date:20170912

[SSSD] [sssd PR#383][opened] MAN: Add a note about the output of all commands when using domain_resolution_order

2017-09-12 Thread fidencio

   URL: https://github.com/SSSD/sssd/pull/383
Author: fidencio
 Title: #383: MAN: Add a note about the output of all commands when using 
domain_resolution_order
Action: opened

PR body:
"""
As the output of all commands when using domain_resolution_order is
fully-qualified, even when using shortnames, let's add a note in the man
page to make it explicit. Also, let's suggest a possible workaround for
this having the output non fully-qualified.

Signed-off-by: Fabiano Fidêncio 
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/383/head:pr383
git checkout pr383
From 411f6971956d142eba96ff178cf38025826aff82 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= 
Date: Wed, 13 Sep 2017 07:22:12 +0200
Subject: [PATCH] MAN: Add a note about the output of all commands when using
 domain_resolution_order
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As the output of all commands when using domain_resolution_order is
fully-qualified, even when using shortnames, let's add a note in the man
page to make it explicit. Also, let's suggest a possible workaround for
this having the output non fully-qualified.

Signed-off-by: Fabiano Fidêncio 
---
 src/man/sssd.conf.5.xml | 9 +
 1 file changed, 9 insertions(+)

diff --git a/src/man/sssd.conf.5.xml b/src/man/sssd.conf.5.xml
index 9c9bf894f..8757107d0 100644
--- a/src/man/sssd.conf.5.xml
+++ b/src/man/sssd.conf.5.xml
@@ -560,6 +560,15 @@
 in a random order for each parent domain.
 
 
+Note that when this option is set the output
+format of all commands is always
+fully-qualified, even when using short names.
+In case the administrator wants the output not
+fully-qualified, the full_name_format option
+can be used as shown below:
+full_name_format=%1$s
+
+
 Default: Not set
 
 
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

2017-09-12 Thread fidencio

  URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check

fidencio commented:
"""
On Tue, Sep 12, 2017 at 10:49 PM, Jakub Hrozek 
wrote:

> Well, yeah, all our python code should conform to pep8. I sent a PR some
> time ago that tried to reformat the tests but I don't have any time to
> rework it or check for other issues in other files, sorry.
>
> But I like your approach, perhaps the patch could check the files under
> the integration test directory first?
>

Okay. I'll re-work your patch (according to @lslebodn suggestions), re-work
my patch according to your suggestion (on focusing in the integration tests
directory firstly) and re-submit the PR.

Thanks for the feedback.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/379#issuecomment-328985870
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#382][+Accepted] CONFIG: Fix schema for try_inotify

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/382
Title: #382: CONFIG: Fix schema for try_inotify

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#382][-Changes requested] CONFIG: Fix schema for try_inotify

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/382
Title: #382: CONFIG: Fix schema for try_inotify

Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#382][comment] CONFIG: Fix schema for try_inotify

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/382
Title: #382: CONFIG: Fix schema for try_inotify

jhrozek commented:
"""
wrong label, sorry
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/382#issuecomment-328980606
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check

jhrozek commented:
"""
Well, yeah, all our python code should conform to pep8. I sent a PR some time 
ago that tried to reformat the tests but I don't have any time to rework it or 
check for other issues in other files, sorry.

But I like your approach, perhaps the patch could check the files under the 
integration test directory first?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/379#issuecomment-328980181
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

2017-09-12 Thread fidencio

  URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code

fidencio commented:
"""
On Tue, Sep 12, 2017 at 9:36 PM, Jakub Hrozek 
wrote:

> btw there are more warnings on RHEL-6:
>
> cache_req_data.o `test -f 'src/responder/common/cache_req/cache_req_data.c' 
> || echo 
> '/var/lib/jenkins/workspace/ci/label/rhel6/'`src/responder/common/cache_req/cache_req_data.c
> cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ 
> but not for C
> cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ 
> but not for C
> cc1: warnings being treated as errors
> /var/lib/jenkins/workspace/ci/label/rhel6/src/responder/common/cache_req/cache_req_result.c:
>  In function 'cache_req_add_result':
> /var/lib/jenkins/workspace/ci/label/rhel6/src/responder/common/cache_req/cache_req_result.c:35:
>  error: declaration of 'index' shadows a global declaration [-Wshadow]
> /usr/include/string.h:489: error: shadowed declaration is here [-Wshadow]
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
> 
> .
>
This one is covered by PR #371.

In case @lslebodn agrees I can merge PR #371 and PR #377 and then rebase
this PR atop of that one.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/378#issuecomment-328966393
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#382][+Changes requested] CONFIG: Fix schema for try_inotify

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/382
Title: #382: CONFIG: Fix schema for try_inotify

Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#382][comment] CONFIG: Fix schema for try_inotify

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/382
Title: #382: CONFIG: Fix schema for try_inotify

jhrozek commented:
"""
CI passed: http://sssd-ci.XXX:8080/job/ci/7676/
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/382#issuecomment-328961609
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code

jhrozek commented:
"""
btw there are more warnings on RHEL-6:
```
cache_req_data.o `test -f 'src/responder/common/cache_req/cache_req_data.c' || 
echo 
'/var/lib/jenkins/workspace/ci/label/rhel6/'`src/responder/common/cache_req/cache_req_data.c
cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but 
not for C
cc1: warning: command line option "-Wenum-compare" is valid for C++/ObjC++ but 
not for C
cc1: warnings being treated as errors
/var/lib/jenkins/workspace/ci/label/rhel6/src/responder/common/cache_req/cache_req_result.c:
 In function 'cache_req_add_result':
/var/lib/jenkins/workspace/ci/label/rhel6/src/responder/common/cache_req/cache_req_result.c:35:
 error: declaration of 'index' shadows a global declaration [-Wshadow]
/usr/include/string.h:489: error: shadowed declaration is here [-Wshadow]
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/378#issuecomment-328961312
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] Re: kinit on IPA server does not exclusively talk to local KDC

2017-09-12 Thread Sumit Bose

On Tue, Sep 12, 2017 at 03:45:52PM +0200, Lukas Slebodnik wrote:
> ehlo,
> 
> I realized that it might be better to discuss it here rather then in
> pull requests because it seems to be related to two different commits.
> 
> I will describe a test case on master with already created replica on another
> host.
> * kinit as admin
> // create user with dummy password
> * echo $dummypw | ipa user-add $login --first "$firstname" --last "$lastname" 
> \
>--password
> 
> // adding sleep think that first kinit hits slave sometimes and the user 
> is
> // not replicated yet.
> * sleep 2
> * FirstKinitAs $login $dummypw $password
> 
> FirstKinitAs is a bash function which change initial password
> something like: echo -e "$password\n$newpassword\n$newpassword" | kinit -V 
> $username
> 
> Such test works reliably with 1.15.3 and kinit always talk to local master
> (I didn't try to remove sleep 2)
> 
> 
> But situation changed a little bit with git master due to following commits
> IPA: Only generate kdcinfo files on clients
> https://pagure.io/SSSD/sssd/c/a309525cc47da726461aec1f238165c17aade2a6

Do you have the /etc/krb5.conf available from the host where the test
failed. The above patch was written with the assumption that
/etc/krb5.conf on the IPA server points to the server itself as
ipa-server-install creates it:

[realms]
 IPA.DEVEL = {
  kdc = ipa-devel.ipa.devel:88
  master_kdc = ipa-devel.ipa.devel:88
  admin_server = ipa-devel.ipa.devel:749
  default_domain = ipa.devel
  pkinit_anchors = FILE:/etc/ipa/ca.crt
}

Currently I would assume that at least admin_server is missing.

> localauth plugin: change return code of sss_an2ln
> https://pagure.io/SSSD/sssd/c/3f94a979eebd1c9496b49b4e07b7823550dec97e

I'm a bit surprised here because it is not clear to me where during the
test an2ln is used. But if it is the case it might point to an issue at
a different place because the old return code was wrong according to the
documentation of the plugin.

bye,
Sumit

> 
> 
> It is enough to revert just one of these patches and situation is back stable
> 
> BTW failure is not 100% reliable but it happens quite often 40-60% of cases.
> And I think kinit on IPA server should always talk to local KDC unless
> it is down.
> 
> 
> Attaching two logs with KRB5TRACE + SSSD_KRB5_LOCATOR_DEBUG
> 
> LS

> --
> Added user "selfservuser1"
> --
>   User login: selfservuser1
>   First name: first
>   Last name: last
>   Full name: first last
>   Display name: first last
>   Initials: fl
>   Home directory: /home/selfservuser1
>   GECOS: first last
>   Login shell: /bin/sh
>   Principal name: selfservus...@testrelm.test
>   Principal alias: selfservus...@testrelm.test
>   Email address: selfservus...@testrelm.test
>   UID: 1739200021
>   GID: 1739200021
>   Password: True
>   Member of groups: ipausers
>   Kerberos keys available: True
> :: [   PASS   ] :: add test user account (Expected 0, got 0)
> :: [  BEGIN   ] :: Running 'FirstKinitAs selfservuser1 dummy...@ipa.com 
> passw0rd1'
> [2008] 1504979429.356684: Destroying ccache KEYRING:persistent:0:0
> Using default cache: persistent:0:0
> Using principal: selfservus...@testrelm.test
> [2010] 1504979429.362816: Getting initial credentials for 
> selfservus...@testrelm.test
> [2010] 1504979429.364886: Sending request (183 bytes) to TESTRELM.TEST
> [sssd_krb5_locator] sssd_krb5_locator_init called
> [sssd_krb5_locator] Found [10.19.41.54] in 
> [/var/lib/sss/pubconf/kdcinfo.TESTRELM.TEST].
> [sssd_krb5_locator] sssd_realm[TESTRELM.TEST] requested realm[TESTRELM.TEST] 
> family[0] socktype[2] locate_service[1]
> [sssd_krb5_locator] addr[10.19.41.54:88] family[2] socktype[2]
> [sssd_krb5_locator] [10.19.41.54] used
> [sssd_krb5_locator] sssd_realm[TESTRELM.TEST] requested realm[TESTRELM.TEST] 
> family[0] socktype[1] locate_service[1]
> [sssd_krb5_locator] addr[10.19.41.54:88] family[2] socktype[1]
> [sssd_krb5_locator] [10.19.41.54] used
> [sssd_krb5_locator] sssd_krb5_locator_close called
> [2010] 1504979429.365050: Initiating TCP connection to stream 10.19.41.54:88
> [2010] 1504979429.365114: Sending TCP request to stream 10.19.41.54:88
> [2010] 1504979429.366775: Received answer (186 bytes) from stream 
> 10.19.41.54:88
> [2010] 1504979429.366783: Terminating TCP connection to stream 10.19.41.54:88
> [sssd_krb5_locator] sssd_krb5_locator_init called
> [sssd_krb5_locator] Found [10.19.41.54] in 
> [/var/lib/sss/pubconf/kdcinfo.TESTRELM.TEST].
> [sssd_krb5_locator] open failed 
> [/var/lib/sss/pubconf/kpasswdinfo.TESTRELM.TEST][2][No such file or 
> directory].
> [sssd_krb5_locator] reading kpasswd address failed, using kdc address.
> [sssd_krb5_locator] sssd_realm[TESTRELM.TEST] requested realm[TESTRELM.TEST] 
> family[0] socktype[1] locate_service[2]
> [sssd_krb5_locator] addr[10.19.41.54:88] family[2] socktype[1]
> [sssd_krb5_locator] [10.19.41.54] used
> [sssd_krb5_locator]

[SSSD] kinit on IPA server does not exclusively talk to local KDC

2017-09-12 Thread Lukas Slebodnik

ehlo,

I realized that it might be better to discuss it here rather then in
pull requests because it seems to be related to two different commits.

I will describe a test case on master with already created replica on another
host.
* kinit as admin
// create user with dummy password
* echo $dummypw | ipa user-add $login --first "$firstname" --last "$lastname" \
   --password

// adding sleep think that first kinit hits slave sometimes and the user is
// not replicated yet.
* sleep 2
* FirstKinitAs $login $dummypw $password

FirstKinitAs is a bash function which change initial password
something like: echo -e "$password\n$newpassword\n$newpassword" | kinit -V 
$username

Such test works reliably with 1.15.3 and kinit always talk to local master
(I didn't try to remove sleep 2)


But situation changed a little bit with git master due to following commits
IPA: Only generate kdcinfo files on clients
https://pagure.io/SSSD/sssd/c/a309525cc47da726461aec1f238165c17aade2a6
localauth plugin: change return code of sss_an2ln
https://pagure.io/SSSD/sssd/c/3f94a979eebd1c9496b49b4e07b7823550dec97e


It is enough to revert just one of these patches and situation is back stable

BTW failure is not 100% reliable but it happens quite often 40-60% of cases.
And I think kinit on IPA server should always talk to local KDC unless
it is down.


Attaching two logs with KRB5TRACE + SSSD_KRB5_LOCATOR_DEBUG

LS
--
Added user "selfservuser1"
--
  User login: selfservuser1
  First name: first
  Last name: last
  Full name: first last
  Display name: first last
  Initials: fl
  Home directory: /home/selfservuser1
  GECOS: first last
  Login shell: /bin/sh
  Principal name: selfservus...@testrelm.test
  Principal alias: selfservus...@testrelm.test
  Email address: selfservus...@testrelm.test
  UID: 1739200021
  GID: 1739200021
  Password: True
  Member of groups: ipausers
  Kerberos keys available: True
:: [   PASS   ] :: add test user account (Expected 0, got 0)
:: [  BEGIN   ] :: Running 'FirstKinitAs selfservuser1 dummy...@ipa.com 
passw0rd1'
[2008] 1504979429.356684: Destroying ccache KEYRING:persistent:0:0
Using default cache: persistent:0:0
Using principal: selfservus...@testrelm.test
[2010] 1504979429.362816: Getting initial credentials for 
selfservus...@testrelm.test
[2010] 1504979429.364886: Sending request (183 bytes) to TESTRELM.TEST
[sssd_krb5_locator] sssd_krb5_locator_init called
[sssd_krb5_locator] Found [10.19.41.54] in 
[/var/lib/sss/pubconf/kdcinfo.TESTRELM.TEST].
[sssd_krb5_locator] sssd_realm[TESTRELM.TEST] requested realm[TESTRELM.TEST] 
family[0] socktype[2] locate_service[1]
[sssd_krb5_locator] addr[10.19.41.54:88] family[2] socktype[2]
[sssd_krb5_locator] [10.19.41.54] used
[sssd_krb5_locator] sssd_realm[TESTRELM.TEST] requested realm[TESTRELM.TEST] 
family[0] socktype[1] locate_service[1]
[sssd_krb5_locator] addr[10.19.41.54:88] family[2] socktype[1]
[sssd_krb5_locator] [10.19.41.54] used
[sssd_krb5_locator] sssd_krb5_locator_close called
[2010] 1504979429.365050: Initiating TCP connection to stream 10.19.41.54:88
[2010] 1504979429.365114: Sending TCP request to stream 10.19.41.54:88
[2010] 1504979429.366775: Received answer (186 bytes) from stream 10.19.41.54:88
[2010] 1504979429.366783: Terminating TCP connection to stream 10.19.41.54:88
[sssd_krb5_locator] sssd_krb5_locator_init called
[sssd_krb5_locator] Found [10.19.41.54] in 
[/var/lib/sss/pubconf/kdcinfo.TESTRELM.TEST].
[sssd_krb5_locator] open failed 
[/var/lib/sss/pubconf/kpasswdinfo.TESTRELM.TEST][2][No such file or directory].
[sssd_krb5_locator] reading kpasswd address failed, using kdc address.
[sssd_krb5_locator] sssd_realm[TESTRELM.TEST] requested realm[TESTRELM.TEST] 
family[0] socktype[1] locate_service[2]
[sssd_krb5_locator] addr[10.19.41.54:88] family[2] socktype[1]
[sssd_krb5_locator] [10.19.41.54] used
[sssd_krb5_locator] sssd_krb5_locator_close called
[2010] 1504979429.366833: Response was from master KDC
[2010] 1504979429.366849: Received error from KDC: -1765328361/Password has 
expired
[2010] 1504979429.366866: Principal expired; getting changepw ticket
[2010] 1504979429.366871: Getting initial credentials for 
selfservus...@testrelm.test
[2010] 1504979429.366885: Setting initial creds service to kadmin/changepw
[2010] 1504979429.366901: Sending request (178 bytes) to TESTRELM.TEST (master)
[sssd_krb5_locator] sssd_krb5_locator_init called
[sssd_krb5_locator] Found [10.19.41.54] in 
[/var/lib/sss/pubconf/kdcinfo.TESTRELM.TEST].
[sssd_krb5_locator] open failed 
[/var/lib/sss/pubconf/kpasswdinfo.TESTRELM.TEST][2][No such file or directory].
[sssd_krb5_locator] reading kpasswd address failed, using kdc address.
[sssd_krb5_locator] sssd_realm[TESTRELM.TEST] requested realm[TESTRELM.TEST] 
family[0] socktype[2] locate_service[2]
[sssd_krb5_locator] addr[10.19.41.54:88] family[2] socktype[2]
[sssd_krb5_locator] [10.19.41.54] used
[sssd_krb5_locator]

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-12 Thread lslebodn

  URL: https://github.com/SSSD/sssd/pull/369
Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef

sumit-bose commented:
"""
>In my test using 'bytes' with python2 and python3 by just removing the #ifdef 
>and >PyModule_AddStringConstant() calls from 
>9375eae59550437c85ada9212be430a4242b25a4 works as well in my testing.

Current solution works as well but it's nicer to get rid of unnecessary 
"#ifdefs"

>After talking with python developers it seems to me that using strings/unicode 
>here is more the python >way of doing things.

Thank you for checking it with python guys. I was not sure about string/bytes; 
I just wanted to be closer to old python2 behaviour

> It would be possible to force users to only use the constants defined by the 
> module but this would require defining our own class for the keys which imo 
> is too much for this simple use case.  So ACK.

I noticed that we can assign value to `pysss_nss_idmap.SID_KEY`.  But creating 
new class might break old clients. Next time we can consult API of module with 
them :-)

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/369#issuecomment-328540887
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#373][comment] intg: Add sanity tests for pysss_nss_idmap

2017-09-12 Thread lslebodn

  URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap

lslebodn commented:
"""
calling `ldb_add` was replace with python version so we needn't add new 
dependency.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/373#issuecomment-328830995
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#373][-Changes requested] intg: Add sanity tests for pysss_nss_idmap

2017-09-12 Thread lslebodn

  URL: https://github.com/SSSD/sssd/pull/373
Title: #373: intg: Add sanity tests for pysss_nss_idmap

Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#373][synchronized] intg: Add sanity tests for pysss_nss_idmap

2017-09-12 Thread lslebodn

   URL: https://github.com/SSSD/sssd/pull/373
Author: lslebodn
 Title: #373: intg: Add sanity tests for pysss_nss_idmap
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/373/head:pr373
git checkout pr373
From 0f6f1d406a4fcb0d87af8c27904cd6759681dd2c Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Wed, 6 Sep 2017 14:13:00 +0200
Subject: [PATCH 1/7] intg: Fix pep8 warnings in config.py template

intg/bld/src/tests/intg/config.py:5:7: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:6:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:7:15: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:8:12: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:9:10: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:10:8: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:11:9: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:12:13: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:13:9: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:14:12: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:15:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:16:13: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:17:12: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:18:13: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:20:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:21:7: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:22:11: E221 multiple spaces before operator
intg/bld/src/tests/intg/config.py:23:7: E221 multiple spaces before operator

pep8 will prevent reformatting in case of added new options
e.g. 53a4219e2f51cd0443931aa931505bf0b4bf5a45
---
 src/tests/intg/config.py.m4 | 28 ++--
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/tests/intg/config.py.m4 b/src/tests/intg/config.py.m4
index bfbbf030f..20f9ec17a 100644
--- a/src/tests/intg/config.py.m4
+++ b/src/tests/intg/config.py.m4
@@ -2,18 +2,18 @@
 Build configuration variables.
 """
 
-PREFIX  = "prefix"
-SYSCONFDIR  = "sysconfdir"
-NSS_MODULE_DIR  = PREFIX + "/lib"
-SSSDCONFDIR = SYSCONFDIR + "/sssd"
-CONF_PATH   = SSSDCONFDIR + "/sssd.conf"
-DB_PATH = "dbpath"
-PID_PATH= "pidpath"
-PIDFILE_PATH= PID_PATH + "/sssd.pid"
-LOG_PATH= "logpath"
-MCACHE_PATH = "mcpath"
-SECDB_PATH  = "secdbpath"
-LIBEXEC_PATH= "libexecpath"
-RUNSTATEDIR = "runstatedir"
-ABS_BUILDDIR= "abs_builddir"
+PREFIX = "prefix"
+SYSCONFDIR = "sysconfdir"
+NSS_MODULE_DIR = PREFIX + "/lib"
+SSSDCONFDIR = SYSCONFDIR + "/sssd"
+CONF_PATH = SSSDCONFDIR + "/sssd.conf"
+DB_PATH = "dbpath"
+PID_PATH = "pidpath"
+PIDFILE_PATH = PID_PATH + "/sssd.pid"
+LOG_PATH = "logpath"
+MCACHE_PATH = "mcpath"
+SECDB_PATH = "secdbpath"
+LIBEXEC_PATH = "libexecpath"
+RUNSTATEDIR = "runstatedir"
+ABS_BUILDDIR = "abs_builddir"
 SESSION_RECORDING_SHELL = "session_recording_shell"

From bf5e77b15575ad6d751e11f49897656533b11db8 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Sat, 21 May 2016 22:44:08 +0200
Subject: [PATCH 2/7] intg: Let python paths be configurable

It will allow to prefer locally built python modules
in integration tests.
---
 src/tests/intg/Makefile.am  | 4 
 src/tests/intg/config.py.m4 | 4 
 2 files changed, 8 insertions(+)

diff --git a/src/tests/intg/Makefile.am b/src/tests/intg/Makefile.am
index abf6237fc..d25d94466 100644
--- a/src/tests/intg/Makefile.am
+++ b/src/tests/intg/Makefile.am
@@ -44,6 +44,10 @@ config.py: config.py.m4
 	   -D "runstatedir=\`$(runstatedir)'" \
 	   -D "abs_builddir=\`$(abs_builddir)'" \
 	   -D "session_recording_shell=\`$(session_recording_shell)'" \
+	   -D "py2execdir=\`$(py2execdir)'" \
+	   -D "py3execdir=\`$(py3execdir)'" \
+	   -D "python2dir=\`$(python2dir)'" \
+	   -D "python3dir=\`$(python3dir)'" \
 	   $< > $@
 
 root:
diff --git a/src/tests/intg/config.py.m4 b/src/tests/intg/config.py.m4
index 20f9ec17a..6e011b692 100644
--- a/src/tests/intg/config.py.m4
+++ b/src/tests/intg/config.py.m4
@@ -17,3 +17,7 @@ LIBEXEC_PATH = "libexecpath"
 RUNSTATEDIR = "runstatedir"
 ABS_BUILDDIR = "abs_builddir"
 SESSION_RECORDING_SHELL = "session_recording_shell"
+PY2EXECDIR = "py2execdir"
+PY2DIR = "python2dir"
+PY3EXECDIR = "py3execdir"
+PY3DIR = "python3dir"

From ec6b01f0f0c9f60b6fc66a6f56f835142b9e030b Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Wed, 18 May 2016 21:00:27 +0200
Subject: [PATCH 3/7] intg: prevent "TypeError: must be type, not classobj"

[SSSD] [sssd PR#369][+Accepted] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-12 Thread fidencio

  URL: https://github.com/SSSD/sssd/pull/369
Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

2017-09-12 Thread fidencio

  URL: https://github.com/SSSD/sssd/pull/369
Title: #369: pysss_nss_idmap: remove unnecessary python2/3 ifdef

fidencio commented:
"""
Adding the "Accepted" label as per @sumit-bose's review.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/369#issuecomment-328824338
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

2017-09-12 Thread fidencio

  URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code

fidencio commented:
"""
Okay. I'll re-work this PR.

About merging this PR and the #371, I'm okay with that. But I'd prefer dropping 
the patches from there than from here (as those patches here are at least 6 
months older than that ones).
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/378#issuecomment-328812923
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

2017-09-12 Thread fidencio

  URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check

fidencio commented:
"""
It's not going to work, @jhrozek. We have .py files in a few different places 
than in our tests and those will have to be fixed as well in case this PR is 
desired.

Another option would be to just check or tests (then I'd have to modify this PR 
a little bit).

So, those are the things that I'm not sure what would be the desired approach 
for the project.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/379#issuecomment-328812578
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

2017-09-12 Thread mzidek-rh

  URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code

mzidek-rh commented:
"""
I did not review all the patches, but I do not like the removal of the INI 
warning. I guess we can not treat warnings as errors for all platforms. It is 
easy to forget that you need new ding-libs for some of the features to work 
properly in SSSD and if someone compiles the code for EL6 (scratch builds) this 
warning is a valuable piece of information. I explicitly grep for it when do 
some scratch builds to verify if the new ding-libs was available during compile 
time (not just run time).
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/378#issuecomment-328810902
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check

jhrozek commented:
"""
Well, I applied the patch on top of the old pep8 PR and submitted to CI, let's 
see what results we get.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/379#issuecomment-328801790
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#372][-Changes requested] ldap: Change ldap_user_certificate to userCertificate; binary

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/372
Title: #372: ldap: Change ldap_user_certificate to userCertificate;binary

Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check

jhrozek commented:
"""
(Then it would make sense to resubmit both in the same PR)
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/379#issuecomment-328801865
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code

jhrozek commented:
"""
btw as I said in PR #371 since there are fixes developed independently, maybe 
the patches that are also included from PR #371 should be dropped from this PR 
so that we can merge both.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/378#issuecomment-328801163
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#378][+Changes requested] [RFC] Use GNULIB's compiler warning code

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code

Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/378
Title: #378: [RFC] Use GNULIB's compiler warning code

jhrozek commented:
"""
I'm seeing a build failure with these patches on my machine:
```
/home/remote/jhrozek/devel/sssd/src/util/crypto/nss/nss_sha512crypt.c: In 
function ‘sha512_crypt_r’:
/home/remote/jhrozek/devel/sssd/src/util/crypto/nss/nss_sha512crypt.c:71:12: 
error: stack protector not protecting local variables: variable length buffer 
[-Werror=stack-protector]
 static int sha512_crypt_r(const char *key,
^~
cc1: all warnings being treated as errors
Makefile:17864: recipe for target 
'src/util/crypto/nss/libsss_crypt_la-nss_sha512crypt.lo' failed
```
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/378#issuecomment-328800775
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#380][comment] CI: Use dnf 2.0 for installation of packages in fedora

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/380
Title: #380: CI: Use dnf 2.0 for installation of packages in fedora

jhrozek commented:
"""
* master: 51c4da6e4941dfc5fca40bffa2248b9a77f139b2
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/380#issuecomment-328798347
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#381][closed] SPEC: Update owner and mode for /var/lib/sss/deskprofile

2017-09-12 Thread jhrozek

   URL: https://github.com/SSSD/sssd/pull/381
Author: lslebodn
 Title: #381: SPEC: Update owner and mode for /var/lib/sss/deskprofile
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/381/head:pr381
git checkout pr381
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#381][+Pushed] SPEC: Update owner and mode for /var/lib/sss/deskprofile

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/381
Title: #381: SPEC: Update owner and mode for /var/lib/sss/deskprofile

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#380][+Pushed] CI: Use dnf 2.0 for installation of packages in fedora

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/380
Title: #380: CI: Use dnf 2.0 for installation of packages in fedora

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#380][closed] CI: Use dnf 2.0 for installation of packages in fedora

2017-09-12 Thread jhrozek

   URL: https://github.com/SSSD/sssd/pull/380
Author: lslebodn
 Title: #380: CI: Use dnf 2.0 for installation of packages in fedora
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/380/head:pr380
git checkout pr380
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#381][comment] SPEC: Update owner and mode for /var/lib/sss/deskprofile

2017-09-12 Thread jhrozek

  URL: https://github.com/SSSD/sssd/pull/381
Title: #381: SPEC: Update owner and mode for /var/lib/sss/deskprofile

jhrozek commented:
"""
* master: f5d446da1a2874f699e4e7566f6c3f36a950
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/381#issuecomment-328798269
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#382][opened] CONFIG: Fix schema for try_inotify

2017-09-12 Thread lslebodn

   URL: https://github.com/SSSD/sssd/pull/382
Author: lslebodn
 Title: #382: CONFIG: Fix schema for try_inotify
Action: opened

PR body:
"""
It is read only from "[sssd]" section.

Resolves:
https://pagure.io/SSSD/sssd/issue/3511
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/382/head:pr382
git checkout pr382
From bee93efd7ebb11d3da6c08fde7ea470ff6047e55 Mon Sep 17 00:00:00 2001
From: Lukas Slebodnik 
Date: Tue, 12 Sep 2017 10:45:16 +0200
Subject: [PATCH] CONFIG: Fix schema for try_inotify

It is read only from "[sssd]" section.

Resolves:
https://pagure.io/SSSD/sssd/issue/3511
---
 src/config/SSSDConfigTest.py | 6 +++---
 src/config/cfg_rules.ini | 2 +-
 src/config/etc/sssd.api.conf | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/config/SSSDConfigTest.py b/src/config/SSSDConfigTest.py
index d0e97f02b..4a583bdd3 100755
--- a/src/config/SSSDConfigTest.py
+++ b/src/config/SSSDConfigTest.py
@@ -371,7 +371,9 @@ def testListOptions(self):
 'override_space',
 'disable_netlink',
 'enable_files_domain',
-'domain_resolution_order']
+'domain_resolution_order',
+'try_inotify',
+]
 
 self.assertTrue(type(options) == dict,
 "Options should be a dictionary")
@@ -567,7 +569,6 @@ def testListOptions(self):
 'max_id',
 'timeout',
 'offline_timeout',
-'try_inotify',
 'command',
 'enumerate',
 'cache_credentials',
@@ -938,7 +939,6 @@ def testRemoveProvider(self):
 'max_id',
 'timeout',
 'offline_timeout',
-'try_inotify',
 'command',
 'enumerate',
 'cache_credentials',
diff --git a/src/config/cfg_rules.ini b/src/config/cfg_rules.ini
index 3e4ce4673..f3d30b9b3 100644
--- a/src/config/cfg_rules.ini
+++ b/src/config/cfg_rules.ini
@@ -50,6 +50,7 @@ option = config_file_version
 option = disable_netlink
 option = enable_files_domain
 option = domain_resolution_order
+option = try_inotify
 
 [rule/allowed_nss_options]
 validator = ini_allowed_options
@@ -349,7 +350,6 @@ option = domain_type
 option = min_id
 option = max_id
 option = timeout
-option = try_inotify
 option = enumerate
 option = subdomain_enumerate
 option = offline_timeout
diff --git a/src/config/etc/sssd.api.conf b/src/config/etc/sssd.api.conf
index 792c42a1f..7f2b8977b 100644
--- a/src/config/etc/sssd.api.conf
+++ b/src/config/etc/sssd.api.conf
@@ -33,6 +33,7 @@ override_space = str, None, false
 disable_netlink = bool, None, false
 enable_files_domain = str, None, false
 domain_resolution_order = list, str, false
+try_inotify = bool, None, false
 
 [nss]
 # Name service
@@ -153,7 +154,6 @@ command = str, None, false
 min_id = int, None, false
 max_id = int, None, false
 timeout = int, None, false
-try_inotify = bool, None, false
 enumerate = bool, None, false
 subdomain_enumerate = str, None, false
 offline_timeout = int, None, false
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#383][opened] MAN: Add a note about the output of all commands when using domain_resolution_order

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

[SSSD] [sssd PR#382][+Accepted] CONFIG: Fix schema for try_inotify

[SSSD] [sssd PR#382][-Changes requested] CONFIG: Fix schema for try_inotify

[SSSD] [sssd PR#382][comment] CONFIG: Fix schema for try_inotify

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

[SSSD] [sssd PR#382][+Changes requested] CONFIG: Fix schema for try_inotify

[SSSD] [sssd PR#382][comment] CONFIG: Fix schema for try_inotify

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

[SSSD] Re: kinit on IPA server does not exclusively talk to local KDC

[SSSD] kinit on IPA server does not exclusively talk to local KDC

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

[SSSD] [sssd PR#373][comment] intg: Add sanity tests for pysss_nss_idmap

[SSSD] [sssd PR#373][-Changes requested] intg: Add sanity tests for pysss_nss_idmap

[SSSD] [sssd PR#373][synchronized] intg: Add sanity tests for pysss_nss_idmap

[SSSD] [sssd PR#369][+Accepted] pysss_nss_idmap: remove unnecessary python2/3 ifdef

[SSSD] [sssd PR#369][comment] pysss_nss_idmap: remove unnecessary python2/3 ifdef

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

[SSSD] [sssd PR#372][-Changes requested] ldap: Change ldap_user_certificate to userCertificate; binary

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

[SSSD] [sssd PR#378][+Changes requested] [RFC] Use GNULIB's compiler warning code

[SSSD] [sssd PR#378][comment] [RFC] Use GNULIB's compiler warning code

[SSSD] [sssd PR#380][comment] CI: Use dnf 2.0 for installation of packages in fedora

[SSSD] [sssd PR#381][closed] SPEC: Update owner and mode for /var/lib/sss/deskprofile

[SSSD] [sssd PR#381][+Pushed] SPEC: Update owner and mode for /var/lib/sss/deskprofile

[SSSD] [sssd PR#380][+Pushed] CI: Use dnf 2.0 for installation of packages in fedora

[SSSD] [sssd PR#380][closed] CI: Use dnf 2.0 for installation of packages in fedora

[SSSD] [sssd PR#381][comment] SPEC: Update owner and mode for /var/lib/sss/deskprofile

[SSSD] [sssd PR#382][opened] CONFIG: Fix schema for try_inotify

34 matches

Site Navigation

Mail list logo

Footer information