[SSSD] [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716 Title: #716: CACHE: SSSD doesn't clear cache entries thalman commented: """ @jhrozek I fixed all minor comments. There is still question whether we move the check as you suggested. """ See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-452335917 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#712][comment] SSSCTL: user-checks does not show custom attributes
URL: https://github.com/SSSD/sssd/pull/712 Title: #712: SSSCTL: user-checks does not show custom attributes thalman commented: """ > But this looks like I haven't gotten to your codepath yet. Did you see the > error locally as well? No, I did not see this error. It worked fine in my testing environment. """ See the full comment at https://github.com/SSSD/sssd/pull/712#issuecomment-452317173 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#716][synchronized] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
From 60237f7f5076e30592f6cd2c1d3ee00482e606b5 Mon Sep 17 00:00:00 2001
From: Tomas Halman
Date: Sun, 16 Dec 2018 08:46:24 +0100
Subject: [PATCH] CACHE: SSSD doesn't clear cache entries
Once object is in cache it is refreshed when it is expired and
requested by the system. Object ID is not checked before refresh,
but config parameter ldap_(min|max)_id could be changed by admin.
We should check object ID and not refresh objects outside min/max
ID interval.
Resolves:
https://pagure.io/SSSD/sssd/issue/3905
---
.../common/cache_req/cache_req_search.c | 61 +--
1 file changed, 57 insertions(+), 4 deletions(-)
diff --git a/src/responder/common/cache_req/cache_req_search.c b/src/responder/common/cache_req/cache_req_search.c
index 7423feb63..c73b526eb 100644
--- a/src/responder/common/cache_req/cache_req_search.c
+++ b/src/responder/common/cache_req/cache_req_search.c
@@ -25,6 +25,7 @@
#include "util/util.h"
#include "responder/common/cache_req/cache_req_private.h"
#include "responder/common/cache_req/cache_req_plugin.h"
+#include "db/sysdb.h"
static errno_t cache_req_search_ncache(struct cache_req *cr)
{
@@ -169,6 +170,51 @@ static errno_t cache_req_search_ncache_filter(TALLOC_CTX *mem_ctx,
return ret;
}
+static int
+cache_req_should_be_in_cache(struct cache_req *cr,
+ struct ldb_result *result)
+{
+id_t id = 0;
+const char *object_class;
+
+if (result == NULL || result->count == 0) {
+/* can't decide so keep it */
+return EOK;
+}
+
+object_class = ldb_msg_find_attr_as_string(result->msgs[0],
+ SYSDB_OBJECTCATEGORY, NULL);
+if (object_class == NULL) {
+/* no object_class => can't decide so keep it in cache */
+return EOK;
+}
+
+if (strcasecmp(object_class, SYSDB_USER_CLASS) == 0) {
+/* user -> check uid and primary group */
+id = ldb_msg_find_attr_as_uint(result->msgs[0], SYSDB_UIDNUM, 0);
+if (id && OUT_OF_ID_RANGE(id, cr->domain->id_min, cr->domain->id_max)) {
+return ERR_ID_OUTSIDE_RANGE;
+}
+
+id = ldb_msg_find_attr_as_uint(result->msgs[0], SYSDB_GIDNUM, 0);
+if (id && OUT_OF_ID_RANGE(id, cr->domain->id_min, cr->domain->id_max)) {
+return ERR_ID_OUTSIDE_RANGE;
+}
+
+return EOK;
+}
+
+if (strcasecmp(object_class, SYSDB_GROUP_CLASS) == 0) {
+/* group -> check gidNumber */
+id = ldb_msg_find_attr_as_uint(result->msgs[0], SYSDB_GIDNUM, 0);
+if (id && OUT_OF_ID_RANGE(id, cr->domain->id_min, cr->domain->id_max)) {
+return ERR_ID_OUTSIDE_RANGE;
+}
+}
+
+return EOK;
+}
+
static errno_t cache_req_search_cache(TALLOC_CTX *mem_ctx,
struct cache_req *cr,
struct ldb_result **_result)
@@ -278,7 +324,7 @@ cache_req_search_send(TALLOC_CTX *mem_ctx,
struct cache_req_search_state *state;
enum cache_object_status status;
struct tevent_req *req;
-errno_t ret;
+errno_t ret, refresh_check;
req = tevent_req_create(mem_ctx, &state, struct cache_req_search_state);
if (req == NULL) {
@@ -325,9 +371,16 @@ cache_req_search_send(TALLOC_CTX *mem_ctx,
* we can return it without searching the rest of the domains.
*/
if (status != CACHE_OBJECT_MISSING) {
-CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr,
-"Object found, but needs to be refreshed.\n");
-bypass_dp = false;
+refresh_check = cache_req_should_be_in_cache(cr, state->result);
+if (refresh_check == EOK) {
+CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr,
+"Object found, but needs to be refreshed.\n");
+bypass_dp = false;
+} else {
+CACHE_REQ_DEBUG(SSSDBG_TRACE_FUNC, cr,
+"Object found, but should not be in cache.\n");
+ret = refresh_check;
+}
} else {
ret = ENOENT;
}
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#726][-Blocked] TESTS: Add a simple integration test for retrieving the extraAttributes property
URL: https://github.com/SSSD/sssd/pull/726 Title: #726: TESTS: Add a simple integration test for retrieving the extraAttributes property Label: -Blocked ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#726][comment] TESTS: Add a simple integration test for retrieving the extraAttributes property
URL: https://github.com/SSSD/sssd/pull/726 Title: #726: TESTS: Add a simple integration test for retrieving the extraAttributes property jhrozek commented: """ Ah, sorry, there were some pep8 errors in the test. Should work now. """ See the full comment at https://github.com/SSSD/sssd/pull/726#issuecomment-452305308 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#726][synchronized] TESTS: Add a simple integration test for retrieving the extraAttributes property
URL: https://github.com/SSSD/sssd/pull/726
Author: jhrozek
Title: #726: TESTS: Add a simple integration test for retrieving the
extraAttributes property
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/726/head:pr726
git checkout pr726
From c02dd62ed79d10008193ff91cec03ac2928aee15 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek
Date: Fri, 4 Jan 2019 15:26:02 +0100
Subject: [PATCH] TESTS: Add a simple integration test for retrieving the
extraAttributes property
Related:
https://pagure.io/SSSD/sssd/issue/3906
---
src/tests/intg/test_infopipe.py | 31 +++
src/tests/multihost/basic/test_ifp.py | 28
2 files changed, 59 insertions(+)
create mode 100644 src/tests/multihost/basic/test_ifp.py
diff --git a/src/tests/intg/test_infopipe.py b/src/tests/intg/test_infopipe.py
index 6c316628b..9d575e675 100644
--- a/src/tests/intg/test_infopipe.py
+++ b/src/tests/intg/test_infopipe.py
@@ -207,12 +207,14 @@ def format_basic_conf(ldap_conn, schema):
# problem with "ifp" + client regristration in monitor
# There is not such problem in 1st test. Just in following tests.
command = {ifp_command} --uid 0 --gid 0 --debug-to-files
+user_attributes = +extraName
[domain/LDAP]
{schema_conf}
id_provider = ldap
ldap_uri= {ldap_conn.ds_inst.ldap_url}
ldap_search_base= {ldap_conn.ds_inst.base_dn}
+ldap_user_extra_attrs = extraName:uid
[application/app]
inherit_from = LDAP
@@ -534,6 +536,35 @@ def test_get_user_groups(dbus_system_bus, ldap_conn, sanity_rfc2307):
assert sorted(res) == ['single_user_group', 'two_user_group']
+def get_user_property(dbus_system_bus, username, prop_name):
+users_obj = dbus_system_bus.get_object(
+'org.freedesktop.sssd.infopipe',
+'/org/freedesktop/sssd/infopipe/Users')
+
+users_iface = dbus.Interface(users_obj,
+ "org.freedesktop.sssd.infopipe.Users")
+
+user_path = users_iface.FindByName(username)
+user_object = dbus_system_bus.get_object('org.freedesktop.sssd.infopipe',
+ user_path)
+
+prop_iface = dbus.Interface(user_object, 'org.freedesktop.DBus.Properties')
+return prop_iface.Get('org.freedesktop.sssd.infopipe.Users.User',
+ prop_name)
+
+
+def test_get_extra_attributes_empty(dbus_system_bus,
+ldap_conn,
+sanity_rfc2307):
+"""
+Make sure the extraAttributes property can be retrieved
+"""
+extra_attrs = get_user_property(dbus_system_bus,
+'user1',
+'extraAttributes')
+assert extra_attrs['extraName'][0] == 'user1'
+
+
def test_sssctl_domain_list_app_domain(dbus_system_bus,
ldap_conn,
sanity_rfc2307):
diff --git a/src/tests/multihost/basic/test_ifp.py b/src/tests/multihost/basic/test_ifp.py
new file mode 100644
index 0..108169de2
--- /dev/null
+++ b/src/tests/multihost/basic/test_ifp.py
@@ -0,0 +1,28 @@
+"""
+InfoPipe test cases
+"""
+
+import pytest
+from sssd.testlib.common.utils import SSHClient
+
+
+class TestInfoPipe(object):
+"""
+Test the InfoPipe responder
+"""
+def test_ifp_extra_attributes_property(self, multihost):
+"""
+Test requesting the extraAttributes property works at all,
+see e.g. https://pagure.io/SSSD/sssd/issue/3906
+"""
+dbus_send_cmd = \
+"""
+dbus-send --print-reply --system \
+--dest=org.freedesktop.sssd.infopipe \
+/org/freedesktop/sssd/infopipe/Users/LDAP_2eTEST/123 \
+org.freedesktop.DBus.Properties.Get \
+string:"org.freedesktop.sssd.infopipe.Users.User" \
+string:"extraAttributes"
+"""
+cmd = multihost.master[0].run_command(dbus_send_cmd)
+assert cmd.returncode == 0
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#723][+Accepted] MAN: Explicitly state that not all generic domain options are supported for the files provider
URL: https://github.com/SSSD/sssd/pull/723 Title: #723: MAN: Explicitly state that not all generic domain options are supported for the files provider Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#728][comment] ci: add Fedora 29
URL: https://github.com/SSSD/sssd/pull/728 Title: #728: ci: add Fedora 29 jhrozek commented: """ scan.coverity.com uses an invalid certificate. It's issued for misc.synopsys.com and a couple of other strange sites using the subjectAltName, but none of them matches scan.coverity.com I suggest we disable the travisCI coverity integration for the time being. We can also use incecure checks, but.. """ See the full comment at https://github.com/SSSD/sssd/pull/728#issuecomment-452288921 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716 Title: #716: CACHE: SSSD doesn't clear cache entries jhrozek commented: """ I think this commit is mostly good. I'll just leave some very minor nitpics inline using the github review tool. """ See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-452284643 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#712][comment] SSSCTL: user-checks does not show custom attributes
URL: https://github.com/SSSD/sssd/pull/712 Title: #712: SSSCTL: user-checks does not show custom attributes jhrozek commented: """ I'm getting a crash when testing this code: ``` #0 0x7fdfcaefaeab in raise () from /lib64/libc.so.6 #1 0x7fdfcaee55b9 in abort () from /lib64/libc.so.6 #2 0x7fdfcb5a9aad in _dbus_abort.cold.0 () from /lib64/libdbus-1.so.3 #3 0x7fdfcb5cbef0 in _dbus_warn_check_failed () from /lib64/libdbus-1.so.3 #4 0x7fdfcb5bd7ef in dbus_message_iter_open_container () from /lib64/libdbus-1.so.3 #5 0x7fdfcbe38f47 in sbus_copy_iterator_container (from=0x7ffc535c9490, to=0x7ffc535c94e0, type=101) at /sssd/src/sbus/interface/sbus_properties.c:190 #6 0x7fdfcbe390e1 in sbus_copy_iterator_value (from=0x7ffc535c9490, to=0x7ffc535c94e0) at /sssd/src/sbus/interface/sbus_properties.c:264 #7 0x7fdfcbe38f76 in sbus_copy_iterator_container (from=0x7ffc535c95b0, to=0x7ffc535c9600, type=97) at /sssd/src/sbus/interface/sbus_properties.c:195 #8 0x7fdfcbe390e1 in sbus_copy_iterator_value (from=0x7ffc535c95b0, to=0x7ffc535c9600) at /sssd/src/sbus/interface/sbus_properties.c:264 #9 0x7fdfcbe38f76 in sbus_copy_iterator_container (from=0x7ffc535c9720, to=0x7ffc535c96d0, type=118) at /sssd/src/sbus/interface/sbus_properties.c:195 #10 0x7fdfcbe390e1 in sbus_copy_iterator_value (from=0x7ffc535c9720, to=0x7ffc535c96d0) at /sssd/src/sbus/interface/sbus_properties.c:264 #11 0x7fdfcbe3923a in sbus_copy_message_to_dictionary (name=0x7fdfcc2981db "extraAttributes", msg=0x1822c90, to=0x1831828) at /sssd/src/sbus/interface/sbus_properties.c:308 #12 0x7fdfcbe39e82 in sbus_properties_getall_done (subreq=0x0) at /sssd/src/sbus/interface/sbus_properties.c:658 #13 0x7fdfcbe398ea in sbus_properties_get_done (subreq=0x0) at /sssd/src/sbus/interface/sbus_properties.c:489 #14 0x7fdfcc2896fe in _sbus_ifp_invoke_in__out_ifp_extra_step (ev=0x17f3900, te=0x182a5f0, tv=..., private_data=0x182a3b0) at /sssd/src/responder/ifp/ifp_iface/sbus_ifp_invokers.c:852 #15 0x7fdfcba0a785 in tevent_common_loop_timer_delay (ev=ev@entry=0x17f3900) at ../tevent_timed.c:369 #16 0x7fdfcba0b87b in epoll_event_loop_once (ev=0x17f3900, location=) at ../tevent_epoll.c:915 #17 0x7fdfcba09dab in std_event_loop_once (ev=0x17f3900, location=0x7fdfceb9c3bd "/sssd/src/util/server.c:724") at ../tevent_standard.c:114 #18 0x7fdfcba06098 in _tevent_loop_once (ev=ev@entry=0x17f3900, location=location@entry=0x7fdfceb9c3bd "/sssd/src/util/server.c:724") at ../tevent.c:725 #19 0x7fdfcba062eb in tevent_common_loop_wait (ev=0x17f3900, ---Type to continue, or q to quit--- location=0x7fdfceb9c3bd "/sssd/src/util/server.c:724") at ../tevent.c:848 #20 0x7fdfcba09d3b in std_event_loop_wait (ev=0x17f3900, location=0x7fdfceb9c3bd "/sssd/src/util/server.c:724") at ../tevent_standard.c:145 #21 0x7fdfceb72593 in server_loop (main_ctx=0x17f4d90) at /sssd/src/util/server.c:724 #22 0x00408d59 in main (argc=6, argv=0x7ffc535c9d18) at /sssd/src/responder/ifp/ifpsrv.c:361 ``` But this looks like I haven't gotten to your codepath yet. Did you see the error locally as well? """ See the full comment at https://github.com/SSSD/sssd/pull/712#issuecomment-452282273 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#728][comment] ci: add Fedora 29
URL: https://github.com/SSSD/sssd/pull/728 Title: #728: ci: add Fedora 29 pbrezina commented: """ I have no idea why the travis ci failed. """ See the full comment at https://github.com/SSSD/sssd/pull/728#issuecomment-452281320 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#723][synchronized] MAN: Explicitly state that not all generic domain options are supported for the files provider
URL: https://github.com/SSSD/sssd/pull/723 Author: jhrozek Title: #723: MAN: Explicitly state that not all generic domain options are supported for the files provider Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/723/head:pr723 git checkout pr723 From 91f8237e8fbbc5f098c2f29261ca70751e9de279 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Thu, 3 Jan 2019 15:32:26 +0100 Subject: [PATCH] MAN: Explicitly state that not all generic domain options are supported for the files provider Resolves: https://pagure.io/SSSD/sssd/issue/3882 --- src/man/sssd-files.5.xml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/man/sssd-files.5.xml b/src/man/sssd-files.5.xml index 067e21949..34b107965 100644 --- a/src/man/sssd-files.5.xml +++ b/src/man/sssd-files.5.xml @@ -84,7 +84,13 @@ sssd.conf 5 manual page for details on the configuration -of an SSSD domain. +of an SSSD domain. But the purpose of the files provider is +to expose the same data as the UNIX files, just through the +SSSD interfaces. Therefore not all generic domain options are +supported. Likewise, some global options, such as overriding +the shell in the nss section for all domains +has no effect on the files domain unless explicitly specified +per-domain. passwd_files (string) ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#723][-Changes requested] MAN: Explicitly state that not all generic domain options are supported for the files provider
URL: https://github.com/SSSD/sssd/pull/723 Title: #723: MAN: Explicitly state that not all generic domain options are supported for the files provider Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#722][+Accepted] KCM: Deleting a non-existent ccache should not yield an error
URL: https://github.com/SSSD/sssd/pull/722 Title: #722: KCM: Deleting a non-existent ccache should not yield an error Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#722][comment] KCM: Deleting a non-existent ccache should not yield an error
URL: https://github.com/SSSD/sssd/pull/722 Title: #722: KCM: Deleting a non-existent ccache should not yield an error thalman commented: """ LGTM, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/722#issuecomment-452259179 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#728][opened] ci: add Fedora 29
URL: https://github.com/SSSD/sssd/pull/728
Author: pbrezina
Title: #728: ci: add Fedora 29
Action: opened
PR body:
"""
I pushed Fedora 29 machines into [1] vagrant cloud. This patch
enables testing on this distro in our CI.
[1] https://app.vagrantup.com/sssd-vagrant/
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/728/head:pr728
git checkout pr728
From bf77af3e1cfe0aac4010b5d7ed5e98f0b561905f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?=
Date: Tue, 8 Jan 2019 11:43:46 +0100
Subject: [PATCH] ci: add Fedora 29
Enables testing on Fedora 29 distro.
---
Jenkinsfile | 26 ++
1 file changed, 26 insertions(+)
diff --git a/Jenkinsfile b/Jenkinsfile
index 8dcb617f5..c25a556ab 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -66,6 +66,32 @@ pipeline {
}
}
}
+stage('Test on Fedora 29') {
+ agent {label "sssd-ci"}
+ environment {
+TEST_SYSTEM = "fedora29"
+GH_CONTEXT = "$GH_CONTEXT/fedora29"
+GH_URL = "$AWS_BASE/$BRANCH_NAME/$BUILD_ID/$TEST_SYSTEM/index.html"
+CONFIG = "$BASE_DIR/configs/${TEST_SYSTEM}.json"
+ }
+ steps {
+githubNotify status: 'PENDING', context: "$GH_CONTEXT", description: "$GH_PENDING", targetUrl: "$GH_URL"
+sh '$RUN "$WORKSPACE/sssd" "$SUITE_DIR" "$WORKSPACE/artifacts/$TEST_SYSTEM" "$CONFIG"'
+ }
+ post {
+always {
+ archiveArtifacts artifacts: "artifacts/**", allowEmptyArchive: true
+ sh '$ARCHIVE $TEST_SYSTEM $WORKSPACE/artifacts/$TEST_SYSTEM $NAME'
+ sh 'rm -fr "$WORKSPACE/artifacts/$TEST_SYSTEM"'
+}
+failure {
+ githubNotify status: 'FAILURE', context: "$GH_CONTEXT", description: "$GH_FAILURE", targetUrl: "$GH_URL"
+}
+success {
+ githubNotify status: 'SUCCESS', context: "$GH_CONTEXT", description: "$GH_SUCCESS", targetUrl: "$GH_URL"
+}
+ }
+}
}
}
}
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#715][+Pushed] Use 120 second default timeout for dbus (#1654537)
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537) Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#715][comment] Use 120 second default timeout for dbus (#1654537)
URL: https://github.com/SSSD/sssd/pull/715 Title: #715: Use 120 second default timeout for dbus (#1654537) jhrozek commented: """ Oops, this was pushed already, I just forgot to close the PR. Master: e4469fbdb3d5c53294c6514280ac75b847b3c61c """ See the full comment at https://github.com/SSSD/sssd/pull/715#issuecomment-452252594 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#715][closed] Use 120 second default timeout for dbus (#1654537)
URL: https://github.com/SSSD/sssd/pull/715 Author: AdamWill Title: #715: Use 120 second default timeout for dbus (#1654537) Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/715/head:pr715 git checkout pr715 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#726][comment] TESTS: Add a simple integration test for retrieving the extraAttributes property
URL: https://github.com/SSSD/sssd/pull/726 Title: #726: TESTS: Add a simple integration test for retrieving the extraAttributes property jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/726#issuecomment-452213696 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
