[SSSD] [sssd PR#5303][comment] tests: run TIER-0 multihost tests in PRCI
URL: https://github.com/SSSD/sssd/pull/5303 Title: #5303: tests: run TIER-0 multihost tests in PRCI mrniranjan commented: """ @pbrezina is it possible to get rpms so that i can install and run failing tests individually to debug the issue. """ See the full comment at https://github.com/SSSD/sssd/pull/5303#issuecomment-688648864 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5226][+Changes requested] python/pysss_nss_idmap: check return from functions
URL: https://github.com/SSSD/sssd/pull/5226 Title: #5226: python/pysss_nss_idmap: check return from functions Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5226][-Waiting for review] python/pysss_nss_idmap: check return from functions
URL: https://github.com/SSSD/sssd/pull/5226 Title: #5226: python/pysss_nss_idmap: check return from functions Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5226][comment] python/pysss_nss_idmap: check return from functions
URL: https://github.com/SSSD/sssd/pull/5226 Title: #5226: python/pysss_nss_idmap: check return from functions alexey-tikhonov commented: """ Thanks for the update. Please see comment inline. Btw, wouldn't it make sense to include `Py_DECREF(module);` (actually better `Py_XDECREF`) into `MODINITERROR`? """ See the full comment at https://github.com/SSSD/sssd/pull/5226#issuecomment-688432755 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5245][comment] RESOLV: Avoid DNS search to improve fail-over reaction
URL: https://github.com/SSSD/sssd/pull/5245 Title: #5245: RESOLV: Avoid DNS search to improve fail-over reaction sumit-bose commented: """ > Suggested solution with "." lookup is still possible but this one is more > simple, elegant and consistent. > > I would rather see a new option "perform_dns_search" which will give as the > possibility to keep old behaviour rather than to do the trailing dot. > > I also think there will be very few installation where admins depends on > domain search. Maybe some testing installation. Hi, I agree, but `perform_dns_search` sounds misleading, I would suggestion something like `dns_resolver_use_default_search_domains'. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5245#issuecomment-688367440 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5272][comment] IFP: GetUserGroups() returns origPrimaryGroupGidNumber
URL: https://github.com/SSSD/sssd/pull/5272 Title: #5272: IFP: GetUserGroups() returns origPrimaryGroupGidNumber ikerexxe commented: """ CI failures are not related with the change itself. """ See the full comment at https://github.com/SSSD/sssd/pull/5272#issuecomment-688364832 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5245][comment] RESOLV: Avoid DNS search to improve fail-over reaction
URL: https://github.com/SSSD/sssd/pull/5245 Title: #5245: RESOLV: Avoid DNS search to improve fail-over reaction thalman commented: """ Suggested solution with "." lookup is still possible but this one is more simple, elegant and consistent. I would rather see a new option "perform_dns_search" which will give as the possibility to keep old behaviour rather than to do the trailing dot. I also think there will be very few installation where admins depends on domain search. Maybe some testing installation. """ See the full comment at https://github.com/SSSD/sssd/pull/5245#issuecomment-688313575 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5299][comment] dp: fix potential race condition in provider's sbus server
URL: https://github.com/SSSD/sssd/pull/5299 Title: #5299: dp: fix potential race condition in provider's sbus server alexey-tikhonov commented: """ > Yes. The problem was that backend did not send its id registration in time. > It is not supposed to register to itself but the new connection callback is > not set before the backend connect to the server so dp_cli is created for it > as well. Wouldn't it be better to skip creation of `dp_cli` (and setting up timer) right in `dp_client_init()`? """ See the full comment at https://github.com/SSSD/sssd/pull/5299#issuecomment-688308170 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5262][comment] DN with white spaces
URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces alexey-tikhonov commented: """ That would be great. Removing "accepted" label until test is included. """ See the full comment at https://github.com/SSSD/sssd/pull/5262#issuecomment-688268353 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5262][-Accepted] DN with white spaces
URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5262][comment] DN with white spaces
URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces alexey-tikhonov commented: """ That would be great. """ See the full comment at https://github.com/SSSD/sssd/pull/5262#issuecomment-688268353 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5307][comment] UTIL:utf8: code cleanup
URL: https://github.com/SSSD/sssd/pull/5307 Title: #5307: UTIL:utf8: code cleanup alexey-tikhonov commented: """ While the "form" of those patches might be a topic to discuss, the main point is the following: Originally execution flow was: ``` sss_tc_utf8_str_tolower() -> `sss_tc_utf8_tolower()` + talloc_realloc() -> sss_utf8_tolower() + talloc_memdup() -> g_utf8_strdown() + memcpy() ``` -- i.e. 3 mem alloc/moves. Patch reduces this to 1. """ See the full comment at https://github.com/SSSD/sssd/pull/5307#issuecomment-688264865 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5262][comment] DN with white spaces
URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces sumit-bose commented: """ @alexey-tikhonov, @thalman, I've added a test to https://github.com/sumit-bose/sssd/commits/ghost_hash_dn, maybe you'd like to pull this as well? """ See the full comment at https://github.com/SSSD/sssd/pull/5262#issuecomment-688266601 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5307][comment] UTIL:utf8: code cleanup
URL: https://github.com/SSSD/sssd/pull/5307 Title: #5307: UTIL:utf8: code cleanup alexey-tikhonov commented: """ While the "form" of those patches might be a topic to discuss, the main point is the following: Originally execution flow was: ``` sss_tc_utf8_str_tolower() -> `sss_tc_utf8_tolower()` + talloc_realloc() -> sss_utf8_tolower() + talloc_memdup() -> g_utf8_strdown() + memcpy() ``` -- i.e. 3 mem movements. Patch reduces this to 1. """ See the full comment at https://github.com/SSSD/sssd/pull/5307#issuecomment-688264865 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5226][-Changes requested] python/pysss_nss_idmap: check return from functions
URL: https://github.com/SSSD/sssd/pull/5226 Title: #5226: python/pysss_nss_idmap: check return from functions Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5226][+Waiting for review] python/pysss_nss_idmap: check return from functions
URL: https://github.com/SSSD/sssd/pull/5226 Title: #5226: python/pysss_nss_idmap: check return from functions Label: +Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5307][edited] UTIL:utf8: code cleanup
URL: https://github.com/SSSD/sssd/pull/5307 Author: alexey-tikhonov Title: #5307: UTIL:utf8: code cleanup Action: edited Changed field: body Original value: """ Set of patches to address covscan issues. """ ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5307][edited] UTIL:utf8: code cleanup
URL: https://github.com/SSSD/sssd/pull/5307 Author: alexey-tikhonov Title: #5307: UTIL:utf8: code cleanup Action: edited Changed field: title Original value: """ (WiP) Covscan issues cleanup """ ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5281][+Accepted] Dn with spaces for 1.16
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16 Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5281][-Waiting for review] Dn with spaces for 1.16
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16 Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5281][comment] Dn with spaces for 1.16
URL: https://github.com/SSSD/sssd/pull/5281 Title: #5281: Dn with spaces for 1.16 alexey-tikhonov commented: """ Patches: ``` UTIL: DN sanitization UTIL: Use sss_sanitize_dn where we deal with DN UTIL: Use sss_sanitize_dn where we deal with DN 2 ``` were reviewed by @elkoniu and @sumit-bose Patch ``` ldap: use member DN to create ghost user hash table ``` was reviewed by @thalman and me. As Sumit wrote, cherry-pick commit messages might need an update after the original patches are commited to master. """ See the full comment at https://github.com/SSSD/sssd/pull/5281#issuecomment-688255131 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5262][-Waiting for review] DN with white spaces
URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5262][+Accepted] DN with white spaces
URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5262][comment] DN with white spaces
URL: https://github.com/SSSD/sssd/pull/5262 Title: #5262: DN with white spaces alexey-tikhonov commented: """ Patches: ``` UTIL: DN sanitization UTIL: Use sss_sanitize_dn where we deal with DN UTIL: Use sss_sanitize_dn where we deal with DN 2 ``` were reviewed by @elkoniu and @sumit-bose Patch ``` ldap: use member DN to create ghost user hash table ``` was reviewed by @thalman and me. """ See the full comment at https://github.com/SSSD/sssd/pull/5262#issuecomment-688254202 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5226][synchronized] python/pysss_nss_idmap: check return from functions
URL: https://github.com/SSSD/sssd/pull/5226
Author: ikerexxe
Title: #5226: python/pysss_nss_idmap: check return from functions
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5226/head:pr5226
git checkout pr5226
From a103d6d73e2afb952dfdbd75fe8eb3a16221ebe4 Mon Sep 17 00:00:00 2001
From: ikerexxe
Date: Wed, 1 Jul 2020 15:15:36 +0200
Subject: [PATCH 1/3] python/pysss_nss_idmap: check return from functions
Coverity warns that PyModule_AddIntConstant() returns operation success
or failure but this value is never checked.
```
Error: CHECKED_RETURN (CWE-252):
sssd-2.3.0/src/python/pysss_nss_idmap.c:587: check_return: Calling
"PyModule_AddIntConstant" without checking return value (as is done
elsewhere 4 out of 5 times).
sssd-2.3.0/src/python/pyhbac.c:1956: example_assign: Example 1:
Assigning: "ret" = return value from "PyModule_AddIntConstant(m,
"HBAC_CATEGORY_ALL", 1L)".
sssd-2.3.0/src/python/pyhbac.c:1957: example_checked: Example 1 (cont.):
"ret" has its value checked in "ret == -1".
sssd-2.3.0/src/python/pyhbac.c:1960: example_assign: Example 2:
Assigning: "ret" = return value from "PyModule_AddIntConstant(m,
"HBAC_RULE_ELEMENT_USERS", 1L)".
sssd-2.3.0/src/python/pyhbac.c:1961: example_checked: Example 2 (cont.):
"ret" has its value checked in "ret == -1".
sssd-2.3.0/src/python/pyhbac.c:1972: example_assign: Example 3:
Assigning: "ret" = return value from "PyModule_AddIntConstant(m,
"HBAC_EVAL_DENY", HBAC_EVAL_DENY)".
sssd-2.3.0/src/python/pyhbac.c:1973: example_checked: Example 3 (cont.):
"ret" has its value checked in "ret == -1".
sssd-2.3.0/src/python/pyhbac.c:1982: example_assign: Example 4:
Assigning: "ret" = return value from "PyModule_AddIntConstant(m,
"HBAC_ERROR_NOT_IMPLEMENTED", HBAC_ERROR_NOT_IMPLEMENTED)".
sssd-2.3.0/src/python/pyhbac.c:1983: example_checked: Example 4 (cont.):
"ret" has its value checked in "ret == -1".
# 585| PyModule_AddIntConstant(module, "ID_NOT_SPECIFIED",
# 586| SSS_ID_TYPE_NOT_SPECIFIED);
# 587|-> PyModule_AddIntConstant(module, "ID_USER", SSS_ID_TYPE_UID);
# 588| PyModule_AddIntConstant(module, "ID_GROUP", SSS_ID_TYPE_GID);
# 589| PyModule_AddIntConstant(module, "ID_BOTH", SSS_ID_TYPE_BOTH);
```
Moreover, even though coverity doesn't indicate it the same happens with
PyModule_AddStringConstant().
---
src/python/pysss_nss_idmap.c | 44
1 file changed, 34 insertions(+), 10 deletions(-)
diff --git a/src/python/pysss_nss_idmap.c b/src/python/pysss_nss_idmap.c
index c64aa45318..47605045a1 100644
--- a/src/python/pysss_nss_idmap.c
+++ b/src/python/pysss_nss_idmap.c
@@ -582,16 +582,40 @@ initpysss_nss_idmap(void)
if (module == NULL)
MODINITERROR;
-PyModule_AddIntConstant(module, "ID_NOT_SPECIFIED",
-SSS_ID_TYPE_NOT_SPECIFIED);
-PyModule_AddIntConstant(module, "ID_USER", SSS_ID_TYPE_UID);
-PyModule_AddIntConstant(module, "ID_GROUP", SSS_ID_TYPE_GID);
-PyModule_AddIntConstant(module, "ID_BOTH", SSS_ID_TYPE_BOTH);
-
-PyModule_AddStringConstant(module, "SID_KEY", SSS_SID_KEY);
-PyModule_AddStringConstant(module, "NAME_KEY", SSS_NAME_KEY);
-PyModule_AddStringConstant(module, "ID_KEY", SSS_ID_KEY);
-PyModule_AddStringConstant(module, "TYPE_KEY", SSS_TYPE_KEY);
+if (PyModule_AddIntConstant(module, "ID_NOT_SPECIFIED",
+SSS_ID_TYPE_NOT_SPECIFIED) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
+if (PyModule_AddIntConstant(module, "ID_USER", SSS_ID_TYPE_UID) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
+if (PyModule_AddIntConstant(module, "ID_GROUP", SSS_ID_TYPE_GID) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
+if (PyModule_AddIntConstant(module, "ID_BOTH", SSS_ID_TYPE_BOTH) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
+
+if (PyModule_AddStringConstant(module, "SID_KEY", SSS_SID_KEY) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
+if (PyModule_AddStringConstant(module, "NAME_KEY", SSS_NAME_KEY) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
+if (PyModule_AddStringConstant(module, "ID_KEY", SSS_ID_KEY) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
+if (PyModule_AddStringConstant(module, "TYPE_KEY", SSS_TYPE_KEY) < 0) {
+Py_DECREF(module);
+MODINITERROR;
+}
#ifdef IS_PY3K
return module;
From cfa0f50c3ce545f7f329341a2c7ddc31018c19d7 Mon Sep 17 00:00:00 2001
From: ikerexxe
Date: Mon, 7 Sep 2020 12:39:13 +0200
Subject: [PATCH 2/3] python/pyhbac: if PyModule* fails decrement references
If PyModule* actions fail, then references to objects have to be
decremented.
---
src/python/pyhbac.c | 107 +++-
1 file changed, 76 insertions(+), 31 deletions(-)
diff --git a/src/python
[SSSD] [sssd PR#5283][comment] Add dyndns_auth_ptr support
URL: https://github.com/SSSD/sssd/pull/5283 Title: #5283: Add dyndns_auth_ptr support joakim-tjernlund commented: """ I would really appreciate if this could be merged to master, then I can install sssd on a few more computers that uses master """ See the full comment at https://github.com/SSSD/sssd/pull/5283#issuecomment-688194108 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5245][comment] RESOLV: Avoid DNS search to improve fail-over reaction
URL: https://github.com/SSSD/sssd/pull/5245 Title: #5245: RESOLV: Avoid DNS search to improve fail-over reaction sumit-bose commented: """ > 'hostname.subdomain' will still work through domain search if subdomain is > not a top level domain, wouldn't it? Hi, no, as @thalman suggested in https://bugzilla.redhat.com/show_bug.cgi?id=1608496#c26 we would check if there is a '.' in the name and since `hostname.subdomain` has a dot we would add a dot to the end which would skip the domain searches. Since we cannot reliable determine if what follows the '.' is a fully-qualified domain or just the first part which has to be extended with what's available in /etc/resolv.conf I guess we cannot avoid a config option which can switch `options.flags = ARES_FLAG_NOSEARCH;` on and off. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5245#issuecomment-688171034 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5245][comment] RESOLV: Avoid DNS search to improve fail-over reaction
URL: https://github.com/SSSD/sssd/pull/5245 Title: #5245: RESOLV: Avoid DNS search to improve fail-over reaction pbrezina commented: """ 'hostname.subdomain' will still work through domain search if subdomain is not a top level domain, wouldn't it? """ See the full comment at https://github.com/SSSD/sssd/pull/5245#issuecomment-688161437 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#5303][comment] tests: run TIER-0 multihost tests in PRCI
URL: https://github.com/SSSD/sssd/pull/5303 Title: #5303: tests: run TIER-0 multihost tests in PRCI pbrezina commented: """ Click on details next to the test result and look for multihost-pytest.log. E.g.: https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5303/3/fedora32/multihost-pytest.log At least test_kcm_debug_level_set is probably a real bug since I had to restart SSSD to set the debug level quite recently. """ See the full comment at https://github.com/SSSD/sssd/pull/5303#issuecomment-688159799 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
