date:20210112

[SSSD] [sssd PR#5457][+Bugzilla] simple: fix memory leak while reloading lists

2021-01-12 Thread alexey-tikhonov

  URL: https://github.com/SSSD/sssd/pull/5457
Title: #5457: simple: fix memory leak while reloading lists

Label: +Bugzilla
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5453][comment] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

2021-01-12 Thread alexey-tikhonov

  URL: https://github.com/SSSD/sssd/pull/5453
Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section and 
coverity fixes

alexey-tikhonov commented:
"""
Hi,

there is a compilation warning:
```
../src/sss_client/pam_sss_gss.c:339:5: warning: ‘reply’ may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  339 | free(reply);
  | ^~~
../src/sss_client/pam_sss_gss.c:328:14: note: ‘reply’ was declared here
  328 | uint8_t *reply;
  |  ^
../src/sss_client/pam_sss_gss.c:270:11: warning: ‘reply_len’ may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  270 | upn = malloc(reply_len * sizeof(char));
  |   ^~~~
../src/sss_client/pam_sss_gss.c:327:12: note: ‘reply_len’ was declared here
  327 | size_t reply_len;
  |^
```

That's false positive but I think still better to suppress.

Otherwise ACK for the 2nd patch ("fix coverity issues").

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5453#issuecomment-758823747
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5453][+Bugzilla] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

2021-01-12 Thread alexey-tikhonov

  URL: https://github.com/SSSD/sssd/pull/5453
Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section and 
coverity fixes

Label: +Bugzilla
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5453][+Waiting for review] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

2021-01-12 Thread alexey-tikhonov

  URL: https://github.com/SSSD/sssd/pull/5453
Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section and 
coverity fixes

Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5365][synchronized] Translations update from Weblate

2021-01-12 Thread weblate

   URL: https://github.com/SSSD/sssd/pull/5365
Author: weblate
 Title: #5365: Translations update from Weblate
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5365/head:pr5365
git checkout pr5365
From ff8910da676ed7082edfd446b135acca065e9687 Mon Sep 17 00:00:00 2001
From: Weblate 
Date: Tue, 12 Jan 2021 17:38:09 +0100
Subject: [PATCH] Translated using Weblate (Finnish)

Currently translated at 1.1% (31 of 2671 strings)

Translation: SSSD/sssd-manpage
Translate-URL: https://translate.fedoraproject.org/projects/sssd/sssd-manpage-master/fi/
---
 src/man/po/fi.po | 15 ---
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/src/man/po/fi.po b/src/man/po/fi.po
index 1cd7f5ecdb..432274ea3d 100644
--- a/src/man/po/fi.po
+++ b/src/man/po/fi.po
@@ -4,15 +4,16 @@ msgstr ""
 "Project-Id-Version: sssd-docs 2.3.0\n"
 "Report-Msgid-Bugs-To: sssd-de...@redhat.com\n"
 "POT-Creation-Date: 2020-05-19 12:09+0200\n"
-"PO-Revision-Date: 2017-03-24 08:46-0400\n"
-"Last-Translator: Toni Rantala \n"
-"Language-Team: Finnish\n"
+"PO-Revision-Date: 2021-01-12 16:38+\n"
+"Last-Translator: Jan Kuparinen \n"
+"Language-Team: Finnish \n"
 "Language: fi\n"
 "MIME-Version: 1.0\n"
 "Content-Type: text/plain; charset=UTF-8\n"
 "Content-Transfer-Encoding: 8bit\n"
-"Plural-Forms: nplurals=2; plural=(n != 1)\n"
-"X-Generator: Zanata 4.6.2\n"
+"Plural-Forms: nplurals=2; plural=n != 1;\n"
+"X-Generator: Weblate 4.4\n"
 
 #. type: Content of: 
 #: sss_groupmod.8.xml:5 sssd.conf.5.xml:5 sssd-ldap.5.xml:5 pam_sss.8.xml:5
@@ -1159,7 +1160,7 @@ msgstr ""
 #. 
 #: sssd.conf.5.xml:764
 msgid "offline_timeout (integer)"
-msgstr "offline_timeout (integer)"
+msgstr "offline_timeout (integeri)"
 
 #. type: Content of:
 #. 
@@ -1255,7 +1256,7 @@ msgstr ""
 #. 
 #: sssd.conf.5.xml:840
 msgid "enum_cache_timeout (integer)"
-msgstr "enum_cache_timeout (integer)"
+msgstr "enum_cache_timeout (integeri)"
 
 #. type: Content of:
 #. 
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5458][+Waiting for review] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

2021-01-12 Thread alexey-tikhonov

  URL: https://github.com/SSSD/sssd/pull/5458
Title: #5458: UTIL: find_domain_by_object_name_ex() changed log level (1-16 
backport)

Label: +Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5458][edited] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

2021-01-12 Thread alexey-tikhonov

   URL: https://github.com/SSSD/sssd/pull/5458
Author: alexey-tikhonov
 Title: #5458: UTIL: find_domain_by_object_name_ex() changed log level (1-16 
backport)
Action: edited

 Changed field: body
Original value:
"""
It's up to user of this function to judge if fail to parse fqname is
a critical error.

Reviewed-by: Pawel Polawski 
Reviewed-by: Sumit Bose 
(cherry picked from commit bd2f38abe95645b9b16b12d12dac6008b0d2a03b)

1-16 backport for RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1910131
"""

___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5458][+Bugzilla] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

2021-01-12 Thread alexey-tikhonov

  URL: https://github.com/SSSD/sssd/pull/5458
Title: #5458: UTIL: find_domain_by_object_name_ex() changed log level (1-16 
backport)

Label: +Bugzilla
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5458][opened] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

2021-01-12 Thread alexey-tikhonov

   URL: https://github.com/SSSD/sssd/pull/5458
Author: alexey-tikhonov
 Title: #5458: UTIL: find_domain_by_object_name_ex() changed log level (1-16 
backport)
Action: opened

PR body:
"""
It's up to user of this function to judge if fail to parse fqname is
a critical error.

Reviewed-by: Pawel Polawski 
Reviewed-by: Sumit Bose 
(cherry picked from commit bd2f38abe95645b9b16b12d12dac6008b0d2a03b)

1-16 backport for RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1910131
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5458/head:pr5458
git checkout pr5458
From af13c4765c3986a83e77d85edd2d3205cc514e85 Mon Sep 17 00:00:00 2001
From: Alexey Tikhonov 
Date: Tue, 15 Dec 2020 18:47:25 +0100
Subject: [PATCH] UTIL: find_domain_by_object_name_ex() changed log level

It's up to user of this function to judge if fail to parse fqname is
a critical error.

Reviewed-by: Pawel Polawski 
Reviewed-by: Sumit Bose 
(cherry picked from commit bd2f38abe95645b9b16b12d12dac6008b0d2a03b)
---
 src/util/domain_info_utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/util/domain_info_utils.c b/src/util/domain_info_utils.c
index 71dfcba02e..5a374074b4 100644
--- a/src/util/domain_info_utils.c
+++ b/src/util/domain_info_utils.c
@@ -207,7 +207,7 @@ find_domain_by_object_name_ex(struct sss_domain_info *domain,
 ret = sss_parse_internal_fqname(tmp_ctx, object_name,
 NULL, &domainname);
 if (ret != EOK) {
-DEBUG(SSSDBG_CRIT_FAILURE, "Unable to parse name '%s' [%d]: %s\n",
+DEBUG(SSSDBG_MINOR_FAILURE, "Unable to parse name '%s' [%d]: %s\n",
 object_name, ret, sss_strerror(ret));
 goto done;
 }
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5457][opened] simple: fix memory leak while reloading lists

2021-01-12 Thread sumit-bose

   URL: https://github.com/SSSD/sssd/pull/5457
Author: sumit-bose
 Title: #5457: simple: fix memory leak while reloading lists
Action: opened

PR body:
"""
The simple access provider with reload the access and deny lists at
runtime to make sure that users and groups from domains which are
discovered at runtime are properly processed.

While reloading the lists the original lists are not freed and an
intermediate list wasn't removed as well.

Resolves: https://github.com/SSSD/sssd/issues/5456

:fixes: Memory leak in the simple access provider
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5457/head:pr5457
git checkout pr5457
From a0b921070eae9dacc55d18588b4f5820e69067af Mon Sep 17 00:00:00 2001
From: Sumit Bose 
Date: Tue, 12 Jan 2021 16:40:56 +0100
Subject: [PATCH] simple: fix memory leak while reloading lists

The simple access provider with reload the access and deny lists at
runtime to make sure that users and groups from domains which are
discovered at runtime are properly processed.

While reloading the lists the original lists are not freed and an
intermediate list wasn't removed as well.

Resolves: https://github.com/SSSD/sssd/issues/5456

:fixes: Memory leak in the simple access provider
---
 src/providers/simple/simple_access.c | 24 +---
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/src/providers/simple/simple_access.c b/src/providers/simple/simple_access.c
index 1868569b10..4dc501e9ea 100644
--- a/src/providers/simple/simple_access.c
+++ b/src/providers/simple/simple_access.c
@@ -117,17 +117,13 @@ int simple_access_obtain_filter_lists(struct simple_ctx *ctx)
 const char *name;
 const char *option;
 char **orig_list;
-char ***ctx_list;
+char **ctx_list;
 } lists[] = {{"Allow users", CONFDB_SIMPLE_ALLOW_USERS, NULL, NULL},
  {"Deny users", CONFDB_SIMPLE_DENY_USERS, NULL, NULL},
  {"Allow groups", CONFDB_SIMPLE_ALLOW_GROUPS, NULL, NULL},
  {"Deny groups", CONFDB_SIMPLE_DENY_GROUPS, NULL, NULL},
  {NULL, NULL, NULL, NULL}};
 
-lists[0].ctx_list = &ctx->allow_users;
-lists[1].ctx_list = &ctx->deny_users;
-lists[2].ctx_list = &ctx->allow_groups;
-lists[3].ctx_list = &ctx->deny_groups;
 
 ret = sysdb_master_domain_update(bectx->domain);
 if (ret != EOK) {
@@ -141,7 +137,7 @@ int simple_access_obtain_filter_lists(struct simple_ctx *ctx)
 lists[i].option, &lists[i].orig_list);
 if (ret == ENOENT) {
 DEBUG(SSSDBG_FUNC_DATA, "%s list is empty.\n", lists[i].name);
-*lists[i].ctx_list = NULL;
+lists[i].ctx_list = NULL;
 continue;
 } else if (ret != EOK) {
 DEBUG(SSSDBG_CRIT_FAILURE, "confdb_get_string_as_list failed.\n");
@@ -149,7 +145,8 @@ int simple_access_obtain_filter_lists(struct simple_ctx *ctx)
 }
 
 ret = simple_access_parse_names(ctx, bectx, lists[i].orig_list,
-lists[i].ctx_list);
+&lists[i].ctx_list);
+talloc_free(lists[i].orig_list);
 if (ret != EOK) {
 DEBUG(SSSDBG_CRIT_FAILURE, "Unable to parse %s list [%d]: %s\n",
 lists[i].name, ret, sss_strerror(ret));
@@ -165,6 +162,19 @@ int simple_access_obtain_filter_lists(struct simple_ctx *ctx)
   "No rules supplied for simple access provider. "
"Access will be granted for all users.\n");
 }
+
+talloc_free(ctx->allow_users);
+ctx->allow_users = talloc_steal(ctx, lists[0].ctx_list);
+
+talloc_free(ctx->deny_users);
+ctx->deny_users = talloc_steal(ctx, lists[1].ctx_list);
+
+talloc_free(ctx->allow_groups);
+ctx->allow_groups = talloc_steal(ctx, lists[2].ctx_list);
+
+talloc_free(ctx->deny_groups);
+ctx->deny_groups = talloc_steal(ctx, lists[3].ctx_list);
+
 return EOK;
 
 failed:
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5453][comment] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

2021-01-12 Thread pbrezina

  URL: https://github.com/SSSD/sssd/pull/5453
Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section and 
coverity fixes

pbrezina commented:
"""
I also included fix for coverity warnings.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/5453#issuecomment-758635480
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5453][edited] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

2021-01-12 Thread pbrezina

   URL: https://github.com/SSSD/sssd/pull/5453
Author: pbrezina
 Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section 
and coverity fixes
Action: edited

 Changed field: title
Original value:
"""
gssapi: default pam_gssapi_services to NULL in domain section
"""

___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5453][synchronized] gssapi: default pam_gssapi_services to NULL in domain section

2021-01-12 Thread pbrezina

   URL: https://github.com/SSSD/sssd/pull/5453
Author: pbrezina
 Title: #5453: gssapi: default pam_gssapi_services to NULL in domain section
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5453/head:pr5453
git checkout pr5453
From 1e15e80d79bdc0ba34d8b238562e3baa890763ad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
Date: Mon, 11 Jan 2021 13:11:39 +0100
Subject: [PATCH 1/2] gssapi: default pam_gssapi_services to NULL in domain
 section

We need to distinguish when the option is not set in domain section and when
it is is explicitly disabled. Now if it is not set, domain->gssapi_services
is NULL and we'll use value from the pam section.

Without this change, the value in the pam section is ignored.
---
 src/confdb/confdb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/confdb/confdb.c b/src/confdb/confdb.c
index 2881ce5da7..befcfff2db 100644
--- a/src/confdb/confdb.c
+++ b/src/confdb/confdb.c
@@ -1582,7 +1582,7 @@ static int confdb_get_domain_internal(struct confdb_ctx *cdb,
 }
 
 tmp = ldb_msg_find_attr_as_string(res->msgs[0], CONFDB_PAM_GSSAPI_SERVICES,
-  "-");
+  NULL);
 if (tmp != NULL) {
 ret = split_on_separator(domain, tmp, ',', true, true,
  &domain->gssapi_services, NULL);

From 558bfa79f0439d528c92cbe3dae2c6f6d600c12f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pavel=20B=C5=99ezina?= 
Date: Tue, 12 Jan 2021 13:50:11 +0100
Subject: [PATCH 2/2] pam_sss_gssapi: fix coverity issues

```
1. Defect type: RESOURCE_LEAK
7. sssd-2.4.0/src/sss_client/pam_sss_gss.c:556: leaked_storage: Variable "username" going out of scope leaks the storage it points to.
Expand
2. Defect type: RESOURCE_LEAK
3. sssd-2.4.0/src/sss_client/pam_sss_gss.c:321: leaked_storage: Variable "reply" going out of scope leaks the storage it points to.
Expand
3. Defect type: RESOURCE_LEAK
7. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260: leaked_storage: Variable "username" going out of scope leaks the storage it points to.
Expand
4. Defect type: RESOURCE_LEAK
6. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260: leaked_storage: Variable "upn" going out of scope leaks the storage it points to.
Expand
5. Defect type: RESOURCE_LEAK
7. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260: leaked_storage: Variable "target" going out of scope leaks the storage it points to.
Expand
6. Defect type: RESOURCE_LEAK
7. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260: leaked_storage: Variable "domain" going out of scope leaks the storage it points to.

1. Defect type: CLANG_WARNING
1. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'username'
Expand
2. Defect type: CLANG_WARNING
1. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'upn'
Expand
3. Defect type: CLANG_WARNING
1. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'target'
Expand
4. Defect type: CLANG_WARNING
1. sssd-2.4.0/src/sss_client/pam_sss_gss.c:260:16: warning[unix.Malloc]: Potential leak of memory pointed to by 'domain'
```
---
 src/sss_client/pam_sss_gss.c | 18 --
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/src/sss_client/pam_sss_gss.c b/src/sss_client/pam_sss_gss.c
index cd38db7da7..ea90e35c27 100644
--- a/src/sss_client/pam_sss_gss.c
+++ b/src/sss_client/pam_sss_gss.c
@@ -195,6 +195,8 @@ static errno_t sssd_gssapi_init_send(pam_handle_t *pamh,
 struct sss_cli_req_data req_data;
 size_t service_len;
 size_t user_len;
+size_t reply_len;
+uint8_t *reply;
 uint8_t *data;
 errno_t ret;
 int ret_errno;
@@ -217,7 +219,7 @@ static errno_t sssd_gssapi_init_send(pam_handle_t *pamh,
 
 req_data.data = data;
 
-ret = sss_pam_make_request(SSS_GSSAPI_INIT, &req_data, _reply, _reply_len,
+ret = sss_pam_make_request(SSS_GSSAPI_INIT, &req_data, &reply, &reply_len,
&ret_errno);
 free(data);
 if (ret != PAM_SUCCESS) {
@@ -233,6 +235,16 @@ static errno_t sssd_gssapi_init_send(pam_handle_t *pamh,
 return (ret_errno != EOK) ? ret_errno : EIO;
 }
 
+if (ret_errno == EOK) {
+*_reply = reply;
+*_reply_len = reply_len;
+} else {
+/* We got PAM_SUCCESS therefore the communication with SSSD was
+ * successful and we have received a reply buffer. We just don't care
+ * about it, we are only interested in the error code. */
+free(reply);
+}
+
 return ret_errno;
 }
 
@@ -257,7 +269,8 @@ static errno_t sssd_gssapi_init_recv(uint8_t *reply,
 target = malloc(reply_len * sizeof(char));
 upn = malloc(reply_len * sizeof(char));
 if (username == NULL || domain == NULL || target == NULL || upn == NULL) {
-return E

[SSSD] [sssd PR#5454][+Bugzilla] SBUS: do not try to del non existing sender

2021-01-12 Thread alexey-tikhonov

  URL: https://github.com/SSSD/sssd/pull/5454
Title: #5454: SBUS: do not try to del non existing sender

Label: +Bugzilla
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5452][+Accepted] RESOLV: handle fail of ares_parse_*_reply() properly

2021-01-12 Thread ikerexxe

  URL: https://github.com/SSSD/sssd/pull/5452
Title: #5452: RESOLV: handle fail of ares_parse_*_reply() properly

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5452][-Waiting for review] RESOLV: handle fail of ares_parse_*_reply() properly

2021-01-12 Thread ikerexxe

  URL: https://github.com/SSSD/sssd/pull/5452
Title: #5452: RESOLV: handle fail of ares_parse_*_reply() properly

Label: -Waiting for review
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#5457][+Bugzilla] simple: fix memory leak while reloading lists

[SSSD] [sssd PR#5453][comment] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

[SSSD] [sssd PR#5453][+Bugzilla] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

[SSSD] [sssd PR#5453][+Waiting for review] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

[SSSD] [sssd PR#5365][synchronized] Translations update from Weblate

[SSSD] [sssd PR#5458][+Waiting for review] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

[SSSD] [sssd PR#5458][edited] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

[SSSD] [sssd PR#5458][+Bugzilla] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

[SSSD] [sssd PR#5458][opened] UTIL: find_domain_by_object_name_ex() changed log level (1-16 backport)

[SSSD] [sssd PR#5457][opened] simple: fix memory leak while reloading lists

[SSSD] [sssd PR#5453][comment] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

[SSSD] [sssd PR#5453][edited] gssapi: default pam_gssapi_services to NULL in domain section and coverity fixes

[SSSD] [sssd PR#5453][synchronized] gssapi: default pam_gssapi_services to NULL in domain section

[SSSD] [sssd PR#5454][+Bugzilla] SBUS: do not try to del non existing sender

[SSSD] [sssd PR#5452][+Accepted] RESOLV: handle fail of ares_parse_*_reply() properly

[SSSD] [sssd PR#5452][-Waiting for review] RESOLV: handle fail of ares_parse_*_reply() properly

16 matches

Site Navigation

Mail list logo

Footer information