[SSSD] [sssd PR#5712][synchronized] Health and Support Analyzer - Add request log parsing utility
URL: https://github.com/SSSD/sssd/pull/5712 Author: justin-stephenson Title: #5712: Health and Support Analyzer - Add request log parsing utility Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5712/head:pr5712 git checkout pr5712 From 225f91087af3d0abb8d0c91811a8c1e305874a66 Mon Sep 17 00:00:00 2001 From: Justin Stephenson Date: Wed, 4 Aug 2021 14:57:55 + Subject: [PATCH 1/4] DP: Log offline warning for REQ_TRACE tracking This allows the sssctl analyze parsing tool to report if the backend was offline when the request came in to the data provider. --- src/providers/data_provider/dp_request.c | 4 1 file changed, 4 insertions(+) diff --git a/src/providers/data_provider/dp_request.c b/src/providers/data_provider/dp_request.c index 077b361f3c..3cbd55c1ec 100644 --- a/src/providers/data_provider/dp_request.c +++ b/src/providers/data_provider/dp_request.c @@ -133,6 +133,10 @@ static errno_t dp_attach_req(struct dp_req *dp_req, SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name, "New request. [%s CID #%u] Flags [%#.4x].", sender_name, cli_id, dp_flags); +if (be_is_offline(provider->be_ctx)) { +DEBUG(SSSDBG_TRACE_FUNC, "[CID #%u] Backend is offline! " \ + "Using cached data if available\n", cli_id); +} } else { SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name, "New request. Flags [%#.4x].", From f67152712f30fef7abca494520ca32cacac03b55 Mon Sep 17 00:00:00 2001 From: Justin Stephenson Date: Fri, 1 Oct 2021 15:13:57 + Subject: [PATCH 2/4] Responder: Log client uid that started a request --- src/responder/common/responder_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index 3207e26e6f..7e145aa9b2 100644 --- a/src/responder/common/responder_common.c +++ b/src/responder/common/responder_common.c @@ -640,9 +640,9 @@ static void accept_fd_handler(struct tevent_context *ev, rctx->client_id_num++; DEBUG(SSSDBG_TRACE_FUNC, - "Client [CID #%u][cmd %s][%p][%d] connected%s!\n", - rctx->client_id_num, cctx->cmd_line, cctx, cctx->cfd, - accept_ctx->is_private ? " to privileged pipe" : ""); + "Client [CID #%u][cmd %s][uid %u][%p][%d] connected%s!\n", + rctx->client_id_num, cctx->cmd_line, cli_creds_get_uid(cctx->creds), + cctx, cctx->cfd, accept_ctx->is_private ? " to privileged pipe" : ""); return; } From 0a018653576715d8af13ec4eb6bc57791e1f2078 Mon Sep 17 00:00:00 2001 From: Justin Stephenson Date: Fri, 11 Jun 2021 11:04:59 -0400 Subject: [PATCH 3/4] TOOLS: Add sss_analyze utility Add log parsing tool which can be used to track requests across responder and backend logs. --- Makefile.am| 2 +- configure.ac | 1 + contrib/sssd.spec.in | 5 + src/tools/analyzer/Makefile.am | 16 ++ src/tools/analyzer/modules/__init__.py | 0 src/tools/analyzer/modules/request.py | 276 + src/tools/analyzer/source_files.py | 76 +++ src/tools/analyzer/source_journald.py | 47 + src/tools/analyzer/source_reader.py| 27 +++ src/tools/analyzer/sss_analyze.py | 27 +++ 10 files changed, 476 insertions(+), 1 deletion(-) create mode 100644 src/tools/analyzer/Makefile.am create mode 100644 src/tools/analyzer/modules/__init__.py create mode 100644 src/tools/analyzer/modules/request.py create mode 100644 src/tools/analyzer/source_files.py create mode 100644 src/tools/analyzer/source_journald.py create mode 100644 src/tools/analyzer/source_reader.py create mode 100755 src/tools/analyzer/sss_analyze.py diff --git a/Makefile.am b/Makefile.am index 6d84b082ec..c7c429965d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,7 +22,7 @@ SUBDIRS += src/man endif SUBDIRS += . src/tests/cwrap src/tests/intg src/tests/test_CA \ - src/tests/test_ECC_CA + src/tests/test_ECC_CA src/tools/analyzer # Some old versions of automake don't define builddir builddir ?= . diff --git a/configure.ac b/configure.ac index c5c3a903b0..c5193fa545 100644 --- a/configure.ac +++ b/configure.ac @@ -531,6 +531,7 @@ AC_CONFIG_FILES([Makefile contrib/sssd.spec src/examples/rwtab src/doxy.config src/lib/sifp/sss_simpleifp.doxy src/config/setup.py src/systemtap/sssd.stp + src/tools/analyzer/Makefile src/config/SSSDConfig/__init__.py]) AC_CONFIG_FILES([sbus_generate.sh], [chmod +x sbus_generate.sh]) AC_OUTPUT diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index c8a4f62c7e..a9b7ecc5c6 100644 --- a/contrib/sssd.spec.in +++ b/contri
[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility justin-stephenson commented: """ > I look into Fedora python packaging guidelines and we can use > [py3_shebang_fix](https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#py3_shebang_fix) > macro instead of --with-python-bin and autoconf. This looks like a cleaner > approach. > > After this change, I think we can push. Okay thanks, it is fixed now to use `%py3_shebang_fix` and I removed the python bin lines """ See the full comment at https://github.com/SSSD/sssd/pull/5712#issuecomment-940428058 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5712][synchronized] Health and Support Analyzer - Add request log parsing utility
URL: https://github.com/SSSD/sssd/pull/5712 Author: justin-stephenson Title: #5712: Health and Support Analyzer - Add request log parsing utility Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5712/head:pr5712 git checkout pr5712 From 225f91087af3d0abb8d0c91811a8c1e305874a66 Mon Sep 17 00:00:00 2001 From: Justin Stephenson Date: Wed, 4 Aug 2021 14:57:55 + Subject: [PATCH 1/4] DP: Log offline warning for REQ_TRACE tracking This allows the sssctl analyze parsing tool to report if the backend was offline when the request came in to the data provider. --- src/providers/data_provider/dp_request.c | 4 1 file changed, 4 insertions(+) diff --git a/src/providers/data_provider/dp_request.c b/src/providers/data_provider/dp_request.c index 077b361f3c..3cbd55c1ec 100644 --- a/src/providers/data_provider/dp_request.c +++ b/src/providers/data_provider/dp_request.c @@ -133,6 +133,10 @@ static errno_t dp_attach_req(struct dp_req *dp_req, SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name, "New request. [%s CID #%u] Flags [%#.4x].", sender_name, cli_id, dp_flags); +if (be_is_offline(provider->be_ctx)) { +DEBUG(SSSDBG_TRACE_FUNC, "[CID #%u] Backend is offline! " \ + "Using cached data if available\n", cli_id); +} } else { SSS_REQ_TRACE_CID_DP_REQ(SSSDBG_TRACE_FUNC, dp_req->name, "New request. Flags [%#.4x].", From f67152712f30fef7abca494520ca32cacac03b55 Mon Sep 17 00:00:00 2001 From: Justin Stephenson Date: Fri, 1 Oct 2021 15:13:57 + Subject: [PATCH 2/4] Responder: Log client uid that started a request --- src/responder/common/responder_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/responder/common/responder_common.c b/src/responder/common/responder_common.c index 3207e26e6f..7e145aa9b2 100644 --- a/src/responder/common/responder_common.c +++ b/src/responder/common/responder_common.c @@ -640,9 +640,9 @@ static void accept_fd_handler(struct tevent_context *ev, rctx->client_id_num++; DEBUG(SSSDBG_TRACE_FUNC, - "Client [CID #%u][cmd %s][%p][%d] connected%s!\n", - rctx->client_id_num, cctx->cmd_line, cctx, cctx->cfd, - accept_ctx->is_private ? " to privileged pipe" : ""); + "Client [CID #%u][cmd %s][uid %u][%p][%d] connected%s!\n", + rctx->client_id_num, cctx->cmd_line, cli_creds_get_uid(cctx->creds), + cctx, cctx->cfd, accept_ctx->is_private ? " to privileged pipe" : ""); return; } From bc4dfa590c9dfb2836b32b67516535fcd8775996 Mon Sep 17 00:00:00 2001 From: Justin Stephenson Date: Fri, 11 Jun 2021 11:04:59 -0400 Subject: [PATCH 3/4] TOOLS: Add sss_analyze utility Add log parsing tool which can be used to track requests across responder and backend logs. --- Makefile.am| 2 +- configure.ac | 1 + contrib/sssd.spec.in | 5 + src/tools/analyzer/Makefile.am | 16 ++ src/tools/analyzer/modules/__init__.py | 0 src/tools/analyzer/modules/request.py | 276 + src/tools/analyzer/source_files.py | 76 +++ src/tools/analyzer/source_journald.py | 47 + src/tools/analyzer/source_reader.py| 27 +++ src/tools/analyzer/sss_analyze.py | 24 +++ 10 files changed, 473 insertions(+), 1 deletion(-) create mode 100644 src/tools/analyzer/Makefile.am create mode 100644 src/tools/analyzer/modules/__init__.py create mode 100644 src/tools/analyzer/modules/request.py create mode 100644 src/tools/analyzer/source_files.py create mode 100644 src/tools/analyzer/source_journald.py create mode 100644 src/tools/analyzer/source_reader.py create mode 100755 src/tools/analyzer/sss_analyze.py diff --git a/Makefile.am b/Makefile.am index 6d84b082ec..c7c429965d 100644 --- a/Makefile.am +++ b/Makefile.am @@ -22,7 +22,7 @@ SUBDIRS += src/man endif SUBDIRS += . src/tests/cwrap src/tests/intg src/tests/test_CA \ - src/tests/test_ECC_CA + src/tests/test_ECC_CA src/tools/analyzer # Some old versions of automake don't define builddir builddir ?= . diff --git a/configure.ac b/configure.ac index c5c3a903b0..c5193fa545 100644 --- a/configure.ac +++ b/configure.ac @@ -531,6 +531,7 @@ AC_CONFIG_FILES([Makefile contrib/sssd.spec src/examples/rwtab src/doxy.config src/lib/sifp/sss_simpleifp.doxy src/config/setup.py src/systemtap/sssd.stp + src/tools/analyzer/Makefile src/config/SSSDConfig/__init__.py]) AC_CONFIG_FILES([sbus_generate.sh], [chmod +x sbus_generate.sh]) AC_OUTPUT diff --git a/contrib/sssd.spec.in b/contrib/sssd.spec.in index c8a4f62c7e..a9b7ecc5c6 100644 --- a/contrib/sssd.spec.in +++ b/contri
[SSSD][sssd PR#5814][synchronized] Tests: sss_override does not take precedence over override_homedir di…
URL: https://github.com/SSSD/sssd/pull/5814 Author: aborah-sudo Title: #5814: Tests: sss_override does not take precedence over override_homedir di… Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5814/head:pr5814 git checkout pr5814 From a393b748b2d274b6ed36fc7ea48e0c83d61de2f2 Mon Sep 17 00:00:00 2001 From: Anuj Borah Date: Wed, 6 Oct 2021 17:59:51 +0530 Subject: [PATCH] Tests: sss_override does not take precedence over override_homedir directive bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942 --- .../alltests/test_ldap_extra_attrs.py | 40 +++ 1 file changed, 40 insertions(+) diff --git a/src/tests/multihost/alltests/test_ldap_extra_attrs.py b/src/tests/multihost/alltests/test_ldap_extra_attrs.py index a493fb558b..bfd1fb3120 100644 --- a/src/tests/multihost/alltests/test_ldap_extra_attrs.py +++ b/src/tests/multihost/alltests/test_ldap_extra_attrs.py @@ -193,3 +193,43 @@ def test_0006_bz1667252(self, multihost): cmd = multihost.client[0].run_command(sssctl_cmd) ret = multihost.client[0].service_sssd('status') assert ret == 0 + +@pytest.mark.tier1_2 +def test_0007_bz1919942(self, multihost, +backupsssdconf): +""" +:title: ifp: sss_override does not take + precedence over override_homedir directive +:id: d2e98c70-26a0-11ec-bcf5-845cf3eff344 +:customerscenario: true +:bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1919942 +:steps: + 1. Edit sssd.conf and set homedir, i.e. + `override_homedir = /home/%u1` + 2. Restart sssd and check homedir + 3. Use `sss_override` to set a + different home directory + 4. Restart sssd and use getent command + to check home directory, which is still set to same. +:expectedresults: + 1. Should succeed + 2. Should succeed + 3. Should succeed + 4. Should succeed +""" +tools = sssdTools(multihost.client[0]) +domain_name = tools.get_domain_section_name() +client = sssdTools(multihost.client[0]) +domain_params = {'override_homedir': '/home/%u1'} +client.sssd_conf(f'domain/{domain_name}', domain_params) +multihost.client[0].service_sssd('restart') +before = multihost.client[0].run_command("getent passwd " + "foo5@example1") +assert before.returncode == 0 +multihost.client[0].run_command("sss_override " +"user-add foo5@example1 -h " +"/home/foo56") +multihost.client[0].service_sssd('restart') +after = multihost.client[0].run_command("getent passwd " +"foo5@example1") +assert "User:/home/foo56" in after.stdout_text ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5802][+Accepted] MONITOR: reduce logs severity around signalling
URL: https://github.com/SSSD/sssd/pull/5802 Title: #5802: MONITOR: reduce logs severity around signalling Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5802][-Waiting for review] MONITOR: reduce logs severity around signalling
URL: https://github.com/SSSD/sssd/pull/5802 Title: #5802: MONITOR: reduce logs severity around signalling Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5802][comment] MONITOR: reduce logs severity around signalling
URL: https://github.com/SSSD/sssd/pull/5802 Title: #5802: MONITOR: reduce logs severity around signalling sumit-bose commented: """ Hi, thanks for the patch, I'm fine with the changes. ACK. bye, Sumit """ See the full comment at https://github.com/SSSD/sssd/pull/5802#issuecomment-940091869 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5755][+Accepted] Tests: support subid ranges managed by FreeIPA
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5755][-Waiting for review] Tests: support subid ranges managed by FreeIPA
URL: https://github.com/SSSD/sssd/pull/5755 Title: #5755: Tests: support subid ranges managed by FreeIPA Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD]WARNING: MERGED [sssd PR#5780][closed] Translations update from Weblate
*WARNING: this pull request has been merged!* This is only mirrored repo thus any changes will be erased. Please push commit(s) to authoritative repository. URL: https://github.com/SSSD/sssd/pull/5780 Author: weblate Title: #5780: Translations update from Weblate Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5780/head:pr5780 git checkout pr5780 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][closed] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Author: alexey-tikhonov Title: #5766: Sources cleanup - part 3. Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5766/head:pr5766 git checkout pr5766 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][-Ready to push] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. Label: -Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][-Accepted] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][+Pushed] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][comment] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5766 * `master` * 1e64a762fded96aa6f25cf3927f6ad8f44bb25f2 - KCM: secdb: treat secdb_get_cc() == ENOENT the same way as corresponding key_by_*() == ENOENT (mostly) * 29f8a795f67db651e95842cddf153975f97d9b3f - TESTS: avoid cross-test tainting of os.environ * dfb97f071803218c1e5678bd79b7fd6d5a21e0df - crypto: removed sss_encrypt()/sss_decrypt() helpers as those aren't used anymore. * f5431c3a74c7bdfe1b86ea1c10c627c574fe0217 - KCM: secrets db: got rid of legacy encrypted payload format * 9466aa4d94a4d926e13db6b5a51f7f80cd46ef46 - KCM: secrets db: got rid of legacy json format support * 5bb5380cbf8cccf080906d1ca3c84ffae2da48da - libsecrets was disbanded and merged into KCM responder as this is the only its user now. * 10069b1d39e671b7502c5211883c94ceaa91aebb - Got rid of 'secrets' responder and it's support in KCM """ See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-939985469 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][closed] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Author: pbrezina Title: #5821: monitor: fix unused variable warning Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5821/head:pr5821 git checkout pr5821 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][-Ready to push] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Title: #5821: monitor: fix unused variable warning Label: -Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][+Pushed] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Title: #5821: monitor: fix unused variable warning Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][-Accepted] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Title: #5821: monitor: fix unused variable warning Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][comment] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Title: #5821: monitor: fix unused variable warning pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5821 * `master` * bb6d9d9cf67666582288212c108060fd5e777ff1 - monitor: fix unused variable warning """ See the full comment at https://github.com/SSSD/sssd/pull/5821#issuecomment-939985332 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][+Ready to push] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Title: #5821: monitor: fix unused variable warning Label: +Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][+Accepted] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Title: #5821: monitor: fix unused variable warning Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][comment] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Title: #5821: monitor: fix unused variable warning alexey-tikhonov commented: """ Thank you, ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/5821#issuecomment-939880814 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility pbrezina commented: """ I look into Fedora python packaging guidelines and we can use [py3_shebang_fix](https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#py3_shebang_fix) macro instead of --with-python-bin and autoconf. This looks like a cleaner approach. After this change, I think we can push. """ See the full comment at https://github.com/SSSD/sssd/pull/5712#issuecomment-939872088 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5712][comment] Health and Support Analyzer - Add request log parsing utility
URL: https://github.com/SSSD/sssd/pull/5712 Title: #5712: Health and Support Analyzer - Add request log parsing utility pbrezina commented: """ I look into Fedora python packaging guidelines and we can use [py3_shebang_fix](https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#py3_shebang_fix) macro instead of --with-python-bin and autoconf. This looks like a cleaner approach. """ See the full comment at https://github.com/SSSD/sssd/pull/5712#issuecomment-939872088 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][-Waiting for review] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. Label: -Waiting for review ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][+Ready to push] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. Label: +Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][+Accepted] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5766][comment] Sources cleanup - part 3.
URL: https://github.com/SSSD/sssd/pull/5766 Title: #5766: Sources cleanup - part 3. pbrezina commented: """ Thank you. Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/5766#issuecomment-939859888 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
[SSSD] [sssd PR#5821][opened] monitor: fix unused variable warning
URL: https://github.com/SSSD/sssd/pull/5821 Author: pbrezina Title: #5821: monitor: fix unused variable warning Action: opened PR body: """ ``` src/monitor/monitor.c: In function ‘get_monitor_config’: src/monitor/monitor.c:898:9: error: unused variable ‘timeout_seconds’ [-Werror=unused-variable] 898 | int timeout_seconds; ``` Introduced in c4c0fd690d82f9a8a714784ad4e036a39e1017fc. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5821/head:pr5821 git checkout pr5821 From 5697e222d9ca2a2a484a0f256b1c89b3d2fa7c56 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Mon, 11 Oct 2021 11:34:46 +0200 Subject: [PATCH] monitor: fix unused variable warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ``` src/monitor/monitor.c: In function ‘get_monitor_config’: src/monitor/monitor.c:898:9: error: unused variable ‘timeout_seconds’ [-Werror=unused-variable] 898 | int timeout_seconds; ``` Introduced in c4c0fd690d82f9a8a714784ad4e036a39e1017fc. --- src/monitor/monitor.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c index 8ea6d8e87a..42def74510 100644 --- a/src/monitor/monitor.c +++ b/src/monitor/monitor.c @@ -895,7 +895,6 @@ static int get_service_user(struct mt_ctx *ctx) static int get_monitor_config(struct mt_ctx *ctx) { int ret; -int timeout_seconds; char *badsrv = NULL; int i; ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure