ehlo, We should set pagging flag in state and not in local variable which is not read anywhere in the function.
Found by clang static analyzer. Do we need this patch also to stable branch? LS
>From 6fb265fc7a41f037e3a380a4af7c60d513f48df4 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik <lsleb...@redhat.com> Date: Tue, 30 Aug 2016 16:39:49 +0200 Subject: [PATCH 2/2] SDAP: Fix settig paging attribute in sdap_get_generic_ext_send We should set pagging flag in state and not in local variable which is not read anywhere in the function. Found by clang static analyzer. --- src/providers/ldap/sdap_async.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/providers/ldap/sdap_async.c b/src/providers/ldap/sdap_async.c index 4195ba95d911f3956f8cca665310b4b92091e6cd..e9ce2d5fd7c835919fff615e7b553d95f72d65a7 100644 --- a/src/providers/ldap/sdap_async.c +++ b/src/providers/ldap/sdap_async.c @@ -1254,7 +1254,7 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx, */ if (scope == LDAP_SCOPE_BASE && (flags & SDAP_SRCH_FLG_PAGING)) { /* Disable paging */ - flags &= ~SDAP_SRCH_FLG_PAGING; + state->flags &= ~SDAP_SRCH_FLG_PAGING; DEBUG(SSSDBG_TRACE_FUNC, "WARNING: Disabling paging because scope is set to base.\n"); } @@ -1267,7 +1267,7 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx, serverctrls, NULL); if (control) { - flags |= SDAP_SRCH_FLG_PAGING; + state->flags |= SDAP_SRCH_FLG_PAGING; } /* ASQ */ @@ -1275,7 +1275,7 @@ sdap_get_generic_ext_send(TALLOC_CTX *memctx, serverctrls, NULL); if (control) { - flags |= SDAP_SRCH_FLG_PAGING; + state->flags |= SDAP_SRCH_FLG_PAGING; } for (state->nserverctrls=0; -- 2.9.3
_______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org