Re: [SSSD] [PATCH] Temporarily disable automatic config file reread

2009-09-25 Thread Simo Sorce
On Thu, 2009-09-24 at 09:09 -0400, Stephen Gallagher wrote:
 The backends do not honor the reloadConfig SBUS message right now,
 so if an admin changes the sssd.conf file, it will update only the
 monitor, potentially leaving the SSSD as a whole in a bad state.
 
 This patch will simply comment out monitor_config_file() for the
 time being until https://fedorahosted.org/sssd/ticket/91 is fixed.

ack

Simo.

___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel


[SSSD] [PATCH] Temporarily disable automatic config file reread

2009-09-24 Thread Stephen Gallagher
The backends do not honor the reloadConfig SBUS message right now,
so if an admin changes the sssd.conf file, it will update only the
monitor, potentially leaving the SSSD as a whole in a bad state.

This patch will simply comment out monitor_config_file() for the
time being until https://fedorahosted.org/sssd/ticket/91 is fixed.

-- 
Stephen Gallagher
RHCE 804006346421761

Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
From 00d40204580b418fa71c1390650d8d43a1aaebcc Mon Sep 17 00:00:00 2001
From: Stephen Gallagher sgall...@redhat.com
Date: Thu, 24 Sep 2009 08:59:03 -0400
Subject: [PATCH 1/2] Temporarily disable automatic config file reread

The backends do not honor the reloadConfig SBUS message right now,
so if an admin changes the sssd.conf file, it will update only the
monitor, potentially leaving the SSSD as a whole in a bad state.

This patch will simply comment out monitor_config_file() for the
time being until https://fedorahosted.org/sssd/ticket/91 is fixed.
---
 server/monitor/monitor.c |8 +++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/server/monitor/monitor.c b/server/monitor/monitor.c
index 44ce5f2..39cc291 100644
--- a/server/monitor/monitor.c
+++ b/server/monitor/monitor.c
@@ -1864,12 +1864,18 @@ int monitor_process_init(struct mt_ctx *ctx,
 int ret, i;
 struct sss_domain_info *dom;
 
+#if 0
+This feature is incomplete and can leave the SSSD in a bad state if the
+config file is changed while the SSSD is running.
+
+Uncomment this once the backends are honoring reloadConfig()
+
 /* Watch for changes to the confdb config file */
 ret = monitor_config_file(ctx, ctx, config_file, monitor_signal_reconf);
 if (ret != EOK) {
 return ret;
 }
-
+#endif
 /* Watch for changes to the DNS resolv.conf */
 ret = monitor_config_file(ctx, ctx, RESOLV_CONF_PATH,
   monitor_update_resolv);
-- 
1.6.2.5



signature.asc
Description: OpenPGP digital signature
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://fedorahosted.org/mailman/listinfo/sssd-devel