[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 11:49:09AM -0700, lslebodn wrote: > IMHO, it might be better to close this PR. > If we decide to dor support for libini_config < 1.1 or 1.2 > then it will be a different patch anyway. @see my previous comment The only reason I suggest deferred over closing is that if we close this PR, we will never remember to ressurect it. If it's going to be deferred, it will keep coming up in the PR list. """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-245204278 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)
lslebodn commented on a pull request """ IMHO, it might be better to close this PR. If we decide to dor support for libini_config < 1.1 or 1.2 then it will be a different patch anyway. @see my previous comment """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-245050796 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)
lslebodn commented on a pull request """ On (06/09/16 05:16), fidencio wrote: >The distributions that would break with this patch are: >- RHEL/CentOS 5 and older >- Debian Wheezy (from 2013) and older >- Ubuntu 12.04 LTS and older > >I was not able to find what's the version of the package on SLES > * libini_config-0.7.0 is feature wise the same as libini_config-1.0 sssd uses it for basic parsing of ini files * libini_config-1.1 is an optional feature used in ad provider for parsing gpo files * libini_config-1.2 provides optional feature for config snippets in /etc/sssd/conf.d * libini_config-1.3 provides optional feature for validation of ini files After this patch we still have 3 optional features provided by different versions of libini_config. If we want to drop support for older version of libini_config and siplify the wrapper then I would drop support for libini_config < 1.3 and remove wrappers in src/util/sss_ini.c However, libini_config-1.3 is only in fedora. LS """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-244937445 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)
jhrozek commented on a pull request """ On Tue, Sep 06, 2016 at 05:16:00AM -0700, fidencio wrote: > The distributions that would break with this patch are: > - RHEL/CentOS 5 and older I don't think we care about RHEL-5 with master and I'm not sure sssd master even builds there. > - Debian Wheezy (from 2013) and older OK, this one I think we care about for the basic functionality: 7.0 Wheezy May 4th 2013 April 26th 2016 (full) / May 2018 (LTS) But LTS means bug fixes and for those I think sssd-1-13 would be OK. > - Ubuntu 12.04 LTS and older 12.04 is often used (for example travis-ci still offers only this distro) and ends its life in 2017. On one hand, it's unlikely that users of LTS distributions will run master, they will probably only run sssd-1-13 or some PPAs, on the other hand, I don't see too much value except for cleaner code. So all in all I suggest we nack this patchset for now and push it when Ubuntu 12.04 goes EOL. Does that sound like a reasonable compromise? """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-244935329 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)
fidencio commented on a pull request """ The distributions that would break with this patch are: - RHEL/CentOS 5 and older - Debian Wheezy (from 2013) and older - Ubuntu 12.04 LTS and older I was not able to find what's the version of the package on SLES """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-244932095 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)
jhrozek commented on a pull request """ On Thu, Sep 01, 2016 at 09:01:54AM -0700, lslebodn wrote: > On (01/09/16 08:35), fidencio wrote: > >On Thu, Sep 1, 2016 at 2:10 PM, lslebodn wrote: > > > >> On (01/09/16 04:32), Jakub Hrozek wrote: > >> >On Thu, Sep 01, 2016 at 03:21:06AM -0700, fidencio wrote: > >> >> On Thu, Sep 1, 2016 at 11:54 AM, lslebodn > >> wrote: > >> >> > > >> >> > On (31/08/16 23:18), fidencio wrote: > >> >> > >libini 1.0.0 is part of ding-libs 0.3.0 and has been around since > >> 2013. > >> >> > >Even the old systems that we have to support already have a newer > >> >> > >version of the library. RHEL6, for instance, has ding-libs 0.4.0 > >> which > >> >> > >provides libinit 1.1.0. > >> >> > > > >> >> > >By removing this code we also can stop depending on libcollection. > >> >> > > > >> >> > >Signed-off-by: Fabiano Fidêncio > >> >> > >You can view, comment on, or merge this pull request online at: > >> >> > > > >> >> > > https://github.com/SSSD/sssd/pull/10 > >> >> > > > >> >> > >-- Commit Summary -- > >> >> > > > >> >> > > * UTIL: Remove support to libini older than 1.0.0 > >> >> > > > >> >> > >-- File Changes -- > >> >> > > > >> >> > > M configure.ac (1) > >> >> > > M contrib/ci/deps.sh (1) > >> >> > > M contrib/sssd.spec.in (1) > >> >> > > D src/external/libcollection.m4 (9) > >> >> > > M src/util/sss_ini.c (97) > >> >> > > > >> >> > >-- Patch Links -- > >> >> > > > >> >> > >https://github.com/SSSD/sssd/pull/10.patch > >> >> > >https://github.com/SSSD/sssd/pull/10.diff > >> >> > > > >> >> > OpenSUSE LEAP has just ding-libs 0.3.0.1 in official repositories. > >> >> > http://software.opensuse.org/package/ding-libs?search_term=ding-libs > >> >> > >> >> Yep. OpenSUSE LEAP has 0.3.0.1, Debian Stable (Jessie) has 0.4.0, > >> >> latest Ubuntu LTS has 0.5.0. > >> >> And all of them would be able to build SSSD with my patch without any > >> issues. > >> > > >> >Two questions: > >> > 1) how long until the distributions with too old ding-libs go out of > >> > support? > >> > > > >Hmm. Unfortunately I don't have an answer for you. > >What are the major distributions that we want to support? Debian, Ubuntu > >LTS, RHEL, SLES ...? > > > I would prefer if limited version of sssd (ldap + krb5 provider) > could be compiled almost anywhere. (even old distributions) > It is not only about major distributions. > > > > >> > 2) since we will be (likely) supporting sssd-1-13 for the lifetime > >> > of RHEL-6, can we say that the old distributions just use sssd-1-13? > >> > > >> libini_config-1.0 does not provide any new functionality > >> which is not in libini_config < 1.0 > >> > > > >> They have just a different API (and moreover libini_config-1.0 > >> still provides old API) (at least from sssd POV) > >> > > > >There's no new functionality, true. But there's a quite good API > >simplification > I agree that API is better. > But feature wise are the same. So if we wanted to drop > support for libini_config < 1.0 then we could > drop support for libini_config-1.0. > It would simplify more things in sssd > > However, OpenSUSE LEAP has just a libini_config-1.0 This PR has stalled somehow. Can we either move it forward or reject? I admit I got a bit lost in the comments, which distributions would we break with this patch? Are any of them supported/will be supported in th near future? """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-244928774 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#10] UTIL: Remove support to libini older than 1.0.0 (comment)
lslebodn commented on a pull request """ On (01/09/16 08:35), fidencio wrote: >On Thu, Sep 1, 2016 at 2:10 PM, lslebodn wrote: > >> On (01/09/16 04:32), Jakub Hrozek wrote: >> >On Thu, Sep 01, 2016 at 03:21:06AM -0700, fidencio wrote: >> >> On Thu, Sep 1, 2016 at 11:54 AM, lslebodn >> wrote: >> >> > >> >> > On (31/08/16 23:18), fidencio wrote: >> >> > >libini 1.0.0 is part of ding-libs 0.3.0 and has been around since >> 2013. >> >> > >Even the old systems that we have to support already have a newer >> >> > >version of the library. RHEL6, for instance, has ding-libs 0.4.0 >> which >> >> > >provides libinit 1.1.0. >> >> > > >> >> > >By removing this code we also can stop depending on libcollection. >> >> > > >> >> > >Signed-off-by: Fabiano Fidêncio >> >> > >You can view, comment on, or merge this pull request online at: >> >> > > >> >> > > https://github.com/SSSD/sssd/pull/10 >> >> > > >> >> > >-- Commit Summary -- >> >> > > >> >> > > * UTIL: Remove support to libini older than 1.0.0 >> >> > > >> >> > >-- File Changes -- >> >> > > >> >> > > M configure.ac (1) >> >> > > M contrib/ci/deps.sh (1) >> >> > > M contrib/sssd.spec.in (1) >> >> > > D src/external/libcollection.m4 (9) >> >> > > M src/util/sss_ini.c (97) >> >> > > >> >> > >-- Patch Links -- >> >> > > >> >> > >https://github.com/SSSD/sssd/pull/10.patch >> >> > >https://github.com/SSSD/sssd/pull/10.diff >> >> > > >> >> > OpenSUSE LEAP has just ding-libs 0.3.0.1 in official repositories. >> >> > http://software.opensuse.org/package/ding-libs?search_term=ding-libs >> >> >> >> Yep. OpenSUSE LEAP has 0.3.0.1, Debian Stable (Jessie) has 0.4.0, >> >> latest Ubuntu LTS has 0.5.0. >> >> And all of them would be able to build SSSD with my patch without any >> issues. >> > >> >Two questions: >> > 1) how long until the distributions with too old ding-libs go out of >> > support? >> > >Hmm. Unfortunately I don't have an answer for you. >What are the major distributions that we want to support? Debian, Ubuntu >LTS, RHEL, SLES ...? > I would prefer if limited version of sssd (ldap + krb5 provider) could be compiled almost anywhere. (even old distributions) It is not only about major distributions. > >> > 2) since we will be (likely) supporting sssd-1-13 for the lifetime >> > of RHEL-6, can we say that the old distributions just use sssd-1-13? >> > >> libini_config-1.0 does not provide any new functionality >> which is not in libini_config < 1.0 >> > >> They have just a different API (and moreover libini_config-1.0 >> still provides old API) (at least from sssd POV) >> > >There's no new functionality, true. But there's a quite good API >simplification I agree that API is better. But feature wise are the same. So if we wanted to drop support for libini_config < 1.0 then we could drop support for libini_config-1.0. It would simplify more things in sssd However, OpenSUSE LEAP has just a libini_config-1.0 >and we can stop depending on libcollection. > libini_config-devel depends on libcollection-devel :-) and it's a very tiny dependency. sh$ rpm -q --requires libini_config-devel /usr/bin/pkg-config libbasicobjects-devel = 0.1.1-29.fc25 libcollection-devel = 0.7.0-29.fc25 libini_config = 1.3.0-29.fc25 libini_config.so.5()(64bit) libref_array-devel = 0.1.5-29.fc25 pkgconfig(basicobjects) pkgconfig(collection) pkgconfig(ref_array) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 We would not reduce our dependency chain. LS """ See the full comment at https://github.com/SSSD/sssd/pull/10#issuecomment-244127101 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
