[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-07 Thread jhrozek
jhrozek commented on a pull request

"""
On Tue, Sep 06, 2016 at 10:23:13AM -0700, mzidek-rh wrote:
> The PR#16 includes jhrozek's patch from this PR as well as CI test + fix for 
> sss_groupshow.

OK, thank you, I will close this one as rejected (just so that we don't
track the PR any longer..)

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/14#issuecomment-245260472
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread lslebodn
lslebodn commented on a pull request

"""
On (06/09/16 04:57), Jakub Hrozek wrote:
>On Tue, Sep 06, 2016 at 04:54:29AM -0700, lslebodn wrote:
>> On (06/09/16 03:14), Jakub Hrozek wrote:
>> >The log said:
>> >(Tue Sep  6 15:18:31:935105 2016) [sss_groupadd] 
>> >[sysdb_timestamp_cache_connect] (0x0400): No timestamp cache for LOCAL
>> >(Tue Sep  6 15:18:31:935255 2016) [sss_groupadd] [sss_names_init_from_args] 
>> >(0x0100): Using re [(?P[^@]+)@?(?P[^@]*$)].
>> >(Tue Sep  6 15:18:31:935277 2016) [sss_groupadd] [sss_fqnames_init] 
>> >(0x0100): Using fq format [%1$s@%2$s].
>> >(Tue Sep  6 15:18:31:935392 2016) [sss_groupadd] [parse_name_domain] 
>> >(0x0200): Parsed username: group1
>> >(Tue Sep  6 15:18:31:935418 2016) [sss_groupadd] [ldb] (0x4000): start ldb 
>> >transaction (nesting: 0)
>> >(Tue Sep  6 15:18:31:935504 2016) [sss_groupadd] [ldb] (0x4000): cancel ldb 
>> >transaction (nesting: 0)
>> >(Tue Sep  6 15:18:31:935629 2016) [sss_groupadd] [main] (0x0020): sysdb 
>> >operation failed (12)[Cannot allocate memory]
>> 
>> NACK.
>> 
>> I miss an integration test.
>> We already have some for localprovider in src/tests/intg/test_local_domain.py
>
>Fair enough, I will add it later.
>
I hope it will not ate such log as integration test for
https://fedorahosted.org/sssd/ticket/3045 :-)

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/14#issuecomment-244928742
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread jhrozek
jhrozek commented on a pull request

"""
On Tue, Sep 06, 2016 at 04:54:29AM -0700, lslebodn wrote:
> On (06/09/16 03:14), Jakub Hrozek wrote:
> >The log said:
> >(Tue Sep  6 15:18:31:935105 2016) [sss_groupadd] 
> >[sysdb_timestamp_cache_connect] (0x0400): No timestamp cache for LOCAL
> >(Tue Sep  6 15:18:31:935255 2016) [sss_groupadd] [sss_names_init_from_args] 
> >(0x0100): Using re [(?P[^@]+)@?(?P[^@]*$)].
> >(Tue Sep  6 15:18:31:935277 2016) [sss_groupadd] [sss_fqnames_init] 
> >(0x0100): Using fq format [%1$s@%2$s].
> >(Tue Sep  6 15:18:31:935392 2016) [sss_groupadd] [parse_name_domain] 
> >(0x0200): Parsed username: group1
> >(Tue Sep  6 15:18:31:935418 2016) [sss_groupadd] [ldb] (0x4000): start ldb 
> >transaction (nesting: 0)
> >(Tue Sep  6 15:18:31:935504 2016) [sss_groupadd] [ldb] (0x4000): cancel ldb 
> >transaction (nesting: 0)
> >(Tue Sep  6 15:18:31:935629 2016) [sss_groupadd] [main] (0x0020): sysdb 
> >operation failed (12)[Cannot allocate memory]
> 
> NACK.
> 
> I miss an integration test.
> We already have some for localprovider in src/tests/intg/test_local_domain.py

Fair enough, I will add it later.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/14#issuecomment-244928302
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread lslebodn
lslebodn commented on a pull request

"""
On (06/09/16 03:14), Jakub Hrozek wrote:
>The log said:
>(Tue Sep  6 15:18:31:935105 2016) [sss_groupadd] 
>[sysdb_timestamp_cache_connect] (0x0400): No timestamp cache for LOCAL
>(Tue Sep  6 15:18:31:935255 2016) [sss_groupadd] [sss_names_init_from_args] 
>(0x0100): Using re [(?P[^@]+)@?(?P[^@]*$)].
>(Tue Sep  6 15:18:31:935277 2016) [sss_groupadd] [sss_fqnames_init] (0x0100): 
>Using fq format [%1$s@%2$s].
>(Tue Sep  6 15:18:31:935392 2016) [sss_groupadd] [parse_name_domain] (0x0200): 
>Parsed username: group1
>(Tue Sep  6 15:18:31:935418 2016) [sss_groupadd] [ldb] (0x4000): start ldb 
>transaction (nesting: 0)
>(Tue Sep  6 15:18:31:935504 2016) [sss_groupadd] [ldb] (0x4000): cancel ldb 
>transaction (nesting: 0)
>(Tue Sep  6 15:18:31:935629 2016) [sss_groupadd] [main] (0x0020): sysdb 
>operation failed (12)[Cannot allocate memory]

NACK.

I miss an integration test.
We already have some for localprovider in src/tests/intg/test_local_domain.py

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/14#issuecomment-244927717
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread mzidek-rh
mzidek-rh commented on a pull request

"""
I see the error with the sss_groupshow. Will send patch in another PR.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/14#issuecomment-244920668
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread mzidek-rh
mzidek-rh commented on a pull request

"""
The patch works. I pushed it to CI, waiting for results.

As I tested the local provider now, I found that the sss_groupshow does not 
seem to work. Will check why. But it is not related to this patch.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/14#issuecomment-244919926
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org


[SSSD] [sssd PR#14] Attempting to create a qualified name from a NULL pointer broke sss_groupadd (comment)

2016-09-06 Thread fidencio
fidencio commented on a pull request

"""
Patch works as expected but I wasn't able to run CI tests on it* due to some 
connection issue to the CI machine.

*: Well, I ran it locally and it passed.

Please, if possible, run the CI as feel free to push as soon as it passes.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/14#issuecomment-244917498
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org