[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread lslebodn 
lslebodn commented on a pull request

"""
On (07/09/16 09:51), fidencio wrote:
>A few minors in the commit messages that should be fixed before pushing.
>
>Patch0001: TOOLS: Fix a typo in groupadd()
>Remove the four spaces before the link of the trac ticket.
>
>Patch0002: TOOLS: sss_groupshow did not work
>Patch0003: TESTS: sss_groupadd/groupshow regressions
>Patch0004: TOOLS: use internal fqdn for DN
>Patch0006: TOOLS: sss_mc_refresh_nested_group short/fqname usage
>Patch0007: TESTS: Add FQDN variants for some tests
>Use (but do not exceed) 72 characters in the commit (body) message. I have the 
>feeling you're breaking the line with 52.
>
Changed together with adding review-by

ACK

http://sssd-ci.duckdns.org/logs/job/53/01/summary.html

master:
* f2d1d90a14267c01155eab7bb95b8eb34128acc9
* cb54dbad6be907d277ce6aa39524338643e2f5a4
* 7fa4964d84f41bd80a6d971ffaeef87a7c2f19be
* 5e2142b66589e5e50cb404fc972ed5418bbaa772
* 20c2d76d9430a1fc069531ff537df046a74c8f61
* 5210c5d3a5a83b5d08396ee23d88f6ba0994097d
* 6be723a089a1e07a1cd19b4fa53fd142c13f0c69

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/18#issuecomment-245377110
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread fidencio 
fidencio commented on a pull request

"""
A few minors in the commit messages that should be fixed before pushing.

Patch0001: TOOLS: Fix a typo in groupadd()
Remove the four spaces before the link of the trac ticket.

Patch0002: TOOLS: sss_groupshow did not work
Patch0003: TESTS: sss_groupadd/groupshow regressions
Patch0004: TOOLS: use internal fqdn for DN
Patch0006: TOOLS: sss_mc_refresh_nested_group short/fqname usage
Patch0007: TESTS: Add FQDN variants for some tests
Use (but do not exceed) 72 characters in the commit (body) message. I have the 
feeling you're breaking the line with 52.

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/18#issuecomment-245345440
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread lslebodn 
lslebodn commented on a pull request

"""
On (07/09/16 07:18), mzidek-rh wrote:
>Hi,
>
>This PR is blocked by PR#16 (TOOLS: sss_groupshow did not work). It includes 
>fix for the ticket https://fedorahosted.org/sssd/ticket/3178.
>
>Michal
>You can view, comment on, or merge this pull request online at:
>
>  https://github.com/SSSD/sssd/pull/18
>
6th patch
src/tools/tools_mc_util.c
 if (ret != EOK) {
 DEBUG(SSSDBG_MINOR_FAILURE, "Malformed DN [%s]? Skipping\n",
   (const char *) el->values[i].data);
-talloc_free(parent_name);
+talloc_free(parent_internal_name);
 continue;
 }
 
-ret = sss_mc_refresh_group(parent_name);
-talloc_free(parent_name);
+ret = sss_parse_internal_fqname(tmpctx, parent_internal_name,
+&parent_shortname, NULL);
 we should use sss_output_name here

+if (ret != EOK) {
+DEBUG(SSSDBG_MINOR_FAILURE, "Could not parse name %s\n",
+  parent_internal_name);
+goto done;
+}
+
+ret = sss_mc_refresh_group(parent_shortname);
+talloc_free(parent_internal_name);
+talloc_free(parent_shortname);

otherwise LGTM

LS

"""

See the full comment at 
https://github.com/SSSD/sssd/pull/18#issuecomment-245334928
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread mzidek-rh 
mzidek-rh commented on a pull request

"""
Thanks for the tip Nick.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/18#issuecomment-245304406
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] [sssd PR#18] [PATCHES] sss_user/groupmod fixes (comment)

2016-09-07 Thread spbnick 
spbnick commented on a pull request

"""
Just a hint: if you avoid putting "PR" in front of the PR#16, then you'll get a 
link to the actual pull request on the GitHub page, plus the target pull 
request will have a link back. Like this: #16.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/18#issuecomment-245302411
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org