[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

fidencio commented:
"""
master:
 e6e5fe3
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/551#issuecomment-384948486
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-18 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

jhrozek commented:
"""
The GPO automated RHEL passed (Job ID:2432777). I haven't done the manual tests 
yet to verify this bug.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/551#issuecomment-382486398
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-18 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

jhrozek commented:
"""
OK, I will test and review this PR.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/551#issuecomment-382315559
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-17 Thread rdratlos 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

rdratlos commented:
"""
Hi Michal,,
of course your PR should continue to be reviewed. My intention was just to 
present an alternative approach based on some analysis half a year ago that 
guided me to SID merging. After some further testing and analysis today, I 
would recommend to fix issue [#3680](https://pagure.io/SSSD/sssd/issue/3680) 
based on your proposal.

But what I'd like to propose is to add an explanation and references to 
function ad_gpo_cse_done() how GPO settings are to be merged and overridden. 
This should prevent a third or fourth contributor showing up and wanting to 
implement SID merging :-).

Kind regards

Thomas
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/551#issuecomment-382187714
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-17 Thread mzidek-rh 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

mzidek-rh commented:
"""
Hi @rdratlos ,
the PR #552 does not solve the problem described in issue 
https://pagure.io/SSSD/sssd/issue/3680 .
The changes made in that PR seem to be unrelated to the empty rule bug. I think 
you tried to implement the SID merging there which is a different thing. I will 
add my comments on this in that PR.

So this PR is still valid and needs to be reviewed.

Michal
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/551#issuecomment-381964958
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-14 Thread rdratlos 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

rdratlos commented:
"""
I believe this PR only fixes symptoms of the real root cause for 
[#3680](https://pagure.io/SSSD/sssd/issue/3680). 

Please check  #552 which proposes a more sophisticated solution before merging 
this PR. 
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/551#issuecomment-381345954
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org