[SSSD] [sssd PR#713][comment] krb5_child: fix permissions during SC auth
URL: https://github.com/SSSD/sssd/pull/713 Title: #713: krb5_child: fix permissions during SC auth jhrozek commented: """ * master: e49e9f727e4960c8a0a2ed50488dac6e51ddf284 """ See the full comment at https://github.com/SSSD/sssd/pull/713#issuecomment-446930695 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#713][comment] krb5_child: fix permissions during SC auth
URL: https://github.com/SSSD/sssd/pull/713 Title: #713: krb5_child: fix permissions during SC auth sumit-bose commented: """ np, new version has the corrected link. Thanks for doing the paperwork. """ See the full comment at https://github.com/SSSD/sssd/pull/713#issuecomment-446855902 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#713][comment] krb5_child: fix permissions during SC auth
URL: https://github.com/SSSD/sssd/pull/713 Title: #713: krb5_child: fix permissions during SC auth jhrozek commented: """ Thank you. As discussed on IRC, I filed a separate ticket https://pagure.io/SSSD/sssd/issue/3903 as the issue is a bit different from the generic 'can't access ccache as root' tracked in #3376. I can just fix the ticket link before pushing -- please shout if that's not OK with you. """ See the full comment at https://github.com/SSSD/sssd/pull/713#issuecomment-446759931 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#713][comment] krb5_child: fix permissions during SC auth
URL: https://github.com/SSSD/sssd/pull/713 Title: #713: krb5_child: fix permissions during SC auth sumit-bose commented: """ The latest version has the ret assignment removed. """ See the full comment at https://github.com/SSSD/sssd/pull/713#issuecomment-446603494 ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
[SSSD] [sssd PR#713][comment] krb5_child: fix permissions during SC auth
URL: https://github.com/SSSD/sssd/pull/713
Title: #713: krb5_child: fix permissions during SC auth
jhrozek commented:
"""
In general this looks good, but please fix this clang warning:
```
Error: CLANG_WARNING:
sssd-2.0.99/src/providers/krb5/krb5_child.c:1759:13: warning: Value stored to
'ret' is never read
#ret = EFAULT;
#^ ~~
sssd-2.0.99/src/providers/krb5/krb5_child.c:1759:13: note: Value stored to
'ret' is never read
#ret = EFAULT;
#^ ~~
# 1757| if (kerr != 0) {
# 1758| DEBUG(SSSDBG_CRIT_FAILURE, "become_user failed.\n");
# 1759|-> ret = EFAULT;
# 1760| goto done;
# 1761| }
(The function returns the value of kerr, not ret)
```
"""
See the full comment at
https://github.com/SSSD/sssd/pull/713#issuecomment-446533287
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedorahosted.org/archives/list/sssd-devel@lists.fedorahosted.org
