subject:"\[SSSD\] Re\: \[SSSD\} \[PATCH\] Remove no longer used code"

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

2016-08-30 Thread Lukas Slebodnik

On (30/08/16 09:41), Petr Cech wrote:
>On 08/30/2016 08:47 AM, Petr Cech wrote:
>> 
>> 
>> On 08/30/2016 08:28 AM, Fabiano Fidêncio wrote:
>> > On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech  wrote:
>> > > On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:
>> > > > 
>> > > > Those 3 patches are from Jakub and I've just done some minor
>> > > > adjustments and add myself as co-author of the first 2 patches.
>> > > > 
>> > > > CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
>> > > > 
>> > > > Best Regards,
>> > > > --
>> > > > Fabiano Fidêncio
>> > > 
>> > > 
>> > > Hello,
>> > > 
>> > > CI passed:
>> > > http://sssd-ci.duckdns.org/logs/job/52/71/summary.html
>> > > 
>> > > > 0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch
>> > > > 
>> > > > 
>> > > > From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001
>> > > > From: Jakub Hrozek 
>> > > > Date: Sun, 8 May 2016 14:41:35 +0200
>> > > > Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd
>> > > > command
>> > > > MIME-Version: 1.0
>> > > > Content-Type: text/plain; charset=UTF-8
>> > > > Content-Transfer-Encoding: 8bit
>> > > > 
>> > > > After introducing the watchdog, the diag_cmd is longer used and
>> > > > makes no
>> > > > sense trying to make it usable by watchdog as the result of "pstack %p"
>> > > > seems next to useless in this context.
>> > > > 
>> > > > Co-author: Fabiano Fidêncio 
>> > > > 
>> > > > Related:
>> > > > https://fedorahosted.org/sssd/ticket/3051
>> > > > ---
>> > > 
>> > > 
>> > > ACK
>> > > 
>> > > 
>> > > > 0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch
>> > > > 
>> > > > 
>> > > > From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001
>> > > > From: Jakub Hrozek 
>> > > > Date: Sun, 8 May 2016 14:46:25 +0200
>> > > > Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service
>> > > > command
>> > > > MIME-Version: 1.0
>> > > > Content-Type: text/plain; charset=UTF-8
>> > > > Content-Transfer-Encoding: 8bit
>> > > > 
>> > > > After introducing the watchdog, the force_timeout option is no longer
>> > > > used.
>> > > > 
>> > > > Co-author: Fabiano Fidêncio 
>> > > > 
>> > > > Resolves:
>> > > > https://fedorahosted.org/sssd/ticket/3052
>> > > > ---
>> > > 
>> > > 
>> > > ACK
>> > > 
>> > > 
>> > > > 0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
>> > > > 
>> > > > 
>> > > > From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001
>> > > > From: Jakub Hrozek 
>> > > > Date: Mon, 15 Aug 2016 12:54:20 +0200
>> > > > Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3
>> > > > 
>> > > > Instead of using the number 3 directly, let's introduce and use
>> > > > WATCHDOG_MAX_TICKS.
>> > > > --
>> > > 
>> > > 
>> > > This patch is unfortunately inapplicable on top of master
>> > > (after two previous patches):
>> > > 
>> > > pcech@albireo ~/sssd: (master) $ git am
>> > > ../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
>> > > Applying: WATCHDOG: define and use _MAX_TICKS as 3
>> > > error: patch failed: src/util/util_watchdog.c:38
>> > > error: src/util/util_watchdog.c: patch does not apply
>> > > Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3
>> > > 
>> > > Regards
>> > 
>> > Rebase was quite simple.
>> > See the v2 attached (the only change in v2 was the rebase).
>> 
>> Thanks, Fabiano,
>> 
>> I pushed patches to CI so quickly I missed
>> that the 3rd patch is LGTM and almost ACK :-)
>> 
>> I would like to wait to CI anyway.
>
>CI passed:
>http://sssd-ci.duckdns.org/logs/job/52/73/summary.html
>
>=> ACK
>
master:
* d7075a255a1f28e890539072e06d0140ffe0927c
* fa93cd0f0fc75a6d635079e67788f8a9fe183c3c
* 1620f435dbe7013f985128dcdf001e9158cb00e3

LS
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

2016-08-30 Thread Petr Cech




On 08/30/2016 08:28 AM, Fabiano Fidêncio wrote:

On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech  wrote:

On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:


Those 3 patches are from Jakub and I've just done some minor
adjustments and add myself as co-author of the first 2 patches.

CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html

Best Regards,
--
Fabiano Fidêncio



Hello,

CI passed:
http://sssd-ci.duckdns.org/logs/job/52/71/summary.html


0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch


From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Sun, 8 May 2016 14:41:35 +0200
Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

After introducing the watchdog, the diag_cmd is longer used and makes no
sense trying to make it usable by watchdog as the result of "pstack %p"
seems next to useless in this context.

Co-author: Fabiano Fidêncio 

Related:
https://fedorahosted.org/sssd/ticket/3051
---



ACK



0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch


From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Sun, 8 May 2016 14:46:25 +0200
Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service
command
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

After introducing the watchdog, the force_timeout option is no longer
used.

Co-author: Fabiano Fidêncio 

Resolves:
https://fedorahosted.org/sssd/ticket/3052
---



ACK



0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch


From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Mon, 15 Aug 2016 12:54:20 +0200
Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3

Instead of using the number 3 directly, let's introduce and use
WATCHDOG_MAX_TICKS.
--



This patch is unfortunately inapplicable on top of master
(after two previous patches):

pcech@albireo ~/sssd: (master) $ git am
../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
Applying: WATCHDOG: define and use _MAX_TICKS as 3
error: patch failed: src/util/util_watchdog.c:38
error: src/util/util_watchdog.c: patch does not apply
Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3

Regards


Rebase was quite simple.
See the v2 attached (the only change in v2 was the rebase).


Thanks, Fabiano,

I pushed patches to CI so quickly I missed
that the 3rd patch is LGTM and almost ACK :-)

I would like to wait to CI anyway.

Regards

--
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

2016-08-30 Thread Fabiano Fidêncio

On Tue, Aug 30, 2016 at 8:23 AM, Petr Cech  wrote:
> On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:
>>
>> Those 3 patches are from Jakub and I've just done some minor
>> adjustments and add myself as co-author of the first 2 patches.
>>
>> CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
>>
>> Best Regards,
>> --
>> Fabiano Fidêncio
>
>
> Hello,
>
> CI passed:
> http://sssd-ci.duckdns.org/logs/job/52/71/summary.html
>
>> 0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch
>>
>>
>> From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001
>> From: Jakub Hrozek 
>> Date: Sun, 8 May 2016 14:41:35 +0200
>> Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> After introducing the watchdog, the diag_cmd is longer used and makes no
>> sense trying to make it usable by watchdog as the result of "pstack %p"
>> seems next to useless in this context.
>>
>> Co-author: Fabiano Fidêncio 
>>
>> Related:
>> https://fedorahosted.org/sssd/ticket/3051
>> ---
>
>
> ACK
>
>
>> 0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch
>>
>>
>> From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001
>> From: Jakub Hrozek 
>> Date: Sun, 8 May 2016 14:46:25 +0200
>> Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service
>> command
>> MIME-Version: 1.0
>> Content-Type: text/plain; charset=UTF-8
>> Content-Transfer-Encoding: 8bit
>>
>> After introducing the watchdog, the force_timeout option is no longer
>> used.
>>
>> Co-author: Fabiano Fidêncio 
>>
>> Resolves:
>> https://fedorahosted.org/sssd/ticket/3052
>> ---
>
>
> ACK
>
>
>> 0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
>>
>>
>> From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001
>> From: Jakub Hrozek 
>> Date: Mon, 15 Aug 2016 12:54:20 +0200
>> Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3
>>
>> Instead of using the number 3 directly, let's introduce and use
>> WATCHDOG_MAX_TICKS.
>> --
>
>
> This patch is unfortunately inapplicable on top of master
> (after two previous patches):
>
> pcech@albireo ~/sssd: (master) $ git am
> ../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch
> Applying: WATCHDOG: define and use _MAX_TICKS as 3
> error: patch failed: src/util/util_watchdog.c:38
> error: src/util/util_watchdog.c: patch does not apply
> Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3
>
> Regards

Rebase was quite simple.
See the v2 attached (the only change in v2 was the rebase).

>
> ---
>
> Petr^4 Čech
> ___
> sssd-devel mailing list
> sssd-devel@lists.fedorahosted.org
> https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org
From 7579cf9982c86978500e9249ad3e82124867fc90 Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Sun, 8 May 2016 14:41:35 +0200
Subject: [PATCH v2 1/3] MONITOR: Remove the no longer used diag_cmd command

After introducing the watchdog, the diag_cmd is longer used and makes no
sense trying to make it usable by watchdog as the result of "pstack %p"
seems next to useless in this context.

Related:
https://fedorahosted.org/sssd/ticket/3051
---
 src/confdb/confdb.h   |   1 -
 src/monitor/monitor.c | 163 --
 2 files changed, 164 deletions(-)

diff --git a/src/confdb/confdb.h b/src/confdb/confdb.h
index 72adbd8..58a085b 100644
--- a/src/confdb/confdb.h
+++ b/src/confdb/confdb.h
@@ -73,7 +73,6 @@
 #define CONFDB_MONITOR_DEFAULT_DOMAIN "default_domain_suffix"
 #define CONFDB_MONITOR_OVERRIDE_SPACE "override_space"
 #define CONFDB_MONITOR_USER_RUNAS "user"
-#define CONFDB_MONITOR_PRE_KILL_CMD "diag_cmd"
 #define CONFDB_MONITOR_CERT_VERIFICATION "certificate_verification"
 
 /* Both monitor and domains */
diff --git a/src/monitor/monitor.c b/src/monitor/monitor.c
index 7a9ef56..f97b2a9 100644
--- a/src/monitor/monitor.c
+++ b/src/monitor/monitor.c
@@ -112,7 +112,6 @@ struct mt_svc {
 char *identity;
 pid_t pid;
 
-char *diag_cmd;
 int kill_time;
 
 struct tevent_timer *kill_timer;
@@ -373,77 +372,6 @@ static int add_svc_conn_spy(struct mt_svc *svc)
 return EOK;
 }
 
-static char *expand_diag_cmd(struct mt_svc *svc,
- const char *template)
-{
-TALLOC_CTX *tmp_ctx = NULL;
-char *copy;
-char *p_copy;
-char *n;
-char *result = NULL;
-char action;
-char *res = NULL;
-
-if (template == NULL) {
-DEBUG(SSSDBG_CRIT_FAILURE, "Missing template.\n");
-return NULL;
-}
-
-tmp_ctx = talloc_new(NULL);
-if (!tmp_ctx) return NULL;
-
-copy = talloc_strdup(tmp_ctx, template);
-if (copy == NULL) {
-DEBUG(SSSDBG_CRIT_FAILURE, "talloc_strdup

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

2016-08-30 Thread Petr Cech


On 08/15/2016 02:58 PM, Fabiano Fidêncio wrote:

Those 3 patches are from Jakub and I've just done some minor
adjustments and add myself as co-author of the first 2 patches.

CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html

Best Regards,
--
Fabiano Fidêncio


Hello,

CI passed:
http://sssd-ci.duckdns.org/logs/job/52/71/summary.html


0001-MONITOR-Remove-the-no-longer-used-diag_cmd-command.patch


From aa6204816cde0a7d75b9303916d038ed06e467ba Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Sun, 8 May 2016 14:41:35 +0200
Subject: [PATCH 1/3] MONITOR: Remove the no longer used diag_cmd command
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

After introducing the watchdog, the diag_cmd is longer used and makes no
sense trying to make it usable by watchdog as the result of "pstack %p"
seems next to useless in this context.

Co-author: Fabiano Fidêncio 

Related:
https://fedorahosted.org/sssd/ticket/3051
---


ACK



0002-MONITOR-Remove-the-no-longer-used-kill_service-comma.patch


From 7954e0254752d0a830a0501f23a6a93d0345e5ce Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Sun, 8 May 2016 14:46:25 +0200
Subject: [PATCH 2/3] MONITOR: Remove the no longer used kill_service command
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

After introducing the watchdog, the force_timeout option is no longer
used.

Co-author: Fabiano Fidêncio 

Resolves:
https://fedorahosted.org/sssd/ticket/3052
---


ACK



0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch


From 1302c5a95ac36dd674c8795cda0082b84d30978d Mon Sep 17 00:00:00 2001
From: Jakub Hrozek 
Date: Mon, 15 Aug 2016 12:54:20 +0200
Subject: [PATCH 3/3] WATCHDOG: define and use _MAX_TICKS as 3

Instead of using the number 3 directly, let's introduce and use
WATCHDOG_MAX_TICKS.
--


This patch is unfortunately inapplicable on top of master
(after two previous patches):

pcech@albireo ~/sssd: (master) $ git am 
../patch/0003-WATCHDOG-define-and-use-_MAX_TICKS-as-3.patch

Applying: WATCHDOG: define and use _MAX_TICKS as 3
error: patch failed: src/util/util_watchdog.c:38
error: src/util/util_watchdog.c: patch does not apply
Patch failed at 0001 WATCHDOG: define and use _MAX_TICKS as 3

Regards

---
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

2016-08-29 Thread Petr Cech


On 08/26/2016 04:59 PM, Jakub Hrozek wrote:

On Mon, Aug 15, 2016 at 02:58:50PM +0200, Fabiano Fidêncio wrote:

Those 3 patches are from Jakub and I've just done some minor
adjustments and add myself as co-author of the first 2 patches.

CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html

Best Regards,
--
Fabiano Fidêncio


bump, this is just a simple removal of code, but I can't review it
myself..


Hello Fabiano,

I will take a look. :-)

Regards

--
Petr^4 Čech
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

2016-08-26 Thread Jakub Hrozek

On Mon, Aug 15, 2016 at 02:58:50PM +0200, Fabiano Fidêncio wrote:
> Those 3 patches are from Jakub and I've just done some minor
> adjustments and add myself as co-author of the first 2 patches.
> 
> CI has passed: http://sssd-ci.duckdns.org/logs/job/51/55/summary.html
> 
> Best Regards,
> --
> Fabiano Fidêncio

bump, this is just a simple removal of code, but I can't review it
myself..
___
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

[SSSD] Re: [SSSD} [PATCH] Remove no longer used code

6 matches

Site Navigation

Mail list logo

Footer information