Re: [SSSD-users] lines beginning with spaces in sssd.conf
On Thu, 2013-10-10 at 19:38 -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/10/2013 03:47 PM, Dmitri Pal wrote: > > On 10/10/2013 02:42 PM, Stephen Gallagher wrote: > >> On 10/10/2013 02:40 PM, Simo Sorce wrote: > >>> On Thu, 2013-10-10 at 19:56 +0200, Jakub Hrozek wrote: > On Thu, Oct 10, 2013 at 01:48:24PM -0400, Simo Sorce wrote: > > On Thu, 2013-10-10 at 11:22 +0200, Jakub Hrozek wrote: > >> On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek > >> wrote: > >>> On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen > >>> Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > > On 10/09/2013 01:22 PM, Dmitri Pal wrote: > > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > >> Hi List, > >> > >> I have noticed that since F19 I can not use > >> lines beginning with spaces in sssd.conf - sssd > >> complains otherwise. Was this an intentional > >> change? I used spaces/white characters to ident > >> the config for better readability. Thanks, > >> > >> Ondrej > >> > >> > >> ___ > >> sssd-users mailing list > >> sssd-users@lists.fedorahosted.org > >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users > >> > >> > >>> > >> > >> There was a change in the underlying libini_config library to > > treat spaces as wrappers by default. > > Just to clarify what this means: libini_config > changed its behavior so that a leading space should > be interpreted as a line-continuation from the > previous line. So if you had REALLY long data (such > as a complex ldap_search_filter), you could make it > more readable by spreading it out on multiple lines. > > > > It is probably a bug in the SSSD implementation of > > libini_config Hm... yes. > > > > Line 225 in > > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > >> > > > >>> s/0/INI_PARSE_NOWRAP > > > > You can definitely file a ticket for that. > > > > Feel free to file a ticket, but I think the wrapping > behavior may prove more useful. Hard to say. > >>> > >>> In general I agree that the wrapping functionality is > >>> useful, but I don't think we should be changing > >>> behaviour to the point where SSSD doesn't start after > >>> an upgrade. > >>> > >>> I think we should do the change Dmitri proposed and > >>> file another ticket to decide whether it makes sense to > >>> munge existing configuration files with an upgrade > >>> script and change to the line wrapping version. > >> > >> I sent a patch to the list and filed > >> https://fedorahosted.org/sssd/ticket/2118 > > > > config files could be installed via management tools like > > puppet or cfengine. > > > > I am personally completely against changing file format > > (yes this is a change in file format) incompatibily. Please > > use something like a \ char at the end of the line to > > indicate continuation on the next line. > > > > Simo. > > There is a patch already on the list that reverts to the old > behaviour. > >> > >>> Excellent however I was referring to the idea of "decide > >>> whether it makes sense to munge existing configuration files > >>> with an upgrade script and change to the line wrapping > >>> version.". I think it does not. > >> > >> > >> Yeah, I agree with that. Changing the file format is a bad idea. > > > > > > First of all let me clarify some things: > > > > * The change in the libini was discussed here on the list and > > agreed to. * Also the fact that leading spaces are treated as > > wrapper is the default behavior of the library was agreed to. * The > > change to the ini library was requested and was actually proposed > > to rely on leading spaced rather than "\" * My opinion as an > > implementer was that "\" a better choice but I was talked out out > > of it. * There is a ticket to allow wrapping by "\" but it is > > deferred as there is no one asking for it * The fact that SSSD took > > the defaults when switched to the new version is a bug and needs > > fixing * Moving forward SSSD should stay backward compatible but > > allow people to use wrapping if they want. This will be enabled via > > SSSD startup command line arguments as noted in the ticket. Ticket > > to do that is deferred till future. > > > > Yes, agreed on all points. For the record, if I recall correctly we > opted not to use the backslash mainly because we foresaw the > possibility of actually using that character in option values and > didn't want to have to deal wi
Re: [SSSD-users] lines beginning with spaces in sssd.conf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2013 03:47 PM, Dmitri Pal wrote: > On 10/10/2013 02:42 PM, Stephen Gallagher wrote: >> On 10/10/2013 02:40 PM, Simo Sorce wrote: >>> On Thu, 2013-10-10 at 19:56 +0200, Jakub Hrozek wrote: On Thu, Oct 10, 2013 at 01:48:24PM -0400, Simo Sorce wrote: > On Thu, 2013-10-10 at 11:22 +0200, Jakub Hrozek wrote: >> On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek >> wrote: >>> On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen >>> Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/09/2013 01:22 PM, Dmitri Pal wrote: > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: >> Hi List, >> >> I have noticed that since F19 I can not use >> lines beginning with spaces in sssd.conf - sssd >> complains otherwise. Was this an intentional >> change? I used spaces/white characters to ident >> the config for better readability. Thanks, >> >> Ondrej >> >> >> ___ >> sssd-users mailing list >> sssd-users@lists.fedorahosted.org >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users >> >> >>> >> >> There was a change in the underlying libini_config library to > treat spaces as wrappers by default. Just to clarify what this means: libini_config changed its behavior so that a leading space should be interpreted as a line-continuation from the previous line. So if you had REALLY long data (such as a complex ldap_search_filter), you could make it more readable by spreading it out on multiple lines. > It is probably a bug in the SSSD implementation of > libini_config Hm... yes. > > Line 225 in > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c >> > >>> s/0/INI_PARSE_NOWRAP > > You can definitely file a ticket for that. > Feel free to file a ticket, but I think the wrapping behavior may prove more useful. Hard to say. >>> >>> In general I agree that the wrapping functionality is >>> useful, but I don't think we should be changing >>> behaviour to the point where SSSD doesn't start after >>> an upgrade. >>> >>> I think we should do the change Dmitri proposed and >>> file another ticket to decide whether it makes sense to >>> munge existing configuration files with an upgrade >>> script and change to the line wrapping version. >> >> I sent a patch to the list and filed >> https://fedorahosted.org/sssd/ticket/2118 > > config files could be installed via management tools like > puppet or cfengine. > > I am personally completely against changing file format > (yes this is a change in file format) incompatibily. Please > use something like a \ char at the end of the line to > indicate continuation on the next line. > > Simo. There is a patch already on the list that reverts to the old behaviour. >> >>> Excellent however I was referring to the idea of "decide >>> whether it makes sense to munge existing configuration files >>> with an upgrade script and change to the line wrapping >>> version.". I think it does not. >> >> >> Yeah, I agree with that. Changing the file format is a bad idea. > > > First of all let me clarify some things: > > * The change in the libini was discussed here on the list and > agreed to. * Also the fact that leading spaces are treated as > wrapper is the default behavior of the library was agreed to. * The > change to the ini library was requested and was actually proposed > to rely on leading spaced rather than "\" * My opinion as an > implementer was that "\" a better choice but I was talked out out > of it. * There is a ticket to allow wrapping by "\" but it is > deferred as there is no one asking for it * The fact that SSSD took > the defaults when switched to the new version is a bug and needs > fixing * Moving forward SSSD should stay backward compatible but > allow people to use wrapping if they want. This will be enabled via > SSSD startup command line arguments as noted in the ticket. Ticket > to do that is deferred till future. > Yes, agreed on all points. For the record, if I recall correctly we opted not to use the backslash mainly because we foresaw the possibility of actually using that character in option values and didn't want to have to deal with escaping it. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJXOoQACgkQeiVVYja6o6P/hgCeJ+Ymbv4HyKEJz47BhYwFy0F2 C90An38Z+x5uMPriIqrB+gLVxVEzC085 =hJ2p -END PGP SIGNATURE-
Re: [SSSD-users] lines beginning with spaces in sssd.conf
On 10/10/2013 02:42 PM, Stephen Gallagher wrote: > On 10/10/2013 02:40 PM, Simo Sorce wrote: > > On Thu, 2013-10-10 at 19:56 +0200, Jakub Hrozek wrote: > >> On Thu, Oct 10, 2013 at 01:48:24PM -0400, Simo Sorce wrote: > >>> On Thu, 2013-10-10 at 11:22 +0200, Jakub Hrozek wrote: > On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek > wrote: > > On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen Gallagher > > wrote: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > >> > >> On 10/09/2013 01:22 PM, Dmitri Pal wrote: > >>> On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > Hi List, > > I have noticed that since F19 I can not use lines > beginning with spaces in sssd.conf - sssd complains > otherwise. Was this an intentional change? I used > spaces/white characters to ident the config for > better readability. Thanks, > > Ondrej > > > ___ > sssd-users mailing list > sssd-users@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-users > >>> > > There was a change in the underlying libini_config library to > >>> treat spaces as wrappers by default. > >> > >> Just to clarify what this means: libini_config changed > >> its behavior so that a leading space should be > >> interpreted as a line-continuation from the previous > >> line. So if you had REALLY long data (such as a complex > >> ldap_search_filter), you could make it more readable by > >> spreading it out on multiple lines. > >> > >> > >>> It is probably a bug in the SSSD implementation of > >>> libini_config Hm... yes. > >>> > >>> Line 225 in > >>> https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > >>> s/0/INI_PARSE_NOWRAP > >>> > >>> You can definitely file a ticket for that. > >>> > >> > >> Feel free to file a ticket, but I think the wrapping > >> behavior may prove more useful. Hard to say. > > > > In general I agree that the wrapping functionality is > > useful, but I don't think we should be changing behaviour > > to the point where SSSD doesn't start after an upgrade. > > > > I think we should do the change Dmitri proposed and file > > another ticket to decide whether it makes sense to munge > > existing configuration files with an upgrade script and > > change to the line wrapping version. > > I sent a patch to the list and filed > https://fedorahosted.org/sssd/ticket/2118 > >>> > >>> config files could be installed via management tools like > >>> puppet or cfengine. > >>> > >>> I am personally completely against changing file format (yes > >>> this is a change in file format) incompatibily. Please use > >>> something like a \ char at the end of the line to indicate > >>> continuation on the next line. > >>> > >>> Simo. > >> > >> There is a patch already on the list that reverts to the old > >> behaviour. > > > Excellent however I was referring to the idea of "decide whether > > it makes sense to munge existing configuration files with an > > upgrade script and change to the line wrapping version.". I think > > it does not. > > > Yeah, I agree with that. Changing the file format is a bad idea. First of all let me clarify some things: * The change in the libini was discussed here on the list and agreed to. * Also the fact that leading spaces are treated as wrapper is the default behavior of the library was agreed to. * The change to the ini library was requested and was actually proposed to rely on leading spaced rather than "\" * My opinion as an implementer was that "\" a better choice but I was talked out out of it. * There is a ticket to allow wrapping by "\" but it is deferred as there is no one asking for it * The fact that SSSD took the defaults when switched to the new version is a bug and needs fixing * Moving forward SSSD should stay backward compatible but allow people to use wrapping if they want. This will be enabled via SSSD startup command line arguments as noted in the ticket. Ticket to do that is deferred till future. HTH > ___ > sssd-users mailing list > sssd-users@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-users -- Thank you, Dmitri Pal Sr. Engineering Manager for IdM portfolio Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/10/2013 02:40 PM, Simo Sorce wrote: > On Thu, 2013-10-10 at 19:56 +0200, Jakub Hrozek wrote: >> On Thu, Oct 10, 2013 at 01:48:24PM -0400, Simo Sorce wrote: >>> On Thu, 2013-10-10 at 11:22 +0200, Jakub Hrozek wrote: On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek wrote: > On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen Gallagher > wrote: >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 10/09/2013 01:22 PM, Dmitri Pal wrote: >>> On 10/09/2013 01:05 PM, Ondrej Valousek wrote: Hi List, I have noticed that since F19 I can not use lines beginning with spaces in sssd.conf - sssd complains otherwise. Was this an intentional change? I used spaces/white characters to ident the config for better readability. Thanks, Ondrej ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users >>> There was a change in the underlying libini_config library to >>> treat spaces as wrappers by default. >> >> Just to clarify what this means: libini_config changed >> its behavior so that a leading space should be >> interpreted as a line-continuation from the previous >> line. So if you had REALLY long data (such as a complex >> ldap_search_filter), you could make it more readable by >> spreading it out on multiple lines. >> >> >>> It is probably a bug in the SSSD implementation of >>> libini_config Hm... yes. >>> >>> Line 225 in >>> https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c >>> s/0/INI_PARSE_NOWRAP >>> >>> You can definitely file a ticket for that. >>> >> >> Feel free to file a ticket, but I think the wrapping >> behavior may prove more useful. Hard to say. > > In general I agree that the wrapping functionality is > useful, but I don't think we should be changing behaviour > to the point where SSSD doesn't start after an upgrade. > > I think we should do the change Dmitri proposed and file > another ticket to decide whether it makes sense to munge > existing configuration files with an upgrade script and > change to the line wrapping version. I sent a patch to the list and filed https://fedorahosted.org/sssd/ticket/2118 >>> >>> config files could be installed via management tools like >>> puppet or cfengine. >>> >>> I am personally completely against changing file format (yes >>> this is a change in file format) incompatibily. Please use >>> something like a \ char at the end of the line to indicate >>> continuation on the next line. >>> >>> Simo. >> >> There is a patch already on the list that reverts to the old >> behaviour. > > Excellent however I was referring to the idea of "decide whether > it makes sense to munge existing configuration files with an > upgrade script and change to the line wrapping version.". I think > it does not. > Yeah, I agree with that. Changing the file format is a bad idea. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJW9RsACgkQeiVVYja6o6M5+ACfTBtHKRhaTKFczgUJSMLEirhv Th0An3MdlT8R8CQ0Sg1P7v1S7HbhL9kH =kIbN -END PGP SIGNATURE- ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
On Thu, 2013-10-10 at 19:56 +0200, Jakub Hrozek wrote: > On Thu, Oct 10, 2013 at 01:48:24PM -0400, Simo Sorce wrote: > > On Thu, 2013-10-10 at 11:22 +0200, Jakub Hrozek wrote: > > > On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek wrote: > > > > On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen Gallagher wrote: > > > > > -BEGIN PGP SIGNED MESSAGE- > > > > > Hash: SHA1 > > > > > > > > > > On 10/09/2013 01:22 PM, Dmitri Pal wrote: > > > > > > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > > > > > >> Hi List, > > > > > >> > > > > > >> I have noticed that since F19 I can not use lines beginning with > > > > > >> spaces in sssd.conf - sssd complains otherwise. Was this an > > > > > >> intentional change? I used spaces/white characters to ident the > > > > > >> config for better readability. Thanks, > > > > > >> > > > > > >> Ondrej > > > > > >> > > > > > >> > > > > > >> ___ sssd-users > > > > > >> mailing list sssd-users@lists.fedorahosted.org > > > > > >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users > > > > > > There was a change in the underlying libini_config library to > > > > > > treat spaces as wrappers by default. > > > > > > > > > > Just to clarify what this means: libini_config changed its behavior so > > > > > that a leading space should be interpreted as a line-continuation from > > > > > the previous line. So if you had REALLY long data (such as a complex > > > > > ldap_search_filter), you could make it more readable by spreading it > > > > > out on multiple lines. > > > > > > > > > > > > > > > > It is probably a bug in the SSSD implementation of libini_config > > > > > > Hm... yes. > > > > > > > > > > > > Line 225 in > > > > > > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > > > > > > s/0/INI_PARSE_NOWRAP > > > > > > > > > > > > You can definitely file a ticket for that. > > > > > > > > > > > > > > > > Feel free to file a ticket, but I think the wrapping behavior may > > > > > prove more useful. Hard to say. > > > > > > > > In general I agree that the wrapping functionality is useful, but I > > > > don't think we should be changing behaviour to the point where SSSD > > > > doesn't start after an upgrade. > > > > > > > > I think we should do the change Dmitri proposed and file another ticket > > > > to decide whether it makes sense to munge existing configuration files > > > > with an upgrade script and change to the line wrapping version. > > > > > > I sent a patch to the list and filed > > > https://fedorahosted.org/sssd/ticket/2118 > > > > config files could be installed via management tools like puppet or > > cfengine. > > > > I am personally completely against changing file format (yes this is a > > change in file format) incompatibily. > > Please use something like a \ char at the end of the line to indicate > > continuation on the next line. > > > > Simo. > > There is a patch already on the list that reverts to the old behaviour. Excellent however I was referring to the idea of "decide whether it makes sense to munge existing configuration files with an upgrade script and change to the line wrapping version.". I think it does not. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
On Thu, Oct 10, 2013 at 01:48:24PM -0400, Simo Sorce wrote: > On Thu, 2013-10-10 at 11:22 +0200, Jakub Hrozek wrote: > > On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek wrote: > > > On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen Gallagher wrote: > > > > -BEGIN PGP SIGNED MESSAGE- > > > > Hash: SHA1 > > > > > > > > On 10/09/2013 01:22 PM, Dmitri Pal wrote: > > > > > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > > > > >> Hi List, > > > > >> > > > > >> I have noticed that since F19 I can not use lines beginning with > > > > >> spaces in sssd.conf - sssd complains otherwise. Was this an > > > > >> intentional change? I used spaces/white characters to ident the > > > > >> config for better readability. Thanks, > > > > >> > > > > >> Ondrej > > > > >> > > > > >> > > > > >> ___ sssd-users > > > > >> mailing list sssd-users@lists.fedorahosted.org > > > > >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users > > > > > There was a change in the underlying libini_config library to > > > > > treat spaces as wrappers by default. > > > > > > > > Just to clarify what this means: libini_config changed its behavior so > > > > that a leading space should be interpreted as a line-continuation from > > > > the previous line. So if you had REALLY long data (such as a complex > > > > ldap_search_filter), you could make it more readable by spreading it > > > > out on multiple lines. > > > > > > > > > > > > > It is probably a bug in the SSSD implementation of libini_config > > > > > Hm... yes. > > > > > > > > > > Line 225 in > > > > > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > > > > > s/0/INI_PARSE_NOWRAP > > > > > > > > > > You can definitely file a ticket for that. > > > > > > > > > > > > > Feel free to file a ticket, but I think the wrapping behavior may > > > > prove more useful. Hard to say. > > > > > > In general I agree that the wrapping functionality is useful, but I > > > don't think we should be changing behaviour to the point where SSSD > > > doesn't start after an upgrade. > > > > > > I think we should do the change Dmitri proposed and file another ticket > > > to decide whether it makes sense to munge existing configuration files > > > with an upgrade script and change to the line wrapping version. > > > > I sent a patch to the list and filed > > https://fedorahosted.org/sssd/ticket/2118 > > config files could be installed via management tools like puppet or > cfengine. > > I am personally completely against changing file format (yes this is a > change in file format) incompatibily. > Please use something like a \ char at the end of the line to indicate > continuation on the next line. > > Simo. There is a patch already on the list that reverts to the old behaviour. ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
On Thu, 2013-10-10 at 11:22 +0200, Jakub Hrozek wrote: > On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek wrote: > > On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen Gallagher wrote: > > > -BEGIN PGP SIGNED MESSAGE- > > > Hash: SHA1 > > > > > > On 10/09/2013 01:22 PM, Dmitri Pal wrote: > > > > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > > > >> Hi List, > > > >> > > > >> I have noticed that since F19 I can not use lines beginning with > > > >> spaces in sssd.conf - sssd complains otherwise. Was this an > > > >> intentional change? I used spaces/white characters to ident the > > > >> config for better readability. Thanks, > > > >> > > > >> Ondrej > > > >> > > > >> > > > >> ___ sssd-users > > > >> mailing list sssd-users@lists.fedorahosted.org > > > >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users > > > > There was a change in the underlying libini_config library to > > > > treat spaces as wrappers by default. > > > > > > Just to clarify what this means: libini_config changed its behavior so > > > that a leading space should be interpreted as a line-continuation from > > > the previous line. So if you had REALLY long data (such as a complex > > > ldap_search_filter), you could make it more readable by spreading it > > > out on multiple lines. > > > > > > > > > > It is probably a bug in the SSSD implementation of libini_config > > > > Hm... yes. > > > > > > > > Line 225 in > > > > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > > > > s/0/INI_PARSE_NOWRAP > > > > > > > > You can definitely file a ticket for that. > > > > > > > > > > Feel free to file a ticket, but I think the wrapping behavior may > > > prove more useful. Hard to say. > > > > In general I agree that the wrapping functionality is useful, but I > > don't think we should be changing behaviour to the point where SSSD > > doesn't start after an upgrade. > > > > I think we should do the change Dmitri proposed and file another ticket > > to decide whether it makes sense to munge existing configuration files > > with an upgrade script and change to the line wrapping version. > > I sent a patch to the list and filed > https://fedorahosted.org/sssd/ticket/2118 config files could be installed via management tools like puppet or cfengine. I am personally completely against changing file format (yes this is a change in file format) incompatibily. Please use something like a \ char at the end of the line to indicate continuation on the next line. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
On Thu, Oct 10, 2013 at 10:54:59AM +0200, Jakub Hrozek wrote: > On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen Gallagher wrote: > > -BEGIN PGP SIGNED MESSAGE- > > Hash: SHA1 > > > > On 10/09/2013 01:22 PM, Dmitri Pal wrote: > > > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > > >> Hi List, > > >> > > >> I have noticed that since F19 I can not use lines beginning with > > >> spaces in sssd.conf - sssd complains otherwise. Was this an > > >> intentional change? I used spaces/white characters to ident the > > >> config for better readability. Thanks, > > >> > > >> Ondrej > > >> > > >> > > >> ___ sssd-users > > >> mailing list sssd-users@lists.fedorahosted.org > > >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users > > > There was a change in the underlying libini_config library to > > > treat spaces as wrappers by default. > > > > Just to clarify what this means: libini_config changed its behavior so > > that a leading space should be interpreted as a line-continuation from > > the previous line. So if you had REALLY long data (such as a complex > > ldap_search_filter), you could make it more readable by spreading it > > out on multiple lines. > > > > > > > It is probably a bug in the SSSD implementation of libini_config > > > Hm... yes. > > > > > > Line 225 in > > > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > > > s/0/INI_PARSE_NOWRAP > > > > > > You can definitely file a ticket for that. > > > > > > > Feel free to file a ticket, but I think the wrapping behavior may > > prove more useful. Hard to say. > > In general I agree that the wrapping functionality is useful, but I > don't think we should be changing behaviour to the point where SSSD > doesn't start after an upgrade. > > I think we should do the change Dmitri proposed and file another ticket > to decide whether it makes sense to munge existing configuration files > with an upgrade script and change to the line wrapping version. I sent a patch to the list and filed https://fedorahosted.org/sssd/ticket/2118 ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
On Wed, Oct 09, 2013 at 02:03:00PM -0400, Stephen Gallagher wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/09/2013 01:22 PM, Dmitri Pal wrote: > > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > >> Hi List, > >> > >> I have noticed that since F19 I can not use lines beginning with > >> spaces in sssd.conf - sssd complains otherwise. Was this an > >> intentional change? I used spaces/white characters to ident the > >> config for better readability. Thanks, > >> > >> Ondrej > >> > >> > >> ___ sssd-users > >> mailing list sssd-users@lists.fedorahosted.org > >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users > > There was a change in the underlying libini_config library to > > treat spaces as wrappers by default. > > Just to clarify what this means: libini_config changed its behavior so > that a leading space should be interpreted as a line-continuation from > the previous line. So if you had REALLY long data (such as a complex > ldap_search_filter), you could make it more readable by spreading it > out on multiple lines. > > > > It is probably a bug in the SSSD implementation of libini_config > > Hm... yes. > > > > Line 225 in > > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > > s/0/INI_PARSE_NOWRAP > > > > You can definitely file a ticket for that. > > > > Feel free to file a ticket, but I think the wrapping behavior may > prove more useful. Hard to say. In general I agree that the wrapping functionality is useful, but I don't think we should be changing behaviour to the point where SSSD doesn't start after an upgrade. I think we should do the change Dmitri proposed and file another ticket to decide whether it makes sense to munge existing configuration files with an upgrade script and change to the line wrapping version. ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/09/2013 01:22 PM, Dmitri Pal wrote: > On 10/09/2013 01:05 PM, Ondrej Valousek wrote: >> Hi List, >> >> I have noticed that since F19 I can not use lines beginning with >> spaces in sssd.conf - sssd complains otherwise. Was this an >> intentional change? I used spaces/white characters to ident the >> config for better readability. Thanks, >> >> Ondrej >> >> >> ___ sssd-users >> mailing list sssd-users@lists.fedorahosted.org >> https://lists.fedorahosted.org/mailman/listinfo/sssd-users > There was a change in the underlying libini_config library to > treat spaces as wrappers by default. Just to clarify what this means: libini_config changed its behavior so that a leading space should be interpreted as a line-continuation from the previous line. So if you had REALLY long data (such as a complex ldap_search_filter), you could make it more readable by spreading it out on multiple lines. > It is probably a bug in the SSSD implementation of libini_config > Hm... yes. > > Line 225 in > https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c > s/0/INI_PARSE_NOWRAP > > You can definitely file a ticket for that. > Feel free to file a ticket, but I think the wrapping behavior may prove more useful. Hard to say. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlJVmlQACgkQeiVVYja6o6PCyACfZrc8TlFM2mRdWQloSXTScWgR 2o4AnAx+Wh4ok21IlurhmDJM1FvaZIaB =M0wB -END PGP SIGNATURE- ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
Re: [SSSD-users] lines beginning with spaces in sssd.conf
On 10/09/2013 01:05 PM, Ondrej Valousek wrote: > Hi List, > > I have noticed that since F19 I can not use lines beginning with > spaces in sssd.conf - sssd complains otherwise. > Was this an intentional change? I used spaces/white characters to > ident the config for better readability. > Thanks, > > Ondrej > > > ___ > sssd-users mailing list > sssd-users@lists.fedorahosted.org > https://lists.fedorahosted.org/mailman/listinfo/sssd-users There was a change in the underlying libini_config library to treat spaces as wrappers by default. It is probably a bug in the SSSD implementation of libini_config Hm... yes. Line 225 in https://git.fedorahosted.org/cgit/sssd.git/tree/src/util/sss_ini.c s/0/INI_PARSE_NOWRAP You can definitely file a ticket for that. -- Thank you, Dmitri Pal Sr. Engineering Manager for IdM portfolio Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
[SSSD-users] lines beginning with spaces in sssd.conf
Hi List, I have noticed that since F19 I can not use lines beginning with spaces in sssd.conf - sssd complains otherwise. Was this an intentional change? I used spaces/white characters to ident the config for better readability. Thanks, Ondrej ___ sssd-users mailing list sssd-users@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-users
