[PATCH v2] mac80211: Fix IBSS disconnect

2014-01-30 Thread Sujith Manoharan
From: Sujith Manoharan c_man...@qca.qualcomm.com

Currently, when a station leaves an IBSS network, the
corresponding BSS is not dropped from cfg80211 if there are
other active stations in the network. But, the small
window that is present when trying to determine a station's
status based on IEEE80211_IBSS_MERGE_INTERVAL introduces
a race.

Instead of trying to keep the BSS, always remove it when
leaving an IBSS network. There is not much benefit to retain
the BSS entry since it will be added with a subsequent join
operation.

This fixes an issue where a dangling BSS entry causes ath9k
to wait for a beacon indefinitely.

Cc: stable@vger.kernel.org
Reported-by: Simon Wunderlich s...@simonwunderlich.de
Signed-off-by: Sujith Manoharan c_man...@qca.qualcomm.com
---
v2 - Remove BSS entry in the CSA-failure case too.

 net/mac80211/ibss.c | 5 +
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/mac80211/ibss.c b/net/mac80211/ibss.c
index 771080e..2796a19 100644
--- a/net/mac80211/ibss.c
+++ b/net/mac80211/ibss.c
@@ -695,12 +695,9 @@ static void ieee80211_ibss_disconnect(struct 
ieee80211_sub_if_data *sdata)
struct cfg80211_bss *cbss;
struct beacon_data *presp;
struct sta_info *sta;
-   int active_ibss;
u16 capability;
 
-   active_ibss = ieee80211_sta_active_ibss(sdata);
-
-   if (!active_ibss  !is_zero_ether_addr(ifibss-bssid)) {
+   if (!is_zero_ether_addr(ifibss-bssid)) {
capability = WLAN_CAPABILITY_IBSS;
 
if (ifibss-privacy)
-- 
1.8.5.3

--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH v2] mac80211: Fix IBSS disconnect

2014-01-30 Thread Johannes Berg
On Thu, 2014-01-30 at 14:17 +0530, Sujith Manoharan wrote:
 From: Sujith Manoharan c_man...@qca.qualcomm.com
 
 Currently, when a station leaves an IBSS network, the
 corresponding BSS is not dropped from cfg80211 if there are
 other active stations in the network. But, the small
 window that is present when trying to determine a station's
 status based on IEEE80211_IBSS_MERGE_INTERVAL introduces
 a race.
 
 Instead of trying to keep the BSS, always remove it when
 leaving an IBSS network. There is not much benefit to retain
 the BSS entry since it will be added with a subsequent join
 operation.
 
 This fixes an issue where a dangling BSS entry causes ath9k
 to wait for a beacon indefinitely.

Applied.

johannes

--
To unsubscribe from this list: send the line unsubscribe stable in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html