On Mon, Dec 2, 2013 at 9:58 AM, Peter Waher <peter.wa...@clayster.com> wrote: > Hello Philipp > > Thanks for your input. I've updated the according to your comments, and > attach a new version. > > Best regards, > Peter Waher >
Hey Peter, Something which I don't think has been discussed: Encoding. I'm assuming syslog-to-xmpp bridging is something you wish to enable. Syslog does recommend UTF-8, but doesn't require it. Data can be non-UTF-8. Also, syslog messages can be truncated by bytes, which can lead to invalid UTF-8 at the end of a message (the spec specifically points this out). And lastly, syslog messages may contain a byte-order-mark (BOM) at the start of messages to specify encoding. Also, XML supports a subset of UTF-8, not all UTF-8 characters are allowed. What we probably want is some form of escaping to be specified in the spec. Perhaps as simple as: replace \ with \\ and replace any invalid XML bytes with \XX, XX being the byte in hex. BOMs should be removed if available, and data should be converted to UTF-8 if possible. One thing which looks awkward to me are the 'type' attributes in the 'tag' element. What's a use-case where specifying the data-type would help the receiver (particularly when this would generally be the same in every log message sent by the entity)? And while you are using 'xs:*', the 'xs' namespace isn't defined in the XML stream the stanza is in. -- Waqas Hussain
