[EMAIL PROTECTED] wrote:
Author: faridz
Date: Tue Jun 12 08:39:20 2007
New Revision: 546535

URL: http://svn.apache.org/viewvc?view=rev&rev=546535
Log:
2007-06-12 Farid Zaripov <[EMAIL PROTECTED]>

        * sstream (str): Method definition moved outside of the class 
definition.

Modified:
    incubator/stdcxx/trunk/include/sstream

Modified: incubator/stdcxx/trunk/include/sstream
URL: 
http://svn.apache.org/viewvc/incubator/stdcxx/trunk/include/sstream?view=diff&rev=546535&r1=546534&r2=546535
==============================================================================
--- incubator/stdcxx/trunk/include/sstream (original)
+++ incubator/stdcxx/trunk/include/sstream Tue Jun 12 08:39:20 2007
[...]
@@ -194,6 +177,28 @@
     void _C_catchup (char_type*);
 };
+template <class _CharT, class _Traits, class _Allocator>
+inline basic_string<_CharT, _Traits, _Allocator>
+basic_stringbuf<_CharT, _Traits, _Allocator>::
+str () const {

In member functions defined outside the definition of their
class the opening brace goes on a line all by itself. It's
also nice to separate namespace-scope definitions by two
blank lines rather than just one (it makes it easier to
tell individual function definitions apart).

+
+    const char_type * __first = 0;
+    const char_type * __last = 0;

There should be a space only on one side of the asterisk,
not both. I.e., like this:

    const char_type* __first = 0;
    const char_type* __last  = 0;

I made the changes here:
http://svn.apache.org/viewvc?view=rev&rev=552661

Martin

Reply via email to