DO NOT REPLY [Bug 18394] - TilesRequestProcessor, downgrade log msg from error to info

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18394

TilesRequestProcessor, downgrade log msg from error to info

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED



--- Additional Comments From [EMAIL PROTECTED]  2003-03-27 03:09 ---
The code checks for the definitionsFactory being null so it does appear that 
it's a valid condition to run without one.  I changed it to log an info level 
message.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/share/org/apache/struts/tiles TilesRequestProcessor.java

2003-03-26 Thread dgraham 
dgraham 2003/03/26 19:06:12

  Modified:src/share/org/apache/struts/tiles TilesRequestProcessor.java
  Log:
  Changed error to info log if DefinitionsFactory is not supplied.  PR #18394.
  
  Revision  ChangesPath
  1.19  +5 -5  
jakarta-struts/src/share/org/apache/struts/tiles/TilesRequestProcessor.java
  
  Index: TilesRequestProcessor.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/tiles/TilesRequestProcessor.java,v
  retrieving revision 1.18
  retrieving revision 1.19
  diff -u -r1.18 -r1.19
  --- TilesRequestProcessor.java27 Mar 2003 03:04:14 -  1.18
  +++ TilesRequestProcessor.java27 Mar 2003 03:06:12 -  1.19
  @@ -126,9 +126,9 @@
   definitionsFactory = 
((TilesUtilStrutsImpl)TilesUtil.getTilesUtil()).getDefinitionsFactory(getServletContext(),
 moduleConfig);
   if( definitionsFactory == null )
 {  // problem !
  -if(log.isErrorEnabled())
  +if(log.isInfoEnabled())
 {
  -log.error( "Definition Factory not found for module '"
  +log.info( "Definition Factory not found for module '"
   + moduleConfig.getPrefix() + "'. "
   + "Have you declared the appropriate plugin in struts-config.xml ?" 
);
 }
  
  
  

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

cvs commit: jakarta-struts/src/share/org/apache/struts/tiles TilesRequestProcessor.java

2003-03-26 Thread dgraham 
dgraham 2003/03/26 19:04:15

  Modified:src/share/org/apache/struts/tiles TilesRequestProcessor.java
  Log:
  Added braces to if statements.
  
  Revision  ChangesPath
  1.18  +36 -24
jakarta-struts/src/share/org/apache/struts/tiles/TilesRequestProcessor.java
  
  Index: TilesRequestProcessor.java
  ===
  RCS file: 
/home/cvs/jakarta-struts/src/share/org/apache/struts/tiles/TilesRequestProcessor.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- TilesRequestProcessor.java27 Feb 2003 19:20:50 -  1.17
  +++ TilesRequestProcessor.java27 Mar 2003 03:04:14 -  1.18
  @@ -7,7 +7,7 @@
*
* The Apache Software License, Version 1.1
*
  - * Copyright (c) 1999-2002 The Apache Software Foundation.  All rights
  + * Copyright (c) 1999-2003 The Apache Software Foundation.  All rights
* reserved.
*
* Redistribution and use in source and binary forms, with or without
  @@ -77,10 +77,10 @@
* RequestProcessor contains the processing logic that
* the Struts controller servlet performs as it receives each servlet request
* from the container.
  - * This processor subclasses the Struts one in order to intercept calls to 
forward
  - * or include. When such calls are done, the Tiles processor checks if the 
specified uri
  + * This processor subclasses the Struts RequestProcessor in order to intercept 
calls to forward
  + * or include. When such calls are done, the Tiles processor checks if the 
specified URI
* is a definition name. If true, the definition is retrieved and included. If
  - * false, the original uri is included or a forward is performed.
  + * false, the original URI is included or a forward is performed.
* 
* Actually, catching is done by overloading the following methods:
* 
  @@ -90,7 +90,7 @@
* 
* 
* @author Cedric Dumoulin
  - * @since Tiles 1.1.1
  + * @since Struts 1.1
*/
   public class TilesRequestProcessor extends RequestProcessor
   {
  @@ -189,8 +189,9 @@
 tileContext = new ComponentContext( definition.getAttributes() );
 ComponentContext.setContext( tileContext, request);
 }
  - else
  + else {
 tileContext.addMissing( definition.getAttributes() );
  + }
   } // end if
 } // end if
   
  @@ -200,17 +201,20 @@
 { // We have a definition.
   // We use it to complete missing attribute in context.
   // We also overload uri and controller if set in definition.
  -  if(definition.getPath()!=null)
  +  if (definition.getPath() != null) {
   uri = definition.getPath();
  -  if(definition.getOrCreateController()!=null)
  +  }
  +  if (definition.getOrCreateController() != null) {
   controller = definition.getOrCreateController();
  +  }
 if( tileContext == null )
   {
   tileContext = new ComponentContext( definition.getAttributes() );
   ComponentContext.setContext( tileContext, request);
   }
  -  else
  +  else {
   tileContext.addMissing( definition.getAttributes() );
  +  }
 } // end if
   
   }
  @@ -228,8 +232,9 @@
   }
   
 // Have we found a definition ?
  -if(uri == null)
  +if (uri == null) {
 return false;
  +}
   
 // Process the definition
 // Execute controller associated to definition, if any.
  @@ -240,12 +245,14 @@
   
 // If request comes from a previous Tile, do an include.
 // This allows to insert an action in a Tile.
  -if(log.isDebugEnabled())
  +if (log.isDebugEnabled()) {
 log.debug( "uri=" + uri + " doInclude=" + doInclude);
  -if( doInclude )
  +}
  +if (doInclude) {
 doInclude(uri, request, response);
  - else
  +} else {
 doForward(uri, request, response);   // original behavior
  +}
   
   return true;
   }
  @@ -261,10 +268,11 @@
 protected void doForward(String uri, HttpServletRequest request, 
HttpServletResponse response)
   throws IOException, ServletException
   {
  -if(response.isCommitted())
  +if (response.isCommitted()) {
 doInclude(uri, request, response);
  - else
  +} else {
 super.doForward(uri, request, response);
  +}
  }
   
   /**
  @@ -292,20 +300,22 @@
 return;
 }
   
  -if(log.isDebugEnabled())
  +if (log.isDebugEnabled()) {
 log.debug( "processForwardConfig("
   + forward.getPath() + ", "
   + forward.getContextRelative() + ")" );
  -
  +}
 // Try to process the definition.
   if (processTilesDefinition( forward.get

DO NOT REPLY [Bug 18394] New: - TilesRequestProcessor, downgrade log msg from error to info

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18394

TilesRequestProcessor, downgrade log msg from error to info

   Summary: TilesRequestProcessor, downgrade log msg from error to
info
   Product: Struts
   Version: 1.1 RC1
  Platform: All
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Tiles framework
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


TilesRequestProcessor.initDefinitionsMapping() logs an error message if the 
definition factory was not found (line #131 in rev 1.17).

However, it is a legal situation to use the TilesRequestProcessor without a 
definition factory. Therefore, the error message should be downgraded to info 
(error messages irritate our operations people).

Specifically, our company has a legacy framework that wraps around Struts and 
also extends the (Tiles)RequestProcessor. Our legacy framework being a generic 
solution that is used by a number of our applications, we had to decide whether 
to extend the TilesRequestProcessor or the Struts RequestProcessor directly. We 
decided to extend the TilesRequestProcessor in order to allow our applications 
to use Tiles if they so desire. This means that all of our applications will 
use the TilesRequestProcessor, but not all of them will actually use Tiles. 
This works fine, only problem is it generates this meaningless error message in 
the logs.

Proposed fix: downgrade log message from error to info 
(TilesRequestProcessor.java v1.17, line 131)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Taglib documentation in JavaDoc format

2003-03-26 Thread David Graham 
That's pretty neat!  It would be good to have an "All Tags" link just like 
the All Classes provided by javadoc.

David



From: Mohan Kishore <[EMAIL PROTECTED]>
Reply-To: "Struts Developers List" <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Taglib documentation in JavaDoc format
Date: Wed, 26 Mar 2003 15:48:09 -0800 (PST)
Hi,

I have put together an ant task with accompanying XSL files etc, which 
generate
javadoc-like documentation for the taglibs (uses the current struts-xxx.xml
files).

The docs are available at http://mohankishore.tripod.com/struts-docs/ Just
wanted to run it by the community to see if it feels its useful.
regards,
Mohan.
__
Do you Yahoo!?
Yahoo! Platinum - Watch CBS' NCAA March Madness, live on your desktop!
http://platinum.yahoo.com
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


_
Help STOP SPAM with the new MSN 8 and get 2 months FREE*  
http://join.msn.com/?page=features/junkmail

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: Taglib documentation in JavaDoc format

2003-03-26 Thread James Mitchell 
On Wed, 2003-03-26 at 18:48, Mohan Kishore wrote:
> Hi,
> 
> I have put together an ant task with accompanying XSL files etc, which generate
> javadoc-like documentation for the taglibs (uses the current struts-xxx.xml
> files).

Hey, this is great!  Do you plan to contribute this?

Also, maybe you could help me with something similar that I've been
wanting to do.  I've been looking into adding a task to the build that
will generate a report for each group of tags (html, bean, etc) that
shows a grid-like view of attributes and tags.  The purpose of it would
be to give us a high-level view of which tags are using which attributes
and could help us find missing or fogotten attributes.

Here's a snip from the comments of my stylesheet:
 bodycontent id  multiple name--> more attributes
 === ===  ==
cookie   emtpy   (required)  (rt) *(rt) <- the * means required 
define   JSP (required)(rt)  
(more tags)


*Note - It is difficult to show in this email all the additional
information, but the report will show all the data from the tld.  Might
even be nice to add links to the docs from the tags.

Your thoughts?



> 
> The docs are available at http://mohankishore.tripod.com/struts-docs/ Just
> wanted to run it by the community to see if it feels its useful.
> 
> regards,
> Mohan.
> 


-- 
James Mitchell
Software Developer/Struts Evangelist
http://www.open-tools.org




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Taglib documentation in JavaDoc format

2003-03-26 Thread Mohan Kishore 
Hi,

I have put together an ant task with accompanying XSL files etc, which generate
javadoc-like documentation for the taglibs (uses the current struts-xxx.xml
files).

The docs are available at http://mohankishore.tripod.com/struts-docs/ Just
wanted to run it by the community to see if it feels its useful.

regards,
Mohan.

__
Do you Yahoo!?
Yahoo! Platinum - Watch CBS' NCAA March Madness, live on your desktop!
http://platinum.yahoo.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18343] - Nested tags cannot find bean in any scope in included JSP

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18343

Nested tags cannot find bean in any scope in included JSP





--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 23:21 ---
Let me know what kind of information you need, do you want me to attach the 
jsp, config xml, form and action classes?

For one thing, I can make the page display if I don't use included JSP.  
However, none of the form data can be saved.  I am not aware of any syntax 
change between 1.1 b2, which the current codes are working, to 1.1 RC or 
nightly build.  It makes no sense to me that it doesn't work in 1.1 RC.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18293] - Loading language files does not use Resource Bundle

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18293

Loading language files does not use Resource Bundle





--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 23:00 ---
If MessageResource was modified to use ResourceBundle internally then
MessageResource will inherit all its functionality.  ie Loading from a class and
hierarchy construction.

For example: If I have a class that implements PropertyResourceBundle it is
found before the properties file of the same name.

In our case we can use this feature to write a PropertyResourceBundle class that
dynamicaly combines multiple properties files so the user can deal with just the
one property file.

This means MessageResource can use our language class as easily as other classes
when looking up languages resources.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18343] - Nested tags cannot find bean in any scope in included JSP

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18343

Nested tags cannot find bean in any scope in included JSP





--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 22:57 ---
In this case, there's not much I can do until I see some code of how the tags
are marked up in the JSP.

The details about the session problem seems a little fuzzy. Data isn't making it
back to the server after form submit?... the tags aren't populating the page
properly?...

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18343] - Nested tags cannot find bean in any scope in included JSP

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18343

Nested tags cannot find bean in any scope in included JSP

[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Cannot find bean in any |Nested tags cannot find bean
   |scope in included JSP   |in any scope in included JSP

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18365] - Changes in the retrieveUserLocale of RequestUtils

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18365

Changes in the retrieveUserLocale of RequestUtils

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 17:44 ---
The method only checks the session if one exists.  If you don't want to use the 
accept-language header to identify the user's locale, don't use this method.  
You can override the RequestProcessor.processLocale() method to change the 
behavior.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18368] - Using dots (.) in action mappings

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18368

Using dots (.) in action mappings

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX



--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 17:42 ---
Periods are not valid action name characters.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 17833] - Validator Javascript does not validate negative numbers correctly

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17833

Validator Javascript does not validate negative numbers correctly

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 17:40 ---
*** Bug 18373 has been marked as a duplicate of this bug. ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18373] - validateInteger javascript doesn't display warning message

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18373

validateInteger javascript doesn't display warning message

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 17:40 ---


*** This bug has been marked as a duplicate of 17833 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18373] - validateInteger javascript doesn't display warning message

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18373

validateInteger javascript doesn't display warning message





--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 17:14 ---
ARGH! One more issue for the fix is submitted.

I left some alert statements in the fix.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18373] - validateInteger javascript doesn't display warning message

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18373

validateInteger javascript doesn't display warning message





--- Additional Comments From [EMAIL PROTECTED]  2003-03-26 17:11 ---
I made a mistake posting this bug report. The following line, from 
isAllDigits, has also been altered.

for (var n = startFrom; n < argvalue.length; n++) {

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18373] New: - validateInteger javascript doesn't display warning message

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18373

validateInteger javascript doesn't display warning message

   Summary: validateInteger javascript doesn't display warning
message
   Product: Struts
   Version: 1.1 RC1
  Platform: PC
OS/Version: Windows XP
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Validator Framework
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


validateInteger did not display a warning message when I typed all characters 
in a validated field. When I clicked submit the form did not submit, and there 
was no error message.

It also did not work properly for negative numbers. It did work for range 
validation. 

The reason for this bug is that two javascript methods have bugs. I fixed the 
methods and pasted the code below.

As an aside, I think that you should reconsider the wisdom of incorporating 
HEX and OCTAL validation in this method. I believe that the average Struts 
user would not expect this behavior. A separate validateHex and validateOctal 
method would be a better solution. If you really want a catch-all method, 
maybe validateAllIntegers would give users a clue as to what is going on. The 
99% use case will be standard decimal integers. 

The validation framework is a tremendous timesaver. Thanks for the good work.

function validateInteger(form) {
var bValid = true;
var focusField = null;
var i = 0;
var fields = new Array();
oInteger = new IntegerValidations();
for (x in oInteger) {
var field = form[oInteger[x][0]];

if (field.type == 'text' ||
field.type == 'textarea' ||
field.type == 'select-one' ||
field.type == 'radio') {

var value = '';
// get field's value
if (field.type == "select-one") {
var si = field.selectedIndex;
if (si >= 0) {
value = field.options[si].value;
}
} else {
value = field.value;
}

if (value.length > 0) {

if (!isAllDigits(value)) {
bValid = false;
// BEGIN ERROR MESSAGE FIX
focusField = field;
fields[i++] = oInteger[x][1];
// END ERROR MESSAGE FIX
} else {
var iValue = parseInt(value);
if (isNaN(iValue) || !(iValue >= -2147483648 && iValue <= 
2147483647)) {
if (i == 0) {
focusField = field;
}
fields[i++] = oInteger[x][1];
bValid = false;
}
}
}
}
}
if (fields.length > 0) {
   focusField.focus();
   alert(fields.join('\n'));
}
return bValid;
}

function isAllDigits(argvalue) {
argvalue = argvalue.toString();
var validChars = "0123456789";
var startFrom = 0;
if (argvalue.substring(0, 2) == "0x") {
   validChars = "0123456789abcdefABCDEF";
   startFrom = 2;
} else if (argvalue.charAt(0) == "0") {
   validChars = "01234567";
   startFrom = 1;
} 
// BEGIN NEGATIVE NUMBER FIX
else if (argvalue.charAt(0) == "-") {
   validChars = "0123456789";
   startFrom = 1;
   alert("first char dash");
}
// END NEGATIVE NUMBER FIX
for (var n = startFrom; n < argvalue.length; n++) {
if (validChars.indexOf(argvalue.substring(n, n+1)) == -1) return false;
}
alert("isAllDigits returning true");
return true;
}

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18370] New: - generate MANIFEST.MF with ant task

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18370

generate MANIFEST.MF with ant task

   Summary: generate MANIFEST.MF with ant task
   Product: Struts
   Version: Nightly Build
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Enhancement
  Priority: Other
 Component: Utilities
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


In order to tag a correct version into the MANIFEST.MF file , I propose to use 
the ant sub-task: , with, no need to checkout MANIFEST.MF file, and 
we are sure to have the correct version number.

in build.xml:









The MANIFEST.MF into conf/share will be :

Manifest-Version: 1.0
Specification-Title: Struts Framework
Specification-Vendor: Apache Software Foundation
Specification-Version: 1.1
Implementation-Vendor: Apache Software Foundation
Implementation-Vendor-Id: org.apache
Class-Path: commons-beanutils.jar
Class-Path: commons-collections.jar
Class-Path: commons-dbcp.jar
Class-Path: commons-digester.jar
Class-Path: commons-logging.jar
Class-Path: commons-pool.jar
Class-Path: commons-validator.jar
Class-Path: jakarta-oro.jar

no need to checkout tis file for a delivery.

if thats can help
Guillaume Compagnon [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18368] New: - Using dots (.) in action mappings

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18368

Using dots (.) in action mappings

   Summary: Using dots (.) in action mappings
   Product: Struts
   Version: 1.1 RC1
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Major
  Priority: Other
 Component: Controller
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Using the dot (ie '.') character in action mappings seems to cause some
side-effects with custom tags.

Example: if using
 
  
Then:
  
will not find the corresponding mapping in the xml file.
The tag seems to search for a wrong alias ("login" instead of "login-validate").
I guess the algorithm supposes that all chars behind the "." are part of the
servlet mapping (".do")

When replacing "." by "-" (ie "login-validate"), everyting works fine.

Best regards to the Struts team.

Bernard Ligny
mailto: [EMAIL PROTECTED]

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 18365] New: - Changes in the retrieveUserLocale of RequestUtils

2003-03-26 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18365

Changes in the retrieveUserLocale of RequestUtils

   Summary: Changes in the retrieveUserLocale of RequestUtils
   Product: Struts
   Version: Nightly Build
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Utilities
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I saw in the Class org.apache.struts.util.RequestUtils that in the verison 1.90 
the method retrieveUserLocale was changed and i suggest a other behavior:
1. look for the locale in the session
2. look for the locale in the request under the name Globals.LOCALE_KEY or from 
the parameter.
3. look in the request with request.getLocale

In the case the application developer don't want to use the session and want to 
control independent of the request header "accept-language" the language of the 
page ( e.g. bean:write ).

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]