DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-02-13 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2004-02-13 11:12 ---
Thanks, Gary. This seems fine as it stands, though we should decide whether /
should be supported as a reference to the default module. In the Action form,
either  or / can be used, but with the page form a NPE is exposed. (See the
page block on the html-link page.) My own preference would be to support both,
since that would help reduce support requests :) 

I'm going to link this to #25855 for recordkeeping purposes, but I'd still
consider it open pending a decision on  and /. 

*** This bug has been marked as a duplicate of 25855 ***

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-02-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2004-02-12 04:37 ---
Created an attachment (id=10325)
This is a comprehensive patch that includes the previous patch for this bug named 
patch_examples.txt.  , and extends the module= attribute to work with both the page= 
and forward= attributes.  Additionally, the ForwardConfig was modified to allow a 
module= attribute as well.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-02-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2004-02-12 04:47 ---
As per earlier comments from Ted, I have provided a patch (previous) that
provides more completeness to the module= attribute in the html:link tag.  I
changed the examples welcome page to provide an example of all 3 html:link types
that seemed applicable (forward, page, and action).  Additionally, I added a
module= attribute as part of the ForwardConfig.  The TestRequestUtils has been
updated to provide some additional testing related to the ForwardConfig change.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-02-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2004-02-10 18:06 ---
Created an attachment (id=10299)
Patch to examples that uses html:link with module= in the welcome.jsp.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-02-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2004-02-10 18:29 ---
I created a patch, which I just uploaded, that changes the index and welcome
pages into jsps.  I changed welcome.html to welcome.jsp and made the first 3
links into html:link tags with module= attributes.  Using the latest head the
welcome.jsp does create the correct links.  I'd love to help more, but I need to
do some digging to see where this examples app is headed, and I want to look
into the MailReader app.  Ted or others, let me know if there is any particular
items that would help get 1.2 out the door.  I have some time avaibable through
this weekend.  Otherwise I'll just poke around and see what I may be able to
contribute.  Thanks.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-02-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2004-02-11 03:21 ---
The additional patch was helpful. I had omitted the slash from the module 
names. For completeness, we would need to also support the page form of 
html:link, but it seems to be ignoring the module attribute. (See the 
examples/exercises html-link page.) In the hope that you have a chance to look 
at the page form, Gary, I'll start locking down the nightly build so that we 
can roll a 1.20 release.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-02-07 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2004-02-07 16:07 ---
Making progress. My first tests with the new examples application didn't work, 
so I tried the one Gary submitted for the taglib-exercise application. Those 
are working now, though mine still are not :(

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-01-27 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||struts-
   ||[EMAIL PROTECTED]
 AssignedTo|struts- |[EMAIL PROTECTED]
   |[EMAIL PROTECTED]  |



--- Additional Comments From [EMAIL PROTECTED]  2004-01-27 11:21 ---
I've applied this patch locally, but I'll need to look at it more extensively
tonight before applying it to the public distribution. 

I *very* much appreciate the effort in creating a comprehensive patch, which
includes changes to the examples too. :) 

Though, we're not using the taglib-excercise application anymore. I just haven't
had a chance to remove the old code. It was rolled into the new examples
application, which already uses modules. So, I just ported the example code
there.  :)

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2004-01-24 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2004-01-24 18:56 ---
Created an attachment (id=10081)
Patch for module= in html:link, html:frame, html:rewrite, and html:img as well as 
update to excercise-taglib

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2003-11-11 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2003-11-12 01:37 ---
I apologize for confusing the issue.  Consider this a request to add the 
module= attribute to the html:link and html:rewrite tags.  I agree the 
security feature is a separate request.  The entire set of patches still apply 
to add the module= attribute, simple ignore the SecureLinkTag patch.  I can 
resubmit the struts-html tld patch and remove the entries for the SecureLinkTag 
out of it, if desired.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2003-10-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2003-10-29 23:26 ---
Created an attachment (id=8808)
patch for LinkTag without secure= attribute

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2003-10-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2003-10-29 23:34 ---
Created an attachment (id=8809)
TagUtils patch to add module and security support needed for enhancement.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2003-10-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2003-10-29 23:38 ---
Created an attachment (id=8810)
RewriteTag patch

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2003-10-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2003-10-29 23:39 ---
Created an attachment (id=8811)
SecureLinkTag patch.  This is a new tag proposal.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2003-10-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2003-10-29 23:41 ---
Created an attachment (id=8812)
struts-html patch to reflect tld updates

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 24235] - Secure html:link tag, plus module support.

2003-10-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24235

Secure html:link tag, plus module support.





--- Additional Comments From [EMAIL PROTECTED]  2003-10-30 00:16 ---
These two issues should be opened in separate tickets.  logic:present already
supports role checking.  IMO, it's better to compose this behavior from separate
tags instead of building it into the html tags.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]