RE: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
Ted, I submitted a patch a month ago, following a go-ahead from Craig to a bugzilla I raised and it got zero response. Now maybe it wasn't any good and probably I should have put more explanation, but a response saying something would have been great. That was the reason I put the comment about a committer being assigned - I'd rather know there was someone with power interested rather than waste effort again. I also submitted code for if/else and switch/case tags - if you've got the time, I would appreciate your opinion on those as well. 1) PATCH: [Bug 1683] - Change Struts tags to be more granular in their design: This patch affected the following tags and involved re-factoring code out of the doStartTag() method so that Struts tags could be more easily sub-classed and individual bits of functionality overriden - a good example of where this could be used is, generating names which include the index value when embedded in an IterateTag. BaseFieldTag.java, BaseFieldTag.java, ButtonTag.java, CancelTag.java, CheckboxTag.java, ImageTag.java, ImgTag.java, MultiboxTag.java, RadioTag.java, ResetTag.java, SelectTag.java, SubmitTag.java, TextareaTag.java http://www.mail-archive.com/struts-dev%40jakarta.apache.org/msg01450.html I believe quite a few of these tags have been changed since I submitted this so unless CVS is clever I gues its now can't be applied and was a waste of time. 2) IF / ELSE and SWITCH/CASE Tags: These tags are basically just new wrappers for existing Struts functionality - the key classes extend the existing Struts CompareTagBase. I have a new version since I submitted them which includes the ability to specify condtions on the case tag - rather than just having to be equal - if its of interest I can send it. http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg01372.html Niall -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED]] Sent: 21 June 2001 11:13 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Just a note: Committers make the final decision about whether something is added to the official distribution, but we do not control the contribution or development process. Everyone is invited and encouraged to discuss how they would implement features here on the dev list, and then go off and implement them -- usually for use in your own project. When you bring the code back to list, then we can make the decision about whether it's a good fit with the Struts core. But, hey, don't wait on us guys -- do what *you* need to do, and then show us the code when you're ready. -- Ted Husted, Husted dot Com, Fairport NY USA. -- Custom Software ~ Technical Services. -- Tel 716 737-3463. -- http://www.husted.com/about/struts/ Niall Pemberton wrote: These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas.
Re: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
Hi Niall I have been using your extentions (being able to access and update indexed properties via the iterate tag) in my Web Timesheet system. Yes it would be really good if your changes are committed into the 1.1 release. Your code change is certainly not a waste of time for me. Otherwise if you made any updates to apply on top of the 1.0 STRUTS, can you let me know so I can incorporate into my development environment. Thanks in advance. Regards Michael Mok www.webappcabaret.com/normad - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Sunday, June 24, 2001 5:08 AM Subject: RE: Struts 1.0 Released - Looking forward to 1.1!!! Ted, I submitted a patch a month ago, following a go-ahead from Craig to a bugzilla I raised and it got zero response. Now maybe it wasn't any good and probably I should have put more explanation, but a response saying something would have been great. That was the reason I put the comment about a committer being assigned - I'd rather know there was someone with power interested rather than waste effort again. I also submitted code for if/else and switch/case tags - if you've got the time, I would appreciate your opinion on those as well. 1) PATCH: [Bug 1683] - Change Struts tags to be more granular in their design: This patch affected the following tags and involved re-factoring code out of the doStartTag() method so that Struts tags could be more easily sub-classed and individual bits of functionality overriden - a good example of where this could be used is, generating names which include the index value when embedded in an IterateTag. BaseFieldTag.java, BaseFieldTag.java, ButtonTag.java, CancelTag.java, CheckboxTag.java, ImageTag.java, ImgTag.java, MultiboxTag.java, RadioTag.java, ResetTag.java, SelectTag.java, SubmitTag.java, TextareaTag.java http://www.mail-archive.com/struts-dev%40jakarta.apache.org/msg01450.html I believe quite a few of these tags have been changed since I submitted this so unless CVS is clever I gues its now can't be applied and was a waste of time. 2) IF / ELSE and SWITCH/CASE Tags: These tags are basically just new wrappers for existing Struts functionality - the key classes extend the existing Struts CompareTagBase. I have a new version since I submitted them which includes the ability to specify condtions on the case tag - rather than just having to be equal - if its of interest I can send it. http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg01372.html Niall -Original Message- From: Ted Husted [mailto:[EMAIL PROTECTED]] Sent: 21 June 2001 11:13 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Just a note: Committers make the final decision about whether something is added to the official distribution, but we do not control the contribution or development process. Everyone is invited and encouraged to discuss how they would implement features here on the dev list, and then go off and implement them -- usually for use in your own project. When you bring the code back to list, then we can make the decision about whether it's a good fit with the Struts core. But, hey, don't wait on us guys -- do what *you* need to do, and then show us the code when you're ready. -- Ted Husted, Husted dot Com, Fairport NY USA. -- Custom Software ~ Technical Services. -- Tel 716 737-3463. -- http://www.husted.com/about/struts/ Niall Pemberton wrote: These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas.
Re: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
Just a note: Committers make the final decision about whether something is added to the official distribution, but we do not control the contribution or development process. Everyone is invited and encouraged to discuss how they would implement features here on the dev list, and then go off and implement them -- usually for use in your own project. When you bring the code back to list, then we can make the decision about whether it's a good fit with the Struts core. But, hey, don't wait on us guys -- do what *you* need to do, and then show us the code when you're ready. -- Ted Husted, Husted dot Com, Fairport NY USA. -- Custom Software ~ Technical Services. -- Tel 716 737-3463. -- http://www.husted.com/about/struts/ Niall Pemberton wrote: These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas.
Re: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
Niall, Your approach is simpler. However, I believe a lot of legacy code would break if that kind of change were to be made. I think a separate property name is warranted here. - jeff - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, June 19, 2001 7:58 PM Subject: RE: Struts 1.0 Released - Looking forward to 1.1!!! Martin, Ideally I would like Struts html tags (text, checkbox, hidden etc.) to automatically generate the name with the subscript if its embedded in an IterateTag so that iterated beans are automatically updated by Struts. For example: logic:iterate id=list name=formExample property=beanArray trtdhtml:text name=list property=desc//td /logic:iterate generates: input type=text name=beanArray[0].desc value=../ input type=text name=beanArray[1].desc value=../ input type=text name=beanArray[2].desc value=../ etc. etc. I realise you can do this with the indexId scripting variable, but this is simpler. I raised it before (prior to indexId and getIndex method) in the following messages: http://www.mail-archive.com/struts-user@jakarta.apache.org/msg05231.html http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg00975.html What do you think? Niall -Original Message- From: Martin Cooper [mailto:[EMAIL PROTECTED]] Sent: 19 June 2001 05:28 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Niall, Regarding auto-generating a subscript, what do you have in mind? The indexId attribute was added to the iterate tag recently (just before Struts 1.0) so that a scripting variable can be created containing the value of the current index. However, from the description in the TODO list, I'm not sure if that's the same thing or not. Thanks! -- Martin Cooper - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, June 18, 2001 6:46 PM Subject: Struts 1.0 Released - Looking forward to 1.1!!! Congratulations and thank you for Struts 1.0 - a great product. Now I know you guys deserve a well earned rest now Struts 1.0 is released, but what sort of timescale do you envisage work starting on 1.1? I am particularly interested for starters in: 1) ActionForms with dynamic properties. 2) If/Else and Switch/Case tags (I submitted tags which do this to the dev list a while ago). 3) Improved Iteration Support - auto-generating a subscript. These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas. Niall -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: 16 June 2001 01:23 To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [ANNOUNCEMENT] Struts 1.0 (Final) Released As promised at JavaOne, the Struts project team is proud to announce the availability of Version 1.0 (final release) of the Struts Framework. The binary distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/ and the source distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/src/ Craig McClanahan
Re: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
I hear what you are saying Niall, but again, I'd sooner introduce a new tag like 'html2' before I'd change existing tags/property names - especially now that struts 1.0 is out and feels more formally defined if you know what I mean. Too bad there was no way to label something 'depcrecated' in a taglib! Imagine seeing output to System.err stating that a tag has been deprecated - pretty cool I think... - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, June 20, 2001 4:23 PM Subject: RE: Struts 1.0 Released - Looking forward to 1.1!!! Jeff, You might be right, but the question is is it the right thing to do? - if it is, then it would be a shame to have to code indexed='true' from now to eternity - perhaps there could be a way of specifying the default behaviour in the struts-config. Niall -Original Message- From: Jeff Trent [mailto:[EMAIL PROTECTED]] Sent: 20 June 2001 14:09 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Niall, Your approach is simpler. However, I believe a lot of legacy code would break if that kind of change were to be made. I think a separate property name is warranted here. - jeff - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, June 19, 2001 7:58 PM Subject: RE: Struts 1.0 Released - Looking forward to 1.1!!! Martin, Ideally I would like Struts html tags (text, checkbox, hidden etc.) to automatically generate the name with the subscript if its embedded in an IterateTag so that iterated beans are automatically updated by Struts. For example: logic:iterate id=list name=formExample property=beanArray trtdhtml:text name=list property=desc//td /logic:iterate generates: input type=text name=beanArray[0].desc value=../ input type=text name=beanArray[1].desc value=../ input type=text name=beanArray[2].desc value=../ etc. etc. I realise you can do this with the indexId scripting variable, but this is simpler. I raised it before (prior to indexId and getIndex method) in the following messages: http://www.mail-archive.com/struts-user@jakarta.apache.org/msg05231.html http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg00975.html What do you think? Niall -Original Message- From: Martin Cooper [mailto:[EMAIL PROTECTED]] Sent: 19 June 2001 05:28 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Niall, Regarding auto-generating a subscript, what do you have in mind? The indexId attribute was added to the iterate tag recently (just before Struts 1.0) so that a scripting variable can be created containing the value of the current index. However, from the description in the TODO list, I'm not sure if that's the same thing or not. Thanks! -- Martin Cooper - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, June 18, 2001 6:46 PM Subject: Struts 1.0 Released - Looking forward to 1.1!!! Congratulations and thank you for Struts 1.0 - a great product. Now I know you guys deserve a well earned rest now Struts 1.0 is released, but what sort of timescale do you envisage work starting on 1.1? I am particularly interested for starters in: 1) ActionForms with dynamic properties. 2) If/Else and Switch/Case tags (I submitted tags which do this to the dev list a while ago). 3) Improved Iteration Support - auto-generating a subscript. These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas. Niall -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: 16 June 2001 01:23 To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [ANNOUNCEMENT] Struts 1.0 (Final) Released As promised at JavaOne, the Struts project team is proud to announce the availability of Version 1.0 (final release) of the Struts Framework. The binary distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/ and the source distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/src/ Craig McClanahan
RE: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
Another tag works well for me :-) - we have our own customised versions of struts tags to do this. I submitted a Bugzilla to make tags more granular so that individual bits of behaviour (like generating the name )could be overriden. Unfortunately :-( it didn't make it into Struts 1.0 and I think quite a few of the classes have been changed since, so it may have been wasted effort. http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg01450.html -Original Message- From: Jeff Trent [mailto:[EMAIL PROTECTED]] Sent: 20 June 2001 21:59 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! I hear what you are saying Niall, but again, I'd sooner introduce a new tag like 'html2' before I'd change existing tags/property names - especially now that struts 1.0 is out and feels more formally defined if you know what I mean. Too bad there was no way to label something 'depcrecated' in a taglib! Imagine seeing output to System.err stating that a tag has been deprecated - pretty cool I think... - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Wednesday, June 20, 2001 4:23 PM Subject: RE: Struts 1.0 Released - Looking forward to 1.1!!! Jeff, You might be right, but the question is is it the right thing to do? - if it is, then it would be a shame to have to code indexed='true' from now to eternity - perhaps there could be a way of specifying the default behaviour in the struts-config. Niall -Original Message- From: Jeff Trent [mailto:[EMAIL PROTECTED]] Sent: 20 June 2001 14:09 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Niall, Your approach is simpler. However, I believe a lot of legacy code would break if that kind of change were to be made. I think a separate property name is warranted here. - jeff - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Tuesday, June 19, 2001 7:58 PM Subject: RE: Struts 1.0 Released - Looking forward to 1.1!!! Martin, Ideally I would like Struts html tags (text, checkbox, hidden etc.) to automatically generate the name with the subscript if its embedded in an IterateTag so that iterated beans are automatically updated by Struts. For example: logic:iterate id=list name=formExample property=beanArray trtdhtml:text name=list property=desc//td /logic:iterate generates: input type=text name=beanArray[0].desc value=../ input type=text name=beanArray[1].desc value=../ input type=text name=beanArray[2].desc value=../ etc. etc. I realise you can do this with the indexId scripting variable, but this is simpler. I raised it before (prior to indexId and getIndex method) in the following messages: http://www.mail-archive.com/struts-user@jakarta.apache.org/msg05231.html http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg00975.html What do you think? Niall -Original Message- From: Martin Cooper [mailto:[EMAIL PROTECTED]] Sent: 19 June 2001 05:28 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Niall, Regarding auto-generating a subscript, what do you have in mind? The indexId attribute was added to the iterate tag recently (just before Struts 1.0) so that a scripting variable can be created containing the value of the current index. However, from the description in the TODO list, I'm not sure if that's the same thing or not. Thanks! -- Martin Cooper - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, June 18, 2001 6:46 PM Subject: Struts 1.0 Released - Looking forward to 1.1!!! Congratulations and thank you for Struts 1.0 - a great product. Now I know you guys deserve a well earned rest now Struts 1.0 is released, but what sort of timescale do you envisage work starting on 1.1? I am particularly interested for starters in: 1) ActionForms with dynamic properties. 2) If/Else and Switch/Case tags (I submitted tags which do this to the dev list a while ago). 3) Improved Iteration Support - auto-generating a subscript. These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas. Niall -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: 16 June 2001 01:23
RE: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
Martin, Ideally I would like Struts html tags (text, checkbox, hidden etc.) to automatically generate the name with the subscript if its embedded in an IterateTag so that iterated beans are automatically updated by Struts. For example: logic:iterate id=list name=formExample property=beanArray trtdhtml:text name=list property=desc//td /logic:iterate generates: input type=text name=beanArray[0].desc value=../ input type=text name=beanArray[1].desc value=../ input type=text name=beanArray[2].desc value=../ etc. etc. I realise you can do this with the indexId scripting variable, but this is simpler. I raised it before (prior to indexId and getIndex method) in the following messages: http://www.mail-archive.com/struts-user@jakarta.apache.org/msg05231.html http://www.mail-archive.com/struts-dev@jakarta.apache.org/msg00975.html What do you think? Niall -Original Message- From: Martin Cooper [mailto:[EMAIL PROTECTED]] Sent: 19 June 2001 05:28 To: [EMAIL PROTECTED] Subject: Re: Struts 1.0 Released - Looking forward to 1.1!!! Niall, Regarding auto-generating a subscript, what do you have in mind? The indexId attribute was added to the iterate tag recently (just before Struts 1.0) so that a scripting variable can be created containing the value of the current index. However, from the description in the TODO list, I'm not sure if that's the same thing or not. Thanks! -- Martin Cooper - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, June 18, 2001 6:46 PM Subject: Struts 1.0 Released - Looking forward to 1.1!!! Congratulations and thank you for Struts 1.0 - a great product. Now I know you guys deserve a well earned rest now Struts 1.0 is released, but what sort of timescale do you envisage work starting on 1.1? I am particularly interested for starters in: 1) ActionForms with dynamic properties. 2) If/Else and Switch/Case tags (I submitted tags which do this to the dev list a while ago). 3) Improved Iteration Support - auto-generating a subscript. These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas. Niall -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: 16 June 2001 01:23 To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [ANNOUNCEMENT] Struts 1.0 (Final) Released As promised at JavaOne, the Struts project team is proud to announce the availability of Version 1.0 (final release) of the Struts Framework. The binary distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/ and the source distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/src/ Craig McClanahan
Re: Struts 1.0 Released - Looking forward to 1.1!!!!!!!
Niall, Regarding auto-generating a subscript, what do you have in mind? The indexId attribute was added to the iterate tag recently (just before Struts 1.0) so that a scripting variable can be created containing the value of the current index. However, from the description in the TODO list, I'm not sure if that's the same thing or not. Thanks! -- Martin Cooper - Original Message - From: Niall Pemberton [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, June 18, 2001 6:46 PM Subject: Struts 1.0 Released - Looking forward to 1.1!!! Congratulations and thank you for Struts 1.0 - a great product. Now I know you guys deserve a well earned rest now Struts 1.0 is released, but what sort of timescale do you envisage work starting on 1.1? I am particularly interested for starters in: 1) ActionForms with dynamic properties. 2) If/Else and Switch/Case tags (I submitted tags which do this to the dev list a while ago). 3) Improved Iteration Support - auto-generating a subscript. These areas are currently unassigned on the ToDo list and presumably need a committer to take control. If someone is assigned I am more than willing to contribute to these (and other) areas. Niall -Original Message- From: Craig R. McClanahan [mailto:[EMAIL PROTECTED]] Sent: 16 June 2001 01:23 To: [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED]; [EMAIL PROTECTED] Subject: [ANNOUNCEMENT] Struts 1.0 (Final) Released As promised at JavaOne, the Struts project team is proud to announce the availability of Version 1.0 (final release) of the Struts Framework. The binary distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/ and the source distribution is available at: http://jakarta.apache.org/builds/jakarta-struts/release/v1.0/src/ Craig McClanahan
