RE: cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html FormTag.java
On Fri, 25 Oct 2002, Martin Cooper wrote: Date: Fri, 25 Oct 2002 18:06:31 -0700 From: Martin Cooper [EMAIL PROTECTED] Reply-To: Struts Developers List [EMAIL PROTECTED] To: 'Struts Developers List' [EMAIL PROTECTED] Subject: RE: cvs commit: jakarta-struts/src/share/org/apache/struts/taglib /html FormTag.java Why was this changed? The change makes Struts break compliance with the HTTP spec, which states: - 5.1.1 Method The Method token indicates the method to be performed on the resource identified by the Request-URI. The method is case-sensitive. - The method value for a post request is specified as POST, not post. Please change this back. The value included in an HTML page (as defined in the HTML spec) has no direct relationship with the value a browser sends on the first line of a request (as defined in the HTTP spec). In fact, the references to the get and post values in the HTML spec are almost universally in lower case. This is not a reason to change them back (although the original upper case values did not violate XHTML either). -- Martin Cooper Craig -- To unsubscribe, e-mail: mailto:struts-dev-unsubscribe;jakarta.apache.org For additional commands, e-mail: mailto:struts-dev-help;jakarta.apache.org
RE: cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html FormTag.java
Thanks Craig, I've been meaning to get back to that.
James Mitchell
Software Engineer\Struts Evangelist
Struts-Atlanta, the Open Minded Developer Network
http://struts-atlanta.open-tools.org
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
Sent: Saturday, June 22, 2002 6:07 PM
To: [EMAIL PROTECTED]
Subject: cvs commit:
jakarta-struts/src/share/org/apache/struts/taglib/html FormTag.java
craigmcc2002/06/22 15:06:33
Modified:src/share/org/apache/struts/taglib/html FormTag.java
Log:
Do not try to set focus on a hidden field.
PR: Bugzilla #10005
Submitted by: James Mitchell jmitchtx at telocity.com
Revision ChangesPath
1.20 +13 -4
jakarta-struts/src/share/org/apache/struts/taglib/html/FormTag.java
Index: FormTag.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/F
ormTag.java,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- FormTag.java22 Mar 2002 23:47:18 - 1.19
+++ FormTag.java22 Jun 2002 22:06:33 - 1.20
@@ -652,6 +652,15 @@
results.append(script language=\JavaScript\);
results.append( type=\text/javascript\\r\n);
results.append( !--\r\n);
+results.append( if (document.forms[\);
+results.append(name);
+results.append(\].elements[\);
+results.append(tempFocus);
+results.append(\]);
+if (refocus.length() 1) {
+results.append(refocus.toString());
+}
+results.append(.type != \hidden\) \r\n);
results.append(document.forms[\);
results.append(name);
results.append(\].elements[\);
--
To unsubscribe, e-mail:
mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
--
To unsubscribe, e-mail: mailto:[EMAIL PROTECTED]
For additional commands, e-mail: mailto:[EMAIL PROTECTED]
Re: cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html FormTag.java
On Sun, Apr 29, 2001 at 03:11:40AM -, [EMAIL PROTECTED] wrote: craigmcc01/04/28 20:11:40 Modified:src/share/org/apache/struts/taglib/html FormTag.java Log: Migrate the attributes created by the html:form tag (the form tag instance itself, and a reference to the form bean itself) from page scope to request scope. Among other things, this change enables the use of a separate JSP page (accessed by jsp:include or the template tag library) to contain the input fields, nested inside an html:form tag instance. Many thanks. incze
Re: cvs commit: jakarta-struts/src/share/org/apache/struts/taglib/html FormTag.java
BTW, I have found that the Javascript generated here does not seem to
work well with Netscape 4.7 (Windows). It focusses on the field at
first, but jumps to the browser's "Address" field when you press tab.
For this browser/platform, it does work correctly when put into the
body tag -- onload="document.logonForm.username.focus();"
[EMAIL PROTECTED] wrote:
craigmcc01/03/06 14:09:53
Modified:src/doc release-notes-1.0-b2.xml struts-html.xml
src/share/org/apache/struts/taglib/html FormTag.java
Log:
Correct the JavaScript generated to implement the "focus" attribute of the
html:form tag so that it works even when you use nested or indexed property
expressions for the field you want initial focus on.
Submitted by: Hal Deadman [EMAIL PROTECTED]
PR: Bugzilla #714
Revision ChangesPath
1.2 +6 -0 jakarta-struts/src/doc/release-notes-1.0-b2.xml
Index: release-notes-1.0-b2.xml
===
RCS file: /home/cvs/jakarta-struts/src/doc/release-notes-1.0-b2.xml,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- release-notes-1.0-b2.xml 2001/03/06 20:40:35 1.1
+++ release-notes-1.0-b2.xml 2001/03/06 22:09:49 1.2
@@ -36,6 +36,8 @@
liThe codelt;html:linkgt;/code tag now accepts an optional
codeanchor/code attribute, to allow the inclusion of a
(possibly calculated) anchor ("#xxx") in the generated hyperlink./li
+liThe codelt;html:basegt;/code tag now accepts an optional
+codetarget/code attribute./li
/ul
pThe following new features have been added to the
@@ -70,6 +72,10 @@
hyperlink value./li
liThe codelt;html:linkgt;/code tag now correctly places any
specified anchor ("#xxx") in the generated hyperlink./li
+liThe JavaScript code generated to implement the codefocus/code
+attribute of the codelt;html:formgt;/code tag now works even
+when you use nested or indexed property expressions. Previously,
+this would generate an invalid JavaScript reference to the field./li
/ul
pThe following changes and bug fixes to the Struts Documentation
1.19 +10 -0 jakarta-struts/src/doc/struts-html.xml
Index: struts-html.xml
===
RCS file: /home/cvs/jakarta-struts/src/doc/struts-html.xml,v
retrieving revision 1.18
retrieving revision 1.19
diff -u -r1.18 -r1.19
--- struts-html.xml 2001/03/06 17:04:18 1.18
+++ struts-html.xml 2001/03/06 22:09:50 1.19
@@ -41,6 +41,16 @@
took place (which is where the browser would normally resolve
relative references against)./p
/info
+
+ attribute
+nametarget/name
+requiredfalse/required
+rtexprvaluetrue/rtexprvalue
+info
+ pThe window target for this base reference./p
+/info
+ /attribute
+
/tag
tag
1.7 +8 -7
jakarta-struts/src/share/org/apache/struts/taglib/html/FormTag.java
Index: FormTag.java
===
RCS file:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/FormTag.java,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -r1.6 -r1.7
--- FormTag.java 2001/03/06 16:58:24 1.6
+++ FormTag.java 2001/03/06 22:09:52 1.7
@@ -1,7 +1,7 @@
/*
- * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/FormTag.java,v 1.6
2001/03/06 16:58:24 craigmcc Exp $
- * $Revision: 1.6 $
- * $Date: 2001/03/06 16:58:24 $
+ * $Header:
/home/cvs/jakarta-struts/src/share/org/apache/struts/taglib/html/FormTag.java,v 1.7
2001/03/06 22:09:52 craigmcc Exp $
+ * $Revision: 1.7 $
+ * $Date: 2001/03/06 22:09:52 $
*
*
*
@@ -85,7 +85,7 @@
* properties correspond to the various fields of the form.
*
* @author Craig R. McClanahan
- * @version $Revision: 1.6 $ $Date: 2001/03/06 16:58:24 $
+ * @version $Revision: 1.7 $ $Date: 2001/03/06 22:09:52 $
*/
public class FormTag extends TagSupport {
@@ -556,10 +556,11 @@
results.append("script language=\"JavaScript\"");
results.append(" type=\"text/javascript\"\r\n");
results.append(" !--\r\n");
- results.append("document.");
+ results.append("document.forms[\"");
results.append(name);
- results.append(".");
- results.append(focus);
+ results.append("\"].elements[\"");
+results.append(focus);
+
