[jira] [Commented] (SUBMARINE-57) Add more elaborate message if submarine command is not recognized
[
https://issues.apache.org/jira/browse/SUBMARINE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903799#comment-16903799
]
Hudson commented on SUBMARINE-57:
-
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17073 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/17073/])
SUBMARINE-57. Add more elaborate message if submarine command is not (snemeth:
rev e5f4cd0fdae7e689789dd74bfbcfa6c52895f037)
* (edit)
hadoop-submarine/hadoop-submarine-core/src/main/java/org/apache/hadoop/yarn/submarine/client/cli/Cli.java
> Add more elaborate message if submarine command is not recognized
> -
>
> Key: SUBMARINE-57
> URL: https://issues.apache.org/jira/browse/SUBMARINE-57
> Project: Hadoop Submarine
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Adam Antal
>Priority: Major
> Fix For: 0.2.1, 0.3.0
>
> Attachments: SUBMARINE-57.001.patch, SUBMARINE-57.001.patch
>
>
> In {{org.apache.hadoop.yarn.submarine.client.cli.Cli#main}}, we have this
> error handling:
> {code:java}
> if (args[0].equals("job")) {
> String subCmd = args[1];
> if (subCmd.equals(CliConstants.RUN)) {
> new RunJobCli(clientContext).run(moduleArgs);
> } else if (subCmd.equals(CliConstants.SHOW)) {
> new ShowJobCli(clientContext).run(moduleArgs);
> } else {
> printHelp();
> throw new IllegalArgumentException("Unknown option for job");
> }
> } else {
> printHelp();
> throw new IllegalArgumentException("Bad parameters ");
> }
> {code}
> "Bad parameters " need to be replaced with someting making more sense.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SUBMARINE-57) Add more elaborate message if submarine command is not recognized
[
https://issues.apache.org/jira/browse/SUBMARINE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903788#comment-16903788
]
Szilard Nemeth commented on SUBMARINE-57:
-
Thanks [~adam.antal] for this patch, committed to trunk and branch-3.2!
> Add more elaborate message if submarine command is not recognized
> -
>
> Key: SUBMARINE-57
> URL: https://issues.apache.org/jira/browse/SUBMARINE-57
> Project: Hadoop Submarine
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Adam Antal
>Priority: Major
> Attachments: SUBMARINE-57.001.patch, SUBMARINE-57.001.patch
>
>
> In {{org.apache.hadoop.yarn.submarine.client.cli.Cli#main}}, we have this
> error handling:
> {code:java}
> if (args[0].equals("job")) {
> String subCmd = args[1];
> if (subCmd.equals(CliConstants.RUN)) {
> new RunJobCli(clientContext).run(moduleArgs);
> } else if (subCmd.equals(CliConstants.SHOW)) {
> new ShowJobCli(clientContext).run(moduleArgs);
> } else {
> printHelp();
> throw new IllegalArgumentException("Unknown option for job");
> }
> } else {
> printHelp();
> throw new IllegalArgumentException("Bad parameters ");
> }
> {code}
> "Bad parameters " need to be replaced with someting making more sense.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (SUBMARINE-57) Add more elaborate message if submarine command is not recognized
[
https://issues.apache.org/jira/browse/SUBMARINE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16885157#comment-16885157
]
Hadoop QA commented on SUBMARINE-57:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 22m
7s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
25s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
18s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
29s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 20s{color} | {color:green} branch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
22s{color} | {color:green} trunk passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 0m
40s{color} | {color:blue} Used deprecated FindBugs config; considering
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
38s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green}
13m 45s{color} | {color:green} patch has no errors when building and testing
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
43s{color} | {color:green} hadoop-submarine-core in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
32s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 57m 0s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.7 Server=18.09.7 base:
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/156/artifact/out/Dockerfile
|
| JIRA Issue | SUBMARINE-57 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12974722/SUBMARINE-57.001.patch
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite
unit shadedclient findbugs checkstyle |
| uname | Linux 1642552e9ed2 4.15.0-52-generic #56-Ubuntu SMP Tue Jun 4
22:49:08 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 18ee109 |
| Default Java | 1.8.0_212 |
| Test Results |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/156/testReport/ |
| Max. process+thread count | 307 (vs. ulimit of 5500) |
| modules | C:
[jira] [Commented] (SUBMARINE-57) Add more elaborate message if submarine command is not recognized
[
https://issues.apache.org/jira/browse/SUBMARINE-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16841098#comment-16841098
]
Hadoop QA commented on SUBMARINE-57:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
38s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} yetus {color} | {color:red} 0m 7s{color}
| {color:red} Unprocessed flag(s): --jenkins --skip-dir --mvn-args {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/116/artifact/out/Dockerfile
|
| JIRA Issue | SUBMARINE-57 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/1296/SUBMARINE-57.001.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-SUBMARINE-Build/116/console |
| versions | git=2.7.4 |
| Powered by | Apache Yetus 0.11.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
> Add more elaborate message if submarine command is not recognized
> -
>
> Key: SUBMARINE-57
> URL: https://issues.apache.org/jira/browse/SUBMARINE-57
> Project: Hadoop Submarine
> Issue Type: Improvement
>Reporter: Szilard Nemeth
>Assignee: Adam Antal
>Priority: Major
> Attachments: SUBMARINE-57.001.patch
>
>
> In {{org.apache.hadoop.yarn.submarine.client.cli.Cli#main}}, we have this
> error handling:
> {code:java}
> if (args[0].equals("job")) {
> String subCmd = args[1];
> if (subCmd.equals(CliConstants.RUN)) {
> new RunJobCli(clientContext).run(moduleArgs);
> } else if (subCmd.equals(CliConstants.SHOW)) {
> new ShowJobCli(clientContext).run(moduleArgs);
> } else {
> printHelp();
> throw new IllegalArgumentException("Unknown option for job");
> }
> } else {
> printHelp();
> throw new IllegalArgumentException("Bad parameters ");
> }
> {code}
> "Bad parameters " need to be replaced with someting making more sense.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
