Re: Make planner work again for CCR dives

2014-10-16 Thread Dirk Hohndel
On Thu, Oct 16, 2014 at 05:28:42PM +0200, Robert Helling wrote:
> Hi,
> 
> the latest CCR patches had rendered the planner not usable for CCR
> dives. This patch corrects this (and reenables the CCR set point column
> for segments). The problem was that a new member setpoint of struct
> divepoint had been introduced, but there was already po2 which had the
> same meaning. This patch merges the two and renames them setpoint to
> prevent future confusion.

I'm a bit nervous that it doesn't apply to latest master.
Do you have other code in your tree that isn't upstream?

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: Bug in the OSTC3 setting O2% in a gasmix from a computer

2014-10-16 Thread Anton Lundin
On 16 October, 2014 - Anton Lundin wrote:

> Hi.
> 
> I'm currently hacking on Subsurface, and more specific the code to
> configure your OSTC3 from it.
> 
> I have seen some wierd problems with setting a O2% value from the
> computer. Every O2 value in the range 21..99 works as it should, but i
> can't set it to 100% or anything below 21%. In any of those case it
> changes the O2 value to the default 21%. I've spent a fair amount of
> time debugging Subsurface but as far as i can see everything there looks
> as it should.
> 
> Then started to suspect a bug in the OSTC3, based on the weird range of
> values that works, so i to some time and dove down into the OSTC3 code
> base and found some interesting bits.
> 

And one for the archives. As usual HW answered and was really helpful
and responsive. The problem with not being able to set O2
values below 21 was a old bug, and me not on the latest stable firmware.
The bug was fixed in stable 1.60

The not being able to set 100% bug is now found and a fix will be
released in a future firmware.

Thanks HW!

//Anton

-- 
Anton Lundin+46702-161604
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Make planner work again for CCR dives

2014-10-16 Thread Robert Helling
Hi,the latest CCR patches had rendered the planner not usable for CCR dives. This patch corrects this (and reenables the CCR set point column for segments). The problem was that a new member setpoint of struct divepoint had been introduced, but there was already po2 which had the same meaning. This patch merges the two and renames them setpoint to prevent future confusion.BestRobert

0001-PLanner-working-again-for-CCR-dives.patch
Description: Binary data

-- .oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oORobert C. Helling     Elite Master Course Theoretical and Mathematical Physics                      Scientific Coordinator                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339                      http://www.atdotde.deEnhance your privacy, use cryptography! My PGP keys have fingerprintsA9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    andDCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F



signature.asc
Description: Message signed with OpenPGP using GPGMail
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface