Fwd: Subsurface UI for CCR dives

2014-10-20 Thread Rodrigo Severo
On Sat, Oct 18, 2014 at 5:29 PM, Paul Sargent paul.lions...@icloud.com wrote:


 I wrote some notes on a ticket about gas consumption on CCR dives several 
 months ago (before I knew the Poseidon logged cylinder pressure). Maybe those 
 are useful. http://trac.subsurface-divelog.org/ticket/80. Unfortunately the 
 attachments I added seem to have been lost.

I've just added a commetn on the above mentioned ticket.

It's about diluent SAC calculations:

I believe we should consider that diluent is only used on decends,
taking depth (ambient pressure) in account just like we do to
calculate SAC for OC. In other words, when depth is maintained or
reduced, we should consider diluent spend as zero, all use of diluent
happening on decends.


Regards,

Rodrigo


-- 
Rodrigo Severo | DIRETOR DE TECNOLOGIA
Tel. +55 61 3030-1515
Siga a Fábrica no twitter:@empautaclipping

fabricadeideias.com
12 ANOS DE TECNOLOGIA E COMUNICAÇÃO
NUMA COMBINAÇÃO PERFEITA
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


[PATCH 2/6] Finish off the firmware update code.

2014-10-20 Thread Anton Lundin
This code connects the final parts of the generic firmware update code.

Signed-off-by: Anton Lundin gla...@acc.umu.se
---
 configuredivecomputer.cpp | 22 +-
 configuredivecomputer.h   |  3 +++
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/configuredivecomputer.cpp b/configuredivecomputer.cpp
index 1b2b9e8..9a708ad 100644
--- a/configuredivecomputer.cpp
+++ b/configuredivecomputer.cpp
@@ -13,7 +13,8 @@ ConfigureDiveComputer::ConfigureDiveComputer(QObject *parent) 
:
QObject(parent),
readThread(0),
writeThread(0),
-   resetThread(0)
+   resetThread(0),
+   firmwareThread(0)
 {
setState(INITIAL);
 }
@@ -512,7 +513,17 @@ bool ConfigureDiveComputer::restoreXMLBackup(QString 
fileName, DeviceDetails *de
 
 void ConfigureDiveComputer::startFirmwareUpdate(QString fileName, 
device_data_t *data)
 {
+   setState(FWUPDATE);
 
+   if (firmwareThread)
+   firmwareThread-deleteLater();
+
+   firmwareThread = new FirmwareUpdateThread(this, data, fileName);
+   connect(firmwareThread, SIGNAL(finished()),
+   this, SLOT(firmwareThreadFinished()), Qt::QueuedConnection);
+   connect(firmwareThread, SIGNAL(error(QString)), this, 
SLOT(setError(QString)));
+
+   firmwareThread-start();
 }
 
 void ConfigureDiveComputer::resetSettings(device_data_t *data)
@@ -557,6 +568,15 @@ void ConfigureDiveComputer::writeThreadFinished()
}
 }
 
+void ConfigureDiveComputer::firmwareThreadFinished()
+{
+   setState(DONE);
+   if (resetThread-lastError.isEmpty()) {
+   //No error
+   emit message(tr(Device firmware successfully updated));
+   }
+}
+
 void ConfigureDiveComputer::resetThreadFinished()
 {
setState(DONE);
diff --git a/configuredivecomputer.h b/configuredivecomputer.h
index 8123576..93c50f9 100644
--- a/configuredivecomputer.h
+++ b/configuredivecomputer.h
@@ -22,6 +22,7 @@ public:
READING,
WRITING,
RESETTING,
+   FWUPDATE,
CANCELLING,
CANCELLED,
ERROR,
@@ -49,11 +50,13 @@ private:
ReadSettingsThread *readThread;
WriteSettingsThread *writeThread;
ResetSettingsThread *resetThread;
+   FirmwareUpdateThread *firmwareThread;
void setState(states newState);
 private slots:
void readThreadFinished();
void writeThreadFinished();
void resetThreadFinished();
+   void firmwareThreadFinished();
void setError(QString err);
 };
 
-- 
1.9.1

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


[PATCH 3/6] Disable update firmware button for OSTC3 for now

2014-10-20 Thread Anton Lundin
We currently don't support update firmware for the OSTC3. Where waiting
for support in libdivecomputer for that, so disable that button for now.

Signed-off-by: Anton Lundin gla...@acc.umu.se
---
 qt-ui/configuredivecomputerdialog.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qt-ui/configuredivecomputerdialog.cpp 
b/qt-ui/configuredivecomputerdialog.cpp
index 92f4c39..781a0e6 100644
--- a/qt-ui/configuredivecomputerdialog.cpp
+++ b/qt-ui/configuredivecomputerdialog.cpp
@@ -615,7 +615,7 @@ void 
ConfigureDiveComputerDialog::on_DiveComputerList_currentRowChanged(int curr
case 0:
selected_vendor = Heinrichs Weikamp;
selected_product = OSTC 3;
-   ui.updateFirmwareButton-setEnabled(true);
+   ui.updateFirmwareButton-setEnabled(false);
break;
case 1:
selected_vendor = Suunto;
-- 
1.9.1

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface