Re: Problems since last update

2017-12-25 Thread Stefan Fuchs
Hallo Robert,

Am 24.12.2017 um 00:07 schrieb Robert Helling:
> Hi,
>
>> On 23. Dec 2017, at 21:17, Stefan Fuchs  wrote:
>>
>> Maybe Robert and/or Rick could have a look at this as well?
> such things tend to be hard to track down. But let’s see.
>
> I this is something I introduced recently, my bet would be on 
> 4d605ce51fcb4bbadf83471568d9f315844f904b where I tried to limit the number of 
> replanning that were triggered by UI element changes. Maybe that was a bit 
> too aggressive or with small gradient factors deco is longer and so is deco 
> computation and there is a race condition with some computation that turns 
> replanning off. But tracking race conditions is no fun. Let’s see what the 
> holidays bring (maybe a bit debugging time and motivation.
Reverting this specific commit is possible with current master but
doesn't solve the issue.

Best regards
Stefan

-- 

Stefan Fuchs
E-Mail: sfu...@gmx.de 

___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface


Re: 4.7.6

2017-12-25 Thread Cristian Ionescu-Idbohrn
On Sun, 24 Dec 2017, Dirk Hohndel wrote:
> > On Dec 24, 2017, at 12:54 PM, Cristian Ionescu-Idbohrn 
> >  wrote:
> > 
> > On Sun, 24 Dec 2017, Dirk Hohndel wrote:
> >> 
> >> cd ~/src/subsurface
> >> git submodule update
> > 
> >> cd subsurface
> > [master=]> git submodule update
> > fatal: destination path 
> > '.../subsurface/libdivecomputer' already exists and 
> > is not an empty directory.
> 
> And there is your problem - I'm guessing that you have a version of 
> libdivecomputer checked out in subsurface/libdivecomputer

I guess subsurface/libdivecomputer came with:

commit 10237a19b7b65802a0ceb2f8e2192703ad2fcf97
Author: Dirk Hohndel 
Date:   Sun Dec 3 11:39:58 2017 -0800

libdc: add our libdivecomputer branch as git submodule

But that was previously cloned under ~/src, if I remember correctly.  
And what I missed was doing:

[master=]> git submodule update

at some point after pulling from 
git://github.com/Subsurface-divelog/subsurface

> move that directory elsewhere (or remove completely) and try again.

Yes, I ended up removing both ~/src/libdivecomputer and 
~/src/subsurface/libdivecomputer,

> cd ~/src/subsurface
[master=]> git pull
[master=]> git submodule update

and now it builds.

I imagine this must have happen for many other people who keep their 
cloned trees around for a long time.  If my interpretation is correct, 
would it be a good idea to mention something about it in the INSTALL 
file?


Cheers,

-- 
Cristian
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface