Re: at some point we need to release Subsurface 4.5
I so not have that fixes as I don't understand that code well yet. A struct is passed to the doimport routine, I am working on that only so that what is passed to the main program is valid. I don't think any further fix is needed. It takes me so long only because I still try to understand certain artifacts such that I am getting all dive spots except for one. Also it seems that when I delete a dive off the table the main program tries to delete that of a trip but there is not trip. I am sure I find that issue. So far I have changed the design slightly and fixed a few bugs. I'll let you know once I get stuck Give me a few days to cleanup my code and put further documentation, the patch should be small and easy to understand what I did. Regards, Guido +41 79 3217739 > Am 28.08.2015 um 15:58 schrieb Dirk Hohndel : > >> On Fri, Aug 28, 2015 at 01:23:39PM +0200, Guido Lerch wrote: >> Hi Dirk, >> >> Not that far but soon, the current import cannot work as reading a dive from >> an existing table returns always NULL, >> we discussed this. > > Yes. Do you have this fixed? Otherwise I'll just send a change that > addresses this. > > The reason I keep poking you for patches is simple. The smaller the > change, the easier. And that whole "release early, release often" logic > works for changes like the ones you want to do as well. So it would be > good to address this one thing, make a commit, send me a patch... > > /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Fri, Aug 28, 2015 at 01:23:39PM +0200, Guido Lerch wrote: > Hi Dirk, > > Not that far but soon, the current import cannot work as reading a dive from > an existing table returns always NULL, > we discussed this. Yes. Do you have this fixed? Otherwise I'll just send a change that addresses this. The reason I keep poking you for patches is simple. The smaller the change, the easier. And that whole "release early, release often" logic works for changes like the ones you want to do as well. So it would be good to address this one thing, make a commit, send me a patch... /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
Hi Dirk, > Hi Dirk, > I did not follow this closely but how much time do I have to fix the Uemis > implementation. > I make nice progress but since I am doing this besides my job, like propably > all, I would need a few days more. I expect a rather lengthy beta cycle. And I don't think I'll be ready to release even Beta 1 until later next week. There are quite a few more things that I need to get ready... > Currently it does import all my 252 dive¹s I did with it with the correct > profiles and divespots. > I am currently working on buddies, which I believe it never did before. Correct. > Also with the current master the Uemis support would be completely broken. Well, it works for some of us, but I certainly would love to see your patches. Can you send what you already have done? Not that far but soon, the current import cannot work as reading a dive from an existing table returns always NULL, we discussed this. Anyway, within the next weeks I should be done, depending on how much time I can spare but I¹ll send in my first :-) patch within the next week or so. Best regards, Guido Lerch m: +41 79 3217739 "Quality means building the customer¹s point of view into every aspect of a product from design to final recycling." From: subsurface on behalf of Dirk Hohndel Date: Thursday 27 August 2015 23:43 To: Guido Lerch Cc: Subsurface Mailing List , Claudiu Olteanu , Thiago Macieira Subject: Re: at some point we need to release Subsurface 4.5 On Thu, Aug 27, 2015 at 08:31:02PM +, Lerch, Guido wrote: > Hi Dirk, > > I did not follow this closely but how much time do I have to fix the Uemis > implementation. > I make nice progress but since I am doing this besides my job, like propably > all, I would need a few days more. I expect a rather lengthy beta cycle. And I don't think I'll be ready to release even Beta 1 until later next week. There are quite a few more things that I need to get ready... > Currently it does import all my 252 dive¹s I did with it with the correct > profiles and divespots. > I am currently working on buddies, which I believe it never did before. Correct. > Also with the current master the Uemis support would be completely broken. Well, it works for some of us, but I certainly would love to see your patches. Can you send what you already have done? /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Thursday 27 August 2015 09:29:27 Dirk Hohndel wrote: > Hmm - my binary is linked against QtBluetooth but there doesn't even > appear to BE a QtConnectivity in Qt on my Mac... I see you've already fixed it but... QtBluetooth is a Qt module, so you'll have libQt5Bluetooth.so, libQt5Bluetooth.dylib, Qt5Bluetooth.dll, QtBluetooth.framework, as well as do #include qtconnectivity (always written in lowercase) is the name of the Git repository and tarball that contains QtBluetooth. It also contains QtNfc. -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Center PGP/GPG: 0x6EF45358; fingerprint: E067 918B B660 DBD1 105C 966C 33F5 F005 6EF4 5358 ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Thu, Aug 27, 2015 at 08:31:02PM +, Lerch, Guido wrote: > Hi Dirk, > > I did not follow this closely but how much time do I have to fix the Uemis > implementation. > I make nice progress but since I am doing this besides my job, like propably > all, I would need a few days more. I expect a rather lengthy beta cycle. And I don't think I'll be ready to release even Beta 1 until later next week. There are quite a few more things that I need to get ready... > Currently it does import all my 252 dive’s I did with it with the correct > profiles and divespots. > I am currently working on buddies, which I believe it never did before. Correct. > Also with the current master the Uemis support would be completely broken. Well, it works for some of us, but I certainly would love to see your patches. Can you send what you already have done? /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
Sent from the wrong account, please disregard the previous mail. Best regards, Guido Lerch m: +41 79 3217739 "Quality means building the customer¹s point of view into every aspect of a product from design to final recycling." From: Guido Lerch Date: Thursday 27 August 2015 22:31 To: Dirk Hohndel , Claudiu Olteanu Cc: Thiago Macieira , Subsurface Mailing List Subject: Re: at some point we need to release Subsurface 4.5 Hi Dirk, I did not follow this closely but how much time do I have to fix the Uemis implementation. I make nice progress but since I am doing this besides my job, like propably all, I would need a few days more. Currently it does import all my 252 dive¹s I did with it with the correct profiles and divespots. I am currently working on buddies, which I believe it never did before. Also with the current master the Uemis support would be completely broken. Best regards, Guido Lerch m: +41 79 3217739 "Quality means building the customer¹s point of view into every aspect of a product from design to final recycling." From: subsurface on behalf of Dirk Hohndel Date: Thursday 27 August 2015 20:54 To: Claudiu Olteanu Cc: Thiago Macieira , Subsurface Mailing List Subject: Re: at some point we need to release Subsurface 4.5 On Thu, Aug 27, 2015 at 08:46:03PM +0300, Claudiu Olteanu wrote: > Oh :). I thought about it but I don't know why I forgot to ask you. > So it is also my mistake. > Let me know if it works or if you encounter other problems. Nope, BT seems to work. Don't have a BT divecomputer around right now, but once I figured out all my build issues this did work as expected. Sorry for the false alarm. Now we still need to fix the Grantlee issue for printing on the Mac. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Thu, Aug 27, 2015 at 08:46:03PM +0300, Claudiu Olteanu wrote: > Oh :). I thought about it but I don't know why I forgot to ask you. > So it is also my mistake. > > Let me know if it works or if you encounter other problems. Nope, BT seems to work. Don't have a BT divecomputer around right now, but once I figured out all my build issues this did work as expected. Sorry for the false alarm. Now we still need to fix the Grantlee issue for printing on the Mac. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
Yes, I promised something Em qui, 27 de ago de 2015 15:40, Dirk Hohndel escreveu: > On Thu, Aug 27, 2015 at 08:46:03PM +0300, Claudiu Olteanu wrote: > > Oh :). I thought about it but I don't know why I forgot to ask you. > > So it is also my mistake. > > > > Let me know if it works or if you encounter other problems. > > LOADS of other problems trying to get my rebuild to do what I want it to > do. About to blow it all away and rerun the build script... > > But first waiting for a patch Tomaz promised > > /D > ___ > subsurface mailing list > subsurface@subsurface-divelog.org > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface > ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Thu, Aug 27, 2015 at 08:46:03PM +0300, Claudiu Olteanu wrote: > Oh :). I thought about it but I don't know why I forgot to ask you. > So it is also my mistake. > > Let me know if it works or if you encounter other problems. LOADS of other problems trying to get my rebuild to do what I want it to do. About to blow it all away and rerun the build script... But first waiting for a patch Tomaz promised /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
Oh :). I thought about it but I don't know why I forgot to ask you. So it is also my mistake. Let me know if it works or if you encounter other problems. Claudiu ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Thu, Aug 27, 2015 at 09:29:27AM -0700, Dirk Hohndel wrote: > On Thu, Aug 27, 2015 at 07:12:12PM +0300, Claudiu Olteanu wrote: > > > OK, deleting the plist file, shutting the system down and restarting > > > worked. BT is alive and well again. Here's what Subsurface reports: > > > > > > "The local Bluetooth adapter cannot be accessed." > > > > > > So this indicated that in > > > BtDeviceSelectionDialog::updateLocalDeviceInformation() > > > localDevice->isValid() returns false... > > > > > > So QtBT isn't finding any devices. Any suggestions how to debug that? > > > > Unfortunately I don't have any idea how Bluetooth works on OSx. > > I encountered the same problem on Linux when the libqt5-qtconnectivity > > library > > was missing or when the BlueZ driver wasn't installed correctly. > > Hmm - my binary is linked against QtBluetooth but there doesn't even > appear to BE a QtConnectivity in Qt on my Mac... The STUPID. IT HURTS. Specifically, MY STUPID. After some googling and searching and head scratching I finally realized... I still had Qt 5.4 installed on the Mac. QtBT support for Mac is new in Qt 5.5. :facepalm: /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Thu, Aug 27, 2015 at 07:12:12PM +0300, Claudiu Olteanu wrote: > > OK, deleting the plist file, shutting the system down and restarting > > worked. BT is alive and well again. Here's what Subsurface reports: > > > > "The local Bluetooth adapter cannot be accessed." > > > > So this indicated that in > > BtDeviceSelectionDialog::updateLocalDeviceInformation() > > localDevice->isValid() returns false... > > > > So QtBT isn't finding any devices. Any suggestions how to debug that? > > Unfortunately I don't have any idea how Bluetooth works on OSx. > I encountered the same problem on Linux when the libqt5-qtconnectivity > library > was missing or when the BlueZ driver wasn't installed correctly. Hmm - my binary is linked against QtBluetooth but there doesn't even appear to BE a QtConnectivity in Qt on my Mac... In the meantime I fixed a crash on exit if there is no working adapter found. Tiny details :-) > The Qt framework couldn't communicate with the driver via D-Bus and > localDevice->isValid() was always returning FALSE. That would make sense. I need to do some googling to figure out how this is supposed to work and if I maybe need to install something else... > Maybe Thiago has any suggestions or we could start talking > with Alex, the maintainer of QtBluetooth module. Yes, please. Thiago? /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
> OK, deleting the plist file, shutting the system down and restarting > worked. BT is alive and well again. Here's what Subsurface reports: > > "The local Bluetooth adapter cannot be accessed." > > So this indicated that in > BtDeviceSelectionDialog::updateLocalDeviceInformation() > localDevice->isValid() returns false... > > So QtBT isn't finding any devices. Any suggestions how to debug that? > > /D > Unfortunately I don't have any idea how Bluetooth works on OSx. I encountered the same problem on Linux when the libqt5-qtconnectivity library was missing or when the BlueZ driver wasn't installed correctly. The Qt framework couldn't communicate with the driver via D-Bus and localDevice->isValid() was always returning FALSE. Maybe Thiago has any suggestions or we could start talking with Alex, the maintainer of QtBluetooth module. Claudiu ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Thu, Aug 27, 2015 at 07:57:34AM -0700, Dirk Hohndel wrote: > > > On Aug 26, 2015, at 11:20 PM, Claudiu Olteanu > > wrote: > > > > > > >> Bluetooth support > > >> = > > >> > > >> BT support is looking fairly good on Linux and making progress on > > >> Windows, > > >> I think, but I'm sure there are tons of small issues lurking here and > > >> there. Has anyone gotten it to work on Mac, yet? > > > > > Also ready for Beta 1, except for OS X where it also doesn't appear to > > > work at all :-( > > > > Can you be more specific? Is your local Bluetooth adapter recognized? Did > > you receive some specific errors? > > Bluetooth on my Mac is suddenly "unavailable". Need to figure out what's up > with that (it's only > a few months old). OK, deleting the plist file, shutting the system down and restarting worked. BT is alive and well again. Here's what Subsurface reports: "The local Bluetooth adapter cannot be accessed." So this indicated that in BtDeviceSelectionDialog::updateLocalDeviceInformation() localDevice->isValid() returns false... So QtBT isn't finding any devices. Any suggestions how to debug that? /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
> On Aug 26, 2015, at 11:20 PM, Claudiu Olteanu > wrote: > > > >> Bluetooth support > >> = > >> > >> BT support is looking fairly good on Linux and making progress on Windows, > >> I think, but I'm sure there are tons of small issues lurking here and > >> there. Has anyone gotten it to work on Mac, yet? > > > Also ready for Beta 1, except for OS X where it also doesn't appear to > > work at all :-( > > Can you be more specific? Is your local Bluetooth adapter recognized? Did you > receive some specific errors? Bluetooth on my Mac is suddenly "unavailable". Need to figure out what's up with that (it's only a few months old). Robert / Tomaz / anyone else with a Mac, can any of you verify on your Macs if BT still fails to work? Even if you don't have a BT divecomputer, just open download, select BT and then click on the three dots to see if it sees your BT adapter and if it can see any BT devices (you could turn on BT in your phone to have something that should show up in a scan...) Thanks /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
>> Bluetooth support >> = >> >> BT support is looking fairly good on Linux and making progress on Windows, >> I think, but I'm sure there are tons of small issues lurking here and >> there. Has anyone gotten it to work on Mac, yet? > Also ready for Beta 1, except for OS X where it also doesn't appear to > work at all :-( Can you be more specific? Is your local Bluetooth adapter recognized? Did you receive some specific errors? ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Wed, Aug 26, 2015 at 1:20 PM, Dirk Hohndel wrote: > > Merge has been implemented by the master of creating crappy code and > subtle bugs that will delete all your data. Which means we are ready for > Beta 1. It seems to work. I've tried to break it, but with the new deterministic uuid thing, my obvious test-case that I had talked to you about last week Just Worked(tm). And my "no conflict" tests also just did the right thing with no problems. I also tried to test the actual conflict resolution, and it also worked. Now, admittedly it worked in a way that is possibly broken, but it *worked*. Here's what I did: Side 1 does: -notes "Add some notes for the last dive" +notes "Add some more notes for the last dive" Side 2 does: -notes "Add some notes for the last dive" +notes "Add some notes for the last dive to conflict" and the merge was "successful" as +notes "Add some more notes for the last dive" + notes "Add some notes for the last dive to conflict" which just took both sides. Then when we read that thing, it just took the second entry, so we ended up with a successful merge, but it basically threw away one of the changes. That's probably about as well as we can do automatically, though, so I'd not consider it a failure. But it's an effect of that "GIT_MERGE_FILE_FAVOR_UNION", which I actually think is the right thing, but is very aggressive about not actually failing the merge at all. Anyway, the merging worked fine, although arguably our git file reading might be better off *appending* things like notes when there is duplication due to merging. But "take one or the other" is the only sane model for most of the data we have (ie imagine dive site data etc), so I don't think this is *wrong*. I think I should try some multi-line note merge cases, but on the whole I think the notion that "with the git file format, merging off-line editing Just Works(tm)" actually turned out to be true. In general, I would hope that the common case should be that we never actually really get conflicts with the whole cloud storage model, but clearly the code doesn't explode violently at least for the trivial cases. Linus ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
Quick update on where we are with respect to starting the 4.5 release cycle... On Mon, Aug 17, 2015 at 06:16:32AM -0700, Dirk Hohndel wrote: > > Location management > === I think we are really close. It's not perfect, it has bugs, needs a ton of testing and some things fixed before a final release... but this is almost ready for Beta 1. If there are any show stoppers here, please file bugs / let us know. > Cloud storage > = Merge has been implemented by the master of creating crappy code and subtle bugs that will delete all your data. Which means we are ready for Beta 1. I would mention that this needs more testing but I've said that so many times I'll just give up. A few people clearly are playing with it, but the number is way too small. 21 people have tried this at all, 9 have used it in the past four days. > Undo/redo > = > > Undo/redo is there for a hand full of operations. That's nice but are we > OK with this? And can the mixing of things that get added to the undo > stack and operations that don't get added to the undo stack cause > disaster? > > I think this mainly needs testing. Lots of testing. This is a chance for > all of you people on this mailing list who aren't developers but who want > to help! What would be great is simply a collection of emails "this has > been tested and works / here is how I can make this break". Any volunteers > who would like to take ownership here? You don't have to fix the bugs, > just document what works and where things might fail. Nothing has happened on this. I don't know if this has been well tested and is perfect, or if no one ever uses it and it's a complete disaster. I guess we can just have our users find out. > Printing > This is ready for Beta 1 WITH THE EXCEPTION OF OS X where I believe this is still completely broken. > VPM-B > = > > VPM-B - at least for the planner I understand that we are getting closer. > Ignoring the fact that so far we aren't matching known profiles :-/ > > Robert / Jan - do you have a TODO list for what is needed? I'm not quite sure. I think it's close. It needs a bigger disclaimer that says "WE REALLY MEAN IT, DON'T DIVE WITH THESE TABLES" > Bluetooth support > = > > BT support is looking fairly good on Linux and making progress on Windows, > I think, but I'm sure there are tons of small issues lurking here and > there. Has anyone gotten it to work on Mac, yet? Also ready for Beta 1, except for OS X where it also doesn't appear to work at all :-( > Android app > === > > The Android app is also making great progress - but can be released > independently of 4.5 (admittedly, I'd love to release them together - but > it obviously cannot be released until 4.5 is out as it uses cloud storage > to connect to the dive data of a user). > > What's the feature set we'd want for that first release? Do we need > download on the device? Or is what Grace has right now already reasonaby > sufficient? It definitely needs lots of testing and tuning of the UI. This needs a lot more work, but in a way it doesn't have to be released with 4.5 unless we happen to get it ready in time. > User manual > === > > That needs massive work for all the amazing features that we have added. > Willem, will you be able to do that? > Once we have agreed on a feature set for the Android app, that needs a > separate user manual as well. Volunteers? Several people have volunteered but I haven't seen patches. But in a way this isn't strictly required for Beta 1. We can update this throughout the release cycle. So my inclination is to start the beta test soon. I have no idea how to fix the issue that two major new features don't work on the Mac. If it wasn't for that I'd be pushing for a Beta 1 within days. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
RE: at some point we need to release Subsurface 4.5
Hi, Grace and Steve El 19/08/2015 02:51, "Steve" escribió: > > If you touch the very top right hand side a (hidden for some devices) menu will appear. > > There was a thread on the mailing list with pictures where I bought this up and did some testing. > Aha, there it was, hidden on my phone and my tablet. After displaying the menu, everything went smooth. Just will report some "issues" although I think they are probably already known: - In smaller display (phone) the lower part isn't reachable as there is no scroll posibiliy. - The same issue with the boxes, which get out of the screen. - After rotate the screen, the profile disappears and it only recovers if we open another dive and then get back to the first one. - As loading for first time the full git divelog is painly slow, the user will surely think that the app has freezed. It can be useful to set some kind of counter or animation. Nevertheless, I like the app and the UI. If we could only see the menu button ... ;-) Regards. Salva. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Tue, Aug 18, 2015 at 10:38 PM, Salvador Cuñat wrote: > > >> Sadly, the app doesn't work for me at all (latest dailies, first did). > I only get the blue screen with the "Subsurface mobile" bar and the status > bar with "subsurface mobile startup". Don't know if it's due to a > communication failure with the git repo (as I experienced the same problem > with cloud storage reported in #905 by David, although solved op PC with a > pull), or if the app simply freezes. May be the app could store a debug > log somewhere in the device, at least now, for the test builds, so the > reports don't be so silly like this one is. > > Hi Salvador, What happens when you click on the menu and then 'Load Dives'? Meanwhile I will work on a way to be able to submit logs. -- Grace K ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
RE: at some point we need to release Subsurface 4.5
From: subsurface [mailto:subsurface-boun...@subsurface-divelog.org] On Behalf Of Salvador Cuñat Sent: Wednesday, 19 August 2015 5:09 AM To: Dirk Hohndel Cc: Subsurface Mailing List Subject: Re: at some point we need to release Subsurface 4.5 Good evening 2015-08-17 15:16 GMT+02:00 Dirk Hohndel mailto:d...@hohndel.org> >: Android app === The Android app is also making great progress - but can be released independently of 4.5 (admittedly, I'd love to release them together - but it obviously cannot be released until 4.5 is out as it uses cloud storage to connect to the dive data of a user). What's the feature set we'd want for that first release? Do we need download on the device? Or is what Grace has right now already reasonaby sufficient? It definitely needs lots of testing and tuning of the UI. Sadly, the app doesn't work for me at all (latest dailies, first did). I only get the blue screen with the "Subsurface mobile" bar and the status bar with "subsurface mobile startup". Don't know if it's due to a communication failure with the git repo (as I experienced the same problem with cloud storage reported in #905 by David, although solved op PC with a pull), or if the app simply freezes. May be the app could store a debug log somewhere in the device, at least now, for the test builds, so the reports don't be so silly like this one is. That’s also what thought when I tested the first version with the menu. If you touch the very top right hand side a (hidden for some devices) menu will appear. There was a thread on the mailing list with pictures where I bought this up and did some testing. User manual === That needs massive work for all the amazing features that we have added. Willem, will you be able to do that? Once we have agreed on a feature set for the Android app, that needs a separate user manual as well. Volunteers? I can help in the manual area as much as needed, at least in the parts where I could play (e.g. I don't have a bluetooth device, so little work can do with this). Steve ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
Good evening 2015-08-17 15:16 GMT+02:00 Dirk Hohndel : > > > Android app > === > > The Android app is also making great progress - but can be released > independently of 4.5 (admittedly, I'd love to release them together - but > it obviously cannot be released until 4.5 is out as it uses cloud storage > to connect to the dive data of a user). > > What's the feature set we'd want for that first release? Do we need > download on the device? Or is what Grace has right now already reasonaby > sufficient? It definitely needs lots of testing and tuning of the UI. > > Sadly, the app doesn't work for me at all (latest dailies, first did). I only get the blue screen with the "Subsurface mobile" bar and the status bar with "subsurface mobile startup". Don't know if it's due to a communication failure with the git repo (as I experienced the same problem with cloud storage reported in #905 by David, although solved op PC with a pull), or if the app simply freezes. May be the app could store a debug log somewhere in the device, at least now, for the test builds, so the reports don't be so silly like this one is. > User manual > === > > That needs massive work for all the amazing features that we have added. > Willem, will you be able to do that? > Once we have agreed on a feature set for the Android app, that needs a > separate user manual as well. Volunteers? > > I can help in the manual area as much as needed, at least in the parts where I could play (e.g. I don't have a bluetooth device, so little work can do with this). ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On 17 August 2015 at 20:37, Tomaz Canabrava wrote: > Regarding to grantlee - I started reading it's source code but didn't > managed to advance much - will keep trying. > also, I'm in contact with grantlee developer to make things easier. > i was able to go trough the Grantlee source - following it from the loading stage to where the parser is initiated for a template, but couldn't find any multi-thread or async usage...weird, could have missed it. also, logically i don't understand why a new thread is used without giving control to the user over that in the lines of loadByNameAsync() and allowing him/her to connect to a onLoaded() slot. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Mon, Aug 17, 2015 at 3:16 PM, Dirk Hohndel wrote: > > Location management > === > > The location management work turned into an utter disaster of many > attempts that no one liked but I think we are getting closer there. What's > missing before this is ready for actual users? > > Davide, are you back? Henrik, any chance you can help provide a todo list > of what's needed before we can use this in a release? What I'm looking for > is a TODO list... Hi Dirk, I'm very busy ATM going back and forth from workplace and vacation. I will be free again from 6th of September. Sorry ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
Regarding to grantlee - I started reading it's source code but didn't managed to advance much - will keep trying. also, I'm in contact with grantlee developer to make things easier. tomaz ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
> > Bluetooth support > = > > BT support is looking fairly good on Linux and making progress on Windows, > I think, but I'm sure there are tons of small issues lurking here and > there. Has anyone gotten it to work on Mac, yet? > > Claudiu / Thiago - do you have a TODO list? > The patches sent should add support for Windows and fix the issues reported so far (at least the ones that could be reproduced:) ). Until now we managed (Rick, Steve and me) to test the implementation on Windows XP SP2, Windows Vista, Windows 7, Windows 8.1 and Windows 10. There were no issues reported which are related to the data transfer. Unfortunately I didn't receive any feedback for MAC platforms and I don't have any environment in which I could run some tests. I am really curious how it works. Regarding the TODO list this is what I have in mind: - improve the UI for Linux & Mac platforms (remove the context menu with the pairing functionalities and add a separated button for that) - add support for other dive computer families which have Bluetooth functionality (like Aeris) - implement a new feature which will add the possibility to do firmware upgrade directly from Subsurface app > User manual > === > > That needs massive work for all the amazing features that we have added. > Willem, will you be able to do that? > Once we have agreed on a feature set for the Android app, that needs a > separate user manual as well. Volunteers? I am planning to update the Bluetooth section with the usage of our custom Bluetooth implementation and with some troubleshooting tips. Cheers, Claudiu ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On 17 August 2015 at 17:33, Gehad Elrobey wrote: > > > On Mon, Aug 17, 2015 at 4:20 PM, Lubomir I. Ivanov > wrote: >> >> On 17 August 2015 at 17:06, Gehad Elrobey wrote: >> > >> > >> > On Mon, Aug 17, 2015 at 3:49 PM, Lubomir I. Ivanov >> > wrote: >> > >> >> >> >> ATM, the plan for the "statistics print" is for it to have a >> >> single-template design (no delete, import/export, only edit) due to >> >> complications that he can explain better than me, but i can see it >> >> being part of Subsurface 4.5. >> >> >> > >> > To support many templates we will need to export yearly statistics data >> > structures to the Grantlee backend, I can work on this if we found out >> > that >> > this will be a 'nice to have' feature. >> > >> >> "nice to have" usually means that we are only going to work on the >> feature if there is enough time. >> GSoC scope wise, you can just add support for single template feature >> (edit only, no delete/import/export) as the feature is a bonus one and >> we need time to write the docs. >> >> depending on the Subsurface 4.5 release window the full >> delete/import/export for the stats print can added as well. >> but only if you have enough time to work on that after GSoC. >> >> how much time would you need BTW? >> > > I am planning to finish the remaining tasks by 21th of August. > ok, if you can manage the full "stats print" support and the documentation by the end of GSoC (21th), that would be great. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Mon, Aug 17, 2015 at 4:20 PM, Lubomir I. Ivanov wrote: > On 17 August 2015 at 17:06, Gehad Elrobey wrote: > > > > > > On Mon, Aug 17, 2015 at 3:49 PM, Lubomir I. Ivanov > > wrote: > > > >> > >> ATM, the plan for the "statistics print" is for it to have a > >> single-template design (no delete, import/export, only edit) due to > >> complications that he can explain better than me, but i can see it > >> being part of Subsurface 4.5. > >> > > > > To support many templates we will need to export yearly statistics data > > structures to the Grantlee backend, I can work on this if we found out > that > > this will be a 'nice to have' feature. > > > > "nice to have" usually means that we are only going to work on the > feature if there is enough time. > GSoC scope wise, you can just add support for single template feature > (edit only, no delete/import/export) as the feature is a bonus one and > we need time to write the docs. > > depending on the Subsurface 4.5 release window the full > delete/import/export for the stats print can added as well. > but only if you have enough time to work on that after GSoC. > > how much time would you need BTW? > > I am planning to finish the remaining tasks by 21th of August. -- regards, Gehad ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
> On Aug 17, 2015, at 7:12 AM, Willem Ferguson > wrote: > > On 17/08/2015 15:16, Dirk Hohndel wrote: >> I've been saying this for a while now. But I'd like to actually try and >> make this happen sooner rather than later... >> >> So here's what I can remember of the top of my head... >> >> Location management >> === >> >> The location management work turned into an utter disaster of many >> attempts that no one liked but I think we are getting closer there. What's >> missing before this is ready for actual users? >> >> Davide, are you back? Henrik, any chance you can help provide a todo list >> of what's needed before we can use this in a release? What I'm looking for >> is a TODO list... > > TODO: > > I currently manage my dive sites by hand-editing the XML. At present, if I > enter Times Square as a dive site and tell Subsurface to create a new site, > it happily does so without also creating the coordinates. So, two things: > 1) Allow coordinate selection from marble, as previously. > 2) Allow text entry of coordinates as previously. Both works when you go to View->Dive site edit (that's still capitalized wrong) > Currently, when I enter Times Square, it says "create a dive site" with a + > to the right. If the + is chosen, then a panel should open as suggested in > the attached image. If "Enter coordinates from world map" is chosen, then the > orange bar at the top of the globe is activated, allowing a click on the > globe to be saved. If text is used, there is a suitable text box. For me, it > would mean a lot if there is a clear indication whether the text coordinates > have (not) been accepted. Clicking the Apply or the Cancel button (or a click > on the globe) closes the panel. I assume that import from the Companion Ap > would follow the usual dialogue, not involved here. The above would be mostly > the existing code base with minimal new programming. I don't think that's what we want. What's odd is that right now you have to go to the Menu to edit a dive site instead of being able to trigger this from the Notes tab. But we really want to use that UI. Also, in the dive site edit UI you can't change which dive site you are editing... I know that Davide had put together a wonderful UI mockup for all of this... I really hope that he and Tomaz can finish this part - or get it to a sane state, soon. >> User manual >> === >> >> That needs massive work for all the amazing features that we have added. >> Willem, will you be able to do that? > Absolutely. I will be in the US from Sept 11-Oct 9th but I am available most > of that time. Cool. I don't have a time line, yet, because I'm still trying to wrap my mind around all the things that still have to be done. >> WHAT ELSE? >> == >> >> I'm sure there are other areas that I'm forgetting... > > A smaller addition is the work that Miika has put into reading text APD CCR > dive log dumps into Subsurface. Yes, there are a TON of new features that Miika has added regarding data input. We need to make sure they are all documented and tested. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On 17 August 2015 at 17:06, Gehad Elrobey wrote: > > > On Mon, Aug 17, 2015 at 3:49 PM, Lubomir I. Ivanov > wrote: > >> >> ATM, the plan for the "statistics print" is for it to have a >> single-template design (no delete, import/export, only edit) due to >> complications that he can explain better than me, but i can see it >> being part of Subsurface 4.5. >> > > To support many templates we will need to export yearly statistics data > structures to the Grantlee backend, I can work on this if we found out that > this will be a 'nice to have' feature. > "nice to have" usually means that we are only going to work on the feature if there is enough time. GSoC scope wise, you can just add support for single template feature (edit only, no delete/import/export) as the feature is a bonus one and we need time to write the docs. depending on the Subsurface 4.5 release window the full delete/import/export for the stats print can added as well. but only if you have enough time to work on that after GSoC. how much time would you need BTW? lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On 17/08/2015 15:16, Dirk Hohndel wrote: I've been saying this for a while now. But I'd like to actually try and make this happen sooner rather than later... So here's what I can remember of the top of my head... Location management === The location management work turned into an utter disaster of many attempts that no one liked but I think we are getting closer there. What's missing before this is ready for actual users? Davide, are you back? Henrik, any chance you can help provide a todo list of what's needed before we can use this in a release? What I'm looking for is a TODO list... TODO: I currently manage my dive sites by hand-editing the XML. At present, if I enter Times Square as a dive site and tell Subsurface to create a new site, it happily does so without also creating the coordinates. So, two things: 1) Allow coordinate selection from marble, as previously. 2) Allow text entry of coordinates as previously. Currently, when I enter Times Square, it says "create a dive site" with a + to the right. If the + is chosen, then a panel should open as suggested in the *attached image*. If "Enter coordinates from world map" is chosen, then the orange bar at the top of the globe is activated, allowing a click on the globe to be saved. If text is used, there is a suitable text box. For me, it would mean a lot if there is a clear indication whether the text coordinates have (not) been accepted. Clicking the Apply or the Cancel button (or a click on the globe) closes the panel. I assume that import from the Companion Ap would follow the usual dialogue, not involved here. The above would be mostly the existing code base with minimal new programming. User manual === That needs massive work for all the amazing features that we have added. Willem, will you be able to do that? Absolutely. I will be in the US from Sept 11-Oct 9th but I am available most of that time. Once we have agreed on a feature set for the Android app, that needs a separate user manual as well. Volunteers? WHAT ELSE? == I'm sure there are other areas that I'm forgetting... /D A smaller addition is the work that Miika has put into reading text APD CCR dive log dumps into Subsurface. Kind regards, willem ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On Mon, Aug 17, 2015 at 3:49 PM, Lubomir I. Ivanov wrote: > On 17 August 2015 at 16:16, Dirk Hohndel wrote: > > I've been saying this for a while now. But I'd like to actually try and > > make this happen sooner rather than later... > > > > So here's what I can remember of the top of my head... > > > > > > Printing > > > > > > Printing seems to be fairly close - there are a few known bugs that Gehad > > is working on but I'm quite happy there. Except that I believe we haven't > > gotten it to work on the Mac, yet, correct? > > > > Gehad / Lubomir, I assume you have a TODO list of what's still missing? > > Tomaz, have you been able to look at the Mac issue? > > > > we are mostly done. Gehad could share his TODO list if he has certain > things in there that i'm not aware of and that need to be attended to. > other than the "statistics print" which is technically outside of the > GSoC scope and the docs - all tasks are complete. > > Other than "statistics print" that Lubomir mentioned, I still have one issue to fix on my todo list. > ATM, the plan for the "statistics print" is for it to have a > single-template design (no delete, import/export, only edit) due to > complications that he can explain better than me, but i can see it > being part of Subsurface 4.5. > > To support many templates we will need to export yearly statistics data structures to the Grantlee backend, I can work on this if we found out that this will be a 'nice to have' feature. > the OSX issue is concerning and both me and Gehad can't debug it. > Robert reported Qt 5.4 which is a fairly recent version, but perhaps a > newer one should be testest (e.g. Qt 5.5). the Grantlee version is the > same across platforms. > > we haven't heard from the Grantlee community or Tomaz in that thread i > posted at kde-pim. in the meantime i have no idea why threads are > problematic when reading a template, *only* on OSX. i can try staring > at the Grantlee source code, but without running it on the problem > platform it might be quite difficult to find the exact cause. > > > User manual > > === > > > > That needs massive work for all the amazing features that we have added. > > Willem, will you be able to do that? > > Once we have agreed on a feature set for the Android app, that needs a > > separate user manual as well. Volunteers? > > > > as i understand it, writing the documentation for a GSoC task would > include updating the user manual, so Gehad should write the new > "Printing" section. > > lubomir > -- > ___ > subsurface mailing list > subsurface@subsurface-divelog.org > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface > -- regards, Gehad ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On 17-08-2015 14:16, Dirk Hohndel wrote: I've been saying this for a while now. But I'd like to actually try and make this happen sooner rather than later... So here's what I can remember of the top of my head... User manual === That needs massive work for all the amazing features that we have added. Willem, will you be able to do that? Once we have agreed on a feature set for the Android app, that needs a separate user manual as well. Volunteers? Hi: I'll be happy/able to help Willem with the user manual... Cheers: Pedro ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: at some point we need to release Subsurface 4.5
On 17 August 2015 at 16:16, Dirk Hohndel wrote: > I've been saying this for a while now. But I'd like to actually try and > make this happen sooner rather than later... > > So here's what I can remember of the top of my head... > > > Printing > > > Printing seems to be fairly close - there are a few known bugs that Gehad > is working on but I'm quite happy there. Except that I believe we haven't > gotten it to work on the Mac, yet, correct? > > Gehad / Lubomir, I assume you have a TODO list of what's still missing? > Tomaz, have you been able to look at the Mac issue? > we are mostly done. Gehad could share his TODO list if he has certain things in there that i'm not aware of and that need to be attended to. other than the "statistics print" which is technically outside of the GSoC scope and the docs - all tasks are complete. ATM, the plan for the "statistics print" is for it to have a single-template design (no delete, import/export, only edit) due to complications that he can explain better than me, but i can see it being part of Subsurface 4.5. the OSX issue is concerning and both me and Gehad can't debug it. Robert reported Qt 5.4 which is a fairly recent version, but perhaps a newer one should be testest (e.g. Qt 5.5). the Grantlee version is the same across platforms. we haven't heard from the Grantlee community or Tomaz in that thread i posted at kde-pim. in the meantime i have no idea why threads are problematic when reading a template, *only* on OSX. i can try staring at the Grantlee source code, but without running it on the problem platform it might be quite difficult to find the exact cause. > User manual > === > > That needs massive work for all the amazing features that we have added. > Willem, will you be able to do that? > Once we have agreed on a feature set for the Android app, that needs a > separate user manual as well. Volunteers? > as i understand it, writing the documentation for a GSoC task would include updating the user manual, so Gehad should write the new "Printing" section. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
