Re: "other" tag

[Salvador Cuñat]

El 07/09/2015 07:43, "Robert C. Helling"  escribió:
>
> From the code, it seems to me that these can be combined: A drift dive in
a river with a  camera where I take photos of a wreck. And the dive is also
other.
>
> In any case, I would rather have no tag for a dive than having one that
only says „other“. But that might be my personal opinion. This is the
difference between a combo box where I have to choose something and a tag
system.

Yes, we can, simply drop the bit.
Included it as it was an option in Uwatec's software, but it's far from
unavoidable.
Will send a patch this evening.

Regards.
Salva.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: "other" tag

[Dirk Hohndel]

On Mon, Sep 07, 2015 at 09:30:22PM +0200, Salvador Cuñat wrote:
> Hi again, Robert,
> 
> 2015-09-07 12:28 GMT+02:00 Salvador Cuñat :
> 
> >
> > El 07/09/2015 07:43, "Robert C. Helling"  escribió:
> > >
> > > From the code, it seems to me that these can be combined: A drift dive
> > in a river with a  camera where I take photos of a wreck. And the dive is
> > also other.
> > >
> > > In any case, I would rather have no tag for a dive than having one that
> > only says „other“. But that might be my personal opinion. This is the
> > difference between a combo box where I have to choose something and a tag
> > system.
> >
> > Yes, we can, simply drop the bit.
> > Included it as it was an option in Uwatec's software, but it's far from
> > unavoidable.
> > Will send a patch this evening.
> >
> > Regards.
> > Salva.
> >
> I've been thinking about this while driving home from work, and I'm not so
> sure as I was this morning.
> Although I agree in the nonsense of this tag, and I never used it in the 10
> years I've been using datatrak, please note that importing is a kind of
> forensic task; in the sense that the tag was set some time ago by a user
> who knows (or better, knew) its meaning.  Leaving the code "as is" now,
> will only affect those users who set the "other" tag in the past, while
> using Datatrak.  It'll go unnoticed for users who didn't make use of it and
> (like me), even  those who used it in the past will probably never use it
> again, as Subsurface's custom tag system is much more powerful than
> Uwatec's limited combo list.

I think it's the right thing to import thing as closely to the source as
possible. If the Datatrak software has since senseless tag then we can
giggle, but if people use it we still should import it. They can always
replace it with something more meaningful once they have imported the
data.

/D
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: "other" tag

[Salvador Cuñat]

Hi again, Robert,

2015-09-07 12:28 GMT+02:00 Salvador Cuñat :

>
> El 07/09/2015 07:43, "Robert C. Helling"  escribió:
> >
> > From the code, it seems to me that these can be combined: A drift dive
> in a river with a  camera where I take photos of a wreck. And the dive is
> also other.
> >
> > In any case, I would rather have no tag for a dive than having one that
> only says „other“. But that might be my personal opinion. This is the
> difference between a combo box where I have to choose something and a tag
> system.
>
> Yes, we can, simply drop the bit.
> Included it as it was an option in Uwatec's software, but it's far from
> unavoidable.
> Will send a patch this evening.
>
> Regards.
> Salva.
>
I've been thinking about this while driving home from work, and I'm not so
sure as I was this morning.
Although I agree in the nonsense of this tag, and I never used it in the 10
years I've been using datatrak, please note that importing is a kind of
forensic task; in the sense that the tag was set some time ago by a user
who knows (or better, knew) its meaning.  Leaving the code "as is" now,
will only affect those users who set the "other" tag in the past, while
using Datatrak.  It'll go unnoticed for users who didn't make use of it and
(like me), even  those who used it in the past will probably never use it
again, as Subsurface's custom tag system is much more powerful than
Uwatec's limited combo list.

Not sure I had explained very well.

Regards.
Salva.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: "other" tag

[Robert C. Helling]

Salvador,

> On 07 Sep 2015, at 07:10, Salvador Cuñat  > wrote:
> 
> This is the meaning of the bit in datatrak software.  It stands for any 
> activity not included in previous definitions.
> It isn't of great use, off course, but if the imported log book has it set, 
> we have to import it " as is ".
> 
> 
From the code, it seems to me that these can be combined: A drift dive in a 
river with a  camera where I take photos of a wreck. And the dive is also other.

In any case, I would rather have no tag for a dive than having one that only 
says „other“. But that might be my personal opinion. This is the difference 
between a combo box where I have to choose something and a tag system.

Best
Robert


signature.asc
Description: Message signed with OpenPGP using GPGMail
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface

Re: "other" tag

[Salvador Cuñat]

Hi Robert.

El 07/09/2015 00:23, "Robert C. Helling"  escribió:
>
> if (byte[4] != 0)
> taglist_add_tag(_dive->tag_list,
strdup(QT_TRANSLATE_NOOP("gettextFromC", "other")));
>
>
>
>
> Does this mean, if byte[4] is non-zero, the dive gets a tag that reads
„other“. Is this really what we want? I wouldn’t want to have a dive that
has such a tag. What do you think?
>

This is the meaning of the bit in datatrak software.  It stands for any
activity not included in previous definitions.
It isn't of great use, off course, but if the imported log book has it set,
we have to import it " as is ".

Regards.
Salva.
___
subsurface mailing list
subsurface@subsurface-divelog.org
http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface