Re: [PATCH 4/7] Fix divecomputer part of UDDF export
On 13 December 2014 at 23:33, Long, Martin mar...@longhome.co.uk wrote: I'll have to test this tomorrow hopefully. i've not been able to do anything on this tonight, so hopefully I'll get a chance tomorrow. Am I missing something? I don't see a Subsurface-testing branch in libdivecomputer. I'm using git://git.libdivecomputer.org/libdivecomputer ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 4/7] Fix divecomputer part of UDDF export
On December 14, 2014 1:41:48 PM Long, Martin mar...@longhome.co.uk wrote: On 13 December 2014 at 23:33, Long, Martin mar...@longhome.co.uk wrote: I'll have to test this tomorrow hopefully. i've not been able to do anything on this tonight, so hopefully I'll get a chance tomorrow. Am I missing something? I don't see a Subsurface-testing branch in libdivecomputer. I'm using git://git.libdivecomputer.org/libdivecomputer For complicated reasons it's now git://git.libdivecomputer.org/libdc Sorry, I sent email about this maybe a week or two ago... /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 4/7] Fix divecomputer part of UDDF export
On 13 December 2014 at 16:40, Dirk Hohndel d...@hohndel.org wrote: Well, there are divecomputer sections in each dive, but the nickname, serial, firmware, etc, should be stored in the settings at the beginning. And that has been true at least since Subsurface 3. Also, if the nickname is removed, then it disappears from the file again. So it is only present as long as there is a nickname. As the program is fully functional without setting a nickname, I suspect a lot of people, like me, will not have set one. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 4/7] Fix divecomputer part of UDDF export
On Sat, Dec 13, 2014 at 04:44:19PM +, Long, Martin wrote: On 13 December 2014 at 16:40, Dirk Hohndel d...@hohndel.org wrote: Well, there are divecomputer sections in each dive, but the nickname, serial, firmware, etc, should be stored in the settings at the beginning. And that has been true at least since Subsurface 3. Also, if the nickname is removed, then it disappears from the file again. So it is only present as long as there is a nickname. As the program is fully functional without setting a nickname, I suspect a lot of people, like me, will not have set one. Interesting. I didn't think that was the case. Will have to look at the logic again. Which dive computer do you have? Does it save serial or firmware or anything like that? /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 4/7] Fix divecomputer part of UDDF export
So, the info in every profile (for my Suunto) is: divecomputer model='Suunto Vyper Air' deviceid='cef51609' diveid='8ab03c43' And the details in the settings section, when I add a nickname: divecomputerid model='Suunto Vyper Air' deviceid='cef51609' nickname='nick'/ So, it looks like there are no version details, or fimware. I suppose if there is more data then it might create this section anyway. Also, if the section isn't there, then log - edit device list must read the devices from the profiles, as it shows my Suunto in there, along with the device ID. M ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 4/7] Fix divecomputer part of UDDF export
On Sat, Dec 13, 2014 at 05:29:06PM +, Long, Martin wrote: So, the info in every profile (for my Suunto) is: divecomputer model='Suunto Vyper Air' deviceid='cef51609' diveid='8ab03c43' And the details in the settings section, when I add a nickname: divecomputerid model='Suunto Vyper Air' deviceid='cef51609' nickname='nick'/ So, it looks like there are no version details, or fimware. I suppose if there is more data then it might create this section anyway. Hmm, if you use one of my precompiled daily binaries, or build the Subsurface-testing branch of libdivecomputer, and if you then download dives from the divecomputer (just loading from XML and saving back is not enough), do you then get your divecomputer in the settings? Also, if the section isn't there, then log - edit device list must read the devices from the profiles, as it shows my Suunto in there, along with the device ID. Correct, that's what it does. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 4/7] Fix divecomputer part of UDDF export
I'll have to test this tomorrow hopefully. i've not been able to do anything on this tonight, so hopefully I'll get a chance tomorrow. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: [PATCH 4/7] Fix divecomputer part of UDDF export
On Sat, Dec 13, 2014 at 2:34 AM, Martin Long mar...@longhome.co.uk wrote: XPath was incorrect for parsing divecomputers into the equipment section, meaning they dont get inserted. Can you elaborate on this one as on my divelog all the dive computers are listed on the settings section and the original code worked with that properly. The sample dives are incorrect in this regard, but when you open them in Subsurface and save to new file, they get the stored in the settings section (and this is the state that is used when exporting from Subsurface). Dirk, shouldn't all the DCs be always listed in the settings section so that we don't need to parse the whole file to get a list of them? Of course, your way of grabbing the divecomputers from all the dives works as well, but it is faster to just grab them from the settings section (unless I am really missing something and not all DCs are available from there). miika ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
