Re: map-widget: new suggestions for editing markers
> On Nov 15, 2017, at 4:29 AM, Lubomir I. Ivanov wrote: > > On 11 November 2017 at 18:51, Lubomir I. Ivanov wrote: >> >> https://github.com/Subsurface-divelog/subsurface/issues/754#issuecomment-343677546 >> > > no comments on latest suggestions by Stefan? > they look reasonable and i might just implement them as is. I like both of his ideas :-) /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On 11 November 2017 at 18:51, Lubomir I. Ivanov wrote: > > https://github.com/Subsurface-divelog/subsurface/issues/754#issuecomment-343677546 > no comments on latest suggestions by Stefan? they look reasonable and i might just implement them as is. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On 11 November 2017 at 18:48, Lubomir I. Ivanov wrote: > On 9 November 2017 at 19:43, Lubomir I. Ivanov wrote: >> On 2 November 2017 at 07:40, Willem Ferguson >> wrote: >>> From phone. >>> Issue 1: >>> This is the most difficult one. I support showing the map focused on the >>> last recorded dive site but zoomed out to the "regional" level. For me in >>> south Africa I would amost like to see the southern half of the continent >>> for a large probability of having the new dive site within scope. Also, >>> having the new and movable flag at the last dive site may be confusing. >>> There is a case to be made for centering the new flag within the scope of >>> the map. But maybe that would partly recreate the existing problem of having >>> to zoom in a lot before placing the flag. However that would still be my >>> personal preference. >>> >>> Issue 2: >>> I support the proposal. >>> Kind regards, Willem >>> >> >> made a PR for this: >> https://github.com/Subsurface-divelog/subsurface/pull/793 >> > > Stefan added new suggestions about this. > you can try the latest changes in master and discuss/ACK/NAK what he says. > > > @neolit123 > Took me some time until I was able to test the improvements. Great work! > But... > I immediately have more suggestions: > > What is a great "side effect" of the new strategy is the following: > After creating a new dive site for a new dive if the user > "accidentally" already moves the map to the right location before > pressing the "edit dive site" button this work is not lost when > pressing the dive site button because the marker is created at the > current map center. Thats great. But currently there is the strong > need to once grab the marker then to have the gps coordinates copied > to the edit field and to have it saved. Why not immediately copy the > initial coordinates once. Maybe the marker is already at the 100% > exact position and the user just wants to press "apply". > If you now enter coordinates directly by keyboard this is reflected > immediately in the marker position. BUT the map is not following the > marker. So very often the marker will be out of sight and you have to > find it by zooming out. The map should follow the marker in this case > while keeping the current zoom level. > > comment with markdown @ github: https://github.com/Subsurface-divelog/subsurface/issues/754#issuecomment-343677546 lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On 9 November 2017 at 19:43, Lubomir I. Ivanov wrote: > On 2 November 2017 at 07:40, Willem Ferguson > wrote: >> From phone. >> Issue 1: >> This is the most difficult one. I support showing the map focused on the >> last recorded dive site but zoomed out to the "regional" level. For me in >> south Africa I would amost like to see the southern half of the continent >> for a large probability of having the new dive site within scope. Also, >> having the new and movable flag at the last dive site may be confusing. >> There is a case to be made for centering the new flag within the scope of >> the map. But maybe that would partly recreate the existing problem of having >> to zoom in a lot before placing the flag. However that would still be my >> personal preference. >> >> Issue 2: >> I support the proposal. >> Kind regards, Willem >> > > made a PR for this: > https://github.com/Subsurface-divelog/subsurface/pull/793 > Stefan added new suggestions about this. you can try the latest changes in master and discuss/ACK/NAK what he says. @neolit123 Took me some time until I was able to test the improvements. Great work! But... I immediately have more suggestions: What is a great "side effect" of the new strategy is the following: After creating a new dive site for a new dive if the user "accidentally" already moves the map to the right location before pressing the "edit dive site" button this work is not lost when pressing the dive site button because the marker is created at the current map center. Thats great. But currently there is the strong need to once grab the marker then to have the gps coordinates copied to the edit field and to have it saved. Why not immediately copy the initial coordinates once. Maybe the marker is already at the 100% exact position and the user just wants to press "apply". If you now enter coordinates directly by keyboard this is reflected immediately in the marker position. BUT the map is not following the marker. So very often the marker will be out of sight and you have to find it by zooming out. The map should follow the marker in this case while keeping the current zoom level. lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On 2 November 2017 at 07:40, Willem Ferguson wrote: > From phone. > Issue 1: > This is the most difficult one. I support showing the map focused on the > last recorded dive site but zoomed out to the "regional" level. For me in > south Africa I would amost like to see the southern half of the continent > for a large probability of having the new dive site within scope. Also, > having the new and movable flag at the last dive site may be confusing. > There is a case to be made for centering the new flag within the scope of > the map. But maybe that would partly recreate the existing problem of having > to zoom in a lot before placing the flag. However that would still be my > personal preference. > > Issue 2: > I support the proposal. > Kind regards, Willem > made a PR for this: https://github.com/Subsurface-divelog/subsurface/pull/793 lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
> On Nov 2, 2017, at 8:49 AM, Martin Měřinský wrote: > > On Thu, 2017-11-02 at 08:26 -0700, Dirk Hohndel wrote: >>> On Nov 2, 2017, at 8:09 AM, Linus Torvalds >> on.org> wrote: >>> >>> On Thu, Nov 2, 2017 at 7:49 AM, Martin Měřinský >>> wrote: After selecting dive(s) without location, zomm out to level 0 (whole world). >>> >>> No. >>> >>> We used to do that, and it's a nightmare. If you walk through dives >>> in a trip where some dives have locations and others don't (which >>> is very common even if you give all your dives locations - think >>> "I'm now downloading new dives"), it's absolutely horrible. >>> >>> It's also horrible if you want to manually give a location. You >>> were just at your previous dive, now you go to the dive you want to >>> give a location to (possibly the same location, and very likely >>> near-by), and now the damn map zooms out to middle of nowhere. >>> >>> DO NOT MOVE/CHANGE THE MAP WHEN A DIVE HAS NO LOCATION. >>> >>> It's really really bad. >> >> I agree with that. If you really feel like you have to do something, >> put an opaque screen above it so it looks disabled or something. But >> don't zoom / move. > > Could be confusing a little bit, because divesite is probably not on > the map shown at the moment. And zoom out for sites without location > wasn't be bad for me. But I have no strong feelings about that. It is super annoying if you have a sequence of dives with and without GPS info and you scroll through them to find a certain thing. > Now selected divesite has brighter flag. Maybe the difference between > selected and not selected divesite should be a little more visible. That is certainly a valid point - I think the flags are still too similar /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On Thu, 2017-11-02 at 08:26 -0700, Dirk Hohndel wrote: > > On Nov 2, 2017, at 8:09 AM, Linus Torvalds > on.org> wrote: > > > > On Thu, Nov 2, 2017 at 7:49 AM, Martin Měřinský > > wrote: > > > > > > After selecting dive(s) without location, zomm out to level 0 > > > (whole world). > > > > No. > > > > We used to do that, and it's a nightmare. If you walk through dives > > in a trip where some dives have locations and others don't (which > > is very common even if you give all your dives locations - think > > "I'm now downloading new dives"), it's absolutely horrible. > > > > It's also horrible if you want to manually give a location. You > > were just at your previous dive, now you go to the dive you want to > > give a location to (possibly the same location, and very likely > > near-by), and now the damn map zooms out to middle of nowhere. > > > > DO NOT MOVE/CHANGE THE MAP WHEN A DIVE HAS NO LOCATION. > > > > It's really really bad. > > I agree with that. If you really feel like you have to do something, > put an opaque screen above it so it looks disabled or something. But > don't zoom / move. Could be confusing a little bit, because divesite is probably not on the map shown at the moment. And zoom out for sites without location wasn't be bad for me. But I have no strong feelings about that. Now selected divesite has brighter flag. Maybe the difference between selected and not selected divesite should be a little more visible. M. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
> On Nov 2, 2017, at 8:09 AM, Linus Torvalds > wrote: > > On Thu, Nov 2, 2017 at 7:49 AM, Martin Měřinský wrote: >> >> After selecting dive(s) without location, zomm out to level 0 (whole >> world). > > No. > > We used to do that, and it's a nightmare. If you walk through dives in > a trip where some dives have locations and others don't (which is very > common even if you give all your dives locations - think "I'm now > downloading new dives"), it's absolutely horrible. > > It's also horrible if you want to manually give a location. You were > just at your previous dive, now you go to the dive you want to give a > location to (possibly the same location, and very likely near-by), and > now the damn map zooms out to middle of nowhere. > > DO NOT MOVE/CHANGE THE MAP WHEN A DIVE HAS NO LOCATION. > > It's really really bad. I agree with that. If you really feel like you have to do something, put an opaque screen above it so it looks disabled or something. But don't zoom / move. /D ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On Thu, Nov 2, 2017 at 7:49 AM, Martin Měřinský wrote: > > After selecting dive(s) without location, zomm out to level 0 (whole > world). No. We used to do that, and it's a nightmare. If you walk through dives in a trip where some dives have locations and others don't (which is very common even if you give all your dives locations - think "I'm now downloading new dives"), it's absolutely horrible. It's also horrible if you want to manually give a location. You were just at your previous dive, now you go to the dive you want to give a location to (possibly the same location, and very likely near-by), and now the damn map zooms out to middle of nowhere. DO NOT MOVE/CHANGE THE MAP WHEN A DIVE HAS NO LOCATION. It's really really bad. Linus ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On Wed, 2017-11-01 at 23:02 +0200, Lubomir I. Ivanov wrote: > i suggest that collect feedback for at least a couple of days Hi. For the first start, without divelog, I would like to see map zoom 0 (whole world). After opening divelog, last dive is automatically selected. If it has location; or after changing selection to another dive with location, I would like to see map zoom 13 or 15 (village or town). After selecting several dives with different locations, I would like to see map zommed in to show all known locations from selected dives. Do not take care about selected dives without location. After selecting dive(s) without location, zomm out to level 0 (whole world). When editing dive(s) (this dive is selected). At the time location is added or changed (coordinates are successfully parsed), change the map according to previous rules. Map should have a feature to point at some location, click right mouse button (RMB) and select "Set This Divesite", which sets location to edited/selected dive(s). Also already known divesite on the map should enable RMB + "Set This Divesite". If I select (using left mouse button) divesite from the map some dive(s) are selected and I can correct their location using previous RMB + "Set This Divesite" feature. Do not remember any of my manual zooming from previous selections, or Subsurface run. Instead of map Hamburger button -> Open location in Google Maps, I would prefer Geo URI. It would open in my prefered map viewer application. (Why just Google?) I would still appreciate Openstreetmap tiles, because they are more usefull here. Martin M. ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On 2 November 2017 at 14:13, Lubomir I. Ivanov wrote: > On 2 November 2017 at 07:40, Willem Ferguson > wrote: > > From phone. > > Issue 1: > > This is the most difficult one. I support showing the map focused on the > > last recorded dive site but zoomed out to the "regional" level. For me in > > south Africa I would amost like to see the southern half of the continent > > for a large probability of having the new dive site within scope. Also, > > having the new and movable flag at the last dive site may be confusing. > > There is a case to be made for centering the new flag within the scope of > > the map. But maybe that would partly recreate the existing problem of > having > > to zoom in a lot before placing the flag. However that would still be my > > personal preference. > > > > Issue 2: > > I support the proposal. > > Kind regards, Willem > > > > thanks, for the feedback Willem. > do others have any suggestions? > > I agree with Willem on both points. I dive mostly in the same body of sea so having the map zoomed out to the regional level would fit the most. Thanks ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
On 2 November 2017 at 07:40, Willem Ferguson wrote: > From phone. > Issue 1: > This is the most difficult one. I support showing the map focused on the > last recorded dive site but zoomed out to the "regional" level. For me in > south Africa I would amost like to see the southern half of the continent > for a large probability of having the new dive site within scope. Also, > having the new and movable flag at the last dive site may be confusing. > There is a case to be made for centering the new flag within the scope of > the map. But maybe that would partly recreate the existing problem of having > to zoom in a lot before placing the flag. However that would still be my > personal preference. > > Issue 2: > I support the proposal. > Kind regards, Willem > thanks, for the feedback Willem. do others have any suggestions? lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
Re: map-widget: new suggestions for editing markers
>From phone. Issue 1: This is the most difficult one. I support showing the map focused on the last recorded dive site but zoomed out to the "regional" level. For me in south Africa I would amost like to see the southern half of the continent for a large probability of having the new dive site within scope. Also, having the new and movable flag at the last dive site may be confusing. There is a case to be made for centering the new flag within the scope of the map. But maybe that would partly recreate the existing problem of having to zoom in a lot before placing the flag. However that would still be my personal preference. Issue 2: I support the proposal. Kind regards, Willem On 02 Nov 2017 00:03, "Lubomir I. Ivanov" wrote: > hello, > > Stefan has posted a couple of suggestions about improving the > map-widget editing of markers. > i do agree that this area needs some work. > > here is the github issue link: > https://github.com/Subsurface-divelog/subsurface/issues/754 > also, have a look at my comments bellow the main post. > > i suggest that collect feedback for at least a couple of days to see > what user suggestions we can get from the mailing list and then once > we settle on something we can lock the idea and implement it (at least > try to). > > so, please share your ideas about the current marker editing behavior > and how to improve it. > if you have a github account you can post directly there. > > thanks > lubomir > -- > ___ > subsurface mailing list > subsurface@subsurface-divelog.org > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface > ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
map-widget: new suggestions for editing markers
hello, Stefan has posted a couple of suggestions about improving the map-widget editing of markers. i do agree that this area needs some work. here is the github issue link: https://github.com/Subsurface-divelog/subsurface/issues/754 also, have a look at my comments bellow the main post. i suggest that collect feedback for at least a couple of days to see what user suggestions we can get from the mailing list and then once we settle on something we can lock the idea and implement it (at least try to). so, please share your ideas about the current marker editing behavior and how to improve it. if you have a github account you can post directly there. thanks lubomir -- ___ subsurface mailing list subsurface@subsurface-divelog.org http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
