Re: [Sugar-devel] [Dextrose] [PATCH sugar-toolkit] Insert activity root path in front of the reset of sys.path

2011-02-07 Thread Martin Langhoff 
On Mon, Feb 7, 2011 at 4:40 AM, Sascha Silbe
 wrote:
>> Otherwise it is possible to include, eg, system modules before local ones.
>
> Which is how Python 2 usually works. Your patch would make us deviate
> from upstream, making it harder to debug.

I've done extensive programming with Python, Perl, PHP and similar
scripting languages over the last, um, 14 years. Local modules/libs
always override system ones.

To wit, note the first entry at

$ python
Python 2.7 (r27:82500, Sep 16 2010, 18:03:06)
[GCC 4.5.1 20100907 (Red Hat 4.5.1-3)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import sys
>>> sys.path
['', '/usr/lib/python27.zip', '/usr/lib/python2.7',
'/usr/lib/python2.7/plat-linux2', '/usr/lib/python2.7/lib-tk',
'/usr/lib/python2.7/lib-old', '/usr/lib/python2.7/lib-dynload',
'/usr/lib/python2.7/site-packages',
'/usr/lib/python2.7/site-packages/PIL',
'/usr/lib/python2.7/site-packages/gst-0.10',
'/usr/lib/python2.7/site-packages/gtk-2.0',
'/usr/lib/python2.7/site-packages/setuptools-0.6c11-py2.7.egg-info',
'/usr/lib/python2.7/site-packages/webkit-1.0']

The library the developer meant to include is a lot easier to debug
(to the developer involved) than "system library changed API
subtly/silently/in a relnote encoded with a reference to a bug number.

The behaviour sought by Aleksey's patch makes sense. I am surprised
that CWD isn't set to SUGAR_BUNDLE_PATH, maybe that needs to get fixed
instead.

cheers,


m
--
 martin.langh...@gmail.com
 mar...@laptop.org -- Software Architect - OLPC
 - ask interesting questions
 - don't get distracted with shiny stuff  - working code first
 - http://wiki.laptop.org/go/User:Martinlanghoff
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar v2] Add cpu and memory resource indicator to frame

2011-02-07 Thread Anish Mangal 
Oh!

I didn't realize this was pushed to sugar/mainline (sorry for
overlooking the commit link you gave)
I only pushed it to dextrose/mainline.

On Tue, Feb 8, 2011 at 00:27, Anish Mangal  wrote:
> On Mon, Feb 7, 2011 at 18:13, Simon Schampijer  wrote:
>> On 01/25/2011 10:14 PM, Anish Mangal wrote:
>>>
>>> pushed to dx/mainline [1]
>>>
>>> [1]
>>> http://git.sugarlabs.org/dextrose/mainline/commit/1cd4c31cd474bb84985fff97ac5f5b9e693469db
>>
>> Hi Anish,
>>
>> did you push as well to sugar mainline?
>> http://git.sugarlabs.org/sugar/mainline/commit/e014bc401195a9b096e44d33d7f6135f7ae0c1c6
>
> nope
>
>>
>> I think this one is still controversial. At least, I am not really happy
>> about including it (as I mainly think the picture we use here, a sad/happy
>> computer is not right) in the mainline and I remember others did feel
>> similarly.
>>
>
> If you agree on s/sad/strained and are happy with Gary's or
> Frederick's icons, I'd be happy to push.
> Also, I think tomeu had raised concerns regarding the way the
> metrics/load is calculated. Again, if you're happy with silbe's change
> of giving memory consumption greater weight, I have no problems
> otherwise.
>
> FWIW, I'm fine with silbe's changes and Gary/Frederick's icons and
> corresponding changes in code.
>
>> Regards,
>>   Simon
>>
>> ___
>> Sugar-devel mailing list
>> Sugar-devel@lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/sugar-devel
>>
>
> --
> Anish | an...@sugarlabs.org
>



-- 
Anish | an...@sugarlabs.org
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar v2] Add cpu and memory resource indicator to frame

2011-02-07 Thread Anish Mangal 
On Mon, Feb 7, 2011 at 18:13, Simon Schampijer  wrote:
> On 01/25/2011 10:14 PM, Anish Mangal wrote:
>>
>> pushed to dx/mainline [1]
>>
>> [1]
>> http://git.sugarlabs.org/dextrose/mainline/commit/1cd4c31cd474bb84985fff97ac5f5b9e693469db
>
> Hi Anish,
>
> did you push as well to sugar mainline?
> http://git.sugarlabs.org/sugar/mainline/commit/e014bc401195a9b096e44d33d7f6135f7ae0c1c6

nope

>
> I think this one is still controversial. At least, I am not really happy
> about including it (as I mainly think the picture we use here, a sad/happy
> computer is not right) in the mainline and I remember others did feel
> similarly.
>

If you agree on s/sad/strained and are happy with Gary's or
Frederick's icons, I'd be happy to push.
Also, I think tomeu had raised concerns regarding the way the
metrics/load is calculated. Again, if you're happy with silbe's change
of giving memory consumption greater weight, I have no problems
otherwise.

FWIW, I'm fine with silbe's changes and Gary/Frederick's icons and
corresponding changes in code.

> Regards,
>   Simon
>
> ___
> Sugar-devel mailing list
> Sugar-devel@lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>

-- 
Anish | an...@sugarlabs.org
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar v2] Add cpu and memory resource indicator to frame

2011-02-07 Thread Simon Schampijer 

On 01/25/2011 10:14 PM, Anish Mangal wrote:

pushed to dx/mainline [1]

[1] 
http://git.sugarlabs.org/dextrose/mainline/commit/1cd4c31cd474bb84985fff97ac5f5b9e693469db


Hi Anish,

did you push as well to sugar mainline? 
http://git.sugarlabs.org/sugar/mainline/commit/e014bc401195a9b096e44d33d7f6135f7ae0c1c6


I think this one is still controversial. At least, I am not really happy 
about including it (as I mainly think the picture we use here, a 
sad/happy computer is not right) in the mainline and I remember others 
did feel similarly.


Regards,
   Simon

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Modified Patch for adding feedback-icon.svg to sugar-artwork

2011-02-07 Thread Frederick Grose 
On Mon, Feb 7, 2011 at 11:58 AM, Simon Schampijer wrote:

> On 01/29/2011 01:34 PM, Frederick Grose wrote:
>
>> On Sat, Jan 29, 2011 at 12:18 PM, Anish Mangal> >wrote:
>>
>>  I like it better than the current one.
>>>
>>> Couple of nitpicks:
>>> (1) There is lots of inkscape SPAM. Save the file as a 'simple svg'.
>>> (2) It isn't sugarized [1].
>>>
>>> [1]
>>>
>>> http://wiki.sugarlabs.org/go/Development_Team/Almanac/Making_Icons#Sugarizing_Icons
>>>
>>
> Hi,
>
> can we have a bit more context for that patch? Where is the feedback icon
> used?
>
> Thanks,
>   Simon


This is from Dextrose 2,
http://wiki.sugarlabs.org/go/Dextrose/2/Todo#feedback

Sorry for the
disconnect.

 --Fred
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Modified Patch for adding feedback-icon.svg to sugar-artwork

2011-02-07 Thread Simon Schampijer 

On 01/29/2011 01:34 PM, Frederick Grose wrote:

On Sat, Jan 29, 2011 at 12:18 PM, Anish Mangalwrote:


I like it better than the current one.

Couple of nitpicks:
(1) There is lots of inkscape SPAM. Save the file as a 'simple svg'.
(2) It isn't sugarized [1].

[1]
http://wiki.sugarlabs.org/go/Development_Team/Almanac/Making_Icons#Sugarizing_Icons


Hi,

can we have a bit more context for that patch? Where is the feedback 
icon used?


Thanks,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [SPAM?]: Re: [PATCH] Modify search icon to honor stroke and fill color

2011-02-07 Thread Simon Schampijer 

Hi Gary,

On 02/04/2011 09:41 PM, Gary Martin wrote:

Hi Simon,

On 4 Feb 2011, at 17:05, Simon Schampijer  wrote:


On 02/04/2011 08:17 AM, Gonzalo Odiard wrote:

On Thu, Feb 3, 2011 at 4:26 PM, Simon Schampijerwrote:


Hi Gonzalo,

looks good to me. Please push to the master branch.



I think you added to Gonzalo Delgado, not me.
I am godiard in git.


Sorry, done now.


 From the icons under icons/scalable/actions the logout icon does not honour
the stroke and fill colour - I would take a patch for that one, too :)


@Gary, do you think it is safe to include in all those icons the stroke and 
fill colour? Do you think there was a specific reason to not do so for those 
icons?


Just adding myself as a cc to the ticket, but I think these are safe for now as 
they are all intended as white toolbar icons, not ever user coloured items. 
I'll go through and tidy them up just so we have them all to the same standard 
- will make a git clone of sugar-artwork and submit a merge request once done.

--G


Excellent! Sounds good.

Regards,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [Dextrose] [PATCH sugar-toolkit] Insert activity root path in front of the reset of sys.path

2011-02-07 Thread Sascha Silbe 
Excerpts from Aleksey Lim's message of Sun Feb 06 01:50:54 +0100 2011:

[Posting only on sugar-devel - please let's discuss general Sugar
development just there, not on dextrose]

> Otherwise it is possible to include, eg, system modules before local ones.

Which is how Python 2 usually works. Your patch would make us deviate
from upstream, making it harder to debug. It might even cause regressions
in existing activities that bundle copies of system modules for use on
older systems. If we prefer the bundled copy over the system one, it
might break on more recent systems. In Restore [1] I'm taking care to
change the name of the file [2] and use it only if the system copy is too
old, but other authors might not have been that careful.

I'd much rather see us mention this in the documentation than
unconditionally messing with the module loading order for all activities.

AFAICT Python 3 prefers local modules over the system ones [4], so this
is only a matter of time resp. of a Py3k / g-i / Gnome3 based Sugar port.

Sascha

[1] http://activities.sugarlabs.org/en-US/sugar/addon/4327
[2] http://git.sugarlabs.org/restore/mainline/blobs/master/zipfile26.py
[3] http://git.sugarlabs.org/restore/mainline/blobs/master/restore.py#line29
[4] http://diveintopython3.org/your-first-python-program.html#importsearchpath
-- 
http://sascha.silbe.org/
http://www.infra-silbe.de/


signature.asc
Description: PGP signature
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel