Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 1:25 AM, Walter Bender wrote: > On Tue, Sep 25, 2012 at 7:05 PM, Peter Robinson wrote: >> Hi Walter, >> >> I'm seeing issues building this as an rpm, there are the logs >> http://kojipkgs.fedoraproject.org//work/tasks/6308/4526308/build.log > > Strange. Seems to be related somehow to ./setup.py build but I have no > problems running that script. Will investigate tomorrow. No problem > with TA 160? TA 160 works fine and the only change to the spec for building was to bump the version. Abacua 35 was fine too. Thanks, Peter >> Peter >> >> On Tue, Sep 25, 2012 at 10:07 PM, Sugar Labs Activities >> wrote: >>> Activity Homepage: >>> http://activities.sugarlabs.org/addon/4293 >>> >>> Sugar Platform: >>> 0.82 - 0.98 >>> >>> Download Now: >>> http://activities.sugarlabs.org/downloads/file/28230/abacus-36.xo >>> >>> Release notes: >>> 36 >>> >>> ENHANCEMENT >>> * New translations >>> * summary string in activity.info >>> >>> >>> Sugar Labs Activities >>> http://activities.sugarlabs.org >>> >>> ___ >>> Sugar-devel mailing list >>> Sugar-devel@lists.sugarlabs.org >>> http://lists.sugarlabs.org/listinfo/sugar-devel >> ___ >> Sugar-devel mailing list >> Sugar-devel@lists.sugarlabs.org >> http://lists.sugarlabs.org/listinfo/sugar-devel > > > > -- > Walter Bender > Sugar Labs > http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 7:39 AM, Daniel Narvaez wrote: > Hi, > > is there a dependency on sugar-toolkit in the spec? It doesn't seem to find > the sugar.activity module. It worked fine in v35, the only change was to bump the spec version, also there's other Activities that I built fine at the same time. Peter > On Wednesday, 26 September 2012, Peter Robinson wrote: >> >> Hi Walter, >> >> I'm seeing issues building this as an rpm, there are the logs >> http://kojipkgs.fedoraproject.org//work/tasks/6308/4526308/build.log >> >> Peter >> >> On Tue, Sep 25, 2012 at 10:07 PM, Sugar Labs Activities >> wrote: >> > Activity Homepage: >> > http://activities.sugarlabs.org/addon/4293 >> > >> > Sugar Platform: >> > 0.82 - 0.98 >> > >> > Download Now: >> > http://activities.sugarlabs.org/downloads/file/28230/abacus-36.xo >> > >> > Release notes: >> > 36 >> > >> > ENHANCEMENT >> > * New translations >> > * summary string in activity.info >> > >> > >> > Sugar Labs Activities >> > http://activities.sugarlabs.org >> > >> > ___ >> > Sugar-devel mailing list >> > Sugar-devel@lists.sugarlabs.org >> > http://lists.sugarlabs.org/listinfo/sugar-devel >> ___ >> Sugar-devel mailing list >> Sugar-devel@lists.sugarlabs.org >> http://lists.sugarlabs.org/listinfo/sugar-devel > > > > -- > Daniel Narvaez > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH shell] Views: defocus the search entry by default
From: Simon Schampijer This patch does implement the following behavior: - the search entry in all the views (Home (Favorites and Activity list), Group and Neighborhood) is unfocused by default - the search entry can be focused by clicking in the entry or by starting to type - the search entry contains a hint when unfocused and no search has been entered, the hint is dependent on the View you are in and matches the labels in the View Palettes (Frame), the existing translations have been reused - the learner can defocus the entry by clicking outside somewhere in the view (toolbar or canvas), if no search has been entered the hint will be displayed again if there is a search entered it will remain in effect and the entry will only be unfocused, the latter will help to hide the OSK and see the matches for a particular search - clicking on the clear icon in the entry ('x') the entry will be unfocused again Signed-off-by: Simon Schampijer --- src/jarabe/desktop/activitieslist.py | 4 src/jarabe/desktop/favoritesview.py | 4 src/jarabe/desktop/groupbox.py | 6 +- src/jarabe/desktop/homebox.py| 15 +++ src/jarabe/desktop/homewindow.py | 23 +++ src/jarabe/desktop/meshbox.py| 5 + src/jarabe/desktop/viewcontainer.py | 1 + src/jarabe/desktop/viewtoolbar.py| 6 +- 8 files changed, 58 insertions(+), 6 deletions(-) diff --git a/src/jarabe/desktop/activitieslist.py b/src/jarabe/desktop/activitieslist.py index b830526..1b5ddd7 100644 --- a/src/jarabe/desktop/activitieslist.py +++ b/src/jarabe/desktop/activitieslist.py @@ -375,6 +375,10 @@ class ActivitiesList(Gtk.VBox): self._alert = None self._clear_message_box = None +def grab_focus(self): +# overwrite grab focus in order to grab focus from the parent +self._tree_view.grab_focus() + def set_filter(self, query): matches = self._tree_view.set_filter(query) if matches == 0: diff --git a/src/jarabe/desktop/favoritesview.py b/src/jarabe/desktop/favoritesview.py index b73d016..26a89e6 100644 --- a/src/jarabe/desktop/favoritesview.py +++ b/src/jarabe/desktop/favoritesview.py @@ -85,6 +85,10 @@ class FavoritesBox(Gtk.VBox): def set_resume_mode(self, resume_mode): self._view.set_resume_mode(resume_mode) +def grab_focus(self): +# overwrite grab focus in order to grab focus from the parent +self._view.grab_focus() + def add_alert(self, alert): if self._alert is not None: self.remove_alert() diff --git a/src/jarabe/desktop/groupbox.py b/src/jarabe/desktop/groupbox.py index 3d7c0f3..f916f62 100644 --- a/src/jarabe/desktop/groupbox.py +++ b/src/jarabe/desktop/groupbox.py @@ -41,7 +41,8 @@ class GroupBox(ViewContainer): self._query = '' toolbar.connect('query-changed', self._toolbar_query_changed_cb) - +toolbar.search_entry.connect('icon-press', + self.__clear_icon_pressed_cb) self._friends = {} friends_model = friends.get_model() @@ -72,3 +73,6 @@ class GroupBox(ViewContainer): for icon in self.get_children(): if hasattr(icon, 'set_filter'): icon.set_filter(self._query) + +def __clear_icon_pressed_cb(self, entry, icon_pos, event): +self.grab_focus() diff --git a/src/jarabe/desktop/homebox.py b/src/jarabe/desktop/homebox.py index 8eda213..ed5144b 100644 --- a/src/jarabe/desktop/homebox.py +++ b/src/jarabe/desktop/homebox.py @@ -45,6 +45,8 @@ class HomeBox(Gtk.VBox): toolbar.connect('query-changed', self.__toolbar_query_changed_cb) toolbar.connect('view-changed', self.__toolbar_view_changed_cb) +toolbar.search_entry.connect('icon-press', + self.__clear_icon_pressed_cb) self._list_view.connect('clear-clicked', self.__activitylist_clear_clicked_cb, toolbar) @@ -108,6 +110,17 @@ class HomeBox(Gtk.VBox): def __activitylist_clear_clicked_cb(self, widget, toolbar): toolbar.clear_query() +def __clear_icon_pressed_cb(self, entry, icon_pos, event): +self.grab_focus() + +def grab_focus(self): +# overwrite grab focus to be able to grab focus on the +# views which are packed inside a box +if self._list_view in self.get_children(): +self._list_view.grab_focus() +else: +self._favorites_box.grab_focus() + def _set_view(self, view): if view == _FAVORITES_VIEW: if self._list_view in self.get_children(): @@ -116,6 +129,7 @@ class HomeBox(Gtk.VBox): if self._favorites_box not in self.get_children(): self.add(self._favorites_box) self._favorites_box.show() +self._favorites_box.grab_focus() elif view == _LIST_VIEW: if self
Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default
On 09/26/2012 09:40 AM, Simon Schampijer wrote: From: Simon Schampijer This patch does implement the following behavior: - the search entry in all the views (Home (Favorites and Activity list), Group and Neighborhood) is unfocused by default - the search entry can be focused by clicking in the entry or by starting to type - the search entry contains a hint when unfocused and no search has been entered, the hint is dependent on the View you are in and matches the labels in the View Palettes (Frame), the existing translations have been reused - the learner can defocus the entry by clicking outside somewhere in the view (toolbar or canvas), if no search has been entered the hint will be displayed again if there is a search entered it will remain in effect and the entry will only be unfocused, the latter will help to hide the OSK and see the matches for a particular search - clicking on the clear icon in the entry ('x') the entry will be unfocused again Signed-off-by: Simon Schampijer The above was decided in discussions with Gary. We just tested both on the XO. A further enhancement would be to do the same in the Journal, string is "Search in Journal". Another enhancement is that hitting "enter" in the entry would unfocus it as well, the search entered would remain in effect. Simon ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default
Hi Simon, On 26 Sep 2012, at 08:40, Simon Schampijer wrote: > From: Simon Schampijer > > This patch does implement the following behavior: > > - the search entry in all the views (Home (Favorites and Activity list), > Group and Neighborhood) is unfocused by default > > - the search entry can be focused by clicking in the entry or by > starting to type > > - the search entry contains a hint when unfocused and no search has been > entered, the hint is dependent on the View you are in and matches the > labels in the View Palettes (Frame), the existing translations have > been reused > > - the learner can defocus the entry by clicking outside somewhere in > the view (toolbar or canvas), if no search has been entered the hint > will be displayed again if there is a search entered it will remain > in effect and the entry will only be unfocused, the latter will help > to hide the OSK and see the matches for a particular search > > - clicking on the clear icon in the entry ('x') the entry will be > unfocused again Tested there here on an XO (with OSK and without) and it's working very nicely. Thanks for the patch! :) For the others reviewing this, there are a couple more behaviours on the radar as part of this search focus treatment, but their omission here should not block getting this patch landed as it's already a really good improvement (and especially for OSK user interaction): - the enter/return key (to defocus and leave query intact) - the escape key (clear query and defocus) Regards, --Gary > Signed-off-by: Simon Schampijer > --- > src/jarabe/desktop/activitieslist.py | 4 > src/jarabe/desktop/favoritesview.py | 4 > src/jarabe/desktop/groupbox.py | 6 +- > src/jarabe/desktop/homebox.py| 15 +++ > src/jarabe/desktop/homewindow.py | 23 +++ > src/jarabe/desktop/meshbox.py| 5 + > src/jarabe/desktop/viewcontainer.py | 1 + > src/jarabe/desktop/viewtoolbar.py| 6 +- > 8 files changed, 58 insertions(+), 6 deletions(-) > > diff --git a/src/jarabe/desktop/activitieslist.py > b/src/jarabe/desktop/activitieslist.py > index b830526..1b5ddd7 100644 > --- a/src/jarabe/desktop/activitieslist.py > +++ b/src/jarabe/desktop/activitieslist.py > @@ -375,6 +375,10 @@ class ActivitiesList(Gtk.VBox): > self._alert = None > self._clear_message_box = None > > +def grab_focus(self): > +# overwrite grab focus in order to grab focus from the parent > +self._tree_view.grab_focus() > + > def set_filter(self, query): > matches = self._tree_view.set_filter(query) > if matches == 0: > diff --git a/src/jarabe/desktop/favoritesview.py > b/src/jarabe/desktop/favoritesview.py > index b73d016..26a89e6 100644 > --- a/src/jarabe/desktop/favoritesview.py > +++ b/src/jarabe/desktop/favoritesview.py > @@ -85,6 +85,10 @@ class FavoritesBox(Gtk.VBox): > def set_resume_mode(self, resume_mode): > self._view.set_resume_mode(resume_mode) > > +def grab_focus(self): > +# overwrite grab focus in order to grab focus from the parent > +self._view.grab_focus() > + > def add_alert(self, alert): > if self._alert is not None: > self.remove_alert() > diff --git a/src/jarabe/desktop/groupbox.py b/src/jarabe/desktop/groupbox.py > index 3d7c0f3..f916f62 100644 > --- a/src/jarabe/desktop/groupbox.py > +++ b/src/jarabe/desktop/groupbox.py > @@ -41,7 +41,8 @@ class GroupBox(ViewContainer): > > self._query = '' > toolbar.connect('query-changed', self._toolbar_query_changed_cb) > - > +toolbar.search_entry.connect('icon-press', > + self.__clear_icon_pressed_cb) > self._friends = {} > > friends_model = friends.get_model() > @@ -72,3 +73,6 @@ class GroupBox(ViewContainer): > for icon in self.get_children(): > if hasattr(icon, 'set_filter'): > icon.set_filter(self._query) > + > +def __clear_icon_pressed_cb(self, entry, icon_pos, event): > +self.grab_focus() > diff --git a/src/jarabe/desktop/homebox.py b/src/jarabe/desktop/homebox.py > index 8eda213..ed5144b 100644 > --- a/src/jarabe/desktop/homebox.py > +++ b/src/jarabe/desktop/homebox.py > @@ -45,6 +45,8 @@ class HomeBox(Gtk.VBox): > > toolbar.connect('query-changed', self.__toolbar_query_changed_cb) > toolbar.connect('view-changed', self.__toolbar_view_changed_cb) > +toolbar.search_entry.connect('icon-press', > + self.__clear_icon_pressed_cb) > self._list_view.connect('clear-clicked', > self.__activitylist_clear_clicked_cb, toolbar) > > @@ -108,6 +110,17 @@ class HomeBox(Gtk.VBox): > def __activitylist_clear_clicked_cb(self, widget, toolbar): > toolbar.clear_query() > > +def __clear_icon_pressed_cb(self, entry, icon_pos, event): > +self.grab_fo
Re: [Sugar-devel] [ASLO] Release Get Books-13
Yes :) http://download.sugarlabs.org/sources/honey/GetBooks/ Gonzalo On Tue, Sep 25, 2012 at 8:09 PM, Peter Robinson wrote: > Can I get some tar balls please? > > peter > > On Fri, Sep 14, 2012 at 11:21 PM, Sugar Labs Activities > wrote: > > Activity Homepage: > > http://activities.sugarlabs.org/addon/4304 > > > > Sugar Platform: > > 0.98 - 0.98 > > > > Download Now: > > http://activities.sugarlabs.org/downloads/file/28217/get_books-13.xo > > > > Release notes: > > Update FeedBook catalogs > > Revert "Avoid error using the activity in spanish due to accents in > translation - SL #3763" > > Do not request random catalog when navigating catalog tree > > Read Internet Archive catalogs (Daniel Castelo) > > Updated translations > > > > > > Sugar Labs Activities > > http://activities.sugarlabs.org > > > > ___ > > Sugar-devel mailing list > > Sugar-devel@lists.sugarlabs.org > > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Read-101
Read crash with the last gstreamer-espeak plugin dnarvaez is looking at the plugin, and I am looking at the Read activity. I hope solve it soon and upload version 102 Gonzalo On Tue, Sep 25, 2012 at 7:39 PM, Peter Robinson wrote: > Any chance of tarballs ;-) > > On Thu, Sep 13, 2012 at 6:33 PM, Sugar Labs Activities > wrote: > > Activity Homepage: > > http://activities.sugarlabs.org/addon/4028 > > > > Sugar Platform: > > 0.98 - 0.98 > > > > Download Now: > > http://activities.sugarlabs.org/downloads/file/28216/read-101.xo > > > > Release notes: > > Improve display of text files > > Use a scrollbar to navigate the entire book in txt books. > > Add touch event management to text files backend > > Implement kindle like change page in epub backend > > Page number should be zero based, fix epub backend - SL #3864 > > Keep the text position in the epub files - SL #3861 > > Enable the use of arrow keys in the page number entry - SL #3863 > > Fix index management in epub files - SL #3853 > > Enable touch kindle like interaction in pdf backend > > Disable code to read index in pdf files > > > > > > > > Sugar Labs Activities > > http://activities.sugarlabs.org > > > > ___ > > Sugar-devel mailing list > > Sugar-devel@lists.sugarlabs.org > > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [sugar-toolkit-gtk3] Set default python encoding to utf-8
Thanks, pushed as: 5fdad9481ba7079a6a718159ebe7eb8e5367c46e Gonzalo will open a ticket for tracking testing, and one for the Python3 follow up. Simon On 08/27/2012 04:09 PM, godi...@sugarlabs.org wrote: From: Gonzalo Odiard As spoted by Daniel Narvaez in [1], pygi does not set the default encoding anymore as the old gtk did. This change break ported activities. The change in gtk was discussed upstream here [2] A better solution will be implemented when we port to python 3, when we will be able to use real unicode strings. Signed-off-by: Gonzalo Odiard [1] http://lists.sugarlabs.org/archive/sugar-devel/2012-August/038993.html [2] https://bugzilla.gnome.org/show_bug.cgi?id=681915 --- bin/sugar-activity | 5 + 1 file changed, 5 insertions(+) diff --git a/bin/sugar-activity b/bin/sugar-activity index 5aef1ae..839174a 100644 --- a/bin/sugar-activity +++ b/bin/sugar-activity @@ -18,6 +18,11 @@ import os import sys +# Change the default encoding to avoid UnicodeDecodeError +# http://lists.sugarlabs.org/archive/sugar-devel/2012-August/038928.html +reload(sys) +sys.setdefaultencoding('utf-8') + import gettext from optparse import OptionParser ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default
Wow impressive patch. Is a great usability improvement, and having the placeholder text is nice. Also I don't see the text reset issue that I was seeing in your previous test app, sent to the design thread [1]. About code styling, do we have an agreement mixing docstrings like """this""" and # this ? If so, please push. Thanks! [1] http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039096.html 2012/9/26 Simon Schampijer : > From: Simon Schampijer > > This patch does implement the following behavior: > > - the search entry in all the views (Home (Favorites and Activity list), > Group and Neighborhood) is unfocused by default > > - the search entry can be focused by clicking in the entry or by > starting to type > > - the search entry contains a hint when unfocused and no search has been > entered, the hint is dependent on the View you are in and matches the > labels in the View Palettes (Frame), the existing translations have > been reused > > - the learner can defocus the entry by clicking outside somewhere in > the view (toolbar or canvas), if no search has been entered the hint > will be displayed again if there is a search entered it will remain > in effect and the entry will only be unfocused, the latter will help > to hide the OSK and see the matches for a particular search > > - clicking on the clear icon in the entry ('x') the entry will be > unfocused again > > Signed-off-by: Simon Schampijer > --- > src/jarabe/desktop/activitieslist.py | 4 > src/jarabe/desktop/favoritesview.py | 4 > src/jarabe/desktop/groupbox.py | 6 +- > src/jarabe/desktop/homebox.py| 15 +++ > src/jarabe/desktop/homewindow.py | 23 +++ > src/jarabe/desktop/meshbox.py| 5 + > src/jarabe/desktop/viewcontainer.py | 1 + > src/jarabe/desktop/viewtoolbar.py| 6 +- > 8 files changed, 58 insertions(+), 6 deletions(-) > > diff --git a/src/jarabe/desktop/activitieslist.py > b/src/jarabe/desktop/activitieslist.py > index b830526..1b5ddd7 100644 > --- a/src/jarabe/desktop/activitieslist.py > +++ b/src/jarabe/desktop/activitieslist.py > @@ -375,6 +375,10 @@ class ActivitiesList(Gtk.VBox): > self._alert = None > self._clear_message_box = None > > +def grab_focus(self): > +# overwrite grab focus in order to grab focus from the parent > +self._tree_view.grab_focus() > + > def set_filter(self, query): > matches = self._tree_view.set_filter(query) > if matches == 0: > diff --git a/src/jarabe/desktop/favoritesview.py > b/src/jarabe/desktop/favoritesview.py > index b73d016..26a89e6 100644 > --- a/src/jarabe/desktop/favoritesview.py > +++ b/src/jarabe/desktop/favoritesview.py > @@ -85,6 +85,10 @@ class FavoritesBox(Gtk.VBox): > def set_resume_mode(self, resume_mode): > self._view.set_resume_mode(resume_mode) > > +def grab_focus(self): > +# overwrite grab focus in order to grab focus from the parent > +self._view.grab_focus() > + > def add_alert(self, alert): > if self._alert is not None: > self.remove_alert() > diff --git a/src/jarabe/desktop/groupbox.py b/src/jarabe/desktop/groupbox.py > index 3d7c0f3..f916f62 100644 > --- a/src/jarabe/desktop/groupbox.py > +++ b/src/jarabe/desktop/groupbox.py > @@ -41,7 +41,8 @@ class GroupBox(ViewContainer): > > self._query = '' > toolbar.connect('query-changed', self._toolbar_query_changed_cb) > - > +toolbar.search_entry.connect('icon-press', > + self.__clear_icon_pressed_cb) > self._friends = {} > > friends_model = friends.get_model() > @@ -72,3 +73,6 @@ class GroupBox(ViewContainer): > for icon in self.get_children(): > if hasattr(icon, 'set_filter'): > icon.set_filter(self._query) > + > +def __clear_icon_pressed_cb(self, entry, icon_pos, event): > +self.grab_focus() > diff --git a/src/jarabe/desktop/homebox.py b/src/jarabe/desktop/homebox.py > index 8eda213..ed5144b 100644 > --- a/src/jarabe/desktop/homebox.py > +++ b/src/jarabe/desktop/homebox.py > @@ -45,6 +45,8 @@ class HomeBox(Gtk.VBox): > > toolbar.connect('query-changed', self.__toolbar_query_changed_cb) > toolbar.connect('view-changed', self.__toolbar_view_changed_cb) > +toolbar.search_entry.connect('icon-press', > + self.__clear_icon_pressed_cb) > self._list_view.connect('clear-clicked', > self.__activitylist_clear_clicked_cb, > toolbar) > > @@ -108,6 +110,17 @@ class HomeBox(Gtk.VBox): > def __activitylist_clear_clicked_cb(self, widget, toolbar): > toolbar.clear_query() > > +def __clear_icon_pressed_cb(self, entry, icon_pos, event): > +self.grab_focus() > + > +def grab_focus(self): > +# overwrite grab focus to be able to grab fo
Re: [Sugar-devel] [PATCH] Fix external media mounting (#3911)
Excellent work Daniel. I just did make the mount/unmount args more verbose and added a link to the upstream discussion on user_data arguments [1]. Pushed as: b0ac7a02f9e1cd5a3d4408e5ecd4fe7d4a70d9b7 Regards, Simon [1] https://mail.gnome.org/archives/python-hackers-list/2012-September/msg9.html On 09/25/2012 07:45 PM, Daniel Drake wrote: The GVolumeMonitor used for mounting devices must not drop out of scope, otherwise it will be destroyed, and no signals will be receieved. Move it into global scope. Update mount and unmount calls for introspection. Remove dead code from volumestoolbar. --- extensions/deviceicon/volume.py | 10 ++ src/jarabe/journal/volumestoolbar.py | 7 --- src/jarabe/view/palettes.py | 8 +--- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/extensions/deviceicon/volume.py b/extensions/deviceicon/volume.py index ec7b2e2..fe9e0e3 100644 --- a/extensions/deviceicon/volume.py +++ b/extensions/deviceicon/volume.py @@ -34,6 +34,7 @@ from jarabe.frame.frameinvoker import FrameWidgetInvoker _icons = {} +volume_monitor = None class DeviceView(TrayIcon): @@ -100,6 +101,7 @@ def setup(tray): def _setup_volumes(tray): +global volume_monitor volume_monitor = Gio.VolumeMonitor.get() for volume in volume_monitor.get_volumes(): @@ -121,17 +123,17 @@ def _mount(volume, tray): # Follow Nautilus behaviour here # since it has the same issue with removable device # and it would be good to not invent our own workflow -if hasattr(volume, 'should_automount') and not volume.should_automount(): +if not volume.should_automount(): return #TODO: should be done by some other process, like gvfs-hal-volume-monitor -#TODO: use volume.should_automount() when it gets into pygtk if volume.get_mount() is None and volume.can_mount(): #TODO: pass None as mount_operation, or better, SugarMountOperation -volume.mount(Gtk.MountOperation(tray.get_toplevel()), _mount_cb) +volume.mount(0, Gtk.MountOperation(parent=tray.get_toplevel()), None, + _mount_cb, None) -def _mount_cb(volume, result): +def _mount_cb(volume, result, user_data): logging.debug('_mount_cb %r %r', volume, result) volume.mount_finish(result) diff --git a/src/jarabe/journal/volumestoolbar.py b/src/jarabe/journal/volumestoolbar.py index 8f4692d..1fc368e 100644 --- a/src/jarabe/journal/volumestoolbar.py +++ b/src/jarabe/journal/volumestoolbar.py @@ -251,13 +251,6 @@ class VolumesToolbar(Gtk.Toolbar): if button.props.active: self.emit('volume-changed', button.mount_point) -def _unmount_activated_cb(self, menu_item, mount): -logging.debug('VolumesToolbar._unmount_activated_cb: %r', mount) -mount.unmount(self.__unmount_cb) - -def __unmount_cb(self, source, result): -logging.debug('__unmount_cb %r %r', source, result) - def _get_button_for_mount(self, mount): mount_point = mount.get_root().get_path() for button in self.get_children(): diff --git a/src/jarabe/view/palettes.py b/src/jarabe/view/palettes.py index 35475d0..89d47db 100644 --- a/src/jarabe/view/palettes.py +++ b/src/jarabe/view/palettes.py @@ -246,11 +246,13 @@ class VolumePalette(Palette): self.connect('popup', self.__popup_cb) def __unmount_activate_cb(self, menu_item): -self._mount.unmount(self.__unmount_cb) +mount_op = Gtk.MountOperation(parent=self.content_box.get_toplevel()) +self._mount.unmount_with_operation(0, mount_op, None, + self.__unmount_cb, None) -def __unmount_cb(self, mount, result): +def __unmount_cb(self, mount, result, user_data): logging.debug('__unmount_cb %r %r', mount, result) -mount.unmount_finish(result) +mount.unmount_with_operation_finish(result) def __popup_cb(self, palette): mount_point = self._mount.get_root().get_path() ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH shell] Views: defocus the search entry by default
Ok, as discussed on irc, the text with a # is a comment not meant to be doc visible. Pushed as 1570f7742e606d09e9fb9079711dd6a43346784d Thanks for the review and testing, Simon On 09/26/2012 01:39 PM, Manuel Quiñones wrote: Wow impressive patch. Is a great usability improvement, and having the placeholder text is nice. Also I don't see the text reset issue that I was seeing in your previous test app, sent to the design thread [1]. About code styling, do we have an agreement mixing docstrings like """this""" and # this ? If so, please push. Thanks! [1] http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039096.html 2012/9/26 Simon Schampijer : From: Simon Schampijer This patch does implement the following behavior: - the search entry in all the views (Home (Favorites and Activity list), Group and Neighborhood) is unfocused by default - the search entry can be focused by clicking in the entry or by starting to type - the search entry contains a hint when unfocused and no search has been entered, the hint is dependent on the View you are in and matches the labels in the View Palettes (Frame), the existing translations have been reused - the learner can defocus the entry by clicking outside somewhere in the view (toolbar or canvas), if no search has been entered the hint will be displayed again if there is a search entered it will remain in effect and the entry will only be unfocused, the latter will help to hide the OSK and see the matches for a particular search - clicking on the clear icon in the entry ('x') the entry will be unfocused again Signed-off-by: Simon Schampijer --- src/jarabe/desktop/activitieslist.py | 4 src/jarabe/desktop/favoritesview.py | 4 src/jarabe/desktop/groupbox.py | 6 +- src/jarabe/desktop/homebox.py| 15 +++ src/jarabe/desktop/homewindow.py | 23 +++ src/jarabe/desktop/meshbox.py| 5 + src/jarabe/desktop/viewcontainer.py | 1 + src/jarabe/desktop/viewtoolbar.py| 6 +- 8 files changed, 58 insertions(+), 6 deletions(-) diff --git a/src/jarabe/desktop/activitieslist.py b/src/jarabe/desktop/activitieslist.py index b830526..1b5ddd7 100644 --- a/src/jarabe/desktop/activitieslist.py +++ b/src/jarabe/desktop/activitieslist.py @@ -375,6 +375,10 @@ class ActivitiesList(Gtk.VBox): self._alert = None self._clear_message_box = None +def grab_focus(self): +# overwrite grab focus in order to grab focus from the parent +self._tree_view.grab_focus() + def set_filter(self, query): matches = self._tree_view.set_filter(query) if matches == 0: diff --git a/src/jarabe/desktop/favoritesview.py b/src/jarabe/desktop/favoritesview.py index b73d016..26a89e6 100644 --- a/src/jarabe/desktop/favoritesview.py +++ b/src/jarabe/desktop/favoritesview.py @@ -85,6 +85,10 @@ class FavoritesBox(Gtk.VBox): def set_resume_mode(self, resume_mode): self._view.set_resume_mode(resume_mode) +def grab_focus(self): +# overwrite grab focus in order to grab focus from the parent +self._view.grab_focus() + def add_alert(self, alert): if self._alert is not None: self.remove_alert() diff --git a/src/jarabe/desktop/groupbox.py b/src/jarabe/desktop/groupbox.py index 3d7c0f3..f916f62 100644 --- a/src/jarabe/desktop/groupbox.py +++ b/src/jarabe/desktop/groupbox.py @@ -41,7 +41,8 @@ class GroupBox(ViewContainer): self._query = '' toolbar.connect('query-changed', self._toolbar_query_changed_cb) - +toolbar.search_entry.connect('icon-press', + self.__clear_icon_pressed_cb) self._friends = {} friends_model = friends.get_model() @@ -72,3 +73,6 @@ class GroupBox(ViewContainer): for icon in self.get_children(): if hasattr(icon, 'set_filter'): icon.set_filter(self._query) + +def __clear_icon_pressed_cb(self, entry, icon_pos, event): +self.grab_focus() diff --git a/src/jarabe/desktop/homebox.py b/src/jarabe/desktop/homebox.py index 8eda213..ed5144b 100644 --- a/src/jarabe/desktop/homebox.py +++ b/src/jarabe/desktop/homebox.py @@ -45,6 +45,8 @@ class HomeBox(Gtk.VBox): toolbar.connect('query-changed', self.__toolbar_query_changed_cb) toolbar.connect('view-changed', self.__toolbar_view_changed_cb) +toolbar.search_entry.connect('icon-press', + self.__clear_icon_pressed_cb) self._list_view.connect('clear-clicked', self.__activitylist_clear_clicked_cb, toolbar) @@ -108,6 +110,17 @@ class HomeBox(Gtk.VBox): def __activitylist_clear_clicked_cb(self, widget, toolbar): toolbar.clear_query() +def __clear_icon_pressed_cb(self, entry, icon_pos, event): +self.grab_focus() + +def grab_
[Sugar-devel] [PATCH shell] Remove unused import forgotten in b46de8e3
Signed-off-by: Manuel Quiñones --- extensions/deviceicon/network.py | 1 - 1 file changed, 1 deletion(-) diff --git a/extensions/deviceicon/network.py b/extensions/deviceicon/network.py index bc929ee..79bc764 100644 --- a/extensions/deviceicon/network.py +++ b/extensions/deviceicon/network.py @@ -38,7 +38,6 @@ from sugar3.graphics.palettemenuitem import PaletteMenuItem from sugar3.graphics.palettemenuitem import PaletteMenuItemSeparator from sugar3.graphics.toolbutton import ToolButton from sugar3.graphics.tray import TrayIcon -from sugar3.graphics.menuitem import MenuItem from sugar3.graphics.icon import Icon from sugar3.graphics import xocolor from sugar3 import profile -- 1.7.11.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH v2 shell] Remove unused MenuItem imports forgotten in b46de8e3 and e92baeeb
Signed-off-by: Manuel Quiñones --- extensions/deviceicon/network.py | 1 - extensions/deviceicon/speaker.py | 1 - 2 files changed, 2 deletions(-) diff --git a/extensions/deviceicon/network.py b/extensions/deviceicon/network.py index bc929ee..79bc764 100644 --- a/extensions/deviceicon/network.py +++ b/extensions/deviceicon/network.py @@ -38,7 +38,6 @@ from sugar3.graphics.palettemenuitem import PaletteMenuItem from sugar3.graphics.palettemenuitem import PaletteMenuItemSeparator from sugar3.graphics.toolbutton import ToolButton from sugar3.graphics.tray import TrayIcon -from sugar3.graphics.menuitem import MenuItem from sugar3.graphics.icon import Icon from sugar3.graphics import xocolor from sugar3 import profile diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py index 4a09e7b..5dab329 100644 --- a/extensions/deviceicon/speaker.py +++ b/extensions/deviceicon/speaker.py @@ -23,7 +23,6 @@ from gi.repository import Gtk from sugar3.graphics import style from sugar3.graphics.icon import get_icon_state, Icon -from sugar3.graphics.menuitem import MenuItem from sugar3.graphics.tray import TrayIcon from sugar3.graphics.palette import Palette from sugar3.graphics.palettemenuitem import PaletteMenuItem -- 1.7.11.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH v2 shell] Remove unused MenuItem imports forgotten in b46de8e3 and e92baeeb
Good, please push. On 09/26/2012 02:15 PM, Manuel Quiñones wrote: Signed-off-by: Manuel Quiñones --- extensions/deviceicon/network.py | 1 - extensions/deviceicon/speaker.py | 1 - 2 files changed, 2 deletions(-) diff --git a/extensions/deviceicon/network.py b/extensions/deviceicon/network.py index bc929ee..79bc764 100644 --- a/extensions/deviceicon/network.py +++ b/extensions/deviceicon/network.py @@ -38,7 +38,6 @@ from sugar3.graphics.palettemenuitem import PaletteMenuItem from sugar3.graphics.palettemenuitem import PaletteMenuItemSeparator from sugar3.graphics.toolbutton import ToolButton from sugar3.graphics.tray import TrayIcon -from sugar3.graphics.menuitem import MenuItem from sugar3.graphics.icon import Icon from sugar3.graphics import xocolor from sugar3 import profile diff --git a/extensions/deviceicon/speaker.py b/extensions/deviceicon/speaker.py index 4a09e7b..5dab329 100644 --- a/extensions/deviceicon/speaker.py +++ b/extensions/deviceicon/speaker.py @@ -23,7 +23,6 @@ from gi.repository import Gtk from sugar3.graphics import style from sugar3.graphics.icon import get_icon_state, Icon -from sugar3.graphics.menuitem import MenuItem from sugar3.graphics.tray import TrayIcon from sugar3.graphics.palette import Palette from sugar3.graphics.palettemenuitem import PaletteMenuItem ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Read-101
Yeah, we just need Aleksey to review/push my patch :) On Wednesday, 26 September 2012, Gonzalo Odiard wrote: > Read crash with the last gstreamer-espeak plugin > dnarvaez is looking at the plugin, and I am looking at the Read activity. > I hope solve it soon and upload version 102 > > Gonzalo > > On Tue, Sep 25, 2012 at 7:39 PM, Peter Robinson > > > wrote: > >> Any chance of tarballs ;-) >> >> On Thu, Sep 13, 2012 at 6:33 PM, Sugar Labs Activities >> > 'activit...@sugarlabs.org');>> wrote: >> > Activity Homepage: >> > http://activities.sugarlabs.org/addon/4028 >> > >> > Sugar Platform: >> > 0.98 - 0.98 >> > >> > Download Now: >> > http://activities.sugarlabs.org/downloads/file/28216/read-101.xo >> > >> > Release notes: >> > Improve display of text files >> > Use a scrollbar to navigate the entire book in txt books. >> > Add touch event management to text files backend >> > Implement kindle like change page in epub backend >> > Page number should be zero based, fix epub backend - SL #3864 >> > Keep the text position in the epub files - SL #3861 >> > Enable the use of arrow keys in the page number entry - SL #3863 >> > Fix index management in epub files - SL #3853 >> > Enable touch kindle like interaction in pdf backend >> > Disable code to read index in pdf files >> > >> > >> > >> > Sugar Labs Activities >> > http://activities.sugarlabs.org >> > >> > ___ >> > Sugar-devel mailing list >> > Sugar-devel@lists.sugarlabs.org > 'Sugar-devel@lists.sugarlabs.org');> >> > http://lists.sugarlabs.org/listinfo/sugar-devel >> ___ >> Sugar-devel mailing list >> Sugar-devel@lists.sugarlabs.org > 'Sugar-devel@lists.sugarlabs.org');> >> http://lists.sugarlabs.org/listinfo/sugar-devel >> > > -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [ASLO] Release Get Books-14
Activity Homepage: http://activities.sugarlabs.org/addon/4304 Sugar Platform: 0.98 - 0.98 Download Now: http://activities.sugarlabs.org/downloads/file/28234/get_books-14.xo Release notes: Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Read-101
On Wed, Sep 26, 2012 at 1:44 PM, Daniel Narvaez wrote: > Yeah, we just need Aleksey to review/push my patch :) for gst-espeak? If we want to get wider testing of the patch I can patch the Fedora package for F-18 so we can test it wider for the next build. Just point me at the patch I need to apply. Presumably it's also ported to gst1 too? Peter > On Wednesday, 26 September 2012, Gonzalo Odiard wrote: >> >> Read crash with the last gstreamer-espeak plugin >> dnarvaez is looking at the plugin, and I am looking at the Read activity. >> I hope solve it soon and upload version 102 >> >> Gonzalo >> >> On Tue, Sep 25, 2012 at 7:39 PM, Peter Robinson >> wrote: >>> >>> Any chance of tarballs ;-) >>> >>> On Thu, Sep 13, 2012 at 6:33 PM, Sugar Labs Activities >>> wrote: >>> > Activity Homepage: >>> > http://activities.sugarlabs.org/addon/4028 >>> > >>> > Sugar Platform: >>> > 0.98 - 0.98 >>> > >>> > Download Now: >>> > http://activities.sugarlabs.org/downloads/file/28216/read-101.xo >>> > >>> > Release notes: >>> > Improve display of text files >>> > Use a scrollbar to navigate the entire book in txt books. >>> > Add touch event management to text files backend >>> > Implement kindle like change page in epub backend >>> > Page number should be zero based, fix epub backend - SL #3864 >>> > Keep the text position in the epub files - SL #3861 >>> > Enable the use of arrow keys in the page number entry - SL #3863 >>> > Fix index management in epub files - SL #3853 >>> > Enable touch kindle like interaction in pdf backend >>> > Disable code to read index in pdf files >>> > >>> > >>> > >>> > Sugar Labs Activities >>> > http://activities.sugarlabs.org >>> > >>> > ___ >>> > Sugar-devel mailing list >>> > Sugar-devel@lists.sugarlabs.org >>> > http://lists.sugarlabs.org/listinfo/sugar-devel >>> ___ >>> Sugar-devel mailing list >>> Sugar-devel@lists.sugarlabs.org >>> http://lists.sugarlabs.org/listinfo/sugar-devel >> >> > > > -- > Daniel Narvaez > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On 26 September 2012 09:28, Peter Robinson wrote: > It worked fine in v35, the only change was to bump the spec version, > also there's other Activities that I built fine at the same time. It looks like v35 uses gtk3, v36 uses gtk2. The spec depends on sugar-toolkit-gtk3 so v36 fails. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [RELEASE] sugar-0.97.5
The "oh we have text in the UI" release. == Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar/sugar-0.97.5.tar.bz2 == News == * Release 0.97.5 (Simon Schampijer) * Remove unused MenuItem imports forgotten in b46de8e3 and e92baeeb (Manuel Quiñones) * Add src/jarabe/desktop/homewindow.py to po/POTFILES.in (Simon Schampijer) * Update Sucrose version for upcoming 0.97.4 (Simon Schampijer) * Fix external media mounting, SL #3911 (Daniel Drake) * Views: defocus the search entry by default (Simon Schampijer) * Finish port of palettes in network device icon (Manuel Quiñones) * Fix layout of Clear search button in Journal and Activity List - SL #3809 (Manuel Quiñones) * Get back text visibility in Network section of the Control Panel (Manuel Quiñones) * Fix layout of Language and Modem sections in the Control Panel - SL #3902 (Manuel Quiñones) * Gio.content_type_guess now returns a dict instead of a str (Gonzalo Odiard) * Journal details view, fix get_text method in text buffers - SL #3920 (Manuel Quiñones) * Fix realize callback in ViewSource (Manuel Quiñones) * Commit from Sugar Labs: Translation System by user cjl.: 387 of 387 messages translated (0 fuzzy). (Pootle daemon) * Commit from Sugar Labs: Translation System by user cjl.: 387 of 387 messages translated (0 fuzzy). (Pootle daemon) * Commit from Sugar Labs: Translation System by user cjl.: 387 of 387 messages translated (0 fuzzy). (Pootle daemon) * Commit from Sugar Labs: Translation System by user cjl.: 387 of 387 messages translated (0 fuzzy). (Pootle daemon) ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [RELEASE] sugar-toolkit-gtk3-0.97.4
The "encode your code" release. == Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar-toolkit-gtk3/sugar-toolkit-gtk3-0.97.4.tar.bz2 == News == * Release 0.97.4 (Simon Schampijer) * Set default python encoding to utf-8 (Gonzalo Odiard) * Add management of summary property to the activity.info file (Gonzalo Odiard) * Fix radiopalette due to api change in toolbotton (Gonzalo Odiard) * Commit from Sugar Labs: Translation System by user cjl.: 40 of 40 messages translated (0 fuzzy). (Pootle daemon) ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 9:19 AM, Daniel Narvaez wrote: > On 26 September 2012 09:28, Peter Robinson wrote: >> It worked fine in v35, the only change was to bump the spec version, >> also there's other Activities that I built fine at the same time. > > It looks like v35 uses gtk3, v36 uses gtk2. The spec depends on > sugar-toolkit-gtk3 so v36 fails. I've been using even numbers for gtk2 and odd numbers for gtk3 since the dotted number scheme doesn't work on all versions of Sugar. -walter > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel -- Walter Bender Sugar Labs http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Grassroots-l] A simple way for teachers to review children works
Lionel, Have you tried the Portfolio Activity? teachers can ask the students to start putting together their work of the wee, reflecting on what they did and learn, and organizing a portfolio. The Portfolio can be shared with others (teachers and other students) for comments. FInally, the Portfolio can be saved as a PDF (or a movie, not developed yet) for teachers to collect. After reviewing, teachers may ask for individual objects to loo deeper. http://activities.sugarlabs.org/en-US/sugar/addon/4437 I hope this helps! Claudia On Tue, Sep 25, 2012 at 3:51 PM, wrote: > Hi all, > > > > One of the main feedback from teachers in our small XO deployment at > Saint-Denis (a poor suburb of Paris) is related to children works review. > > The teacher would like a way to control and review works of children. > > > > Generally they ask to children to write a text or something else and they > want a way to check if children have completed the work. > > They try to use an USB key but it’s too long (about fifteen minutes at > least). More, because we’ve got only 25 XO for 50 children, two children > share the same XO and there is a risk that a child delete the work of the > previous one (it already happens). > > I don’t know if it could help here but we don’t have a XS server installed. > BTW to be honest, I’m afraid than if we have one teachers don’t have > knowledge to use it. > > > > Because each XO has an Internet connection, we are thinking to develop a > small activity to allow children to upload their works to a web server where > teachers could retrieve it. > > - Do you know how other deployments handle teachers review ? > > - Does the XS could be a solution to this problem ? > > - Is there any existing activity matching the idea to upload > content to a web server ? > > > > Any advice is welcome. > > > > Best regards from France. > > > > Lionel. > > > > > ___ > Grassroots mailing list > grassro...@lists.laptop.org > http://lists.laptop.org/listinfo/grassroots > -- Claudia Urrea, PhD Director of Learning OLPCA ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [RELEASE] sugar-artwork-0.97.4
== Source == http://download.sugarlabs.org/sources/sucrose/glucose/sugar-artwork/sugar-artwork-0.97.4.tar.bz2 == News == * Release 0.97.4 (Manuel Quiñones) * Fix color and background-color for GtkWindow - SL #3917 (Manuel Quiñones) * Add the filename of last three added icons to the Makefile, so they actually get installed (Manuel Quiñones)pa ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 2:30 PM, Walter Bender wrote: > On Wed, Sep 26, 2012 at 9:19 AM, Daniel Narvaez wrote: >> On 26 September 2012 09:28, Peter Robinson wrote: >>> It worked fine in v35, the only change was to bump the spec version, >>> also there's other Activities that I built fine at the same time. >> >> It looks like v35 uses gtk3, v36 uses gtk2. The spec depends on >> sugar-toolkit-gtk3 so v36 fails. > > I've been using even numbers for gtk2 and odd numbers for gtk3 since > the dotted number scheme doesn't work on all versions of Sugar. Oh! That wasn't overly clear. Why don't you bump the gtk3 release to 100 and start from there or something to make it perfectly clear what's what with a reasonable designator? The odd/even is none obvious. I would have also thought you would have versions 0.82 - 0.94 for gtk2 and > 0.96 for the gtk3 release. I'll await v37 (or what ever the next gtk3 release is than. Peter Peter ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 9:35 AM, Peter Robinson wrote: > On Wed, Sep 26, 2012 at 2:30 PM, Walter Bender > wrote: >> On Wed, Sep 26, 2012 at 9:19 AM, Daniel Narvaez wrote: >>> On 26 September 2012 09:28, Peter Robinson wrote: It worked fine in v35, the only change was to bump the spec version, also there's other Activities that I built fine at the same time. >>> >>> It looks like v35 uses gtk3, v36 uses gtk2. The spec depends on >>> sugar-toolkit-gtk3 so v36 fails. >> >> I've been using even numbers for gtk2 and odd numbers for gtk3 since >> the dotted number scheme doesn't work on all versions of Sugar. > > Oh! That wasn't overly clear. Why don't you bump the gtk3 release to > 100 and start from there or something to make it perfectly clear > what's what with a reasonable designator? The odd/even is none > obvious. I would have also thought you would have versions 0.82 - 0.94 > for gtk2 and > 0.96 for the gtk3 release. I'll await v37 (or what ever > the next gtk3 release is than. Hmm. 100 is not large enough, whereas I am already up to Turtle Blocks v160 :P But I don't know why even/odd is any less obvious than >< 100. I am not sure how to proceed. -walter > > Peter > > Peter -- Walter Bender Sugar Labs http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Read-101
On 26 September 2012 15:19, Peter Robinson wrote: > On Wed, Sep 26, 2012 at 1:44 PM, Daniel Narvaez wrote: >> Yeah, we just need Aleksey to review/push my patch :) > > for gst-espeak? If we want to get wider testing of the patch I can > patch the Fedora package for F-18 so we can test it wider for the next > build. Just point me at the patch I need to apply. Presumably it's > also ported to gst1 too? For gst-plugins-espeak, yeah. http://lists.sugarlabs.org/archive/sugar-devel/2012-September/039810.html It fixes a regression in the 1.0 port. I'm not sure what's the situation with F-18. Is gstreamer 1.0 going to be shipped with it? Latest sugar depends on it. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 2:40 PM, Walter Bender wrote: > On Wed, Sep 26, 2012 at 9:35 AM, Peter Robinson wrote: >> On Wed, Sep 26, 2012 at 2:30 PM, Walter Bender >> wrote: >>> On Wed, Sep 26, 2012 at 9:19 AM, Daniel Narvaez wrote: On 26 September 2012 09:28, Peter Robinson wrote: > It worked fine in v35, the only change was to bump the spec version, > also there's other Activities that I built fine at the same time. It looks like v35 uses gtk3, v36 uses gtk2. The spec depends on sugar-toolkit-gtk3 so v36 fails. >>> >>> I've been using even numbers for gtk2 and odd numbers for gtk3 since >>> the dotted number scheme doesn't work on all versions of Sugar. >> >> Oh! That wasn't overly clear. Why don't you bump the gtk3 release to >> 100 and start from there or something to make it perfectly clear >> what's what with a reasonable designator? The odd/even is none >> obvious. I would have also thought you would have versions 0.82 - 0.94 >> for gtk2 and > 0.96 for the gtk3 release. I'll await v37 (or what ever >> the next gtk3 release is than. > > Hmm. 100 is not large enough, whereas I am already up to Turtle Blocks v160 :P > But I don't know why even/odd is any less obvious than >< 100. > I am not sure how to proceed. I suppose the question is more whether if you make 100 on the gtk2 package before you kill off the gtk2 version. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Read-101
On Wed, Sep 26, 2012 at 2:42 PM, Daniel Narvaez wrote: > On 26 September 2012 15:19, Peter Robinson wrote: >> On Wed, Sep 26, 2012 at 1:44 PM, Daniel Narvaez wrote: >>> Yeah, we just need Aleksey to review/push my patch :) >> >> for gst-espeak? If we want to get wider testing of the patch I can >> patch the Fedora package for F-18 so we can test it wider for the next >> build. Just point me at the patch I need to apply. Presumably it's >> also ported to gst1 too? > > For gst-plugins-espeak, yeah. > > http://lists.sugarlabs.org/archive/sugar-devel/2012-September/039810.html > > It fixes a regression in the 1.0 port. I'm not sure what's the > situation with F-18. Is gstreamer 1.0 going to be shipped with it? > Latest sugar depends on it. Yes it is, it's also a core dependency for gnome 3.6 and 1.0.o is already shipping in F-18 repos at the moment :) Peter ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On 26 September 2012 15:40, Walter Bender wrote: > Hmm. 100 is not large enough, whereas I am already up to Turtle Blocks v160 :P > But I don't know why even/odd is any less obvious than >< 100. > I am not sure how to proceed. Maybe start using dotted numbers for the gtk3 version only? ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
> > >> I've been using even numbers for gtk2 and odd numbers for gtk3 since > >> the dotted number scheme doesn't work on all versions of Sugar. > Probably even and odd numbers will not work for users. If they update, will receive a gtk2 version, and after that a gtk3, and so, right? Dotted versions works with 10.1.3 and bigger, is not all, but mostly. That was what we talked the last time the topic was discussed, do you have another information? Should be good be consistent here, if every maintainer have a different criteria is worst for our users. Gonzalo > > > > Oh! That wasn't overly clear. Why don't you bump the gtk3 release to > > 100 and start from there or something to make it perfectly clear > > what's what with a reasonable designator? The odd/even is none > > obvious. I would have also thought you would have versions 0.82 - 0.94 > > for gtk2 and > 0.96 for the gtk3 release. I'll await v37 (or what ever > > the next gtk3 release is than. > > Hmm. 100 is not large enough, whereas I am already up to Turtle Blocks > v160 :P > But I don't know why even/odd is any less obvious than >< 100. > I am not sure how to proceed. > > -walter > > > > Peter > > > > Peter > > > > -- > Walter Bender > Sugar Labs > http://www.sugarlabs.org > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Read-101
On 26 September 2012 15:46, Peter Robinson wrote: > Yes it is, it's also a core dependency for gnome 3.6 and 1.0.o is > already shipping in F-18 repos at the moment :) Ok, so it would be great to start testing the 1.0 port of gst-plugins-espeak in F-18. It's several commits though, I guess the easiest would be for Aleksey to make a release (after pushing the metadata patch). ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 10:48 AM, Daniel Narvaez wrote: > On 26 September 2012 15:40, Walter Bender wrote: > > Hmm. 100 is not large enough, whereas I am already up to Turtle Blocks > v160 :P > > But I don't know why even/odd is any less obvious than >< 100. > > I am not sure how to proceed. > > Maybe start using dotted numbers for the gtk3 version only? > Doesn't solve the problem. You will have bigger version numbers with the gtk2 version than the gtk3 version. Gonzalo > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [DESIGN] Chage in filter in home view
The Search in the home, used to search activities, in the favorites or in the list view, is cleaned after one activity starts and is closed. Is a recent change, and is very annoying, why is the reason behind this change? Should I fill a ticket or is a design decision? Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Read-101
2012/9/26 Daniel Narvaez : > On 26 September 2012 15:46, Peter Robinson wrote: >> Yes it is, it's also a core dependency for gnome 3.6 and 1.0.o is >> already shipping in F-18 repos at the moment :) > > Ok, so it would be great to start testing the 1.0 port of > gst-plugins-espeak in F-18. It's several commits though, I guess the > easiest would be for Aleksey to make a release (after pushing the > metadata patch). We have a problem with the Speech device icon too: http://bugs.sugarlabs.org/ticket/3955 -- .. manuq .. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On Wed, Sep 26, 2012 at 9:48 AM, Daniel Narvaez wrote: > On 26 September 2012 15:40, Walter Bender wrote: >> Hmm. 100 is not large enough, whereas I am already up to Turtle Blocks v160 >> :P >> But I don't know why even/odd is any less obvious than >< 100. >> I am not sure how to proceed. > > Maybe start using dotted numbers for the gtk3 version only? That is an interesting idea. And as long as we list the dotted number versions as 0.96+ then older Sugars will not look at them. So we could have a whole number for gtk2 (< 0.96) and dotted number for gtk3. Might work. But needs testing. -- Walter Bender Sugar Labs http://www.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [ASLO] Release Typing Turtle-30
Activity Homepage: http://activities.sugarlabs.org/addon/4026 Sugar Platform: 0.98 - 0.98 Download Now: http://activities.sugarlabs.org/downloads/file/28235/typing_turtle-30.xo Release notes: Add summary information Port to Gtk3 (Manuel Kaufmann) Updated translations Fix spanish lessons words for baloons game Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On 26 September 2012 15:52, Gonzalo Odiard wrote: > Doesn't solve the problem. > You will have bigger version numbers with the gtk2 version than the gtk3 > version. We could hack aslo to turn version x into 0.x for platform versions < 0.98. If I'm not missing something there is no real handling of the version number client side. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
How will map the version number to rpms? Gonzalo On Wed, Sep 26, 2012 at 12:09 PM, Daniel Narvaez wrote: > On 26 September 2012 15:52, Gonzalo Odiard wrote: > > Doesn't solve the problem. > > You will have bigger version numbers with the gtk2 version than the gtk3 > > version. > > We could hack aslo to turn version x into 0.x for platform versions < > 0.98. If I'm not missing something there is no real handling of the > version number client side. > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
On 26 September 2012 16:02, Walter Bender wrote: > On Wed, Sep 26, 2012 at 9:48 AM, Daniel Narvaez wrote: >> On 26 September 2012 15:40, Walter Bender wrote: >>> Hmm. 100 is not large enough, whereas I am already up to Turtle Blocks v160 >>> :P >>> But I don't know why even/odd is any less obvious than >< 100. >>> I am not sure how to proceed. >> >> Maybe start using dotted numbers for the gtk3 version only? > > That is an interesting idea. And as long as we list the dotted number > versions as 0.96+ then older Sugars will not look at them. So we could > have a whole number for gtk2 (< 0.96) and dotted number for gtk3. > Might work. But needs testing. As Gonzalo pointed out the problem is that latest sugar will see old gtk2 versions of the activity as newer than dotted recent ones. I'm getting convinced we should just use a very high version number (like 1000.0) to avoid that. Ugly but very straightforward. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Abacus-36
Oh, I haven't seen anything dealing with rpms in the updater code (maybe it's olpc only?). On 26 September 2012 17:18, Gonzalo Odiard wrote: > How will map the version number to rpms? > > Gonzalo > > > On Wed, Sep 26, 2012 at 12:09 PM, Daniel Narvaez > wrote: >> >> On 26 September 2012 15:52, Gonzalo Odiard wrote: >> > Doesn't solve the problem. >> > You will have bigger version numbers with the gtk2 version than the gtk3 >> > version. >> >> We could hack aslo to turn version x into 0.x for platform versions < >> 0.98. If I'm not missing something there is no real handling of the >> version number client side. > > -- Daniel Narvaez ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH shell] Journal: defocus the search entry by default
Do the same behavior as in the shell views, explained in detail in commit 1570f774 . - make MainToolBox search_entry a public attribute to make it visible from JournalActivity - as a consequence of the previous item, remove give_entry_focus method from MainToolBox and use the attribute directly Signed-off-by: Manuel Quiñones --- src/jarabe/journal/journalactivity.py | 12 ++-- src/jarabe/journal/journaltoolbox.py | 27 +-- 2 files changed, 23 insertions(+), 16 deletions(-) diff --git a/src/jarabe/journal/journalactivity.py b/src/jarabe/journal/journalactivity.py index 23a0b38..1ecb6e3 100644 --- a/src/jarabe/journal/journalactivity.py +++ b/src/jarabe/journal/journalactivity.py @@ -173,6 +173,7 @@ class JournalActivity(JournalWindow): def _setup_main_view(self): self._main_toolbox = MainToolbox() self._main_view = Gtk.VBox() +self._main_view.set_can_focus(True) self._list_view = ListView() self._list_view.connect('detail-clicked', self.__detail_clicked_cb) @@ -188,6 +189,8 @@ class JournalActivity(JournalWindow): self._main_view.pack_start(self._volumes_toolbar, False, True, 0) self._main_toolbox.connect('query-changed', self._query_changed_cb) +self._main_toolbox.search_entry.connect('icon-press', +self.__search_icon_pressed_cb) self._main_toolbox.set_mount_point('/') def _setup_secondary_view(self): @@ -203,6 +206,9 @@ class JournalActivity(JournalWindow): self._detail_view.show() def _key_press_event_cb(self, widget, event): +if not self._main_toolbox.search_entry.has_focus(): +self._main_toolbox.search_entry.grab_focus() + keyname = Gdk.keyval_name(event.keyval) if keyname == 'Escape': self.show_main_view() @@ -220,6 +226,9 @@ class JournalActivity(JournalWindow): self._list_view.update_with_query(query) self.show_main_view() +def __search_icon_pressed_cb(self, entry, icon_pos, event): +self._main_view.grab_focus() + def show_main_view(self): if self.toolbar_box != self._main_toolbox: self.set_toolbar_box(self._main_toolbox) @@ -279,7 +288,6 @@ class JournalActivity(JournalWindow): self.show_main_view() def _focus_in_event_cb(self, window, event): -self.search_grab_focus() self._list_view.update_dates() def _check_for_bundle(self, object_id): @@ -319,7 +327,7 @@ class JournalActivity(JournalWindow): model.write(metadata) def search_grab_focus(self): -self._main_toolbox.give_entry_focus() +self._main_toolbox.search_entry.grab_focus() def __window_state_event_cb(self, window, event): logging.debug('window_state_event_cb %r', self) diff --git a/src/jarabe/journal/journaltoolbox.py b/src/jarabe/journal/journaltoolbox.py index a4f80fc..09d8a31 100644 --- a/src/jarabe/journal/journaltoolbox.py +++ b/src/jarabe/journal/journaltoolbox.py @@ -76,14 +76,16 @@ class MainToolbox(ToolbarBox): self._mount_point = None -self._search_entry = iconentry.IconEntry() -self._search_entry.set_icon_from_name(iconentry.ICON_ENTRY_PRIMARY, - 'system-search') -self._search_entry.connect('activate', self._search_entry_activated_cb) -self._search_entry.connect('changed', self._search_entry_changed_cb) -self._search_entry.add_clear_button() +self.search_entry = iconentry.IconEntry() +self.search_entry.set_icon_from_name(iconentry.ICON_ENTRY_PRIMARY, + 'system-search') +text = _('Search in %s') % _('Journal') +self.search_entry.set_placeholder_text(text) +self.search_entry.connect('activate', self._search_entry_activated_cb) +self.search_entry.connect('changed', self._search_entry_changed_cb) +self.search_entry.add_clear_button() self._autosearch_timer = None -self._add_widget(self._search_entry, expand=True) +self._add_widget(self.search_entry, expand=True) self._favorite_button = ToggleToolButton('emblem-favorite') self._favorite_button.connect('toggled', @@ -121,9 +123,6 @@ class MainToolbox(ToolbarBox): self.refresh_filters() -def give_entry_focus(self): -self._search_entry.grab_focus() - def _get_when_search_combo(self): when_search = ComboBox() when_search.append_item(_ACTION_ANYTIME, _('Anytime')) @@ -188,8 +187,8 @@ class MainToolbox(ToolbarBox): date_from, date_to = self._get_date_range() query['timestamp'] = {'start': date_from, 'end': date_to} -if self._search_entry.props.text: -text = self._search_entry.props.text.strip() +if self.search_entry.props.text: +text = self.s
Re: [Sugar-devel] [PATCH 0/7] datastore: handle ENOSPC gracefully
On Sat, Sep 22, 2012 at 10:09 PM, Martin Langhoff wrote: > On Fri, Sep 21, 2012 at 11:36 AM, Martin Langhoff > wrote: >> Reviews are boring. Testing is more fun! rpms for ARM at Reviews are boring, but necessary. As these patches have seen some reviews, and the ml is a bit awkward for tracking those, I've pushed a 'pu' (proposed updates) branch at http://dev.laptop.org/git/users/martin/sugar-datastore/ I have posted all the patches to the mailing list, and will continue to do so. The pu branch will have the latest, freshest set of patches (so: it rewinds/rebases as needed). m -- martin.langh...@gmail.com mar...@laptop.org -- Software Architect - OLPC - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [ASLO] Release StopWatch-18
Activity Homepage: http://activities.sugarlabs.org/addon/4263 Sugar Platform: 0.96 - 0.98 Download Now: http://activities.sugarlabs.org/downloads/file/28236/stopwatch-18.xo Release notes: *Change _shared_activity by shared_activity (fdane...@activitycentral.com), enabling sharing. Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [ASLO] Release Distance-34
Activity Homepage: http://activities.sugarlabs.org/addon/4264 Sugar Platform: 0.96 - 0.98 Download Now: http://activities.sugarlabs.org/downloads/file/28237/distance-34.xo Release notes: *Change _shared_activity by shared_activity (fdane...@activitycentral.com), enabling sharing. Sugar Labs Activities http://activities.sugarlabs.org ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release Distance-34
Please, remember add summary information in the activity.info file. Gonzalo On Wed, Sep 26, 2012 at 2:03 PM, Sugar Labs Activities < activit...@sugarlabs.org> wrote: > Activity Homepage: > http://activities.sugarlabs.org/addon/4264 > > Sugar Platform: > 0.96 - 0.98 > > Download Now: > http://activities.sugarlabs.org/downloads/file/28237/distance-34.xo > > Release notes: > *Change _shared_activity by shared_activity (fdane...@activitycentral.com), > enabling sharing. > > > > Sugar Labs Activities > http://activities.sugarlabs.org > > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [ASLO] Release StopWatch-18
Please, remember add summary information in the activity.info file. Gonzalo On Wed, Sep 26, 2012 at 1:39 PM, Sugar Labs Activities < activit...@sugarlabs.org> wrote: > Activity Homepage: > http://activities.sugarlabs.org/addon/4263 > > Sugar Platform: > 0.96 - 0.98 > > Download Now: > http://activities.sugarlabs.org/downloads/file/28236/stopwatch-18.xo > > Release notes: > *Change _shared_activity by shared_activity (fdane...@activitycentral.com), > enabling sharing. > > > Sugar Labs Activities > http://activities.sugarlabs.org > > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Chage in filter in home view
Hi Gonzalo, On 26 Sep 2012, at 14:55, Gonzalo Odiard wrote: > The Search in the home, used to search activities, > in the favorites or in the list view, is cleaned after one activity starts > and is closed. > Is a recent change, and is very annoying, why is the reason behind this > change? > Should I fill a ticket or is a design decision? We did discuss it in the mailing list here [1], and then was re confirmed by Manuq after the OLPC-A team meeting in the separate mail thread (between us and Martin) where we were checking off tasks (should be in you inbox dated September 14th, Subject: Design meeting). There were three choices if I remember: 1) make the search query 'sticky' between views so that a search would be active from one view to the next 2) make each view's search query cache a copy of the search (this is the behaviour we had before) 3) start with a clear search query when you expose/switch views (this is the change that just landed) Behaviour (1) was rejected, as a search query doesn't often make sense in all views (searching for an AP or Buddy in Neighbourhood is not much use when you switch to the Home Favourites view). Option (2) has given us some mischief when users enter a query (on-purpose, accidentally, or unknowingly) and later return to a view and wonder why icons are greyed out, or even missing in the case of the Home list view. Option (3) seemed to provide the more consistent behaviour for users later returning to a view after having left it in a search query. Can you describe how it is annoying, what were you trying to do with search, was it a complicated search string you needed to preserve, or a result state you particularly wanted to keep? UI freeze is not for another couple of weeks, reports/feedback on feature chenges is most wanted! :) Regards, --Gary [1] http://lists.sugarlabs.org/archive/sugar-devel/2012-August/039342.html > > Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Chage in filter in home view
2012/9/26 Gary Martin : > Behaviour (1) was rejected, as a search query doesn't often make sense in > all views (searching for an AP or Buddy in Neighbourhood is not much use > when you switch to the Home Favourites view). And when you open an activity and return to the home view? Developing and testing, when I use the home list view and use the filter to find my activity, I have to write the activity name all the times I need to run it... ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH sugar-artwork] Set 'gtk-button-images' to True in settings.ini - SL #3904 #3725
For the same reason we set 'gtk-menu-images' in commit 6ad1090a . In the absence of an Xsettings manager, GTK+ reads default values for settings from settings.ini . Signed-off-by: Manuel Quiñones --- gtk3/theme/settings.ini.em | 1 + 1 file changed, 1 insertion(+) diff --git a/gtk3/theme/settings.ini.em b/gtk3/theme/settings.ini.em index 511aa06..7780f8f 100644 --- a/gtk3/theme/settings.ini.em +++ b/gtk3/theme/settings.ini.em @@ -14,6 +14,7 @@ icon_large = icon_base * 5 [Settings] gtk-auto-mnemonics = 1 gtk-menu-images = 1 +gtk-button-images = 1 gtk-toolbar-style = GTK_TOOLBAR_ICONS gtk-cursor-theme-name = sugar -- 1.7.11.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Chage in filter in home view
Hey Daniel, On 26 Sep 2012, at 18:50, "S. Daniel Francis" wrote: > 2012/9/26 Gary Martin : >> Behaviour (1) was rejected, as a search query doesn't often make sense in >> all views (searching for an AP or Buddy in Neighbourhood is not much use >> when you switch to the Home Favourites view). > > And when you open an activity and return to the home view? So yes, the new behaviour would clear the search when you returned later. > Developing and testing, when I use the home list view and use the > filter to find my activity, I have to write the activity name all the > times I need to run it... Yes that is a fair use case, especially if you have lots of activities installed, and I do wish we had more active developers like you! :) Can I ask, do you spend more time working in Sugar's home list view, or the home favourite view? Would making your test activity a Favourite be a practical option? Again, this depends how many Activities you already have favourited ;) Regards, --Gary ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Chage in filter in home view
> From: garycmar...@googlemail.com > Date: Wed, 26 Sep 2012 19:22:56 +0100 > To: fran...@sugarlabs.org > CC: gonz...@laptop.org; sugar-devel@lists.sugarlabs.org; ma...@laptop.org > Subject: Re: [Sugar-devel] [DESIGN] Chage in filter in home view > > Hey Daniel, > > On 26 Sep 2012, at 18:50, "S. Daniel Francis" wrote: > > > 2012/9/26 Gary Martin : > >> Behaviour (1) was rejected, as a search query doesn't often make sense in > >> all views (searching for an AP or Buddy in Neighbourhood is not much use > >> when you switch to the Home Favourites view). > > > > And when you open an activity and return to the home view? > > So yes, the new behaviour would clear the search when you returned later. > > > Developing and testing, when I use the home list view and use the > > filter to find my activity, I have to write the activity name all the > > times I need to run it... > > Yes that is a fair use case, especially if you have lots of activities > installed, and I do wish we had more active developers like you! :) Can I > ask, do you spend more time working in Sugar's home list view, or the home > favourite view? Would making your test activity a Favourite be a practical > option? Again, this depends how many Activities you already have favourited > ;) In my case, I only have 5 or 6 favorites activities. There are some that never use/testWhen I try to test one (or develop), I search once in the list view, and after,use the favorites view. > > Regards, > --Gary > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Chage in filter in home view
> > > Can you describe how it is annoying, what were you trying to do with > search, was it a complicated search string you needed to preserve, or a > result state you particularly wanted to keep? UI freeze is not for another > couple of weeks, reports/feedback on feature chenges is most wanted! :) > > I am working with any activity, then, use the filter to found it in the home, in the favorites or in the list, start the activity, and when close the activity, the search is cleaned. If I want use the same activity again, need enter the filter again. I have not switched views. The filter should be preserved. In fact, the filter should be preserved, but not shared, for every view. Example: I can filter the Read activity, go to neighbour view, the filter is empty, search for a access point "My School", go back to the home, and the filter should keep the activity Read filtered. Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Chage in filter in home view
2012/9/26 Gary Martin : > Yes that is a fair use case, especially if you have lots of activities > installed, > and I do wish we had more active developers like you! :) > Can I ask, do you spend more time working in Sugar's home list view, > or the home favourite view? Would making your test activity a Favourite > be a practical option? Again, this depends how many Activities you already > have favourited ;) Now I'm using the list view because the list view in Gtk3 is more stable than the favourite view. When I say unstable I mean that sometimes I try to start an activity and nothing happens. I didn't check the logs and I'm a few busy working in other things, but when I have time I'm going to report some issues. Cheers. ~danielf ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] RFC: Optimizer: simplify, avoid hashing files, remove 'checksums' dir
This patch changes the strategy used by optimize. Instead of maintaining a 'checksum' field for every file, and maintaining metadata about whether they are linked in the 'checksums' dir, it will only ever hash files that match size _exactly_ with a new file. A DS that does not see 2 files of identical size will never hash any file. - Allows the datastore to handle large files (downloads, video captures) without paying a high 'hashing' price. - Removes the 'checksums' dirtree; which was redundant: we can evaluate whether two files are hardlinked comparing their inode. - There are no users of 'checksum' metadata field out of DS, so we remove it completely. - Removal of checksum metadata and the 'checksums' dirtree means less risk of out-of-date metadata. Caveats: - Assumes no program is producing large files of identical size. On the XO, this is true. Some file formats with no compression could trigger unwelcome hashing (ie: an activity that saves TIFF or BMP files). - The optimizer should run in a separate process, to avoid making the DS unresponsive. Was written to avoid races, but would need to flock() the file between hashing it and hardlinking it. I need to read up on forking a long-running process from a dbus service. --- Background: reviewing DS code and datastuctures, the checksums dirtree and strategy in optimize.py looked problematic to me. If I am saving a large video, I don't want it hashed (expensive op) if I can (cheaply) check that no other file is the same size. I could retain the 'checksum' metadata field -- and add some assurances that it does not get stale. It would help with large and identical-sized files, such as screenshots, which may otherwise end up hashed more than once, perhaps many times. --- src/carquinyol/datastore.py |4 - src/carquinyol/filestore.py | 12 --- src/carquinyol/layoutmanager.py |9 -- src/carquinyol/metadatastore.py |4 +- src/carquinyol/optimizer.py | 225 ++- 5 files changed, 106 insertions(+), 148 deletions(-) diff --git a/src/carquinyol/datastore.py b/src/carquinyol/datastore.py index a859dfe..0ee70d2 100644 --- a/src/carquinyol/datastore.py +++ b/src/carquinyol/datastore.py @@ -362,9 +362,6 @@ class DataStore(dbus.service.Object): self._metadata_store.store(uid, props) self._index_store.store(uid, props) -if os.path.exists(self._file_store.get_file_path(uid)) and \ -(not file_path or os.path.exists(file_path)): -self._optimizer.remove(uid) self._file_store.store(uid, file_path, transfer_ownership, lambda * args: self._update_completion_cb(async_cb, async_err_cb, @@ -489,7 +486,6 @@ class DataStore(dbus.service.Object): self._mark_dirty() try: entry_path = layoutmanager.get_instance().get_entry_path(uid) -self._optimizer.remove(uid) self._index_store.delete(uid) self._file_store.delete(uid) self._metadata_store.delete(uid) diff --git a/src/carquinyol/filestore.py b/src/carquinyol/filestore.py index 0b34b69..38a4018 100644 --- a/src/carquinyol/filestore.py +++ b/src/carquinyol/filestore.py @@ -146,18 +146,6 @@ class FileStore(object): if os.path.exists(file_path): os.remove(file_path) -def hard_link_entry(self, new_uid, existing_uid): -existing_file = layoutmanager.get_instance().get_data_path( -existing_uid) -new_file = layoutmanager.get_instance().get_data_path(new_uid) - -logging.debug('removing %r', new_file) -os.remove(new_file) - -logging.debug('hard linking %r -> %r', new_file, existing_file) -os.link(existing_file, new_file) - - class AsyncCopy(object): """Copy a file in chunks in the idle loop. diff --git a/src/carquinyol/layoutmanager.py b/src/carquinyol/layoutmanager.py index 3179a98..ee8270c 100644 --- a/src/carquinyol/layoutmanager.py +++ b/src/carquinyol/layoutmanager.py @@ -35,9 +35,6 @@ class LayoutManager(object): if not os.path.exists(self._root_path): os.makedirs(self._root_path) -self._create_if_needed(self.get_checksums_dir()) -self._create_if_needed(self.get_queue_path()) - def _create_if_needed(self, path): if not os.path.exists(path): os.makedirs(path) @@ -74,12 +71,6 @@ class LayoutManager(object): def get_index_path(self): return os.path.join(self._root_path, 'index') -def get_checksums_dir(self): -return os.path.join(self._root_path, 'checksums') - -def get_queue_path(self): -return os.path.join(self.get_checksums_dir(), 'queue') - def find_all(self): uids = [] for f in os.listdir(self._root_path): diff --git a/src/carquinyol/metadatastore.py b/src/carquinyol/metadatastore.py index 52
Re: [Sugar-devel] [PATCH shell] Journal: defocus the search entry by default
This has a regression whlie trying to rename an entry in the journal. Please don't push, I will fix it :) 2012/9/26 Manuel Quiñones : > Do the same behavior as in the shell views, explained in detail in > commit 1570f774 . > > - make MainToolBox search_entry a public attribute to make it visible > from JournalActivity > > - as a consequence of the previous item, remove give_entry_focus > method from MainToolBox and use the attribute directly > > Signed-off-by: Manuel Quiñones > --- > src/jarabe/journal/journalactivity.py | 12 ++-- > src/jarabe/journal/journaltoolbox.py | 27 +-- > 2 files changed, 23 insertions(+), 16 deletions(-) > > diff --git a/src/jarabe/journal/journalactivity.py > b/src/jarabe/journal/journalactivity.py > index 23a0b38..1ecb6e3 100644 > --- a/src/jarabe/journal/journalactivity.py > +++ b/src/jarabe/journal/journalactivity.py > @@ -173,6 +173,7 @@ class JournalActivity(JournalWindow): > def _setup_main_view(self): > self._main_toolbox = MainToolbox() > self._main_view = Gtk.VBox() > +self._main_view.set_can_focus(True) > > self._list_view = ListView() > self._list_view.connect('detail-clicked', self.__detail_clicked_cb) > @@ -188,6 +189,8 @@ class JournalActivity(JournalWindow): > self._main_view.pack_start(self._volumes_toolbar, False, True, 0) > > self._main_toolbox.connect('query-changed', self._query_changed_cb) > +self._main_toolbox.search_entry.connect('icon-press', > + > self.__search_icon_pressed_cb) > self._main_toolbox.set_mount_point('/') > > def _setup_secondary_view(self): > @@ -203,6 +206,9 @@ class JournalActivity(JournalWindow): > self._detail_view.show() > > def _key_press_event_cb(self, widget, event): > +if not self._main_toolbox.search_entry.has_focus(): > +self._main_toolbox.search_entry.grab_focus() > + > keyname = Gdk.keyval_name(event.keyval) > if keyname == 'Escape': > self.show_main_view() > @@ -220,6 +226,9 @@ class JournalActivity(JournalWindow): > self._list_view.update_with_query(query) > self.show_main_view() > > +def __search_icon_pressed_cb(self, entry, icon_pos, event): > +self._main_view.grab_focus() > + > def show_main_view(self): > if self.toolbar_box != self._main_toolbox: > self.set_toolbar_box(self._main_toolbox) > @@ -279,7 +288,6 @@ class JournalActivity(JournalWindow): > self.show_main_view() > > def _focus_in_event_cb(self, window, event): > -self.search_grab_focus() > self._list_view.update_dates() > > def _check_for_bundle(self, object_id): > @@ -319,7 +327,7 @@ class JournalActivity(JournalWindow): > model.write(metadata) > > def search_grab_focus(self): > -self._main_toolbox.give_entry_focus() > +self._main_toolbox.search_entry.grab_focus() > > def __window_state_event_cb(self, window, event): > logging.debug('window_state_event_cb %r', self) > diff --git a/src/jarabe/journal/journaltoolbox.py > b/src/jarabe/journal/journaltoolbox.py > index a4f80fc..09d8a31 100644 > --- a/src/jarabe/journal/journaltoolbox.py > +++ b/src/jarabe/journal/journaltoolbox.py > @@ -76,14 +76,16 @@ class MainToolbox(ToolbarBox): > > self._mount_point = None > > -self._search_entry = iconentry.IconEntry() > -self._search_entry.set_icon_from_name(iconentry.ICON_ENTRY_PRIMARY, > - 'system-search') > -self._search_entry.connect('activate', > self._search_entry_activated_cb) > -self._search_entry.connect('changed', self._search_entry_changed_cb) > -self._search_entry.add_clear_button() > +self.search_entry = iconentry.IconEntry() > +self.search_entry.set_icon_from_name(iconentry.ICON_ENTRY_PRIMARY, > + 'system-search') > +text = _('Search in %s') % _('Journal') > +self.search_entry.set_placeholder_text(text) > +self.search_entry.connect('activate', > self._search_entry_activated_cb) > +self.search_entry.connect('changed', self._search_entry_changed_cb) > +self.search_entry.add_clear_button() > self._autosearch_timer = None > -self._add_widget(self._search_entry, expand=True) > +self._add_widget(self.search_entry, expand=True) > > self._favorite_button = ToggleToolButton('emblem-favorite') > self._favorite_button.connect('toggled', > @@ -121,9 +123,6 @@ class MainToolbox(ToolbarBox): > > self.refresh_filters() > > -def give_entry_focus(self): > -self._search_entry.grab_focus() > - > def _get_when_search_combo(self): > when_search = ComboBox() > when_search.append_item(_ACTION_ANYTIME, _('Anytime')) > @@ -188,8
[Sugar-devel] [PATCH sugar-artwork] Set height for all the GtkNotebook tabs
This is the second item of SL#3923. Set the same height for all the tabs, with or without icons. Signed-off-by: Daniel Francis --- gtk3/theme/gtk-widgets.css.em | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em index 24a4c17..8dd420c 100644 --- a/gtk3/theme/gtk-widgets.css.em +++ b/gtk3/theme/gtk-widgets.css.em @@ -310,6 +310,8 @@ GtkComboBox .separator { .notebook tab { background-color: @selection_grey; color: @white; +padding-top: $(icon_large * 0.30)px; +padding-bottom: $(icon_large * 0.30)px; } .notebook tab GtkLabel { -- 1.7.11.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar-artwork] Set height for all the GtkNotebook tabs
2012/9/26 Daniel Francis : > +padding-top: $(icon_large * 0.30)px; > +padding-bottom: $(icon_large * 0.30)px; I spoke too early, this solution doesn't work as expected with tab close buttons. "Ooops!" ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH sugar-artwork] Set background color to GtkTreeView - SL #3962
This makes the treeview header get the same style as in GTK+2. The background is the same color as the header button, so looks a rectagular area. And a white round border is visible when the button is active. Signed-off-by: Manuel Quiñones --- gtk3/theme/gtk-widgets.css.em | 4 1 file changed, 4 insertions(+) diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em index 062acbe..8421c1c 100644 --- a/gtk3/theme/gtk-widgets.css.em +++ b/gtk3/theme/gtk-widgets.css.em @@ -214,6 +214,10 @@ GtkToggleButton.button:active { color: @black; } +GtkTreeView { +background-color: @button_grey; +} + GtkTreeView row:nth-child(even) { background-color: @row_even; } -- 1.7.11.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] ImageViewer gtk3 branch maintainership
Hi Aleksey, As the OLPC team approach the release of 13.1.0, we are improving and testing the support of touch in the activities. One of the activities where this is important, is ImageViewer. To support two fingers pinch-to-zoom or rotation, we need a version ported to gtk3, and there are already a branch where Flavio did it. Manuel Kaufmann is working based in the work from Flavio. I understand you are fully focused in Sugar Network, and probably do not have too much time to test in a recent version of Sugar and do release work. How can we coordinate to have a gtk3 version release on ASLO? Of course can be marked as compatible with sugar-0.98, then other users will not be affected. The issues we need solve are: 1) Who will be responsible by the branch/release 2) Schema number for gtk2 and gtk3 releases. Tell us what you think. Regards, Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] A simple way for teachers to review children works
Hi all, You give me plenty of different solutions ! Its great to have a so prolific mailing list. Thanks to Tony, Tabitha, Kevin, Yama, Claudia, James and Adam. We will think to all of these solutions and discuss it with teachers. Thanks a lot for your help. Best regards from France. Lionel. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] using logging vs logger
Sugar{,-toolkit,toolkit3,datastore} sources have a mix of direct calls to the logging module, and calls to it via the sugar logger instance of the logging module, which is configured. Early in sugar-session, I understand the use of logging before sugar.logger is setup. But after that... is there any logic to the direct use of logging? "it's messy/inconsistent but it works either way" is an acceptable answer :-) -- OTOH, if there are subtleties at play, I would really like to understand them. Logging functionality does _not_ work correctly in all cases for the datastore, and I'd like to fix that. Some tracebacks are being written to the dbus daemon -- and the caller at the other end of the dbus conversation does not understand the response. Sometimes *that* gets logged but it's very unwieldy to debug in these conditions. cheers, m -- martin.langh...@gmail.com mar...@laptop.org -- Software Architect - OLPC - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [Grassroots-l] A simple way for teachers to review children works
On Wed, Sep 26, 2012 at 9:33 AM, Claudia Urrea wrote: > Have you tried the Portfolio Activity? teachers can ask the students to start putting together their work of the wee, reflecting on what they did ^^ Great typo :) I second the suggestion to use Portfolio. It's also under active development, so there's a chance of submitting feature requests and having them filled. SJ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [DESIGN] Chage in filter in home view
2012/9/26 Gonzalo Odiard : >> >> Can you describe how it is annoying, what were you trying to do with >> search, was it a complicated search string you needed to preserve, or a >> result state you particularly wanted to keep? UI freeze is not for another >> couple of weeks, reports/feedback on feature chenges is most wanted! :) >> > > I am working with any activity, then, use the filter to found it in the > home, in the favorites or in the list, > start the activity, and when close the activity, the search is cleaned. > If I want use the same activity again, need enter the filter again. > > I have not switched views. The filter should be preserved. > In fact, the filter should be preserved, but not shared, for every view. > Example: > I can filter the Read activity, go to neighbour view, the filter is empty, > search for a access point "My School", go back to the home, and the filter > should keep the activity Read filtered. Gonzalo, yours is a respectable user case. In my case, I don't have any problem doing the search again, and I'm used to do it in gnome shell too. I wonder what learners would prefer. As Gary said we discussed three options in the design thread, and concluded in the current one, which we thought was the best. Regards, -- .. manuq .. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] OpenDyslexic font
Kevix pointed out this article on #sugar http://www.bbc.com/news/technology-19734341 I'm wondering if there is a simple method to download and install the font on Sugar. it would appear to be under suitable licensing and I'm wondering of there is a way to hang it up on ASLO to raise awareness of it and make it more available. I don't know how well the i18n coverage, but in a sense, a11y is a form of 18jn/L10n in it's own right. cjl. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel