Hello, sorry for causing all this problem =]
On Tue, Dec 24, 2013 at 9:35 PM, Daniel Narvaez dwnarv...@gmail.com wrote:
On 24 December 2013 23:36, Alan Jhonn Aguiar Schwyn
alan...@hotmail.comwrote:
No. I only aswer this email (see below).
The mantainer is not Unresponsive, only takes more of 1 month to
asnwer, that what is?
slow modem connection user? :-)
Well, to start with give him more of a chance :) He didn't answer to one
email, he might have missed it, forgot about it or even thought you didn't
need an answer to go ahead and post the merge request.
About that, maybe I wasn't clear enough in my previous answer, but what I
wanted to say was exactly what Daniel said: just go ahead and make a merge
request. And yes, I missed this email thread, only today a friend pointed
that something was happening.
If a maintainer is very slow but it's clear he wants to review code before
it's pushed, I don't think we should do so without his permission. It's his
project, he is even free to reject perfectly good code without looking at
it, if he wants.
I'm not planning to deny merge requests, but I think code review is a good
practice. OK, four years ago we didnt't do it, but nowadays it is important
=]
Luiz
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
