Re: [Sugar-devel] [Dextrose] [PATCH] Reduction in the time taken for loading of the menu (SL#1169)

2010-10-21 Thread Shanjit Singh Jajmann
Bernie,

Thanks for your time to review the patch.

Glad you could provide pointers.

Thanks.

Regards
Shanjit Singh Jajmann
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [Dextrose] [PATCH] Reduction in the time taken for loading of the menu (SL#1169)

2010-10-21 Thread Bernie Innocenti
On Thu, 2010-10-21 at 04:07 +0530, shan...@seeta.in wrote:
> From: Shanjit Singh Jajmann 
> 
> The earlier menu which was slow in loading up, has now been
> made quicker to respond to hovering above it. Changes have
> been made to palette.py and palettewindow.py .
> 
> v1 -> v2 : Since the time 0.0, was too short for
> comfortable viewing, changes have been made, to allow
> sufficient pop up down. Suggestions taken from SL#2367.
>
> Co-Authored by : Frederick 

A few observations:

1) If we agree to make up a "Co-authored-by" tag, we should at least be
consistent. It should be:

 Co-authored-by: Frederick Grose 

(note the capitalization, hyphens, spacing and full name)

2) "Changes have been made to palette.py and palettewindow.py ." doesn't
belong to the commit message, which is supposed to be a *functional*
description of what the patch does and why.

With the above changes:

 Reviewed-By: Bernie Innocenti 

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs   - http://sugarlabs.org/

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel