[Sugar-devel] [PATCH] Add description item to the toolbar if available - SL# 3525

2012-04-26 Thread godiard 
From: Gonzalo Odiard 

The activity have a custom toolbar, then need add the DescriptionItem
to implement the feature "Write to Journal Anytime"

http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime

Signed-off-by: Gonzalo Odiard 
---
 activity.py |8 
 1 file changed, 8 insertions(+)

diff --git a/activity.py b/activity.py
index b885842..34a0e68 100644
--- a/activity.py
+++ b/activity.py
@@ -67,6 +67,14 @@ class Chat(activity.Activity):
 toolbar_box.toolbar.insert(ActivityButton(self), -1)
 toolbar_box.toolbar.insert(TitleEntry(self), -1)
 
+try:
+from sugar.activity.widgets import DescriptionItem
+description_item = DescriptionItem(self)
+toolbar_box.toolbar.insert(description_item, -1)
+description_item.show()
+except:
+pass
+
 share_button = ShareButton(self)
 toolbar_box.toolbar.insert(share_button, -1)
 
-- 
1.7.10

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

[Sugar-devel] [PATCH] Add description item to the toolbar if available - SL# 3525

2012-04-26 Thread godiard 
From: Gonzalo Odiard 

The activity have a custom toolbar, then need add the DescriptionItem
to implement the feature "Write to Journal Anytime"

http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime

Signed-off-by: Gonzalo Odiard 
---
 activity.py |8 
 1 file changed, 8 insertions(+)

diff --git a/activity.py b/activity.py
index 306b081..6660fa7 100644
--- a/activity.py
+++ b/activity.py
@@ -66,6 +66,14 @@ class StopWatchActivity(Activity):
 toolbar_box.toolbar.insert(title_entry, -1)
 title_entry.show()
 
+try:
+from sugar.activity.widgets import DescriptionItem
+description_item = DescriptionItem(self)
+toolbar_box.toolbar.insert(description_item, -1)
+description_item.show()
+except:
+pass
+
 share_button = ShareButton(self)
 toolbar_box.toolbar.insert(share_button, -1)
 share_button.show()
-- 
1.7.10

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Add description item to the toolbar if available - SL# 3525

2012-04-26 Thread Simon Schampijer 

On 04/26/2012 02:24 PM, godi...@sugarlabs.org wrote:

From: Gonzalo Odiard

The activity have a custom toolbar, then need add the DescriptionItem
to implement the feature "Write to Journal Anytime"

http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime

Signed-off-by: Gonzalo Odiard
---
  activity.py |8 
  1 file changed, 8 insertions(+)

diff --git a/activity.py b/activity.py
index b885842..34a0e68 100644
--- a/activity.py
+++ b/activity.py
@@ -67,6 +67,14 @@ class Chat(activity.Activity):
  toolbar_box.toolbar.insert(ActivityButton(self), -1)
  toolbar_box.toolbar.insert(TitleEntry(self), -1)

+try:
+from sugar.activity.widgets import DescriptionItem
+description_item = DescriptionItem(self)
+toolbar_box.toolbar.insert(description_item, -1)
+description_item.show()
+except:
+pass
+
  share_button = ShareButton(self)
  toolbar_box.toolbar.insert(share_button, -1)



I would do:

try:
from sugar.activity.widgets import DescriptionItem
except ImportError:
logging.debug('DescriptionItem button is not available, toolkit 
version < 0.96')

else:
description_item = DescriptionItem(self)
...

Regards,
   Simon

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Add description item to the toolbar if available - SL# 3525

2012-04-26 Thread Gonzalo Odiard 
Ok

Gonzalo

On Thu, Apr 26, 2012 at 10:37 AM, Simon Schampijer wrote:

> On 04/26/2012 02:24 PM, godi...@sugarlabs.org wrote:
>
>> From: Gonzalo Odiard
>>
>> The activity have a custom toolbar, then need add the DescriptionItem
>> to implement the feature "Write to Journal Anytime"
>>
>> http://wiki.sugarlabs.org/go/**Features/Write_to_journal_**anytime
>>
>> Signed-off-by: Gonzalo Odiard
>> ---
>>  activity.py |8 
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/activity.py b/activity.py
>> index b885842..34a0e68 100644
>> --- a/activity.py
>> +++ b/activity.py
>> @@ -67,6 +67,14 @@ class Chat(activity.Activity):
>>  toolbar_box.toolbar.insert(**ActivityButton(self), -1)
>>  toolbar_box.toolbar.insert(**TitleEntry(self), -1)
>>
>> +try:
>> +from sugar.activity.widgets import DescriptionItem
>> +description_item = DescriptionItem(self)
>> +toolbar_box.toolbar.insert(**description_item, -1)
>> +description_item.show()
>> +except:
>> +pass
>> +
>>  share_button = ShareButton(self)
>>  toolbar_box.toolbar.insert(**share_button, -1)
>>
>>
> I would do:
>
> try:
>from sugar.activity.widgets import DescriptionItem
> except ImportError:
>logging.debug('DescriptionItem button is not available, toolkit version
> < 0.96')
> else:
>description_item = DescriptionItem(self)
>...
>
> Regards,
>   Simon
>
> __**_
> Sugar-devel mailing list
> Sugar-devel@lists.sugarlabs.**org 
> http://lists.sugarlabs.org/**listinfo/sugar-devel
>
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Add description item to the toolbar if available - SL# 3525

2012-04-28 Thread Aleksey Lim 
On Thu, Apr 26, 2012 at 09:24:24AM -0300, godi...@sugarlabs.org wrote:
> From: Gonzalo Odiard 
> 
> The activity have a custom toolbar, then need add the DescriptionItem
> to implement the feature "Write to Journal Anytime"
> 
> http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime

Pushed, released in v76.

-- 
Aleksey
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH] Add description item to the toolbar if available - SL# 3525

2012-04-30 Thread Simon Schampijer 

On 04/28/2012 06:23 PM, Aleksey Lim wrote:

On Thu, Apr 26, 2012 at 09:24:24AM -0300, godi...@sugarlabs.org wrote:

From: Gonzalo Odiard

The activity have a custom toolbar, then need add the DescriptionItem
to implement the feature "Write to Journal Anytime"

http://wiki.sugarlabs.org/go/Features/Write_to_journal_anytime


Pushed, released in v76.



Great, thanks Aleksey.

Regards,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel