Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
On Wed, 2010-04-28 at 09:56 +1000, James Cameron wrote: On Tue, Apr 27, 2010 at 09:43:21AM -0400, Raul Gutierrez Segales wrote: Looking at it with more detail, the problem is that self._update_signal_match is initialized in the wrong order (after a call to set_object_id that depends on it). No worries, now I understand, and approve. Reviewed-by: James Cameron qu...@laptop.org Great, what is the next step for inclusion? (I have no commit access to sugar-toolkit). Raúl ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
On Wed, Apr 28, 2010 at 10:57:24AM -0400, Raul Gutierrez Segales wrote: Great, what is the next step for inclusion? (I have no commit access to sugar-toolkit). Please provide the updated patch (i.e. including Reviewed-By/Tested-By/... lines) as a separate MIME part (I don't care whether it's marked inline or attachment, but it needs to be a separate MIME part so it doesn't get munged by the MUA). Also I'll need to know which branches it should be applied to. Ideally, you'd also have an Ack-By from the maintainer of sugar-toolkit (IIRC that's Simon). CU Sascha -- http://sascha.silbe.org/ http://www.infra-silbe.de/ signature.asc Description: Digital signature ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
El Wed, 28-04-2010 a las 19:33 +0200, Sascha Silbe escribió: Please provide the updated patch (i.e. including Reviewed-By/Tested-By/... lines) as a separate MIME part (I don't care whether it's marked inline or attachment, but it needs to be a separate MIME part so it doesn't get munged by the MUA). Also I'll need to know which branches it should be applied to. I've never had problems saving inline patches from either Evolution or Thunderbird and then applying them with git am. Mutt of course also works great. This is the regulard workflow to exchange patches by email: Alice: git format-patch -1 Alice: git send-email --to bob foo.patch Bob: (saves raw email body in MUA) Bob: git am foop.patch Ideally, you'd also have an Ack-By from the maintainer of sugar-toolkit (IIRC that's Simon). Hmm... sugar-toolkit is missing a MAINTAINERS file. It would be good to add it, or document the current maintainer mappings somewhere (gitorious, wiki...) -- // Bernie Innocenti - http://codewiz.org/ \X/ Sugar Labs - http://sugarlabs.org/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
On Thu, Apr 29, 2010 at 12:32:25AM -0400, Bernie Innocenti wrote: Hmm... sugar-toolkit is missing a MAINTAINERS file. +1 It would be good to add it, or document the current maintainer mappings somewhere (gitorious, wiki...) Only put it somewhere else if you don't want people to find it when they are looking at the source ... same can be said of dependencies ... I like what Michael Stone has done with the debian-builddeps and xo-builddeps targets. It makes the source more usable for developers, and therefore more accessible. -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
James, On Tue, 2010-04-27 at 11:25 +1000, James Cameron wrote: On Mon, Apr 26, 2010 at 03:50:17PM -0400, Raul Gutierrez Segales wrote: Because of missing initialization and a weak test for the existence of the object (self._update_signal_match is not None) Turtle Art was crashing when resuming from the Journal. Reviewed, but I didn't understand. This might be my fault. Your patch appears to be to sugar-toolkit. Correct. self._update_signal_match is only used in DSObject, it is already initialised in sugar-toolkit 0.84.9, and you're adding the initialisation to DSMetadata, where it is not used. Sorry, this was done on the run.. Because we were spinning new builds. Looking at it with more detail, the problem is that self._update_signal_match is initialized in the wrong order (after a call to set_object_id that depends on it). diff --git a/src/sugar/datastore/datastore.py b/src/sugar/datastore/datastore.py index 6ff10de..7aa4d15 100644 --- a/src/sugar/datastore/datastore.py +++ b/src/sugar/datastore/datastore.py @@ -109,12 +109,12 @@ class DSMetadata(gobject.GObject): class DSObject(object): def __init__(self, object_id, metadata=None, file_path=None): +self._update_signal_match = None self.set_object_id(object_id) self._metadata = metadata self._file_path = file_path self._destroyed = False self._owns_file = False -self._update_signal_match = None def get_object_id(self): return self._object_id ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
On Tue, Apr 27, 2010 at 09:43:21AM -0400, Raul Gutierrez Segales wrote: Looking at it with more detail, the problem is that self._update_signal_match is initialized in the wrong order (after a call to set_object_id that depends on it). No worries, now I understand, and approve. Reviewed-by: James Cameron qu...@laptop.org -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
[Sugar-devel] [PATCH] _update_signal_match wasn't initialized
Because of missing initialization and a weak test for the existence of
the object (self._update_signal_match is not None) Turtle Art was
crashing when resuming from the Journal.
Signed-off-by: Raúl Gutiérrez S. r...@paraguayeduca.org
Ackd-by: Bernie Innocenti ber...@sugarlabs.org
---
src/sugar/datastore/datastore.py |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/sugar/datastore/datastore.py b/src/sugar/datastore/datastore.py
index 6ff10de..e711f02 100644
--- a/src/sugar/datastore/datastore.py
+++ b/src/sugar/datastore/datastore.py
@@ -57,6 +57,7 @@ class DSMetadata(gobject.GObject):
}
def __init__(self, props=None):
+self._update_signal_match = None
gobject.GObject.__init__(self)
if not props:
self._props = {}
--
1.6.3.3
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
Forgot to mention that this is for 0.84 branch, 0.88 does it right.
On Mon, 2010-04-26 at 15:50 -0400, Raul Gutierrez Segales wrote:
Because of missing initialization and a weak test for the existence of
the object (self._update_signal_match is not None) Turtle Art was
crashing when resuming from the Journal.
Signed-off-by: Raúl Gutiérrez S. r...@paraguayeduca.org
Ackd-by: Bernie Innocenti ber...@sugarlabs.org
---
src/sugar/datastore/datastore.py |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/sugar/datastore/datastore.py
b/src/sugar/datastore/datastore.py
index 6ff10de..e711f02 100644
--- a/src/sugar/datastore/datastore.py
+++ b/src/sugar/datastore/datastore.py
@@ -57,6 +57,7 @@ class DSMetadata(gobject.GObject):
}
def __init__(self, props=None):
+self._update_signal_match = None
gobject.GObject.__init__(self)
if not props:
self._props = {}
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH] _update_signal_match wasn't initialized
On Mon, Apr 26, 2010 at 03:50:17PM -0400, Raul Gutierrez Segales wrote: Because of missing initialization and a weak test for the existence of the object (self._update_signal_match is not None) Turtle Art was crashing when resuming from the Journal. Reviewed, but I didn't understand. This might be my fault. Your patch appears to be to sugar-toolkit. self._update_signal_match is only used in DSObject, it is already initialised in sugar-toolkit 0.84.9, and you're adding the initialisation to DSMetadata, where it is not used. -- James Cameron http://quozl.linux.org.au/ ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
