[Sugar-devel] [PATCH sugar-artwork] Set height for all the GtkNotebook tabs

2012-09-26 Thread Daniel Francis 
This is the second item of SL#3923.
Set the same height for all the tabs, with or without icons.

Signed-off-by: Daniel Francis 
---
 gtk3/theme/gtk-widgets.css.em | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gtk3/theme/gtk-widgets.css.em b/gtk3/theme/gtk-widgets.css.em
index 24a4c17..8dd420c 100644
--- a/gtk3/theme/gtk-widgets.css.em
+++ b/gtk3/theme/gtk-widgets.css.em
@@ -310,6 +310,8 @@ GtkComboBox .separator {
 .notebook tab {
 background-color: @selection_grey;
 color: @white;
+padding-top: $(icon_large * 0.30)px;
+padding-bottom: $(icon_large * 0.30)px;
 }
 
 .notebook tab GtkLabel {
-- 
1.7.11.4

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar-artwork] Set height for all the GtkNotebook tabs

2012-09-26 Thread S. Daniel Francis 
2012/9/26 Daniel Francis :
> +padding-top: $(icon_large * 0.30)px;
> +padding-bottom: $(icon_large * 0.30)px;

I spoke too early, this solution doesn't work as expected with tab
close buttons. "Ooops!"
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar-artwork] Set height for all the GtkNotebook tabs

2012-09-27 Thread Manuel Quiñones 
Hey Dani,

2012/9/26 S. Daniel Francis :
> 2012/9/26 Daniel Francis :
>> +padding-top: $(icon_large * 0.30)px;
>> +padding-bottom: $(icon_large * 0.30)px;
>
> I spoke too early, this solution doesn't work as expected with tab
> close buttons. "Ooops!"

:)  I think the way to do it is setting top and bottom padding to the
label inside the tab.  But we have to find the exact number to make
the tab the same tall when it has only labels, and when it has labels
and buttons.

Maybe start using the same as the button padding wich is $(border)px
and add a bit of salt.

-- 
.. manuq ..
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel

Re: [Sugar-devel] [PATCH sugar-artwork] Set height for all the GtkNotebook tabs

2012-09-27 Thread S. Daniel Francis 
2012/9/27 Manuel Quiñones :
> Hey Dani,
>
> 2012/9/26 S. Daniel Francis :
>> 2012/9/26 Daniel Francis :
>>> +padding-top: $(icon_large * 0.30)px;
>>> +padding-bottom: $(icon_large * 0.30)px;
>>
>> I spoke too early, this solution doesn't work as expected with tab
>> close buttons. "Ooops!"
>
> :)  I think the way to do it is setting top and bottom padding to the
> label inside the tab.
Thanks for the tip. :)

>  But we have to find the exact number to make
> the tab the same tall when it has only labels
> and when it has labels and buttons.
>
> Maybe start using the same as the button padding wich is $(border)px
> and add a bit of salt.

In my patch I used the icon size, but there's to test which is better.

Regards,
Daniel.
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel