[Sugar-devel] [PATCH sugar-artwork] Zoom icons: Removing grey fill color
I'm developing a graph plotting activity, and when I tried to use the zoom icons, I saw an ugly difference with the other icons in the Sugar Theme. Signed-off-by: Daniel Francis --- icons/scalable/actions/zoom-best-fit.svg |4 ++-- icons/scalable/actions/zoom-in.svg |4 ++-- icons/scalable/actions/zoom-original.svg |4 ++-- icons/scalable/actions/zoom-out.svg |4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/icons/scalable/actions/zoom-best-fit.svg b/icons/scalable/actions/zoom-best-fit.svg index 68d103f..1a3a240 100644 --- a/icons/scalable/actions/zoom-best-fit.svg +++ b/icons/scalable/actions/zoom-best-fit.svg @@ -1,8 +1,8 @@ http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd'>http://www.w3.org/2000/svg"; xmlns:xlink="http://www.w3.org/1999/xlink"; y="0px"> - + - \ No newline at end of file + diff --git a/icons/scalable/actions/zoom-in.svg b/icons/scalable/actions/zoom-in.svg index 8031903..4bed524 100644 --- a/icons/scalable/actions/zoom-in.svg +++ b/icons/scalable/actions/zoom-in.svg @@ -1,8 +1,8 @@ http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd'>http://www.w3.org/2000/svg"; xmlns:xlink="http://www.w3.org/1999/xlink"; y="0px"> - + - \ No newline at end of file + diff --git a/icons/scalable/actions/zoom-original.svg b/icons/scalable/actions/zoom-original.svg index 2ccb5c5..77639db 100644 --- a/icons/scalable/actions/zoom-original.svg +++ b/icons/scalable/actions/zoom-original.svg @@ -3,9 +3,9 @@ ]>http://www.w3.org/2000/svg"; xmlns:xlink="http://www.w3.org/1999/xlink"; y="0px"> - + - \ No newline at end of file + diff --git a/icons/scalable/actions/zoom-out.svg b/icons/scalable/actions/zoom-out.svg index 1e6a681..3418b16 100644 --- a/icons/scalable/actions/zoom-out.svg +++ b/icons/scalable/actions/zoom-out.svg @@ -1,7 +1,7 @@ http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd'>http://www.w3.org/2000/svg"; xmlns:xlink="http://www.w3.org/1999/xlink"; y="0px"> - + - \ No newline at end of file + -- 1.7.10.4 ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar-artwork] Zoom icons: Removing grey fill color
Maybe Gary or Manuq can look at this issue? Gonzalo ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar-artwork] Zoom icons: Removing grey fill color
I made a new patch with similar changes, but for the table/cell icons, also mailed to this list. Cheers. 2012/7/13 Gonzalo Odiard : > Maybe Gary or Manuq can look at this issue? > > Gonzalo > > ___ > Sugar-devel mailing list > Sugar-devel@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar-artwork] Zoom icons: Removing grey fill color
Hi Daniel, On 13 Jul 2012, at 16:00, S. Daniel Francis wrote: > I made a new patch with similar changes, but for the table/cell icons, > also mailed to this list. Thanks for the patches! I've not had time to review them yet, design review on svg diff patches sent to the mail list is a petty slow work-flow for me to actually get to see the end result ;) But while you pretend to listen to elevator music, waiting for a review, I thought you might find this of interest. It's an svg gird of all the other svg's currently in sugar-artwork mainline, hover over them to see the file name. It works well in Safari and Chrome (but I think Firefox's SVG support is still a little broken with regard to the official spec supporting the imbedding of other images in an SVG): http://wiki.sugarlabs.org/images/e/e8/Sugar-artwork.svg There's quite a lot of unused items in there, and some you see with grey are often intended to allow for the user fill and stroke entity colours (but pretty sure the one's you've patched so far were not intended for such user colour use). I'll clarify/confirm once I've had a chance to look over your patches in more detail. Regards, --Gary > Cheers. > > 2012/7/13 Gonzalo Odiard : >> Maybe Gary or Manuq can look at this issue? >> >> Gonzalo >> >> ___ >> Sugar-devel mailing list >> Sugar-devel@lists.sugarlabs.org >> http://lists.sugarlabs.org/listinfo/sugar-devel >> ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] [PATCH sugar-artwork] Zoom icons: Removing grey fill color
2012/7/13 Gary Martin : > Thanks for the patches! I've not had time to review them yet, design review > on svg diff patches sent to the mail list is a petty slow work-flow for me to > actually get to see the end result ;) Yeah, this is the first time I make a patch for Sugar Design, but I agree sending patches like any other component in Sugar isn't the best way. So, I made a little article[1] in the Wiki with the affected activities and screenshots with and without my patch where you can see quickly the differences. Regards, danielf. [1] http://wiki.sugarlabs.org/go/User:Daniel_Francis/Remove_grey_fill_color ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
