Re: [Sugar-devel] [PATCH chat] Remove the KeepButton due to deprecation

2011-07-28 Thread Gonzalo Odiard
Reviewed-by: Gonzalo Odiard 

On Wed, Jul 27, 2011 at 12:02 PM, Simon Schampijer wrote:

> From: Simon Schampijer 
>
> ---
>  activity.py |3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/activity.py b/activity.py
> index 58c6d8e..05b7558 100644
> --- a/activity.py
> +++ b/activity.py
> @@ -35,7 +35,7 @@ from sugar.graphics.palette import Palette
>  from sugar.graphics.toolbarbox import ToolbarBox
>  from sugar.activity import activity
>  from sugar.presence import presenceservice
> -from sugar.activity.widgets import ActivityButton, TitleEntry, KeepButton
> +from sugar.activity.widgets import ActivityButton, TitleEntry
>  from sugar.activity.widgets import StopButton, ShareButton,
> RadioMenuButton
>
>  from chat import smilies
> @@ -69,7 +69,6 @@ class Chat(activity.Activity):
>
> share_button = ShareButton(self)
> toolbar_box.toolbar.insert(share_button, -1)
> -toolbar_box.toolbar.insert(KeepButton(self), -1)
>
> separator = gtk.SeparatorToolItem()
> toolbar_box.toolbar.insert(separator, -1)
> --
> 1.7.4.4
>
> ___
> Sugar-devel mailing list
> Sugar-devel@lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/sugar-devel
>
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH chat] Remove the KeepButton due to deprecation

2011-08-13 Thread Simon Schampijer

Hi Aleksey,

can you push this if you are ok with it?

Regards,
   Simon

On 07/28/2011 02:56 PM, Gonzalo Odiard wrote:

Reviewed-by: Gonzalo Odiard



On Wed, Jul 27, 2011 at 12:02 PM, Simon Schampijerwrote:


From: Simon Schampijer

---
  activity.py |3 +--
  1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/activity.py b/activity.py
index 58c6d8e..05b7558 100644
--- a/activity.py
+++ b/activity.py
@@ -35,7 +35,7 @@ from sugar.graphics.palette import Palette
  from sugar.graphics.toolbarbox import ToolbarBox
  from sugar.activity import activity
  from sugar.presence import presenceservice
-from sugar.activity.widgets import ActivityButton, TitleEntry, KeepButton
+from sugar.activity.widgets import ActivityButton, TitleEntry
  from sugar.activity.widgets import StopButton, ShareButton,
RadioMenuButton

  from chat import smilies
@@ -69,7 +69,6 @@ class Chat(activity.Activity):

 share_button = ShareButton(self)
 toolbar_box.toolbar.insert(share_button, -1)
-toolbar_box.toolbar.insert(KeepButton(self), -1)

 separator = gtk.SeparatorToolItem()
 toolbar_box.toolbar.insert(separator, -1)
--
1.7.4.4

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel





___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH chat] Remove the KeepButton due to deprecation

2011-08-13 Thread Aleksey Lim
On Sat, Aug 13, 2011 at 03:27:27PM +0200, Simon Schampijer wrote:
> Hi Aleksey,
> 
> can you push this if you are ok with it?

Thanks, pushed.

Would be useful to add project maintianers (as HACKING file asks) to
original email, to pop up patches in maintianers' email queue.

-- 
Aleksey
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH chat] Remove the KeepButton due to deprecation

2011-08-13 Thread Simon Schampijer

On 08/13/2011 04:03 PM, Aleksey Lim wrote:

On Sat, Aug 13, 2011 at 03:27:27PM +0200, Simon Schampijer wrote:

Hi Aleksey,

can you push this if you are ok with it?


Thanks, pushed.

Would be useful to add project maintianers (as HACKING file asks) to
original email, to pop up patches in maintianers' email queue.


Sure, sounds good.

Simon

___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel