Re: [Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-20 Thread Simon Schampijer

On 09/19/2011 02:21 PM, Simon Schampijer wrote:

Make the palette on demand as well

Signed-off-by: Simon Schampijersi...@laptop.org


Pushed as: 
http://git.sugarlabs.org/sugar/mainline/commit/069eada75f23398b227affd5252e1408260ca354


Thanks to Gonzalo for testing, Marco for reviewing and Sascha for 
ack'ing (irc).


Regards,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-19 Thread Marco Pesenti Gritti
On 19 September 2011 12:59, Simon Schampijer si...@schampijer.de wrote:
 +        #self.palette_invoker.cache_palette = False

Leftover?

Looks good to me otherwise.

Marco
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel


Re: [Sugar-devel] [PATCH sugar] Do not cache the buddy palette in friends tray, SL #3108

2011-09-19 Thread Simon Schampijer

On 09/19/2011 02:17 PM, Marco Pesenti Gritti wrote:

On 19 September 2011 12:59, Simon Schampijersi...@schampijer.de  wrote:

+#self.palette_invoker.cache_palette = False


Leftover?

Looks good to me otherwise.

Marco


Outch, was a leftover from testing. We need to set the non-caching 
property of course. Send a new patch.


Thanks for the review,
   Simon
___
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel