Re: [Sugar-devel] icons for paragraph toolbar
Hi Fred, On 7 Sep 2009, at 06:10, Frederick Grose wrote: On Sat, Sep 5, 2009 at 9:16 PM, Gary C Martin g...@garycmartin.com wrote: ... Insert table icon is already in sugar-artwork, it's called insert- table.svg and looks OK to me, but I can't see it being set by the InsertToolbar class so it looks like we get a default low res bitmap instead: What we currently get is What we should be getting is I'd be very tempted to use this for the Table primary icon (as well as for the add table palette). The rest of the table SVG icons seem reasonable to me (add row, remove row, add column, remove column): The insert and delete row/column icons have arrows that suggest the movement of the surrounding data rather than the selected object (row or column), which would be highlighted. Please consider following that convention to show the action on the selected object, similar to the attached (rows column.PNG). Just to be clear. So it's not so much the use of arrows, but that the specific object affected (a row, a column) is not highlighted clearly in the icons? Thanks for taking an interest! Regards, --Gary ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] icons for paragraph toolbar
On Mon, Sep 7, 2009 at 8:27 AM, Gary C Martin g...@garycmartin.com wrote: ... The insert and delete row/column icons have arrows that suggest the movement of the surrounding data rather than the selected object (row or column), which would be highlighted. Please consider following that convention to show the action on the selected object, similar to the attached (rows column.PNG). Just to be clear. So it's not so much the use of arrows, but that the specific object affected (a row, a column) is not highlighted clearly in the icons? With 2 tones of gray, light and dark, (over the black background and white outline), I have trouble instantly identifying which is the highlight. In the delete case, if there is a highlight, it would seem to be the outer elements, so that suggests the darker gray is the highlight. I may be confused because the row or column that I highlighted in the sheet usually takes on a darker shade, while the center row or column in the icon is lighter. It requires me a lot of thought to work out a logic that overcomes what appears to be a dissonance between the subject and action of the arrow and my perception of the intended action. Thanks again Gary, hope that helps, --Fred ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] icons for paragraph toolbar
I created a walter clone of Write where I pushed (most) of these changes. (I need to work on the tables still.) Please let me know what you think. (I created an icon for the heading-style menu, attached.) -walter On Sat, Sep 5, 2009 at 9:16 PM, Gary C Marting...@garycmartin.com wrote: Hi Walter, On 4 Sep 2009, at 22:56, Walter Bender wrote: Attached are proposed patches to toolbar.py and widgets.py Seemingly pretty straight-forward stuff... but we need icons :) Sorry, haven't got to look at your patches yet, but here's the icons I have so far... Here's a possible replacement Insert Image icon (if you like it): Here's a primary toolbar icon for the secondary toolbar of bullet styles: Insert table icon is already in sugar-artwork, it's called insert-table.svg and looks OK to me, but I can't see it being set by the InsertToolbar class so it looks like we get a default low res bitmap instead: What we currently get is What we should be getting is I'd be very tempted to use this for the Table primary icon (as well as for the add table palette). The rest of the table SVG icons seem reasonable to me (add row, remove row, add column, remove column): Here's a set of icons for paragraph style headings 1 to 4: Here's an icon for the block text paragraph style: Here's my favourite attempt so far at an icon for the Plain Text paragraph style: It's a tough one, but if you don't like the above, here's another try: Plus, I haven't figured out where to put Plain. In the Headings palette perhaps? I popped Plain in the secondary Paragraph style toolbar (see toolbar layout in text below), it's with the headings and justify tools so I think that's the same place your referring to. We'll also need to violate string freeze, I am afraid to include the Headings hint. Walter, there's no need to be scared ;-) Ohh, quick toolbar bug while I remember: The Undo accelerator key is mapped to Ctrl+Q for some reason, so you can't currently quite Write with that shortcut ;-) Regards, --Gary P.S. Shout if you think I've missed an icon you need! On Fri, Sep 4, 2009 at 12:24 PM, Gary C Marting...@garycmartin.com wrote: Hi Walter, If I focus on generating need icons (and some order suggestions) would you pick up patching the Write toolbars? I can then move onto other icons for Simon (and my own Labyrinth/Physics/Moon). Here's a first pass at the toolbar to get an idea of icons needed. The HIG has space for 14 icons max, so things are pretty tight here. I would like to move 'Insert image' out of 'Table' and onto the primary toolbar, but that put's it perhaps too close to the 'Stop' button (I'd like to leave a 1x icon gap if possible): [Activity] Title input {Share palette} {Export palette} Keep [Edit] Copy Paste Undo Redo [View] Zoom in Zoom out (Zoom combo box) (Page combo box) Search input box -- should have string Search: prefixing the input box Find previous Find next [Paragraph style] Heading 1 -- need icon Heading 2 -- need icon Heading 3 -- need icon Heading 4 -- need icon Block text -- need icon Plain Text -- need icon Left justify Centre justify Right justify Fill justify [List style] -- need icon Normal Bullet list Dashed list Numbered list Lower case list Upper case list [Font style] (Font list menu) (Font size menu) [Table] -- need better icon {Add table palette} -- need better icon Add row -- need better icon Remove row -- need better icon Add column -- need better icon Remove column -- need better icon Insert Image -- have a better icon (see Labyrinth) Bold Italic Underline {Colour picker palette} ... ... Stop Seem OK? I can work on these a little tonight, but also tomorrow. Regards, --Gary On 3 Sep 2009, at 15:21, Walter Bender wrote: I think you'd get a +1 from both uwog and me. There are already individual icons for the bullet styles. Adding the same for the heading styles and then eliminating the drop-down menu doesn't seem too invasive. But we'll need to add a new string for the heading-style button, breaking string freeze. If we can agree upon the icons, I can try my hand at creating the patch. -walter On Thu, Sep 3, 2009 at 10:13 AM, Gary C Marting...@garycmartin.com wrote: Hi Walter, Thanks, have also popped them on the wiki page for reference: http://wiki.sugarlabs.org/go/Activity_Team/New_Toolbars I haven't started on the Write toolbar polish and
Re: [Sugar-devel] icons for paragraph toolbar
Hi Walter, On 6 Sep 2009, at 13:52, Walter Bender wrote: I created a walter clone of Write where I pushed (most) of these changes. (I need to work on the tables still.) Please let me know what you think. (I created an icon for the heading-style menu, attached.) Hmmm, not sure if I'm getting this correctly in sugar-jhbuild (I edit config/modulesets/fructose.modules to point to write/walter.git, delete source/write, do an update which looks to pull the new stuff, then a build). I'm just seeing some of the new icons in what looks like the old palettes, no change to the primary titlebar (either in order or content). Would you mind if I took a shot at this? Regards, --Gary ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] icons for paragraph toolbar
On Sat, Sep 5, 2009 at 9:16 PM, Gary C Martin g...@garycmartin.com wrote: ... Insert table icon is already in sugar-artwork, it's called insert-table.svg and looks OK to me, but I can't see it being set by the InsertToolbar class so it looks like we get a default low res bitmap instead: What we currently get is What we should be getting is I'd be very tempted to use this for the Table primary icon (as well as for the add table palette). The rest of the table SVG icons seem reasonable to me (add row, remove row, add column, remove column): The insert and delete row/column icons have arrows that suggest the movement of the surrounding data rather than the selected object (row or column), which would be highlighted. Please consider following that convention to show the action on the selected object, similar to the attached (rows column.PNG). Thanks for your efforts! --Fred attachment: table_tools.pngattachment: rows.PNGattachment: column.PNG___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
Re: [Sugar-devel] icons for paragraph toolbar
On 4 Sep 2009, at 17:55, Eben Eliason wrote: On Fri, Sep 4, 2009 at 12:24 PM, Gary C Marting...@garycmartin.com wrote: Hi Walter, If I focus on generating need icons (and some order suggestions) would you pick up patching the Write toolbars? I can then move onto other icons for Simon (and my own Labyrinth/Physics/Moon). Here's a first pass at the toolbar to get an idea of icons needed. The HIG has space for 14 icons max, so things are pretty tight here. I would like to move 'Insert image' out of 'Table' and onto the primary toolbar, but that put's it perhaps too close to the 'Stop' button (I'd like to leave a 1x icon gap if possible): [Activity] Title input {Share palette} {Export palette} Keep [Edit] Copy Paste Undo Redo [View] Zoom in Zoom out (Zoom combo box) (Page combo box) Search input box -- should have string Search: prefixing the input box Find previous Find next [Paragraph style] Heading 1 -- need icon Heading 2 -- need icon Heading 3 -- need icon Heading 4 -- need icon Block text -- need icon Plain Text -- need icon Left justify Centre justify Right justify Fill justify [List style]-- need icon Normal Bullet list Dashed list Numbered list Lower case list Upper case list [Font style] (Font list menu) (Font size menu) [Table] -- need better icon {Add table palette} -- need better icon Add row -- need better icon Remove row -- need better icon Add column -- need better icon Remove column -- need better icon Insert Image-- have a better icon (see Labyrinth) Bold Italic Underline {Colour picker palette} ... ... Stop Seem OK? I can work on these a little tonight, but also tomorrow. Looks pretty good to me. Fab. I think that the find controls belong on the edit toolbar, though. Sure, seems a fair change to me :-) Have some of the icons ready, will send out an email later tonight once I've hit a few more. Note that some of these icons used are from sugar-artwork so will need committed there. Regards, --Gary P.S. Bringing this thread on to list (started out as off list email chit chat) so folks are not left out the loop. ___ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel