Re: svn commit: r219091 - head/share/timedef

2011-02-27 Thread Konrad Jankowski
On Sun, Feb 27, 2011 at 10:40 PM, Bruce Cran  wrote:
> On Sun, 2011-02-27 at 21:32 +, Konrad Jankowski wrote:
>> Author: versus
>> Date: Sun Feb 27 21:32:25 2011
>> New Revision: 219091
>> URL: http://svn.freebsd.org/changeset/base/219091
>>
>> Log:
>>   Partial fix for PR 91106. Correct the short weekday names. Done according 
>> to this poll https://bugzilla.redhat.com/show_bug.cgi?id=242296. This will 
>> not close the bug fully yet, as the month names are still not correctly in 
>> Genitive. More research on this topic will be done, as I'm suspecting a bug 
>> in the libc locale functions picking the month name from the wrong group.
>
> Could you limit lines to 80 characters please?
> If you use vim, the following in ~/.vimrc will cause it to highlight
> overly long lines in red:
>
> highlight OverLength ctermbg=red ctermfg=white guibg=#592929
> match OverLength /\%81v.\+/

Sure, sorry about that, it won't happen again.

-- 
Konrad Jankowski
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r219089 - in head: cddl/compat/opensolaris/include cddl/compat/opensolaris/misc cddl/contrib/opensolaris/cmd/stat cddl/contrib/opensolaris/cmd/stat/common cddl/contrib/opensolaris/cmd/

2011-02-27 Thread Pawel Jakub Dawidek
On Sun, Feb 27, 2011 at 02:52:42PM -0800, Doug Barton wrote:
> On 02/27/2011 11:41, Pawel Jakub Dawidek wrote:
> >Author: pjd
> >Date: Sun Feb 27 19:41:40 2011
> >New Revision: 219089
> >URL: http://svn.freebsd.org/changeset/base/219089
> >
> >Log:
> >   Finally... Import the latest open-source ZFS version - (SPA) 28.
> 
> Has this been successfully built with clang? [...]

I haven't tried clang.

-- 
Pawel Jakub Dawidek   http://www.wheelsystems.com
FreeBSD committer http://www.FreeBSD.org
Am I Evil? Yes, I Am! http://yomoli.com


pgpwmaIMGBJeT.pgp
Description: PGP signature


svn commit: r219093 - head

2011-02-27 Thread Simon L. Nielsen
Author: simon
Date: Mon Feb 28 06:54:14 2011
New Revision: 219093
URL: http://svn.freebsd.org/changeset/base/219093

Log:
  Drop my OpenSSL maintainer hat. I don't have the motivation to keep
  chasing updates etc.
  
  Leave a reminder not to commit non-upstream changes (ref: Debian
  random...).

Modified:
  head/MAINTAINERS

Modified: head/MAINTAINERS
==
--- head/MAINTAINERSMon Feb 28 05:45:31 2011(r219092)
+++ head/MAINTAINERSMon Feb 28 06:54:14 2011(r219093)
@@ -107,7 +107,7 @@ linux emul  emulation   Please discuss chan
 bs{diff,patch} cpercivaPre-commit review requested.
 portsnap   cpercivaPre-commit review requested.
 freebsd-update cpercivaPre-commit review requested.
-opensslsimon   Pre-commit review requested.
+openssl-   No non-upstream commits should be done.
 sys/netgraph/bluetooth emaxPre-commit review preferred.
 lib/libbluetooth   emaxPre-commit review preferred.
 lib/libsdp emaxPre-commit review preferred.
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219092 - head/sys/cddl/compat/opensolaris/kern

2011-02-27 Thread Pawel Jakub Dawidek
Author: pjd
Date: Mon Feb 28 05:45:31 2011
New Revision: 219092
URL: http://svn.freebsd.org/changeset/base/219092

Log:
  Use proper lock in assertion.
  
  MFC after:1 month

Modified:
  head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c

Modified: head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c
==
--- head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c  Sun Feb 27 
21:32:25 2011(r219091)
+++ head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c  Mon Feb 28 
05:45:31 2011(r219092)
@@ -94,7 +94,7 @@ ddi_get_soft_state_locked(struct ddi_sof
 {
struct ddi_soft_state_item *itemp;
 
-   ASSERT(MUTEX_HELD(&zfsdev_state_lock));
+   ASSERT(MUTEX_HELD(&ss->ss_lock));
 
LIST_FOREACH(itemp, &ss->ss_list, ssi_next) {
if (itemp->ssi_item == item)
@@ -142,7 +142,7 @@ ddi_soft_state_free_locked(struct ddi_so
 {
struct ddi_soft_state_item *itemp;
 
-   ASSERT(MUTEX_HELD(&zfsdev_state_lock));
+   ASSERT(MUTEX_HELD(&ss->ss_lock));
 
LIST_FOREACH(itemp, &ss->ss_list, ssi_next) {
if (itemp->ssi_item == item)
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r219089 - in head: cddl/compat/opensolaris/include cddl/compat/opensolaris/misc cddl/contrib/opensolaris/cmd/stat cddl/contrib/opensolaris/cmd/stat/common cddl/contrib/opensolaris/cmd/

2011-02-27 Thread Doug Barton

On 02/27/2011 11:41, Pawel Jakub Dawidek wrote:

Author: pjd
Date: Sun Feb 27 19:41:40 2011
New Revision: 219089
URL: http://svn.freebsd.org/changeset/base/219089

Log:
   Finally... Import the latest open-source ZFS version - (SPA) 28.


Has this been successfully built with clang? It failed for me with 
-DNO_CLEAN, restarting now with a clean /obj directory.



Doug

--

Nothin' ever doesn't change, but nothin' changes much.
-- OK Go

Breadth of IT experience, and depth of knowledge in the DNS.
Yours for the right price.  :)  http://SupersetSolutions.com/

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r219091 - head/share/timedef

2011-02-27 Thread Bruce Cran
On Sun, 2011-02-27 at 21:32 +, Konrad Jankowski wrote:
> Author: versus
> Date: Sun Feb 27 21:32:25 2011
> New Revision: 219091
> URL: http://svn.freebsd.org/changeset/base/219091
> 
> Log:
>   Partial fix for PR 91106. Correct the short weekday names. Done according 
> to this poll https://bugzilla.redhat.com/show_bug.cgi?id=242296. This will 
> not close the bug fully yet, as the month names are still not correctly in 
> Genitive. More research on this topic will be done, as I'm suspecting a bug 
> in the libc locale functions picking the month name from the wrong group.

Could you limit lines to 80 characters please?
If you use vim, the following in ~/.vimrc will cause it to highlight
overly long lines in red:

highlight OverLength ctermbg=red ctermfg=white guibg=#592929
match OverLength /\%81v.\+/

-- 
Bruce Cran

___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219091 - head/share/timedef

2011-02-27 Thread Konrad Jankowski
Author: versus
Date: Sun Feb 27 21:32:25 2011
New Revision: 219091
URL: http://svn.freebsd.org/changeset/base/219091

Log:
  Partial fix for PR 91106. Correct the short weekday names. Done according to 
this poll https://bugzilla.redhat.com/show_bug.cgi?id=242296. This will not 
close the bug fully yet, as the month names are still not correctly in 
Genitive. More research on this topic will be done, as I'm suspecting a bug in 
the libc locale functions picking the month name from the wrong group.
  
  PR:   conf/91106
  Approved by:  gavin (mentor)
  MFC after:1 month

Modified:
  head/share/timedef/pl_PL.ISO8859-2.src
  head/share/timedef/pl_PL.UTF-8.src

Modified: head/share/timedef/pl_PL.ISO8859-2.src
==
--- head/share/timedef/pl_PL.ISO8859-2.src  Sun Feb 27 19:44:10 2011
(r219090)
+++ head/share/timedef/pl_PL.ISO8859-2.src  Sun Feb 27 21:32:25 2011
(r219091)
@@ -32,12 +32,12 @@ grudnia
 #
 # Short weekday names
 #
-ndz
+nie
 pon
 wto
 �ro
 czw
-ptk
+pi�
 sob
 #
 # Long weekday names

Modified: head/share/timedef/pl_PL.UTF-8.src
==
--- head/share/timedef/pl_PL.UTF-8.src  Sun Feb 27 19:44:10 2011
(r219090)
+++ head/share/timedef/pl_PL.UTF-8.src  Sun Feb 27 21:32:25 2011
(r219091)
@@ -32,12 +32,12 @@ grudnia
 #
 # Short weekday names
 #
-ndz
+nie
 pon
 wto
 śro
 czw
-ptk
+pią
 sob
 #
 # Long weekday names
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219090 - in head: . etc/rc.d

2011-02-27 Thread Pawel Jakub Dawidek
Author: pjd
Date: Sun Feb 27 19:44:10 2011
New Revision: 219090
URL: http://svn.freebsd.org/changeset/base/219090

Log:
  Commit two more files missed in r219089.
  
  MFC after:1 month

Modified:
  head/Makefile.inc1
  head/etc/rc.d/zvol

Modified: head/Makefile.inc1
==
--- head/Makefile.inc1  Sun Feb 27 19:41:40 2011(r219089)
+++ head/Makefile.inc1  Sun Feb 27 19:44:10 2011(r219090)
@@ -1153,6 +1153,7 @@ _prebuild_libs=   ${_kerberos5_lib_libasn1
lib/ncurses/ncurses lib/ncurses/ncursesw \
lib/libopie lib/libpam ${_lib_libthr} \
lib/libradius lib/libsbuf lib/libtacplus \
+   ${_cddl_lib_libumem} \
lib/libutil ${_lib_libypclnt} lib/libz lib/msun \
${_secure_lib_libcrypto} ${_secure_lib_libssh} \
${_secure_lib_libssl}
@@ -1166,6 +1167,7 @@ _generic_libs=${_cddl_lib} gnu/lib ${_k
 lib/libopie__L lib/libtacplus__L: lib/libmd__L
 
 .if ${MK_CDDL} != "no"
+_cddl_lib_libumem= cddl/lib/libumem
 _cddl_lib= cddl/lib
 .endif
 

Modified: head/etc/rc.d/zvol
==
--- head/etc/rc.d/zvol  Sun Feb 27 19:41:40 2011(r219089)
+++ head/etc/rc.d/zvol  Sun Feb 27 19:44:10 2011(r219090)
@@ -17,7 +17,6 @@ required_modules="zfs"
 
 zvol_start()
 {
-   zfs volinit
# Enable swap on ZVOLs with property org.freebsd:swap=on.
zfs list -H -o org.freebsd:swap,name -t volume | \
while read state name; do
@@ -40,7 +39,6 @@ zvol_stop()
;;
esac
done
-   zfs volfini
 }
 
 load_rc_config $name
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219089 - in head: cddl/compat/opensolaris/include cddl/compat/opensolaris/misc cddl/contrib/opensolaris/cmd/stat cddl/contrib/opensolaris/cmd/stat/common cddl/contrib/opensolaris/cmd/z...

2011-02-27 Thread Pawel Jakub Dawidek
Author: pjd
Date: Sun Feb 27 19:41:40 2011
New Revision: 219089
URL: http://svn.freebsd.org/changeset/base/219089

Log:
  Finally... Import the latest open-source ZFS version - (SPA) 28.
  
  Few new things available from now on:
  
  - Data deduplication.
  - Triple parity RAIDZ (RAIDZ3).
  - zfs diff.
  - zpool split.
  - Snapshot holds.
  - zpool import -F. Allows to rewind corrupted pool to earlier
transaction group.
  - Possibility to import pool in read-only mode.
  
  MFC after:1 month

Added:
  head/cddl/compat/opensolaris/include/sha2.h   (contents, props changed)
  head/cddl/compat/opensolaris/include/thread_pool.h   (contents, props changed)
  head/cddl/contrib/opensolaris/cmd/stat/
  head/cddl/contrib/opensolaris/cmd/stat/common/
  head/cddl/contrib/opensolaris/cmd/stat/common/statcommon.h   (contents, props 
changed)
  head/cddl/contrib/opensolaris/cmd/stat/common/timestamp.c   (contents, props 
changed)
  head/cddl/contrib/opensolaris/cmd/zlook/
  head/cddl/contrib/opensolaris/cmd/zlook/zlook.c   (contents, props changed)
  head/cddl/contrib/opensolaris/cmd/zstreamdump/
  head/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.1   (contents, 
props changed)
  head/cddl/contrib/opensolaris/cmd/zstreamdump/zstreamdump.c   (contents, 
props changed)
  head/cddl/contrib/opensolaris/lib/libuutil/common/uu_string.c   (contents, 
props changed)
  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_diff.c   (contents, 
props changed)
  head/cddl/contrib/opensolaris/lib/libzfs/common/libzfs_fru.c   (contents, 
props changed)
  head/cddl/contrib/opensolaris/lib/pyzfs/common/holds.py   (contents, props 
changed)
  head/cddl/contrib/opensolaris/lib/pyzfs/common/table.py   (contents, props 
changed)
  head/cddl/usr.bin/zlook/
  head/cddl/usr.bin/zlook/Makefile   (contents, props changed)
  head/cddl/usr.bin/zstreamdump/
  head/cddl/usr.bin/zstreamdump/Makefile   (contents, props changed)
  head/sys/cddl/boot/zfs/zle.c   (contents, props changed)
  head/sys/cddl/compat/opensolaris/kern/opensolaris_sunddi.c   (contents, props 
changed)
  head/sys/cddl/compat/opensolaris/kern/opensolaris_sysevent.c   (contents, 
props changed)
  head/sys/cddl/compat/opensolaris/sys/systeminfo.h   (contents, props changed)
  head/sys/cddl/contrib/opensolaris/common/zfs/zfs_fletcher.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/common/zfs/zfs_fletcher.h   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/common/zfs/zfs_ioctl_compat.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/common/zfs/zfs_ioctl_compat.h   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/bpobj.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/ddt.c   (contents, props 
changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/ddt_zap.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dmu_diff.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_deadlist.c   
(contents, props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_scan.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sa.c   (contents, props 
changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/bpobj.h   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/ddt.h   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_deadlist.h   
(contents, props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/dsl_scan.h   
(contents, props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/sa.h   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/sa_impl.h   
(contents, props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_onexit.h   
(contents, props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_sa.h   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zfs_stat.h   
(contents, props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/sys/zrlock.h   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_debug.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_onexit.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_sa.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zle.c   (contents, props 
changed)
  head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zrlock.c   (contents, 
props changed)
  head/sys/cddl/contrib/opensolaris/uts/common/os/fm.c   (contents, props 
changed)
  head/sys/cddl/contrib/opensolaris/uts/common/sys/fs/zut.h   (contents, props 
changed)
  head/sys/cddl/contrib/opensolaris/uts/common/sys/sysevent/dev.h   (contents, 
props changed)
Deleted:
  head/sys/cddl/

svn commit: r219088 - stable/8/sbin/quotacheck

2011-02-27 Thread Glen Barber
Author: gjb (doc committer)
Date: Sun Feb 27 18:23:28 2011
New Revision: 219088
URL: http://svn.freebsd.org/changeset/base/219088

Log:
  MFC 205076 [1]:
  
  Fix reference to fsck(8).
  
  PR:   154215
  Submitted by: Mats Erik Andersson (debian of gisladisker se)
  Obtained from:uqs [1]

Modified:
  stable/8/sbin/quotacheck/quotacheck.8
Directory Properties:
  stable/8/sbin/quotacheck/   (props changed)

Modified: stable/8/sbin/quotacheck/quotacheck.8
==
--- stable/8/sbin/quotacheck/quotacheck.8   Sun Feb 27 17:30:45 2011
(r219087)
+++ stable/8/sbin/quotacheck/quotacheck.8   Sun Feb 27 18:23:28 2011
(r219088)
@@ -82,7 +82,7 @@ is zero, parallel passes are run as per
 .Xr fsck 8 .
 This option is deprecated and parallel passes are always run
 as per
-.Xf fsck 8.
+.Xr fsck 8 .
 .It Fl u
 Only user quotas listed in
 .Pa /etc/fstab
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219087 - stable/8/sbin/newfs

2011-02-27 Thread Glen Barber
Author: gjb (doc committer)
Date: Sun Feb 27 17:30:45 2011
New Revision: 219087
URL: http://svn.freebsd.org/changeset/base/219087

Log:
  MFC 212498:
  
  Rewording and typo fixes in newfs(8).
  
  PR:   150490

Modified:
  stable/8/sbin/newfs/newfs.8
Directory Properties:
  stable/8/sbin/newfs/   (props changed)

Modified: stable/8/sbin/newfs/newfs.8
==
--- stable/8/sbin/newfs/newfs.8 Sun Feb 27 17:14:06 2011(r219086)
+++ stable/8/sbin/newfs/newfs.8 Sun Feb 27 17:30:45 2011(r219087)
@@ -79,10 +79,10 @@ The following options define the general
 Erase the content of the disk before making the filesystem.
 The reserved area in front of the superblock (for bootcode) will not be erased.
 
-This is a relevant option for flash based storage devices that use
-wear levelling algorithms.
+This option is only relevant for flash based storage devices that use
+wear-leveling algorithms.
 
-NB: Erasing may take as long time as writing every sector on the disk.
+Erasing may take a long time as it writes to every sector on the disk.
 .It Fl J
 Enable journaling on the new file system via gjournal.
 See
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219086 - head/share/man/man4

2011-02-27 Thread Glen Barber
Author: gjb (doc committer)
Date: Sun Feb 27 17:14:06 2011
New Revision: 219086
URL: http://svn.freebsd.org/changeset/base/219086

Log:
  Fix typo in kernel configuration entry.
  
  PR:   155074
  Submitted by: Warren Block (wblock of wonkity com)
  MFC after:3 days

Modified:
  head/share/man/man4/usb_quirk.4

Modified: head/share/man/man4/usb_quirk.4
==
--- head/share/man/man4/usb_quirk.4 Sun Feb 27 13:58:20 2011
(r219085)
+++ head/share/man/man4/usb_quirk.4 Sun Feb 27 17:14:06 2011
(r219086)
@@ -16,7 +16,7 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd November 9, 2010
+.Dd February 27, 2011
 .Dt USB_QUIRK 4
 .Os
 .Sh NAME
@@ -27,7 +27,7 @@ To compile this module into the kernel,
 place the following line in your
 kernel configuration file:
 .Bd -ragged -offset indent
-.Cd "device usb"
+.Cd "device usb_quirk"
 .Ed
 .Pp
 Alternatively, to load the module at boot
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r219084 - in head: bin/test tools/regression/bin/test

2011-02-27 Thread Alexander Leidinger
Quoting Joerg Sonnenberger  (from Sun, 27 Feb  
2011 15:29:10 +0100):



On Sun, Feb 27, 2011 at 03:11:43PM +0100, Erik Trulsson wrote:

On Sun, Feb 27, 2011 at 01:30:58PM +0100, Joerg Sonnenberger wrote:
> On Sun, Feb 27, 2011 at 12:28:06PM +, Xin LI wrote:
> > Author: delphij
> > Date: Sun Feb 27 12:28:06 2011
> > New Revision: 219084
> > URL: http://svn.freebsd.org/changeset/base/219084
> >
> > Log:
> >   Accept == as an alias of = which is a popular GNU extension.
>
> It is not a popular GNU extension. It is crap only bash supports.
> Do you really want to encourage that?

In what way is it 'crap', and in what way would adding support for it
be a problem?


It is completely redundant and inconsistent with pretty much every other
test(1) implementation. E.g. it isn't even supported by /bin/test from
coretutils. The very presence of this in various shell scripts is a
direct result of silently accepting it in bash, even in sh mode. This is
just further encouragement to legalize it.


For your info, at work we got a script (for Solaris) which had a mix  
of = and == (and [ ] and [[ ]]) as a delivery of some software.  
Needless to say it didn't work as expected. I also think that adding  
support for == encourages bad scripts.


Bye,
Alexander.

--
10.0 times 0.1 is hardly ever 1.0.

http://www.Leidinger.netAlexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org   netchild @ FreeBSD.org  : PGP ID = 72077137
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r219084 - in head: bin/test tools/regression/bin/test

2011-02-27 Thread Joerg Sonnenberger
On Sun, Feb 27, 2011 at 03:11:43PM +0100, Erik Trulsson wrote:
> On Sun, Feb 27, 2011 at 01:30:58PM +0100, Joerg Sonnenberger wrote:
> > On Sun, Feb 27, 2011 at 12:28:06PM +, Xin LI wrote:
> > > Author: delphij
> > > Date: Sun Feb 27 12:28:06 2011
> > > New Revision: 219084
> > > URL: http://svn.freebsd.org/changeset/base/219084
> > > 
> > > Log:
> > >   Accept == as an alias of = which is a popular GNU extension.
> > 
> > It is not a popular GNU extension. It is crap only bash supports.
> > Do you really want to encourage that?
> 
> In what way is it 'crap', and in what way would adding support for it
> be a problem?

It is completely redundant and inconsistent with pretty much every other
test(1) implementation. E.g. it isn't even supported by /bin/test from
coretutils. The very presence of this in various shell scripts is a
direct result of silently accepting it in bash, even in sh mode. This is
just further encouragement to legalize it.

Joerg
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r219084 - in head: bin/test tools/regression/bin/test

2011-02-27 Thread Erik Trulsson
On Sun, Feb 27, 2011 at 01:30:58PM +0100, Joerg Sonnenberger wrote:
> On Sun, Feb 27, 2011 at 12:28:06PM +, Xin LI wrote:
> > Author: delphij
> > Date: Sun Feb 27 12:28:06 2011
> > New Revision: 219084
> > URL: http://svn.freebsd.org/changeset/base/219084
> > 
> > Log:
> >   Accept == as an alias of = which is a popular GNU extension.
> 
> It is not a popular GNU extension. It is crap only bash supports.
> Do you really want to encourage that?

In what way is it 'crap', and in what way would adding support for it
be a problem?



-- 

Erik Trulsson
ertr1...@student.uu.se
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219085 - head/sys/dev/sdhci

2011-02-27 Thread Pawel Jakub Dawidek
Author: pjd
Date: Sun Feb 27 13:58:20 2011
New Revision: 219085
URL: http://svn.freebsd.org/changeset/base/219085

Log:
  Force DMA for controller found in Lenovo T510 (probably in others too).
  This makes reads 10 times faster.
  
  Discussed with:   mav

Modified:
  head/sys/dev/sdhci/sdhci.c

Modified: head/sys/dev/sdhci/sdhci.c
==
--- head/sys/dev/sdhci/sdhci.c  Sun Feb 27 12:28:06 2011(r219084)
+++ head/sys/dev/sdhci/sdhci.c  Sun Feb 27 13:58:20 2011(r219085)
@@ -83,6 +83,8 @@ static const struct sdhci_device {
 } sdhci_devices[] = {
{ 0x08221180,   0x, "RICOH R5C822 SD",
SDHCI_QUIRK_FORCE_DMA },
+   { 0xe8221180,   0x, "RICOH SD",
+   SDHCI_QUIRK_FORCE_DMA },
{ 0x8034104c,   0x, "TI XX21/XX11 SD",
SDHCI_QUIRK_FORCE_DMA },
{ 0x05501524,   0x, "ENE CB712 SD",
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r218966 - head/sys/vm

2011-02-27 Thread Kostik Belousov
On Sun, Feb 27, 2011 at 11:12:03PM +1100, Bruce Evans wrote:
> On Sun, 27 Feb 2011, Bruce Cran wrote:
> 
> >On Thu, 2011-02-24 at 10:36 +1100, Bruce Evans wrote:
> >>
> >>I would cast operand(s) in the expression as necessary to prevent overflow
> >>of subexpressions.  vm_pindex_t would work, but I prefer to use a type
> >>related to the subexpressions.  Not sure what that is.  Maybe just
> >>uintmax_t for safety (even that is not safe if the subexpressions have
> >>large values).  So:
> >>
> >> (uintmax_t)swap_bcount * SWAP_META_PAGES * n / mumble.
> >
> >Following Alan's suggestion, I've attached an updated patch which uses a
> >cast to u_long and returns long.
> 
> I thought he only meant to return long.  The units being returned are
> PAGE_SIZE smaller than the units in the expression.  But I don't know
> exacty how large swp_bcount can be.  If everything fits in a single
> object, then vm_size_t = u_int on 32-bit machines is enough.

I think that return type should be left as vm_offset_t. The calculation
basically returns some quantity of type vm_offset_t, divided by PAGE_SIZE.
This validates the new return type.

The calculation could use vm_offset_t, or uintmax_t cast, probably
vm_offset_t is preferred for the same reason.


pgpu5aew5KUQ3.pgp
Description: PGP signature


Re: svn commit: r219084 - in head: bin/test tools/regression/bin/test

2011-02-27 Thread Joerg Sonnenberger
On Sun, Feb 27, 2011 at 12:28:06PM +, Xin LI wrote:
> Author: delphij
> Date: Sun Feb 27 12:28:06 2011
> New Revision: 219084
> URL: http://svn.freebsd.org/changeset/base/219084
> 
> Log:
>   Accept == as an alias of = which is a popular GNU extension.

It is not a popular GNU extension. It is crap only bash supports.
Do you really want to encourage that?

Joerg
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219084 - in head: bin/test tools/regression/bin/test

2011-02-27 Thread Xin LI
Author: delphij
Date: Sun Feb 27 12:28:06 2011
New Revision: 219084
URL: http://svn.freebsd.org/changeset/base/219084

Log:
  Accept == as an alias of = which is a popular GNU extension.
  
  This is intentionally undocumented for now since it's not part
  of any standard.
  
  MFC after:1 month

Modified:
  head/bin/test/test.c
  head/tools/regression/bin/test/regress.sh

Modified: head/bin/test/test.c
==
--- head/bin/test/test.cSun Feb 27 12:25:47 2011(r219083)
+++ head/bin/test/test.cSun Feb 27 12:28:06 2011(r219084)
@@ -144,6 +144,7 @@ struct t_op {
{"-L",  FILSYM, UNOP},
{"-S",  FILSOCK,UNOP},
{"=",   STREQ,  BINOP},
+   {"==",  STREQ,  BINOP},
{"!=",  STRNE,  BINOP},
{"<",   STRLT,  BINOP},
{">",   STRGT,  BINOP},

Modified: head/tools/regression/bin/test/regress.sh
==
--- head/tools/regression/bin/test/regress.sh   Sun Feb 27 12:25:47 2011
(r219083)
+++ head/tools/regression/bin/test/regress.sh   Sun Feb 27 12:28:06 2011
(r219084)
@@ -52,12 +52,15 @@ t ()
 }
 
 count=0
-echo "1..94"
+echo "1..97"
 
 t 0 'b = b' 
+t 0 'b == b' 
 t 1 'b != b' 
 t 0 '\( b = b \)' 
+t 0 '\( b == b \)' 
 t 1 '! \( b = b \)' 
+t 1 '! \( b == b \)' 
 t 1 '! -f /etc/passwd'
 
 t 0 '-h = -h'
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219083 - head/sys/boot/common

2011-02-27 Thread Pawel Jakub Dawidek
Author: pjd
Date: Sun Feb 27 12:25:47 2011
New Revision: 219083
URL: http://svn.freebsd.org/changeset/base/219083

Log:
  Rename bcpy() macro to bcopy().

Modified:
  head/sys/boot/common/gpt.c
  head/sys/boot/common/util.h

Modified: head/sys/boot/common/gpt.c
==
--- head/sys/boot/common/gpt.c  Sun Feb 27 11:40:20 2011(r219082)
+++ head/sys/boot/common/gpt.c  Sun Feb 27 12:25:47 2011(r219083)
@@ -71,7 +71,7 @@ gptupdate(const char *which, struct dsk 
entries_per_sec = DEV_BSIZE / hdr->hdr_entsz;
slba = curent / entries_per_sec;
firstent = slba * entries_per_sec;
-   bcpy(&table[firstent], secbuf, DEV_BSIZE);
+   bcopy(&table[firstent], secbuf, DEV_BSIZE);
slba += hdr->hdr_lba_table;
if (drvwrite(dskp, secbuf, slba, 1)) {
printf("%s: unable to update %s GPT partition table\n",
@@ -82,7 +82,7 @@ gptupdate(const char *which, struct dsk 
hdr->hdr_crc_self = 0;
hdr->hdr_crc_self = crc32(hdr, hdr->hdr_size);
bzero(secbuf, DEV_BSIZE);
-   bcpy(hdr, secbuf, hdr->hdr_size);
+   bcopy(hdr, secbuf, hdr->hdr_size);
if (drvwrite(dskp, secbuf, hdr->hdr_lba_self, 1)) {
printf("%s: unable to update %s GPT header\n", BOOTPROG, which);
return;
@@ -191,7 +191,7 @@ gptread_hdr(const char *which, struct ds
printf("%s: unable to read %s GPT header\n", BOOTPROG, which);
return (-1);
}
-   bcpy(secbuf, hdr, sizeof(*hdr));
+   bcopy(secbuf, hdr, sizeof(*hdr));
if (bcmp(hdr->hdr_sig, GPT_HDR_SIG, sizeof(hdr->hdr_sig)) != 0 ||
hdr->hdr_lba_self != hdrlba || hdr->hdr_revision < 0x0001 ||
hdr->hdr_entsz < sizeof(struct gpt_ent) ||
@@ -259,7 +259,7 @@ gptbootconv(const char *which, struct ds
}
if (!sector_updated)
continue;
-   bcpy(&table[nent], secbuf, DEV_BSIZE);
+   bcopy(&table[nent], secbuf, DEV_BSIZE);
if (drvwrite(dskp, secbuf, slba, 1)) {
printf("%s: unable to update %s GPT partition table\n",
BOOTPROG, which);
@@ -271,7 +271,7 @@ gptbootconv(const char *which, struct ds
hdr->hdr_crc_self = 0;
hdr->hdr_crc_self = crc32(hdr, hdr->hdr_size);
bzero(secbuf, DEV_BSIZE);
-   bcpy(hdr, secbuf, hdr->hdr_size);
+   bcopy(hdr, secbuf, hdr->hdr_size);
if (drvwrite(dskp, secbuf, hdr->hdr_lba_self, 1))
printf("%s: unable to update %s GPT header\n", BOOTPROG, which);
 }
@@ -299,7 +299,7 @@ gptread_table(const char *which, const u
}
ent = (struct gpt_ent *)secbuf;
for (part = 0; part < entries_per_sec; part++, ent++) {
-   bcpy(ent, &table[nent], sizeof(table[nent]));
+   bcopy(ent, &table[nent], sizeof(table[nent]));
if (++nent >= hdr->hdr_entries)
break;
}

Modified: head/sys/boot/common/util.h
==
--- head/sys/boot/common/util.h Sun Feb 27 11:40:20 2011(r219082)
+++ head/sys/boot/common/util.h Sun Feb 27 12:25:47 2011(r219083)
@@ -37,7 +37,7 @@ void memcpy(void *dst, const void *src, 
 void memset(void *b, int c, size_t len);
 int memcmp(const void *b1, const void *b2, size_t len);
 
-#definebcpy(src, dst, len) memcpy((dst), (src), (len))
+#definebcopy(src, dst, len)memcpy((dst), (src), (len))
 #definebzero(buf, size)memset((buf), 0, (size))
 #definebcmp(b1, b2, len)   (memcmp((b1), (b2), (len)) != 0)
 
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r218966 - head/sys/vm

2011-02-27 Thread Bruce Evans

On Sun, 27 Feb 2011, Bruce Cran wrote:


On Thu, 2011-02-24 at 10:36 +1100, Bruce Evans wrote:


I would cast operand(s) in the expression as necessary to prevent overflow
of subexpressions.  vm_pindex_t would work, but I prefer to use a type
related to the subexpressions.  Not sure what that is.  Maybe just
uintmax_t for safety (even that is not safe if the subexpressions have
large values).  So:

 (uintmax_t)swap_bcount * SWAP_META_PAGES * n / mumble.


Following Alan's suggestion, I've attached an updated patch which uses a
cast to u_long and returns long.


I thought he only meant to return long.  The units being returned are
PAGE_SIZE smaller than the units in the expression.  But I don't know
exacty how large swp_bcount can be.  If everything fits in a single
object, then vm_size_t = u_int on 32-bit machines is enough.

Bruce
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r219043 - in head/usr.bin: kdump ktrace

2011-02-27 Thread Chagin Dmitry
On Fri, Feb 25, 2011 at 05:22:30PM -0500, John Baldwin wrote:
> On Friday, February 25, 2011 5:07:23 pm Dmitry Chagin wrote:
> > Author: dchagin
> > Date: Fri Feb 25 22:07:23 2011
> > New Revision: 219043
> > URL: http://svn.freebsd.org/changeset/base/219043
> > 
> > Log:
> >   Teach kdump to understand sv_flags records in the trace files.
> >   
> >   MFC after:1 Month.
> 
> Ohhh, are you going to merge in Linux kdump?? :)
> 

http://www.freebsd.org/cgi/query-pr.cgi?pr=155083  :)

-- 
Have fun!
chd


pgpCbzOG7KI1L.pgp
Description: PGP signature


svn commit: r219082 - head/etc/rc.d

2011-02-27 Thread Pawel Jakub Dawidek
Author: pjd
Date: Sun Feb 27 11:40:20 2011
New Revision: 219082
URL: http://svn.freebsd.org/changeset/base/219082

Log:
  Recognize 'reload' command, as hastd can be reloaded with the SIGHUP signal.
  
  MFC after:1 week

Modified:
  head/etc/rc.d/hastd

Modified: head/etc/rc.d/hastd
==
--- head/etc/rc.d/hastd Sun Feb 27 10:13:16 2011(r219081)
+++ head/etc/rc.d/hastd Sun Feb 27 11:40:20 2011(r219082)
@@ -18,6 +18,7 @@ hastctl="/sbin/hastctl"
 required_files="/etc/hast.conf"
 stop_precmd="hastd_stop_precmd"
 required_modules="geom_gate:g_gate"
+extra_commands="reload"
 
 hastd_stop_precmd()
 {
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


svn commit: r219081 - head/contrib/lukemftp/src

2011-02-27 Thread Bruce Cran
Author: brucec
Date: Sun Feb 27 10:13:16 2011
New Revision: 219081
URL: http://svn.freebsd.org/changeset/base/219081

Log:
  Merge fix from r1.108 of NetBSD's usr.bin/ftp/main.c:
  
  Only attempt to el_parse() a command unknown by the default parser
  if editing is enabled.
  
  PR:   bin/100089
  MFC after:3 days

Modified:
  head/contrib/lukemftp/src/main.c

Modified: head/contrib/lukemftp/src/main.c
==
--- head/contrib/lukemftp/src/main.cSun Feb 27 09:12:24 2011
(r219080)
+++ head/contrib/lukemftp/src/main.cSun Feb 27 10:13:16 2011
(r219081)
@@ -707,6 +707,7 @@ cmdscanner(void)
 * such commands as invalid.
 */
if (strchr(margv[0], ':') != NULL ||
+   !editing ||
el_parse(el, margc, (const char **)margv) != 0)
 #endif /* !NO_EDITCOMPLETE */
fputs("?Invalid command.\n", ttyout);
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"


Re: svn commit: r218966 - head/sys/vm

2011-02-27 Thread Bruce Cran
On Thu, 2011-02-24 at 10:36 +1100, Bruce Evans wrote:
> 
> I would cast operand(s) in the expression as necessary to prevent overflow
> of subexpressions.  vm_pindex_t would work, but I prefer to use a type
> related to the subexpressions.  Not sure what that is.  Maybe just
> uintmax_t for safety (even that is not safe if the subexpressions have
> large values).  So:
> 
>  (uintmax_t)swap_bcount * SWAP_META_PAGES * n / mumble.

Following Alan's suggestion, I've attached an updated patch which uses a
cast to u_long and returns long.

-- 
Bruce Cran
Index: vm_map.h
===
--- vm_map.h	(revision 219050)
+++ vm_map.h	(working copy)
@@ -380,6 +380,6 @@
 int flags);
 int vm_map_wire(vm_map_t map, vm_offset_t start, vm_offset_t end,
 int flags);
-vm_offset_t vmspace_swap_count(struct vmspace *vmspace);
+long vmspace_swap_count(struct vmspace *vmspace);
 #endif/* _KERNEL */
 #endif/* _VM_MAP_ */
Index: swap_pager.c
===
--- swap_pager.c	(revision 219050)
+++ swap_pager.c	(working copy)
@@ -2420,13 +2420,13 @@
  *	if the VM object has any swap use at all the associated map entries
  *	count for at least 1 swap page.
  */
-vm_offset_t
+long
 vmspace_swap_count(struct vmspace *vmspace)
 {
 	vm_map_t map;
 	vm_map_entry_t cur;
 	vm_object_t object;
-	vm_offset_t count, n;
+	long count, n;
 
 	map = &vmspace->vm_map;
 	count = 0;
@@ -2438,7 +2438,7 @@
 			if (object->type == OBJT_SWAP &&
 			object->un_pager.swp.swp_bcount != 0) {
 n = (cur->end - cur->start) / PAGE_SIZE;
-count += object->un_pager.swp.swp_bcount *
+count += (u_long)object->un_pager.swp.swp_bcount *
 SWAP_META_PAGES * n / object->size + 1;
 			}
 			VM_OBJECT_UNLOCK(object);
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r219080 - in stable/8: include share/man/man3

2011-02-27 Thread Konstantin Belousov
Author: kib
Date: Sun Feb 27 09:12:24 2011
New Revision: 219080
URL: http://svn.freebsd.org/changeset/base/219080

Log:
  MFC r218881:
  Add restrict keyword to pthread_sigmask prototype and manpage.

Modified:
  stable/8/include/signal.h
  stable/8/share/man/man3/pthread_sigmask.3
Directory Properties:
  stable/8/include/   (props changed)
  stable/8/share/man/man3/   (props changed)

Modified: stable/8/include/signal.h
==
--- stable/8/include/signal.h   Sun Feb 27 02:06:09 2011(r219079)
+++ stable/8/include/signal.h   Sun Feb 27 09:12:24 2011(r219080)
@@ -73,7 +73,8 @@ int   raise(int);
 #if __POSIX_VISIBLE || __XSI_VISIBLE
 intkill(__pid_t, int);
 intpthread_kill(__pthread_t, int);
-intpthread_sigmask(int, const __sigset_t *, __sigset_t *);
+intpthread_sigmask(int, const __sigset_t * __restrict,
+   __sigset_t * __restrict);
 intsigaction(int, const struct sigaction * __restrict,
struct sigaction * __restrict);
 intsigaddset(sigset_t *, int);

Modified: stable/8/share/man/man3/pthread_sigmask.3
==
--- stable/8/share/man/man3/pthread_sigmask.3   Sun Feb 27 02:06:09 2011
(r219079)
+++ stable/8/share/man/man3/pthread_sigmask.3   Sun Feb 27 09:12:24 2011
(r219080)
@@ -26,7 +26,7 @@
 .\" EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 .\"
 .\" $FreeBSD$
-.Dd April 27, 2000
+.Dd February 19, 2011
 .Dt PTHREAD_SIGMASK 3
 .Os
 .Sh NAME
@@ -38,7 +38,8 @@
 .In pthread.h
 .In signal.h
 .Ft int
-.Fn pthread_sigmask "int how" "const sigset_t *set" "sigset_t *oset"
+.Fn pthread_sigmask "int how" "const sigset_t * restrict set" \
+"sigset_t * restrict oset"
 .Sh DESCRIPTION
 The
 .Fn pthread_sigmask
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"