Re: svn commit: r366804 - stable/10/usr.bin/calendar/calendars

[Greg 'groggy' Lehey]

On Sunday, 18 October 2020 at  1:57:50 +, Greg Lehey wrote:
> Author: grog
>
> Log:
>   Correct location and date of the Boston Shoemakers' organization,
> ...
>
> Modified:
>   stable/10/usr.bin/calendar/calendars/calendar.history

Ugh.  Wrong branch.  Please ignore.  I've committed to head.

Greg
--
Sent from my desktop computer.
See complete headers for address and phone numbers.
This message is digitally signed.  If your Microsoft mail program
reports problems, please read http://lemis.com/broken-MUA


signature.asc
Description: PGP signature

svn commit: r366805 - head/usr.bin/calendar/calendars

[Greg Lehey]

Author: grog
Date: Sun Oct 18 03:01:26 2020
New Revision: 366805
URL: https://svnweb.freebsd.org/changeset/base/366805

Log:
  Correct location and date of the Boston Shoemakers' organization,
  which significantly predated the USA.
  
  Reference: 
http://www.famousdaily.com/history/boston-shoemakers-form-first-us-labor-organization.html

Modified:
  head/usr.bin/calendar/calendars/calendar.history

Modified: head/usr.bin/calendar/calendars/calendar.history
==
--- head/usr.bin/calendar/calendars/calendar.historySun Oct 18 01:57:49 
2020(r366804)
+++ head/usr.bin/calendar/calendars/calendar.historySun Oct 18 03:01:26 
2020(r366805)
@@ -582,9 +582,9 @@
 10/16  The Walt Disney Company is founded by Walt Disney
and his brother, Roy Disney, 1923
 10/17  Al Capone convicted of income tax evasion, 1931
-10/18  Boston Shoemakers form first US labor org., 1648
 10/18  Soviets announce their probe took photos of the Moon's far side, 1959
 10/18  The Grand Ole Opry opens its doors, 1925
+10/19  Boston Shoemakers form first American labor organization, 1648
 10/19  Mao Tse-tung establishes the People's Republic of China, 1949
 10/19  Napoleon's beaten army begins the long retreat from Moscow, 1812
 10/20  "Saturday Night Massacre", 1973
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366804 - stable/10/usr.bin/calendar/calendars

[Greg Lehey]

Author: grog
Date: Sun Oct 18 01:57:49 2020
New Revision: 366804
URL: https://svnweb.freebsd.org/changeset/base/366804

Log:
  Correct location and date of the Boston Shoemakers' organization,
  which significantly predated the USA.
  
  Reference: 
http://www.famousdaily.com/history/boston-shoemakers-form-first-us-labor-organization.html

Modified:
  stable/10/usr.bin/calendar/calendars/calendar.history

Modified: stable/10/usr.bin/calendar/calendars/calendar.history
==
--- stable/10/usr.bin/calendar/calendars/calendar.history   Sun Oct 18 
01:13:41 2020(r366803)
+++ stable/10/usr.bin/calendar/calendars/calendar.history   Sun Oct 18 
01:57:49 2020(r366804)
@@ -368,8 +368,8 @@
 10/14  Battle of Hastings won by William the Conqueror and the Normans, 1066
 10/14  Chuck Yeager breaks sound barrier, 1947
 10/15  First draft card burned, 1965
-10/18  Boston Shoemakers form first US labor org., 1648
 10/18  Soviets announce their probe took photos of the Moon's far side, 1959
+10/19  Boston Shoemakers form first American labor organization, 1648
 10/19  Mao Tse-tung establishes the People's Republic of China, 1949
 10/19  Napoleon's beaten army begins the long retreat from Moscow, 1812
 10/20  "Saturday Night Massacre", 1973
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366803 - stable/12/sbin/nvmecontrol

[Alexander Motin]

Author: mav
Date: Sun Oct 18 01:13:41 2020
New Revision: 366803
URL: https://svnweb.freebsd.org/changeset/base/366803

Log:
  MFC r366730: Fix nvmecontrol logpage -i parameter.

Modified:
  stable/12/sbin/nvmecontrol/logpage.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sbin/nvmecontrol/logpage.c
==
--- stable/12/sbin/nvmecontrol/logpage.cSun Oct 18 01:10:06 2020
(r366802)
+++ stable/12/sbin/nvmecontrol/logpage.cSun Oct 18 01:13:41 2020
(r366803)
@@ -84,7 +84,7 @@ static const struct opts logpage_opts[] = {
"Page to dump"),
OPT("lsp", 'f', arg_uint8, opt, lsp,
"Log Specific Field"),
-   OPT("lsi", 'i', arg_uint16, opt, lsp,
+   OPT("lsi", 'i', arg_uint16, opt, lsi,
"Log Specific Identifier"),
OPT("rae", 'r', arg_none, opt, rae,
"Retain Asynchronous Event"),
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366802 - stable/11/contrib/tzdata

[Philip Paeps]

Author: philip
Date: Sun Oct 18 01:10:06 2020
New Revision: 366802
URL: https://svnweb.freebsd.org/changeset/base/366802

Log:
  MFC r366779: Import tzdata 2020c

Modified:
  stable/11/contrib/tzdata/Makefile
  stable/11/contrib/tzdata/NEWS
  stable/11/contrib/tzdata/australasia
  stable/11/contrib/tzdata/europe
  stable/11/contrib/tzdata/version
  stable/11/contrib/tzdata/ziguard.awk
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/contrib/tzdata/Makefile
==
--- stable/11/contrib/tzdata/Makefile   Sun Oct 18 01:09:55 2020
(r366801)
+++ stable/11/contrib/tzdata/Makefile   Sun Oct 18 01:10:06 2020
(r366802)
@@ -1022,10 +1022,14 @@ tzdata$(VERSION)-rearguard.tar.gz: rearguard.zi set-ti
done
sed '1s/$$/-rearguard/' \
  tzdata$(VERSION)-rearguard.dir/version
+   : The dummy pacificnew pacifies TZUpdater 2.3.1 and earlier.
+   touch -md 2020-10-12T22:53:00Z \
+ tzdata$(VERSION)-rearguard.dir/pacificnew
touch -cmr version tzdata$(VERSION)-rearguard.dir/version
LC_ALL=C && export LC_ALL && \
  (cd tzdata$(VERSION)-rearguard.dir && \
-  tar $(TARFLAGS) -cf - $(COMMON) $(DATA) $(MISC) | \
+  tar $(TARFLAGS) -cf - \
+   $(COMMON) $(DATA) $(MISC) pacificnew | \
 gzip $(GZIPFLAGS)) >$@.out
mv $@.out $@
 

Modified: stable/11/contrib/tzdata/NEWS
==
--- stable/11/contrib/tzdata/NEWS   Sun Oct 18 01:09:55 2020
(r366801)
+++ stable/11/contrib/tzdata/NEWS   Sun Oct 18 01:10:06 2020
(r366802)
@@ -1,5 +1,25 @@
 News for the tz database
 
+Release 2020c - 2020-10-16 11:15:53 -0700
+
+  Briefly:
+Fiji starts DST later than usual, on 2020-12-20.
+
+  Changes to future timestamps
+
+Fiji will start DST on 2020-12-20, instead of 2020-11-08 as
+previously predicted.  DST will still end on 2021-01-17.
+(Thanks to Raymond Kumar and Alan Mintz.)  Assume for now that
+the later-than-usual start date is a one-time departure from the
+recent pattern.
+
+  Changes to build procedure
+
+Rearguard tarballs now contain an empty file pacificnew.
+Some older downstream software expects this file to exist.
+(Problem reported by Mike Cullinan.)
+
+
 Release 2020b - 2020-10-06 18:35:04 -0700
 
   Briefly:

Modified: stable/11/contrib/tzdata/australasia
==
--- stable/11/contrib/tzdata/australasiaSun Oct 18 01:09:55 2020
(r366801)
+++ stable/11/contrib/tzdata/australasiaSun Oct 18 01:10:06 2020
(r366802)
@@ -381,6 +381,19 @@ Zone   Indian/Cocos6:27:40 -   LMT 1900
 # From Michael Deckers (2019-08-06):
 # https://www.laws.gov.fj/LawsAsMade/downloadfile/848
 
+# From Raymond Kumar (2020-10-08):
+# [DST in Fiji] is from December 20th 2020, till 17th January 2021.
+# From Alan Mintz (2020-10-08):
+# https://www.laws.gov.fj/LawsAsMade/GetFile/1071
+# From Tim Parenti (2020-10-08):
+# 
https://www.fijivillage.com/news/Daylight-saving-from-Dec-20th-this-year-to-Jan-17th-2021-8rf4x5/
+# "Minister for Employment, Parveen Bala says they had never thought of
+# stopping daylight saving. He says it was just to decide on when it should
+# start and end.  Bala says it is a short period..."
+# Since the end date is still in line with our ongoing predictions, assume for
+# now that the later-than-usual start date is a one-time departure from the
+# recent second Sunday in November pattern.
+
 # Rule NAMEFROMTO  -   IN  ON  AT  SAVELETTER/S
 Rule   Fiji19981999-   Nov Sun>=1  2:001:00-
 Rule   Fiji19992000-   Feb lastSun 3:000   -
@@ -392,7 +405,9 @@ RuleFiji20122013-   Jan Sun>=18 
3:000   -
 Rule   Fiji2014only-   Jan Sun>=18 2:000   -
 Rule   Fiji20142018-   Nov Sun>=1  2:001:00-
 Rule   Fiji2015max -   Jan Sun>=12 3:000   -
-Rule   Fiji2019max -   Nov Sun>=8  2:001:00-
+Rule   Fiji2019only-   Nov Sun>=8  2:001:00-
+Rule   Fiji2020only-   Dec 20  2:001:00-
+Rule   Fiji2021max -   Nov Sun>=8  2:001:00-
 # Zone NAMESTDOFF  RULES   FORMAT  [UNTIL]
 Zone   Pacific/Fiji11:55:44 -  LMT 1915 Oct 26 # Suva
12:00   Fiji+12/+13

Modified: stable/11/contrib/tzdata/europe
==
--- stable/11/contrib/tzdata/europe Sun Oct 18 01:09:55 2020  

svn commit: r366801 - stable/12/contrib/tzdata

[Philip Paeps]

Author: philip
Date: Sun Oct 18 01:09:55 2020
New Revision: 366801
URL: https://svnweb.freebsd.org/changeset/base/366801

Log:
  MFC r366779: Import tzdata 2020c

Modified:
  stable/12/contrib/tzdata/Makefile
  stable/12/contrib/tzdata/NEWS
  stable/12/contrib/tzdata/australasia
  stable/12/contrib/tzdata/europe
  stable/12/contrib/tzdata/version
  stable/12/contrib/tzdata/ziguard.awk
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/contrib/tzdata/Makefile
==
--- stable/12/contrib/tzdata/Makefile   Sun Oct 18 00:27:20 2020
(r366800)
+++ stable/12/contrib/tzdata/Makefile   Sun Oct 18 01:09:55 2020
(r366801)
@@ -1022,10 +1022,14 @@ tzdata$(VERSION)-rearguard.tar.gz: rearguard.zi set-ti
done
sed '1s/$$/-rearguard/' \
  tzdata$(VERSION)-rearguard.dir/version
+   : The dummy pacificnew pacifies TZUpdater 2.3.1 and earlier.
+   touch -md 2020-10-12T22:53:00Z \
+ tzdata$(VERSION)-rearguard.dir/pacificnew
touch -cmr version tzdata$(VERSION)-rearguard.dir/version
LC_ALL=C && export LC_ALL && \
  (cd tzdata$(VERSION)-rearguard.dir && \
-  tar $(TARFLAGS) -cf - $(COMMON) $(DATA) $(MISC) | \
+  tar $(TARFLAGS) -cf - \
+   $(COMMON) $(DATA) $(MISC) pacificnew | \
 gzip $(GZIPFLAGS)) >$@.out
mv $@.out $@
 

Modified: stable/12/contrib/tzdata/NEWS
==
--- stable/12/contrib/tzdata/NEWS   Sun Oct 18 00:27:20 2020
(r366800)
+++ stable/12/contrib/tzdata/NEWS   Sun Oct 18 01:09:55 2020
(r366801)
@@ -1,5 +1,25 @@
 News for the tz database
 
+Release 2020c - 2020-10-16 11:15:53 -0700
+
+  Briefly:
+Fiji starts DST later than usual, on 2020-12-20.
+
+  Changes to future timestamps
+
+Fiji will start DST on 2020-12-20, instead of 2020-11-08 as
+previously predicted.  DST will still end on 2021-01-17.
+(Thanks to Raymond Kumar and Alan Mintz.)  Assume for now that
+the later-than-usual start date is a one-time departure from the
+recent pattern.
+
+  Changes to build procedure
+
+Rearguard tarballs now contain an empty file pacificnew.
+Some older downstream software expects this file to exist.
+(Problem reported by Mike Cullinan.)
+
+
 Release 2020b - 2020-10-06 18:35:04 -0700
 
   Briefly:

Modified: stable/12/contrib/tzdata/australasia
==
--- stable/12/contrib/tzdata/australasiaSun Oct 18 00:27:20 2020
(r366800)
+++ stable/12/contrib/tzdata/australasiaSun Oct 18 01:09:55 2020
(r366801)
@@ -381,6 +381,19 @@ Zone   Indian/Cocos6:27:40 -   LMT 1900
 # From Michael Deckers (2019-08-06):
 # https://www.laws.gov.fj/LawsAsMade/downloadfile/848
 
+# From Raymond Kumar (2020-10-08):
+# [DST in Fiji] is from December 20th 2020, till 17th January 2021.
+# From Alan Mintz (2020-10-08):
+# https://www.laws.gov.fj/LawsAsMade/GetFile/1071
+# From Tim Parenti (2020-10-08):
+# 
https://www.fijivillage.com/news/Daylight-saving-from-Dec-20th-this-year-to-Jan-17th-2021-8rf4x5/
+# "Minister for Employment, Parveen Bala says they had never thought of
+# stopping daylight saving. He says it was just to decide on when it should
+# start and end.  Bala says it is a short period..."
+# Since the end date is still in line with our ongoing predictions, assume for
+# now that the later-than-usual start date is a one-time departure from the
+# recent second Sunday in November pattern.
+
 # Rule NAMEFROMTO  -   IN  ON  AT  SAVELETTER/S
 Rule   Fiji19981999-   Nov Sun>=1  2:001:00-
 Rule   Fiji19992000-   Feb lastSun 3:000   -
@@ -392,7 +405,9 @@ RuleFiji20122013-   Jan Sun>=18 
3:000   -
 Rule   Fiji2014only-   Jan Sun>=18 2:000   -
 Rule   Fiji20142018-   Nov Sun>=1  2:001:00-
 Rule   Fiji2015max -   Jan Sun>=12 3:000   -
-Rule   Fiji2019max -   Nov Sun>=8  2:001:00-
+Rule   Fiji2019only-   Nov Sun>=8  2:001:00-
+Rule   Fiji2020only-   Dec 20  2:001:00-
+Rule   Fiji2021max -   Nov Sun>=8  2:001:00-
 # Zone NAMESTDOFF  RULES   FORMAT  [UNTIL]
 Zone   Pacific/Fiji11:55:44 -  LMT 1915 Oct 26 # Suva
12:00   Fiji+12/+13

Modified: stable/12/contrib/tzdata/europe
==
--- stable/12/contrib/tzdata/europe Sun Oct 18 00:27:20 2020  

svn commit: r366800 - in head: sbin/ifconfig sys/net80211

[Bjoern A. Zeeb]

Author: bz
Date: Sun Oct 18 00:27:20 2020
New Revision: 366800
URL: https://svnweb.freebsd.org/changeset/base/366800

Log:
  net80211: update for (more) VHT160 support
  
  Implement two macros IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_IS_160MHZ()
  and its 80+80 counter part to check in vhtcaps for appropriate
  levels of support and use the macros throughout the code.
  
  Add vht160_chan_ranges/is_vht160_valid_freq and handle analogue
  to vht80 in various parts of the code.
  
  Add ieee80211_add_channel_cbw() which also takes the CBW flag
  fields and make the former ieee80211_add_channel() a wrapper to it.
  With the CBW flags we can add HT/VHT channels passing them to
  getflags() for the 2/5ghz functions.
  
  In ifconfig(8) add the regdomain_addchans() support for VHT160
  and VHT80P80.
  
  With this (+ regdoain.xml updates) VHT160 channels can be
  configured, listed, and pass regdomain where appropriate.
  
  Tested with:  iwlwifi
  Reviewed by:  adrian
  MFC after:10 days
  Sponsored by: The FreeBSD Foundation
  Differential Revision:https://reviews.freebsd.org/D26712

Modified:
  head/sbin/ifconfig/ifieee80211.c
  head/sys/net80211/ieee80211.c
  head/sys/net80211/ieee80211.h
  head/sys/net80211/ieee80211_regdomain.c
  head/sys/net80211/ieee80211_var.h
  head/sys/net80211/ieee80211_vht.c

Modified: head/sbin/ifconfig/ifieee80211.c
==
--- head/sbin/ifconfig/ifieee80211.cSat Oct 17 23:42:33 2020
(r366799)
+++ head/sbin/ifconfig/ifieee80211.cSun Oct 18 00:27:20 2020
(r366800)
@@ -2405,7 +2405,31 @@ regdomain_makechannels(
>dc_chaninfo);
}
 
-   /* XXX TODO: VHT80P80, VHT160 */
+   /* VHT160 */
+   if (IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_IS_160MHZ(
+   dc->dc_vhtcaps)) {
+   regdomain_addchans(ci, >bands_11ac, reg,
+   IEEE80211_CHAN_A | IEEE80211_CHAN_HT40U |
+   IEEE80211_CHAN_VHT160,
+   >dc_chaninfo);
+   regdomain_addchans(ci, >bands_11ac, reg,
+   IEEE80211_CHAN_A | IEEE80211_CHAN_HT40D |
+   IEEE80211_CHAN_VHT160,
+   >dc_chaninfo);
+   }
+
+   /* VHT80P80 */
+   if (IEEE80211_VHTCAP_SUPP_CHAN_WIDTH_IS_160_80P80MHZ(
+   dc->dc_vhtcaps)) {
+   regdomain_addchans(ci, >bands_11ac, reg,
+   IEEE80211_CHAN_A | IEEE80211_CHAN_HT40U |
+   IEEE80211_CHAN_VHT80P80,
+   >dc_chaninfo);
+   regdomain_addchans(ci, >bands_11ac, reg,
+   IEEE80211_CHAN_A | IEEE80211_CHAN_HT40D |
+   IEEE80211_CHAN_VHT80P80,
+   >dc_chaninfo);
+   }
}
 
if (!LIST_EMPTY(>bands_11ng) && dc->dc_htcaps != 0) {

Modified: head/sys/net80211/ieee80211.c
==
--- head/sys/net80211/ieee80211.c   Sat Oct 17 23:42:33 2020
(r366799)
+++ head/sys/net80211/ieee80211.c   Sun Oct 18 00:27:20 2020
(r366800)
@@ -1163,6 +1163,12 @@ struct vht_chan_range vht80_chan_ranges[] = {
{ 0, 0 }
 };
 
+struct vht_chan_range vht160_chan_ranges[] = {
+   { 5170, 5330 },
+   { 5490, 5650 },
+   { 0, 0 }
+};
+
 static int
 set_vht_extchan(struct ieee80211_channel *c)
 {
@@ -1177,8 +1183,24 @@ set_vht_extchan(struct ieee80211_channel *c)
}
 
if (IEEE80211_IS_CHAN_VHT160(c)) {
-   printf("%s: TODO VHT160 channel (ieee=%d, flags=0x%08x)\n",
-   __func__, c->ic_ieee, c->ic_flags);
+   for (i = 0; vht160_chan_ranges[i].freq_start != 0; i++) {
+   if (c->ic_freq >= vht160_chan_ranges[i].freq_start &&
+   c->ic_freq < vht160_chan_ranges[i].freq_end) {
+   int midpoint;
+
+   midpoint = vht160_chan_ranges[i].freq_start + 
80;
+   c->ic_vht_ch_freq1 =
+   ieee80211_mhz2ieee(midpoint, c->ic_flags);
+   c->ic_vht_ch_freq2 = 0;
+#if 0
+   printf("%s: %d, freq=%d, midpoint=%d, freq1=%d, 
freq2=%d\n",
+   __func__, c->ic_ieee, c->ic_freq, midpoint,
+   c->ic_vht_ch_freq1, c->ic_vht_ch_freq2);
+#endif
+   return (1);
+

svn commit: r366799 - head/sys/dev/extres/clk

[Bjoern A. Zeeb]

Author: bz
Date: Sat Oct 17 23:42:33 2020
New Revision: 366799
URL: https://svnweb.freebsd.org/changeset/base/366799

Log:
  clk: fix indentation
  
  Just fix indentation of an if() clause.
  No functional changes intended.
  
  MFC after:3 days

Modified:
  head/sys/dev/extres/clk/clk.c

Modified: head/sys/dev/extres/clk/clk.c
==
--- head/sys/dev/extres/clk/clk.c   Sat Oct 17 22:47:08 2020
(r366798)
+++ head/sys/dev/extres/clk/clk.c   Sat Oct 17 23:42:33 2020
(r366799)
@@ -544,7 +544,7 @@ clknode_create(struct clkdom * clkdom, clknode_class_t
CLK_TOPO_SLOCK();
clknode = clknode_find_by_name(def->name);
CLK_TOPO_UNLOCK();
-   if (clknode !=  NULL) {
+   if (clknode !=  NULL) {
if (!(clknode->flags & CLK_NODE_LINKED) &&
def->flags & CLK_NODE_LINKED) {
/*
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Trouver des nouveaux clients

[l...@aproximeo.fr]

Bonjour,

Pour votre information, vous pouvez gratuitement trouver plein de nouveaux
clients en vous inscrivant sur la 1ère plateforme de proximité en
cliquant ici

.

Plus d'infos en cliquant ici

.

Excellente journée !

Luc HIDOUX

Responsable Commercial 



--

 This message was sent to svn-src-all@freebsd.org by l...@aproximeo.fr

 To forward this message, please do not use the forward button of your
email application, because this message was made specifically for you only.
Instead use the forward page

in our newsletter system.

 To change your details and to choose which lists to be subscribed to,
visit your personal preferences page


 Or you can opt-out completely

from all future mailings.

 


-- powered by phpList, www.phplist.com --


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366798 - head/sys/kern

[Bjoern A. Zeeb]

Author: bz
Date: Sat Oct 17 22:47:08 2020
New Revision: 366798
URL: https://svnweb.freebsd.org/changeset/base/366798

Log:
  ddb: add show sysinit command
  
  Add a show sysinit command to ddb (similar to show vnet_sysinit) which
  proved to be helpful to debug some ordering issues on early-mid kernel
  start panics.

Modified:
  head/sys/kern/init_main.c

Modified: head/sys/kern/init_main.c
==
--- head/sys/kern/init_main.c   Sat Oct 17 21:30:46 2020(r366797)
+++ head/sys/kern/init_main.c   Sat Oct 17 22:47:08 2020(r366798)
@@ -47,6 +47,7 @@
 __FBSDID("$FreeBSD$");
 
 #include "opt_ddb.h"
+#include "opt_kdb.h"
 #include "opt_init_path.h"
 #include "opt_verbose_sysinit.h"
 
@@ -838,3 +839,51 @@ kick_init(const void *udata __unused)
sched_add(td, SRQ_BORING);
 }
 SYSINIT(kickinit, SI_SUB_KTHREAD_INIT, SI_ORDER_MIDDLE, kick_init, NULL);
+
+/*
+ * DDB(4).
+ */
+#ifdef DDB
+static void
+db_show_print_syinit(struct sysinit *sip, bool ddb)
+{
+   const char *sname, *funcname;
+   c_db_sym_t sym;
+   db_expr_t  offset;
+
+#define xprint(...)\
+   if (ddb)\
+   db_printf(__VA_ARGS__); \
+   else\
+   printf(__VA_ARGS__)
+
+   if (sip == NULL) {
+   xprint("%s: no sysinit * given\n", __func__);
+   return;
+   }
+
+   sym = db_search_symbol((vm_offset_t)sip, DB_STGY_ANY, );
+   db_symbol_values(sym, , NULL);
+   sym = db_search_symbol((vm_offset_t)sip->func, DB_STGY_PROC, );
+   db_symbol_values(sym, , NULL);
+   xprint("%s(%p)\n", (sname != NULL) ? sname : "", sip);
+   xprint("  %#08x %#08x\n", sip->subsystem, sip->order);
+   xprint("  %p(%s)(%p)\n",
+   sip->func, (funcname != NULL) ? funcname : "", sip->udata);
+#undef xprint
+}
+
+DB_SHOW_COMMAND(sysinit, db_show_sysinit)
+{
+   struct sysinit **sipp;
+
+   db_printf("SYSINIT vs Name(Ptr)\n");
+   db_printf("  Subsystem  Order\n");
+   db_printf("  Function(Name)(Arg)\n");
+   for (sipp = sysinit; sipp < sysinit_end; sipp++) {
+   db_show_print_syinit(*sipp, true);
+   if (db_pager_quit)
+   break;
+   }
+}
+#endif /* DDB */
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Sean Bruno]

>> sbruno@alice:~ % pkg info |grep kmod
>> drm-current-kmod-4.16.g20200320 DRM modules for the linuxkpi-based KMS
>> components
>> drm-kmod-g20190710 Metaport of DRM modules for the
>> linuxkpi-based KMS components
>> gpu-firmware-kmod-g20200503    Firmware modules for the linuxkpi-based
>> KMS components
> 
> You may want to have to update this to recent and try again;  if that
> still breaks I assume either Hans or I will be happy to help until manu
> is back.
> 
> I’d assume with more linuxkpi bits implemented in HEAD the conflicts in
> head will stay … and port/package updates will have to happen once in a
> while (*).
> 
> https://svnweb.freebsd.org/base?view=revision=366374
> https://svnweb.freebsd.org/ports?view=revision=551266
> 
> /bz
> 
> (*) manu is making sure that after the commit to head the new port keeps
> compiling with older kernels for a while using __FreeBSD_version; I may
> have a partial solution that might allow us to update the port first but
> neither won’t help with old ports like in this case.
> 

I think its fair to tell people like me who update -current every couple
of months to update more frequently or pop something into the top of
-current reminding them that they need to keep up.  :-)

For now, I'm rebuilding my poudriere jail and will update my pkg's to
ports-HEAD then retry the updates.  I don't think you folks should spend
too much time on it.

sean



signature.asc
Description: OpenPGP digital signature

svn commit: r366797 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 21:30:46 2020
New Revision: 366797
URL: https://svnweb.freebsd.org/changeset/base/366797

Log:
  cache: shorten names of debug stats

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==
--- head/sys/kern/vfs_cache.c   Sat Oct 17 21:22:40 2020(r366796)
+++ head/sys/kern/vfs_cache.c   Sat Oct 17 21:30:46 2020(r366797)
@@ -491,22 +491,20 @@ STATNODE_COUNTER(fullpathfound, numfullpathfound, "Num
  */
 static SYSCTL_NODE(_vfs_cache, OID_AUTO, debug, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
 "Name cache debugging");
-#define DEBUGNODE_ULONG(name, descr)   \
-   SYSCTL_ULONG(_vfs_cache_debug, OID_AUTO, name, CTLFLAG_RD, , 0, 
descr);
-#define DEBUGNODE_COUNTER(name, descr) \
-   static COUNTER_U64_DEFINE_EARLY(name);  \
-   SYSCTL_COUNTER_U64(_vfs_cache_debug, OID_AUTO, name, CTLFLAG_RD, , 
\
+#define DEBUGNODE_ULONG(name, varname, descr)  
\
+   SYSCTL_ULONG(_vfs_cache_debug, OID_AUTO, name, CTLFLAG_RD, , 0, 
descr);
+#define DEBUGNODE_COUNTER(name, varname, descr)
\
+   static COUNTER_U64_DEFINE_EARLY(varname);   
\
+   SYSCTL_COUNTER_U64(_vfs_cache_debug, OID_AUTO, name, CTLFLAG_RD, 
, \
descr);
-DEBUGNODE_COUNTER(zap_and_exit_bucket_relock_success,
+DEBUGNODE_COUNTER(zap_bucket_relock_success, zap_bucket_relock_success,
 "Number of successful removals after relocking");
-static long zap_and_exit_bucket_fail;
-DEBUGNODE_ULONG(zap_and_exit_bucket_fail,
-"Number of times zap_and_exit failed to lock");
-static long zap_and_exit_bucket_fail2;
-DEBUGNODE_ULONG(zap_and_exit_bucket_fail2,
-"Number of times zap_and_exit failed to lock");
+static long zap_bucket_fail;
+DEBUGNODE_ULONG(zap_bucket_fail, zap_bucket_fail, "");
+static long zap_bucket_fail2;
+DEBUGNODE_ULONG(zap_bucket_fail2, zap_bucket_fail2, "");
 static long cache_lock_vnodes_cel_3_failures;
-DEBUGNODE_ULONG(cache_lock_vnodes_cel_3_failures,
+DEBUGNODE_ULONG(vnodes_cel_3_failures, cache_lock_vnodes_cel_3_failures,
 "Number of times 3-way vnode locking failed");
 
 static void cache_zap_locked(struct namecache *ncp);
@@ -1325,7 +1323,7 @@ cache_zap_unlocked_bucket(struct namecache *ncp, struc
cache_zap_locked(rncp);
mtx_unlock(blp);
cache_unlock_vnodes(dvlp, vlp);
-   counter_u64_add(zap_and_exit_bucket_relock_success, 1);
+   counter_u64_add(zap_bucket_relock_success, 1);
return (0);
}
 
@@ -1423,7 +1421,7 @@ retry:
 
error = cache_zap_locked_bucket(ncp, cnp, hash, blp);
if (__predict_false(error != 0)) {
-   zap_and_exit_bucket_fail++;
+   zap_bucket_fail++;
goto retry;
}
counter_u64_add(numposzaps, 1);
@@ -1647,7 +1645,7 @@ negative_success:
counter_u64_add(numnegzaps, 1);
error = cache_zap_locked_bucket(ncp, cnp, hash, blp);
if (__predict_false(error != 0)) {
-   zap_and_exit_bucket_fail2++;
+   zap_bucket_fail2++;
goto retry;
}
cache_free(ncp);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366796 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 21:22:40 2020
New Revision: 366796
URL: https://svnweb.freebsd.org/changeset/base/366796

Log:
  cache: don't automatically evict negative entries if usage is low
  
  The previous scheme only looked at negative entry count in relation to the
  total count, leading to tons of spurious evictions if the cache is not
  significantly populated.
  
  Instead, only try the above if negative entry count goes beyond namecache
  capacity.

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==
--- head/sys/kern/vfs_cache.c   Sat Oct 17 20:33:09 2020(r366795)
+++ head/sys/kern/vfs_cache.c   Sat Oct 17 21:22:40 2020(r366796)
@@ -296,6 +296,17 @@ SYSCTL_ULONG(_vfs_cache_param, OID_AUTO, negfactor, CT
 "Ratio of negative namecache entries");
 
 /*
+ * Negative entry % of namecahe capacity above which automatic eviction is 
allowed.
+ *
+ * Check cache_neg_evict_cond for details.
+ */
+static u_int ncnegminpct = 3;
+
+static u_int __read_mostly neg_min; /* the above recomputed against ncsize 
*/
+SYSCTL_UINT(_vfs_cache_param, OID_AUTO, negmin, CTLFLAG_RD, _min, 0,
+"Negative entry count above which automatic eviction is allowed");
+
+/*
  * Structures associated with name caching.
  */
 #define NCHHASH(hash) \
@@ -703,6 +714,37 @@ SYSCTL_PROC(_vfs_cache, OID_AUTO, nchstats, CTLTYPE_OP
 CTLFLAG_MPSAFE, 0, 0, sysctl_nchstats, "LU",
 "VFS cache effectiveness statistics");
 
+static void
+cache_recalc_neg_min(u_int val)
+{
+
+   neg_min = (ncsize * val) / 100;
+}
+
+static int
+sysctl_negminpct(SYSCTL_HANDLER_ARGS)
+{
+   u_int val;
+   int error;
+
+   val = ncnegminpct;
+   error = sysctl_handle_int(oidp, , 0, req);
+   if (error != 0 || req->newptr == NULL)
+   return (error);
+
+   if (val == ncnegminpct)
+   return (0);
+   if (val < 0 || val > 99)
+   return (EINVAL);
+   ncnegminpct = val;
+   cache_recalc_neg_min(val);
+   return (0);
+}
+
+SYSCTL_PROC(_vfs_cache_param, OID_AUTO, negminpct,
+CTLTYPE_INT | CTLFLAG_MPSAFE | CTLFLAG_RW, NULL, 0, sysctl_negminpct,
+"I", "Negative entry \% of namecahe capacity above which automatic 
eviction is allowed");
+
 #ifdef DIAGNOSTIC
 /*
  * Grab an atomic snapshot of the name cache hash chain lengths
@@ -1033,7 +1075,7 @@ cache_neg_evict_select(void)
return (nl);
 }
 
-static void
+static bool
 cache_neg_evict(void)
 {
struct namecache *ncp, *ncp2;
@@ -1044,10 +1086,11 @@ cache_neg_evict(void)
struct mtx *blp;
uint32_t hash;
u_char nlen;
+   bool evicted;
 
nl = cache_neg_evict_select();
if (nl == NULL) {
-   return;
+   return (false);
}
 
mtx_lock(>nl_lock);
@@ -1064,7 +1107,7 @@ cache_neg_evict(void)
counter_u64_add(neg_evict_skipped_empty, 1);
mtx_unlock(>nl_lock);
mtx_unlock(>nl_evict_lock);
-   return;
+   return (false);
}
ns = NCP2NEGSTATE(ncp);
nlen = ncp->nc_nlen;
@@ -1088,6 +1131,7 @@ cache_neg_evict(void)
if (ncp2 == NULL) {
counter_u64_add(neg_evict_skipped_missed, 1);
ncp = NULL;
+   evicted = false;
} else {
MPASS(dvlp == VP2VNODELOCK(ncp->nc_dvp));
MPASS(blp == NCP2BUCKETLOCK(ncp));
@@ -1095,14 +1139,44 @@ cache_neg_evict(void)
ncp->nc_name);
cache_zap_locked(ncp);
counter_u64_add(neg_evicted, 1);
+   evicted = true;
}
mtx_unlock(blp);
mtx_unlock(dvlp);
if (ncp != NULL)
cache_free(ncp);
+   return (evicted);
 }
 
 /*
+ * Maybe evict a negative entry to create more room.
+ *
+ * The ncnegfactor parameter limits what fraction of the total count
+ * can comprise of negative entries. However, if the cache is just
+ * warming up this leads to excessive evictions.  As such, ncnegminpct
+ * (recomputed to neg_min) dictates whether the above should be
+ * applied.
+ *
+ * Try evicting if the cache is close to full capacity regardless of
+ * other considerations.
+ */
+static bool
+cache_neg_evict_cond(u_long lnumcache)
+{
+   u_long lnumneg;
+
+   if (ncsize - 1000 < lnumcache)
+   goto out_evict;
+   lnumneg = atomic_load_long();
+   if (lnumneg < neg_min)
+   return (false);
+   if (lnumneg * ncnegfactor < lnumcache)
+   return (false);
+out_evict:
+   return (cache_neg_evict());
+}
+
+/*
  * cache_zap_locked():
  *
  *   Removes a namecache entry from cache, whether it contains an actual
@@ -1994,8 +2068,7 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, 
 * 3. it only ever looks at negative entries.
 */
lnumcache = 

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Bjoern A. Zeeb]

On 17 Oct 2020, at 20:48, Sean Bruno wrote:


Same buildfailure with GENERIC-NODEBUG.


Seems different.



https://people.freebsd.org/~sbruno/backlight.txt


HEAD with which version of the drm port/package?

/bz


sbruno@alice:~ % pkg info |grep kmod
drm-current-kmod-4.16.g20200320 DRM modules for the linuxkpi-based KMS
components
drm-kmod-g20190710 Metaport of DRM modules for the
linuxkpi-based KMS components
gpu-firmware-kmod-g20200503Firmware modules for the linuxkpi-based
KMS components


You may want to have to update this to recent and try again;  if that 
still breaks I assume either Hans or I will be happy to help until manu 
is back.


I’d assume with more linuxkpi bits implemented in HEAD the conflicts 
in head will stay … and port/package updates will have to happen once 
in a while (*).


https://svnweb.freebsd.org/base?view=revision=366374
https://svnweb.freebsd.org/ports?view=revision=551266

/bz

(*) manu is making sure that after the commit to head the new port keeps 
compiling with older kernels for a while using __FreeBSD_version; I may 
have a partial solution that might allow us to update the port first but 
neither won’t help with old ports like in this case.


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Sean Bruno]

>> Same buildfailure with GENERIC-NODEBUG.
> 
> Seems different.
> 
> 
>> https://people.freebsd.org/~sbruno/backlight.txt
> 
> HEAD with which version of the drm port/package?
> 
> /bz

sbruno@alice:~ % pkg info |grep kmod
drm-current-kmod-4.16.g20200320 DRM modules for the linuxkpi-based KMS
components
drm-kmod-g20190710 Metaport of DRM modules for the
linuxkpi-based KMS components
gpu-firmware-kmod-g20200503Firmware modules for the linuxkpi-based
KMS components

> 
> 



signature.asc
Description: OpenPGP digital signature

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Bjoern A. Zeeb]

On 17 Oct 2020, at 20:14, Sean Bruno wrote:


On 2020-10-17 05:27, Alexander V. Chernikov wrote:

02.10.2020, 19:26, "Emmanuel Vadot" :

Author: manu
Date: Fri Oct 2 18:26:41 2020
New Revision: 366372
URL: https://svnweb.freebsd.org/changeset/base/366372

Log:
  linuxkpi: Add backlight support
  
  Add backlight function to linuxkpi.
  Graphics drivers expose the backlight of the panel directly 
so

allow them to use the backlight subsystem so
  user can use backlight(8) to configure them.
  
  Reviewed by: hselasky
  Relnotes: yes
  Differential Revision: The FreeBSD Foundation

Added:
  head/sys/compat/linuxkpi/common/include/linux/backlight.h
(contents, props changed)
Modified:
  head/sys/compat/linuxkpi/common/include/linux/device.h
  head/sys/compat/linuxkpi/common/src/linux_kmod.c
  head/sys/compat/linuxkpi/common/src/linux_pci.c
  head/sys/conf/kmod.mk

It breaks the build for me with
 
/usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:
fatal error: 'backlight_if.h' file not found




Same buildfailure with GENERIC-NODEBUG.


Seems different.



https://people.freebsd.org/~sbruno/backlight.txt


HEAD with which version of the drm port/package?

/bz


___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Hans Petter Selasky]

On 2020-10-17 22:14, Sean Bruno wrote:

On 2020-10-17 05:27, Alexander V. Chernikov wrote:

02.10.2020, 19:26, "Emmanuel Vadot" :

 Author: manu
 Date: Fri Oct 2 18:26:41 2020
 New Revision: 366372
 URL: https://svnweb.freebsd.org/changeset/base/366372

 Log:
   linuxkpi: Add backlight support
   
   Add backlight function to linuxkpi.

   Graphics drivers expose the backlight of the panel directly so
 allow them to use the backlight subsystem so
   user can use backlight(8) to configure them.
   
   Reviewed by: hselasky

   Relnotes: yes
   Differential Revision: The FreeBSD Foundation

 Added:
   head/sys/compat/linuxkpi/common/include/linux/backlight.h
 (contents, props changed)
 Modified:
   head/sys/compat/linuxkpi/common/include/linux/device.h
   head/sys/compat/linuxkpi/common/src/linux_kmod.c
   head/sys/compat/linuxkpi/common/src/linux_pci.c
   head/sys/conf/kmod.mk

It breaks the build for me with
  
/usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:

fatal error: 'backlight_if.h' file not found




Same buildfailure with GENERIC-NODEBUG.


I'll have a look at it tomorrow.

I think Emmanuel is OOO this week.

--HPS
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366795 - head/sys/netinet

[Alexander V. Chernikov]

Author: melifaro
Date: Sat Oct 17 20:33:09 2020
New Revision: 366795
URL: https://svnweb.freebsd.org/changeset/base/366795

Log:
  Fix sleepq_add panic happening with too wide net epoch in mcast control.
  
  PR:   250413
  Reported by:  Christopher Hall 
  Reviewed by:  ae
  Differential Revision:https://reviews.freebsd.org/D26827

Modified:
  head/sys/netinet/in_mcast.c

Modified: head/sys/netinet/in_mcast.c
==
--- head/sys/netinet/in_mcast.c Sat Oct 17 17:31:06 2020(r366794)
+++ head/sys/netinet/in_mcast.c Sat Oct 17 20:33:09 2020(r366795)
@@ -1905,7 +1905,7 @@ inp_getmoptions(struct inpcb *inp, struct sockopt *sop
  * this in order to allow groups to be joined when the routing
  * table has not yet been populated during boot.
  *
- * Returns NULL if no ifp could be found.
+ * Returns NULL if no ifp could be found, otherwise return referenced ifp.
  *
  * FUTURE: Implement IPv4 source-address selection.
  */
@@ -1926,13 +1926,16 @@ inp_lookup_mcast_ifp(const struct inpcb *inp,
if (!in_nullhost(ina)) {
IN_IFADDR_RLOCK(_ifa_tracker);
INADDR_TO_IFP(ina, ifp);
+   if (ifp != NULL)
+   if_ref(ifp);
IN_IFADDR_RUNLOCK(_ifa_tracker);
} else {
-   fibnum = inp ? inp->inp_inc.inc_fibnum : 0;
-   nh = fib4_lookup(fibnum, gsin->sin_addr, 0, 0, 0);
-   if (nh != NULL)
+   fibnum = inp ? inp->inp_inc.inc_fibnum : RT_DEFAULT_FIB;
+   nh = fib4_lookup(fibnum, gsin->sin_addr, 0, NHR_NONE, 0);
+   if (nh != NULL) {
ifp = nh->nh_ifp;
-   else {
+   if_ref(ifp);
+   } else {
struct in_ifaddr *ia;
struct ifnet *mifp;
 
@@ -1943,6 +1946,7 @@ inp_lookup_mcast_ifp(const struct inpcb *inp,
if (!(mifp->if_flags & IFF_LOOPBACK) &&
 (mifp->if_flags & IFF_MULTICAST)) {
ifp = mifp;
+   if_ref(ifp);
break;
}
}
@@ -1966,6 +1970,7 @@ inp_join_group(struct inpcb *inp, struct sockopt *sopt
struct ip_moptions  *imo;
struct in_multi *inm;
struct in_msource   *lims;
+   struct epoch_tracker et;
int  error, is_new;
 
ifp = NULL;
@@ -1997,9 +2002,10 @@ inp_join_group(struct inpcb *inp, struct sockopt *sopt
if (!IN_MULTICAST(ntohl(gsa->sin.sin_addr.s_addr)))
return (EINVAL);
 
+   NET_EPOCH_ENTER(et);
if (sopt->sopt_valsize == sizeof(struct ip_mreqn) &&
mreqn.imr_ifindex != 0)
-   ifp = ifnet_byindex(mreqn.imr_ifindex);
+   ifp = ifnet_byindex_ref(mreqn.imr_ifindex);
else
ifp = inp_lookup_mcast_ifp(inp, >sin,
mreqn.imr_address);
@@ -2023,6 +2029,7 @@ inp_join_group(struct inpcb *inp, struct sockopt *sopt
 
ssa->sin.sin_addr = mreqs.imr_sourceaddr;
 
+   NET_EPOCH_ENTER(et);
ifp = inp_lookup_mcast_ifp(inp, >sin,
mreqs.imr_interface);
CTR3(KTR_IGMPV3, "%s: imr_interface = 0x%08x, ifp = %p",
@@ -2065,7 +2072,8 @@ inp_join_group(struct inpcb *inp, struct sockopt *sopt
 
if (gsr.gsr_interface == 0 || V_if_index < gsr.gsr_interface)
return (EADDRNOTAVAIL);
-   ifp = ifnet_byindex(gsr.gsr_interface);
+   NET_EPOCH_ENTER(et);
+   ifp = ifnet_byindex_ref(gsr.gsr_interface);
break;
 
default:
@@ -2074,9 +2082,13 @@ inp_join_group(struct inpcb *inp, struct sockopt *sopt
return (EOPNOTSUPP);
break;
}
+   NET_EPOCH_EXIT(et);
 
-   if (ifp == NULL || (ifp->if_flags & IFF_MULTICAST) == 0)
+   if (ifp == NULL || (ifp->if_flags & IFF_MULTICAST) == 0) {
+   if (ifp != NULL)
+   if_rele(ifp);
return (EADDRNOTAVAIL);
+   }
 
IN_MULTI_LOCK();
 
@@ -2265,6 +2277,7 @@ out_inp_unlocked:
}
ip_mfilter_free(imf);
}
+   if_rele(ifp);
return (error);
 }
 
@@ -2740,7 +2753,6 @@ inp_setmoptions(struct inpcb *inp, struct sockopt *sop
 {
struct ip_moptions  *imo;
int  error;
-   struct epoch_trackeret;
 
error = 0;
 
@@ -2847,9 +2859,7 @@ inp_setmoptions(struct inpcb *inp, struct sockopt *sop
case IP_ADD_SOURCE_MEMBERSHIP:
case 

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Sean Bruno]

On 2020-10-17 05:27, Alexander V. Chernikov wrote:
> 02.10.2020, 19:26, "Emmanuel Vadot" :
> 
> Author: manu
> Date: Fri Oct 2 18:26:41 2020
> New Revision: 366372
> URL: https://svnweb.freebsd.org/changeset/base/366372
> 
> Log:
>   linuxkpi: Add backlight support
>   
>   Add backlight function to linuxkpi.
>   Graphics drivers expose the backlight of the panel directly so
> allow them to use the backlight subsystem so
>   user can use backlight(8) to configure them.
>   
>   Reviewed by: hselasky
>   Relnotes: yes
>   Differential Revision: The FreeBSD Foundation
> 
> Added:
>   head/sys/compat/linuxkpi/common/include/linux/backlight.h
> (contents, props changed)
> Modified:
>   head/sys/compat/linuxkpi/common/include/linux/device.h
>   head/sys/compat/linuxkpi/common/src/linux_kmod.c
>   head/sys/compat/linuxkpi/common/src/linux_pci.c
>   head/sys/conf/kmod.mk
> 
> It breaks the build for me with
>  
> /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:
> fatal error: 'backlight_if.h' file not found
> 
> 

Same buildfailure with GENERIC-NODEBUG.

sean


https://people.freebsd.org/~sbruno/backlight.txt



signature.asc
Description: OpenPGP digital signature

svn commit: r366794 - head/sys/riscv/riscv

[Mitchell Horne]

Author: mhorne
Date: Sat Oct 17 17:31:06 2020
New Revision: 366794
URL: https://svnweb.freebsd.org/changeset/base/366794

Log:
  riscv: zero reserved PTE bits for L2 PTEs
  
  As was done for L3 PTEs in r362853, mask out the reserved bits when
  extracting the physical address from an L2 PTE. Future versions of the
  spec or custom implementations may make use of these reserved bits, in
  which case the resulting physical address could be incorrect.
  
  Submitted by: Nathaniel Filardo 
  Reviewed by:  kp, mhorne
  Differential Revision:https://reviews.freebsd.org/D26607

Modified:
  head/sys/riscv/riscv/pmap.c

Modified: head/sys/riscv/riscv/pmap.c
==
--- head/sys/riscv/riscv/pmap.c Sat Oct 17 13:06:29 2020(r366793)
+++ head/sys/riscv/riscv/pmap.c Sat Oct 17 17:31:06 2020(r366794)
@@ -342,6 +342,8 @@ pagezero(void *p)
 
 #definePTE_TO_PHYS(pte) \
 pte) & ~PTE_HI_MASK) >> PTE_PPN0_S) * PAGE_SIZE)
+#defineL2PTE_TO_PHYS(l2) \
+l2) & ~PTE_HI_MASK) >> PTE_PPN1_S) << L2_SHIFT)
 
 static __inline pd_entry_t *
 pmap_l1(pmap_t pmap, vm_offset_t va)
@@ -477,7 +479,7 @@ pmap_early_vtophys(vm_offset_t l1pt, vm_offset_t va)
("Invalid bootstrap L2 table"));
 
/* L2 is superpages */
-   ret = (l2[l2_slot] >> PTE_PPN1_S) << L2_SHIFT;
+   ret = L2PTE_TO_PHYS(l2[l2_slot]);
ret += (va & L2_OFFSET);
 
return (ret);
@@ -825,7 +827,7 @@ pmap_extract(pmap_t pmap, vm_offset_t va)
}
} else {
/* L2 is superpages */
-   pa = (l2 >> PTE_PPN1_S) << L2_SHIFT;
+   pa = L2PTE_TO_PHYS(l2);
pa |= (va & L2_OFFSET);
}
}
@@ -877,7 +879,7 @@ pmap_kextract(vm_offset_t va)
panic("pmap_kextract: No l2");
if ((pmap_load(l2) & PTE_RX) != 0) {
/* superpages */
-   pa = (pmap_load(l2) >> PTE_PPN1_S) << L2_SHIFT;
+   pa = L2PTE_TO_PHYS(pmap_load(l2));
pa |= (va & L2_OFFSET);
return (pa);
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Warner Losh]

On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov 
wrote:

> 17.10.2020, 14:07, "Hans Petter Selasky" :
>
> On 2020-10-17 14:34, Alexander V. Chernikov wrote:
>
>  17.10.2020, 12:32, "Hans Petter Selasky" :
>
>   On 2020-10-17 13:27, Alexander V. Chernikov wrote:
>
> 02.10.2020, 19:26, "Emmanuel Vadot">:
>
>  Author: manu
>  Date: Fri Oct 2 18:26:41 2020
>  New Revision: 366372
>  URL: https://svnweb.freebsd.org/changeset/base/366372
>
>  Log:
> linuxkpi: Add backlight support
>
> Add backlight function to linuxkpi.
> Graphics drivers expose the backlight of the panel
> directly so
>   allow them
>  to use the backlight subsystem so
> user can use backlight(8) to configure them.
>
> Reviewed by: hselasky
> Relnotes: yes
> Differential Revision: The FreeBSD Foundation
>
>  Added:
>
> head/sys/compat/linuxkpi/common/include/linux/backlight.h
>   (contents,
>  props changed)
>  Modified:
> head/sys/compat/linuxkpi/common/include/linux/device.h
> head/sys/compat/linuxkpi/common/src/linux_kmod.c
> head/sys/compat/linuxkpi/common/src/linux_pci.c
> head/sys/conf/kmod.mk
>
> It breaks the build for me with
>
> 
> /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:
> fatal error: 'backlight_if.h' file not found
>
>
>   How do you build? Doesn't break over here.
>
>  GENERIC + COMPAT_LINUXKPI.
>
>
>
> Try adding:
>
> options backlight
>
> To the kernel config.
>
> Yep, thank you!
> Maybe it's worth considering adding static assert with the message
> describing this dependency?
>

Yes. It likely is worth doing something to highlight this issue.

Warner


--HPS
>
>
>
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Alexander V . Chernikov]

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Hans Petter Selasky]

On 2020-10-17 14:34, Alexander V. Chernikov wrote:

17.10.2020, 12:32, "Hans Petter Selasky" :

 On 2020-10-17 13:27, Alexander V. Chernikov wrote:

   02.10.2020, 19:26, "Emmanuel Vadot" mailto:m...@freebsd.org>>:

Author: manu
Date: Fri Oct 2 18:26:41 2020
New Revision: 366372
URL: https://svnweb.freebsd.org/changeset/base/366372

Log:
   linuxkpi: Add backlight support

   Add backlight function to linuxkpi.
   Graphics drivers expose the backlight of the panel directly 
so
 allow them
to use the backlight subsystem so
   user can use backlight(8) to configure them.

   Reviewed by: hselasky
   Relnotes: yes
   Differential Revision: The FreeBSD Foundation

Added:
   head/sys/compat/linuxkpi/common/include/linux/backlight.h
 (contents,
props changed)
Modified:
   head/sys/compat/linuxkpi/common/include/linux/device.h
   head/sys/compat/linuxkpi/common/src/linux_kmod.c
   head/sys/compat/linuxkpi/common/src/linux_pci.c
   head/sys/conf/kmod.mk

   It breaks the build for me with
   
/usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:
   fatal error: 'backlight_if.h' file not found


 How do you build? Doesn't break over here.

GENERIC + COMPAT_LINUXKPI.



Try adding:

options backlight

To the kernel config.

--HPS

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366793 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 13:06:29 2020
New Revision: 366793
URL: https://svnweb.freebsd.org/changeset/base/366793

Log:
  cache: erwork sysctl vfs.cache tree
  
  Split everything into neg, debug, param and stat categories.
  
  The legacy nchstats sysctl (queried e.g., by systat) remains untouched.
  
  While here rename some vars to be easier on the eye.

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==
--- head/sys/kern/vfs_cache.c   Sat Oct 17 13:04:46 2020(r366792)
+++ head/sys/kern/vfs_cache.c   Sat Oct 17 13:06:29 2020(r366793)
@@ -79,6 +79,9 @@ __FBSDID("$FreeBSD$");
 
 #include 
 
+static SYSCTL_NODE(_vfs, OID_AUTO, cache, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
+"Name cache");
+
 SDT_PROVIDER_DECLARE(vfs);
 SDT_PROBE_DEFINE3(vfs, namecache, enter, done, "struct vnode *", "char *",
 "struct vnode *");
@@ -277,6 +280,21 @@ cache_ncp_canuse(struct namecache *ncp)
 
 VFS_SMR_DECLARE;
 
+static SYSCTL_NODE(_vfs_cache, OID_AUTO, param, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
+"Name cache parameters");
+
+static u_int __read_mostly ncsize; /* the size as computed on creation or 
resizing */
+SYSCTL_UINT(_vfs_cache_param, OID_AUTO, size, CTLFLAG_RW, , 0,
+"Total namecache capacity");
+
+u_int ncsizefactor = 2;
+SYSCTL_UINT(_vfs_cache_param, OID_AUTO, sizefactor, CTLFLAG_RW, , 
0,
+"Size factor for namecache");
+
+static u_long __read_mostlyncnegfactor = 5; /* ratio of negative entries */
+SYSCTL_ULONG(_vfs_cache_param, OID_AUTO, negfactor, CTLFLAG_RW, , 
0,
+"Ratio of negative namecache entries");
+
 /*
  * Structures associated with name caching.
  */
@@ -286,15 +304,8 @@ static __read_mostly CK_SLIST_HEAD(nchashhead, namecac
 static u_long __read_mostlynchash; /* size of hash table */
 SYSCTL_ULONG(_debug, OID_AUTO, nchash, CTLFLAG_RD, , 0,
 "Size of namecache hash table");
-static u_long __read_mostlyncnegfactor = 5; /* ratio of negative entries */
-SYSCTL_ULONG(_vfs, OID_AUTO, ncnegfactor, CTLFLAG_RW, , 0,
-"Ratio of negative namecache entries");
 static u_long __exclusive_cache_line   numneg; /* number of negative entries 
allocated */
 static u_long __exclusive_cache_line   numcache;/* number of cache entries 
allocated */
-u_int ncsizefactor = 2;
-SYSCTL_UINT(_vfs, OID_AUTO, ncsizefactor, CTLFLAG_RW, , 0,
-"Size factor for namecache");
-static u_int __read_mostly ncsize; /* the size as computed on creation or 
resizing */
 
 struct nchstatsnchstats;   /* cache effectiveness 
statistics */
 
@@ -433,43 +444,58 @@ SYSCTL_INT(_debug_sizeof, OID_AUTO, namecache, CTLFLAG
 /*
  * The new name cache statistics
  */
-static SYSCTL_NODE(_vfs, OID_AUTO, cache, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
+static SYSCTL_NODE(_vfs_cache, OID_AUTO, stats, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
 "Name cache statistics");
-#define STATNODE_ULONG(name, descr)\
-   SYSCTL_ULONG(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, , 0, descr);
-#define STATNODE_COUNTER(name, descr)  \
-   static COUNTER_U64_DEFINE_EARLY(name);  \
-   SYSCTL_COUNTER_U64(_vfs_cache, OID_AUTO, name, CTLFLAG_RD, , \
+
+#define STATNODE_ULONG(name, varname, descr)   
\
+   SYSCTL_ULONG(_vfs_cache_stats, OID_AUTO, name, CTLFLAG_RD, , 0, 
descr);
+#define STATNODE_COUNTER(name, varname, descr) 
\
+   static COUNTER_U64_DEFINE_EARLY(varname);   
\
+   SYSCTL_COUNTER_U64(_vfs_cache_stats, OID_AUTO, name, CTLFLAG_RD, 
, \
descr);
-STATNODE_ULONG(numneg, "Number of negative cache entries");
-STATNODE_ULONG(numcache, "Number of cache entries");
-STATNODE_COUNTER(numcachehv, "Number of namecache entries with vnodes held");
-STATNODE_COUNTER(numdrops, "Number of dropped entries due to reaching the 
limit");
-STATNODE_COUNTER(dothits, "Number of '.' hits");
-STATNODE_COUNTER(dotdothits, "Number of '..' hits");
-STATNODE_COUNTER(nummiss, "Number of cache misses");
-STATNODE_COUNTER(nummisszap, "Number of cache misses we do not want to cache");
-STATNODE_COUNTER(numposzaps,
+STATNODE_ULONG(neg, numneg, "Number of negative cache entries");
+STATNODE_ULONG(count, numcache, "Number of cache entries");
+STATNODE_COUNTER(heldvnodes, numcachehv, "Number of namecache entries with 
vnodes held");
+STATNODE_COUNTER(drops, numdrops, "Number of dropped entries due to reaching 
the limit");
+STATNODE_COUNTER(dothits, dothits, "Number of '.' hits");
+STATNODE_COUNTER(dotdothis, dotdothits, "Number of '..' hits");
+STATNODE_COUNTER(miss, nummiss, "Number of cache misses");
+STATNODE_COUNTER(misszap, nummisszap, "Number of cache misses we do not want 
to cache");
+STATNODE_COUNTER(posszaps, numposzaps,
 "Number of cache hits (positive) we do not want to cache");

svn commit: r366791 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 13:04:25 2020
New Revision: 366791
URL: https://svnweb.freebsd.org/changeset/base/366791

Log:
  cache: avoid smr in cache_neg_evict in favoro of the already held bucket lock

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==
--- head/sys/kern/vfs_cache.c   Sat Oct 17 09:51:17 2020(r366790)
+++ head/sys/kern/vfs_cache.c   Sat Oct 17 13:04:25 2020(r366791)
@@ -803,6 +803,11 @@ SYSCTL_COUNTER_U64(_vfs_cache_neg, OID_AUTO, evict_ski
 _evict_skipped_empty,
 "Number of times evicting failed due to lack of entries");
 
+static COUNTER_U64_DEFINE_EARLY(neg_evict_skipped_missed);
+SYSCTL_COUNTER_U64(_vfs_cache_neg, OID_AUTO, evict_skipped_missed, CTLFLAG_RD,
+_evict_skipped_missed,
+"Number of times evicting failed due to target entry disappearing");
+
 static COUNTER_U64_DEFINE_EARLY(neg_evict_skipped_contended);
 SYSCTL_COUNTER_U64(_vfs_cache_neg, OID_AUTO, evict_skipped_contended, 
CTLFLAG_RD,
 _evict_skipped_contended,
@@ -1008,8 +1013,11 @@ cache_neg_evict(void)
struct namecache *ncp, *ncp2;
struct neglist *nl;
struct negstate *ns;
+   struct vnode *dvp;
struct mtx *dvlp;
struct mtx *blp;
+   uint32_t hash;
+   u_char nlen;
 
nl = cache_neg_evict_select();
if (nl == NULL) {
@@ -1033,25 +1041,30 @@ cache_neg_evict(void)
return;
}
ns = NCP2NEGSTATE(ncp);
-   dvlp = VP2VNODELOCK(ncp->nc_dvp);
-   blp = NCP2BUCKETLOCK(ncp);
+   nlen = ncp->nc_nlen;
+   dvp = ncp->nc_dvp;
+   hash = cache_get_hash(ncp->nc_name, nlen, dvp);
+   dvlp = VP2VNODELOCK(dvp);
+   blp = HASH2BUCKETLOCK(hash);
mtx_unlock(>nl_lock);
mtx_unlock(>nl_evict_lock);
mtx_lock(dvlp);
mtx_lock(blp);
/*
-* Enter SMR to safely check the negative list.
-* Even if the found pointer matches, the entry may now be reallocated
-* and used by a different vnode.
+* Note that since all locks were dropped above, the entry may be
+* gone or reallocated to be something else.
 */
-   vfs_smr_enter();
-   ncp2 = TAILQ_FIRST(>nl_list);
-   if (ncp != ncp2 || dvlp != VP2VNODELOCK(ncp2->nc_dvp) ||
-   blp != NCP2BUCKETLOCK(ncp2)) {
-   vfs_smr_exit();
+   CK_SLIST_FOREACH(ncp2, (NCHHASH(hash)), nc_hash) {
+   if (ncp2 == ncp && ncp2->nc_dvp == dvp &&
+   ncp2->nc_nlen == nlen && (ncp2->nc_flag & NCF_NEGATIVE) != 
0)
+   break;
+   }
+   if (ncp2 == NULL) {
+   counter_u64_add(neg_evict_skipped_missed, 1);
ncp = NULL;
} else {
-   vfs_smr_exit();
+   MPASS(dvlp == VP2VNODELOCK(ncp->nc_dvp));
+   MPASS(blp == NCP2BUCKETLOCK(ncp));
SDT_PROBE2(vfs, namecache, evict_negative, done, ncp->nc_dvp,
ncp->nc_name);
cache_zap_locked(ncp);
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366792 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 13:04:46 2020
New Revision: 366792
URL: https://svnweb.freebsd.org/changeset/base/366792

Log:
  cache: factor negative lookup out of cache_fplookup_next

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==
--- head/sys/kern/vfs_cache.c   Sat Oct 17 13:04:25 2020(r366791)
+++ head/sys/kern/vfs_cache.c   Sat Oct 17 13:04:46 2020(r366792)
@@ -3815,16 +3815,53 @@ cache_fplookup_dotdot(struct cache_fpl *fpl)
return (0);
 }
 
+static int __noinline
+cache_fplookup_neg(struct cache_fpl *fpl, struct namecache *ncp, uint32_t hash)
+{
+   struct negstate *ns;
+   struct vnode *dvp;
+   u_char nc_flag;
+   bool neg_hot;
+
+   dvp = fpl->dvp;
+   nc_flag = atomic_load_char(>nc_flag);
+   MPASS((nc_flag & NCF_NEGATIVE) != 0);
+   /*
+* If they want to create an entry we need to replace this one.
+*/
+   if (__predict_false(fpl->cnp->cn_nameiop != LOOKUP)) {
+   /*
+* TODO
+* This should call something similar to
+* cache_fplookup_final_modifying.
+*/
+   return (cache_fpl_partial(fpl));
+   }
+   ns = NCP2NEGSTATE(ncp);
+   neg_hot = ((ns->neg_flag & NEG_HOT) != 0);
+   if (__predict_false(!cache_ncp_canuse(ncp))) {
+   return (cache_fpl_partial(fpl));
+   }
+   if (__predict_false((nc_flag & NCF_WHITE) != 0)) {
+   return (cache_fpl_partial(fpl));
+   }
+   if (!neg_hot) {
+   return (cache_fplookup_negative_promote(fpl, ncp, hash));
+   }
+   SDT_PROBE2(vfs, namecache, lookup, hit__negative, dvp, ncp->nc_name);
+   counter_u64_add(numneghits, 1);
+   cache_fpl_smr_exit(fpl);
+   return (cache_fpl_handled(fpl, ENOENT));
+}
+
 static int
 cache_fplookup_next(struct cache_fpl *fpl)
 {
struct componentname *cnp;
struct namecache *ncp;
-   struct negstate *ns;
struct vnode *dvp, *tvp;
u_char nc_flag;
uint32_t hash;
-   bool neg_hot;
 
cnp = fpl->cnp;
dvp = fpl->dvp;
@@ -3853,28 +3890,7 @@ cache_fplookup_next(struct cache_fpl *fpl)
tvp = atomic_load_ptr(>nc_vp);
nc_flag = atomic_load_char(>nc_flag);
if ((nc_flag & NCF_NEGATIVE) != 0) {
-   /*
-* If they want to create an entry we need to replace this one.
-*/
-   if (__predict_false(fpl->cnp->cn_nameiop != LOOKUP)) {
-   return (cache_fpl_partial(fpl));
-   }
-   ns = NCP2NEGSTATE(ncp);
-   neg_hot = ((ns->neg_flag & NEG_HOT) != 0);
-   if (__predict_false(!cache_ncp_canuse(ncp))) {
-   return (cache_fpl_partial(fpl));
-   }
-   if (__predict_false((nc_flag & NCF_WHITE) != 0)) {
-   return (cache_fpl_partial(fpl));
-   }
-   if (!neg_hot) {
-   return (cache_fplookup_negative_promote(fpl, ncp, 
hash));
-   }
-   SDT_PROBE2(vfs, namecache, lookup, hit__negative, dvp,
-   ncp->nc_name);
-   counter_u64_add(numneghits, 1);
-   cache_fpl_smr_exit(fpl);
-   return (cache_fpl_handled(fpl, ENOENT));
+   return (cache_fplookup_neg(fpl, ncp, hash));
}
 
if (__predict_false(!cache_ncp_canuse(ncp))) {
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Alexander V . Chernikov]

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Hans Petter Selasky]

On 2020-10-17 13:27, Alexander V. Chernikov wrote:

02.10.2020, 19:26, "Emmanuel Vadot" :

 Author: manu
 Date: Fri Oct 2 18:26:41 2020
 New Revision: 366372
 URL: https://svnweb.freebsd.org/changeset/base/366372

 Log:
linuxkpi: Add backlight support

Add backlight function to linuxkpi.
Graphics drivers expose the backlight of the panel directly so allow 
them
 to use the backlight subsystem so
user can use backlight(8) to configure them.

Reviewed by: hselasky
Relnotes: yes
Differential Revision: The FreeBSD Foundation

 Added:
head/sys/compat/linuxkpi/common/include/linux/backlight.h (contents,
 props changed)
 Modified:
head/sys/compat/linuxkpi/common/include/linux/device.h
head/sys/compat/linuxkpi/common/src/linux_kmod.c
head/sys/compat/linuxkpi/common/src/linux_pci.c
head/sys/conf/kmod.mk

It breaks the build for me with
/usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10:
fatal error: 'backlight_if.h' file not found


How do you build? Doesn't break over here.

Maybe you need to do a clean first?

--HPS
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf

[Alexander V . Chernikov]

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366790 - stable/12/usr.bin/cpuset

[Gordon Bergling]

Author: gbe (doc committer)
Date: Sat Oct 17 09:51:17 2020
New Revision: 366790
URL: https://svnweb.freebsd.org/changeset/base/366790

Log:
  MFC r366611: cpuset(1): Fix a typo
  
  - 'at at' -> 'at a'

Modified:
  stable/12/usr.bin/cpuset/cpuset.1
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/usr.bin/cpuset/cpuset.1
==
--- stable/12/usr.bin/cpuset/cpuset.1   Sat Oct 17 09:50:12 2020
(r366789)
+++ stable/12/usr.bin/cpuset/cpuset.1   Sat Oct 17 09:51:17 2020
(r366790)
@@ -152,7 +152,7 @@ Ranges may be specified as in
 Valid policies include first-touch (ft), round-robin (rr), prefer and
 interleave (il).
 First-touch allocates on the local domain when memory is available.
-Round-robin alternates between every possible domain page at at time.
+Round-robin alternates between every possible domain page at a time.
 The prefer policy accepts only a single domain in the set.
 The parent of the set is consulted if the preferred domain is unavailable.
 Interleave operates like round-robin with an implementation defined stripe
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366789 - stable/12/share/man/man3

[Gordon Bergling]

Author: gbe (doc committer)
Date: Sat Oct 17 09:50:12 2020
New Revision: 366789
URL: https://svnweb.freebsd.org/changeset/base/366789

Log:
  MFC r366610: sigevent(3): Fix a typo
  
  - asychronous -> asynchronous

Modified:
  stable/12/share/man/man3/sigevent.3
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/share/man/man3/sigevent.3
==
--- stable/12/share/man/man3/sigevent.3 Sat Oct 17 09:48:56 2020
(r366788)
+++ stable/12/share/man/man3/sigevent.3 Sat Oct 17 09:50:12 2020
(r366789)
@@ -35,7 +35,7 @@
 .Sh SYNOPSIS
 .In signal.h
 .Sh DESCRIPTION
-Some operations permit threads to request asychronous notification of events
+Some operations permit threads to request asynchronous notification of events
 via a
 .Vt struct sigevent
 structure.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366788 - stable/12/usr.sbin/pnfsdsfile

[Gordon Bergling]

Author: gbe (doc committer)
Date: Sat Oct 17 09:48:56 2020
New Revision: 366788
URL: https://svnweb.freebsd.org/changeset/base/366788

Log:
  MFC r366617: pnfsdsfile(8): Remove dublicate word 'the'

Modified:
  stable/12/usr.sbin/pnfsdsfile/pnfsdsfile.8
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/usr.sbin/pnfsdsfile/pnfsdsfile.8
==
--- stable/12/usr.sbin/pnfsdsfile/pnfsdsfile.8  Sat Oct 17 09:47:56 2020
(r366787)
+++ stable/12/usr.sbin/pnfsdsfile/pnfsdsfile.8  Sat Oct 17 09:48:56 2020
(r366788)
@@ -117,7 +117,7 @@ After being re-enabled, the command
 with the
 .Dq -r
 option
-will be used to copy the the file's data to this repaired DS and then update 
the
+will be used to copy the file's data to this repaired DS and then update the
 extended attribute to use it.
 .Pp
 A typical use of this will be within a
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366787 - stable/12/share/man/man4

[Gordon Bergling]

Author: gbe (doc committer)
Date: Sat Oct 17 09:47:56 2020
New Revision: 366787
URL: https://svnweb.freebsd.org/changeset/base/366787

Log:
  MFC r366609: dtrace_audit(4): Fix a typo
  
  - asynchonously -> asynchronously

Modified:
  stable/12/share/man/man4/dtrace_audit.4
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/share/man/man4/dtrace_audit.4
==
--- stable/12/share/man/man4/dtrace_audit.4 Sat Oct 17 09:45:05 2020
(r366786)
+++ stable/12/share/man/man4/dtrace_audit.4 Sat Oct 17 09:47:56 2020
(r366787)
@@ -119,7 +119,7 @@ remains available for capture by the script.
 .Pp
 The
 .Fn audit:event:aue_*:bsm
-probes fire asynchonously from system-call return, following BSM conversion
+probes fire asynchronously from system-call return, following BSM conversion
 and just prior to being written to disk, giving access to four arguments: a
 .Vt char *
 audit event name, the
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366786 - stable/12/usr.sbin/cxgbetool

[Gordon Bergling]

Author: gbe (doc committer)
Date: Sat Oct 17 09:45:05 2020
New Revision: 366786
URL: https://svnweb.freebsd.org/changeset/base/366786

Log:
  MFC r366616: cxgbetool(8): Remove dublicate word 'whether'

Modified:
  stable/12/usr.sbin/cxgbetool/cxgbetool.8
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/usr.sbin/cxgbetool/cxgbetool.8
==
--- stable/12/usr.sbin/cxgbetool/cxgbetool.8Sat Oct 17 08:48:58 2020
(r366785)
+++ stable/12/usr.sbin/cxgbetool/cxgbetool.8Sat Oct 17 09:45:05 2020
(r366786)
@@ -547,7 +547,7 @@ There is an implicit rule that disables offload for co
 match anything in the policy.
 .Pp
 Each rule consists of a filter part, which determines what connections the
-rule applies to, and a settings part, which determines whether whether matching
+rule applies to, and a settings part, which determines whether matching
 connections will be offloaded and, if so, with what settings.
 The general form of a rule is
 .Bl -ohang -offset indent
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366785 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 08:48:58 2020
New Revision: 366785
URL: https://svnweb.freebsd.org/changeset/base/366785

Log:
  cache: rework parts of negative entry management
  
  - declutter sysctl vfs.cache by moving relevant entries into
  vfs.cache.neg
  - add a little more parallelism to eviction by replacing the
  global lock with an atomically modified counter
  - track more statistics
  
  The code needs further effort.

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==
--- head/sys/kern/vfs_cache.c   Sat Oct 17 08:48:32 2020(r366784)
+++ head/sys/kern/vfs_cache.c   Sat Oct 17 08:48:58 2020(r366785)
@@ -113,7 +113,7 @@ SDT_PROBE_DEFINE3(vfs, namecache, zap, done, "struct v
 "struct vnode *");
 SDT_PROBE_DEFINE2(vfs, namecache, zap_negative, done, "struct vnode *",
 "char *");
-SDT_PROBE_DEFINE2(vfs, namecache, shrink_negative, done, "struct vnode *",
+SDT_PROBE_DEFINE2(vfs, namecache, evict_negative, done, "struct vnode *",
 "char *");
 
 SDT_PROBE_DEFINE3(vfs, fplookup, lookup, done, "struct nameidata", "int", 
"bool");
@@ -251,9 +251,6 @@ cache_ncp_canuse(struct namecache *ncp)
  * bucketlock  mtx for access to given set of hash buckets
  * neglist mtx negative entry LRU management
  *
- * Additionally, ncneg_shrink_lock mtx is used to have at most one thread
- * shrinking the LRU list.
- *
  * It is legal to take multiple vnodelock and bucketlock locks. The locking
  * order is lower address first. Both are recursive.
  *
@@ -305,13 +302,14 @@ static bool __read_frequently cache_fast_revlookup = t
 SYSCTL_BOOL(_vfs, OID_AUTO, cache_fast_revlookup, CTLFLAG_RW,
 _fast_revlookup, 0, "");
 
-static struct mtx __exclusive_cache_line   ncneg_shrink_lock;
+static u_int __exclusive_cache_line neg_cycle;
 
 #define ncneghash  3
 #definenumneglists (ncneghash + 1)
 
 struct neglist {
-   struct mtx  nl_lock;
+   struct mtx  nl_evict_lock;
+   struct mtx  nl_lock __aligned(CACHE_LINE_SIZE);
TAILQ_HEAD(, namecache) nl_list;
TAILQ_HEAD(, namecache) nl_hotlist;
u_long  nl_hotnum;
@@ -473,10 +471,6 @@ static long zap_and_exit_bucket_fail2; STATNODE_ULONG(
 static long cache_lock_vnodes_cel_3_failures;
 STATNODE_ULONG(cache_lock_vnodes_cel_3_failures,
 "Number of times 3-way vnode locking failed");
-STATNODE_COUNTER(numneg_evicted,
-"Number of negative entries evicted when adding a new entry");
-STATNODE_COUNTER(shrinking_skipped,
-"Number of times shrinking was already in progress");
 
 static void cache_zap_locked(struct namecache *ncp);
 static int vn_fullpath_hardlink(struct nameidata *ndp, char **retbuf,
@@ -683,21 +677,6 @@ SYSCTL_PROC(_vfs_cache, OID_AUTO, nchstats, CTLTYPE_OP
 CTLFLAG_MPSAFE, 0, 0, sysctl_nchstats, "LU",
 "VFS cache effectiveness statistics");
 
-static int
-sysctl_hotnum(SYSCTL_HANDLER_ARGS)
-{
-   int i, out;
-
-   out = 0;
-   for (i = 0; i < numneglists; i++)
-   out += neglists[i].nl_hotnum;
-
-   return (SYSCTL_OUT(req, , sizeof(out)));
-}
-SYSCTL_PROC(_vfs_cache, OID_AUTO, hotnum, CTLTYPE_INT | CTLFLAG_RD |
-CTLFLAG_MPSAFE, 0, 0, sysctl_hotnum, "I",
-"Number of hot negative entries");
-
 #ifdef DIAGNOSTIC
 /*
  * Grab an atomic snapshot of the name cache hash chain lengths
@@ -792,27 +771,77 @@ SYSCTL_PROC(_debug_hashstat, OID_AUTO, nchash, CTLTYPE
 /*
  * Negative entries management
  *
- * A variation of LRU scheme is used. New entries are hashed into one of
- * numneglists cold lists. Entries get promoted to the hot list on first hit.
+ * Various workloads create plenty of negative entries and barely use them
+ * afterwards. Moreover malicious users can keep performing bogus lookups
+ * adding even more entries. For example "make tinderbox" as of writing this
+ * comment ends up with 2.6M namecache entries in total, 1.2M of which are
+ * negative.
  *
- * The shrinker will demote hot list head and evict from the cold list in a
- * round-robin manner.
+ * As such, a rather aggressive eviction method is needed. The currently
+ * employed method is a placeholder.
+ *
+ * Entries are split over numneglists separate lists, each of which is further
+ * split into hot and cold entries. Entries get promoted after getting a hit.
+ * Eviction happens on addition of new entry.
  */
+static SYSCTL_NODE(_vfs_cache, OID_AUTO, neg, CTLFLAG_RW | CTLFLAG_MPSAFE, 0,
+"Name cache negative entry statistics");
+
+SYSCTL_ULONG(_vfs_cache_neg, OID_AUTO, count, CTLFLAG_RD, , 0,
+"Number of negative cache entries");
+
+static COUNTER_U64_DEFINE_EARLY(neg_created);
+SYSCTL_COUNTER_U64(_vfs_cache_neg, OID_AUTO, created, CTLFLAG_RD, _created,
+"Number of created negative entries");
+
+static COUNTER_U64_DEFINE_EARLY(neg_evicted);
+SYSCTL_COUNTER_U64(_vfs_cache_neg, OID_AUTO, evicted, 

svn commit: r366784 - head/sys/kern

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 08:48:32 2020
New Revision: 366784
URL: https://svnweb.freebsd.org/changeset/base/366784

Log:
  cache: remove entries before trying to add new ones, not after
  
  Should allow positive entries to replace negative ones in case
  the cache is full.

Modified:
  head/sys/kern/vfs_cache.c

Modified: head/sys/kern/vfs_cache.c
==
--- head/sys/kern/vfs_cache.c   Sat Oct 17 08:47:08 2020(r366783)
+++ head/sys/kern/vfs_cache.c   Sat Oct 17 08:48:32 2020(r366784)
@@ -1923,8 +1923,21 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, 
 
/*
 * Avoid blowout in namecache entries.
+*
+* Bugs:
+* 1. filesystems may end up tryng to add an already existing entry
+* (for example this can happen after a cache miss during concurrent
+* lookup), in which case we will call cache_negative_zap_one despite
+* not adding anything.
+* 2. the routine may fail to free anything and no provisions are made
+* to make it try harder (see the inside for failure modes)
+* 3. it only ever looks at negative entries.
 */
lnumcache = atomic_fetchadd_long(, 1) + 1;
+   if (numneg * ncnegfactor > lnumcache) {
+   cache_negative_zap_one();
+   lnumcache = atomic_load_long();
+   }
if (__predict_false(lnumcache >= ncsize)) {
atomic_subtract_long(, 1);
counter_u64_add(numdrops, 1);
@@ -2087,8 +2100,6 @@ cache_enter_time(struct vnode *dvp, struct vnode *vp, 
atomic_store_char(>nc_flag, ncp->nc_flag & ~NCF_WIP);
 
cache_enter_unlock();
-   if (numneg * ncnegfactor > lnumcache)
-   cache_negative_zap_one();
if (ndd != NULL)
cache_free(ndd);
return;
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

svn commit: r366783 - in head/sys: kern sys

[Mateusz Guzik]

Author: mjg
Date: Sat Oct 17 08:47:08 2020
New Revision: 366783
URL: https://svnweb.freebsd.org/changeset/base/366783

Log:
  vfs: annotate mountlist_mtx with __exclusive_cache_line

Modified:
  head/sys/kern/vfs_mount.c
  head/sys/sys/mount.h

Modified: head/sys/kern/vfs_mount.c
==
--- head/sys/kern/vfs_mount.c   Sat Oct 17 04:14:46 2020(r366782)
+++ head/sys/kern/vfs_mount.c   Sat Oct 17 08:47:08 2020(r366783)
@@ -96,7 +96,7 @@ static uma_zone_t mount_zone;
 struct mntlist mountlist = TAILQ_HEAD_INITIALIZER(mountlist);
 
 /* For any iteration/modification of mountlist */
-struct mtx mountlist_mtx;
+struct mtx_padalign __exclusive_cache_line mountlist_mtx;
 MTX_SYSINIT(mountlist, _mtx, "mountlist", MTX_DEF);
 
 EVENTHANDLER_LIST_DEFINE(vfs_mounted);

Modified: head/sys/sys/mount.h
==
--- head/sys/sys/mount.hSat Oct 17 04:14:46 2020(r366782)
+++ head/sys/sys/mount.hSat Oct 17 08:47:08 2020(r366783)
@@ -997,7 +997,7 @@ int vfs_suser(struct mount *, struct thread *);
 void   vfs_unbusy(struct mount *);
 void   vfs_unmountall(void);
 extern TAILQ_HEAD(mntlist, mount) mountlist;   /* mounted filesystem list */
-extern struct mtx mountlist_mtx;
+extern struct mtx_padalign mountlist_mtx;
 extern struct nfs_public nfs_pub;
 extern struct sx vfsconf_sx;
 #definevfsconf_lock()  sx_xlock(_sx)
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r366781 - in head: include lib/libc/stdlib

[Konstantin Belousov]

On Sat, Oct 17, 2020 at 04:14:39AM +, Xin LI wrote:
> Author: delphij
> Date: Sat Oct 17 04:14:38 2020
> New Revision: 366781
> URL: https://svnweb.freebsd.org/changeset/base/366781
> 
> Log:
>   Implement ptsname_r.
>   
>   MFC after:  2 weeks
>   PR: 250062
>   Reviewed by:jilles, 0mp, Ray 
>   Differential Revision:  https://reviews.freebsd.org/D26647
> 
> Modified:
>   head/include/stdlib.h
>   head/lib/libc/stdlib/Makefile.inc
>   head/lib/libc/stdlib/Symbol.map
>   head/lib/libc/stdlib/ptsname.3
>   head/lib/libc/stdlib/ptsname.c
> 
> Modified: head/include/stdlib.h
> ==
> --- head/include/stdlib.h Sat Oct 17 01:06:04 2020(r366780)
> +++ head/include/stdlib.h Sat Oct 17 04:14:38 2020(r366781)
> @@ -225,6 +225,7 @@ long   mrand48(void);
>  long  nrand48(unsigned short[3]);
>  int   posix_openpt(int);
>  char *ptsname(int);
> +int   ptsname_r(int, char *, size_t);
This declaration appears in the __XSI_VISIBLE block, but I do not see the
function description in the IEEE Std 1003.1™-2017 text (base issue 7).

Review mentioned that the function is scheduled for issue 8, but shouldn't
it put under BSD_VISIBLE until specification is finalized ?

>  int   putenv(char *);
>  long  random(void);
>  unsigned short
> 
> Modified: head/lib/libc/stdlib/Makefile.inc
> ==
> --- head/lib/libc/stdlib/Makefile.inc Sat Oct 17 01:06:04 2020
> (r366780)
> +++ head/lib/libc/stdlib/Makefile.inc Sat Oct 17 04:14:38 2020
> (r366781)
> @@ -50,7 +50,7 @@ MLINKS+=hcreate.3 hdestroy.3 hcreate.3 hsearch.3
>  MLINKS+=hcreate.3 hcreate_r.3 hcreate.3 hdestroy_r.3 hcreate.3 hsearch_r.3
>  MLINKS+=insque.3 remque.3
>  MLINKS+=lsearch.3 lfind.3
> -MLINKS+=ptsname.3 grantpt.3 ptsname.3 unlockpt.3
> +MLINKS+=ptsname.3 grantpt.3 ptsname.3 ptsname_r.3 ptsname.3 unlockpt.3
>  MLINKS+=qsort.3 heapsort.3 qsort.3 mergesort.3 qsort.3 qsort_r.3 \
>   qsort.3 qsort_s.3
>  MLINKS+=rand.3 rand_r.3 rand.3 srand.3
> 
> Modified: head/lib/libc/stdlib/Symbol.map
> ==
> --- head/lib/libc/stdlib/Symbol.map   Sat Oct 17 01:06:04 2020
> (r366780)
> +++ head/lib/libc/stdlib/Symbol.map   Sat Oct 17 04:14:38 2020
> (r366781)
> @@ -125,6 +125,7 @@ FBSD_1.6 {
>   qsort_s;
>   rand;
>   srand;
> + ptsname_r;
This is unsorted now.

>  };
>  
>  FBSDprivate_1.0 {
> 
> Modified: head/lib/libc/stdlib/ptsname.3
> ==
> --- head/lib/libc/stdlib/ptsname.3Sat Oct 17 01:06:04 2020
> (r366780)
> +++ head/lib/libc/stdlib/ptsname.3Sat Oct 17 04:14:38 2020
> (r366781)
> @@ -31,12 +31,13 @@
>  .\"
>  .\" $FreeBSD$
>  .\"
> -.Dd August 20, 2008
> +.Dd October 17, 2020
>  .Dt PTSNAME 3
>  .Os
>  .Sh NAME
>  .Nm grantpt ,
>  .Nm ptsname ,
> +.Nm ptsname_r ,
>  .Nm unlockpt
>  .Nd pseudo-terminal access functions
>  .Sh LIBRARY
> @@ -47,6 +48,8 @@
>  .Fn grantpt "int fildes"
>  .Ft "char *"
>  .Fn ptsname "int fildes"
> +.Ft "int"
> +.Fn ptsname_r "int fildes" "char *buffer" "size_t buflen"
>  .Ft int
>  .Fn unlockpt "int fildes"
>  .Sh DESCRIPTION
> @@ -87,12 +90,23 @@ and
>  have been called.
>  .Pp
>  The
> +.Fn ptsname_r
> +function is the thread-safe version of
> +.Fn ptsname .
> +The caller must provide storage for the results of the full pathname of
> +the slave device in the
> +.Fa buffer
> +and
> +.Fa bufsize
> +arguments.
> +.Pp
> +The
>  .Fn unlockpt
>  function clears the lock held on the pseudo-terminal pair
>  for the master device specified with
>  .Fa fildes .
>  .Sh RETURN VALUES
> -.Rv -std grantpt unlockpt
> +.Rv -std grantpt ptsname_r unlockpt
>  .Pp
>  The
>  .Fn ptsname
> @@ -103,7 +117,8 @@ pointer is returned.
>  .Sh ERRORS
>  The
>  .Fn grantpt ,
> -.Fn ptsname
> +.Fn ptsname ,
> +.Fn ptsname_r
>  and
>  .Fn unlockpt
>  functions may fail and set
> @@ -116,6 +131,16 @@ is not a valid open file descriptor.
>  .It Bq Er EINVAL
>  .Fa fildes
>  is not a master pseudo-terminal device.
> +.El
> +.Pp
> +In addition, the
> +.Fn ptsname_r
> +function may set
> +.Va errno
> +to:
> +.Bl -tag -width Er
> +.It Bq Er ERANGE
> +The buffer was too small.
>  .El
>  .Pp
>  In addition, the
> 
> Modified: head/lib/libc/stdlib/ptsname.c
> ==
> --- head/lib/libc/stdlib/ptsname.cSat Oct 17 01:06:04 2020
> (r366780)
> +++ head/lib/libc/stdlib/ptsname.cSat Oct 17 04:14:38 2020
> (r366781)
> @@ -41,6 +41,7 @@ __FBSDID("$FreeBSD$");
>  #include 
>  #include 
>  #include 
> +#include 
>  #include "un-namespace.h"
>  
>  /*
> @@ -71,23 +72,46 @@ __strong_reference(__isptmaster, grantpt);
>  __strong_reference(__isptmaster, unlockpt);
>  
>  /*
> - * ptsname():