RE: svn commit: r328554 - head/sys/cam/scsi

[Dexuan Cui via svn-src-all]

Hi Warner,
Sorry, I need to make a correction: acutally it looks the panic can NOT 
reproduce with stable/11 or the latest master branch. This is great! :-)

Actually I was using an old version of the master branch that doesn’t have 
r328554 yet, and I could 100% reproduce the issue. If I manually apply r328554, 
or I use the latest master branch, the panic can’t happen any more.

So, it looks here we don’t need to MFC any patch to stable/11.

Thanks,
-- Dexuan

From: wl...@bsdimp.com  On Behalf Of Warner Losh
Sent: Monday, March 12, 2018 09:45
To: Dexuan-BSD Cui 
Cc: Warner Losh ; src-committers 
; svn-src-all@freebsd.org; 
svn-src-h...@freebsd.org; Dexuan Cui 
Subject: Re: svn commit: r328554 - head/sys/cam/scsi


This sender failed our fraud detection checks and may not be who they appear to 
be. Learn about spoofing

Feedback

I think this is a good idea to MFC. We've had no reports of it causing issues.

There's more extensive locking changes / tweaks needed for da that just went in 
that likely should also be MFC'd.

Warner

On Sun, Mar 11, 2018 at 9:17 PM, Dexuan-BSD Cui 
> wrote:
Hi imp and all,
I think this patch is very important, because it can fix a panic I
noticed recently when I try to hot-remove a SCSI disk from a VM
running on Azure/Hyper-V.

The panic is almost 100% reproducible with stable/11, but not in the
latest CURRENT code, so finally I identified this fix in the CURRENT
branch.

Can you please MFC this patch to 11 and 10?
It looks there is a major difference in the CAM code between 11/10
and the CURRENT code, and we may have to MFC more related patches. If
this is difficult, I hope at least we can provide a minimal re-written
version of the patch to 11 and 10?

Looking forward to your insight!

Thanks,
-- Dexuan


On Mon, Jan 29, 2018 at 10:07 AM, Warner Losh 
> wrote:
> Author: imp
> Date: Mon Jan 29 18:07:14 2018
> New Revision: 328554
> URL: 
> https://svnweb.freebsd.org/changeset/base/328554
>
> Log:
>   Do the book-keeping on release before we release the reference. The
>   periph was going away on final release, and then returning and we
>   started dancing in free memory.
>
>   Sponsored by: Netflix
>
> Modified:
>   head/sys/cam/scsi/scsi_da.c
>
> Modified: head/sys/cam/scsi/scsi_da.c
> ==
> --- head/sys/cam/scsi/scsi_da.c Mon Jan 29 17:32:30 2018(r328553)
> +++ head/sys/cam/scsi/scsi_da.c Mon Jan 29 18:07:14 2018(r328554)
> @@ -1549,12 +1549,12 @@ da_periph_unhold(struct cam_periph *periph, da_ref_tok
> struct da_softc *softc = periph->softc;
>
> token_sanity(token);
> -   cam_periph_unhold(periph);
> DA_PERIPH_PRINT(periph, "Unholding device %s (%d)\n",
> da_ref_text[token], token);
> cnt = atomic_fetchadd_int(>ref_flags[token], -1);
> if (cnt != 1)
> panic("Unholding %d with cnt = %d", token, cnt);
> +   cam_periph_unhold(periph);
>  }
>
>  static inline int
> @@ -1583,12 +1583,12 @@ da_periph_release(struct cam_periph *periph, da_ref_to
> struct da_softc *softc = periph->softc;
>
> token_sanity(token);
> -   cam_periph_release(periph);
> DA_PERIPH_PRINT(periph, "releasing device %s (%d)\n",
> da_ref_text[token], token);
> cnt = atomic_fetchadd_int(>ref_flags[token], -1);
> if (cnt != 1)
> panic("Releasing %d with cnt = %d", token, cnt);
> +   cam_periph_release(periph);
>  }
>
>  static inline void
> @@ -1598,12 +1598,12 @@ da_periph_release_locked(struct cam_periph *periph, da
> struct da_softc *softc = periph->softc;
>
> token_sanity(token);
> -   cam_periph_release_locked(periph);
> DA_PERIPH_PRINT(periph, "releasing device (locked) %s (%d)\n",
> da_ref_text[token], token);
> cnt = atomic_fetchadd_int(>ref_flags[token], -1);
> if (cnt != 1)
> panic("Unholding %d with cnt = %d", token, cnt);
> +   cam_periph_release_locked(periph);
>  }
>
>  #define cam_periph_hold POISON
>

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r328625 - in head/sys: amd64/amd64 amd64/ia32 amd64/include dev/cpuctl i386/i386 x86/include x86/x86

[Dexuan Cui via svn-src-all]

> From: carpedd...@gmail.com  On Behalf Of Ed
> Maste
> Sent: Friday, March 9, 2018 17:58
> On 9 March 2018 at 19:41, Dexuan-BSD Cui  wrote:
> > Hi,
> >
> > In my FreeBSD 11.1 VM, I'm getting this build failure and it looks
> > this revision causes the failure:
> >
> > /root/bsd.git/sys/amd64/amd64/support.S:855:2: error: unknown directive
> >  .altmacro
> >  ^
> 
> Are you trying to build a head kernel using the toolchain in 11.1?

Yes.

> That won't work (because of missing .altmacro support). Building
> kernel-toolchain first should get a working toolchain.

"make kernel-toolchain" first works for me! :-)

Thank you, Ed!
 
> > It looks -fno-integrated-as might fix the failure for me according to:
> 
> Avoiding the integrated assembler is indeed the workaround for this
> issue, but you'll want to apply it only to the affected file.
> 
> Kostik's 11.1 merge candidate patch adds to sys/conf/Makefile.amd64
> ASM_CFLAGS.support.S= ${CLANG_NO_IAS}

Thanks for the explanation. Good to know this!

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r328944 - stable/11/sys/kern

[Dexuan Cui via svn-src-all]

> From: Gleb Smirnoff 
> Sent: Tuesday, February 6, 2018 15:11
> 
> On Tue, Feb 06, 2018 at 03:08:12PM -0800, Dexuan-BSD Cui wrote:
> D> I'm getting the error too:
> D>
> D> /root/freebsd/sys/kern/vfs_subr.c:3368:30: error: no member named
> D> 'v_unpcb' in 'struct vnode'
> D> printf(" socket %p\n", vp->v_unpcb);
> 
> It should be v_socket on stable/11. If that change fixes the compile
> for you, feel free to commit. I don't have stable/11 system at hand.
> --
> Gleb Smirnoff

Yes, that change fixes the issue, and I can see the renaming happened in: 
https://github.com/freebsd/freebsd/commit/8a7f8bb123cb2056ca239a472deaef02962bdd3e

kib just fixed it by
https://svnweb.freebsd.org/base?view=revision=328961

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r322076 - in head/sys: amd64/amd64 i386/i386 x86/include x86/x86

[Dexuan Cui via svn-src-all]

> From: owner-src-committ...@freebsd.org [mailto:owner-src-
> committ...@freebsd.org] On Behalf Of Jung-uk Kim
> Sent: Wednesday, August 9, 2017 10:03
> To: Dexuan Cui ; src-committ...@freebsd.org; svn-src-
> a...@freebsd.org; svn-src-h...@freebsd.org
> Cc: Yanmin Qiao ; Hongjiang Zhang
> 
> Subject: Re: svn commit: r322076 - in head/sys: amd64/amd64 i386/i386
> x86/include x86/x86
> 
> On 08/09/2017 00:09, Dexuan Cui wrote:
> > Hi jkim,
> > The patch breaks FreeBSD VM on Hyper-V.
> >
> > identify_hypervisor() is moved from identify_cpu() to an earlier place, but 
> > the
> global
> > variable cpu_feature2 used by the function is still initialized in 
> > identify_cpu().
> >
> > I'm not sure about the background of your patch. Can you please have a look?
> 
> Can you please test the attached patch?
> 
> Jung-uk Kim

I tested the patch only with my  x86_64 VM, and it worked.  

Thanks for the quick fix!

-- Dexuan

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r322076 - in head/sys: amd64/amd64 i386/i386 x86/include x86/x86

[Dexuan Cui via svn-src-all]

Hi jkim,
The patch breaks FreeBSD VM on Hyper-V.

identify_hypervisor() is moved from identify_cpu() to an earlier place, but the 
global 
variable cpu_feature2 used by the function is still initialized in 
identify_cpu().

I'm not sure about the background of your patch. Can you please have a look?

Thanks,
-- Dexuan

> -Original Message-
> From: owner-src-committ...@freebsd.org [mailto:owner-src-
> committ...@freebsd.org] On Behalf Of Jung-uk Kim
> Sent: Friday, August 4, 2017 23:57
> To: src-committ...@freebsd.org; svn-src-all@freebsd.org; svn-src-
> h...@freebsd.org
> Subject: svn commit: r322076 - in head/sys: amd64/amd64 i386/i386
> x86/include x86/x86
> 
> Author: jkim
> Date: Sat Aug  5 06:56:46 2017
> New Revision: 322076
> URL:
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsvnweb.fr
> eebsd.org%2Fchangeset%2Fbase%2F322076=02%7C01%7Cdecui%40micr
> osoft.com%7C5a826235e08b415fc3cb08d4dbcf2b80%7C72f988bf86f141af91ab
> 2d7cd011db47%7C1%7C0%7C636375130217192047=%2BcZhlr%2B2zX5S
> S1eA32fWMpzckNHOQlGz8UHLXCaUN0s%3D=0
> 
> Log:
>   Detect hypervisors early.  We used to set lower hz on hypervisors by default
>   but it was broken since r273800 (and r278522, its MFC to stable/10) because
>   identify_cpu() is called too late, i.e., after init_param1().
> 
>   MFC after:  3 days
> 
> Modified:
>   head/sys/amd64/amd64/machdep.c
>   head/sys/i386/i386/machdep.c
>   head/sys/x86/include/x86_var.h
>   head/sys/x86/x86/identcpu.c
> 
> Modified: head/sys/amd64/amd64/machdep.c
> =
> =
> --- head/sys/amd64/amd64/machdep.cSat Aug  5 06:46:06 2017
>   (r322075)
> +++ head/sys/amd64/amd64/machdep.cSat Aug  5 06:56:46 2017
>   (r322076)
> @@ -1537,6 +1537,8 @@ hammer_time(u_int64_t modulep, u_int64_t physfree)
> 
>   kmdp = init_ops.parse_preload_data(modulep);
> 
> + identify_hypervisor();
> +
>   /* Init basic tunables, hz etc */
>   init_param1();
> 
> 
> Modified: head/sys/i386/i386/machdep.c
> =
> =
> --- head/sys/i386/i386/machdep.c  Sat Aug  5 06:46:06 2017
>   (r322075)
> +++ head/sys/i386/i386/machdep.c  Sat Aug  5 06:56:46 2017
>   (r322076)
> @@ -2185,6 +2185,8 @@ init386(int first)
>   else
>   init_static_kenv(NULL, 0);
> 
> + identify_hypervisor();
> +
>   /* Init basic tunables, hz etc */
>   init_param1();
> 
> 
> Modified: head/sys/x86/include/x86_var.h
> =
> =
> --- head/sys/x86/include/x86_var.hSat Aug  5 06:46:06 2017
>   (r322075)
> +++ head/sys/x86/include/x86_var.hSat Aug  5 06:56:46 2017
>   (r322076)
> @@ -116,6 +116,7 @@ void  cpu_setregs(void);
>  void dump_add_page(vm_paddr_t);
>  void dump_drop_page(vm_paddr_t);
>  void identify_cpu(void);
> +void identify_hypervisor(void);
>  void initializecpu(void);
>  void initializecpucache(void);
>  bool fix_cpuid(void);
> 
> Modified: head/sys/x86/x86/identcpu.c
> =
> =
> --- head/sys/x86/x86/identcpu.c   Sat Aug  5 06:46:06 2017
> (r322075)
> +++ head/sys/x86/x86/identcpu.c   Sat Aug  5 06:56:46 2017
>   (r322076)
> @@ -1252,7 +1252,7 @@ static const char *const vm_pnames[] = {
>   NULL
>  };
> 
> -static void
> +void
>  identify_hypervisor(void)
>  {
>   u_int regs[4];
> @@ -1403,7 +1403,6 @@ identify_cpu(void)
>   cpu_feature2 = regs[2];
>  #endif
> 
> - identify_hypervisor();
>   cpu_vendor_id = find_cpu_vendor_id();
> 
>   if (fix_cpuid()) {

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r316767 - head/sys/amd64/amd64

[Dexuan Cui via svn-src-all]

> From: Konstantin Belousov
> > It looks memory allocated by bus_dmamem_alloc() and malloc()
> > is not executable now.
> >
> > What else can we use?
> > I guess we can only use contigmalloc() or kmem_malloc() to
> > get a page that can be executable and use vtophys() to get its
> > physical address?
> Yes, the kmem_malloc() is considered to be a suitable substitution for
> regular malloc(9) if the executable mapping is needed.  See r317072
> for a similar fix for the same issue.

Thanks, kib!
We have fixed Hyper-V drivers with kmem_malloc().

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r316767 - head/sys/amd64/amd64

[Dexuan Cui via svn-src-all]

> From: owner-svn-src-h...@freebsd.org [mailto:owner-svn-src-
> h...@freebsd.org] On Behalf Of Konstantin Belousov
> Sent: Thursday, April 13, 2017 23:50
> 
> Author: kib
> Date: Thu Apr 13 15:49:55 2017
> New Revision: 316767
> URL:
> 
> Log:
>   Map DMAP as nx.
> 
>   Demotions preserve PG_NX, so it is enough to set nx bit for initial
>   lowest-level paging entries.
> 
> Modified:
>   head/sys/amd64/amd64/pmap.c
 
Hi kib,
Unluckily this patch breaks Hyper-V VM:

In dev/hyperv/vmbus/hyperv.c: hypercall_create() we allocate one
page and pass its physical address to the hypervisor, which initializes
the page with executable code.

Later in dev/hyperv/vmbus/hyperv.c: hypercall_post_message(), we
"call" the executable code in the above page.

Now with NX, the "call" gets a fault and as a result FreeBSD VM
can't boot on Hyper-V.

It looks memory allocated by bus_dmamem_alloc() and malloc()
is not executable now.

What else can we use?
I guess we can only use contigmalloc() or kmem_malloc() to
get a page that can be executable and use vtophys() to get its
physical address?

Looking forward to your suggestion!

Thanks!
-- Dexuan

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r314891 - head/sys/boot/efi/loader

[Dexuan Cui via svn-src-all]

> From: Rodney W. Grimes [mailto:free...@pdx.rh.cn85.dnsmgr.net]
> Sent: Wednesday, March 8, 2017 12:33
> > Author: dexuan
> > Date: Wed Mar  8 02:50:29 2017
> > New Revision: 314891
> > Log:
> >   loader.efi: finally fix the off-by-one bug in efi_verify_staging_size()
> >
> >   r314828(loader.efi: fix an off-by-one bug in efi_verify_staging_size())
> >   doesn't really fix the bug and this patch adds the missing part.
> >
> >   It's a shame that I didn't make everything correct at the very 
> > beginning...
> 
> My thoughts on that:
> 
> Try as hard as we can and you well come up short on making software
> correct in the beginning as it is an iterative process.  Be glad you
> have found and fixed yet another small problem, and hope that in
> doing so you have not introduced another.
> 
> I thank you for your persuit of this latent issue in loader.efi!
> --
> Rod Grimes  

The lesson I learned here is that: do test the code with real test cases,
no matter how confident I'm in the patch, and no matter how small
the change would look like.

And another issue here is that actually I don't have a local physical
FreeBSD machine yet. Trying to set up one.

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r312687 - in head/sys: net sys

[Dexuan Cui via svn-src-all]

> From: Dexuan Cui [mailto:de...@microsoft.com]
> Sent: Wednesday, January 25, 2017 06:21
> To: Gleb Smirnoff ; Dexuan Cui 
> Cc: src-committ...@freebsd.org; svn-src-all@freebsd.org; svn-src-
> h...@freebsd.org
> Subject: RE: svn commit: r312687 - in head/sys: net sys
> 
> > From: Gleb Smirnoff [mailto:gleb...@freebsd.org]
> >   Dexuan,
> >
> > On Tue, Jan 24, 2017 at 09:19:47AM +, Dexuan Cui wrote:
> > D> --- head/sys/sys/eventhandler.h  Tue Jan 24 09:15:36 2017
> > (r312686)
> > D> +++ head/sys/sys/eventhandler.h  Tue Jan 24 09:19:46 2017
> > (r312687)
> > D> @@ -284,4 +284,11 @@ typedef void (*swapoff_fn)(void *, struc
> > D>  EVENTHANDLER_DECLARE(swapon, swapon_fn);
> > D>  EVENTHANDLER_DECLARE(swapoff, swapoff_fn);
> > D>
> > D> +/* ifup/ifdown events */
> > D> +#define IFNET_EVENT_UP  0
> > D> +#define IFNET_EVENT_DOWN1
> > D> +struct ifnet;
> > D> +typedef void (*ifnet_event_fn)(void *, struct ifnet *ifp, int event);
> > D> +EVENTHANDLER_DECLARE(ifnet_event, ifnet_event_fn);
> > D> +
> > D>  #endif /* _SYS_EVENTHANDLER_H_ */
> >
> > The network stuff shall not be added to sys/eventhandler.h.
> >
> > All these declarations should go to net/if_var.h. There is already
> > a block of event(9) defines there. Please move it there.
> >
> > --
> > Totus tuus, Glebius.
> 
> Hi Gleb,
> Sorry, I didn't realize this... I'll move it as you suggested.
> 
> Thank you for the reminder!
> 
> -- Dexuan

I posted https://reviews.freebsd.org/D9345 for this.

Please review it.

Thanks,
-- Dexuan

___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r312687 - in head/sys: net sys

[Dexuan Cui via svn-src-all]

> From: Gleb Smirnoff [mailto:gleb...@freebsd.org]
>   Dexuan,
> 
> On Tue, Jan 24, 2017 at 09:19:47AM +, Dexuan Cui wrote:
> D> --- head/sys/sys/eventhandler.hTue Jan 24 09:15:36 2017
>   (r312686)
> D> +++ head/sys/sys/eventhandler.hTue Jan 24 09:19:46 2017
>   (r312687)
> D> @@ -284,4 +284,11 @@ typedef void (*swapoff_fn)(void *, struc
> D>  EVENTHANDLER_DECLARE(swapon, swapon_fn);
> D>  EVENTHANDLER_DECLARE(swapoff, swapoff_fn);
> D>
> D> +/* ifup/ifdown events */
> D> +#define IFNET_EVENT_UP0
> D> +#define IFNET_EVENT_DOWN  1
> D> +struct ifnet;
> D> +typedef void (*ifnet_event_fn)(void *, struct ifnet *ifp, int event);
> D> +EVENTHANDLER_DECLARE(ifnet_event, ifnet_event_fn);
> D> +
> D>  #endif /* _SYS_EVENTHANDLER_H_ */
> 
> The network stuff shall not be added to sys/eventhandler.h.
> 
> All these declarations should go to net/if_var.h. There is already
> a block of event(9) defines there. Please move it there.
> 
> --
> Totus tuus, Glebius.

Hi Gleb,
Sorry, I didn't realize this... I'll move it as you suggested.

Thank you for the reminder!

-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r308798 - head/share/man/man4

[Dexuan Cui via svn-src-all]

> From: John Baldwin [mailto:j...@freebsd.org]
> Sent: Saturday, November 19, 2016 00:44
> To: Dexuan Cui 
> Cc: src-committ...@freebsd.org; svn-src-all@freebsd.org; svn-src-
> h...@freebsd.org
> Subject: Re: svn commit: r308798 - head/share/man/man4
> 
> On Friday, November 18, 2016 07:36:00 AM Dexuan Cui wrote:
> > Author: dexuan
> > Date: Fri Nov 18 07:36:00 2016
> > New Revision: 308798
> >
> > Log:
> >   remove the hv_ata_pci_disengage(4) manual
> >
> You will also want to add an entry in head/ObsoleteFiles.inc so that the 
> installed
> manpage on existing systems gets deleted via 'make delete-old'.
> 
> John Baldwin

Hi, I made https://reviews.freebsd.org/D8572 for this.

Please review it.

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r308798 - head/share/man/man4

[Dexuan Cui via svn-src-all]

> From: John Baldwin [mailto:j...@freebsd.org]
> Sent: Saturday, November 19, 2016 00:44
> To: Dexuan Cui 
> Cc: src-committ...@freebsd.org; svn-src-all@freebsd.org; svn-src-
> h...@freebsd.org
> Subject: Re: svn commit: r308798 - head/share/man/man4
> 
> On Friday, November 18, 2016 07:36:00 AM Dexuan Cui wrote:
> > Author: dexuan
> > Date: Fri Nov 18 07:36:00 2016
> > New Revision: 308798
> > Log:
> >   remove the hv_ata_pci_disengage(4) manual
> >
> >   A few months ago, we removed the driver, which was not necessary any
> longer.
> 
> You will also want to add an entry in head/ObsoleteFiles.inc so that the 
> installed
> manpage on existing systems gets deleted via 'make delete-old'.
> 
> John Baldwin

Hi John,
Thanks for the reminder! Ngie also pointed this out to me.

It turns out I'm too new to the build system. :-)
It would be great if you can help to add a patch for this, as I won't be able to
make and test such a patch until next Monday. Sorry.

Or I can do it next Monday.  I'm OK either way.

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r308799 - head/share/man/man4

[Dexuan Cui via svn-src-all]

> > Author: dexuan
> > Date: Fri Nov 18 08:15:45 2016
> > New Revision: 308799
> > Modified: head/share/man/man4/Makefile
> >
> =
> > --- head/share/man/man4/MakefileFri Nov 18 07:36:00
> > 2016(r308798) +++ head/share/man/man4/Makefile  Fri Nov
> > 18 08:15:45 2016(r308799) @@ -187,7 +187,6 @@ MAN=
> > aac.4 \ ${_hptmv.4} \
> > ${_hptnr.4} \
> > ${_hptrr.4} \
> > -   hv_ata_pci_disengage.4 \
> > hv_kvp.4 \
> > hv_netvsc.4 \
> > hv_storvsc.4 \
> >
> 
> Should the other Hyper-V man pages be installed on architectures where
> the driver is unavailable?
> 
> Andrew

I don't think so. :-)

I created a patch for this: https://reviews.freebsd.org/D8572

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r308798 - head/share/man/man4

[Dexuan Cui via svn-src-all]

> >   head/share/man/man4/hv_ata_pci_disengage.4
> > Modified:
> >   head/share/man/man4/hv_vmbus.4
> > @@ -74,7 +74,6 @@ the interface that facilitate high perfo
> >  between the VSCs and VSPs.
> >  All VSCs utilize the VMBus driver.
> >  .Sh SEE ALSO
> > -.Xr hv_ata_pci_disengage 4 ,
> >  .Xr hv_netvsc 4 ,
> 
> This causes a build failure:
> 
> make[5]: make[5]: don't know how to make hv_ata_pci_disengage.4. Stop
> 
> make[5]: stopped in /opt/src/svn-current/share/man/man4
> *** [all_subdir_share/man/man4] Error code 2
> 
> You'll need to remove its reference from the Makefile.

Hi Cy,

Thank you for reporting this! I committed a fix just now. 

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r308725 - in head/sys: conf dev/hyperv/pcib modules/hyperv/pcib

[Dexuan Cui via svn-src-all]

> From: Dexuan Cui [mailto:de...@microsoft.com]
> > From: Ngie Cooper [mailto:yaneurab...@gmail.com]
> > Sent: Friday, November 18, 2016 05:37
> > To: Andreas Tobler 
> > On Thu, Nov 17, 2016 at 9:46 AM, Andreas Tobler 
> > wrote:
> > > On 16.11.16 10:25, Dexuan Cui wrote:
> > >>
> > >> Author: dexuan
> > >> Date: Wed Nov 16 09:25:00 2016
> > >> New Revision: 308725
> >
> > > -dev/hyperv/pcib/pcib.c optionalhyperv
> > > +dev/hyperv/pcib/pcib.c optionalhyperv pci
> >
> > This seems to be causing Jenkins failures too:
> > Doesn't sys/modules/hyperv/vmbus/Makefile need pci_if.h now in SRCS?
> > Thanks,
> > -Ngie
> 
> Hi Ngie, Andreas,
> Thanks for the reminder!  I'll fix this ASAP.
> Now I'm testing local changes and will report back shortly.
 
Hi, I committed a patch to fix the issue just now.

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

RE: svn commit: r308725 - in head/sys: conf dev/hyperv/pcib modules/hyperv/pcib

[Dexuan Cui via svn-src-all]

> From: Ngie Cooper [mailto:yaneurab...@gmail.com]
> Sent: Friday, November 18, 2016 05:37
> To: Andreas Tobler 
> On Thu, Nov 17, 2016 at 9:46 AM, Andreas Tobler 
> wrote:
> > On 16.11.16 10:25, Dexuan Cui wrote:
> >>
> >> Author: dexuan
> >> Date: Wed Nov 16 09:25:00 2016
> >> New Revision: 308725
> 
> > -dev/hyperv/pcib/pcib.c optionalhyperv
> > +dev/hyperv/pcib/pcib.c optionalhyperv pci
> 
> This seems to be causing Jenkins failures too:
> Doesn't sys/modules/hyperv/vmbus/Makefile need pci_if.h now in SRCS?
> Thanks,
> -Ngie

Hi Ngie, Andreas,
Thanks for the reminder!  I'll fix this ASAP.
Now I'm testing local changes and will report back shortly.

Thanks,
-- Dexuan
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"