svn commit: r368547 - head/lib/libc/gen
Author: ngie Date: Fri Dec 11 02:22:42 2020 New Revision: 368547 URL: https://svnweb.freebsd.org/changeset/base/368547 Log: timespec_get(3): sort SEE ALSO correctly clock_gettime(2) should be mentioned before gettimeofday(2). Reported by: make manlint MFC after:1 week Sponsored by: DellEMC Isilon Modified: head/lib/libc/gen/timespec_get.3 Modified: head/lib/libc/gen/timespec_get.3 == --- head/lib/libc/gen/timespec_get.3Fri Dec 11 01:52:27 2020 (r368546) +++ head/lib/libc/gen/timespec_get.3Fri Dec 11 02:22:42 2020 (r368547) @@ -66,8 +66,8 @@ if successful, otherwise .Dv 0 on failure. .Sh SEE ALSO -.Xr gettimeofday 2 , .Xr clock_gettime 2 , +.Xr gettimeofday 2 , .Xr time 3 .Sh STANDARDS The ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368546 - head/lib/libc/sys
Author: ngie
Date: Fri Dec 11 01:52:27 2020
New Revision: 368546
URL: https://svnweb.freebsd.org/changeset/base/368546
Log:
cpuset{,_getaffinity,_getdomain}.2: fix SEE ALSO
Sort by manpage section, then sort entries alphabetically.
This makes the manpages `make manlint` clean.
MFC after:1 week
Sponsored by: DellEMC Isilon
Modified:
head/lib/libc/sys/cpuset.2
head/lib/libc/sys/cpuset_getaffinity.2
head/lib/libc/sys/cpuset_getdomain.2
Modified: head/lib/libc/sys/cpuset.2
==
--- head/lib/libc/sys/cpuset.2 Fri Dec 11 01:06:49 2020(r368545)
+++ head/lib/libc/sys/cpuset.2 Fri Dec 11 01:52:27 2020(r368546)
@@ -221,8 +221,8 @@ for allocation.
.Sh SEE ALSO
.Xr cpuset 1 ,
.Xr cpuset_getaffinity 2 ,
-.Xr cpuset_setaffinity 2 ,
.Xr cpuset_getdomain 2 ,
+.Xr cpuset_setaffinity 2 ,
.Xr cpuset_setdomain 2 ,
.Xr pthread_affinity_np 3 ,
.Xr pthread_attr_affinity_np 3 ,
Modified: head/lib/libc/sys/cpuset_getaffinity.2
==
--- head/lib/libc/sys/cpuset_getaffinity.2 Fri Dec 11 01:06:49 2020
(r368545)
+++ head/lib/libc/sys/cpuset_getaffinity.2 Fri Dec 11 01:52:27 2020
(r368546)
@@ -155,15 +155,15 @@ See
.Xr capsicum 4 .
.El
.Sh SEE ALSO
-.Xr capsicum 4 ,
.Xr cpuset 1 ,
.Xr cpuset 2 ,
-.Xr cpuset_getid 2 ,
-.Xr cpuset_setid 2 ,
.Xr cpuset_getdomain 2 ,
+.Xr cpuset_getid 2 ,
.Xr cpuset_setdomain 2 ,
+.Xr cpuset_setid 2 ,
.Xr pthread_affinity_np 3 ,
.Xr pthread_attr_affinity_np 3 ,
+.Xr capsicum 4 ,
.Xr cpuset 9
.Sh HISTORY
The
Modified: head/lib/libc/sys/cpuset_getdomain.2
==
--- head/lib/libc/sys/cpuset_getdomain.2Fri Dec 11 01:06:49 2020
(r368545)
+++ head/lib/libc/sys/cpuset_getdomain.2Fri Dec 11 01:52:27 2020
(r368546)
@@ -174,13 +174,13 @@ See
.Xr capsicum 4 .
.El
.Sh SEE ALSO
-.Xr capsicum 4 ,
.Xr cpuset 1 ,
.Xr cpuset 2 ,
-.Xr cpuset_getid 2 ,
-.Xr cpuset_setid 2 ,
.Xr cpuset_getaffinity 2 ,
+.Xr cpuset_getid 2 ,
.Xr cpuset_setaffinity 2 ,
+.Xr cpuset_setid 2 ,
+.Xr capsicum 4 ,
.Xr cpuset 9
.Sh HISTORY
The
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368537 - head/lib/libc/sys
Author: ngie Date: Fri Dec 11 00:28:28 2020 New Revision: 368537 URL: https://svnweb.freebsd.org/changeset/base/368537 Log: aio_suspend.2: properly canonicalize .Dd Months should be fully spelled as their local-specific equivalents: in this case `Oct` should have been spelled like `October`. Reported by: make manlint MFC after:1 week Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/aio_suspend.2 Modified: head/lib/libc/sys/aio_suspend.2 == --- head/lib/libc/sys/aio_suspend.2 Fri Dec 11 00:26:49 2020 (r368536) +++ head/lib/libc/sys/aio_suspend.2 Fri Dec 11 00:28:28 2020 (r368537) @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd Oct 23, 2017 +.Dd October 23, 2017 .Dt AIO_SUSPEND 2 .Os .Sh NAME ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368536 - head/lib/libc/sys
Author: ngie Date: Fri Dec 11 00:26:49 2020 New Revision: 368536 URL: https://svnweb.freebsd.org/changeset/base/368536 Log: cap_enter(2): fix CAVEATS section The CAVEATS section was misspelled as "CAVEAT" before this change. Fix the spelling to identify issues related to the section. Furthermore, given that the section order was incorrect, move the CAVEATS section down to the bottom of the manpage, per the conventional section order. MFC after:1 week Reported by: make manlint Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/cap_enter.2 Modified: head/lib/libc/sys/cap_enter.2 == --- head/lib/libc/sys/cap_enter.2 Fri Dec 11 00:25:34 2020 (r368535) +++ head/lib/libc/sys/cap_enter.2 Fri Dec 11 00:26:49 2020 (r368536) @@ -97,19 +97,6 @@ and operations of the .Xr procctl 2 function for similar per-process functionality. -.Sh CAVEAT -Creating effective process sandboxes is a tricky process that involves -identifying the least possible rights required by the process and then -passing those rights into the process in a safe manner. -Consumers of -.Fn cap_enter -should also be aware of other inherited rights, such as access to VM -resources, memory contents, and other process properties that should be -considered. -It is advisable to use -.Xr fexecve 2 -to create a runtime environment inside the sandbox that has as few implicitly -acquired rights as possible. .Sh RETURN VALUES .Rv -std cap_enter cap_getmode .Pp @@ -162,3 +149,16 @@ These functions and the capability facility were creat .An "Robert N. M. Watson" at the University of Cambridge Computer Laboratory with support from a grant from Google, Inc. +.Sh CAVEATS +Creating effective process sandboxes is a tricky process that involves +identifying the least possible rights required by the process and then +passing those rights into the process in a safe manner. +Consumers of +.Fn cap_enter +should also be aware of other inherited rights, such as access to VM +resources, memory contents, and other process properties that should be +considered. +It is advisable to use +.Xr fexecve 2 +to create a runtime environment inside the sandbox that has as few implicitly +acquired rights as possible. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368534 - head/lib/libc/gen
Author: ngie Date: Fri Dec 11 00:20:04 2020 New Revision: 368534 URL: https://svnweb.freebsd.org/changeset/base/368534 Log: posix_spawn(3): fix section that references `vfork` `vfork(2)` should be referenced in paragraphs as `.Fn vfork`, not `vfork()`. This change switches the reference to use `.Fn`, which in turn makes the manpage `make manlint` clean. MFC after:1 week Reported by: make manlint Sponsored by: DellEMC Isilon Modified: head/lib/libc/gen/posix_spawn.3 Modified: head/lib/libc/gen/posix_spawn.3 == --- head/lib/libc/gen/posix_spawn.3 Fri Dec 11 00:15:57 2020 (r368533) +++ head/lib/libc/gen/posix_spawn.3 Fri Dec 11 00:20:04 2020 (r368534) @@ -300,7 +300,9 @@ had been called to create a child process and then .Fn execve had been called by the child process to execute the new process image. .Pp -The implementation uses vfork(), thus the fork handlers are not run when +The implementation uses +.Fn vfork , +thus the fork handlers are not run when .Fn posix_spawn or .Fn posix_spawnp ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368533 - head/lib/libc/gen
Author: ngie Date: Fri Dec 11 00:15:57 2020 New Revision: 368533 URL: https://svnweb.freebsd.org/changeset/base/368533 Log: getentropy(3): sort SEE ALSO sections Sorting order should be done by manpage section (2 vs 3), then alphabetically. This change fixes the order to sort by the manpage section, first. Reported by: make manlint MFC after:1 week Sponsored by: DellEMC Isilon Modified: head/lib/libc/gen/getentropy.3 Modified: head/lib/libc/gen/getentropy.3 == --- head/lib/libc/gen/getentropy.3 Fri Dec 11 00:13:39 2020 (r368532) +++ head/lib/libc/gen/getentropy.3 Fri Dec 11 00:15:57 2020 (r368533) @@ -66,8 +66,8 @@ invalid address. Too many bytes requested, or some other fatal error occurred. .El .Sh SEE ALSO -.Xr arc4random 3 , .Xr getrandom 2 , +.Xr arc4random 3 , .Xr random 4 .Sh STANDARDS .Fn getentropy ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368532 - head/lib/libc/gen
Author: ngie Date: Fri Dec 11 00:13:39 2020 New Revision: 368532 URL: https://svnweb.freebsd.org/changeset/base/368532 Log: arc4random(3): fix .Xr issues - pthreads(3) should actually be pthread(3). - getentropy(2) should actually be getentropy(3). This makes the manpage `make manlint` clean. MFC after:1 week Sponsored by: DellEMC Isilon Modified: head/lib/libc/gen/arc4random.3 Modified: head/lib/libc/gen/arc4random.3 == --- head/lib/libc/gen/arc4random.3 Thu Dec 10 23:58:27 2020 (r368531) +++ head/lib/libc/gen/arc4random.3 Fri Dec 11 00:13:39 2020 (r368532) @@ -62,7 +62,7 @@ consumption because the other interfaces are deficient quality, portability, standardization, or availability. These functions can be called in almost all coding environments, including -.Xr pthreads 3 +.Xr pthread 3 and .Xr chroot 2 . .Pp @@ -74,7 +74,7 @@ under program flow can act as additional stirring. The subsystem is re-seeded from the kernel .Xr random 4 subsystem using -.Xr getentropy 2 +.Xr getentropy 3 on a regular basis, and also upon .Xr fork 2 . .Pp ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368436 - head/lib/libc/sys
Author: ngie Date: Tue Dec 8 04:18:16 2020 New Revision: 368436 URL: https://svnweb.freebsd.org/changeset/base/368436 Log: extattr_get_file(20: bump .Dd This is being done for the formatting and context changes. While the net content hasn't been changed, the content/context changes were sufficient to warrant the date bump. MFC after:1 week MFC with: r368431, r368433, r368434, r368435 Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/extattr_get_file.2 Modified: head/lib/libc/sys/extattr_get_file.2 == --- head/lib/libc/sys/extattr_get_file.2Tue Dec 8 04:16:05 2020 (r368435) +++ head/lib/libc/sys/extattr_get_file.2Tue Dec 8 04:18:16 2020 (r368436) @@ -26,7 +26,7 @@ .\" .\" $FreeBSD$ .\" -.Dd January 29, 2008 +.Dd December 7, 2020 .Dt EXTATTR 2 .Os .Sh NAME ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368435 - head/lib/libc/sys
Author: ngie Date: Tue Dec 8 04:16:05 2020 New Revision: 368435 URL: https://svnweb.freebsd.org/changeset/base/368435 Log: extattr_get_file(2): clarify RETURN VALUES While some of the syscalls' behavior were documented and implied in the RETURN VALUES section by earlier, e.g., the DESCRIPTION sections, as having behavior of the other calls (`*_fd` vs `*_file` vs `*_link`), there was a lot of implied return value behavior in the section prior to this change. Explicitly document the syscall behavior per the current implementation in sys/kern/vfs_extattr.c so others can better develop based on its explicit documented behavior instead of having to digest the context of the manpage to understand the appropriate behavior. MFC after:1 week MFC with: r368431, r368433, r368434 Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/extattr_get_file.2 Modified: head/lib/libc/sys/extattr_get_file.2 == --- head/lib/libc/sys/extattr_get_file.2Tue Dec 8 04:05:19 2020 (r368434) +++ head/lib/libc/sys/extattr_get_file.2Tue Dec 8 04:16:05 2020 (r368435) @@ -169,21 +169,32 @@ For more information on named extended attributes, ple .Xr extattr 9 . .Sh RETURN VALUES If successful, the +.Fn extattr_get_fd , .Fn extattr_get_file , +.Fn extattr_get_link , +.Fn extattr_list_fd , +.Fn extattr_list_file , +.Fn extattr_list_link , +.Fn extattr_set_fd , .Fn extattr_set_file , and -.Fn extattr_list_file +.Fn extattr_set_link calls return the number of bytes that were read or written from the .Fa data , -respectively, or if +respectively. +If .Fa data was .Dv NULL , then -.Fn extattr_get_file +.Fn extattr_get_fd , +.Fn extattr_get_file , +.Fn extattr_get_link , +.Fn extattr_list_fd , +.Fn extattr_list_file , and -.Fn extattr_list_file +.Fn extattr_list_link return the number of bytes available to read. If any of the calls are unsuccessful, the value \-1 is returned and the global variable ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368434 - head/lib/libc/sys
Author: ngie Date: Tue Dec 8 04:05:19 2020 New Revision: 368434 URL: https://svnweb.freebsd.org/changeset/base/368434 Log: extattr_get_file(2): fix more formatting - Remove an unnecessary trailing comma separating a two-item clause. - Sort more function calls alphabetically (in the same vein as r368433). MFC after:1 week Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/extattr_get_file.2 Modified: head/lib/libc/sys/extattr_get_file.2 == --- head/lib/libc/sys/extattr_get_file.2Tue Dec 8 04:01:03 2020 (r368433) +++ head/lib/libc/sys/extattr_get_file.2Tue Dec 8 04:05:19 2020 (r368434) @@ -101,7 +101,7 @@ Each list entry consists of a single byte containing t of the attribute name, followed by the attribute name. The attribute name is not terminated by ASCII 0 (nul). The -.Fn extattr_get_file , +.Fn extattr_get_file and .Fn extattr_list_file calls consume the @@ -135,10 +135,10 @@ they do not follow symlinks. .Pp The .Fn extattr_get_fd , -.Fn extattr_set_fd , .Fn extattr_delete_fd , -and .Fn extattr_list_fd , +and +.Fn extattr_set_fd calls are identical to their .Qq Li _file counterparts except for the first argument. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368433 - head/lib/libc/sys
Author: ngie Date: Tue Dec 8 04:01:03 2020 New Revision: 368433 URL: https://svnweb.freebsd.org/changeset/base/368433 Log: extattr_get_file(2): sort syscalls alphabetically Although some sections of the manpage sort the syscalls alphabetically, many core areas of the manpage do not. Sort the syscalls so it is easier to pick out functional changes and to improve manpage readability. This formatting change is also being done to make future functional changes easier to spot. MFC after:1 week Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/extattr_get_file.2 Modified: head/lib/libc/sys/extattr_get_file.2 == --- head/lib/libc/sys/extattr_get_file.2Tue Dec 8 03:48:05 2020 (r368432) +++ head/lib/libc/sys/extattr_get_file.2Tue Dec 8 04:01:03 2020 (r368433) @@ -30,48 +30,48 @@ .Dt EXTATTR 2 .Os .Sh NAME -.Nm extattr_get_fd , -.Nm extattr_set_fd , .Nm extattr_delete_fd , -.Nm extattr_list_fd , -.Nm extattr_get_file , -.Nm extattr_set_file , .Nm extattr_delete_file , -.Nm extattr_list_file , -.Nm extattr_get_link , -.Nm extattr_set_link , .Nm extattr_delete_link , -.Nm extattr_list_link +.Nm extattr_get_fd , +.Nm extattr_get_file , +.Nm extattr_get_link , +.Nm extattr_list_fd , +.Nm extattr_list_file , +.Nm extattr_list_link , +.Nm extattr_set_fd , +.Nm extattr_set_file , +.Nm extattr_set_link .Nd system calls to manipulate VFS extended attributes .Sh LIBRARY .Lb libc .Sh SYNOPSIS .In sys/types.h .In sys/extattr.h -.Ft ssize_t -.Fn extattr_get_fd "int fd" "int attrnamespace" "const char *attrname" "void *data" "size_t nbytes" -.Ft ssize_t -.Fn extattr_set_fd "int fd" "int attrnamespace" "const char *attrname" "const void *data" "size_t nbytes" .Ft int .Fn extattr_delete_fd "int fd" "int attrnamespace" "const char *attrname" +.Ft int +.Fn extattr_delete_file "const char *path" "int attrnamespace" "const char *attrname" +.Ft int +.Fn extattr_delete_link "const char *path" "int attrnamespace" "const char *attrname" .Ft ssize_t -.Fn extattr_list_fd "int fd" "int attrnamespace" "void *data" "size_t nbytes" +.Fn extattr_get_fd "int fd" "int attrnamespace" "const char *attrname" "void *data" "size_t nbytes" .Ft ssize_t .Fn extattr_get_file "const char *path" "int attrnamespace" "const char *attrname" "void *data" "size_t nbytes" .Ft ssize_t -.Fn extattr_set_file "const char *path" "int attrnamespace" "const char *attrname" "const void *data" "size_t nbytes" -.Ft int -.Fn extattr_delete_file "const char *path" "int attrnamespace" "const char *attrname" +.Fn extattr_get_link "const char *path" "int attrnamespace" "const char *attrname" "void *data" "size_t nbytes" .Ft ssize_t +.Fn extattr_list_fd "int fd" "int attrnamespace" "void *data" "size_t nbytes" +.Ft ssize_t .Fn extattr_list_file "const char *path" "int attrnamespace" "void *data" "size_t nbytes" .Ft ssize_t -.Fn extattr_get_link "const char *path" "int attrnamespace" "const char *attrname" "void *data" "size_t nbytes" +.Fn extattr_list_link "const char *path" "int attrnamespace" "void *data" "size_t nbytes" .Ft ssize_t -.Fn extattr_set_link "const char *path" "int attrnamespace" "const char *attrname" "const void *data" "size_t nbytes" -.Ft int -.Fn extattr_delete_link "const char *path" "int attrnamespace" "const char *attrname" +.Fn extattr_set_fd "int fd" "int attrnamespace" "const char *attrname" "const void *data" "size_t nbytes" .Ft ssize_t -.Fn extattr_list_link "const char *path" "int attrnamespace" "void *data" "size_t nbytes" +.Fn extattr_set_file "const char *path" "int attrnamespace" "const char *attrname" "const void *data" "size_t nbytes" +.Ft ssize_t +.Fn extattr_set_link "const char *path" "int attrnamespace" "const char *attrname" "const void *data" "size_t nbytes" .Sh DESCRIPTION Named extended attributes are meta-data associated with vnodes representing files and directories. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368432 - head/lib/libc/sys
Author: ngie Date: Tue Dec 8 03:48:05 2020 New Revision: 368432 URL: https://svnweb.freebsd.org/changeset/base/368432 Log: lio_listio(2): fix manlint error The date with .Dd prior to this change isn't canonically spelled out: it should have been "December", not "Dec". MFC after:1 week Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/lio_listio.2 Modified: head/lib/libc/sys/lio_listio.2 == --- head/lib/libc/sys/lio_listio.2 Tue Dec 8 03:43:00 2020 (r368431) +++ head/lib/libc/sys/lio_listio.2 Tue Dec 8 03:48:05 2020 (r368432) @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd Dec 7, 2019 +.Dd December 7, 2019 .Dt LIO_LISTIO 2 .Os .Sh NAME ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r368431 - head/lib/libc/sys
Author: ngie Date: Tue Dec 8 03:43:00 2020 New Revision: 368431 URL: https://svnweb.freebsd.org/changeset/base/368431 Log: extattr_get_fd(2): fix manlint errors - The CAVEATS section was misspelled as "CAVEAT". - The CAVEATS section should come before the "BUGS" section and after other existing sections by convention. MFC after:1 week Reported by: make manlint Sponsored by: DellEMC Isilon Modified: head/lib/libc/sys/extattr_get_file.2 Modified: head/lib/libc/sys/extattr_get_file.2 == --- head/lib/libc/sys/extattr_get_file.2Tue Dec 8 01:47:59 2020 (r368430) +++ head/lib/libc/sys/extattr_get_file.2Tue Dec 8 03:43:00 2020 (r368431) @@ -167,10 +167,6 @@ is attribute-specific. .Pp For more information on named extended attributes, please see .Xr extattr 9 . -.Sh CAVEAT -This interface is under active development, and as such is subject to -change as applications are adapted to use it. -Developers are discouraged from relying on its stability. .Sh RETURN VALUES If successful, the .Fn extattr_get_file , @@ -264,6 +260,10 @@ Project, and introduced in .Fx 5.0 . It was developed to support security extensions requiring additional labels to be associated with each file or directory. +.Sh CAVEATS +This interface is under active development, and as such is subject to +change as applications are adapted to use it. +Developers are discouraged from relying on its stability. .Sh BUGS In earlier versions of this API, passing an empty string for the attribute name to ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r367399 - head/contrib/bsnmp/snmpd
Author: ngie
Date: Thu Nov 5 21:37:24 2020
New Revision: 367399
URL: https://svnweb.freebsd.org/changeset/base/367399
Log:
snmpmod(3): fix typo under the COMMUNITIES section
"recipte" should be spelled like "receipt".
.Dd is intentionally not being bumped for the change.
MFC after:1 week
Sponsored by: DellEMC
Modified:
head/contrib/bsnmp/snmpd/snmpmod.3
Modified: head/contrib/bsnmp/snmpd/snmpmod.3
==
--- head/contrib/bsnmp/snmpd/snmpmod.3 Thu Nov 5 20:52:49 2020
(r367398)
+++ head/contrib/bsnmp/snmpd/snmpmod.3 Thu Nov 5 21:37:24 2020
(r367399)
@@ -577,7 +577,7 @@ struct systemg {
.Ed
.Ss COMMUNITIES
The SNMP daemon implements a community table.
-On recipte of a request message
+On receipt of a request message
the community string in that message is compared to each of the community
strings in that table, if a match is found, the global variable
.Va community
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r366697 - head/usr.bin/xinstall
> On Oct 14, 2020, at 5:28 AM, Alex Richardson wrote: > > Author: arichardson > Date: Wed Oct 14 12:28:41 2020 > New Revision: 366697 > URL: https://svnweb.freebsd.org/changeset/base/366697 > > Log: > install(1): Avoid unncessary fstatfs() calls and use mmap() based on size > > According to git blame the trymmap() function was added in 1996 to skip > mmap() calls for NFS file systems. However, nowadays mmap() should be > perfectly safe even on NFS. Importantly, onl ufs and cd9660 file systems > were whitelisted so we don't use mmap() on ZFS. It also prevents the use > of mmap() when bootstrapping from macOS/Linux since on those systems the > trymmap() function was always returning zero due to the missing MFSNAMELEN > define. > > This change keeps the trymmap() function but changes it to check whether > using mmap() can reduce the number of system calls that are required. > Using mmap() only reduces the number of system calls if we need multiple > read() > syscalls, i.e. if the file size is > MAXBSIZE. However, mmap() is more > expensive > than read() so this sets the threshold at 4 fewer syscalls. Additionally, for > larger file size mmap() can significantly increase the number of page faults, > so avoid it in that case. > > It's unclear whether using mmap() is ever faster than a read with an > appropriate > buffer size, but this change at least removes two unnecessary system calls > for every file that is installed. > > Reviewed By: markj > Differential Revision: https://reviews.freebsd.org/D26041 * Has this change been tested out with source filesystems other than UFS/ZFS? Not all filesystems support mmap(2). * trymmap(..) seems to be less about computing whether or not the filesystem should use mmap(2) after this change, but how it should use mmap(2). Seems like a misnamed function call now. Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r366327 - in head/lib/libc: gen net
Author: ngie
Date: Thu Oct 1 16:37:49 2020
New Revision: 366327
URL: https://svnweb.freebsd.org/changeset/base/366327
Log:
Eliminate duplicate `afterinstallconfigs` target
Define separate dependent targets which `afterinstallconfigs` relies on, in
order to modify `${DESTDIR}/etc/master.passwd` and
`${DESTDIR}/etc/nsswitch.conf`.
Mark these targets .PHONY, since they manipulate configurations on the fly and
the generation logic isn't 100% defined in terms of the source files/logic,
and is variable, based on MK_foo flags.
MFC after:2 weeks
Reviewed by: bapt, brd
Differential Revision:https://reviews.freebsd.org/D20330
Modified:
head/lib/libc/gen/Makefile.inc
head/lib/libc/net/Makefile.inc
Modified: head/lib/libc/gen/Makefile.inc
==
--- head/lib/libc/gen/Makefile.inc Thu Oct 1 16:25:35 2020
(r366326)
+++ head/lib/libc/gen/Makefile.inc Thu Oct 1 16:37:49 2020
(r366327)
@@ -552,7 +552,8 @@ MLINKS+=wordexp.3 wordfree.3
.include
-afterinstallconfig:
+afterinstallconfig: install-passwd
+install-passwd: .PHONY
.if ${MK_TCSH} == "no"
sed -i "" -e 's;/bin/csh;/bin/sh;' ${DESTDIR}/etc/master.passwd
.endif
Modified: head/lib/libc/net/Makefile.inc
==
--- head/lib/libc/net/Makefile.inc Thu Oct 1 16:25:35 2020
(r366326)
+++ head/lib/libc/net/Makefile.inc Thu Oct 1 16:37:49 2020
(r366327)
@@ -124,8 +124,9 @@ SRCS+= hesiod.c
MAN+= hesiod.3
.endif
+afterinstallconfig: modify-nsswitch-conf
+modify-nsswitch-conf: .PHONY
.if ${MK_NIS} == "no"
-afterinstallconfig:
sed -i "" -e 's/.*_compat:/# &/' -e 's/compat$$/files/' \
${DESTDIR}/etc/nsswitch.conf
.endif
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r363088 - head/usr.bin/xinstall/tests
> On Jul 10, 2020, at 6:13 PM, Eugene Grosbein wrote: > > 11.07.2020 8:07, Eugene Grosbein wrote: > Fix the tests for install(1): add support for STRIPBIN's -o option. >>> Is this feature now completely gone? Are binaries being stripped >>> properly in ports, etc? > > Support for STRIPBIN has not changed. Stripping of ports etc. still works as > before, just more quick due to less I/O. Eugene, Got it! Thank you very much for the followup/additional information :). Cheers! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r363103 - head/usr.sbin/bsdinstall/scripts
> On Jul 11, 2020, at 10:20 AM, Allan Jude wrote: > > Author: allanjude > Date: Sat Jul 11 17:20:17 2020 > New Revision: 363103 > URL: https://svnweb.freebsd.org/changeset/base/363103 > > Log: > bsdinstall: only kill the dhclient for the interface we are restarting > > PR: 205821 > Reported by: mjg > MFC after: 2 weeks > Sponsored by:Klara Inc. > Event: July 2020 Bugathon > > Modified: > head/usr.sbin/bsdinstall/scripts/netconfig_ipv4 Allan, Thank you so very much for doing this!!! This has been an annoying nitpick of mine with sysinstall/bsdinstall, for many moons :). It looks like equivalent logic doesn’t need to be implemented for IPv6. Yay :). Cheers! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r363132 - head/tests/sys/audit
Author: ngie
Date: Sun Jul 12 17:16:57 2020
New Revision: 363132
URL: https://svnweb.freebsd.org/changeset/base/363132
Log:
Don't leave `path` behind when executing `:chflags_success`
Prior to this change a `SF_IMMUTABLE` chflagsat(2)'ed file (`path`) was left
behind, which sabotaged kyua(1) from being able to clean up the work
directory,
This resulted in unnecessary work for folks having to clean up the work
directory on non-disposable systems, which defaults to `/tmp`. Use
`UF_OFFLINE`
instead of `SF_IMMUTABLE`, in part because setting `SF_IMMUTABLE` isn't
relevant
to the test and `SF_IMMUTABLE` cannot be cleared at all securelevels, as
pointed
out by @asomers.
Additional work is required to catch cases like this upfront in the future to
avoid tester headache. See PR # 247765 for more details/followup.
Suggested by: asomers
Reviewed By: asomers, #tests
MFC after:1 week
PR: 247761
Sponsored by: DellEMC
Differential Revision: https://reviews.freebsd.org/D25561
Modified:
head/tests/sys/audit/file-attribute-modify.c
Modified: head/tests/sys/audit/file-attribute-modify.c
==
--- head/tests/sys/audit/file-attribute-modify.cSun Jul 12 15:57:29
2020(r363131)
+++ head/tests/sys/audit/file-attribute-modify.cSun Jul 12 17:16:57
2020(r363132)
@@ -704,7 +704,7 @@ ATF_TC_BODY(chflagsat_success, tc)
/* File needs to exist to call chflagsat(2) */
ATF_REQUIRE((filedesc = open(path, O_CREAT, mode)) != -1);
FILE *pipefd = setup(fds, auclass);
- ATF_REQUIRE_EQ(0, chflagsat(AT_FDCWD, path, SF_IMMUTABLE, 0));
+ ATF_REQUIRE_EQ(0, chflagsat(AT_FDCWD, path, UF_OFFLINE, 0));
check_audit(fds, successreg, pipefd);
close(filedesc);
}
@@ -726,7 +726,7 @@ ATF_TC_BODY(chflagsat_failure, tc)
{
FILE *pipefd = setup(fds, auclass);
/* Failure reason: file does not exist */
- ATF_REQUIRE_EQ(-1, chflagsat(AT_FDCWD, errpath, SF_IMMUTABLE, 0));
+ ATF_REQUIRE_EQ(-1, chflagsat(AT_FDCWD, errpath, UF_OFFLINE, 0));
check_audit(fds, failurereg, pipefd);
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r363088 - head/usr.bin/xinstall/tests
> On Jul 10, 2020, at 3:59 PM, Eugene Grosbein wrote: > > Author: eugen > Date: Fri Jul 10 22:59:26 2020 > New Revision: 363088 > URL: https://svnweb.freebsd.org/changeset/base/363088 > > Log: > Fix the tests for install(1): add support for STRIPBIN's -o option. Is this feature now completely gone? Are binaries being stripped properly in ports, etc? Thanks, -Enji >From install(1) on a host running r362553: ENVIRONMENT The install utility checks for the presence of the STRIPBIN environment variable and if present, uses the assigned value as the program to run if and when the -s option has been specified. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r362667 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace
> On Jun 26, 2020, at 6:02 PM, Alexey Dokuchaev wrote: > > On Sat, Jun 27, 2020 at 12:57:48AM +, Matt Macy wrote: >> New Revision: 362667 >> URL: https://svnweb.freebsd.org/changeset/base/362667 >> >> Log: >> Fix "current" variable name conflict with openzfs >> >> The variable "current" is an alias for curthread >> in openzfs. Rename all variable uses of current >> in dtrace.c to curstate. > > Shouldn't OpenZFS be fixed instead? The fact that we need to fix our > local variables suggests that they're abusing too generic name… I kind of agree with `current` being a bit too genericly named in both DTrace and OpenZFS :/.. Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r362591 - head/sys/kern
Author: ngie Date: Wed Jun 24 18:51:01 2020 New Revision: 362591 URL: https://svnweb.freebsd.org/changeset/base/362591 Log: Add `kern.features.witness` Adding `kern.features.witness` helps expose whether or not the kernel has `options WITNESS` enabled, so the `feature_present(3)` API can be used to query whether or not witness(9) is built into the kernel. This support is helpful with userspace applications (generally speaking, tests), as it can be queried to determine whether or not tests related to WITNESS should be run. MFC after:1 week Reviewed by: cem, darrick.freebsd_gmail.com Differential Revision: https://reviews.freebsd.org/D25302 Sponsored by: DellEMC Isilon Modified: head/sys/kern/subr_witness.c Modified: head/sys/kern/subr_witness.c == --- head/sys/kern/subr_witness.cWed Jun 24 18:40:43 2020 (r362590) +++ head/sys/kern/subr_witness.cWed Jun 24 18:51:01 2020 (r362591) @@ -361,6 +361,8 @@ static int witness_output(const char *fmt, ...) __prin static int witness_voutput(const char *fmt, va_list ap) __printflike(1, 0); static voidwitness_setflag(struct lock_object *lock, int flag, int set); +FEATURE(witness, "kernel has witness(9) support"); + static SYSCTL_NODE(_debug, OID_AUTO, witness, CTLFLAG_RW | CTLFLAG_MPSAFE, NULL, "Witness Locking"); ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock dev/hyperv/include dev/hyperv/vmbus modules/hyperv modules/hyperv/hvsock sys
> On May 20, 2020, at 08:54, Enji Cooper wrote: > >>> On May 20, 2020, at 08:11, Shawn Webb wrote: >>> >>> On Wed, May 20, 2020 at 11:03:59AM +, Wei Hu wrote: >>> Author: whu >>> Date: Wed May 20 11:03:59 2020 >>> New Revision: 361275 >>> URL: https://svnweb.freebsd.org/changeset/base/361275 >>> >>> Log: >>> HyperV socket implementation for FreeBSD >>> >>> This change adds Hyper-V socket feature in FreeBSD. New socket address >>> family AF_HYPERV and its kernel support are added. > > Hi Wei, >Could you please further describe what this feature is/does? I realize after looking at the review that it contains the content I was hoping for. It would have been helpful to folks if this context had been included in the commit message. Thank you, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r361275 - in head/sys: conf dev/hyperv/hvsock dev/hyperv/include dev/hyperv/vmbus modules/hyperv modules/hyperv/hvsock sys
> On May 20, 2020, at 08:11, Shawn Webb wrote: > > On Wed, May 20, 2020 at 11:03:59AM +, Wei Hu wrote: >> Author: whu >> Date: Wed May 20 11:03:59 2020 >> New Revision: 361275 >> URL: https://svnweb.freebsd.org/changeset/base/361275 >> >> Log: >> HyperV socket implementation for FreeBSD >> >> This change adds Hyper-V socket feature in FreeBSD. New socket address >> family AF_HYPERV and its kernel support are added. Hi Wei, Could you please further describe what this feature is/does? Thanks, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r360905 - in head/tests/sys/netpfil: common pf
> On May 11, 2020, at 12:07 PM, Mark Johnston wrote: > > Author: markj > Date: Mon May 11 19:07:33 2020 > New Revision: 360905 > URL: https://svnweb.freebsd.org/changeset/base/360905 > > Log: > Remove the svn:executable property from some pf test files. > > The test makefiles will handle setting mode bits during install. Also, > Phabricator gets upset when uploading an executable plain-text file > without a shebang. Awesome — thanks for doing this! Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r360019 - head/tests/sys/kern
> On Apr 20, 2020, at 10:10 AM, Jonathan T. Looney wrote: > > On Sun, Apr 19, 2020 at 5:03 PM Enji Cooper <mailto:yaneurab...@gmail.com>> wrote: > > > On Apr 16, 2020, at 1:07 PM, Jonathan T. Looney wrote: > > > > Author: jtl > > Date: Thu Apr 16 20:07:34 2020 > > New Revision: 360019 > > URL: https://svnweb.freebsd.org/changeset/base/360019 > > <https://svnweb.freebsd.org/changeset/base/360019> > > > > Log: > > Add a regression test for the changes in r359922 and r359923. > > > > Note that the Python code has been tested on both Python 2.7 and 3.7. > > > > Reviewed by: olivier > > MFC after: 2 weeks > > Sponsored by:Netflix, Inc. > > Ugh… I can tell by this commit that I just need to add pytest support > to kyua >_>… > > I assume you're suggesting that we support running Python code natively, > instead of from a shell script. If so, I think that's a great idea. > > It looks like we're growing a number of Python scripts in the test suite, and > supporting them more natively is probably good for more than one reason. That was exactly my thinking. The reason why I picked pytest is that nose 1.x is abandoned, nose 2.x converges with pytest (and the page recommends pytest), and raw unittest requires a lot of complexity. Another plus of pytest is that it has an extensible plugin framework. It’s really unfortunate that we don’t have better package integration in buildworld. It would make building and installing tests a lot easier. Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r360019 - head/tests/sys/kern
> On Apr 16, 2020, at 1:07 PM, Jonathan T. Looney wrote: > > Author: jtl > Date: Thu Apr 16 20:07:34 2020 > New Revision: 360019 > URL: https://svnweb.freebsd.org/changeset/base/360019 > > Log: > Add a regression test for the changes in r359922 and r359923. > > Note that the Python code has been tested on both Python 2.7 and 3.7. > > Reviewed by: olivier > MFC after: 2 weeks > Sponsored by:Netflix, Inc. Ugh… I can tell by this commit that I just need to add pytest support to kyua >_>… Thanks, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r360102 - in head: libexec/rc/rc.d share/mk tools/build/mk
> On Apr 19, 2020, at 10:01 AM, Cy Schubert wrote: > > Author: cy > Date: Sun Apr 19 17:01:21 2020 > New Revision: 360102 > URL: https://svnweb.freebsd.org/changeset/base/360102 > > Log: > Conditionally install Kerberos rc files based on MK_KERBEROS_SCRIPTS > instead of MK_KERBEROS. The reason for this change is some users > prefer to build FreeBSD WITHOUT_KERBEROS, wanting to retain the > Kerberos rc scripts to start/stop MIT Kerberos or Heimdal from ports. > > PR: 197337 > Reported by: Adam McDougall > Reviewed by: imp > Differential Revision: https://reviews.freebsd.org/D24252 Hi Cy, Having excised code like this in the past, I don’t think this is the right approach: a separate slave port should be added that handles the rc.d script installation, etc, or the scripts should be added to the manifest for the ports. Thanks, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r359734 - vendor/google/googletest/dist/googletest/src
Author: ngie
Date: Thu Apr 9 02:00:59 2020
New Revision: 359734
URL: https://svnweb.freebsd.org/changeset/base/359734
Log:
Backport a -Wsign-compare fix for `ArrayAsVector`
This fixes the build with newer versions of gcc.
Obtained from:
[google/googletest#2723](https://github.com/google/googletest/pull/2723)
Submitted-by: [Johan Mabille](https://github.com/JohanMabille)
Modified:
vendor/google/googletest/dist/googletest/src/gtest.cc
Modified: vendor/google/googletest/dist/googletest/src/gtest.cc
==
--- vendor/google/googletest/dist/googletest/src/gtest.cc Thu Apr 9
01:56:21 2020(r359733)
+++ vendor/google/googletest/dist/googletest/src/gtest.cc Thu Apr 9
02:00:59 2020(r359734)
@@ -2108,7 +2108,7 @@ static const char* const kReservedOutputTestCaseAttrib
"classname", "name", "status", "time", "type_param",
"value_param", "file", "line", "result", "timestamp"};
-template
+template
std::vector ArrayAsVector(const char* const ()[kSize]) {
return std::vector(array, array + kSize);
}
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r359733 - vendor/google/googletest/1.10.0
Author: ngie Date: Thu Apr 9 01:56:21 2020 New Revision: 359733 URL: https://svnweb.freebsd.org/changeset/base/359733 Log: Copy ^/vendor/google/googletest/dist to ^/vendor/google/googletest/1.10.0 Added: vendor/google/googletest/1.10.0/ - copied from r359732, vendor/google/googletest/dist/ ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r359732 - in vendor/google/googletest/dist: . ci googlemock googlemock/build-aux googlemock/cmake googlemock/docs googlemock/include/gmock googlemock/include/gmock/internal googlemock/m...
Author: ngie Date: Thu Apr 9 01:55:35 2020 New Revision: 359732 URL: https://svnweb.freebsd.org/changeset/base/359732 Log: Import GoogleTest 1.10.0 GoogleTest 1.10.0 is the last official release series planned for GoogleTest. After 1.10.x, Google is switching GoogleTest to a "release on master" model, as documented here: https://abseil.io/about/philosophy . More information about what's captured between releases can be found on the GitHub release page: https://github.com/google/googletest/releases . Added: vendor/google/googletest/dist/.clang-format vendor/google/googletest/dist/ci/build-platformio.sh (contents, props changed) vendor/google/googletest/dist/ci/install-platformio.sh (contents, props changed) vendor/google/googletest/dist/googlemock/docs/cheat_sheet.md vendor/google/googletest/dist/googlemock/docs/cook_book.md vendor/google/googletest/dist/googlemock/docs/for_dummies.md vendor/google/googletest/dist/googlemock/docs/gmock_faq.md vendor/google/googletest/dist/googlemock/include/gmock/gmock-function-mocker.h (contents, props changed) vendor/google/googletest/dist/googlemock/include/gmock/gmock-nice-strict.h (contents, props changed) vendor/google/googletest/dist/googlemock/include/gmock/internal/gmock-pp.h (contents, props changed) vendor/google/googletest/dist/googlemock/test/gmock-function-mocker_nc.cc (contents, props changed) vendor/google/googletest/dist/googlemock/test/gmock-function-mocker_nc_test.py (contents, props changed) vendor/google/googletest/dist/googlemock/test/gmock-function-mocker_test.cc (contents, props changed) vendor/google/googletest/dist/googlemock/test/gmock-pp-string_test.cc (contents, props changed) vendor/google/googletest/dist/googlemock/test/gmock-pp_test.cc (contents, props changed) vendor/google/googletest/dist/googletest/cmake/libgtest.la.in (contents, props changed) vendor/google/googletest/dist/googletest/docs/pkgconfig.md vendor/google/googletest/dist/googletest/docs/pump_manual.md vendor/google/googletest/dist/googletest/include/gtest/gtest-matchers.h (contents, props changed) vendor/google/googletest/dist/googletest/src/gtest-matchers.cc (contents, props changed) vendor/google/googletest/dist/googletest/test/gtest_skip_environment_check_output_test.py (contents, props changed) vendor/google/googletest/dist/googletest/test/gtest_skip_in_environment_setup_test.cc (contents, props changed) vendor/google/googletest/dist/googletest/test/gtest_skip_test.cc (contents, props changed) vendor/google/googletest/dist/library.json vendor/google/googletest/dist/platformio.ini Deleted: vendor/google/googletest/dist/ci/build-linux-autotools.sh vendor/google/googletest/dist/googlemock/CHANGES vendor/google/googletest/dist/googlemock/Makefile.am vendor/google/googletest/dist/googlemock/build-aux/ vendor/google/googletest/dist/googlemock/configure.ac vendor/google/googletest/dist/googlemock/docs/CheatSheet.md vendor/google/googletest/dist/googlemock/docs/CookBook.md vendor/google/googletest/dist/googlemock/docs/DesignDoc.md vendor/google/googletest/dist/googlemock/docs/Documentation.md vendor/google/googletest/dist/googlemock/docs/ForDummies.md vendor/google/googletest/dist/googlemock/docs/FrequentlyAskedQuestions.md vendor/google/googletest/dist/googlemock/docs/KnownIssues.md vendor/google/googletest/dist/googlemock/include/gmock/gmock-generated-nice-strict.h vendor/google/googletest/dist/googlemock/include/gmock/gmock-generated-nice-strict.h.pump vendor/google/googletest/dist/googlemock/include/gmock/internal/gmock-generated-internal-utils.h vendor/google/googletest/dist/googlemock/include/gmock/internal/gmock-generated-internal-utils.h.pump vendor/google/googletest/dist/googlemock/make/ vendor/google/googletest/dist/googlemock/msvc/ vendor/google/googletest/dist/googlemock/test/gmock-generated-internal-utils_test.cc vendor/google/googletest/dist/googletest/CHANGES vendor/google/googletest/dist/googletest/Makefile.am vendor/google/googletest/dist/googletest/codegear/ vendor/google/googletest/dist/googletest/configure.ac vendor/google/googletest/dist/googletest/docs/Pkgconfig.md vendor/google/googletest/dist/googletest/docs/PumpManual.md vendor/google/googletest/dist/googletest/docs/XcodeGuide.md vendor/google/googletest/dist/googletest/include/gtest/gtest-param-test.h.pump vendor/google/googletest/dist/googletest/include/gtest/internal/gtest-linked_ptr.h vendor/google/googletest/dist/googletest/include/gtest/internal/gtest-param-util-generated.h vendor/google/googletest/dist/googletest/include/gtest/internal/gtest-param-util-generated.h.pump vendor/google/googletest/dist/googletest/include/gtest/internal/gtest-tuple.h vendor/google/googletest/dist/googletest/include/gtest/internal/gtest-tuple.h.pump vendor/google/googletest/dist/googletest/m4/
Re: svn commit: r359689 - head/usr.sbin/config
> On Apr 7, 2020, at 7:14 AM, Kyle Evans wrote: > > Author: kevans > Date: Tue Apr 7 14:14:59 2020 > New Revision: 359689 > URL: https://svnweb.freebsd.org/changeset/base/359689 > > Log: > config(8): "fix" a couple of buffer overflows > > Recently added/changed lines in various kernel configs have caused some > buffer overflows that went undetected. These were detected with a config > built using -fno-common as these line buffers smashed one of our arrays, > then further triaged with ASAN. > > Double the sizes; this is really not a great fix, but addresses the > immediate need until someone rewrites config. While here, add some bounds > checking so that we don't need to detect this by random bus errors or other > weird failures. Good catch! This seems like it deserves a follow up PR in Bugzilla. Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r359514 - head/tools/test/bsnmp
> On Apr 1, 2020, at 08:56, Hartmut Brandt wrote: > > Author: harti > Date: Wed Apr 1 15:39:02 2020 > New Revision: 359514 > URL: https://svnweb.freebsd.org/changeset/base/359514 > > Log: > Add a makefile to build and run the tests for the bsnmp library. > This is not automatically built or run but must explicitly be built > with 'make' and run with 'make run'. Why was this integrated this way? -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r359385 - head/usr.bin/kyua
> On Mar 27, 2020, at 8:22 PM, Brooks Davis wrote: > > On Sat, Mar 28, 2020 at 01:08:20AM +0000, Enji Cooper wrote: >> Author: ngie >> Date: Sat Mar 28 01:08:20 2020 >> New Revision: 359385 >> URL: https://svnweb.freebsd.org/changeset/base/359385 >> >> Log: >> Check in the generated copies of the manpages >> >> These manpages were meant to be templated once per `configure` run. >> >> Given that we're not bound by as many constants, e.g., `--prefix` isn't >> generally changing for kyua in the base system, having to generate the >> manpages each build seems slightly less than optimal. >> >> In the event that one's build environment doesn't define `$SH`, the build >> will also fail until this change is introduced. >> >> Instead of jumping through hoops dealing with shells or permissions, let's >> just cut to the chase and check the generated copies into the sourcebase >> under usr.bin/kyua . > > This was the wrong fix. Committing generated manpaged was > 100% the wrong solution and will make extra work in the > future. The correct fix is almost certainly the one attached to > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086 > <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086>. If someone > doesn't beat me to it I will revert you wrong and broken commit along > with the followups and commit the correct one (this certainly won't be > until at least tomorrow). I’ll revert my changes. -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r359385 - head/usr.bin/kyua
> On Mar 28, 2020, at 7:37 PM, Enji Cooper wrote: > >> >> On Mar 27, 2020, at 8:22 PM, Brooks Davis > <mailto:bro...@freebsd.org>> wrote: >> >> On Sat, Mar 28, 2020 at 01:08:20AM +, Enji Cooper wrote: >>> Author: ngie >>> Date: Sat Mar 28 01:08:20 2020 >>> New Revision: 359385 >>> URL: https://svnweb.freebsd.org/changeset/base/359385 >>> <https://svnweb.freebsd.org/changeset/base/359385> >>> >>> Log: >>> Check in the generated copies of the manpages >>> >>> These manpages were meant to be templated once per `configure` run. >>> >>> Given that we're not bound by as many constants, e.g., `--prefix` isn't >>> generally changing for kyua in the base system, having to generate the >>> manpages each build seems slightly less than optimal. >>> >>> In the event that one's build environment doesn't define `$SH`, the build >>> will also fail until this change is introduced. >>> >>> Instead of jumping through hoops dealing with shells or permissions, let's >>> just cut to the chase and check the generated copies into the sourcebase >>> under usr.bin/kyua . >> >> This was the wrong fix. Committing generated manpaged was >> 100% the wrong solution and will make extra work in the >> future. The correct fix is almost certainly the one attached to >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086 >> <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=245086>. If someone >> doesn't beat me to it I will revert you wrong and broken commit along >> with the followups and commit the correct one (this certainly won't be >> until at least tomorrow). > > I’ll revert my changes. Done in r359417. Thank you, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r359417 - in head: contrib/kyua/doc usr.bin/kyua
Author: ngie
Date: Sun Mar 29 02:40:03 2020
New Revision: 359417
URL: https://svnweb.freebsd.org/changeset/base/359417
Log:
Revert r359385-r359387
As noted by brooks/emaste, this is the wrong approach to take.
Revert the changes so brooks can apply a more proper change.
Requested by: brooks, emaste
Deleted:
head/contrib/kyua/doc/kyua-about.1
head/contrib/kyua/doc/kyua-config.1
head/contrib/kyua/doc/kyua-db-exec.1
head/contrib/kyua/doc/kyua-db-migrate.1
head/contrib/kyua/doc/kyua-debug.1
head/contrib/kyua/doc/kyua-help.1
head/contrib/kyua/doc/kyua-list.1
head/contrib/kyua/doc/kyua-report-html.1
head/contrib/kyua/doc/kyua-report-junit.1
head/contrib/kyua/doc/kyua-report.1
head/contrib/kyua/doc/kyua-test.1
head/contrib/kyua/doc/kyua.1
head/contrib/kyua/doc/kyua.conf.5
head/contrib/kyua/doc/kyuafile.5
Modified:
head/usr.bin/kyua/Makefile
Modified: head/usr.bin/kyua/Makefile
==
--- head/usr.bin/kyua/Makefile Sun Mar 29 02:30:23 2020(r359416)
+++ head/usr.bin/kyua/Makefile Sun Mar 29 02:40:03 2020(r359417)
@@ -48,6 +48,20 @@ STORE= migrate_v1_v2.sql migrate_v2_v3.sql
schema_v3.
STOREDIR= ${KYUA_STOREDIR}
.PATH: ${KYUA_SRCDIR}/store
+CLEANFILES+= ${MAN}
.PATH: ${KYUA_SRCDIR}/doc
+.for man in ${MAN}
+${man}: ${man}.in
+ ${SH} ${KYUA_SRCDIR}/doc/manbuild.sh \
+ -v "CONFDIR=${KYUA_CONFDIR}" \
+ -v "DOCDIR=${KYUA_DOCDIR}" \
+ -v "EGDIR=${KYUA_EGDIR}" \
+ -v "MISCDIR=${KYUA_MISCDIR}" \
+ -v "PACKAGE=kyua" \
+ -v "STOREDIR=${KYUA_STOREDIR}" \
+ -v "TESTSDIR=${TESTSBASE}" \
+ -v "VERSION=${KYUA_VERSION}" \
+ ${.ALLSRC} ${.TARGET}
+.endfor
.include
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r359386 - head/contrib/kyua/doc
Author: ngie Date: Sat Mar 28 01:14:37 2020 New Revision: 359386 URL: https://svnweb.freebsd.org/changeset/base/359386 Log: Follow up to r359385 Actually add the generated manpages to unbreak the build. MFC with: r359385 Added: head/contrib/kyua/doc/kyua-about.1 (contents, props changed) head/contrib/kyua/doc/kyua-config.1 (contents, props changed) head/contrib/kyua/doc/kyua-db-exec.1 (contents, props changed) head/contrib/kyua/doc/kyua-db-migrate.1 (contents, props changed) head/contrib/kyua/doc/kyua-debug.1 (contents, props changed) head/contrib/kyua/doc/kyua-help.1 (contents, props changed) head/contrib/kyua/doc/kyua-list.1 (contents, props changed) head/contrib/kyua/doc/kyua-report-html.1 (contents, props changed) head/contrib/kyua/doc/kyua-report-junit.1 (contents, props changed) head/contrib/kyua/doc/kyua-report.1 (contents, props changed) head/contrib/kyua/doc/kyua-test.1 (contents, props changed) head/contrib/kyua/doc/kyua.1 (contents, props changed) head/contrib/kyua/doc/kyua.conf.5 (contents, props changed) head/contrib/kyua/doc/kyuafile.5 (contents, props changed) Added: head/contrib/kyua/doc/kyua-about.1 == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/contrib/kyua/doc/kyua-about.1 Sat Mar 28 01:14:37 2020 (r359386) @@ -0,0 +1,95 @@ +.\" Copyright 2012 The Kyua Authors. +.\" All rights reserved. +.\" +.\" Redistribution and use in source and binary forms, with or without +.\" modification, are permitted provided that the following conditions are +.\" met: +.\" +.\" * Redistributions of source code must retain the above copyright +.\" notice, this list of conditions and the following disclaimer. +.\" * Redistributions in binary form must reproduce the above copyright +.\" notice, this list of conditions and the following disclaimer in the +.\" documentation and/or other materials provided with the distribution. +.\" * Neither the name of Google Inc. nor the names of its contributors +.\" may be used to endorse or promote products derived from this software +.\" without specific prior written permission. +.\" +.\" THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +.\" "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +.\" LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +.\" A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +.\" OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +.\" SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +.\" LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +.\" DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +.\" THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +.\" (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +.\" OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +.Dd May 20, 2015 +.Dt KYUA-ABOUT 1 +.Os +.Sh NAME +.Nm "kyua about" +.Nd Shows detailed authors, license, and version information +.Sh SYNOPSIS +.Nm +.Op Ar authors | license | version +.Sh DESCRIPTION +The +.Sq about +command provides generic information about the +.Xr kyua 1 +tool. +In the default synopsis form (no arguments), the information printed +includes: +.Bl -enum +.It +The name of the package, which is +.Sq kyua . +.It +The version number, which is +.Sq 0.13 . +.It +License information. +.It +Authors information. +.It +A link to the project web site. +.El +.Pp +You can customize the information printed by this command by specifying +the desired topic as the single argument to the command. +This can be one of: +.Bl -tag -width authorsXX +.It Ar authors +Displays the list of authors and contributors only. +.It Ar license +Displays the license information and the list of copyrights. +.It Ar version +Displays the package name and the version number in a format that is +compatible with the output of GNU tools that support a +.Fl -version +flag. +Use this whenever you have to query the version number of the package. +.El +.Sh FILES +The following files are read by the +.Nm +command: +.Bl -tag -width XX +.It Pa /usr/share/doc/kyua/AUTHORS +List of authors (aka copyright holders). +.It Pa /usr/share/doc/kyua/CONTRIBUTORS +List of contributors (aka individuals that have contributed to the project). +.It Pa /usr/share/doc/kyua/LICENSE +License information. +.El +.Sh EXIT STATUS +The +.Nm +command always returns 0. +.Pp +Additional exit codes may be returned as described in +.Xr kyua 1 . +.Sh SEE ALSO +.Xr kyua 1 Added: head/contrib/kyua/doc/kyua-config.1 == --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/contrib/kyua/doc/kyua-config.1 Sat Mar 28 01:14:37 2020 (r359386) @@ -0,0 +1,59
Re: svn commit: r359385 - head/usr.bin/kyua
> On Mar 27, 2020, at 6:33 PM, Ed Maste wrote: > > On Fri, 27 Mar 2020 at 21:09, Enji Cooper wrote: >> >> Author: ngie >> Date: Sat Mar 28 01:08:20 2020 >> New Revision: 359385 >> URL: https://svnweb.freebsd.org/changeset/base/359385 >> >> Log: >> Check in the generated copies of the manpages > > I think this is the wrong change for the issue reported by Julian H > Stacey, although I don't think having generated manpages committed to > the tree matters too much in practice. > >> In the event that one's build environment doesn't define `$SH`, the build >> will also fail until this change is introduced. > > This isn't the case - the reported failure occurred because the > manbuild.sh script did not have +x set. My local builds and CI builds > were fine, without having SH defined. I understand, but I’d rather not rely on a script’s mode, though. This is how build failures happen when the source tree is checked out somewhere with -o noexec. Thanks, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r359387 - head/usr.bin/kyua
Author: ngie
Date: Sat Mar 28 01:16:06 2020
New Revision: 359387
URL: https://svnweb.freebsd.org/changeset/base/359387
Log:
The .PATH throbbing I added in r359385 is no longer required
MFC with: r359385
Modified:
head/usr.bin/kyua/Makefile
Modified: head/usr.bin/kyua/Makefile
==
--- head/usr.bin/kyua/Makefile Sat Mar 28 01:14:37 2020(r359386)
+++ head/usr.bin/kyua/Makefile Sat Mar 28 01:16:06 2020(r359387)
@@ -2,7 +2,7 @@
.include "${SRCTOP}/lib/kyua/Makefile.kyua"
-.PATH: ${.CURDIR} ${.OBJDIR} ${KYUA_SRCDIR}
+.PATH: ${KYUA_SRCDIR}
PROG_CXX= kyua
SRCS= main.cpp
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r359385 - head/usr.bin/kyua
Author: ngie
Date: Sat Mar 28 01:08:20 2020
New Revision: 359385
URL: https://svnweb.freebsd.org/changeset/base/359385
Log:
Check in the generated copies of the manpages
These manpages were meant to be templated once per `configure` run.
Given that we're not bound by as many constants, e.g., `--prefix` isn't
generally changing for kyua in the base system, having to generate the
manpages each build seems slightly less than optimal.
In the event that one's build environment doesn't define `$SH`, the build
will also fail until this change is introduced.
Instead of jumping through hoops dealing with shells or permissions, let's
just cut to the chase and check the generated copies into the sourcebase
under usr.bin/kyua .
MFC with: r359260
Reported by: Julian Stacey
Modified:
head/usr.bin/kyua/Makefile
Modified: head/usr.bin/kyua/Makefile
==
--- head/usr.bin/kyua/Makefile Sat Mar 28 00:41:47 2020(r359384)
+++ head/usr.bin/kyua/Makefile Sat Mar 28 01:08:20 2020(r359385)
@@ -2,7 +2,7 @@
.include "${SRCTOP}/lib/kyua/Makefile.kyua"
-.PATH: ${KYUA_SRCDIR}
+.PATH: ${.CURDIR} ${.OBJDIR} ${KYUA_SRCDIR}
PROG_CXX= kyua
SRCS= main.cpp
@@ -48,20 +48,6 @@ STORE= migrate_v1_v2.sql migrate_v2_v3.sql
schema_v3.
STOREDIR= ${KYUA_STOREDIR}
.PATH: ${KYUA_SRCDIR}/store
-CLEANFILES+= ${MAN}
.PATH: ${KYUA_SRCDIR}/doc
-.for man in ${MAN}
-${man}: ${man}.in
- ${SH} ${KYUA_SRCDIR}/doc/manbuild.sh \
- -v "CONFDIR=${KYUA_CONFDIR}" \
- -v "DOCDIR=${KYUA_DOCDIR}" \
- -v "EGDIR=${KYUA_EGDIR}" \
- -v "MISCDIR=${KYUA_MISCDIR}" \
- -v "PACKAGE=kyua" \
- -v "STOREDIR=${KYUA_STOREDIR}" \
- -v "TESTSDIR=${TESTSBASE}" \
- -v "VERSION=${KYUA_VERSION}" \
- ${.ALLSRC} ${.TARGET}
-.endfor
.include
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r359168 - head
> On Mar 24, 2020, at 3:57 PM, Scott Long wrote: > > On Tue, Mar 24, 2020, at 3:45 PM, Gleb Smirnoff wrote: >> On Fri, Mar 20, 2020 at 04:02:46PM +, Ed Maste wrote: >> E> Author: emaste >> E> Date: Fri Mar 20 16:02:45 2020 >> E> New Revision: 359168 >> E> URL: https://svnweb.freebsd.org/changeset/base/359168 >> E> >> E> Log: >> E> remove ancient pre-2000 ObsoleteFiles.inc entries >> E> >> E> We support 10.3 as the minimum version to install from, which was >> E> released in the mid-2010s. There's a lot of ancient ObsoleteFiles.inc >> E> history that serves no purpose today; start by removing entries from >> E> 1999 and earlier. >> >> I understand that rationale is to speedup 'make delete-old' times, and >> trimming the default file definitely makes sense. However, what about >> keeping the full ObsoleteFiles.inc version, at least for documenting >> purposes? >> > > This is what SCM history is for, IMHO. The historical entries serve little > purpose outside of that. Moreover, splitting them up into separate files will make merges more difficult than they need to be/already are. Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r358912 - head/tools/build/mk
Author: ngie Date: Thu Mar 12 16:06:26 2020 New Revision: 358912 URL: https://svnweb.freebsd.org/changeset/base/358912 Log: Remove /usr/share/snmp/defs/tc.def with delete-old if MK_BSNMP == no This removes a lingering file on new installs of CURRENT, originally added in r345797. MFC after:1 week MFC with: r345797 Modified: head/tools/build/mk/OptionalObsoleteFiles.inc Modified: head/tools/build/mk/OptionalObsoleteFiles.inc == --- head/tools/build/mk/OptionalObsoleteFiles.inc Thu Mar 12 15:37:41 2020(r358911) +++ head/tools/build/mk/OptionalObsoleteFiles.inc Thu Mar 12 16:06:26 2020(r358912) @@ -972,6 +972,7 @@ OLD_FILES+=usr/share/snmp/defs/mibII_tree.def OLD_FILES+=usr/share/snmp/defs/netgraph_tree.def OLD_FILES+=usr/share/snmp/defs/pf_tree.def OLD_FILES+=usr/share/snmp/defs/target_tree.def +OLD_FILES+=usr/share/snmp/defs/tc.def OLD_FILES+=usr/share/snmp/defs/tree.def OLD_FILES+=usr/share/snmp/defs/usm_tree.def OLD_FILES+=usr/share/snmp/defs/vacm_tree.def ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r357833 - head/tests/sys/pjdfstest/tests
> On Feb 12, 2020, at 14:01, Ed Maste wrote: > > On Wed, 12 Feb 2020 at 15:34, Enji Cooper <mailto:yaneurab...@gmail.com>> wrote: >> >> On Wed, Feb 12, 2020 at 9:37 AM Ed Maste wrote: >>> >>> Author: emaste >>> Date: Wed Feb 12 17:37:32 2020 >>> New Revision: 357833 >>> URL: https://svnweb.freebsd.org/changeset/base/357833 >>> >>> Log: >>> Tag pjdfstest symlink with pkgbase package >>> >>> As with the rest of pjdfstest, tag the symlink with package=tests. >>> The tests -> . symlink seems a little strange but that's independent >>> of pkgbase. >> >> Sidenote: the reason for the symlink was to facilitate integrating the >> test suite without having to completely refactor the code. > > Thanks for the note - this probably ought to be a comment by the > symlink; I'll add it at some point if you don't get to it first. I’ll do that in a bit. I need to dust off the cobwebs with my src bit anyhow, lest the reaper reap it :). -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r357967 - head/sbin/ping6
> On Feb 15, 2020, at 07:39, Alexander V. Chernikov
> wrote:
>
> Author: melifaro
> Date: Sat Feb 15 15:39:53 2020
> New Revision: 357967
> URL: https://svnweb.freebsd.org/changeset/base/357967
>
> Log:
> Make ping6(1) return code consistent with the man page.
> When every sendto() call originated by ping6(1) fails, current code always
> returns 2 ("transmission was successful but no responses were received")
> which is incorrect. Return EX_OSERR instead as in many cases it indicates
> some kernel-level problems.
>
> MFC after: 3 weeks
Could you please add this to RELNOTES?
Thanks!
-Enji
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r357833 - head/tests/sys/pjdfstest/tests
On Wed, Feb 12, 2020 at 9:37 AM Ed Maste wrote: > > Author: emaste > Date: Wed Feb 12 17:37:32 2020 > New Revision: 357833 > URL: https://svnweb.freebsd.org/changeset/base/357833 > > Log: > Tag pjdfstest symlink with pkgbase package > > As with the rest of pjdfstest, tag the symlink with package=tests. > The tests -> . symlink seems a little strange but that's independent > of pkgbase. Sidenote: the reason for the symlink was to facilitate integrating the test suite without having to completely refactor the code. Thanks, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r357679 - head/sys/kern
> On Feb 8, 2020, at 07:51, Mateusz Guzik wrote: > > Author: mjg > Date: Sat Feb 8 15:51:08 2020 > New Revision: 357679 > URL: https://svnweb.freebsd.org/changeset/base/357679 > > Log: > vfs: remove now useless ENODEV handling from vn_fullpath consumers > > Noted by:ngie Thank you Mateusz :)! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r357384 - head/sys/kern
On Sat, Feb 1, 2020 at 12:36 PM Mateusz Guzik wrote: > > Author: mjg > Date: Sat Feb 1 20:36:35 2020 > New Revision: 357384 > URL: https://svnweb.freebsd.org/changeset/base/357384 > > Log: > cache: remove vnode -> path lookup disablement > > It seems to be of little to no use even when debugging. > > Interested parties can resurrect it and gate compilation with a macro. Hi Mateusz, This orphans some other things in the kernel that should potentially be removed as well: $ grep -r 'debug\.disablefullpath' ~/svn/freebsd/src/sys/ sys/kern/kern_jail.c: /* proceed if sysctl debug.disablefullpath == 1 */ sys/kern/vfs_mount.c: /* debug.disablefullpath == 1 results in ENODEV */ Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r356615 - head/share/mk
On Fri, Jan 10, 2020 at 2:00 PM Ed Maste wrote: > > Author: emaste > Date: Fri Jan 10 22:00:39 2020 > New Revision: 356615 > URL: https://svnweb.freebsd.org/changeset/base/356615 > > Log: > src.opts.mk: force KERBEROS_SUPPORT off where KERBEROS forced off > > Explicitly setting WITHOUT_KERBEROS implies WITHOUT_KERBEROS_SUPPORT, > but previously other cases that forced KERBEROS off (such as > WITHOUT_CRYPT) did not also set KERBEROS_SUPPORT off. Because the > _SUPPORT dependent options (KERBEROS/KERBEROS_SUPPORT) are processed > before other dependencies (CRYPT/KERBEROS) it's not easy to make this > happen automatically. Instead just explicitly set KERBEROS_SUPPORT > off where we set KERBEROS off. I don't think this is the right change to make, given that src.opts.mk ( https://svnweb.freebsd.org/base/head/share/mk/src.opts.mk?revision=356615=markup#l233 ) states: 233 # MK_*_SUPPORT options which default to "yes" unless their corresponding 234 # MK_* variable is set to "no". The right change to make would be to shift these special cases to the variable defined on line 227 ( https://svnweb.freebsd.org/base/head/share/mk/src.opts.mk?revision=356615=markup#l227 ): 225 # LEFT/RIGHT. Left options which default to "yes" unless their corresponding 226 # RIGHT option is disabled. 227 __DEFAULT_DEPENDENT_OPTIONS= \ 228 CLANG_FULL/CLANG \ 229 LOADER_VERIEXEC/BEARSSL \ 230 LOADER_EFI_SECUREBOOT/LOADER_VERIEXEC \ 231 VERIEXEC/BEARSSL \ If `MK_CRYPT == no`'s setting of `MK_KERBEROS:=no` was moved here, then the rest would just work by virtue of precedence. Thanks, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r356322 - head/share/mk
On Fri, Jan 3, 2020 at 10:12 AM Ed Maste wrote: > > Author: emaste > Date: Fri Jan 3 18:11:55 2020 > New Revision: 356322 > URL: https://svnweb.freebsd.org/changeset/base/356322 > > Log: > src.opts.mk: GOOGLETEST requires CXX > > Reported by: Build Options Survey run by Michael Dexter Thank you for doing this <3. FWIW, MK_TESTS:= no should have also covered this, but no real harm nor foul in making it explicit. -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r355818 - in head: share/man/man4 sys/amd64/linux sys/amd64/linux32 sys/arm64/linux sys/compat/linux sys/i386/linux
> On Dec 16, 2019, at 12:07, Edward Tomasz Napierala wrote: > > Author: trasz > Date: Mon Dec 16 20:07:04 2019 > New Revision: 355818 > URL: https://svnweb.freebsd.org/changeset/base/355818 > > Log: > Add compat.linux.emul_path, so it can be set to something other > than "/compat/linux". Useful when you have several compat directories > with different Linux versions and you don't want to clash with files > installed by linux-c7 packages. Hi Edward! Great feature :).. i was wondering if it made sense to implement this sysctl as a per-jail setting so one jail could have one setting and another have another setting? Arguably, one could just leave the default, but it’s a just thought I had when reading your commit message. Thank you :)! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r355407 - head/sys/fs/tmpfs
> On Dec 5, 2019, at 05:36, Konstantin Belousov wrote: ... >> Could you elaborate on the why/rationale? >> >> Is there memory wastage/duplication, bug(s), performance or >> development/maintenance benefit? > Each mount/unmount of tmpfs created and destroyed two zones, as it is > easy to see from the patch. Commit messages should provide helpful summaries of changes. Having to look at and understand the patch requires domain knowledge which the reader may or may not have. Kubilay’s request seems valid to me. -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm
> On Nov 30, 2019, at 11:01 AM, Warner Losh wrote: > > On Sat, Nov 30, 2019 at 11:58 AM Enji Cooper <mailto:yaneurab...@gmail.com>> wrote: > >> On Nov 30, 2019, at 10:03 AM, Warner Losh > <mailto:i...@bsdimp.com>> wrote: >> >> >> >> On Sat, Nov 30, 2019 at 10:47 AM Enji Cooper > <mailto:yaneurab...@gmail.com>> wrote: >> >> > On Nov 27, 2019, at 6:32 PM, Scott Long > > <mailto:sco...@freebsd.org>> wrote: >> > >> > Author: scottl >> > Date: Thu Nov 28 02:32:17 2019 >> > New Revision: 355164 >> > URL: https://svnweb.freebsd.org/changeset/base/355164 >> > <https://svnweb.freebsd.org/changeset/base/355164> >> > >> > Log: >> > Remove the trm(4) driver >> > >> > Differential Revision: https://reviews.freebsd.org/D22575 >> > <https://reviews.freebsd.org/D22575> >> >> Hi Scott, >> I believe this driver was removed because it was impacts the CAM >> GIANT lock removal effort — is that true (I’m asking because the “why” >> behind the removal is unclear)? >> >> Hi Enji, >> >> We're trying hard to get rid of all Giant-locked drivers in the tree, either >> by updating or removal. Since sym(4) provides a super-set of trm(4) and we >> have recent-ish reports of sym(4) working, it makes sense to trim this >> driver from the tree. The specific cards it supports aren't all that >> popular, the couple-extra features that trm(4) gave over sym(4) aren't >> really that relevant today, and it's been years since trm has had good >> testing and maintenance. > > Warner, > Thanks so very much for the info :). Glad to see this effort taking > place, since it’s very needed to modernize FreeBSD and improve concurrency in > the kernel, as well as reduce the overall maintenance burden. > > Giant isn't contending, but it's getting in the way of a cleanup of the > console / kbd system, as well as there being newbus issues in highly dynamic > systems. With TB and USB4 support on the horizon, we need to finally clean > that mess up.. I'll post a longer summary of what's left. I have a 'doodle' > tree that I'm separating out the Giant usage to 'driver lock', > kbd/console/ddb, newbus, sysctl, and WTF is that protecting... I'm tempted to > create wtf_lock() and wtf_unlock(), but I'm not sure how well that would go > over :) Sounds great :D… -Enji PS wtf_lock() would be amusing, but probably less of a good idea these days :D... ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm
> On Nov 30, 2019, at 10:03 AM, Warner Losh wrote: > > > > On Sat, Nov 30, 2019 at 10:47 AM Enji Cooper <mailto:yaneurab...@gmail.com>> wrote: > > > On Nov 27, 2019, at 6:32 PM, Scott Long wrote: > > > > Author: scottl > > Date: Thu Nov 28 02:32:17 2019 > > New Revision: 355164 > > URL: https://svnweb.freebsd.org/changeset/base/355164 > > <https://svnweb.freebsd.org/changeset/base/355164> > > > > Log: > > Remove the trm(4) driver > > > > Differential Revision: https://reviews.freebsd.org/D22575 > > <https://reviews.freebsd.org/D22575> > > Hi Scott, > I believe this driver was removed because it was impacts the CAM > GIANT lock removal effort — is that true (I’m asking because the “why” behind > the removal is unclear)? > > Hi Enji, > > We're trying hard to get rid of all Giant-locked drivers in the tree, either > by updating or removal. Since sym(4) provides a super-set of trm(4) and we > have recent-ish reports of sym(4) working, it makes sense to trim this driver > from the tree. The specific cards it supports aren't all that popular, the > couple-extra features that trm(4) gave over sym(4) aren't really that > relevant today, and it's been years since trm has had good testing and > maintenance. Warner, Thanks so very much for the info :). Glad to see this effort taking place, since it’s very needed to modernize FreeBSD and improve concurrency in the kernel, as well as reduce the overall maintenance burden. Keep up the good work :)! Cheers! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm
> On Nov 27, 2019, at 6:32 PM, Scott Long wrote: > > Author: scottl > Date: Thu Nov 28 02:32:17 2019 > New Revision: 355164 > URL: https://svnweb.freebsd.org/changeset/base/355164 > > Log: > Remove the trm(4) driver > > Differential Revision: https://reviews.freebsd.org/D22575 Hi Scott, I believe this driver was removed because it was impacts the CAM GIANT lock removal effort — is that true (I’m asking because the “why” behind the removal is unclear)? Thanks! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r354361 - head
Author: ngie Date: Tue Nov 5 17:33:27 2019 New Revision: 354361 URL: https://svnweb.freebsd.org/changeset/base/354361 Log: Remove picobsd(8) via `make delete-old` This completes the commit that removed picobsd(8) (r354346). MFC after:never Modified: head/ObsoleteFiles.inc Modified: head/ObsoleteFiles.inc == --- head/ObsoleteFiles.inc Tue Nov 5 15:19:05 2019(r354360) +++ head/ObsoleteFiles.inc Tue Nov 5 17:33:27 2019(r354361) @@ -38,6 +38,8 @@ # xargs -n1 | sort | uniq -d; # done +# 20191105: picobsd(8), et al, removed. +OLD_FILES+=usr/share/man/man8/picobsd.8.gz # 20191009: new clang import which bumps version from 8.0.1 to 9.0.0. OLD_FILES+=usr/lib/clang/8.0.1/include/sanitizer/allocator_interface.h OLD_FILES+=usr/lib/clang/8.0.1/include/sanitizer/asan_interface.h ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r353937 - in head/share: man/man5 mk
> On Oct 23, 2019, at 10:02, Dimitry Andric wrote: > > Author: dim > Date: Wed Oct 23 17:02:45 2019 > New Revision: 353937 > URL: https://svnweb.freebsd.org/changeset/base/353937 > > Log: > Build toolchain components as dynamically linked executables by default > > Summary: > Historically, we have built toolchain components such as cc, ld, etc as > statically linked executables. One of the reasons being that you could > sometimes save yourself from botched upgrades, by e.g. recompiling a > "known good" libc and reinstalling it. > > In this day and age, we have boot environments, virtual machine > snapshots, cloud backups, and other much more reliable methods to > restore systems to working order. So I think the time is ripe to flip > this default, and link the toolchain components dynamically, just like > almost all other executables on FreeBSD. > > Maybe at some point they can even become PIE executables by default! :) There might be a different reason for this being the case than the one posed. Using dynamic binaries instead of static binaries might actually regress performance in a way you don’t expect, depending on -j values, etc. Static binaries avoid the dynamic linker, which (obviously) results in a perf hit at scale, at the potential cost of the in-memory image. Static binaries could also better optimize away less optimal code paths, which could result in worse performing code. Did you calculate the perf trade offs for the static binaries at low -j vs high -j, system and user time, etc? Cheers, -Enji PS Thank you for keeping the SHARED_TOOLCHAIN option. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r353888 - head/sys/vm
> On Oct 22, 2019, at 08:59, Konstantin Belousov wrote: > > Author: kib > Date: Tue Oct 22 15:59:16 2019 > New Revision: 353888 > URL: https://svnweb.freebsd.org/changeset/base/353888 > > Log: > vm_fault(): extract code to lock the vnode into a helper > vn_fault_lock_vnode(). From an external perspective, I ask myself, “What is the purpose in extracting the code out?” The answer to this question is missing from the commit message. Thank you, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r353732 - head/sys/net
> On Oct 22, 2019, at 08:26, Gleb Smirnoff wrote: > > On Tue, Oct 22, 2019 at 07:53:31AM -0700, Enji Cooper wrote: > E> > Author: glebius > E> > Date: Fri Oct 18 15:20:24 2019 > E> > New Revision: 353732 > E> > URL: https://svnweb.freebsd.org/changeset/base/353732 > E> > > E> > Log: > E> > Make rt_getifa_fib() static. > E> > E> Why should it be made static? The answer to this question is missing from > the commit message. > > Because a function used only in a scope of a single file and not > intended to be used outside should be made static. Gleb, Yep :)! I appreciate your doing this because it limits scopes and calls, allowing compilers to optimize away unnecessary calls and external symbol linkage. My concern is coming back to the time old issue of providing sufficient context behind commits when making changes. Looking at the code change you made, I understand what you did... I just lack the context as to why the changes was made. This issue is true for the recent KPI rototilling related to interface property enumeration. If I hadn’t seen your mailing list RFC, I would lack all context as to why the changes are being made. Even a quick reference to a one page write up on the wiki, a proposal, or release notes would be wonderful moves towards documenting why interface changes are being made. I want to thank you so very much for all of the awesome work you have done and are continuing to do in the network space — I really appreciate it a lot! Again, I just wish the reasoning behind the work was made more apparent to onlookers as to why changes are being made. Cheers :)! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r353732 - head/sys/net
> On Oct 18, 2019, at 08:20, Gleb Smirnoff wrote: > > Author: glebius > Date: Fri Oct 18 15:20:24 2019 > New Revision: 353732 > URL: https://svnweb.freebsd.org/changeset/base/353732 > > Log: > Make rt_getifa_fib() static. Why should it be made static? The answer to this question is missing from the commit message. -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r353305 - head/tests/sys/kern
> On Oct 8, 2019, at 08:04, Konstantin Belousov wrote:
>
> On Tue, Oct 08, 2019 at 01:43:05PM +, Eric van Gyzen wrote:
>> Author: vangyzen
>> Date: Tue Oct 8 13:43:05 2019
>> New Revision: 353305
>> URL: https://svnweb.freebsd.org/changeset/base/353305
>>
>> Log:
>> Fix problems in the kern_maxfiles__increase test
>>
>> ATF functions such as ATF_REQUIRE do not work correctly in child processes.
>> Use plain C functions to report errors instead.
> There are much more tests that fork and use ATF_ in children.
> Look e.g. at most ptrace(2) tests.
I beg to disagree:
86 /*
87 * A variant of ATF_REQUIRE that is suitable for use in child
88 * processes. This only works if the parent process is tripped up by
89 * the early exit and fails some requirement itself.
90 */
91 #define CHILD_REQUIRE(exp) do { \
92 if (!(exp)) \
93 child_fail_require(__FILE__, __LINE__, \
94 #exp " not met"); \
95 } while (0)
The issue, in this particular case, and the item that evangyzen was fixing, was
the fact that failures in children can result in very confusing failures from a
parent level. In particular, ATF_CHECK does not trickle up to parents and
ATF_REQUIRE* gets thrown up to parents as abort()’ed processes.
The best way to handle this within the atf-c/atf-c++ framework (with less
boilerplate) is to use these APIs: atf_utils_fork(..)/atf_utils_wait(..). You
will still need to use `_exit` (instead of
exit(..)/assert(..)/ATF_CHECK(..)/ATF_REQUIRE(..), but it’s a lot less
boilerplate than writing it yourself.
Again, this is why I was driving towards GoogleTest. Despite the fact that it’s
a C++ framework, there’s a lot less confusing boilerplate involved and context,
since things are executed in relatively the same context, i.e., setup -> test
-> teardown, and they’re easier to follow.
The best way to move forward usability-wise with this (I think) is to probably
alias the ATF_* macros to something more sensible when forking processes.
However, given the amount of complaints I’ve heard about ATF, I think it’s best
not to build upon an unstable foundation, but instead encourage the use of
something more widely-accepted across the open source community/straightforward
use wise. In this case, googletest.
Thanks,
-Enji
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r352465 - head/share/mk
> On Sep 18, 2019, at 07:58, Kyle Evans wrote: > >> On Wed, Sep 18, 2019 at 9:46 AM Enji Cooper wrote: >> >> >>> On Sep 18, 2019, at 07:33, Enji Cooper wrote: >>> >>> >>>>> On Sep 18, 2019, at 05:40, Kyle Evans wrote: >>>>> >>>>> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: >>>>> >>>>> >>>>>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: >>>>>> >>>>>> Author: kevans >>>>>> Date: Wed Sep 18 01:58:56 2019 >>>>>> New Revision: 352465 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/352465 >>>>>> >>>>>> Log: >>>>>> googletest: default-disable on all of MIPS for now >>>>>> >>>>>> Parts of the fusefs tests trigger a bug in current versions of llvm: IR >>>>>> representation of some routine for the MIPS targets is a function with a >>>>>> large number of arguments. This then leads the compiler on an hour+ long >>>>>> goose chase, which is OK if you build the current tree but less-so if >>>>>> you're >>>>>> trying external toolchain or doing a universe build involving mips when >>>>>> it >>>>>> eventually gets switched over to LLVM. >>>>>> >>>>>> Better, accurate details can be found in LLVM PR43263. >>>>> >>>>> Uh... why not do this in tests/sys/... instead? >>>> >>>> Because there's still value in being able to easily enable these for >>>> building/running the complete set of tests through standard build >>>> infrastructure, but it's not worth adding a knob specifically for the >>>> fusefs tests. I also prefer the communication of it being an >>>> off-by-default option and easily deduced from src.conf(5) that this >>>> part of the build is default-disabled on mips/mips. >>> >>> Let me rephrase things a bit: is googlemock broken for all of mips, or is >>> it just the tests? If the latter, the tests should be blacklisted for mips >>> with a justification. If the former, I agree your method of dealing with >>> the situation is ok, but more investigation needs to be done to see whether >>> or not the port (in general) is broken and mark it broken if need be. >> >> It looks like the latter case, based on the PR, and it’s a build performance >> issue... Is this impacting CI pipelines? >> > > It is the latter, and I do not want to *blacklist* them because as far > as I can tell, the tests aren't necessarily broken. I want to > workaround them for default by now. > >>> The problem with src.opts.mk’s per-architecture options, is that it can be >>> very heavy handed enabling/disabling features. I’m not sure that everything >>> in there warrants disabling at that level. >> >> My investigation suggests that the course of action was overly heavy handed. >> While I’m not asking for a revert, it would be really nice if whole features >> weren’t disabled, unless there’s an issue with the feature. >> > > We do not have a lighter method for dealing with this that I can tell, > because as I said above: I do not want to blacklist them or completely > kill them off. I still want the option to build and test them, but as > I aim to switch mips over to llvm I do not want to subject CI and the > rest of the world to an extra 1.5+ hour build time for this during > tinderbox runs. > > Given that it's mips, so already tier-high, and I'm one of few people > that care about it (and I only care about it for the time being), I > intend to leave it as-is since it's still a default in the rest of the > world. Ok, valid straw man argument: in this particular case, should llvm / c++ support be disabled instead, since it’s the real underlying issue? I’m guessing (non-ancient) g++ doesn’t have this issue. Again, disabling a framework because of a single issue in the tests doesn’t make sense. Unless you have proof that the build times for all of googletest/googlemock with llvm is an issue, this seems like the wrong remediation to perform. -Enji PS A heads up to asomers and myself would have been nice. I don’t like post-commit nitpicking, since the issue could have been discussed/reviewed before commit. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r352465 - head/share/mk
> On Sep 18, 2019, at 06:53, Warner Losh wrote: > > > >> On Wed, Sep 18, 2019, 1:41 PM Kyle Evans wrote: >> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: >> > >> > >> > > On Sep 17, 2019, at 18:58, Kyle Evans wrote: >> > > >> > > Author: kevans >> > > Date: Wed Sep 18 01:58:56 2019 >> > > New Revision: 352465 >> > > URL: https://svnweb.freebsd.org/changeset/base/352465 >> > > >> > > Log: >> > > googletest: default-disable on all of MIPS for now >> > > >> > > Parts of the fusefs tests trigger a bug in current versions of llvm: IR >> > > representation of some routine for the MIPS targets is a function with a >> > > large number of arguments. This then leads the compiler on an hour+ long >> > > goose chase, which is OK if you build the current tree but less-so if >> > > you're >> > > trying external toolchain or doing a universe build involving mips when >> > > it >> > > eventually gets switched over to LLVM. >> > > >> > > Better, accurate details can be found in LLVM PR43263. >> > >> > Uh... why not do this in tests/sys/... instead? >> >> Because there's still value in being able to easily enable these for >> building/running the complete set of tests through standard build >> infrastructure, but it's not worth adding a knob specifically for the >> fusefs tests. I also prefer the communication of it being an >> off-by-default option and easily deduced from src.conf(5) that this >> part of the build is default-disabled on mips/mips. > > > This is the right way to do this, imho... I disagree: disabling a framework and all tests dependent on it because of compile times for a single test suite is the wrong approach. I would complain more loudly (for instance), if MK_TESTS were disabled on mips, just because of a build or test issue with a single test. This change throws the baby out with the bath water. The only reason why I’m not asking for a revert is that mips is a tier 2 arch which I haven’t verified, and the bath tub that’s being emptied is small, as many folks haven’t written GoogleTest tests yet in the src tree. -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r352465 - head/share/mk
> On Sep 18, 2019, at 07:33, Enji Cooper wrote: > > >>> On Sep 18, 2019, at 05:40, Kyle Evans wrote: >>> >>> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: >>> >>> >>>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: >>>> >>>> Author: kevans >>>> Date: Wed Sep 18 01:58:56 2019 >>>> New Revision: 352465 >>>> URL: https://svnweb.freebsd.org/changeset/base/352465 >>>> >>>> Log: >>>> googletest: default-disable on all of MIPS for now >>>> >>>> Parts of the fusefs tests trigger a bug in current versions of llvm: IR >>>> representation of some routine for the MIPS targets is a function with a >>>> large number of arguments. This then leads the compiler on an hour+ long >>>> goose chase, which is OK if you build the current tree but less-so if >>>> you're >>>> trying external toolchain or doing a universe build involving mips when it >>>> eventually gets switched over to LLVM. >>>> >>>> Better, accurate details can be found in LLVM PR43263. >>> >>> Uh... why not do this in tests/sys/... instead? >> >> Because there's still value in being able to easily enable these for >> building/running the complete set of tests through standard build >> infrastructure, but it's not worth adding a knob specifically for the >> fusefs tests. I also prefer the communication of it being an >> off-by-default option and easily deduced from src.conf(5) that this >> part of the build is default-disabled on mips/mips. > > Let me rephrase things a bit: is googlemock broken for all of mips, or is it > just the tests? If the latter, the tests should be blacklisted for mips with > a justification. If the former, I agree your method of dealing with the > situation is ok, but more investigation needs to be done to see whether or > not the port (in general) is broken and mark it broken if need be. It looks like the latter case, based on the PR, and it’s a build performance issue... Is this impacting CI pipelines? > The problem with src.opts.mk’s per-architecture options, is that it can be > very heavy handed enabling/disabling features. I’m not sure that everything > in there warrants disabling at that level. My investigation suggests that the course of action was overly heavy handed. While I’m not asking for a revert, it would be really nice if whole features weren’t disabled, unless there’s an issue with the feature. Thank you, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r352465 - head/share/mk
> On Sep 18, 2019, at 05:40, Kyle Evans wrote: > >> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote: >> >> >>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: >>> >>> Author: kevans >>> Date: Wed Sep 18 01:58:56 2019 >>> New Revision: 352465 >>> URL: https://svnweb.freebsd.org/changeset/base/352465 >>> >>> Log: >>> googletest: default-disable on all of MIPS for now >>> >>> Parts of the fusefs tests trigger a bug in current versions of llvm: IR >>> representation of some routine for the MIPS targets is a function with a >>> large number of arguments. This then leads the compiler on an hour+ long >>> goose chase, which is OK if you build the current tree but less-so if you're >>> trying external toolchain or doing a universe build involving mips when it >>> eventually gets switched over to LLVM. >>> >>> Better, accurate details can be found in LLVM PR43263. >> >> Uh... why not do this in tests/sys/... instead? > > Because there's still value in being able to easily enable these for > building/running the complete set of tests through standard build > infrastructure, but it's not worth adding a knob specifically for the > fusefs tests. I also prefer the communication of it being an > off-by-default option and easily deduced from src.conf(5) that this > part of the build is default-disabled on mips/mips. Let me rephrase things a bit: is googlemock broken for all of mips, or is it just the tests? If the latter, the tests should be blacklisted for mips with a justification. If the former, I agree your method of dealing with the situation is ok, but more investigation needs to be done to see whether or not the port (in general) is broken and mark it broken if need be. The problem with src.opts.mk’s per-architecture options, is that it can be very heavy handed enabling/disabling features. I’m not sure that everything in there warrants disabling at that level. Thanks, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r352465 - head/share/mk
> On Sep 17, 2019, at 18:58, Kyle Evans wrote: > > Author: kevans > Date: Wed Sep 18 01:58:56 2019 > New Revision: 352465 > URL: https://svnweb.freebsd.org/changeset/base/352465 > > Log: > googletest: default-disable on all of MIPS for now > > Parts of the fusefs tests trigger a bug in current versions of llvm: IR > representation of some routine for the MIPS targets is a function with a > large number of arguments. This then leads the compiler on an hour+ long > goose chase, which is OK if you build the current tree but less-so if you're > trying external toolchain or doing a universe build involving mips when it > eventually gets switched over to LLVM. > > Better, accurate details can be found in LLVM PR43263. Uh... why not do this in tests/sys/... instead? -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346578 - head/lib/libclang_rt
Author: ngie
Date: Mon Apr 22 19:21:35 2019
New Revision: 346578
URL: https://svnweb.freebsd.org/changeset/base/346578
Log:
Build libclang_rt/profile on all clang-supported architectures
There's no reason why a special case needs to be added specifically for amd64,
arm, and i386, as the code is written in machine architecture agnostic C/C++.
This will make it possible for all supporting clang architectures to produce
runtime coverage with `--coverage`.
MFC after:2 weeks
Reviewed by: dim
Differential Revision: https://reviews.freebsd.org/D20003
Modified:
head/lib/libclang_rt/Makefile
Modified: head/lib/libclang_rt/Makefile
==
--- head/lib/libclang_rt/Makefile Mon Apr 22 18:43:43 2019
(r346577)
+++ head/lib/libclang_rt/Makefile Mon Apr 22 19:21:35 2019
(r346578)
@@ -22,9 +22,6 @@ SUBDIR+= ubsan_standalone
SUBDIR+= ubsan_standalone_cxx
.endif
-.if ${MACHINE_CPUARCH} == "i386" || ${MACHINE_CPUARCH} == "amd64" || \
-${MACHINE_CPUARCH} == "arm"
SUBDIR+= profile
-.endif
.include
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346626 - head/tests/sys/opencrypto
Author: ngie
Date: Wed Apr 24 05:49:48 2019
New Revision: 346626
URL: https://svnweb.freebsd.org/changeset/base/346626
Log:
Fix typo: `Plen` should be `plen`
MFC after:1 month
MFC with: r346617
Reported by: pylint -E
Modified:
head/tests/sys/opencrypto/cryptotest.py
Modified: head/tests/sys/opencrypto/cryptotest.py
==
--- head/tests/sys/opencrypto/cryptotest.py Wed Apr 24 05:47:09 2019
(r346625)
+++ head/tests/sys/opencrypto/cryptotest.py Wed Apr 24 05:49:48 2019
(r346626)
@@ -307,7 +307,7 @@ def GenTestCase(cname):
aad, tag)
payload = data['Payload'].decode('hex')
-Plen = int(data('Plen'))
+plen = int(data('Plen'))
payload = payload[:plen]
self.assertEqual(r, payload,
"Count " + data['Count'] + \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Panic with r346530 [Re: svn commit: r346530 - in head/sys: netinet netinet6]
Hi Hans, > On Apr 22, 2019, at 1:32 AM, Hans Petter Selasky wrote: > > On 4/22/19 10:10 AM, Hans Petter Selasky wrote: >> On 4/22/19 9:52 AM, Enji Cooper wrote: >>> >>>> On Apr 22, 2019, at 12:27 AM, Hans Petter Selasky >>>> wrote: >>>> >>>> Author: hselasky >>>> Date: Mon Apr 22 07:27:24 2019 >>>> New Revision: 346530 >>>> URL: https://svnweb.freebsd.org/changeset/base/346530 >>>> >>>> Log: >>>> Fix panic in network stack due to memory use after free in relation to >>>> fragmented packets. >>>> >>>> When sending IPv4 and IPv6 fragmented packets and a fragment is lost, >>>> the mbuf making up the fragment will remain in the temporary hashed >>>> fragment list for a while. If the network interface departs before the >>>> so-called slow timeout clears the packet, the fragment causes a panic >>>> when the timeout kicks in due to accessing a freed network interface >>>> structure. >>>> >>>> Make sure that when a network device is departing, all hashed IPv4 and >>>> IPv6 fragments belonging to it, get freed. >>>> >>>> Backtrace: >>>> panic() >>>> icmp6_reflect() >>>> >>>> hlim = ND_IFINFO(m->m_pkthdr.rcvif)->chlim; >>>> rcvif->if_afdata[AF_INET6] is NULL. >>>> >>>> icmp6_error() >>>> frag6_freef() >>>> frag6_slowtimo() >>>> pfslowtimo() >>>> softclock_call_cc() >>>> softclock() >>>> ithread_loop() >>>> >>>> Differential Revision:https://reviews.freebsd.org/D19622 >>>> Reviewed by:bz (network), adrian >>>> MFC after:1 week >>>> Sponsored by:Mellanox Technologies > > Should be fixed by > > r346535 > > Else I'll revert. ... The code compiles, but unfortunately panics when running the test suite. From https://ci.freebsd.org/job/FreeBSD-head-amd64-test/10926/console: 03:05:01 1st 0x820967f0 allprison (allprison) @ /usr/src/sys/kern/kern_jail.c:966 03:05:01 2nd 0x820c47f0 vnet_sysinit_sxlock (vnet_sysinit_sxlock) @ /usr/src/sys/net/vnet.c:575 03:05:01 stack backtrace: 03:05:01 #0 0x80c477f3 at witness_debugger+0x73 03:05:01 #1 0x80c4753d at witness_checkorder+0xa7d 03:05:01 #2 0x80be9088 at _sx_slock_int+0x68 03:05:01 #3 0x80d0ef97 at vnet_alloc+0x117 03:05:01 #4 0x80ba4111 at kern_jail_set+0x1bb1 03:05:01 #5 0x80ba5b70 at sys_jail_set+0x40 03:05:01 #6 0x810b2e16 at amd64_syscall+0x276 03:05:01 #7 0x8108b44d at fast_syscall_common+0x101 03:05:01 panic: mtx_lock() of destroyed mutex @ /usr/src/sys/netinet/ip_reass.c:628 03:05:01 cpuid = 1 03:05:01 time = 1555927501 03:05:01 KDB: stack backtrace: 03:05:01 db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfe0030eec630 03:05:01 vpanic() at vpanic+0x19d/frame 0xfe0030eec680 03:05:01 panic() at panic+0x43/frame 0xfe0030eec6e0 03:05:02 __mtx_lock_flags() at __mtx_lock_flags+0x12e/frame 0xfe0030eec730 03:05:02 ipreass_cleanup() at ipreass_cleanup+0x86/frame 0xfe0030eec770 03:05:02 if_detach_internal() at if_detach_internal+0x786/frame 0xfe0030eec7f0 03:05:02 if_detach() at if_detach+0x3d/frame 0xfe0030eec810 03:05:02 lo_clone_destroy() at lo_clone_destroy+0x16/frame 0xfe0030eec830 03:05:02 if_clone_destroyif() at if_clone_destroyif+0x21f/frame 0xfe0030eec880 03:05:02 if_clone_detach() at if_clone_detach+0xb8/frame 0xfe0030eec8b0 03:05:02 vnet_loif_uninit() at vnet_loif_uninit+0x26/frame 0xfe0030eec8d0 03:05:02 vnet_destroy() at vnet_destroy+0x124/frame 0xfe0030eec900 03:05:02 prison_deref() at prison_deref+0x29d/frame 0xfe0030eec940 03:05:02 sys_jail_remove() at sys_jail_remove+0x28f/frame 0xfe0030eec990 03:05:02 amd64_syscall() at amd64_syscall+0x276/frame 0xfe0030eecab0 03:05:02 fast_syscall_common() at fast_syscall_common+0x101/frame 0xfe0030eecab0 03:05:02 --- syscall (508, FreeBSD ELF64, sys_jail_remove), rip = 0x80031e12a, rsp = 0x7fffe998, rbp = 0x7fffea20 --- 03:05:02 KDB: enter: panic 03:05:02 [ thread pid 13109 tid 100150 ] 03:05:02 Stopped at kdb_enter+0x3b: movq$0,kdb_why 03:05:02 db:0:kdb.enter.panic> show pcpu 03:05:02 cpuid= 1 03:05:02 dynamic pcpu = 0xfe0080191800 03:05:02 curthread= 0xf80005c1f000: pid 13109 tid 100150 "jail" 03:05:02 curpcb = 0xfe0030eecb80 03:05:02 fpcurthread = 0xf80005c1f000: pid 13109 "jail" 03:05:02 idlethread = 0xf800032765a0: tid 14 "
svn commit: r346574 - in head: lib/libc++ lib/libc++experimental lib/libc++fs lib/libcxxrt lib/libgcc_eh lib/ofed/libibnetdisc usr.bin/dtc
Author: ngie
Date: Mon Apr 22 18:38:54 2019
New Revision: 346574
URL: https://svnweb.freebsd.org/changeset/base/346574
Log:
Rework CXXSTD setting via r345708
This change allows the user to once again override the C++ standard, restoring
high-level pre-r345708 behavior.
This also unbreaks building lib/ofed/libibnetdisc/Makefile with a non-C++11
capable compiler, e.g., g++ 4.2.1, as the library supported being built with
older C++ standards.
MFC after:2 weeks
MFC with: r345708
Reviewed by: emaste
Reported by: jbeich
Differential Revision: https://reviews.freebsd.org/D19895 (as part of a
larger change)
Modified:
head/lib/libc++/Makefile
head/lib/libc++experimental/Makefile
head/lib/libc++fs/Makefile
head/lib/libcxxrt/Makefile
head/lib/libgcc_eh/Makefile.inc
head/lib/ofed/libibnetdisc/Makefile
head/usr.bin/dtc/Makefile
Modified: head/lib/libc++/Makefile
==
--- head/lib/libc++/MakefileMon Apr 22 18:33:32 2019(r346573)
+++ head/lib/libc++/MakefileMon Apr 22 18:38:54 2019(r346574)
@@ -76,7 +76,7 @@ CFLAGS+= -nostdinc++
CFLAGS+= -nostdlib
CFLAGS+= -D_LIBCPP_BUILDING_LIBRARY
CFLAGS+= -DLIBCXXRT
-CXXSTD=c++11
+CXXSTD?= c++11
LIBADD+= cxxrt
INCSGROUPS=STD EXP EXT
Modified: head/lib/libc++experimental/Makefile
==
--- head/lib/libc++experimental/MakefileMon Apr 22 18:33:32 2019
(r346573)
+++ head/lib/libc++experimental/MakefileMon Apr 22 18:38:54 2019
(r346574)
@@ -20,6 +20,6 @@ CXXFLAGS+=-nostdinc++
CXXFLAGS+= -nostdlib
CXXFLAGS+= -D_LIBCPP_BUILDING_LIBRARY
CXXFLAGS+= -DLIBCXXRT
-CXXSTD=c++14
+CXXSTD?= c++14
.include
Modified: head/lib/libc++fs/Makefile
==
--- head/lib/libc++fs/Makefile Mon Apr 22 18:33:32 2019(r346573)
+++ head/lib/libc++fs/Makefile Mon Apr 22 18:38:54 2019(r346574)
@@ -22,6 +22,6 @@ CXXFLAGS+=-nostdinc++
CXXFLAGS+= -nostdlib
CXXFLAGS+= -D_LIBCPP_BUILDING_LIBRARY
CXXFLAGS+= -DLIBCXXRT
-CXXSTD=c++14
+CXXSTD?= c++14
.include
Modified: head/lib/libcxxrt/Makefile
==
--- head/lib/libcxxrt/Makefile Mon Apr 22 18:33:32 2019(r346573)
+++ head/lib/libcxxrt/Makefile Mon Apr 22 18:38:54 2019(r346574)
@@ -22,7 +22,7 @@ SRCS+=libelftc_dem_gnu3.c\
WARNS= 0
CFLAGS+= -isystem ${SRCDIR} -nostdinc++
-CXXSTD=c++11
+CXXSTD?= c++11
VERSION_MAP= ${.CURDIR}/Version.map
.include
Modified: head/lib/libgcc_eh/Makefile.inc
==
--- head/lib/libgcc_eh/Makefile.inc Mon Apr 22 18:33:32 2019
(r346573)
+++ head/lib/libgcc_eh/Makefile.inc Mon Apr 22 18:38:54 2019
(r346574)
@@ -28,7 +28,7 @@ CXXFLAGS.${file}+=-fno-exceptions -funwind-tables
CFLAGS+= -I${UNWINDINCDIR} -I${.CURDIR} -D_LIBUNWIND_IS_NATIVE_ONLY
CXXFLAGS+= -fno-rtti
-CXXSTD=c++11
+CXXSTD?= c++11
STATIC_CXXFLAGS+= -fvisibility=hidden -fPIC
# Probably need to just move this earlier or use CXXFLAGS
.if ${MK_DIRDEPS_BUILD} == "yes"
Modified: head/lib/ofed/libibnetdisc/Makefile
==
--- head/lib/ofed/libibnetdisc/Makefile Mon Apr 22 18:33:32 2019
(r346573)
+++ head/lib/ofed/libibnetdisc/Makefile Mon Apr 22 18:38:54 2019
(r346574)
@@ -31,6 +31,9 @@ LIBADD= osmcomp ibmad ibumad
CFLAGS+= -DHAVE_CONFIG_H=1
CFLAGS+= -I${_spath}
CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/infiniband
+.if ${COMPILER_FEATURES:Mc++11}
+CXXSTD=c++11
+.endif
VERSION_MAP= ${_spath}/libibnetdisc.map
.include
Modified: head/usr.bin/dtc/Makefile
==
--- head/usr.bin/dtc/Makefile Mon Apr 22 18:33:32 2019(r346573)
+++ head/usr.bin/dtc/Makefile Mon Apr 22 18:38:54 2019(r346574)
@@ -8,6 +8,8 @@ WARNS?= 3
CXXFLAGS+= -fno-rtti -fno-exceptions
+CXXSTD=c++11
+
NO_SHARED?=NO
.include
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
> On Apr 19, 2019, at 11:29, Alexander Motin wrote: > > On 19.04.2019 14:09, Enji Cooper wrote: >>> On Apr 19, 2019, at 08:44, Alexander Motin wrote: >>> >>> Author: mav >>> Date: Fri Apr 19 15:44:45 2019 >>> New Revision: 346390 >>> URL: https://svnweb.freebsd.org/changeset/base/346390 >>> >>> Log: >>> Change the way FreeBSD GID inheritance is hacked. >>> >>> I believe previous ifdef caused NULL dereference in later zfs_log_create() >>> on attempt to create file inside directory belonging to ephemeral group >>> created on illumos, trying to write to log information about GID domain >>> of the newly created file, inheriting the ephemeral GID. >>> >>> This patch reuses original illumos SGID code with exception that due to >>> lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBODY >>> by another ifdef inside zfs_fuid_map_id(). >> >> Hi mav@! >>I was wondering, does this break ACL mappings with sticky bits for the >> group ID (or was it broken to begin with)? If the latter, does it make sense >> to file a bug/add a TODO comment? > > I don't believe this change should have any visible results for native > FreeBSD pools. It does change change handling of some pools coming from > illumos, but previous behavior in that case resulted in kernel panic, so > anything else is better, while full compatibility is impossible, since > FreeBSD has no kernel-side AD UID/GID mapping, used by illumos SMB. > > Could you better describe what ACL mapping breakage you are talking about? Ah... Yeah, it makes sense to leave this alone since it’s a missing ZFS on FreeBSD feature. Thank you! -Enji PS I was likely messing up my interpretation of the stat field. I didn’t read the manpage yet. ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346619 - head/sys/powerpc/aim
> On Apr 23, 2019, at 19:51, Justin Hibbits wrote: > > Author: jhibbits > Date: Wed Apr 24 02:51:58 2019 > New Revision: 346619 > URL: https://svnweb.freebsd.org/changeset/base/346619 > > Log: > powerpc: Add a couple missing isyncs > > mtmsr and mtsr require context synchronizing instructions to follow. Without > a CSI, there's a chance for a machine check exception. This reportedly does > occur on a MPC750 (PowerMac G3). G3?! Wow... the oldest I’ve used is the G4, back a decade and a half ago :0... -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346623 - head/tests/sys/opencrypto
Author: ngie
Date: Wed Apr 24 04:50:03 2019
New Revision: 346623
URL: https://svnweb.freebsd.org/changeset/base/346623
Log:
Chase PEP-3110
Replace `except Environment, e:` with `except Environment as e` for
compatibility between python 2.x and python 3.x.
While here, fix a bad indentation change from r346620 by reindenting the code
properly.
MFC after:2 months
Modified:
head/tests/sys/opencrypto/cryptotest.py
Modified: head/tests/sys/opencrypto/cryptotest.py
==
--- head/tests/sys/opencrypto/cryptotest.py Wed Apr 24 04:45:00 2019
(r346622)
+++ head/tests/sys/opencrypto/cryptotest.py Wed Apr 24 04:50:03 2019
(r346623)
@@ -124,7 +124,7 @@ def GenTestCase(cname):
mac=self._gmacsizes[len(cipherkey)],
mackey=cipherkey, crid=crid,
maclen=16)
-except EnvironmentError, e:
+except EnvironmentError as e:
# Can't test algorithms the driver does not support.
if e.errno != errno.EOPNOTSUPP:
raise
@@ -133,7 +133,7 @@ def GenTestCase(cname):
if mode == 'ENCRYPT':
try:
rct, rtag = c.encrypt(pt, iv, aad)
-except EnvironmentError, e:
+except EnvironmentError as e:
# Can't test inputs the driver does not support.
if e.errno != errno.EINVAL:
raise
@@ -153,7 +153,7 @@ def GenTestCase(cname):
else:
try:
rpt, rtag = c.decrypt(*args)
-except EnvironmentError, e:
+except EnvironmentError as e:
# Can't test inputs the driver does not
support.
if e.errno != errno.EINVAL:
raise
@@ -221,7 +221,7 @@ def GenTestCase(cname):
try:
c = Crypto(meth, cipherkey, crid=crid)
r = curfun(c, pt, iv)
-except EnvironmentError, e:
+except EnvironmentError as e:
# Can't test hashes the driver does not support.
if e.errno != errno.EOPNOTSUPP:
raise
@@ -252,7 +252,7 @@ def GenTestCase(cname):
mackey=key, maclen=16)
r, tag = Crypto.encrypt(c, payload,
nonce, aad)
-except EnvironmentError, e:
+except EnvironmentError as e:
if e.errno != errno.EOPNOTSUPP:
raise
continue
@@ -294,7 +294,7 @@ def GenTestCase(cname):
key=key,
mac=cryptodev.CRYPTO_AES_CCM_CBC_MAC,
mackey=key, maclen=16)
-except EnvironmentError, e:
+except EnvironmentError as e:
if e.errno != errno.EOPNOTSUPP:
raise
continue
@@ -388,13 +388,13 @@ def GenTestCase(cname):
for data in lines:
msg = data['Msg'].decode('hex')
-msg = msg[:int(data['Len'])]
+msg = msg[:int(data['Len'])]
md = data['MD'].decode('hex')
try:
c = Crypto(mac=alg, crid=crid,
maclen=hashlen)
-except EnvironmentError, e:
+except EnvironmentError as e:
# Can't test hashes the driver does not support.
if e.errno != errno.EOPNOTSUPP:
raise
@@ -451,7 +451,7 @@ def GenTestCase(cname):
try:
c = Crypto(mac=alg, mackey=key,
crid=crid, maclen=hashlen)
-except EnvironmentError, e:
+except EnvironmentError as e:
# Can't test hashes the driver does not support.
if e.errno != errno.EOPNOTSUPP:
raise
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346443 - head/tests/sys/opencrypto
> On Apr 20, 2019, at 9:54 AM, John Baldwin wrote: … > To be clear, I prefer the _new_ indentation. I kept having to go back and > manually > use tabify in emacs to work with the current scripts, so once my pending > stuff is > drained I will appreciate having it converted. I figured as much, but really appreciate the clarification <3! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346625 - head/tests/sys/opencrypto
Author: ngie
Date: Wed Apr 24 05:47:09 2019
New Revision: 346625
URL: https://svnweb.freebsd.org/changeset/base/346625
Log:
Don't leak `fd` when manipulating the device via `_getdev()`
Close the file descriptor when done calling ioctl with a try-finally block so
it doesn't get leaked.
MFC after:2 months
Modified:
head/tests/sys/opencrypto/cryptodev.py
Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py Wed Apr 24 05:24:10 2019
(r346624)
+++ head/tests/sys/opencrypto/cryptodev.py Wed Apr 24 05:47:09 2019
(r346625)
@@ -122,10 +122,12 @@ CIOCFINDDEV = 3223610220
CIOCCRYPTAEAD = 3225445229
def _getdev():
-fd = os.open('/dev/crypto', os.O_RDWR)
buf = array.array('I', [0])
-ioctl(fd, CRIOGET, buf, 1)
-os.close(fd)
+fd = os.open('/dev/crypto', os.O_RDWR)
+try:
+ioctl(fd, CRIOGET, buf, 1)
+finally:
+os.close(fd)
return buf[0]
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346576 - head/share/mk
Author: ngie
Date: Mon Apr 22 18:40:46 2019
New Revision: 346576
URL: https://svnweb.freebsd.org/changeset/base/346576
Log:
Fix up CXXSTD support originally added in r345708
r345708 worked for the base system, but unfortunately, caused a lot of
disruption for third-party packages that relied on C++, since bsd.sys.mk is
used by applications outside the base system. The defaults picked didn't match
the compiler's defaults and broke some builds that didn't specify a standard,
as well as some that overrode the value by setting `-std=gnu++14` (for
example) manually.
This change takes a more relaxed approach to appending `-std=${CXXSTD}` to
CXXFLAGS, by only doing so when the value is specified, as opposed to
overriding the standard set by an end-user. This avoids the need for having
to bake NOP default into bsd.sys.mk for supported compiler-toolchain
versions.
In order to make this change possible, add CXXSTD to Makefile snippets which
relied on the default value (c++11) added in r345708.
MFC after: 2 weeks
MFC with: r345708, r346574
Reviewed by:emaste
Reported by:jbeich
Differential Revision: https://reviews.freebsd.org/D19895 (as part of a
larger change)
Modified:
head/share/mk/bsd.sys.mk
head/share/mk/googletest.test.inc.mk
Modified: head/share/mk/bsd.sys.mk
==
--- head/share/mk/bsd.sys.mkMon Apr 22 18:40:24 2019(r346575)
+++ head/share/mk/bsd.sys.mkMon Apr 22 18:40:46 2019(r346576)
@@ -25,17 +25,9 @@ CFLAGS+= -std=iso9899:1999
CFLAGS+= -std=${CSTD}
.endif # CSTD
-.if ${COMPILER_FEATURES:Mc++11}
-CXXSTD?= c++11
-.elif ${COMPILER_TYPE} == "gcc"
-# Prior versions of g++ support C++98 with GNU extensions by default.
-CXXSTD?= gnu++98
-.else
-# Assume that the compiler supports at least C++98.
-CXXSTD?= c++98
-.endif
+.if !empty(CXXSTD)
CXXFLAGS+= -std=${CXXSTD}
-# CXXSTD
+.endif
# -pedantic is problematic because it also imposes namespace restrictions
#CFLAGS+= -pedantic
Modified: head/share/mk/googletest.test.inc.mk
==
--- head/share/mk/googletest.test.inc.mkMon Apr 22 18:40:24 2019
(r346575)
+++ head/share/mk/googletest.test.inc.mkMon Apr 22 18:40:46 2019
(r346576)
@@ -9,4 +9,6 @@ GTESTS_CXXFLAGS+= -frtti
# libgmock's, etc, headers.
CXXFLAGS+= -I${DESTDIR}${INCLUDEDIR}/private
+CXXSTD?= c++11
+
NO_WTHREAD_SAFETY=
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346542 - head/tests/sys/kern
Author: ngie
Date: Mon Apr 22 11:21:20 2019
New Revision: 346542
URL: https://svnweb.freebsd.org/changeset/base/346542
Log:
Fix sys.kern.coredump_phnum_test.coredump_phnum on i386
The zero-padding when printing out the Size field is on 32-bit architectures
is
5, not 15. Adjust the regular expression to work with both the 32-bit and
64-bit case.
MFC after:1 week
Reviewed by: lwhsu, markj
Approved by: emaste (mentor, implicit)
Differential Revision: https://reviews.freebsd.org/D20005
Modified:
head/tests/sys/kern/coredump_phnum_test.sh
Modified: head/tests/sys/kern/coredump_phnum_test.sh
==
--- head/tests/sys/kern/coredump_phnum_test.sh Mon Apr 22 11:17:37 2019
(r346541)
+++ head/tests/sys/kern/coredump_phnum_test.sh Mon Apr 22 11:21:20 2019
(r346542)
@@ -65,7 +65,7 @@ EOF
-x 'readelf -h coredump_phnum_helper.core | grep "Number of program
headers:"'
atf_check -o "match:There are 66[0-9]{3} program headers" \
-x 'readelf -l coredump_phnum_helper.core | grep -1 "program
headers"'
- atf_check -o "match: 0001 .* 66[0-9]{3} " \
+ atf_check -o "match: 0(00)?1 .* 66[0-9]{3} " \
-x 'readelf -S coredump_phnum_helper.core | grep -A1 "^ \[ 0\] "'
atf_check -o "match:66[0-9]{3}" \
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346515 - stable/11/usr.bin/procstat/tests
Author: ngie
Date: Mon Apr 22 03:19:40 2019
New Revision: 346515
URL: https://svnweb.freebsd.org/changeset/base/346515
Log:
Comment out checks that are causing failures on ^/stable/11, post-r337133
Some usr.bin/procstat code has not been MFCed to ^/stable/11 for command line
handling, and unfortunately, r337133 (which was MFCed as r337542) relies on
that support.
Comment out the checks and add a pointer to the PR for code archaeology and
to cause future potential parties to verify changes when backporting them.
This is a direct commit to ^/stable/11
PR: 237445
Reviewed by: markj
Approved by: emaste (mentor; implicit)
Differential Revision: https://reviews.freebsd.org/D19998
Modified:
stable/11/usr.bin/procstat/tests/procstat_test.sh
Modified: stable/11/usr.bin/procstat/tests/procstat_test.sh
==
--- stable/11/usr.bin/procstat/tests/procstat_test.sh Mon Apr 22 03:06:12
2019(r346514)
+++ stable/11/usr.bin/procstat/tests/procstat_test.sh Mon Apr 22 03:19:40
2019(r346515)
@@ -138,8 +138,9 @@ kernel_stacks_head()
}
kernel_stacks_body()
{
- atf_check -o save:procstat.out procstat -a kstack
- atf_check -o not-empty awk '{if ($3 == "procstat") print}' procstat.out
+ # Bug 237445: checks will fail because of missing MFCs on branch
+ #atf_check -o save:procstat.out procstat -a kstack
+ #atf_check -o not-empty awk '{if ($3 == "procstat") print}' procstat.out
atf_check -o save:procstat.out procstat -kka
atf_check -o not-empty awk '{if ($3 == "procstat") print}' procstat.out
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346443 - head/tests/sys/opencrypto
> On Apr 20, 2019, at 9:38 AM, John Baldwin wrote: > > On 4/20/19 9:32 AM, Enji Cooper wrote: >> >>> On Apr 20, 2019, at 9:31 AM, Enji Cooper wrote: >>> >>> >>>> On Apr 20, 2019, at 9:30 AM, John Baldwin >>> <mailto:j...@freebsd.org>> wrote: >>>> >>>> On 4/20/19 8:43 AM, Enji Cooper wrote: >>>>> Author: ngie >>>>> Date: Sat Apr 20 15:43:28 2019 >>>>> New Revision: 346443 >>>>> URL: https://svnweb.freebsd.org/changeset/base/346443 >>>>> <https://svnweb.freebsd.org/changeset/base/346443> >>>>> >>>>> Log: >>>>> tests/sys/opencrypto: fix whitespace per PEP8 >>>>> >>>>> Replace hard tabs with four-character indentations, per PEP8. >>>>> >>>>> This is being done to separate stylistic changes from the tests from >>>>> functional >>>>> ones, as I accidentally introduced a bug to the tests when I used >>>>> four-space >>>>> indentation locally. >>>>> >>>>> No functional change. >>>> >>>> Wow, this is really painful for the 4-5 open reviews I have outstanding as >>>> it >>>> makes a merge disaster. >>> >>> Sorry ;_;… >> >> Being more constructive: I will back out the change, then reapply it >> later. >> Thank you, > > Ok, is it easy to reapply using a script or some such? Also, in general I do > prefer > this indentation as 1) it works out of the box in emacs, and 2) many of the > lines in > cryptotest.py especially are indented pretty far over making it hard to read. Yeah. I basically did `%s/ /. /g` in vim :). Backed out via r346452. Using hard tabs in python should really be verboten, except when dealing with docstrings, etc. It’s so easy to screw up programs/introduce dead code by not indenting things consistently with four-space indents. Thanks! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346539 - head/lib/libc/tests/sys
Author: ngie Date: Mon Apr 22 11:09:24 2019 New Revision: 346539 URL: https://svnweb.freebsd.org/changeset/base/346539 Log: Fix `get_int_via_sysctlbyname(..)` on Jenkins Initialize `oldlen` to the size of the value, instead of leaving the value unitialized. Leaving it unitialized seems to work by accident on amd64 when running 64-bit programs, but not on i386. This matches patterns in use in other programs. PR: 237458 Approved by: emaste (mentor; implicit) MFC after:1 week Tested on:^/head (amd64), ^/stable/11 (i386) Modified: head/lib/libc/tests/sys/sendfile_test.c Modified: head/lib/libc/tests/sys/sendfile_test.c == --- head/lib/libc/tests/sys/sendfile_test.c Mon Apr 22 10:02:34 2019 (r346538) +++ head/lib/libc/tests/sys/sendfile_test.c Mon Apr 22 11:09:24 2019 (r346539) @@ -62,6 +62,8 @@ get_int_via_sysctlbyname(const char *oidname) size_t oldlen; int int_value; + oldlen = sizeof(int_value); + ATF_REQUIRE_EQ_MSG(sysctlbyname(oidname, _value, , NULL, 0), 0, "sysctlbyname(%s, ...) failed: %s", oidname, strerror(errno)); ATF_REQUIRE_EQ_MSG(sizeof(int_value), oldlen, "sanity check failed"); ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346399 - head/share/man/man4
> On Apr 19, 2019, at 10:15, Conrad Meyer wrote: > > Author: cem > Date: Fri Apr 19 17:15:58 2019 > New Revision: 346399 > URL: https://svnweb.freebsd.org/changeset/base/346399 > > Log: > random.4: Include description of knobs added in r346358 > > Reported by:ngie > Sponsored by:Dell EMC Isilon Thank you so very much Conrad \^O^/!!! You’re awesome! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346572 - in head/lib: libcam/tests libkvm/tests libsbuf/tests
Author: ngie Date: Mon Apr 22 18:05:33 2019 New Revision: 346572 URL: https://svnweb.freebsd.org/changeset/base/346572 Log: Update the spelling of my name (continuation of r346571) Previous spellings of my name (NGie, Ngie) weren't my legal spelling. Use Enji instead for clarity. While here, remove "All Rights Reserved" from copyrights I "own". MFC after:1 week Modified: head/lib/libcam/tests/libcam_test.c head/lib/libkvm/tests/kvm_close_test.c head/lib/libkvm/tests/kvm_geterr_test.c head/lib/libkvm/tests/kvm_open2_test.c head/lib/libkvm/tests/kvm_open_test.c head/lib/libkvm/tests/kvm_test_common.c head/lib/libkvm/tests/kvm_test_common.h head/lib/libsbuf/tests/sbuf_core_test.c head/lib/libsbuf/tests/sbuf_stdio_test.c head/lib/libsbuf/tests/sbuf_string_test.c head/lib/libsbuf/tests/sbuf_test_common.h Modified: head/lib/libcam/tests/libcam_test.c == --- head/lib/libcam/tests/libcam_test.c Mon Apr 22 17:52:46 2019 (r346571) +++ head/lib/libcam/tests/libcam_test.c Mon Apr 22 18:05:33 2019 (r346572) @@ -1,6 +1,5 @@ /*- - * Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libkvm/tests/kvm_close_test.c == --- head/lib/libkvm/tests/kvm_close_test.c Mon Apr 22 17:52:46 2019 (r346571) +++ head/lib/libkvm/tests/kvm_close_test.c Mon Apr 22 18:05:33 2019 (r346572) @@ -1,6 +1,5 @@ /*- - * Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libkvm/tests/kvm_geterr_test.c == --- head/lib/libkvm/tests/kvm_geterr_test.c Mon Apr 22 17:52:46 2019 (r346571) +++ head/lib/libkvm/tests/kvm_geterr_test.c Mon Apr 22 18:05:33 2019 (r346572) @@ -1,6 +1,5 @@ /*- - * Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libkvm/tests/kvm_open2_test.c == --- head/lib/libkvm/tests/kvm_open2_test.c Mon Apr 22 17:52:46 2019 (r346571) +++ head/lib/libkvm/tests/kvm_open2_test.c Mon Apr 22 18:05:33 2019 (r346572) @@ -1,6 +1,5 @@ /*- - * Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libkvm/tests/kvm_open_test.c == --- head/lib/libkvm/tests/kvm_open_test.c Mon Apr 22 17:52:46 2019 (r346571) +++ head/lib/libkvm/tests/kvm_open_test.c Mon Apr 22 18:05:33 2019 (r346572) @@ -1,6 +1,5 @@ /*- - * Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libkvm/tests/kvm_test_common.c == --- head/lib/libkvm/tests/kvm_test_common.c Mon Apr 22 17:52:46 2019 (r346571) +++ head/lib/libkvm/tests/kvm_test_common.c Mon Apr 22 18:05:33 2019 (r346572) @@ -1,6 +1,5 @@ /*- - * Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libkvm/tests/kvm_test_common.h == --- head/lib/libkvm/tests/kvm_test_common.h Mon Apr 22 17:52:46 2019 (r346571) +++ head/lib/libkvm/tests/kvm_test_common.h Mon Apr 22 18:05:33 2019 (r346572) @@ -1,6 +1,5 @@ /*- - * Copyright (c) 2017 Ngie Cooper - * All rights reserved. + * Copyright (c) 2017 Enji Cooper * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions Modified: head/lib/libsbuf/te
svn commit: r346627 - head/tests/sys/opencrypto
Author: ngie
Date: Wed Apr 24 05:52:24 2019
New Revision: 346627
URL: https://svnweb.freebsd.org/changeset/base/346627
Log:
Use `range` instead of `xrange`
`xrange` is a pre-python 2.x compatible idiom. Use `range` instead. The values
being iterated over are sufficiently small that using range on python 2.x
won't
be a noticeable issue.
MFC after:2 months
Modified:
head/tests/sys/opencrypto/cryptodev.py
Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py Wed Apr 24 05:49:48 2019
(r346626)
+++ head/tests/sys/opencrypto/cryptodev.py Wed Apr 24 05:52:24 2019
(r346627)
@@ -258,7 +258,7 @@ class Crypto:
return s, tag.tostring()
def perftest(self, op, size, timeo=3):
-inp = array.array('B', (random.randint(0, 255) for x in xrange(size)))
+inp = array.array('B', (random.randint(0, 255) for x in range(size)))
out = array.array('B', inp)
# prep ioctl
@@ -273,7 +273,7 @@ class Crypto:
if self._maclen is not None:
m = array.array('B', [0] * self._maclen)
cop.mac = m.buffer_info()[0]
-ivbuf = array.array('B', (random.randint(0, 255) for x in xrange(16)))
+ivbuf = array.array('B', (random.randint(0, 255) for x in range(16)))
cop.iv = ivbuf.buffer_info()[0]
exit = [ False ]
@@ -503,7 +503,7 @@ if __name__ == '__main__':
except IOError:
print('aesni0 not found')
-for i in xrange(10):
+for i in range(10):
try:
name = Crypto.getcridname(i)
print('%2d: %r' % (i, repr(name)))
@@ -637,7 +637,7 @@ if __name__ == '__main__':
print('tag:', tag.encode('hex'))
assert enctag == tag
elif False:
-for i in xrange(10):
+for i in range(10):
c = Crypto(CRYPTO_AES_XTS,
'1bbfeadf539daedcae33ced497343f3ca1f2474ad932b903997d44707db41382'.decode('hex'))
data = '52a42bca4e9425a25bbc8c8bf6129dec'.decode('hex')
ct = '517e602becd066b65fa4f4f56ddfe240'.decode('hex')
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346530 - in head/sys: netinet netinet6
> On Apr 22, 2019, at 12:27 AM, Hans Petter Selasky
> wrote:
>
> Author: hselasky
> Date: Mon Apr 22 07:27:24 2019
> New Revision: 346530
> URL: https://svnweb.freebsd.org/changeset/base/346530
>
> Log:
> Fix panic in network stack due to memory use after free in relation to
> fragmented packets.
>
> When sending IPv4 and IPv6 fragmented packets and a fragment is lost,
> the mbuf making up the fragment will remain in the temporary hashed
> fragment list for a while. If the network interface departs before the
> so-called slow timeout clears the packet, the fragment causes a panic
> when the timeout kicks in due to accessing a freed network interface
> structure.
>
> Make sure that when a network device is departing, all hashed IPv4 and
> IPv6 fragments belonging to it, get freed.
>
> Backtrace:
> panic()
> icmp6_reflect()
>
> hlim = ND_IFINFO(m->m_pkthdr.rcvif)->chlim;
> rcvif->if_afdata[AF_INET6] is NULL.
>
> icmp6_error()
> frag6_freef()
> frag6_slowtimo()
> pfslowtimo()
> softclock_call_cc()
> softclock()
> ithread_loop()
>
> Differential Revision: https://reviews.freebsd.org/D19622
> Reviewed by: bz (network), adrian
> MFC after: 1 week
> Sponsored by:Mellanox Technologies
This commit broke the build on mips, etc:
07:36:06
--- ip_reass.o ---
07:36:06
/usr/src/sys/netinet/ip_reass.c:641: error: expected ')' before '(' token
07:36:06 *** [ip_reass.o] Error code 1
EVENTHANDLER_DEFINE looks like it doesn’t work with gcc?
Thanks,
-Enji
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346390 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
> On Apr 19, 2019, at 08:44, Alexander Motin wrote: > > Author: mav > Date: Fri Apr 19 15:44:45 2019 > New Revision: 346390 > URL: https://svnweb.freebsd.org/changeset/base/346390 > > Log: > Change the way FreeBSD GID inheritance is hacked. > > I believe previous ifdef caused NULL dereference in later zfs_log_create() > on attempt to create file inside directory belonging to ephemeral group > created on illumos, trying to write to log information about GID domain > of the newly created file, inheriting the ephemeral GID. > > This patch reuses original illumos SGID code with exception that due to > lack of ID mapping code on FreeBSD ephemeral GID will turn into GID_NOBODY > by another ifdef inside zfs_fuid_map_id(). Hi mav@! I was wondering, does this break ACL mappings with sticky bits for the group ID (or was it broken to begin with)? If the latter, does it make sense to file a bug/add a TODO comment? Thank you! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346571 - in head: share/examples/tests/tests/tap share/man/man4 share/man/man5 share/zoneinfo/tests usr.bin/calendar/calendars usr.bin/du/tests usr.bin/getconf/tests usr.bin/procstat/t...
Author: ngie Date: Mon Apr 22 17:52:46 2019 New Revision: 346571 URL: https://svnweb.freebsd.org/changeset/base/346571 Log: Update the spelling of my name Previous spellings of my name (NGie, Ngie) weren't my legal spelling. Use Enji instead for clarity. While here, remove "All Rights Reserved" from copyrights I "own". MFC after:1 week Modified: head/share/examples/tests/tests/tap/cp_test.sh head/share/man/man4/cfiscsi.4 head/share/man/man5/cd9660.5 head/share/zoneinfo/tests/backward_test.sh head/share/zoneinfo/tests/zoneinfo_common.sh head/usr.bin/calendar/calendars/calendar.freebsd head/usr.bin/du/tests/du_test.sh head/usr.bin/getconf/tests/arch_type.c head/usr.bin/procstat/tests/procstat_test.sh head/usr.bin/procstat/tests/while1.c head/usr.sbin/sysrc/sysrc.8 Modified: head/share/examples/tests/tests/tap/cp_test.sh == --- head/share/examples/tests/tests/tap/cp_test.sh Mon Apr 22 17:48:10 2019(r346570) +++ head/share/examples/tests/tests/tap/cp_test.sh Mon Apr 22 17:52:46 2019(r346571) @@ -1,7 +1,6 @@ #!/bin/sh # -# Copyright (c) 2017 Ngie Cooper -# All rights reserved. +# Copyright (c) 2017 Enji Cooper # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions Modified: head/share/man/man4/cfiscsi.4 == --- head/share/man/man4/cfiscsi.4 Mon Apr 22 17:48:10 2019 (r346570) +++ head/share/man/man4/cfiscsi.4 Mon Apr 22 17:52:46 2019 (r346571) @@ -1,7 +1,6 @@ .\" Copyright (c) 2013 Edward Tomasz Napierala .\" Copyright (c) 2015-2017 Alexander Motin -.\" Copyright (c) 2017 Ngie Cooper -.\" All rights reserved. +.\" Copyright (c) 2017 Enji Cooper .\" .\" Redistribution and use in source and binary forms, with or without .\" modification, are permitted provided that the following conditions @@ -109,4 +108,4 @@ subsystem was developed by .An Edward Tomasz Napierala Aq Mt tr...@freebsd.org under sponsorship from the FreeBSD Foundation. This manual page was written by -.An Ngie Cooper Aq Mt n...@freebsd.org . +.An Enji Cooper Aq Mt n...@freebsd.org . Modified: head/share/man/man5/cd9660.5 == --- head/share/man/man5/cd9660.5Mon Apr 22 17:48:10 2019 (r346570) +++ head/share/man/man5/cd9660.5Mon Apr 22 17:52:46 2019 (r346571) @@ -1,6 +1,5 @@ .\" -.\" Copyright (c) 2017 Ngie Cooper -.\" All rights reserved. +.\" Copyright (c) 2017 Enji Cooper .\" .\" Redistribution and use in source and binary forms, with or without .\" modification, are permitted provided that the following conditions @@ -79,4 +78,4 @@ and .An Atsushi Murai Aq Mt amu...@spec.co.jp . .Pp This manual page was written by -.An Ngie Cooper Aq Mt n...@freebsd.org . +.An Enji Cooper Aq Mt n...@freebsd.org . Modified: head/share/zoneinfo/tests/backward_test.sh == --- head/share/zoneinfo/tests/backward_test.sh Mon Apr 22 17:48:10 2019 (r346570) +++ head/share/zoneinfo/tests/backward_test.sh Mon Apr 22 17:52:46 2019 (r346571) @@ -1,6 +1,5 @@ # -# Copyright (c) 2017 Ngie Cooper -# All rights reserved. +# Copyright (c) 2017 Enji Cooper # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions Modified: head/share/zoneinfo/tests/zoneinfo_common.sh == --- head/share/zoneinfo/tests/zoneinfo_common.shMon Apr 22 17:48:10 2019(r346570) +++ head/share/zoneinfo/tests/zoneinfo_common.shMon Apr 22 17:52:46 2019(r346571) @@ -1,7 +1,6 @@ #!/bin/sh # -# Copyright (c) 2017 Ngie Cooper -# All rights reserved. +# Copyright (c) 2017 Enji Cooper # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions Modified: head/usr.bin/calendar/calendars/calendar.freebsd == --- head/usr.bin/calendar/calendars/calendar.freebsdMon Apr 22 17:48:10 2019(r346570) +++ head/usr.bin/calendar/calendars/calendar.freebsdMon Apr 22 17:52:46 2019(r346571) @@ -46,7 +46,7 @@ 01/27 Nick Sayer born in San Diego, California, United States, 1968 01/27 Jacques Anthony Vidrine born in Baton Rouge, Louisiana, United States, 1971 01/27 Alexandre C. Guimaraes born in Rio de Janeiro, Rio de Janeiro, Brazil, 1982 -01/27 Ngie Cooper born in Seattle, Washington, Uni
svn commit: r346443 - head/tests/sys/opencrypto
Author: ngie
Date: Sat Apr 20 15:43:28 2019
New Revision: 346443
URL: https://svnweb.freebsd.org/changeset/base/346443
Log:
tests/sys/opencrypto: fix whitespace per PEP8
Replace hard tabs with four-character indentations, per PEP8.
This is being done to separate stylistic changes from the tests from
functional
ones, as I accidentally introduced a bug to the tests when I used four-space
indentation locally.
No functional change.
MFC after:2 months
Approved by: emaste (mentor: implicit blanket approval for trivial fixes)
Modified:
head/tests/sys/opencrypto/cryptodev.py
head/tests/sys/opencrypto/cryptotest.py
Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py Sat Apr 20 15:06:58 2019
(r346442)
+++ head/tests/sys/opencrypto/cryptodev.py Sat Apr 20 15:43:28 2019
(r346443)
@@ -43,65 +43,65 @@ from cryptodevh import *
__all__ = [ 'Crypto', 'MismatchError', ]
class FindOp(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('crid', 'i', 0),
- ('name', '32s', 0),
- )
+__byte_order__ = '@'
+__hdr__ = ( ('crid', 'i', 0),
+('name', '32s', 0),
+)
class SessionOp(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('cipher', 'I', 0),
- ('mac', 'I', 0),
- ('keylen', 'I', 0),
- ('key', 'P', 0),
- ('mackeylen', 'i', 0),
- ('mackey', 'P', 0),
- ('ses', 'I', 0),
- )
+__byte_order__ = '@'
+__hdr__ = ( ('cipher', 'I', 0),
+('mac', 'I', 0),
+('keylen', 'I', 0),
+('key', 'P', 0),
+('mackeylen', 'i', 0),
+('mackey', 'P', 0),
+('ses', 'I', 0),
+)
class SessionOp2(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('cipher', 'I', 0),
- ('mac', 'I', 0),
- ('keylen', 'I', 0),
- ('key', 'P', 0),
- ('mackeylen', 'i', 0),
- ('mackey', 'P', 0),
- ('ses', 'I', 0),
- ('crid', 'i', 0),
- ('pad0', 'i', 0),
- ('pad1', 'i', 0),
- ('pad2', 'i', 0),
- ('pad3', 'i', 0),
- )
+__byte_order__ = '@'
+__hdr__ = ( ('cipher', 'I', 0),
+('mac', 'I', 0),
+('keylen', 'I', 0),
+('key', 'P', 0),
+('mackeylen', 'i', 0),
+('mackey', 'P', 0),
+('ses', 'I', 0),
+('crid', 'i', 0),
+('pad0', 'i', 0),
+('pad1', 'i', 0),
+('pad2', 'i', 0),
+('pad3', 'i', 0),
+)
class CryptOp(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('ses', 'I', 0),
- ('op', 'H', 0),
- ('flags', 'H', 0),
- ('len', 'I', 0),
- ('src', 'P', 0),
- ('dst', 'P', 0),
- ('mac', 'P', 0),
- ('iv', 'P', 0),
- )
+__byte_order__ = '@'
+__hdr__ = ( ('ses', 'I', 0),
+('op', 'H', 0),
+('flags', 'H', 0),
+('len', 'I', 0),
+('src', 'P', 0),
+('dst', 'P', 0),
+('mac', 'P', 0),
+('iv', 'P', 0),
+)
class CryptAEAD(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = (
- ('ses', 'I', 0),
- ('op', 'H', 0),
- ('flags', 'H', 0),
- ('len', 'I', 0),
- ('aadlen', 'I', 0),
- ('ivlen', 'I', 0),
- ('src', 'P', 0),
- ('dst', 'P', 0),
- ('aad', 'P', 0),
- ('tag', 'P', 0),
- ('iv', 'P', 0),
- )
+__byte_order__ = '@'
+__hdr__ = (
+('ses','I', 0),
+('op','H', 0),
+('flags','H', 0),
+('len','I', 0),
+('aadlen','I', 0),
+('ivlen','I', 0),
+('src','P', 0),
+('dst','P', 0),
+('aad','P', 0),
+('tag','P', 0),
+('iv','P', 0),
+)
# h2py.py can't handle multiarg macros
CRIOGET = 3221513060
@@ -116,445 +116,445 @@ CIOCFINDDEV = 3223610220
CIOCCRYPTAEAD = 3225445229
def _getdev():
- fd = os.open('/dev/crypto', os.O_RDWR)
- buf = array.array('I', [0])
- ioctl(fd, CRIOGET, buf, 1)
- os.close(fd)
+fd = os.open('/dev/crypto', os.O_RDWR)
+buf = array.array('I', [0])
+ioctl(fd, CRIOGET, buf, 1)
+os.close(fd)
- return buf[0]
+return buf[0]
_cryptodev = _getdev()
def _findop(crid, name):
- fop = FindOp()
- fop.crid = crid
- fop.name = name
- s = array.array('B', fop.pack_hdr())
- ioctl(_cryptodev, CIOCFINDDEV, s, 1)
- fop.unpack(s)
+fop = FindOp()
+fop.crid =
Re: svn commit: r346571 - in head: share/examples/tests/tests/tap share/man/man4 share/man/man5 share/zoneinfo/tests usr.bin/calendar/calendars usr.bin/du/tests usr.bin/getconf/tests usr.bin/procstat/
> On Apr 22, 2019, at 12:19, Edward Napierala wrote: > > On Mon, 22 Apr 2019 at 20:01, Rodney W. Grimes > wrote: >> >>> Author: ngie >>> Date: Mon Apr 22 17:52:46 2019 >>> New Revision: 346571 >>> URL: https://svnweb.freebsd.org/changeset/base/346571 >>> >>> Log: >>> Update the spelling of my name >>> >>> Previous spellings of my name (NGie, Ngie) weren't my legal spelling. Use >>> Enji >>> instead for clarity. >>> >>> While here, remove "All Rights Reserved" from copyrights I "own". > > [..] > >>> Modified: head/share/man/man4/cfiscsi.4 >>> == >>> --- head/share/man/man4/cfiscsi.4 Mon Apr 22 17:48:10 2019 >>> (r346570) >>> +++ head/share/man/man4/cfiscsi.4 Mon Apr 22 17:52:46 2019 >>> (r346571) >>> @@ -1,7 +1,6 @@ >>> .\" Copyright (c) 2013 Edward Tomasz Napierala >>> .\" Copyright (c) 2015-2017 Alexander Motin >>> -.\" Copyright (c) 2017 Ngie Cooper >>> -.\" All rights reserved. >>> +.\" Copyright (c) 2017 Enji Cooper >> >> We should investiage the history of this All rights reserved, >> I suspect it actually originally belongs to traz and possibly >> mav, and not explicity you due to prior habbits. If you have >> already done that investigation (ie, you added the line) ignore >> my comment. If however you simply added a copyright between >> the line and some other copyright please restore this line >> to its prior state. > > FWIW, I'm perfectly fine with this. The lineage is complicated: trasz@ was the original person that put “All rights reserved” in the iscsi.4 copyright, and I based manpage on the iscsi.4 manpage, so I thought it was appropriate for me to remove the copyright. trasz@ signing off on this resolves the only potential gray area with this change. Thank you though for following up. -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346443 - head/tests/sys/opencrypto
> On Apr 20, 2019, at 9:30 AM, John Baldwin wrote: > > On 4/20/19 8:43 AM, Enji Cooper wrote: >> Author: ngie >> Date: Sat Apr 20 15:43:28 2019 >> New Revision: 346443 >> URL: https://svnweb.freebsd.org/changeset/base/346443 >> >> Log: >> tests/sys/opencrypto: fix whitespace per PEP8 >> >> Replace hard tabs with four-character indentations, per PEP8. >> >> This is being done to separate stylistic changes from the tests from >> functional >> ones, as I accidentally introduced a bug to the tests when I used four-space >> indentation locally. >> >> No functional change. > > Wow, this is really painful for the 4-5 open reviews I have outstanding as it > makes a merge disaster. Sorry ;_;… -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346620 - head/tests/sys/opencrypto
Author: ngie
Date: Wed Apr 24 04:40:24 2019
New Revision: 346620
URL: https://svnweb.freebsd.org/changeset/base/346620
Log:
Reapply whitespace style changes from r346443 after recent changes to
tests/sys/opencrypto
From r346443:
"""
Replace hard tabs with four-character indentations, per PEP8.
This is being done to separate stylistic changes from the tests from
functional
ones, as I accidentally introduced a bug to the tests when I used four-space
indentation locally.
No functional change.
"""
MFC after:2 months
Discussed with: jhb
Modified:
head/tests/sys/opencrypto/cryptodev.py
head/tests/sys/opencrypto/cryptotest.py
Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py Wed Apr 24 02:51:58 2019
(r346619)
+++ head/tests/sys/opencrypto/cryptodev.py Wed Apr 24 04:40:24 2019
(r346620)
@@ -35,73 +35,79 @@ import array
import dpkt
from fcntl import ioctl
import os
+import random
import signal
from struct import pack as _pack
+import time
from cryptodevh import *
__all__ = [ 'Crypto', 'MismatchError', ]
class FindOp(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('crid', 'i', 0),
- ('name', '32s', 0),
- )
+__byte_order__ = '@'
+__hdr__ = (
+('crid', 'i', 0),
+('name', '32s', 0),
+)
class SessionOp(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('cipher', 'I', 0),
- ('mac', 'I', 0),
- ('keylen', 'I', 0),
- ('key', 'P', 0),
- ('mackeylen', 'i', 0),
- ('mackey', 'P', 0),
- ('ses', 'I', 0),
- )
+__byte_order__ = '@'
+__hdr__ = (
+('cipher','I', 0),
+('mac', 'I', 0),
+('keylen','I', 0),
+('key', 'P', 0),
+('mackeylen', 'i', 0),
+('mackey','P', 0),
+('ses', 'I', 0),
+)
class SessionOp2(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('cipher', 'I', 0),
- ('mac', 'I', 0),
- ('keylen', 'I', 0),
- ('key', 'P', 0),
- ('mackeylen', 'i', 0),
- ('mackey', 'P', 0),
- ('ses', 'I', 0),
- ('crid', 'i', 0),
- ('pad0', 'i', 0),
- ('pad1', 'i', 0),
- ('pad2', 'i', 0),
- ('pad3', 'i', 0),
- )
+__byte_order__ = '@'
+__hdr__ = (
+('cipher','I', 0),
+('mac', 'I', 0),
+('keylen','I', 0),
+('key', 'P', 0),
+('mackeylen', 'i', 0),
+('mackey','P', 0),
+('ses', 'I', 0),
+('crid', 'i', 0),
+('pad0', 'i', 0),
+('pad1', 'i', 0),
+('pad2', 'i', 0),
+('pad3', 'i', 0),
+)
class CryptOp(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = ( ('ses', 'I', 0),
- ('op', 'H', 0),
- ('flags', 'H', 0),
- ('len', 'I', 0),
- ('src', 'P', 0),
- ('dst', 'P', 0),
- ('mac', 'P', 0),
- ('iv', 'P', 0),
- )
+__byte_order__ = '@'
+__hdr__ = (
+('ses', 'I', 0),
+('op','H', 0),
+('flags', 'H', 0),
+('len', 'I', 0),
+('src', 'P', 0),
+('dst', 'P', 0),
+('mac', 'P', 0),
+('iv','P', 0),
+)
class CryptAEAD(dpkt.Packet):
- __byte_order__ = '@'
- __hdr__ = (
- ('ses', 'I', 0),
- ('op', 'H', 0),
- ('flags', 'H', 0),
- ('len', 'I', 0),
- ('aadlen', 'I', 0),
- ('ivlen', 'I', 0),
- ('src', 'P', 0),
- ('dst', 'P', 0),
- ('aad', 'P', 0),
- ('tag', 'P', 0),
- ('iv', 'P', 0),
- )
+__byte_order__ = '@'
+__hdr__ = (
+('ses','I', 0),
+('op', 'H', 0),
+('flags', 'H', 0),
+('len','I', 0),
+('aadlen', 'I', 0),
+('ivlen', 'I', 0),
+('src','P', 0),
+('dst','P', 0),
+('aad','P', 0),
+('tag','P', 0),
+('iv', 'P', 0),
+)
# h2py.py can't handle multiarg macros
CRIOGET = 3221513060
@@ -116,549 +122,546 @@ CIOCFINDDEV = 3223610220
CIOCCRYPTAEAD = 3225445229
def _getdev():
- fd = os.open('/dev/crypto', os.O_RDWR)
- buf = array.array('I', [0])
- ioctl(fd, CRIOGET, buf, 1)
- os.close(fd)
+fd = os.open('/dev/crypto', os.O_RDWR)
+buf = array.array('I', [0])
+ioctl(fd, CRIOGET, buf, 1)
+os.close(fd)
- return buf[0]
+return buf[0]
svn commit: r346452 - head/tests/sys/opencrypto
Author: ngie
Date: Sat Apr 20 16:37:28 2019
New Revision: 346452
URL: https://svnweb.freebsd.org/changeset/base/346452
Log:
Revert r346443
My wide sweeping stylistic change (while well intended) is impeding others
from
working on `tests/sys/opencrypto`.
The plan is to revert the change in ^/head, then reintroduce the changes after
the other changes get merged into ^/head .
Approved by: emaste (mentor; implicit)
Requested by: jhb
MFC after:2 months
Modified:
head/tests/sys/opencrypto/cryptodev.py
head/tests/sys/opencrypto/cryptotest.py
Modified: head/tests/sys/opencrypto/cryptodev.py
==
--- head/tests/sys/opencrypto/cryptodev.py Sat Apr 20 16:28:06 2019
(r346451)
+++ head/tests/sys/opencrypto/cryptodev.py Sat Apr 20 16:37:28 2019
(r346452)
@@ -43,65 +43,65 @@ from cryptodevh import *
__all__ = [ 'Crypto', 'MismatchError', ]
class FindOp(dpkt.Packet):
-__byte_order__ = '@'
-__hdr__ = ( ('crid', 'i', 0),
-('name', '32s', 0),
-)
+ __byte_order__ = '@'
+ __hdr__ = ( ('crid', 'i', 0),
+ ('name', '32s', 0),
+ )
class SessionOp(dpkt.Packet):
-__byte_order__ = '@'
-__hdr__ = ( ('cipher', 'I', 0),
-('mac', 'I', 0),
-('keylen', 'I', 0),
-('key', 'P', 0),
-('mackeylen', 'i', 0),
-('mackey', 'P', 0),
-('ses', 'I', 0),
-)
+ __byte_order__ = '@'
+ __hdr__ = ( ('cipher', 'I', 0),
+ ('mac', 'I', 0),
+ ('keylen', 'I', 0),
+ ('key', 'P', 0),
+ ('mackeylen', 'i', 0),
+ ('mackey', 'P', 0),
+ ('ses', 'I', 0),
+ )
class SessionOp2(dpkt.Packet):
-__byte_order__ = '@'
-__hdr__ = ( ('cipher', 'I', 0),
-('mac', 'I', 0),
-('keylen', 'I', 0),
-('key', 'P', 0),
-('mackeylen', 'i', 0),
-('mackey', 'P', 0),
-('ses', 'I', 0),
-('crid', 'i', 0),
-('pad0', 'i', 0),
-('pad1', 'i', 0),
-('pad2', 'i', 0),
-('pad3', 'i', 0),
-)
+ __byte_order__ = '@'
+ __hdr__ = ( ('cipher', 'I', 0),
+ ('mac', 'I', 0),
+ ('keylen', 'I', 0),
+ ('key', 'P', 0),
+ ('mackeylen', 'i', 0),
+ ('mackey', 'P', 0),
+ ('ses', 'I', 0),
+ ('crid', 'i', 0),
+ ('pad0', 'i', 0),
+ ('pad1', 'i', 0),
+ ('pad2', 'i', 0),
+ ('pad3', 'i', 0),
+ )
class CryptOp(dpkt.Packet):
-__byte_order__ = '@'
-__hdr__ = ( ('ses', 'I', 0),
-('op', 'H', 0),
-('flags', 'H', 0),
-('len', 'I', 0),
-('src', 'P', 0),
-('dst', 'P', 0),
-('mac', 'P', 0),
-('iv', 'P', 0),
-)
+ __byte_order__ = '@'
+ __hdr__ = ( ('ses', 'I', 0),
+ ('op', 'H', 0),
+ ('flags', 'H', 0),
+ ('len', 'I', 0),
+ ('src', 'P', 0),
+ ('dst', 'P', 0),
+ ('mac', 'P', 0),
+ ('iv', 'P', 0),
+ )
class CryptAEAD(dpkt.Packet):
-__byte_order__ = '@'
-__hdr__ = (
-('ses','I', 0),
-('op','H', 0),
-('flags','H', 0),
-('len','I', 0),
-('aadlen','I', 0),
-('ivlen','I', 0),
-('src','P', 0),
-('dst','P', 0),
-('aad','P', 0),
-('tag','P', 0),
-('iv','P', 0),
-)
+ __byte_order__ = '@'
+ __hdr__ = (
+ ('ses', 'I', 0),
+ ('op', 'H', 0),
+ ('flags', 'H', 0),
+ ('len', 'I', 0),
+ ('aadlen', 'I', 0),
+ ('ivlen', 'I', 0),
+ ('src', 'P', 0),
+ ('dst', 'P', 0),
+ ('aad', 'P', 0),
+ ('tag', 'P', 0),
+ ('iv', 'P', 0),
+ )
# h2py.py can't handle multiarg macros
CRIOGET = 3221513060
@@ -116,445 +116,445 @@ CIOCFINDDEV = 3223610220
CIOCCRYPTAEAD = 3225445229
def _getdev():
-fd = os.open('/dev/crypto', os.O_RDWR)
-buf = array.array('I', [0])
-ioctl(fd, CRIOGET, buf, 1)
-os.close(fd)
+ fd = os.open('/dev/crypto', os.O_RDWR)
+ buf = array.array('I', [0])
+ ioctl(fd, CRIOGET, buf, 1)
+ os.close(fd)
-return buf[0]
+ return buf[0]
_cryptodev = _getdev()
def _findop(crid, name):
-fop = FindOp()
-fop.crid = crid
-fop.name = name
-s = array.array('B', fop.pack_hdr())
-ioctl(_cryptodev, CIOCFINDDEV, s, 1)
-fop.unpack(s)
+ fop = FindOp()
+ fop.crid = crid
+ fop.name = name
+ s = array.array('B', fop.pack_hdr())
+
Re: svn commit: r346358 - in head: . sys/dev/random sys/libkern sys/mips/conf sys/sys
> On Apr 18, 2019, at 13:48, Conrad Meyer wrote: > > Author: cem > Date: Thu Apr 18 20:48:54 2019 > New Revision: 346358 > URL: https://svnweb.freebsd.org/changeset/base/346358 > > Log: > random(4): Restore availability tradeoff prior to r346250 > > As discussed in that commit message, it is a dangerous default. But the > safe default causes enough pain on a variety of platforms that for now, > restore the prior default. > > Some of this is self-induced pain we should/could do better about; for > example, programmatic CI systems and VM managers should introduce entropy > from the host for individual VM instances. This is considered a future work > item. > > On modern x86 and Power9 systems, this may be wholly unnecessary after > D19928 lands (even in the non-ideal case where early /boot/entropy is > unavailable), because they have fast hardware random sources available early > in boot. But D19928 is not yet landed and we have a host of architectures > which do not provide fast random sources. > > This change adds several tunables and diagnostic sysctls, documented > thoroughly in UPDATING and sys/dev/random/random_infra.c. Thank you for doing this Conrad! One request: can these sysctls/tunables please be documented in random(4)? Not everyone has access to UPDATING with binary distributions. Thank you so very much! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346571 - in head: share/examples/tests/tests/tap share/man/man4 share/man/man5 share/zoneinfo/tests usr.bin/calendar/calendars usr.bin/du/tests usr.bin/getconf/tests usr.bin/procstat/
> On Apr 22, 2019, at 1:50 PM, Rodney W. Grimes > wrote: … > It still does not dis-associate mav's copyright with the All rights reserved > clause, > as it appears as if he did an insert of copyright bewteen the 2, thus giving > grey assertion by him of that clause. > > Again, please get mav@ to signoff and I am all happy! Though I would > like it documented in a commit. Hi Alexander, Are you ok with my removing “All rights reserved” from share/man/man4/cfiscsi.4 in r346571? Thank you! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346256 - stable/11/tests/sys/netmap
Author: ngie
Date: Tue Apr 16 01:03:32 2019
New Revision: 346256
URL: https://svnweb.freebsd.org/changeset/base/346256
Log:
MFC r345644,r346061:
r345644 (by olivier):
Skip this test if if_tap module is not available
PR: 236842
r346061:
Polish netmap(4) testcases a bit
1. Not all kernels have netmap(4) support. Check for netmap(4) support before
attempting to run the tests via the `PLAIN_REQUIRE_KERNEL_MODULE(..)`
macro.
2. Libraries shouldn't be added to LDFLAGS; they should be added to LIBADD
instead. This allows the build system to evaluate dependencies for sanity.
3. Sort some of the Makefile variables per bsd.README.
1., in particular, will resolve failures when running this testcase on kernels
lacking netmap(4) support, e.g., the i386 GENERIC kernels on ^/stable/11 and
^/stable/12.
PR: 237129
Modified:
stable/11/tests/sys/netmap/Makefile
stable/11/tests/sys/netmap/ctrl-api-test.c
Directory Properties:
stable/11/ (props changed)
Modified: stable/11/tests/sys/netmap/Makefile
==
--- stable/11/tests/sys/netmap/Makefile Tue Apr 16 00:41:22 2019
(r346255)
+++ stable/11/tests/sys/netmap/Makefile Tue Apr 16 01:03:32 2019
(r346256)
@@ -6,8 +6,10 @@ TESTSDIR= ${TESTSBASE}/sys/netmap
TEST_METADATA+=required_user="root"
TEST_METADATA+=is_exclusive=true
-LDFLAGS+= -lpthread
PLAIN_TESTS_C+=ctrl-api-test
+
+CFLAGS+= -I${SRCTOP}/tests
+LIBADD+= pthread
WARNS?=6
Modified: stable/11/tests/sys/netmap/ctrl-api-test.c
==
--- stable/11/tests/sys/netmap/ctrl-api-test.c Tue Apr 16 00:41:22 2019
(r346255)
+++ stable/11/tests/sys/netmap/ctrl-api-test.c Tue Apr 16 01:03:32 2019
(r346256)
@@ -48,9 +48,15 @@
#include
#include
+#ifdef __FreeBSD__
+#include "freebsd_test_suite/macros.h"
+#endif
+
+
#ifdef __linux__
#include
#else
+
static int
eventfd(int x __unused, int y __unused)
{
@@ -1784,6 +1790,11 @@ main(int argc, char **argv)
int list = 0;
int opt;
int i;
+
+#ifdef __FreeBSD__
+ PLAIN_REQUIRE_KERNEL_MODULE("if_tap", 0);
+ PLAIN_REQUIRE_KERNEL_MODULE("netmap", 0);
+#endif
memset(_, 0, sizeof(ctx_));
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346536 - in stable/12: contrib/elftoolchain contrib/elftoolchain/addr2line contrib/elftoolchain/ar contrib/elftoolchain/common contrib/elftoolchain/cxxfilt contrib/elftoolchain/elfcopy...
Author: ngie Date: Mon Apr 22 08:58:33 2019 New Revision: 346536 URL: https://svnweb.freebsd.org/changeset/base/346536 Log: MFC r339473,r340075,r342918,r343592,r343593,r343614,r343665,r343669: MFC a number of changes to elftoolchain/readelf(1). This brings the copy of elftoolchain more in line with the version in ^/head and partially fixes the issue with `sys.kern.coredump_phnum_test.coredump_phnum` on ^/stable/12. Tested with: make tinderbox r339473 (by emaste): libelf: also test for 64-bit ELF in _libelf_is_mips64el Although _libelf_is_mips64el is only called in contexts where we've already checked that e_class is ELFCLASS64 but this may change in the future. Add a safety belt so that we don't access an invalid e_ehdr64 union member if it does. r340075 (by emaste): readelf: decode R_MIPS_HIGHER and R_MIPS_HIGHEST relocation types r342918 (by emaste): Update to ELF Tool Chain r3668 Highlights: - Make sure that only TLS sections are sorted into TLS segment. - Fixed multiple errors in "Section to Segment mapping". - Man page updates - ar improvements - elfcopy: avoid filter_reloc uninitialized variable for rela - elfcopy: avoid stripping relocations from static binaries - readelf: avoid printing directory in front of absolute path - readelf: add NT_FREEBSD_FEATURE_CTL FreeBSD note type - test improvements NOTES: Some of these changes originated in FreeBSD and simply reduce diffs between contrib and vendor. ELF Tool Chain ar is not (currently) used in FreeBSD, and there are improvements in both FreeBSD and ELF Tool Chain ar that are not in the other. r343592 (by emaste): readelf: decode flag bits in DT_FLAGS/DT_FLAGS_1 Decode d_val when the tag is DT_FLAGS or DT_FLAGS_1 based on the information at: https://docs.oracle.com/cd/E23824_01/html/819-0690/chapter6-42444.html PR: 232983 r343593 (by emaste): readelf: fix i386 build Use %jx and (uintmax_t) cast. PR: 232983 MFC with: r343592 r343614 (by emaste): readelf: dump elf note data Output format is compatible with GNU readelf's handling of unknown note types (modulo a GNU char signedness bug); future changes will add type- specific decoding. Relnotes: Yes r343665 (by emaste): readelf: use table-based DT_FLAGS and DT_FLAGS_1 decoding Fewer lines of code and more maintainable. r343669 (by emaste): readelf: decode FreeBSD note types Decode NT_FREEBSD_ABI_TAG, NT_FREEBSD_ARCH_TAG, and NT_FREEBSD_FEATURE_CTL. Relnotes: Yes Added: stable/12/contrib/elftoolchain/README.rst - copied unchanged from r342918, head/contrib/elftoolchain/README.rst stable/12/contrib/elftoolchain/libelf/libelf_elfmachine.c - copied unchanged from r342918, head/contrib/elftoolchain/libelf/libelf_elfmachine.c Modified: stable/12/contrib/elftoolchain/addr2line/addr2line.1 stable/12/contrib/elftoolchain/addr2line/addr2line.c stable/12/contrib/elftoolchain/ar/ar.1 stable/12/contrib/elftoolchain/ar/ar.5 stable/12/contrib/elftoolchain/ar/ar.c stable/12/contrib/elftoolchain/ar/ar.h stable/12/contrib/elftoolchain/ar/ranlib.1 stable/12/contrib/elftoolchain/ar/read.c stable/12/contrib/elftoolchain/ar/write.c stable/12/contrib/elftoolchain/common/native-elf-format stable/12/contrib/elftoolchain/cxxfilt/c++filt.1 stable/12/contrib/elftoolchain/elfcopy/elfcopy.1 stable/12/contrib/elftoolchain/elfcopy/elfcopy.h stable/12/contrib/elftoolchain/elfcopy/mcs.1 stable/12/contrib/elftoolchain/elfcopy/sections.c stable/12/contrib/elftoolchain/elfcopy/segments.c stable/12/contrib/elftoolchain/elfcopy/strip.1 stable/12/contrib/elftoolchain/libdwarf/dwarf.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_comp_dir.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_const_value_string.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_dataref.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_flag.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_location_expr.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_name.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_producer.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_ref_address.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_reference.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_signed_const.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_string.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_AT_targ_address.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_arange.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_die_to_debug.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_directory_decl.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_expr_addr.3 stable/12/contrib/elftoolchain/libdwarf/dwarf_add_expr_gen.3
Re: svn commit: r346441 - in head/sys/modules: em fusefs iavf
> On Apr 20, 2019, at 9:44 AM, John Baldwin wrote: > > On 4/20/19 6:23 AM, Justin Hibbits wrote: >> On Sat, Apr 20, 2019, 08:21 Alan Somers wrote: >> >>> On Sat, Apr 20, 2019 at 6:58 AM Justin Hibbits >>> wrote: On Sat, Apr 20, 2019, 07:51 Alan Somers wrote: > > Author: asomers > Date: Sat Apr 20 12:51:05 2019 > New Revision: 346441 > URL: https://svnweb.freebsd.org/changeset/base/346441 > > Log: > Use symlinks for kernel modules rather than hardlinks > > When aliasing a kernel module to a different name (ie if_igb for >>> if_em), > it's better to use symlinks than hard links. kldxref will omit >>> entries for > the links, ensuring that the loaded module has the correct name. > > Thanks! This should fix installkernel on my POWER9. - Justin >>> >>> What's the problem with your POWER9? Is that one of those msdosfs >>> /boot systems? If so, I don't think this will fix it. msdosfs >>> doesn't support either symlinks or hardlinks. Or is there some other >>> problem? >>> -Alan >>> >> >> Yes it is. Well that's a bummer then. I thought we faked symlinks on >> msdosfs, but on second thought not sure how well would do that. > > You could just use cp instead of a link? *eyes `install -l`*: -l linkflags Instead of copying the file make a link to the source. The type of the link is determined by the linkflags argument. Valid linkflags are: a (absolute), r (relative), h (hard), s (symbolic), m (mixed). Absolute and relative have effect only for symbolic links. Mixed links are hard links for files on the same filesystem, symbolic otherwise. Cheers, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346443 - head/tests/sys/opencrypto
> On Apr 20, 2019, at 9:31 AM, Enji Cooper wrote: > > >> On Apr 20, 2019, at 9:30 AM, John Baldwin > <mailto:j...@freebsd.org>> wrote: >> >> On 4/20/19 8:43 AM, Enji Cooper wrote: >>> Author: ngie >>> Date: Sat Apr 20 15:43:28 2019 >>> New Revision: 346443 >>> URL: https://svnweb.freebsd.org/changeset/base/346443 >>> <https://svnweb.freebsd.org/changeset/base/346443> >>> >>> Log: >>> tests/sys/opencrypto: fix whitespace per PEP8 >>> >>> Replace hard tabs with four-character indentations, per PEP8. >>> >>> This is being done to separate stylistic changes from the tests from >>> functional >>> ones, as I accidentally introduced a bug to the tests when I used >>> four-space >>> indentation locally. >>> >>> No functional change. >> >> Wow, this is really painful for the 4-5 open reviews I have outstanding as it >> makes a merge disaster. > > Sorry ;_;… Being more constructive: I will back out the change, then reapply it later. Thank you, -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346257 - stable/12/tests/sys/netmap
Author: ngie
Date: Tue Apr 16 01:03:38 2019
New Revision: 346257
URL: https://svnweb.freebsd.org/changeset/base/346257
Log:
MFC r345644,r346061:
r345644 (by olivier):
Skip this test if if_tap module is not available
PR: 236842
r346061:
Polish netmap(4) testcases a bit
1. Not all kernels have netmap(4) support. Check for netmap(4) support before
attempting to run the tests via the `PLAIN_REQUIRE_KERNEL_MODULE(..)`
macro.
2. Libraries shouldn't be added to LDFLAGS; they should be added to LIBADD
instead. This allows the build system to evaluate dependencies for sanity.
3. Sort some of the Makefile variables per bsd.README.
1., in particular, will resolve failures when running this testcase on kernels
lacking netmap(4) support, e.g., the i386 GENERIC kernels on ^/stable/11 and
^/stable/12.
PR: 237129
Modified:
stable/12/tests/sys/netmap/Makefile
stable/12/tests/sys/netmap/ctrl-api-test.c
Directory Properties:
stable/12/ (props changed)
Modified: stable/12/tests/sys/netmap/Makefile
==
--- stable/12/tests/sys/netmap/Makefile Tue Apr 16 01:03:32 2019
(r346256)
+++ stable/12/tests/sys/netmap/Makefile Tue Apr 16 01:03:38 2019
(r346257)
@@ -6,8 +6,10 @@ TESTSDIR= ${TESTSBASE}/sys/netmap
TEST_METADATA+=required_user="root"
TEST_METADATA+=is_exclusive=true
-LDFLAGS+= -lpthread
PLAIN_TESTS_C+=ctrl-api-test
+
+CFLAGS+= -I${SRCTOP}/tests
+LIBADD+= pthread
WARNS?=6
Modified: stable/12/tests/sys/netmap/ctrl-api-test.c
==
--- stable/12/tests/sys/netmap/ctrl-api-test.c Tue Apr 16 01:03:32 2019
(r346256)
+++ stable/12/tests/sys/netmap/ctrl-api-test.c Tue Apr 16 01:03:38 2019
(r346257)
@@ -48,9 +48,15 @@
#include
#include
+#ifdef __FreeBSD__
+#include "freebsd_test_suite/macros.h"
+#endif
+
+
#ifdef __linux__
#include
#else
+
static int
eventfd(int x __unused, int y __unused)
{
@@ -1830,6 +1836,11 @@ main(int argc, char **argv)
int list = 0;
int opt;
int i;
+
+#ifdef __FreeBSD__
+ PLAIN_REQUIRE_KERNEL_MODULE("if_tap", 0);
+ PLAIN_REQUIRE_KERNEL_MODULE("netmap", 0);
+#endif
memset(_, 0, sizeof(ctx_));
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r346150 - head/sys/vm
> On Apr 12, 2019, at 13:10, Tycho Nightingale wrote: > >> On Apr 12, 2019, at 12:43 PM, Enji Cooper wrote: >> >> >>> On Apr 12, 2019, at 5:46 AM, Tycho Nightingale wrote: >>> >>> Author: tychon >>> Date: Fri Apr 12 12:46:25 2019 >>> New Revision: 346150 >>> URL: https://svnweb.freebsd.org/changeset/base/346150 >>> >>> Log: >>> for a cache-only zone the destructor tries to destroy a non-existent keg >>> >>> Reviewed by:markj >>> Sponsored by: Dell EMC Isilon >>> Differential Revision: https://reviews.freebsd.org/D19835 >> >> >> Hi Tycho! >> Is the goal of this change to prevent a panic (with an INVARIANTS >> kernel)? >> Thank you! >> -Enji > > Hi, > > The goal of this change is to fix a regression introduced in r343026. It > does cause a panic independent of INVARIANTS. Fortunately there isn’t > currently any in-tree code which triggers the panic. It does however show up > when running with the patch under review in D19845. Hi again! Thank you for the explanation! This part was missing from the commit message, hence my question. I wanted to make sure I understood the change in this commit properly. Cheers! -Enji ___ svn-src-all@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
svn commit: r346196 - in head/lib/libpmc: . pmu-events
Author: ngie
Date: Sun Apr 14 00:06:49 2019
New Revision: 346196
URL: https://svnweb.freebsd.org/changeset/base/346196
Log:
Fix warnings with lib/libpmc
* Use `MIN` instead of similar hand rolled macro.
* Sort headers.
* Use `errno.h` instead of `sys/errno.h`.
* Wrap the argument to sizeof in parentheses for clarity.
* Remove `__BSD_VISIBLE` and `_XOPEN_SOURCE` #defines to mute warnings about
incompatible snprintf definitions.
This fixes a number of warnings I've been seeing lately in my builds.
Sort makefile variables per style.Makefile(9) (`CFLAGS`/`CWARNFLAG.gcc`) and
bump `WARNS` to 3.
MFC after:2 weeks
Reviewed by: jtl
Approved by: jtl (mentor)
MFC after:1 month
Differential Revision:https://reviews.freebsd.org/D19851
Added:
head/lib/libpmc/Makefile.inc (contents, props changed)
Modified:
head/lib/libpmc/Makefile
head/lib/libpmc/libpmc_json.cc
head/lib/libpmc/pmu-events/jevents.c
head/lib/libpmc/pmu-events/jevents.h
Modified: head/lib/libpmc/Makefile
==
--- head/lib/libpmc/MakefileSat Apr 13 23:52:33 2019(r346195)
+++ head/lib/libpmc/MakefileSun Apr 14 00:06:49 2019(r346196)
@@ -6,9 +6,6 @@ LIB=pmc
SRCS= libpmc.c pmclog.c libpmc_pmu_util.c libpmc_json.cc
INCS= pmc.h pmclog.h pmcformat.h
-CFLAGS+= -I${.CURDIR}
-CWARNFLAGS.gcc+= -Wno-shadow -Wno-cast-align
-
.if ${MACHINE_ARCH} == "amd64" || ${MACHINE_ARCH} == "i386"
.if ${MACHINE_ARCH} == "aarch64"
@@ -30,6 +27,11 @@ libpmc_events.c: ${JEVENTS}
${JEVENTS} ${EVENT_ARCH} ${.CURDIR}/pmu-events/arch libpmc_events.c
SRCS+= libpmc_events.c
.endif
+
+WARNS?=3
+
+CFLAGS+= -I${.CURDIR}
+CWARNFLAGS.gcc+= -Wno-shadow -Wno-cast-align
MAN= pmc.3
MAN+= pmc_allocate.3
Added: head/lib/libpmc/Makefile.inc
==
--- /dev/null 00:00:00 1970 (empty, because file is newly added)
+++ head/lib/libpmc/Makefile.incSun Apr 14 00:06:49 2019
(r346196)
@@ -0,0 +1,3 @@
+# $FreeBSD$
+
+WARNS?=3
Modified: head/lib/libpmc/libpmc_json.cc
==
--- head/lib/libpmc/libpmc_json.cc Sat Apr 13 23:52:33 2019
(r346195)
+++ head/lib/libpmc/libpmc_json.cc Sun Apr 14 00:06:49 2019
(r346196)
@@ -29,19 +29,21 @@
*/
#include
-#include
#include
-#include
-#include
+#include
#include
+#include
#include
+#include
+#include
+#include
#include
-#include
-#include
-#include
#include
#include
+
+#include
#include
+#include
using std::string;
Modified: head/lib/libpmc/pmu-events/jevents.c
==
--- head/lib/libpmc/pmu-events/jevents.cSat Apr 13 23:52:33 2019
(r346195)
+++ head/lib/libpmc/pmu-events/jevents.cSun Apr 14 00:06:49 2019
(r346196)
@@ -1,5 +1,3 @@
-#define _XOPEN_SOURCE 500 /* needed for nftw() */
-#define __BSD_VISIBLE 1/* needed for asprintf() */
/* Parse event JSON files */
/*
@@ -33,22 +31,22 @@
*
*/
-
+#include
+#include /* getrlimit */
+#include
+#include /* getrlimit */
+#include
+#include
+#include
+#include
+#include
+#include
#include
#include
#include
-#include
#include
-#include
#include
-#include
-#include
-#include
-#include
-#include /* getrlimit */
-#include /* getrlimit */
#include
-#include
#include "list.h"
#include "jsmn.h"
#include "json.h"
@@ -641,7 +639,7 @@ int json_events(const char *fn,
addfield(map, _desc, " ",
"(Precise event)", NULL);
}
- snprintf(buf, sizeof buf, "event=%#llx", eventcode);
+ snprintf(buf, sizeof(buf), "event=%#llx", eventcode);
addfield(map, , ",", buf, NULL);
if (desc && extra_desc)
addfield(map, , " ", extra_desc, NULL);
@@ -866,7 +864,7 @@ static int get_maxfds(void)
if (getrlimit(RLIMIT_NOFILE, ) == 0) {
if (rlim.rlim_max == RLIM_INFINITY)
return 512;
- return min((unsigned)rlim.rlim_max / 2, 512);
+ return MIN(rlim.rlim_max / 2, 512);
}
return 512;
Modified: head/lib/libpmc/pmu-events/jevents.h
==
--- head/lib/libpmc/pmu-events/jevents.hSat Apr 13 23:52:33 2019
(r346195)
+++ head/lib/libpmc/pmu-events/jevents.hSun Apr 14 00:06:49 2019
(r346196)
@@ -11,12 +11,4 @@ int json_events(const char *fn,
void *data);
char *get_cpu_str(void);
-#ifndef min
-#define min(x, y) ({
Re: svn commit: r346160 - head/usr.bin/mandoc
> On Apr 12, 2019, at 11:35 AM, Li-Wen Hsu wrote:
>
> Author: lwhsu
> Date: Fri Apr 12 18:35:14 2019
> New Revision: 346160
> URL: https://svnweb.freebsd.org/changeset/base/346160
>
> Log:
> Suppress old gcc warning about null format string
>
> This is workaround to make head build on gcc using architectures
>
> Sponsored by:The FreeBSD Foundation
> MFC-with:r346149
>
> Modified:
> head/usr.bin/mandoc/Makefile
>
> Modified: head/usr.bin/mandoc/Makefile
> ==
> --- head/usr.bin/mandoc/Makefile Fri Apr 12 18:13:57 2019
> (r346159)
> +++ head/usr.bin/mandoc/Makefile Fri Apr 12 18:35:14 2019
> (r346160)
> @@ -97,6 +97,8 @@ SRCS= ${LIB_SRCS} \
> WARNS?= 3
> CFLAGS+= -DHAVE_CONFIG_H \
>-I${SRCTOP}/lib/libopenbsd/
> +# This can be removed after swtiching to newer gcc
> +CFLAGS.gcc+= -Wno-format
> LIBADD= openbsd z
>
> .include
Couldn’t this be fixed upstream and pulled back in, instead of ignoring
the warning?
Cheers,
-Enji
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
