Re: svn commit: r271909 - head/sbin/ping6
On Sat, Sep 20, 2014 at 06:48:51PM +, Hiroki Sato wrote:
Author: hrs
Date: Sat Sep 20 18:48:50 2014
New Revision: 271909
URL: http://svnweb.freebsd.org/changeset/base/271909
Log:
Revert changes in r269180. It could cause -c N option to enter an
infinite loop if no reply packet is received.
r269180 was merged to 10-, 9- and 8-. Maybe it should also be reverted?
Regards
John
PR: 151023
Modified:
head/sbin/ping6/ping6.c
Modified: head/sbin/ping6/ping6.c
==
--- head/sbin/ping6/ping6.c Sat Sep 20 16:43:14 2014(r271908)
+++ head/sbin/ping6/ping6.c Sat Sep 20 18:48:50 2014(r271909)
@@ -1090,14 +1090,8 @@ main(int argc, char *argv[])
/* signal handling */
if (seenalrm) {
/* last packet sent, timeout reached? */
- if (npackets ntransmitted = npackets) {
- struct timeval zerotime = {0, 0};
- itimer.it_value = zerotime;
- itimer.it_interval = zerotime;
- (void)setitimer(ITIMER_REAL, itimer, NULL);
- seenalrm = 0; /* clear flag */
- continue;
- }
+ if (npackets ntransmitted = npackets)
+ break;
retransmit();
seenalrm = 0;
continue;
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r269800 - stable/10/sbin/ping6
Hi Xin,
I have just upgraded one of my boxes to 10-stable and found one of my
scripts just hangs. I traced it to this change in ping6. If you do
ping6 -c 3 machine_that_is_now_dead, ping6 will hang until you
^C it.
Regards
John
On Mon, Aug 11, 2014 at 06:54:07AM +, Xin LI wrote:
Author: delphij
Date: Mon Aug 11 06:54:07 2014
New Revision: 269800
URL: http://svnweb.freebsd.org/changeset/base/269800
Log:
MFC r269180:
When interval is set to very small value with limited amount of packets,
ping6(8) would quit before the remote side gets a chance to respond.
Solve this by resetting the itimer when we have reached the maximum packet
number have reached, but let the other handling to continue.
PR: bin/151023
Submitted by: tjmao at tjmao.net
Modified:
stable/10/sbin/ping6/ping6.c
Directory Properties:
stable/10/ (props changed)
Modified: stable/10/sbin/ping6/ping6.c
==
--- stable/10/sbin/ping6/ping6.c Mon Aug 11 03:04:16 2014
(r269799)
+++ stable/10/sbin/ping6/ping6.c Mon Aug 11 06:54:07 2014
(r269800)
@@ -1090,8 +1090,14 @@ main(int argc, char *argv[])
/* signal handling */
if (seenalrm) {
/* last packet sent, timeout reached? */
- if (npackets ntransmitted = npackets)
- break;
+ if (npackets ntransmitted = npackets) {
+ struct timeval zerotime = {0, 0};
+ itimer.it_value = zerotime;
+ itimer.it_interval = zerotime;
+ (void)setitimer(ITIMER_REAL, itimer, NULL);
+ seenalrm = 0; /* clear flag */
+ continue;
+ }
retransmit();
seenalrm = 0;
continue;
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r263015 - stable/10/release
Author: jhay
Date: Tue Mar 11 12:04:58 2014
New Revision: 263015
URL: http://svnweb.freebsd.org/changeset/base/263015
Log:
MFC r262036
etcupdate should use the src tree from where the release is built, not
the default (/usr/src) tree.
Modified:
stable/10/release/Makefile
Directory Properties:
stable/10/ (props changed)
Modified: stable/10/release/Makefile
==
--- stable/10/release/Makefile Tue Mar 11 10:27:57 2014(r263014)
+++ stable/10/release/Makefile Tue Mar 11 12:04:58 2014(r263015)
@@ -105,7 +105,7 @@ base.txz:
sh ${.CURDIR}/scripts/mm-mtree.sh -m ${WORLDDIR} -F \
TARGET_ARCH=${TARGET_ARCH} TARGET=${TARGET} -D
${.OBJDIR}/${DISTDIR}/base
etcupdate extract -B -M TARGET_ARCH=${TARGET_ARCH} TARGET=${TARGET} \
- -d ${.OBJDIR}/${DISTDIR}/base/var/db/etcupdate
+ -s ${WORLDDIR} -d ${.OBJDIR}/${DISTDIR}/base/var/db/etcupdate
# Package all components
cd ${WORLDDIR} ${IMAKE} packageworld DISTDIR=${.OBJDIR}/${DISTDIR}
mv ${DISTDIR}/*.txz .
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r263016 - stable/9/release
Author: jhay
Date: Tue Mar 11 12:24:19 2014
New Revision: 263016
URL: http://svnweb.freebsd.org/changeset/base/263016
Log:
MFC r262036:
etcupdate should use the src tree from where the release is built, not
the default (/usr/src) tree.
Modified:
stable/9/release/Makefile
Directory Properties:
stable/9/release/ (props changed)
Modified: stable/9/release/Makefile
==
--- stable/9/release/Makefile Tue Mar 11 12:04:58 2014(r263015)
+++ stable/9/release/Makefile Tue Mar 11 12:24:19 2014(r263016)
@@ -105,7 +105,7 @@ base.txz:
sh ${.CURDIR}/scripts/mm-mtree.sh -m ${WORLDDIR} -F \
TARGET_ARCH=${TARGET_ARCH} TARGET=${TARGET} -D
${.OBJDIR}/${DISTDIR}/base
etcupdate extract -B -M TARGET_ARCH=${TARGET_ARCH} TARGET=${TARGET} \
- -d ${.OBJDIR}/${DISTDIR}/base/var/db/etcupdate
+ -s ${WORLDDIR} -d ${.OBJDIR}/${DISTDIR}/base/var/db/etcupdate
# Package all components
cd ${WORLDDIR} ${IMAKE} packageworld DISTDIR=${.OBJDIR}/${DISTDIR}
mv ${DISTDIR}/*.txz .
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r263017 - stable/10/sys/arm/xscale/ixp425
Author: jhay Date: Tue Mar 11 12:58:45 2014 New Revision: 263017 URL: http://svnweb.freebsd.org/changeset/base/263017 Log: MFC r262020: Make it possible to use the env kernel config file option for AVILA and CAMBRIA boards that does not use loader to load the kernel. This is basically how it was done for i386. This way tunables can also be set. For example in config file: env /conf/AVILA.env And in AVILA.env: vfs.unmapped_buf_allowed=0 Modified: stable/10/sys/arm/xscale/ixp425/avila_machdep.c Directory Properties: stable/10/ (props changed) Modified: stable/10/sys/arm/xscale/ixp425/avila_machdep.c == --- stable/10/sys/arm/xscale/ixp425/avila_machdep.c Tue Mar 11 12:24:19 2014(r263016) +++ stable/10/sys/arm/xscale/ixp425/avila_machdep.c Tue Mar 11 12:58:45 2014(r263017) @@ -228,6 +228,8 @@ initarm(struct arm_boot_params *abp) pcpu_init(pcpup, 0, sizeof(struct pcpu)); PCPU_SET(curthread, thread0); + if (envmode == 1) + kern_envp = static_env; /* Do basic tuning, hz etc */ init_param1(); ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r263018 - stable/9/sys/arm/xscale/ixp425
Author: jhay Date: Tue Mar 11 13:03:05 2014 New Revision: 263018 URL: http://svnweb.freebsd.org/changeset/base/263018 Log: MFC r262020: Make it possible to use the env kernel config file option for AVILA and CAMBRIA boards that does not use loader to load the kernel. This is basically how it was done for i386. This way tunables can also be set. For example in config file: env /conf/AVILA.env And in AVILA.env: vfs.unmapped_buf_allowed=0 Modified: stable/9/sys/arm/xscale/ixp425/avila_machdep.c Directory Properties: stable/9/sys/ (props changed) Modified: stable/9/sys/arm/xscale/ixp425/avila_machdep.c == --- stable/9/sys/arm/xscale/ixp425/avila_machdep.c Tue Mar 11 12:58:45 2014(r263017) +++ stable/9/sys/arm/xscale/ixp425/avila_machdep.c Tue Mar 11 13:03:05 2014(r263018) @@ -245,6 +245,8 @@ initarm(void *arg, void *arg2) pcpu_init(pcpup, 0, sizeof(struct pcpu)); PCPU_SET(curthread, thread0); + if (envmode == 1) + kern_envp = static_env; /* Do basic tuning, hz etc */ init_param1(); ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r262020 - head/sys/arm/xscale/ixp425
Author: jhay Date: Mon Feb 17 11:05:57 2014 New Revision: 262020 URL: http://svnweb.freebsd.org/changeset/base/262020 Log: Make it possible to use the env kernel config file option for AVILA and CAMBRIA boards that does not use loader to load the kernel. This is basically how it was done for i386. This way tunables can also be set. For example in config file: env /conf/AVILA.env And in AVILA.env: vfs.unmapped_buf_allowed=0 MFC after:2 weeks Modified: head/sys/arm/xscale/ixp425/avila_machdep.c Modified: head/sys/arm/xscale/ixp425/avila_machdep.c == --- head/sys/arm/xscale/ixp425/avila_machdep.c Mon Feb 17 10:57:06 2014 (r262019) +++ head/sys/arm/xscale/ixp425/avila_machdep.c Mon Feb 17 11:05:57 2014 (r262020) @@ -227,6 +227,8 @@ initarm(struct arm_boot_params *abp) pcpu_init(pcpup, 0, sizeof(struct pcpu)); PCPU_SET(curthread, thread0); + if (envmode == 1) + kern_envp = static_env; /* Do basic tuning, hz etc */ init_param1(); ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r262036 - head/release
Author: jhay
Date: Mon Feb 17 12:29:17 2014
New Revision: 262036
URL: http://svnweb.freebsd.org/changeset/base/262036
Log:
etcupdate should use the src tree from where the release is built, not
the default (/usr/src) tree.
MFC after:2 weeks
Modified:
head/release/Makefile
Modified: head/release/Makefile
==
--- head/release/Makefile Mon Feb 17 12:27:02 2014(r262035)
+++ head/release/Makefile Mon Feb 17 12:29:17 2014(r262036)
@@ -105,7 +105,7 @@ base.txz:
sh ${.CURDIR}/scripts/mm-mtree.sh -m ${WORLDDIR} -F \
TARGET_ARCH=${TARGET_ARCH} TARGET=${TARGET} -D
${.OBJDIR}/${DISTDIR}/base
etcupdate extract -B -M TARGET_ARCH=${TARGET_ARCH} TARGET=${TARGET} \
- -d ${.OBJDIR}/${DISTDIR}/base/var/db/etcupdate
+ -s ${WORLDDIR} -d ${.OBJDIR}/${DISTDIR}/base/var/db/etcupdate
# Package all components
cd ${WORLDDIR} ${IMAKE} packageworld DISTDIR=${.OBJDIR}/${DISTDIR}
mv ${DISTDIR}/*.txz .
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r243228 - head/etc
Hi Chris,
On Sun, Nov 18, 2012 at 02:21:05PM +, Chris Rees wrote:
Author: crees (ports committer)
Date: Sun Nov 18 14:21:05 2012
New Revision: 243228
URL: http://svnweb.freebsd.org/changeset/base/243228
Log:
cp -R misses out dotfiles; use pax instead to copy file hierarchies
PR: conf/99721 (based on)
Submitted by: Florian Zavatzki f_zavat...@blue-network.org
Approved by:hrs
MFC after: 1 month
Modified:
head/etc/rc.initdiskless
Modified: head/etc/rc.initdiskless
==
--- head/etc/rc.initdiskless Sun Nov 18 14:05:28 2012(r243227)
+++ head/etc/rc.initdiskless Sun Nov 18 14:21:05 2012(r243228)
@@ -354,7 +354,7 @@ for i in ${templates} ; do
subdir=${j##*/}
if [ -d $j -a ! -f $j.cpio.gz ]; then
create_md $subdir
- cp -Rp $j/ /$subdir
+ (cd $j pax -rw . /$subdir)
fi
done
for j in /conf/$i/*.cpio.gz ; do
Have you tested this on a diskless and readonly system? It looks like pax
need to write something in /tmp and it might not be writeable yet. I got
an error, after the first of /bin/pax not found and having to add that to
the list of files needed.
John
--
John Hay -- j...@meraka.csir.co.za / j...@freebsd.org
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r238622 - head/etc/rc.d
On Fri, Aug 03, 2012 at 02:28:47PM +0900, Hiroki Sato wrote: John Hay j...@meraka.org.za wrote in 20120803042301.ga78...@zibbi.meraka.csir.co.za: jh While you guys are here, may I add a request that we go back to prefering jh IPv6 when IPv6 addresses are enabled. That is the way it was from FBSD-4 jh up to FBSD-8. 9 is a big POLA here. The world is past World IPv6 Launch jh and I think people expect that if they configure IPv6 addresses, that jh would be prefered. If you configure IPv6 addresses and do not want them jh prefered, you are the odd one out and should have to do something. jh jh Otherwise when in the future are we going to change it? IPv4-preferred was chosen as the default because difference of the loopback performance was large. I am a big fun to make FreeBSD IPv6-capable by default and prefer IPv6, but the concern was a possible negative impact for people who are using only IPv4. So, can we change it for 10.X now? We cannot use whether IPv6 address is configured because ::1 is always configured in GENERIC kernel. The change will be IPv6-preferred if the kernel has INET6 support. Preferring IPv6 addresses has needed a knob in rc.conf even in 4.x: 4.X: ipv6_enable=YES ipv6_ifconfig_em0=2001:db8::1 prefixlen 64 9.X and later: ip6addrctl_policy=ipv6_prefer ifconfig_em0_ipv6=inet6 2001:db8::1 prefixlen 64 and if we change the default to ipv6_prefer, ip6addrctl_policy= line will be unnecessary. I would be happy with ipv6_prefer if the kernel has INET6 in. I wish IPv6 on FreeBSD was even more automatic, though. :-) I can give a recent use case. Last weekend after a lot of preparation a university turned on IPv6 on the whole campus, dorms included. The next morning 30-50% of their traffic was IPv6. The reason being that MS Windows just worked. They are very happy because they do not have to start an extra drive to get the students to turn on IPv6 on their machines. :-) John -- John Hay -- j...@meraka.csir.co.za / j...@freebsd.org ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r238622 - head/etc/rc.d
While you guys are here, may I add a request that we go back to prefering IPv6 when IPv6 addresses are enabled. That is the way it was from FBSD-4 up to FBSD-8. 9 is a big POLA here. The world is past World IPv6 Launch and I think people expect that if they configure IPv6 addresses, that would be prefered. If you configure IPv6 addresses and do not want them prefered, you are the odd one out and should have to do something. Otherwise when in the future are we going to change it? my 2cents John -- John Hay -- j...@meraka.csir.co.za / j...@freebsd.org On Fri, Aug 03, 2012 at 12:43:05PM +0900, Hiroki Sato wrote: Maksim Yevmenkin e...@freebsd.org wrote in CAFPOs6pM8qrR72kOtZzO90wYembNrtzw7=ig-nsfudjza7b...@mail.gmail.com: em of course :) we have ipv4 systems in production that make use of em getaddrinfo(3) api. when a particular dns name is resolved, and, em multiple A records are returned, the results get sorted according to em the default address selection policy. rfc3484 has a set of rules em according to which results should be sorted. all of the rules do not em apply in our case, except one - the rule #9. the idea is that ipv4 em addresses are converted to ipv6 addresses and then longest prefix em match sorting is applied. in other words, if your system ip address em happens to share high bits with the ip address from the A record, the em IP address from the A record will always be preferred. of course, em longest prefix match is performed without any extra information such em as netmask and/or cidr. it really is just matching high bits of the em address. em em so, what we found out, is that some systems tend to favor a particular em ip address (from a bunch of ip addresses returned by name resolution) em because 4 high bits were the same. basically, round-robin dns was em completely shot. Is that issue solved by applying the attached patch and setting net.inet6.ip6.longestmatch_mapped=0? I do not think it is a good idea to use the empty rule to solve it because if the system has to support IPv6 as well the empty rule has negative effect. Adding flag to the IPv4 address line in the policy or adding a sysctl sounds a reasonable solution to me. -- Hiroki ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r236736 - head/sys/dev/puc
Author: jhay
Date: Fri Jun 8 06:07:23 2012
New Revision: 236736
URL: http://svn.freebsd.org/changeset/base/236736
Log:
Add support for the Sunix SER5437A dual serial PCI Express card.
Modified:
head/sys/dev/puc/pucdata.c
Modified: head/sys/dev/puc/pucdata.c
==
--- head/sys/dev/puc/pucdata.c Fri Jun 8 05:54:36 2012(r236735)
+++ head/sys/dev/puc/pucdata.c Fri Jun 8 06:07:23 2012(r236736)
@@ -901,6 +901,12 @@ const struct puc_cfg puc_pci_devices[] =
.config_function = puc_config_syba
},
+ { 0x1fd4, 0x1999, 0x, 0,
+ Sunix SER5437A,
+ DEFAULT_RCLK * 8,
+ PUC_PORT_2S, 0x10, 0, 8,
+ },
+
{0x5372, 0x6873, 0x, 0,
Sun 1040 PCI Quad Serial,
DEFAULT_RCLK,
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r212785 - head/release
Author: jhay Date: Fri Sep 17 07:40:02 2010 New Revision: 212785 URL: http://svn.freebsd.org/changeset/base/212785 Log: Chase the ports list to make snapshots work again with NOPORTS set. Modified: head/release/Makefile.inc.docports Modified: head/release/Makefile.inc.docports == --- head/release/Makefile.inc.docports Fri Sep 17 07:36:32 2010 (r212784) +++ head/release/Makefile.inc.docports Fri Sep 17 07:40:02 2010 (r212785) @@ -26,9 +26,12 @@ MINIMALDOCPORTS= \ MINIMALDOCPORTS+= \ ports/archivers/unzip \ ports/converters/libiconv \ + ports/devel/autoconf267 \ + ports/devel/autoconf-wrapper \ ports/devel/gettext \ ports/devel/gmake \ - ports/devel/libtool15 \ + ports/devel/libtool22 \ + ports/devel/m4 \ ports/devel/pkg-config \ ports/graphics/gd \ ports/graphics/jbigkit \ @@ -37,6 +40,7 @@ MINIMALDOCPORTS+= \ ports/graphics/png \ ports/graphics/scr2png \ ports/graphics/tiff \ + ports/misc/help2man \ ports/print/freetype2 \ ports/print/ghostscript8 \ ports/print/ghostscript8-nox11 \ ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r206215 - in stable/8/sys/modules: em ixgbe
On Mon, Apr 05, 2010 at 10:41:44PM -0700, Jack Vogel wrote: Its been without the if_ prefix for a couple years :) However if enough people's sense of propriety is offended I suppose I could change it. I think because it was not hooked up in modules/Makefile before, it will not be a problem to change it. :-) As for adding it to the modules/Makefile, the main reason it was not was that the users of 10G were very small, but that is changing so I suppose its time to add it. Will take care of that soon. Thanks John Jack On Mon, Apr 5, 2010 at 9:10 PM, John Hay j...@meraka.org.za wrote: Hi Jack, On Mon, Apr 05, 2010 at 09:43:23PM +, Jack F Vogel wrote: Author: jfv Date: Mon Apr 5 21:43:22 2010 New Revision: 206215 URL: http://svn.freebsd.org/changeset/base/206215 Log: Add missing module Makefile for ixgbe and em MFCs Modified: stable/8/sys/modules/em/Makefile stable/8/sys/modules/ixgbe/Makefile I notice that in ixgbe/Makefile KMOD is ixgbe. Should it not be if_ixgbe? Most other network drivers have if_ in front. It is not because of this commit because it is like that in current too. I also see ixgbe is not listed in modules/Makefile, so it will not be built automatically with the rest. Any reason not to add it? Thanks John -- John Hay -- j...@meraka.csir.co.za / j...@freebsd.org ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r206215 - in stable/8/sys/modules: em ixgbe
Hi Jack, On Mon, Apr 05, 2010 at 09:43:23PM +, Jack F Vogel wrote: Author: jfv Date: Mon Apr 5 21:43:22 2010 New Revision: 206215 URL: http://svn.freebsd.org/changeset/base/206215 Log: Add missing module Makefile for ixgbe and em MFCs Modified: stable/8/sys/modules/em/Makefile stable/8/sys/modules/ixgbe/Makefile I notice that in ixgbe/Makefile KMOD is ixgbe. Should it not be if_ixgbe? Most other network drivers have if_ in front. It is not because of this commit because it is like that in current too. I also see ixgbe is not listed in modules/Makefile, so it will not be built automatically with the rest. Any reason not to add it? Thanks John -- John Hay -- j...@meraka.csir.co.za / j...@freebsd.org ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r205024 - head/sys/net
On Thu, Mar 11, 2010 at 03:35:13PM -0800, Juli Mallett wrote: On Thu, Mar 11, 2010 at 15:30, Qing Li qin...@freebsd.org wrote: A couple of questions: (1) It used to be the case that quite a few interface drivers and types didn't have a notion of link up -- especially older ethernet devices. ?Do those all have the same problem? ?It was probably a design oversight that ?devices don't declare an explicit capability for can report link state. ?What you raised is definitely a possibility and these fixes take the ?similar approach. I am going to try and go through each of these ?drivers in /sys/dev/ and converting them, very soon. Go through drivers in the embedded port directories, too. The Octeon port's Ethernet driver was broken by this, and it looks like the Atheros if_arge is probably broken, too. I would even suggest going back to the old behavior briefly while the port maintainers are given an opportunity to update their drivers. Actually, it looks like only MIPS has Ethernet drivers outside of dev/ at a quick glance, but I'd be surprised if there weren't other broken examples. There is also if_npe in the arm/xscale/ixp425 directory and probably others in the rest of the arm directories. John -- John Hay -- j...@meraka.csir.co.za / j...@freebsd.org ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r198376 - head/lib/libusb
Hi,
Any chance that we can get it into 8.0 too? This fix printing with
print/hplip3, which is probably what most people with multi-function
HP printers will use.
John
--
John Hay -- j...@meraka.csir.co.za / j...@freebsd.org
On Thu, Oct 22, 2009 at 09:01:41PM +, Andrew Thompson wrote:
Author: thompsa
Date: Thu Oct 22 21:01:41 2009
New Revision: 198376
URL: http://svn.freebsd.org/changeset/base/198376
Log:
Prevent wraparound of the timeout variable.
Submitted by: HPS
Modified:
head/lib/libusb/libusb20_ugen20.c
Modified: head/lib/libusb/libusb20_ugen20.c
==
--- head/lib/libusb/libusb20_ugen20.c Thu Oct 22 20:59:51 2009
(r198375)
+++ head/lib/libusb/libusb20_ugen20.c Thu Oct 22 21:01:41 2009
(r198376)
@@ -800,7 +800,11 @@ ugen20_tr_submit(struct libusb20_transfe
if (xfer-flags LIBUSB20_TRANSFER_DO_CLEAR_STALL) {
fsep-flags |= USB_FS_FLAG_CLEAR_STALL;
}
- fsep-timeout = xfer-timeout;
+ /* NOTE: The fsep-timeout variable is 16-bit. */
+ if (xfer-timeout 65535)
+ fsep-timeout = 65535;
+ else
+ fsep-timeout = xfer-timeout;
temp.ep_index = xfer-trIndex;
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r196326 - head/sys/boot/i386/gptboot
Author: jhay
Date: Mon Aug 17 15:19:03 2009
New Revision: 196326
URL: http://svn.freebsd.org/changeset/base/196326
Log:
Fix parse() so that the partition to boot (load /boot/loader) from can
be set. The syntax as printed in main() is used: 0:ad(0p3)/boot/loader
Reviewed by: jhb
Approved by: re (kib)
Modified:
head/sys/boot/i386/gptboot/gptboot.c
Modified: head/sys/boot/i386/gptboot/gptboot.c
==
--- head/sys/boot/i386/gptboot/gptboot.cMon Aug 17 14:53:59 2009
(r196325)
+++ head/sys/boot/i386/gptboot/gptboot.cMon Aug 17 15:19:03 2009
(r196326)
@@ -466,16 +466,13 @@ parse(void)
dsk.type = i;
arg += 3;
dsk.unit = *arg - '0';
- if (arg[1] != ',' || dsk.unit 9)
+ if (arg[1] != 'p' || dsk.unit 9)
return -1;
arg += 2;
- dsk.part = -1;
- if (arg[1] == ',') {
- dsk.part = *arg - '0';
- if (dsk.part 1 || dsk.part 9)
- return -1;
- arg += 2;
- }
+ dsk.part = *arg - '0';
+ if (dsk.part 1 || dsk.part 9)
+ return -1;
+ arg++;
if (arg[0] != ')')
return -1;
arg++;
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r196328 - in stable/8/sys: . amd64/include/xen boot/i386/gptboot cddl/contrib/opensolaris contrib/dev/acpica contrib/pf dev/mfi dev/xen/netfront dev/xen/xenpci netipx
Author: jhay
Date: Mon Aug 17 15:39:47 2009
New Revision: 196328
URL: http://svn.freebsd.org/changeset/base/196328
Log:
MFC: 196326
Fix parse() so that the partition to boot (load /boot/loader) from can
be set. The syntax as printed in main() is used: 0:ad(0p3)/boot/loader
Reviewed by: jhb
Approved by: re (kib)
Modified:
stable/8/sys/ (props changed)
stable/8/sys/amd64/include/xen/ (props changed)
stable/8/sys/boot/i386/gptboot/gptboot.c
stable/8/sys/cddl/contrib/opensolaris/ (props changed)
stable/8/sys/contrib/dev/acpica/ (props changed)
stable/8/sys/contrib/pf/ (props changed)
stable/8/sys/dev/mfi/ (props changed)
stable/8/sys/dev/xen/netfront/ (props changed)
stable/8/sys/dev/xen/xenpci/ (props changed)
stable/8/sys/netipx/spx_reass.c (props changed)
Modified: stable/8/sys/boot/i386/gptboot/gptboot.c
==
--- stable/8/sys/boot/i386/gptboot/gptboot.cMon Aug 17 15:39:45 2009
(r196327)
+++ stable/8/sys/boot/i386/gptboot/gptboot.cMon Aug 17 15:39:47 2009
(r196328)
@@ -466,16 +466,13 @@ parse(void)
dsk.type = i;
arg += 3;
dsk.unit = *arg - '0';
- if (arg[1] != ',' || dsk.unit 9)
+ if (arg[1] != 'p' || dsk.unit 9)
return -1;
arg += 2;
- dsk.part = -1;
- if (arg[1] == ',') {
- dsk.part = *arg - '0';
- if (dsk.part 1 || dsk.part 9)
- return -1;
- arg += 2;
- }
+ dsk.part = *arg - '0';
+ if (dsk.part 1 || dsk.part 9)
+ return -1;
+ arg++;
if (arg[0] != ')')
return -1;
arg++;
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn commit: r194811 - head/sys/geom
Author: jhay
Date: Wed Jun 24 06:42:13 2009
New Revision: 194811
URL: http://svn.freebsd.org/changeset/base/194811
Log:
Do not stop the loop when an empty or deleted directory entry is found.
Rather just skip over it.
Modified:
head/sys/geom/geom_redboot.c
Modified: head/sys/geom/geom_redboot.c
==
--- head/sys/geom/geom_redboot.cWed Jun 24 06:15:18 2009
(r194810)
+++ head/sys/geom/geom_redboot.cWed Jun 24 06:42:13 2009
(r194811)
@@ -195,7 +195,9 @@ parse_fis_directory(u_char *buf, size_t
*/
fisdir = redbcfg = NULL;
*(tail = head) = NULL;
- for (i = 0; fd efd fd-name[0] != 0xff; i++, fd++) {
+ for (i = 0; fd efd; i++, fd++) {
+ if (fd-name[0] == 0xff)
+ continue;
if (match(fd-name, FISDIR_NAME))
fisdir = fd;
else if (match(fd-name, REDBCFG_NAME))
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
svn2cvs down? was: svn commit: r193282 - stable/7/sys/libkern
Hi Guys,
Is there something wrong with the svn to cvs gateway? At least this
commit has not pitched on the cvs side. Who should one contact about
it?
John
--
John Hay -- john@meraka.csir.co.za / j...@freebsd.org
On Mon, Jun 01, 2009 at 10:09:42PM +, Kip Macy wrote:
Author: kmacy
Date: Mon Jun 1 22:09:42 2009
New Revision: 193282
URL: http://svn.freebsd.org/changeset/base/193282
Log:
memmove is defined in support.S on arm - don't compile in
Modified:
stable/7/sys/libkern/memmove.c
Modified: stable/7/sys/libkern/memmove.c
==
--- stable/7/sys/libkern/memmove.cMon Jun 1 22:05:08 2009
(r193281)
+++ stable/7/sys/libkern/memmove.cMon Jun 1 22:09:42 2009
(r193282)
@@ -29,6 +29,7 @@ __FBSDID($FreeBSD$);
#include sys/libkern.h
+#if !defined(__arm__)
void *
memmove(void *dest, const void *src, size_t n)
{
@@ -36,3 +37,4 @@ memmove(void *dest, const void *src, siz
bcopy(src, dest, n);
return (dest);
}
+#endif
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
