Re: svn commit: r197286 - head/sys/net
Pawel Jakub Dawidek wrote: On Fri, Sep 18, 2009 at 12:59:49AM +, Bjoern A. Zeeb wrote: On Thu, 17 Sep 2009, Pawel Jakub Dawidek wrote: On Thu, Sep 17, 2009 at 02:52:15PM +, Marko Zec wrote: Author: zec Date: Thu Sep 17 14:52:15 2009 New Revision: 197286 URL: http://svn.freebsd.org/changeset/base/197286 Log: V_irtualize the lltables list, making ARP and ND reasonably usable again with options VIMAGE kernels. Submitted by: bz (the original version, probably identical to this one) Uncommitted for the reason to not interfere with bugfixing for 8.0-R. Reviewed by: many @ DevSummit Cambridge MFC after: 3 days [...] +static void +vnet_lltable_init() +{ + + SLIST_INIT(&V_lltables); +} +VNET_SYSINIT(vnet_lltable_init, SI_SUB_PSEUDO, SI_ORDER_FIRST, vnet_lltable_init, NULL); ANy I didn'thave this style bug;) There is nothing we want to do when vnet is going away? No things will clear itself up via other ways as the interfaces will go away the table will empty itself, etc So I guess it won't hurt to assert on uninit that the list is really empty?:) not a bad idea.. is there already an UNINIT? it may be the only user. ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r197286 - head/sys/net
On Fri, Sep 18, 2009 at 12:59:49AM +, Bjoern A. Zeeb wrote: > On Thu, 17 Sep 2009, Pawel Jakub Dawidek wrote: > > >On Thu, Sep 17, 2009 at 02:52:15PM +, Marko Zec wrote: > >>Author: zec > >>Date: Thu Sep 17 14:52:15 2009 > >>New Revision: 197286 > >>URL: http://svn.freebsd.org/changeset/base/197286 > >> > >>Log: > >> V_irtualize the lltables list, making ARP and ND reasonably > >> usable again with options VIMAGE kernels. > >> > >> Submitted by: bz (the original version, probably identical to this > >> one) > > Uncommitted for the reason to not interfere with bugfixing for 8.0-R. > > >> Reviewed by: many @ DevSummit Cambridge > >> MFC after:3 days > >[...] > >>+static void > >>+vnet_lltable_init() > >>+{ > >>+ > >>+ SLIST_INIT(&V_lltables); > >>+} > >>+VNET_SYSINIT(vnet_lltable_init, SI_SUB_PSEUDO, SI_ORDER_FIRST, > >>vnet_lltable_init, NULL); > > ANy I didn'thave this style bug;) > > >There is nothing we want to do when vnet is going away? > > No things will clear itself up via other ways as the interfaces will > go away the table will empty itself, etc So I guess it won't hurt to assert on uninit that the list is really empty?:) -- Pawel Jakub Dawidek http://www.wheel.pl p...@freebsd.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! pgpk5dgInxX6q.pgp Description: PGP signature
Re: svn commit: r197286 - head/sys/net
On Thu, 17 Sep 2009, Pawel Jakub Dawidek wrote: On Thu, Sep 17, 2009 at 02:52:15PM +, Marko Zec wrote: Author: zec Date: Thu Sep 17 14:52:15 2009 New Revision: 197286 URL: http://svn.freebsd.org/changeset/base/197286 Log: V_irtualize the lltables list, making ARP and ND reasonably usable again with options VIMAGE kernels. Submitted by: bz (the original version, probably identical to this one) Uncommitted for the reason to not interfere with bugfixing for 8.0-R. Reviewed by: many @ DevSummit Cambridge MFC after:3 days [...] +static void +vnet_lltable_init() +{ + + SLIST_INIT(&V_lltables); +} +VNET_SYSINIT(vnet_lltable_init, SI_SUB_PSEUDO, SI_ORDER_FIRST, vnet_lltable_init, NULL); ANy I didn'thave this style bug;) There is nothing we want to do when vnet is going away? No things will clear itself up via other ways as the interfaces will go away the table will empty itself, etc -- Bjoern A. Zeeb What was I talking about and who are you again? ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"
Re: svn commit: r197286 - head/sys/net
On Thu, Sep 17, 2009 at 02:52:15PM +, Marko Zec wrote: > Author: zec > Date: Thu Sep 17 14:52:15 2009 > New Revision: 197286 > URL: http://svn.freebsd.org/changeset/base/197286 > > Log: > V_irtualize the lltables list, making ARP and ND reasonably > usable again with options VIMAGE kernels. > > Submitted by: bz (the original version, probably identical to this > one) > Reviewed by:many @ DevSummit Cambridge > MFC after: 3 days [...] > +static void > +vnet_lltable_init() > +{ > + > + SLIST_INIT(&V_lltables); > +} > +VNET_SYSINIT(vnet_lltable_init, SI_SUB_PSEUDO, SI_ORDER_FIRST, > vnet_lltable_init, NULL); There is nothing we want to do when vnet is going away? -- Pawel Jakub Dawidek http://www.wheel.pl p...@freebsd.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! pgpvdhITLmn09.pgp Description: PGP signature