Re: svn commit: r231220 - head/sys/sys

2012-02-09 Thread Konstantin Belousov
On Wed, Feb 08, 2012 at 11:21:59AM -0800, m...@freebsd.org wrote:
 On Wed, Feb 8, 2012 at 10:36 AM, Konstantin Belousov k...@freebsd.org wrote:
  Author: kib
  Date: Wed Feb  8 18:36:07 2012
  New Revision: 231220
  URL: http://svn.freebsd.org/changeset/base/231220
 
  Log:
   Trim 8 unused bytes from struct vnode on 64-bit architectures.
 
 Doesn't this change the KBI?  So should __FreeBSD_version be bumped?
Definitely, it changes the KBI. This is the reason I did not specified
MFC period (but really wanted it).

We do not track KBI changes on HEAD with __FreeBSD_version. IMO,
__FreeBSD_version is more about KPI, and even for KPI, it is more at the
discretion of the committer and usefulness of notification.

With this change, all VFS modules must be recompiled. But HEAD had a lot
of changes related to VFS interface which went in silently.


pgp7Uc4EkZBQQ.pgp
Description: PGP signature


Re: svn commit: r231220 - head/sys/sys

2012-02-08 Thread mdf
On Wed, Feb 8, 2012 at 10:36 AM, Konstantin Belousov k...@freebsd.org wrote:
 Author: kib
 Date: Wed Feb  8 18:36:07 2012
 New Revision: 231220
 URL: http://svn.freebsd.org/changeset/base/231220

 Log:
  Trim 8 unused bytes from struct vnode on 64-bit architectures.

Doesn't this change the KBI?  So should __FreeBSD_version be bumped?

Thanks,
matthew

 Modified:
  head/sys/sys/vnode.h

 Modified: head/sys/sys/vnode.h
 ==
 --- head/sys/sys/vnode.h        Wed Feb  8 18:22:10 2012        (r231219)
 +++ head/sys/sys/vnode.h        Wed Feb  8 18:36:07 2012        (r231220)
 @@ -149,8 +149,8 @@ struct vnode {
        struct  lock *v_vnlock;                 /* u pointer to vnode lock */
        int     v_holdcnt;                      /* i prevents recycling. */
        int     v_usecount;                     /* i ref count of users */
 -       u_long  v_iflag;                        /* i vnode flags (see below) 
 */
 -       u_long  v_vflag;                        /* v vnode flags */
 +       u_int   v_iflag;                        /* i vnode flags (see below) 
 */
 +       u_int   v_vflag;                        /* v vnode flags */
        int     v_writecount;                   /* v ref count of writers */

        /*
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org