Re: svn commit: r252514 - head/sbin/swapon

2013-07-02 Thread Alexey Dokuchaev 
On Tue, Jul 02, 2013 at 05:34:35PM +, Xin LI wrote:
> New Revision: 252514
> URL: http://svnweb.freebsd.org/changeset/base/252514
> 
> Log:
>   Plug a memory leak.

Is MFC to stable/[89] applicable?  If yes, can it be scheduled? ;-)

./danfe
___
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r252514 - head/sbin/swapon

2013-07-02 Thread Florent Peterschmitt 
Le 02/07/2013 19:34, Xin LI a écrit :
> Author: delphij
> Date: Tue Jul  2 17:34:34 2013
> New Revision: 252514
> URL: http://svnweb.freebsd.org/changeset/base/252514
> 
> Log:
>   Plug a memory leak.
> 
> Modified:
>   head/sbin/swapon/swapon.c
> 
> Modified: head/sbin/swapon/swapon.c
> ==
> --- head/sbin/swapon/swapon.c Tue Jul  2 17:17:42 2013(r252513)
> +++ head/sbin/swapon/swapon.c Tue Jul  2 17:34:34 2013(r252514)

Hi,

Wouldn't be simpler to do a "goto" somewhere in the code to do the
free() and return(NULL) instead of copying those instructions at each case ?

It's just a question.

-- 
Florent Peterschmitt   | Please:
flor...@peterschmitt.fr|  * Avoid HTML/RTF in E-mail.
+33 (0)6 64 33 97 92   |  * Send PDF for documents.
http://florent.peterschmitt.fr | Thank you :)



signature.asc
Description: OpenPGP digital signature