Re: svn commit: r283132 - head/lib/libproc
On 2015-05-19 Tue 22:23:16 + Baptiste Daroussin b...@freebsd.org, wrote: Hi, Author: bapt Date: Tue May 19 22:23:15 2015 New Revision: 283132 URL: https://svnweb.freebsd.org/changeset/base/283132 Log: Fix underlinking Modified: head/lib/libproc/Makefile Modified: head/lib/libproc/Makefile == --- head/lib/libproc/Makefile Tue May 19 22:22:53 2015(r283131) +++ head/lib/libproc/Makefile Tue May 19 22:23:15 2015(r283132) @@ -23,6 +23,8 @@ LIBADD+=cxxrt LIBADD+= supcplusplus .endif +LIBADD+= elf rtld_db util + I have to revert this commit on my CURRENT systems so buildworld can continue. On one such system(r283554): [...] building shared library libproc.so.3 --- all_subdir_libdwarf --- --- libdwarf_elf_init.So --- cc -fpic -DPIC -O2 -pipe -march=bdver2 -I. -I/usr/src/lib/libdwarf/../../contrib/elftoolchain/libdwarf -I/usr/src/lib/libdwarf/../../contrib/elftoolchain/common -I/usr/src/lib/libdwarf/../../contrib/elftoolchain/libelf -std=gnu99 -fstack-protector -Ws ystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subscripts -Winline -Wnested- externs -Wredundant-decls -Wold-style-definition -Wno-pointer-sign -Wmissing-variable-declarations -Wthread-safety -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Qunused-arguments -c /usr/src/lib/libdwarf/../../contrib/elftoolchain/libd warf/libdwarf_elf_init.c -o libdwarf_elf_init.So --- all_subdir_libproc --- cc -fstack-protector -shared -Wl,-x -Wl,--fatal-warnings -Wl,--warn-shared-textrel -o libproc.so.3 -Wl,-soname,libproc.so.3 `NM='nm' lorder proc_bkpt.So proc_create.So proc_regs.So proc_sym.So proc_rtld.So proc_util.So | tsort -q` -lcxxrt -lelf -l rtld_db -lutil --- all_subdir_librt --- --- mq.o --- cc -O2 -pipe -march=bdver2 -I/usr/src/lib/librt/../libc/include -I/usr/src/lib/librt -fexceptions -Winline -Wall -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-stri ng-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Qunused-arguments - c /usr/src/lib/librt/mq.c -o mq.o --- sigev_thread.o --- cc -O2 -pipe -march=bdver2 -I/usr/src/lib/librt/../libc/include -I/usr/src/lib/librt -fexceptions -Winline -Wall -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -Wno-empty-body -Wno-stri ng-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Qunused-arguments - c /usr/src/lib/librt/sigev_thread.c -o sigev_thread.o --- all_subdir_librpcsvc --- --- nfs_prot_xdr.o --- cc -O2 -pipe -march=bdver2 -DYP -I/tmp/bdver2/usr/src/tmp/usr/include/rpcsvc -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-unused-const-variable -Wno-tautological-compare -Wno-unused- value -Wno-parentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -Qunused-arguments -c nfs_prot_xdr.c -o nfs_prot_xdr.o --- all_subdir_libproc --- /tmp/bdver2/usr/src/tmp/usr/bin/ld: cannot find -lrtld_db cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [libproc.so.3] Error code 1 $ cat /etc/make.conf: ALWAYS_CHECK_MAKE=YES CPUTYPE?=corei7-avx DEFAULT_VERSIONS= perl5=5.20 KERNCONF= GENERIC KROPOTKIN KROPOTKIN_DEBUG MALLOC_PRODUCTION= NO_MODULES= PERL5_DEFAULT= 5.20 WITH_PKG= devel $ cat /etc/src.conf WITH_BSD_GREP= WITH_CLANG_EXTRAS= WITH_LLDB= WITH_PIE= #WITH_SORT_THREADS= WITHOUT_AMD= WITHOUT_APM= WITHOUT_ATM= WITHOUT_BLUETOOTH= WITHOUT_CDDL= WITHOUT_CTM= WITHOUT_CUSE= WITHOUT_FDT= WITHOUT_FLOPPY= WITHOUT_FMTREE= WITHOUT_FREEBSD_UPDATE= WITHOUT_FTP= WITHOUT_GCOV= WITHOUT_GDB= WITHOUT_GPL_DTC= WITHOUT_GROFF= WITHOUT_HAST= WITHOUT_HTML= WITHOUT_HYPERV= WITHOUT_INFO= WITHOUT_IPFILTER= WITHOUT_IPFW= WITHOUT_ISCSI= WITHOUT_LEGACY_CONSOLE= WITHOUT_LPR= WITHOUT_NDIS= WITHOUT_NTP= WITHOUT_PC_SYSINSTALL= WITHOUT_PORTSNAP= WITHOUT_PROFILE= WITHOUT_RCMDS= WITHOUT_RCS= WITHOUT_SENDMAIL= WITHOUT_SHAREDOCS= WITHOUT_SVNLITE= WITHOUT_SYSCONS= WITHOUT_SYSINSTALL= WITHOUT_TEXINFO= WITHOUT_TESTS= WITHOUT_TFTP= WITHOUT_WIRELESS= WITHOUT_WPA_SUPPLICANT_EAPOL= Ta very much al -- Smile, Cthulhu Loathes You. ___
Re: svn commit: r283132 - head/lib/libproc
On Tue, May 26, 2015 at 5:07 AM, Alastair Hogge a...@fastmail.fm wrote: On 2015-05-19 Tue 22:23:16 + Baptiste Daroussin b...@freebsd.org, wrote: == --- head/lib/libproc/Makefile Tue May 19 22:22:53 2015(r283131) +++ head/lib/libproc/Makefile Tue May 19 22:23:15 2015(r283132) @@ -23,6 +23,8 @@ LIBADD+=cxxrt LIBADD+= supcplusplus .endif +LIBADD+= elf rtld_db util + I have to revert this commit on my CURRENT systems so buildworld can continue. On one such system(r283554): [..] --- all_subdir_libproc --- /tmp/bdver2/usr/src/tmp/usr/bin/ld: cannot find -lrtld_db cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [libproc.so.3] Error code 1 Same here. make.conf: KERNCONF=TRITON CPUTYPE?=k8-sse3 SVN_UPDATE=y COPTFLAGS=-O2 -pipe MALLOC_PRODUCTION=y src.conf: WITHOUT_AMD=y WITHOUT_APM=y WITHOUT_ASSERT_DEBUG=y WITHOUT_ATM=y WITHOUT_AUTOFS=y WITHOUT_BHYVE=y WITHOUT_BLUETOOTH=y WITHOUT_BOOTPARAMD=y WITHOUT_BOOTPD=y WITHOUT_BSNMP=y WITHOUT_CAPSICUM=y WITHOUT_CASPER=y WITHOUT_CDDL=y WITHOUT_CTM=y WITHOUT_FLOPPY=y WITHOUT_HAST=y WITHOUT_HTML=y WITHOUT_HYPERV=y WITHOUT_IPFILTER=y WITHOUT_ISCSI=y WITHOUT_NDIS=y WITHOUT_PPP=y WITHOUT_PROFILE=y WITHOUT_RBOOTD=y WITHOUT_ROUTED=y WITH_SORT_THREADS=y WITHOUT_TESTS=y WITHOUT_WIRELESS=y Best, Matteo ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
Re: svn commit: r283132 - head/lib/libproc
On Tue, May 26, 2015 at 09:20:39AM -0400, Matteo Riondato wrote: On Tue, May 26, 2015 at 5:07 AM, Alastair Hogge a...@fastmail.fm wrote: On 2015-05-19 Tue 22:23:16 + Baptiste Daroussin b...@freebsd.org, wrote: == --- head/lib/libproc/Makefile Tue May 19 22:22:53 2015(r283131) +++ head/lib/libproc/Makefile Tue May 19 22:23:15 2015(r283132) @@ -23,6 +23,8 @@ LIBADD+=cxxrt LIBADD+= supcplusplus .endif +LIBADD+= elf rtld_db util + I have to revert this commit on my CURRENT systems so buildworld can continue. On one such system(r283554): [..] --- all_subdir_libproc --- /tmp/bdver2/usr/src/tmp/usr/bin/ld: cannot find -lrtld_db cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [libproc.so.3] Error code 1 Same here. make.conf: KERNCONF=TRITON CPUTYPE?=k8-sse3 SVN_UPDATE=y COPTFLAGS=-O2 -pipe MALLOC_PRODUCTION=y src.conf: WITHOUT_AMD=y WITHOUT_APM=y WITHOUT_ASSERT_DEBUG=y WITHOUT_ATM=y WITHOUT_AUTOFS=y WITHOUT_BHYVE=y WITHOUT_BLUETOOTH=y WITHOUT_BOOTPARAMD=y WITHOUT_BOOTPD=y WITHOUT_BSNMP=y WITHOUT_CAPSICUM=y WITHOUT_CASPER=y WITHOUT_CDDL=y WITHOUT_CTM=y WITHOUT_FLOPPY=y WITHOUT_HAST=y WITHOUT_HTML=y WITHOUT_HYPERV=y WITHOUT_IPFILTER=y WITHOUT_ISCSI=y WITHOUT_NDIS=y WITHOUT_PPP=y WITHOUT_PROFILE=y WITHOUT_RBOOTD=y WITHOUT_ROUTED=y WITH_SORT_THREADS=y WITHOUT_TESTS=y WITHOUT_WIRELESS=y Best, Matteo Should be fixed, thanks for reporting Best regards, Bapt pgpfcLGEafOY_.pgp Description: PGP signature
Re: svn commit: r283132 - head/lib/libproc
On Tue, May 26, 2015 at 09:20:39AM -0400, Matteo Riondato wrote: On Tue, May 26, 2015 at 5:07 AM, Alastair Hogge a...@fastmail.fm wrote: On 2015-05-19 Tue 22:23:16 + Baptiste Daroussin b...@freebsd.org, wrote: == --- head/lib/libproc/Makefile Tue May 19 22:22:53 2015(r283131) +++ head/lib/libproc/Makefile Tue May 19 22:23:15 2015(r283132) @@ -23,6 +23,8 @@ LIBADD+=cxxrt LIBADD+= supcplusplus .endif +LIBADD+= elf rtld_db util + I have to revert this commit on my CURRENT systems so buildworld can continue. On one such system(r283554): [..] --- all_subdir_libproc --- /tmp/bdver2/usr/src/tmp/usr/bin/ld: cannot find -lrtld_db cc: error: linker command failed with exit code 1 (use -v to see invocation) *** [libproc.so.3] Error code 1 Same here. make.conf: KERNCONF=TRITON CPUTYPE?=k8-sse3 SVN_UPDATE=y COPTFLAGS=-O2 -pipe MALLOC_PRODUCTION=y src.conf: WITHOUT_AMD=y WITHOUT_APM=y WITHOUT_ASSERT_DEBUG=y WITHOUT_ATM=y WITHOUT_AUTOFS=y WITHOUT_BHYVE=y WITHOUT_BLUETOOTH=y WITHOUT_BOOTPARAMD=y WITHOUT_BOOTPD=y WITHOUT_BSNMP=y WITHOUT_CAPSICUM=y WITHOUT_CASPER=y WITHOUT_CDDL=y WITHOUT_CTM=y WITHOUT_FLOPPY=y WITHOUT_HAST=y WITHOUT_HTML=y WITHOUT_HYPERV=y WITHOUT_IPFILTER=y WITHOUT_ISCSI=y WITHOUT_NDIS=y WITHOUT_PPP=y WITHOUT_PROFILE=y WITHOUT_RBOOTD=y WITHOUT_ROUTED=y WITH_SORT_THREADS=y WITHOUT_TESTS=y WITHOUT_WIRELESS=y Thanks, working on a fix now, this only happens due to WITHOUT_CDDL. Best regards, Bapt pgpBIyTaXHwkC.pgp Description: PGP signature
Re: svn commit: r283132 - head/lib/libproc
On 5/19/15 5:23 PM, Baptiste Daroussin wrote: Author: bapt Date: Tue May 19 22:23:15 2015 New Revision: 283132 URL: https://svnweb.freebsd.org/changeset/base/283132 Log: Fix underlinking I recommend always doing a full clean build when adding or removing libraries to libraries when targetting under/over link problems. Often an exp-run may even make sense. Many library consumers have benefited from overlinking for a long time and no one has realized they were missing direct links. I've added build-time tests into our build at work to force all libraries to not be over or under linked by using -Wl,--no-undefined and tools/build/check-links.sh (this gets tricky with WORLDTMP btw). In most cases of fixing an overlink issue I found that consumers were underlinked. It was a cascading issue. As an update to the clang++ -lm link, I modified it at work to use --as-needed -lm and had no fallout. I need to test build it in FreeBSD and get an exp-run for it. That will make check-links.sh happier on many of the PROG_CXX/LIB_CXX FreeBSD has. As for prebuild_libs, it seems that most of the time it is touched in the past year it is done wrong and without good testing. Please seek out reviews and consider dependencies. The libproc one committed currently is still wrong as it is depending on lib/libc++ (rather than lib/libc++__L) and libproc does not even use libc++, it uses libcxxrt. So it should be depending on libcxxrt__L. Not to mention it actually still errors too due to other bugs in it. -- Regards, Bryan Drewery ___ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to svn-src-all-unsubscr...@freebsd.org
