Re: svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel

[Peter Grehan]

On 8/18/20 6:48 PM, Konstantin Belousov wrote:

On Tue, Aug 18, 2020 at 07:23:47AM +, Peter Grehan wrote:

+void
+vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid)
+{
+   uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX];
+   uint32_t cpuid = PCPU_GET(cpuid);
+
+   if (vmx_have_msr_tsc_aux(vmx) && (guest_tsc_aux != cpuid))

This is quite unobvious place to look at if host TSC_AUX is ever going
to provide something different from cpuid.

Could you please add a comment at
{i386/i386,


 No bhyve on i386.


amd64/amd64}/initcpu.c::initializecpu() around TSC_AUX
settings pointing out this code ?


 Sure, will do.

later,

Peter.
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"

Re: svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel

[Konstantin Belousov]

On Tue, Aug 18, 2020 at 07:23:47AM +, Peter Grehan wrote:
> +void
> +vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid)
> +{
> + uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX];
> + uint32_t cpuid = PCPU_GET(cpuid);
> +
> + if (vmx_have_msr_tsc_aux(vmx) && (guest_tsc_aux != cpuid))
This is quite unobvious place to look at if host TSC_AUX is ever going
to provide something different from cpuid.

Could you please add a comment at
{i386/i386,amd64/amd64}/initcpu.c::initializecpu() around TSC_AUX
settings pointing out this code ?
___
svn-src-all@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscr...@freebsd.org"